--- Log opened Thu Sep 16 00:00:09 2021
00:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9424e78f34da...ec7ec69c7bca
00:14 < bitcoin-git> bitcoin/master 3174425 Hennadii Stepanov: Cleanup headers after #20788
00:14 < bitcoin-git> bitcoin/master ec7ec69 merge-script: Merge bitcoin/bitcoin#22952: Cleanup headers after #20788
00:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:24 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
00:30 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev
00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:32 < bitcoin-git> [bitcoin] fanquake opened pull request #22993: build: set OSX_MIN_VERSION to 10.15 (master...macos_minimum_10_15) https://github.com/bitcoin/bitcoin/pull/22993
00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:41 < bitcoin-git> [bitcoin] fanquake closed pull request #22952: Cleanup headers after #20788 (master...210911-headers) https://github.com/bitcoin/bitcoin/pull/22952
00:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:56 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f389600211f26dee70d7f44.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:03 < bitcoin-git> [bitcoin] fanquake opened pull request #22994: ci: use Debian Bullseye in ARM CI (master...use_bullseye_arm_ci) https://github.com/bitcoin/bitcoin/pull/22994
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:16 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:23 -!- davterra [~davterra@143.198.56.186] has quit [Remote host closed the connection]
01:23 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev
01:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec7ec69c7bca...87780dfee8c8
01:57 < bitcoin-git> bitcoin/master 252d1a7 fanquake: ci: use Debian Bullseye in ARM CI
01:57 < bitcoin-git> bitcoin/master 87780df merge-script: Merge bitcoin/bitcoin#22994: ci: use Debian Bullseye in ARM CI
01:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:17 < bitcoin-git> [bitcoin] fanquake closed pull request #22994: ci: use Debian Bullseye in ARM CI (master...use_bullseye_arm_ci) https://github.com/bitcoin/bitcoin/pull/22994
02:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:20 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
02:20 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
02:34 < darosior> b10c: (sorry to ping you every time in need some stats but) would you happen to have stats about the historical use of CPFP? I'm looking into making the fee estimator CPFP-aware
02:35 < darosior> If you don't i can just make a script it was just in case i can avoid doing it
02:35 < darosior> I expect it to be high
02:47 < laanwj> whoops
02:48 < laanwj> oh #22992 already fixed it
02:48 <@gribble> https://github.com/bitcoin/bitcoin/issues/22992 | Fix Qt test broken by #22219 by ryanofsky · Pull Request #22992 · bitcoin/bitcoin · GitHub
02:57 -!- Yihen [~textual@ab.ptr238.ptrcloud.net] has quit [Remote host closed the connection]
03:35 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
03:50 -!- babasancheti [~babasanch@43.249.232.4] has joined #bitcoin-core-dev
03:53 -!- babasancheti77 [~babasanch@43.249.232.4] has joined #bitcoin-core-dev
03:55 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-dev
03:56 -!- babasancheti [~babasanch@43.249.232.4] has quit [Ping timeout: 256 seconds]
03:57 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
04:08 < b10c> darosior: please continue pining me for stats, that's part of why I collect them! However, I I currently don't have any mempool CPFP stats.  
04:09 < b10c> I guess your script calls `getrawmempool true` and calculates the number of packages and size of packages based on the ancestor and descendant information?
04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:13 < bitcoin-git> [bitcoin] kcalvinalvin opened pull request #22995: doc: Update stale comment about secure allocators. (master...update-stale-allocator-comment) https://github.com/bitcoin/bitcoin/pull/22995
04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:15 < darosior> b10c: i don't have one atm but i was thinking of just crawling the chain and look for each transaction if they have childs in the same block which increase the package feerate. Think it'd be a good enough heuristic
04:16 -!- jespada [~jespada@2803:9800:9842:7a62:e809:3117:30c6:aea3] has joined #bitcoin-core-dev
04:16 < darosior> Maybe on the last 100k blocks it shouldn't take too long (esp. with RCasatta[m]'s awesome block_iterator)
04:23 -!- babasancheti77 [~babasanch@43.249.232.4] has quit [Quit: Client closed]
04:33 -!- babasancheti [~babasanch@43.249.232.4] has joined #bitcoin-core-dev
04:43 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:49 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
04:50 < prayank> darosior: Are you trying to create something like this or add this in Core? https://github.com/djbooth007/cpfp-calculator/
05:03 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
05:07 < darosior> Nope, i will be trying to make CBlockPolicyEstimaor not assume that the first transaction in a chain paid its fees itself. (don't think it'll be hard but i wanted to gather some usage statistics to further motivate this change)
05:07 < darosior> Similar to my PR to re-include replacement txs into estimates
05:09 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
05:23 < prayank> Okay
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:31 < bitcoin-git> [bitcoin] rebroad opened pull request #22996: Better GetHeight() for CTxMemPoolEntry (master...BetterEntryHeight) https://github.com/bitcoin/bitcoin/pull/22996
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:34 < bitcoin-git> [bitcoin] rebroad closed pull request #22996: Better GetHeight() for CTxMemPoolEntry (master...BetterEntryHeight) https://github.com/bitcoin/bitcoin/pull/22996
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:35 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:48 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:52 -!- prayank [~andr0irc@51.158.144.31] has quit [Read error: Connection reset by peer]
05:52 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
05:58 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
05:59 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f389600211f26dee70d7f44.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoin] monstro805 opened pull request #22997: Mergify/monstro805/config update (master...mergify/monstro805/config-update) https://github.com/bitcoin/bitcoin/pull/22997
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:06 < bitcoin-git> [bitcoin] monstro805 closed pull request #22997: Mergify/monstro805/config update (master...mergify/monstro805/config-update) https://github.com/bitcoin/bitcoin/pull/22997
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:16 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/87780dfee8c8...7a999879d2f6
06:16 < bitcoin-git> bitcoin/master 5008dd8 Calvin Kim: doc: Remove stale comment for CPrivKey
06:16 < bitcoin-git> bitcoin/master 7a99987 W. J. van der Laan: Merge bitcoin/bitcoin#22995: doc: Remove stale comment for CPrivKey
06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:17 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 268 seconds]
06:21 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Remote host closed the connection]
06:21 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:28 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22995:  doc: Remove stale comment for CPrivKey (master...update-stale-allocator-comment) https://github.com/bitcoin/bitcoin/pull/22995
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:01 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7a999879d2f6...6d76b57ca0cd
07:01 < bitcoin-git> bitcoin/master fad4f44 MarcoFalke: test: Set peertimeout in write_config
07:01 < bitcoin-git> bitcoin/master 6d76b57 W. J. van der Laan: Merge bitcoin/bitcoin#22960: test: Set peertimeout in write_config
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:01 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer]
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:01 < bitcoin-git> [bitcoin] laanwj merged pull request #22960: test: Set peertimeout in write_config (master...2109-testPeerTimeout) https://github.com/bitcoin/bitcoin/pull/22960
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:02 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev
07:02 -!- jespada [~jespada@2803:9800:9842:7a62:e809:3117:30c6:aea3] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:14 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
07:25 -!- jespada [~jespada@2803:9800:9842:7a62:95e0:d2b5:ae88:676] has joined #bitcoin-core-dev
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d76b57ca0cd...58e02395bad5
07:38 < bitcoin-git> bitcoin/master fac66d0 MarcoFalke: test: Simplify p2p_blocksonly test with new miniwallet rescan_utxos method
07:38 < bitcoin-git> bitcoin/master fa66a7d MarcoFalke: p2p: Rename fBlocksOnly, Add test
07:38 < bitcoin-git> bitcoin/master 58e0239 W. J. van der Laan: Merge bitcoin/bitcoin#22955: p2p: Rename fBlocksOnly, Add test
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:39 < bitcoin-git> [bitcoin] laanwj merged pull request #22955: p2p: Rename fBlocksOnly, Add test (master...2109-testInvBlocksonly) https://github.com/bitcoin/bitcoin/pull/22955
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:39 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22962: Remove unused SERIALIZE_METHODS on CFeeRate (master...2109-noSerFeeRate) https://github.com/bitcoin/bitcoin/pull/22962
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:42 < bitcoin-git> [bitcoin] theStack opened pull request #22998: test: use MiniWallet for make_utxo helper in feature_rbf.py (master...202109-test-use_miniwallet_for_make_utxo) https://github.com/bitcoin/bitcoin/pull/22998
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:48 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
07:52 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:02 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58e02395bad5...cdf12c7b3d71
08:02 < bitcoin-git> bitcoin/master 350e034 Jon Atack: consensus: don't call GetBlockPos in ReadBlockFromDisk without lock
08:02 < bitcoin-git> bitcoin/master cdf12c7 W. J. van der Laan: Merge bitcoin/bitcoin#22895: consensus: don't call GetBlockPos in ReadBloc...
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:02 < bitcoin-git> [bitcoin] laanwj merged pull request #22895: consensus: don't call GetBlockPos in ReadBlockFromDisk without cs_main lock (master...ReadBlockFromDisk-block_pos) https://github.com/bitcoin/bitcoin/pull/22895
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:12 -!- tralfaz is now known as davterra
08:13 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
08:27 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has joined #bitcoin-core-dev
08:30 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
08:32 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
08:33 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has quit [Quit: Client closed]
08:33 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has joined #bitcoin-core-dev
08:39 < provoostenator> I just moved my DNS seed to a new machine. There might be some delay before IPv6 starts behaving.
08:39 < provoostenator> This doesn't work for me yet: dig -6 -t AAAA seed.bitcoin.sprovoost.nl
08:39 < provoostenator> But this does: dig -6 @seed1.bitcoin.sprovoost.nl seed.bitcoin.sprovoost.nl AAAA
08:47 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.2]
08:50 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
09:04 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has quit [Quit: Client closed]
09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:04 < bitcoin-git> [bitcoin] jonatack opened pull request #22999: bench: add `-quiet` and `-iters=<n>` benchmark config args (master...bench-add-quiet-and-iters-args) https://github.com/bitcoin/bitcoin/pull/22999
09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:04 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has joined #bitcoin-core-dev
09:09 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
09:12 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
09:17 -!- babasancheti [~babasanch@43.249.232.4] has quit [Quit: Client closed]
09:30 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has quit [Quit: Client closed]
09:38 < laanwj> provoostenator: same, the first dig command line times out the second one works
09:38 < provoostenator> I made a note to check this again tomorrow,  to make sure it's not a configuration problemm.
09:39 < provoostenator> But for now it just looks like the old NS record is very stubbornly cached by the wider internet,  despite its 1 hour timeout
09:43 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
09:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:45 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cdf12c7b3d71...0de84b732852
09:45 < bitcoin-git> bitcoin/master 75ea9ec Jon Atack: cli -addrinfo: drop torv2, torv3 becomes onion per GetNetworkName()
09:45 < bitcoin-git> bitcoin/master 49d503a Jon Atack: doc: update -addrinfo in release-notes.md and tor.md
09:45 < bitcoin-git> bitcoin/master 0de84b7 W. J. van der Laan: Merge bitcoin/bitcoin#22544: cli -addrinfo: drop torv2; torv3 becomes onio...
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:45 < bitcoin-git> [bitcoin] laanwj merged pull request #22544: cli -addrinfo: drop torv2; torv3 becomes onion per GetNetworkName() (master...rm-torv2-from-addrinfo) https://github.com/bitcoin/bitcoin/pull/22544
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
09:52 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
09:52 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
09:52 -!- yakshaver [yakshaver@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
09:53 -!- yakshaver [~yakshaver@shindig.notmandatory.org] has joined #bitcoin-core-dev
09:54 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev
09:54 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev
10:03 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:04 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0de84b732852...698b4b8fac3d
10:04 < bitcoin-git> bitcoin/master 2ef0acc fanquake: remove --enable-glibc-back-compat from CI and docs
10:04 < bitcoin-git> bitcoin/master 62e45da fanquake: build: remove glibc-back-compat from build system
10:04 < bitcoin-git> bitcoin/master a907704 fanquake: compat: remove glibc_compat.cpp
10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:04 < bitcoin-git> [bitcoin] laanwj merged pull request #22930: build: remove glibc back compat (master...remove_glibc_back_commpat) https://github.com/bitcoin/bitcoin/pull/22930
10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:04 < bitcoin-git> [bitcoin] Sjors opened pull request #23000: net: update signet seeds (master...2021/09/signet-seed) https://github.com/bitcoin/bitcoin/pull/23000
10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:06 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has joined #bitcoin-core-dev
10:10 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Remote host closed the connection]
10:20 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
10:21 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:27 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
10:27 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
10:27 -!- yakshaver [~yakshaver@shindig.notmandatory.org] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
10:31 -!- yakshaver [yakshaver@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev
10:31 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev
10:32 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev
10:51 -!- _aj_ [aj@cerulean.erisian.com.au] has quit [Quit: Lost terminal]
10:51 -!- lightningbot [lightningb@cerulean.erisian.com.au] has quit [Remote host closed the connection]
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:54 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/698b4b8fac3d...71bdf0bff1be
10:54 < bitcoin-git> bitcoin/master fab8900 MarcoFalke: Add missing includes and forward declarations, remove unused ones
10:54 < bitcoin-git> bitcoin/master fae8786 MarcoFalke: doc: Fix validation typo
10:54 < bitcoin-git> bitcoin/master fa20f81 MarcoFalke: Remove txindex migration code
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:54 < bitcoin-git> [bitcoin] laanwj merged pull request #22626: Remove txindex migration code (master...2108-noTxindexMigrate) https://github.com/bitcoin/bitcoin/pull/22626
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:54 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
11:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:10 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/71bdf0bff1be...82a85216c3a3
11:10 < bitcoin-git> bitcoin/master 3ec633e fanquake: build: improve check for ::(w)system
11:10 < bitcoin-git> bitcoin/master 82a8521 W. J. van der Laan: Merge bitcoin/bitcoin#22845: build: improve check for ::(w)system
11:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:10 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
11:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:10 < bitcoin-git> [bitcoin] laanwj merged pull request #22845: build: improve check for ::(w)system (master...dont_literally_use_have_or_have) https://github.com/bitcoin/bitcoin/pull/22845
11:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:17 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/82a85216c3a3...6ef84e050399
11:17 < bitcoin-git> bitcoin/master 5984084 lsilva01: Specifies how to set the value of TORGROUP
11:17 < bitcoin-git> bitcoin/master 6ef84e0 W. J. van der Laan: Merge bitcoin/bitcoin#22420: doc: Specifiy how to set the value of TORGROU...
11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:17 < bitcoin-git> [bitcoin] laanwj merged pull request #22420: doc: Specifiy how to set the value of TORGROUP (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22420
11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:21 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
11:22 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.2.1]
11:23 -!- prayank [~andr0irc@51.15.0.88] has joined #bitcoin-core-dev
11:27 < prayank> I had added some topic for meeting today according to bitcoin core wiki. It's 12 AM here and I want to sleep early today. Shared my thoughts here which most probably would not matter, but better than suggesting a topic and saying nothing: https://gist.github.com/prayank23/e385e31427989c47e715d61556772d02
11:27 -!- prayank [~andr0irc@51.15.0.88] has quit [Remote host closed the connection]
11:38 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
11:54 < laanwj> ok, thanks for the heads up
12:00 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:02 -!- Guest57 [~Guest57@p200300f11704680065032f5638ab4586.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
12:03 -!- aj_ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
12:03 -!- aj_ [aj@cerulean.erisian.com.au] has quit [Changing host]
12:03 -!- aj_ [aj@user/aj/x-5857768] has joined #bitcoin-core-dev
12:03 -!- aj_ is now known as _aj_
12:04 < laanwj> #startmeeting
12:04 < core-meetingbot> Meeting started Thu Sep 16 19:04:00 2021 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:04 < core-meetingbot> Available commands: action commands idea info link nick
12:04 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
12:04 < laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:04 < kvaciral[m]> hi
12:04 < achow101> hi
12:05 < sipsorcery> hi
12:05 < ajonas> hi
12:05 < jonatack> hi
12:05 < laanwj> there was one proposed meeting topic: Use database for `lockunspent` (prayank), but they couldn't be there for the meeting
12:06 < laanwj> any last minute topics?
12:06 < meshcollider> hi
12:06 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
12:06 < ajonas> I had a 5 second thing about a new IRC logger
12:06 < achow101> #proposedmeetingtopic changing CFeeRate rounding
12:07 < laanwj> thanks! let's start with high prio as usual
12:07 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-dev
12:07 < laanwj> #topic High priority for review
12:07 < core-meetingbot> topic: High priority for review
12:07 < b10c> hi
12:08 < laanwj> https://github.com/bitcoin/bitcoin/projects/8  7 blockers, 2 chasing concept ACK at the moment
12:08 < laanwj> anything to add/remove, or that is (almost) ready for merge?
12:08 < sipa> hi
12:08 < amiti> can I have 22950 added? 
12:09 < laanwj> looks like #21859 needs rebase
12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/21859 | Add minisketch subtree and integrate in build/test by sipa · Pull Request #21859 · bitcoin/bitcoin · GitHub
12:09 < jonatack> #21526 likely RFM soon
12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/21526 | validation: UpdateTip/CheckBlockIndex assumeutxo support by jamesob · Pull Request #21526 · bitcoin/bitcoin · GitHub
12:10 < laanwj> amiti: added!
12:10 < laanwj> jonatack: great
12:10 < amiti> thanks :) 
12:12 < laanwj> #topic New IRC logger (ajonas)
12:12 < core-meetingbot> topic: New IRC logger (ajonas)
12:12 < ajonas> Very quick - wanted to point out that Chaincode put up yet another IRC logger -- the twist is that this is searchable.
12:12 < ajonas> https://bitcoin-irc.chaincode.com/
12:12 < ajonas> Feedback welcome.
12:12 < ajonas> That's it
12:12 < laanwj> that's really neat
12:12 < harding> Nice!
12:12 < b10c> bookmarked
12:13 < laanwj> i wonder how we should handle this with the topic
12:13 < sipa> not loading for me. and I'm in the chaincode office...
12:13 < jonatack> nice! insta-pinned
12:13 < harding> We could link to all the logs on the IRC channels wiki page and link that in the topic?
12:13 < laanwj> it's getting quite long we can hardly add another logger url there
12:13 < laanwj> yes, might be a better idea
12:14 < laanwj> also the proposedmeetingtopic lists
12:14 < laanwj> would be more organised than this way, at least
12:14 < laanwj> #topic Changing CFeeRate rounding (achow101)
12:14 < core-meetingbot> topic: Changing CFeeRate rounding (achow101)
12:15 < jonatack> ajonas: not sure the analytics (gaug.es) is needed
12:15 < jonatack> but very cool (thank you!)
12:15 < ajonas> yeah, that's not hooked up to anything
12:15 < ajonas> but happy to remove
12:15 < achow101> currently CFeeRate::GetFee always rounds down (via truncation), but this seems to be incorrect behavior to me, although we have tests for it
12:15 < achow101> it means that at some feerates and sizes, we end up paying a feerate that is less than intended
12:16 -!- Guest57 [~Guest57@p200300f11704680065032f5638ab4586.dip0.t-ipconnect.de] has quit [Quit: Client closed]
12:16 < achow101> this can also lead to an assertion failure in coin selection
12:16 < laanwj> would "always round up" lead to better behavior?
12:16 < achow101> I propose in #22949 that we change to rounding up, but there are concerns that this could affect policy
12:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/22949 | fee: Round up fee calculation to avoid a lower than expected feerate by achow101 · Pull Request #22949 · bitcoin/bitcoin · GitHub
12:17 < achow101> so I just wanted to get more people familiar with policy to have a look at that and figure out whether it would actually affect policy
12:17 < achow101> laanwj: yes. it both avoids the assertion failure, and guarantees that the targeted feerate is being met
12:18 < laanwj> so for policy you'd ideally want to round down, but for the wallet up?
12:18 < laanwj> could make it an explicit flag
12:18 < achow101> I guess? I don't think it actually affects policy since GetFee is only used to get the minrelayfee and incremental relay fee
12:19 < laanwj> if it doesn't affect policy then it's moot
12:19 < achow101> it's a bit odd to me that policy and the wallet would have different behavior for calculating at the same feerate
12:20 < laanwj> well one is for what you want paid, the other is for what you pay, it's different sides of the transaction
12:22 < achow101> I'm pretty sure it has no affect on policy, but I don't know policy well enough to definiteively say so
12:23 < laanwj> ok, that would be something to figure out for sure
12:25 < laanwj> no one else weighing in now, i guess that concludes the topic
12:25 < laanwj> anything else to discuss today?
12:25 < jonatack> hm, few existing tests needed to be updated, given how much functional fee rate testing we have. will review
12:27 < michaelfolkson> Just inform the mailing list that this change is being proposed if it is touching policy? I don't see any bad implications and neither does darosior on that issue you linked achow101
12:28 < laanwj> yes, if it (noticibly) affects policy it would be good to discuss on the ml
12:29 < michaelfolkson> I can't see there being any discussion but good to follow what is most likely best practice going forward
12:30 < laanwj> that concludes the meeting i guess, thanks everyone
12:30 < laanwj> #endmeeting
12:30 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:30 < core-meetingbot> Meeting ended Thu Sep 16 19:30:04 2021 UTC.  
12:30 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-09-16-19.04.moin.txt
12:49 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 268 seconds]
12:51 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
12:51 < jamesob> Hey, is anyone working on a patch for bitcoincoreorg that includes new binary verification instructions based on the aggregate sigs? If not I was going to start on a patch. cc dongcarl harding wumpus BlueMatt
12:54 < harding> Not at the moment, would love your help!
12:55 < achow101> while you're at it, perhaps update contrib/verifybinaries/verify.py
12:55 < BlueMatt> or maybe do that and update bitcoincoreorg to just mention/point to that script?
12:56 < BlueMatt> tho i guess that doesnt help winblowz users
12:56 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
12:58 < jamesob> cool, will get on it. Good idea about verify.py.
12:59 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
12:59 < laanwj> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/bitcoin-core-dev-IRC-information a slightly more organized version of what's in the topic, with the new logger added
12:59 < jamesob> BlueMatt: I would love to know how big the intersection is of people are both running on windows and have a serviceable gpg installation
12:59 < BlueMatt> yea that too lol
12:59 < achow101> there are a bunch of windows pgp/gpg software
13:00 < BlueMatt> achow101: yes, but that make it easy to fetch trusted keys, verify a file, then hash-check other files based on that file?
13:00 < jamesob> achow101: I'm sure the software's there, but users who run it...
13:00 < BlueMatt> you'd also need a sha256sum copy...
13:00 < BlueMatt> and, of people who have all those things, how many dont have python3?
13:01 < laanwj> some people do verify signatures on windows
13:01 < laanwj> manually, with a pgp program
13:01 < jamesob> I'm sure someone in this room has some kind of elaborate cygwin/WSL setup, please chime in :)
13:01 < achow101> windows has a different (GUI I think too) tool for calculating sha256 hashes
13:01 < achow101> no automatic comparison like sha256sum though. I think people just verify the hashes match visually
13:02 < laanwj> yes, it's a more manual process
13:02 < achow101> the old verification docs had windows instructions
13:02 < laanwj> it's always funny how GUIs are supposed to make things easier, but often make for more manual work
13:03 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
13:04 < sipa> gleb7: re your comment about addrman rationale... i do not remember
13:08 < BlueMatt> jamesob: ideally the new script should be something that runs on bitcoincoreorg as well, preventing binaries from being uploaded unless it passes.
13:10 < jamesob> BlueMatt: oh good point
13:11 -!- roconnor [~roconnor@host-45-58-209-171.dyn.295.ca] has joined #bitcoin-core-dev
13:13 < roconnor> has anyone reviewed the implementation of sha256sum?  I've been meaning to do it because I'm somewhat nervious that there exists some sort of obtuse input to it that would trick it into returning a successful comparision somehow.
13:13 < laanwj> wouldn't need to upload binaries at all if bitcoincoreorg could do the guix build :)
13:14 < laanwj> and produce the torrent, i guess
13:14 < BlueMatt> probably could do that too, someone should totally make that happen :p
13:15 < laanwj> roconnor: given how many projects rely on it it'd be a huge CVE if so
13:16 < roconnor> Oh? Do lots of project rely on the sha256sum verificaiton mode?
13:16 < BlueMatt> yes
13:16 < laanwj> that said, i'm not sure it'd be an issue in our case? you *first* check the signatures, if they don't match, you don't verify the sha256sums at all, if the signatures match well... why would everyone sign a sha256sums that contains weird data
13:16 < roconnor> That does make me feel better.
13:17 < laanwj> yes, sha256sums -c is incredibly common in instructions
13:17 < roconnor> okay I feel a little bit better then.
13:18 < laanwj> and if you don't verify the PGP signatures at all and JOLO shasums256, you've not gained any security, because the same attacker replacing binaries could also replace that file
13:19 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
13:22 < roconnor> IIUC at least some of these signers are not using dedicated bitcoin signing keys, and thus may use the same key for signing emails or whatnot.
13:23 < laanwj> yes, but they have to sign the specific file for it to work
13:23 < BlueMatt> at least that way there's usually a pgp verification path, though of course these days its impossible to fetch signed pgp keys anymore cause all th keyservers are dead :(
13:23 < roconnor> I get that it is far fetched, but you just need to get some threshold many of these entities to sign some email that happens to tickle sha256sum -c in some way.
13:24 < roconnor> and, having not looked at sha256sum myself, my prior is that these text tools will correctly verify or report failure on well-formated text files.
13:24 < roconnor> and invoke arbitrary behaviour on non-well-formed text files.
13:24 < BlueMatt> luckily no one uses pgp signing in emails anymore :p
13:25 < laanwj> let alone multiple people signing the same mail
13:26 < laanwj> but sure it's not impossible
13:27 < laanwj> if you're that level of paranoid you should probably run your own guix build and compare against other's output
13:27 < roconnor> For the time being I've been manually checking the sha256sums, so I'm not too worried about becoming tricked by a improperly formated file.
13:30 < roconnor> Just to be clear, I'm not actually worried.  I just want to understand where and how things could fail.
13:31 < laanwj> sure, makes sense
13:32 < harding> shasum on linux has an option to ignore invalid input, which was used on the BitcoinCore.org instructions.  For OSX, there's no such option, and I wonder if you could just insert a line in the SHASUMS file that said "bitcoin-22.0.blah.tar.gz SUCCESS" and make it look like it passed or something.  For the Windows instructions, I think you had to do by-eye verification anyway.
13:32 < roconnor> harding: what is the option?
13:32 < luke-jr> #12677 has 4 ACKs and some doc improvement suggestions; shall I address them and wait on re-acks, or would someone prefer to merge it and I do a followup doc improvement PR?\
13:32 <@gribble> https://github.com/bitcoin/bitcoin/issues/12677 | RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr · Pull Request #12677 · bitcoin/bitcoin · GitHub
13:33 < harding> roconnor: sha256sum --ignore-missing --check SHA256SUMS.asc
13:33 < harding> https://github.com/bitcoin-core/bitcoincore.org/blob/2aeaa478532d93196e51b11f07cc0b066bb99aba/_includes/templates/download.html#L199
13:34 < laanwj> luke-jr: I think it makes sense to address the small remaining comments before merge
13:34 < luke-jr> k
13:35 < laanwj> ignore-missing ignores missing files, which is necessary because the attestation attests to files (like un-codesigned intermediate output, debug files) that aren't shipped in the release
13:36 < harding> Yeah, I guess I misremembered that.  It's actually used on BitcoinCore.org because we expect people to only download the binaries for their arch, so the other files listed in the SHASUMS won't be present (normally).
13:36 < laanwj> (also, someone might not download all the files before verifying)
13:36 < laanwj> right
13:37 < harding> Still, it ends up printing a lot less random crap, which reduces the risk of introduced false positives or negatives.
13:38 < laanwj> it prints the names of skipped files though, what if you call a file bitcoin-22.0.blah.tar.gz-SUCCESS :)
13:38 < laanwj> or, no, it doesn't
13:40 < roconnor> bicoin-22.0: SUCCESS : FAILED :)
13:40 < roconnor> *bitcoin
13:40 < roconnor> can filenames have carriage returns in them?
13:43 < harding> roconnor: in Linux/modern Unixes, yes.  I don't know about how sha256sums handles that, but it brings up the question of whether you can put terminal ANSI escape sequences in a file name
13:43 < sipa> $ echo >$'\n'
13:43 < sipa> seems to work
13:43 < harding> Yeah, I've created files with newlines by mistake lots of times over the years; they're kinda a pain to delete.
13:44 < laanwj> our build system can't handle directories with spaces, please don't try even directories with newlines...
13:46 < laanwj> i guess you can literally have any character in a filename except / and \0
13:46 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
13:47 < roconnor> Can you name a file "bitcoin-0.22: SUCCESS\n"?  I'm having trouble doing this myself?
13:47 < roconnor> er s/SUCCESS/OK ... but anyhow.
13:47 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:47 < laanwj> (will try, in /tmp to make sure the OS cleans it up next reboot)
13:47 < sipa> echo >$'bitcoin-0.22: SUCCESS\n'
13:48 < sipa> $ sha256sum bitcoin*
13:48 < sipa> \01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b  bitcoin-0.22: SUCCESS\n
13:48 < harding> sipa: I think you need echo -e
13:48 < harding> I did: harding@ganymede:~$ touch "/tmp/bitcoin-0.22: SUCCESS^M"
13:48 < harding> harding@ganymede:~$ ls /tmp/bitcoin-0.22\:\ SUCCESS^M 
13:48 < harding> '/tmp/bitcoin-0.22: SUCCESS'$'\r'
13:48 < laanwj> 'bitcoin-0.22: OK'$'\n' that's how ls shos it
13:49 < sipa> harding: only difference is whether the resulting file is empty
13:49 < sipa> harding: oh, no
13:49 < sipa> still doesn't matter i think?
13:49 < harding> Yeah, I think your file has a literal "\n" on the end.
13:49 < sipa> the file or the filename?
13:49 < harding> Filename.
13:49 < roconnor> Thanks.  Doesn't appear to fool sha256sum into printing misleading output.
13:49 < sipa> harding: no
13:50 < roconnor> at least on linux.
13:50 < harding> sipa: That's weird.  echo "\n" prints "\n" here, not a newline.
13:50 < sipa> harding: the filename expansion and redirection is done by the shell
13:50 < sipa> not echo
13:50 < harding> Oh, right.
13:53 -!- mersible [~mersible@92.119.17.210] has joined #bitcoin-core-dev
13:54 < laanwj> echo -e '906acc2401735cef66d0fa0080d3e22c9ae0cb7f65e64ce3dd6cb1df31507a52  \e[1;95mtest' |sha256sum -c
13:54 < laanwj> heh
13:57 < harding> Next time I start to think Bitcion is complicated, I'll have to remember to think about Unix.
13:58 < roconnor> ugh
13:59 < roconnor> that doesn't fill me with confidence.
13:59 < roconnor> I'm going to keep thing purple to remind me to write my own operating system.
14:00 < earnestly> Learning how to deal with filenames potentially containing newlines is far harder than writing your own operating system
14:00 < laanwj> echo -e '906acc2401735cef66d0fa0080d3e22c9ae0cb7f65e64ce3dd6cb1df31507a52  \e[1Abitcoin-core-22.0.tar.gz: OK\e[0J\e[30m'|sha256sum -c
14:00 < sipa> if i ever write an OS, the only allowed filename characters will be 0 and 1
14:01 < laanwj> (it sets the text color to black to hide the text after it, so beware)
14:01 < earnestly> If people want a good, opinionated guide to terminal control sequences, see: http://xn--rpa.cc/irl/term.html
14:03 < laanwj> in any case --ignore-missing prevents this because it won't show the name for the missing file
14:05 < laanwj> earnestly: thanks, i usually use the wikipedia page on 'ansi escape code', but that page is already purple so that's eveb better
14:06 < earnestly> That and console_codes(4) is quite good as it highlights what is ECMA-48 (standard) as well
14:13 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:24 < bitcoin-git> [bitcoin] div72 closed pull request #22975: scripted-diff: update license URLs to https (master...https-copyright-header) https://github.com/bitcoin/bitcoin/pull/22975
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:07 < bitcoin-git> [bitcoin] JeremyRand opened pull request #23001: doc: Enable TLS in links in documentation (master...docs-tls) https://github.com/bitcoin/bitcoin/pull/23001
15:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:07 -!- copumpkin [~woohoo@user/copumpkin] has quit [Quit: Textual IRC Client: www.textualapp.com]
15:09 -!- kappa [~kappa@host-87-14-140-155.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds]
15:21 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds]
15:33 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev
15:49 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Read error: Connection reset by peer]
15:50 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
15:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:54 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
16:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:12 < bitcoin-git> [bitcoin] achow101 opened pull request #23002: Make descriptor wallets by default (master...default-desc-wallets) https://github.com/bitcoin/bitcoin/pull/23002
16:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:22 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
16:34 -!- Guest3710 [~Guest37@host-78-149-15-32.as13285.net] has joined #bitcoin-core-dev
16:34 -!- Guest3710 [~Guest37@host-78-149-15-32.as13285.net] has quit [Client Quit]
16:53 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
16:59 -!- sdaftuar1 [~sdaftuar@user/sdaftuar] has quit [K-Lined]
16:59 -!- cmirror [~cmirror@4.53.92.114] has quit [K-Lined]
16:59 -!- c_arc [~c_arc@4.53.92.114] has quit [K-Lined]
17:17 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
17:20 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 240 seconds]
18:46 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds]
19:19 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 265 seconds]
19:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:37 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6ef84e050399...f7189c4ce950
19:37 < bitcoin-git> bitcoin/master 65ed198 Sebastian Falbesoner: wallet: refactor: inline function ReadOrderPos()
19:37 < bitcoin-git> bitcoin/master 973d8ba Sebastian Falbesoner: wallet: refactor: inline function WriteOrderPos()
19:37 < bitcoin-git> bitcoin/master 98cf19c Sebastian Falbesoner: wallet: refactor: avoid duplicate lookup on `mapValue["timesmart"]`
19:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:37 < bitcoin-git> [bitcoin] fanquake merged pull request #22941: wallet: refactor: inline functions `{Read,Write}OrderPos` (master...202109-refactor-wallet-inline_readwrite_orderpos) https://github.com/bitcoin/bitcoin/pull/22941
19:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:45 < bitcoin-git> [bitcoin] ryanofsky opened pull request #23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const (master...pr/ipc-tapc) https://github.com/bitcoin/bitcoin/pull/23003
19:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:47 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
19:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:47 < bitcoin-git> [bitcoin] ryanofsky opened pull request #23004: multiprocess: Run external signer in wallet not node process (master...pr/ipc-signer) https://github.com/bitcoin/bitcoin/pull/23004
19:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:50 < bitcoin-git> [bitcoin] ryanofsky opened pull request #23005: multiprocess: Delay wallet client construction (master...pr/ipc-client) https://github.com/bitcoin/bitcoin/pull/23005
19:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:01 < bitcoin-git> [bitcoin] ryanofsky opened pull request #23006: multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations (master...pr/ipc-init) https://github.com/bitcoin/bitcoin/pull/23006
20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:04 -!- dviola [~diego@179.235.12.99] has joined #bitcoin-core-dev
20:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:05 < bitcoin-git> [bitcoin] fanquake closed pull request #22936: test: don't try and use os.killpg() on Windows (master...windows_no_killpg) https://github.com/bitcoin/bitcoin/pull/22936
20:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:17 -!- mersible [~mersible@92.119.17.210] has quit [Quit: Leaving]
20:25 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 260 seconds]
20:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:29 < bitcoin-git> [bitcoin] fanquake opened pull request #23007: doc: remove WSL install instructions and point to upstream (master...remove_verbose_WSL_instructions) https://github.com/bitcoin/bitcoin/pull/23007
20:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:37 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
21:21 -!- Guest17 [~Guest17@136.56.128.178] has joined #bitcoin-core-dev
21:23 -!- Guest17 [~Guest17@136.56.128.178] has quit [Client Quit]
21:36 -!- dviola [~diego@179.235.12.99] has quit [Changing host]
21:36 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
21:36 -!- ArctVaulMarsHMPJ [~pjetcetal@2.95.253.167] has joined #bitcoin-core-dev
21:37 -!- ArctVaulMarsHMPJ [~pjetcetal@2.95.253.167] has quit [Read error: Connection reset by peer]
22:07 -!- roconnor [~roconnor@host-45-58-209-171.dyn.295.ca] has quit [Ping timeout: 265 seconds]
22:28 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:37 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds]
22:38 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:43 -!- Victorsueca [~Victorsue@90.165.120.190] has joined #bitcoin-core-dev
22:46 -!- vnogueir- [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds]
23:00 -!- kappa [~kappa@host-79-24-59-35.retail.telecomitalia.it] has joined #bitcoin-core-dev
23:06 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Remote host closed the connection]
23:07 < shiza> `getnewaddress "" p2sh-segwit` or `getnewaddress "" bech32` seem to return P2PKH invoice addresses.
23:13 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:17 -!- babasancheti [~babasanch@43.249.232.4] has joined #bitcoin-core-dev
23:18 < shiza> What's the first walletversion fully supporting P2SH? 
23:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f7189c4ce950...6401de0133e3
23:19 < bitcoin-git> bitcoin/master 1231338 James O'Beirne: doc: test: unittest segfault gdb
23:19 < bitcoin-git> bitcoin/master 6401de0 merge-script: Merge bitcoin/bitcoin#22226: doc: add unittest core dump instructions
23:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:22 < shiza> I used `upgradewallet` without an argument, it seems it upgraded it to 169900, still seeming to be returning P2PKH invoice addresses.
23:26 < shiza> It upgraded to HD without request, does it mean pre-HD keys are lost? 
23:27 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:28 < shiza> I once used importprivkey on a contemporary wallet and it seemed to fail because being HD.
23:36 < shiza> I suppose I will park this wallet as a probably failed upgrade and stay with the pre-upgrade backup for actual use.
23:44 < meshcollider> shiza: upgradewallet won't delete your old keys, they'll still be there, don't worry
23:45 < meshcollider> Why do you think it failed?
23:46 < shiza> meshcollider: Because it apparently returns P2PKH invoice address for `getnewaddress "" p2sh-segwit` or `getnewaddress "" bech32`.
23:46 < shiza> Even after restarting bitcoind.
23:50 < meshcollider> shiza: you probably just need to clear out your keypool to start using the new addresses
23:51 < meshcollider> shiza: just call getnewaddress a bunch of times and it'll start working when all your uncompressed keys are "used"
23:51 < shiza> Oh I understand that, lemme test a thing.
23:52 < shiza> I batched it 2000 times and I now see invoice addresses aparently being P2SH. Thank you very much.
23:54 < shiza> I see nothing apparently being Bech32 or similar, but that doesn't worry me.
23:58 < shiza> Hah, after refilling the key pool, here are Bech32[m] invoice addresses.
23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:58 < bitcoin-git> [bitcoin] fanquake closed pull request #22226: doc: add unittest core dump instructions (master...2021-06-tests-core-dump) https://github.com/bitcoin/bitcoin/pull/22226
23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:59 -!- kabaum [~kabaum@h-46-59-13-35.a163.priv.bahnhof.se] has quit [Ping timeout: 252 seconds]
--- Log closed Fri Sep 17 00:00:10 2021