--- Log opened Mon Sep 20 00:00:13 2021
00:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:08 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:08 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23041: test: Add addrman deserialization error tests (master...2109-testAddrmanDeser) https://github.com/bitcoin/bitcoin/pull/23041
00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:24 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
00:24 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:24 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23042: net: Avoid logging AlreadyHaveTx when disconneting misbehaving peer (master...2109-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/23042
00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:42 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23043: ci: Set --nocleanup for Windows functional tests (master...2109-ciWinCleanup) https://github.com/bitcoin/bitcoin/pull/23043
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:26 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
01:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:45 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
01:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:00 < darosior> achow101: thanks for raising #22949 during the meeting. FWIW another round of review and hacking around with the `tx_pool` fuzzing target gave me more confidence this is not a policy change.
02:00 <@gribble> https://github.com/bitcoin/bitcoin/issues/22949 | fee: Round up fee calculation to avoid a lower than expected feerate by achow101 · Pull Request #22949 · bitcoin/bitcoin · GitHub
02:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:46 < laanwj> luke-jr: is this for the distribution binaries or self-built?
02:48 < laanwj> will try it out on my armhf hw, but useful to know what the build conditions were ... it's weird, i don't think the 32-bit ARM is supposed to do 64-bit loads for crc, because it doesn't have a 64 bit crc isntruction
02:51 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
02:54 < laanwj> so does HAVE_ARM64_CRC32C get set when building for armhf
02:58 < laanwj> These built-in intrinsics for the ARMv8-A CRC32 extension are available when the -march=armv8-a+crc switch is used "uint32_t __crc32d (uint32_t, uint64_t)" Form of expected instruction(s): Two crc32w r0, r0, r0 instructions for AArch32
02:59 < laanwj> so: no, unless somehow that flag is passed to the autoconf test, i think the distro binary is fine
03:00 < laanwj> but it is sneaky that gcc will 'emulate' the 64-bit intrinsic on ARM32
03:01 < laanwj> in any case we need to explicitly check for 64-bit ARM in your build system, the crc32c code is not ARM-specific it is ARM64-specific
03:08 < laanwj> oh crap--I think our detection is entirely wrong, we're detecting 32-bit ARM CRC32 instead of 64-bit?
03:10 < laanwj> configure:17553: checking for ARM CRC32 intrinsics" fails for me on
03:11 < laanwj> arm-unknown-linux-gnueabihf-gcc 10.2.0
03:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:16 < laanwj> PHEW-22.0 armhf distro doesn't contain the instructions: arm-unknown-linux-gnueabihf-objdump -d bitcoind|grep crc32
03:16 < laanwj> and the aarch64 one does
03:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:18 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23044: refactor: Remove unused validation includes (master...2109-valInc) https://github.com/bitcoin/bitcoin/pull/23044
03:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:28 < bitcoin-git> [bitcoin] laanwj opened pull request #23045: build: Restrict check for CRC32C intrinsic to aarch64 (master...2021-09-arm64-crc32) https://github.com/bitcoin/bitcoin/pull/23045
03:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:40 -!- jespada [~jespada@2803:9800:9842:7a62:edd5:5e74:3ec2:1b19] has joined #bitcoin-core-dev
03:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:45 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
03:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:16 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
04:19 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
04:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:07 -!- davterra [~davterra@143.198.56.186] has quit [Ping timeout: 260 seconds]
05:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:26 < sipa> laanwj: ok good
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:27 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23046: test: Add txindex migration test (master...2109-txindexMigrate) https://github.com/bitcoin/bitcoin/pull/23046
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:29 -!- bodhi [~bodhi@c-73-93-87-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
05:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:49 < laanwj> the issue must have been there since we first introduced crc32c, afaik its ARM code has always been the same, and so was our build system check, and it's never been reported before (it's a clear immediate crash) so the conditions where it is accidentally enabled on armhf must be rare
05:52 -!- prayank [~andr0irc@51.158.144.32] has joined #bitcoin-core-dev
05:53 -!- yyaac [~andirc@2400:4052:8383:5c00:f8b8:504:5fa0:6a48] has joined #bitcoin-core-dev
05:54 -!- yyaac [~andirc@2400:4052:8383:5c00:f8b8:504:5fa0:6a48] has quit [Client Quit]
05:58 < prayank> laanwj: Waiting for your response about proxies https://github.com/bitcoin/bitcoin/pull/22959#issuecomment-921094779
05:58 < prayank> My understanding with an example: Consider I am using 127.0.0.1:8080 as proxy, onlynet is not used, proxy remains for all networks but may not work for one or more depending on different things. If onlynet is used, only those networks will be tried to reach via proxy but proxy still remains for all networks. 127.0.0.1:7656 is only used for i2p.
06:02 < sipa> prayank: i don't understand the question
06:04 < prayank> sipa: if an IP address and PORT is mentioned in proxy by user, does it make sense to classify it as only applicable for some networks? 127.0.0.1:7656 being an exception
06:06 < laanwj> prayank: i think that's how it's supposed to be: if you configure a proxy for a certain network and the proxy doesn't work for that network, it will try to use it when connecting out on that, then fail--it definitely shouldn't try connecting outside the proxy, that would be some kind of leak
06:06 < laanwj> a 'the proxy doesn't work let's connect directly' fallback would be really bad. but maybe i'm misunderstanding
06:07 < sipa> prayank: you can configure which network it is for
06:07 < prayank> laanwj: agree
06:08 < ryanofsky> Can add #22976 to high prio since I don't have on there right now?
06:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/22976 | scripted-diff: Rename overloaded int GetArg to GetIntArg by ryanofsky · Pull Request #22976 · bitcoin/bitcoin · GitHub
06:08 < sipa> oh, seems i'm wrong
06:08 < prayank> sipa: I guess that would require more things in config
06:08 < sipa> there is just -proxy and -onion; i thought i saw something to restrict which networks -proxy is for
06:13 -!- Yihen [~textual@153.122.173.2] has joined #bitcoin-core-dev
06:14 < laanwj> prayank: btw please don't take my IRC posts out of context on github this is very stressful
06:16 < prayank> It's not completely out of context. Sorry if it looks wrong but things were related and discussed at several places in which I finally had this conclusion proxies are just proxies and should be used for all networks if possible.
06:18 < laanwj> yes, sure, I understand how it can be somewhat confusing: that's true *if* specified with -proxy, then it's intended to be used as cover-all proxy for all networks (including DNS names), however, network-specific proxies are applied to addresses of a specific network
06:18 < laanwj> and that's the information you get with getnetworkinfo
06:20 < laanwj> name connections (where the network isn't known) are a special case that's outside of the normal per-network proxy handling, names never come from the P2P network but only in special cases (as mentioned in https://github.com/bitcoin/bitcoin/pull/22959#issuecomment-922915197)
06:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:27 < prayank> I think I still believe saying proxy 1 is used for ipv4 only can be misleading. Because it's used for only ipv4 either because you restricted outgoing to ipv4 only or used externalip in config. Proxy can still be used for other networks if user changes config. This might give false information that proxy only works for some networks.
06:27 < laanwj> sipa: there's not currently a way to only set a proxy for ipv4 and not ipv6 or vice versa, theoretically it'd be easy to implement, but the use case doesn't really come up, what almost everyone wants is to set a proxy for everything
06:28 < laanwj> (sometimes including or excluding onion)
06:29 < laanwj> prayank: i don't follow you here, the information returned is exactly what the network code uses
06:29 < sipa> prayank: externalip is completely unrelated; that's about advertising an address for incoming connections
06:29 < sipa> -proxy and -onion are purely about outgoing connections
06:30 < laanwj> all that -getinfo does is format it in a nice way, but it's simply the internal proxy information it gets from getnetworkinfo, that is used by the P2P code
06:30 < jonatack> prayank:  also, remember that -getinfo is only a wrapper for a batch of RPCs, including getnetworkinfo, so the relevant discussion there is on how to present the data they provide.  
06:30 < prayank> laanwj: As a user what would you prefer 1. Proxy 127.0.0.1:9150 (ipv4) 2. Proxy 127.0.0.1:9150 (onlynet=ipv4)
06:30 < jonatack> laanwj: right
06:31 < sipa> prayank: i don't understand what you're trying to convey
06:31 < sipa> onlynet is about which automatic connections are made
06:31 < sipa> proxy is about how to make connections in general, including non-automatic ones
06:34 < prayank> sipa: Networks being associated with a proxy looked incorrect to me but at this point it looks like I am more confused than before so will take some time to try things and comeback in few days with fresh thoughts.
06:35 < prayank> Also it was related to this PR as well: https://github.com/bitcoin-core/gui/pull/421
06:37 < sipa> prayank: internally, every network can have a proxy associated with (plus a separate one for name-based connections). -proxy sets all of them. -onion sets the one for tor hidden services only.
06:38 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
06:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:44 < prayank> sipa: externalip assumption was based on the command shared in end of 'manual' section here which says you can use this if proxy should only work for onion and not ipv4
06:45 < prayank> https://github.com/bitcoin/bitcoin/blob/master/doc/tor.md#3-manually-create-a-bitcoin-core-onion-service
06:45 <@gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
06:46 < sipa> prayank: section 1 is about outgoing connections; 2 and 3 are about incoming
06:49 < prayank> Okay so this is proxy for incoming
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23047: test: Use MiniWallet in mempool_persist (master...2109-testMempool) https://github.com/bitcoin/bitcoin/pull/23047
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:53 < sipa> prayank: there is no such thing as a "proxy for incoming"
06:53 < sipa> -externalip is just telling bitcoind on which address it can be reached, so it can.rumour that address to other peers
06:53 -!- mersible [~mersible@92.119.17.211] has joined #bitcoin-core-dev
06:56 -!- Yihen [~textual@153.122.173.2] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:56 < sipa> because if you manually configure your tor node to have a hidden service for your bitcoind, bitcoind has no way of figuring out what its hidden service address is
07:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:01 < laanwj> right, or when your node is behind a NAT, it's not a proxy-specific option
07:01 < laanwj> (+and manually port-forwarded)
07:04 < sipa> prayank: are you confused about the mention of -proxy in the example in section 3? that's just setting the proxy for outbound connections
07:05 < luke-jr> laanwj: is the 2x crc32w worse for performance?
07:05 < luke-jr> laanwj: and again, 0.21 built and ran tests fine :/
07:06 < laanwj> luke-jr: yes, i think all the instructions execute in the same number of cycles, so doing 64 bits at once is twice as fast
07:07 < sipa> (because it's an example of all the tor related settings to use in such an example)
07:07 < sipa> i guess.i comfused.you by saying section 3 is purely about inbound... the example  are about the whole thing
07:09 < luke-jr> laanwj: but ARM won't be doing 64 bits; if we disable this, it will use plain C?
07:09 < laanwj> luke-jr: it has always used plain C on ARM32, your case is really a strnge misdetection
07:09 < laanwj> the code in crc32c is for 64 bit ARM, it doesn't work for 32-bit
07:12 < laanwj> (it even queries the wrong getauxval bit for the instruction set in src/crc32c/src/crc32c_arm64_check.h if you manage to compile that code for 32-bit, it's all in all, pretty bad)
07:12 < luke-jr> laanwj: crc32c itself doesn't check for aarch64
07:13 < luke-jr> ah, I wonder if that's why it detected it at runtime
07:13 < laanwj> luke-jr: maybe it's an upstream bug then
07:13 < laanwj> in any case, we need to fix itin our own build system, as we don't use theirs
07:13 < luke-jr> right
07:15 < sipa> laanwj: do ARM32 implementations (with necessary extensions) have the same instructions, actually? (perhaps without the 64-bits at once one)?
07:16 < sipa> because maybe it's less work to make (upstream) crc32c actually work propertly on arm32 then
07:16 < laanwj> sipa: yes, but they are extremely rare in the first place
07:16 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
07:16 < sipa> i guess the relevant question is: does any raspberry pi have them>
07:16 < laanwj> crc32c extension was introduced with arm8, which tend to be 64 bit
07:17 < laanwj> luke-jr: does your hardware actually list crc32c in /proc/cpuinfo?
07:17 < prayank> sipa: yes
07:18 < sipa> laanwj: but rpi4 is actually aarch64, but with (iirc) typically a 32-bit OS on it
07:19 < laanwj> sipa: ok well for that case it could work
07:19 < sipa> but apparently with misaligned input...
07:19 < laanwj> if anyone actually has hardware to test i'm happy with making crc32c work on 32-bit ARM instead
07:20 < sipa> i have access to an aarch64 machine (developerbox); i can easily compile in 32-bit mode and test on that
07:20 < laanwj> you'd need to specialize for __arm__: a) getauxval linux bit b) make sure the 64 bit path is ifdef'ed out
07:22 < laanwj> (pretty much exactly like the x86/x86_64 distinction)
07:23 < sipa> yeah
07:23 < sipa> it seems there are a lot of analogies between arm32/aarch64 on the one hand and x86/x86_64 on the other hand
07:23 < luke-jr> laanwj: it will take me hours to find out, but I will check
07:24 < luke-jr> I would expect to find it's aarch64-capable running a 32-bit VM or container
07:24 < laanwj> luke-jr: ok no hurry
07:25 < luke-jr> in any case, separating the bugfix from the feature of adding 32-bit support to it, seem like two different tasks/PRs
07:26 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev
07:27 < sipa> luke-jr: agree
07:27 < laanwj> luke-jr: in any case the /proc/cpuinfo 'features' will be what getauxval(AT_HWCAP*) returns, if there is no crc32c in there then it shouldn't even have tried to go into the hw-accelerated code path
07:27 < laanwj> it's probing the wrong bit which means something completely different on a different architecture
07:28 < laanwj> luke-jr: yes
07:30 < laanwj> my PR (disabling it where we know it's not going to work) is the safe baseline
07:30 < luke-jr> oh, got it faster than expected! http://dpaste.com/5CR5SYJPZ
07:31 < laanwj> Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt lpae evtstrm -- no crc32 :/
07:32  * luke-jr wonders how crc32w is normally detected
07:32 < sipa> getauxval is the correct approach, i think
07:33 -!- Guest3749 [~Guest37@109.128.22.109.rev.sfr.net] has joined #bitcoin-core-dev
07:33 < laanwj> it's a bit in HWCAP2
07:33 < laanwj> looking it up now
07:34 < sipa> Note ID_ISAR5.CRC32 indicates whether this instruction is supported in the T32 and A32 instruction sets. 
07:34 < laanwj> HWCAP2_CRC32
07:34 < laanwj> in getauxval(AT_HWCAP2)
07:35 < luke-jr> strange that /proc/cpuinfo lacks it
07:35 < Guest3749> Hello, I was wondering if the BTCC is on sale and if so where can I buy some? thank you
07:36 < luke-jr> Guest3749: wrong channel. (and note that "BTCC" may be a scam, not related to Bitcoin) further discussion somewhere else please
07:37 < laanwj> in aarch64 it's in AT_HWCAP instead and a different bit (HWCAP_CRC32 = 1<<7) .. that same bit would on ARM32 be HWCAP_EDSP      (1 << 7)
07:37 < laanwj> as you have edsp, that checks out... :)
07:37 < sipa> laanwj: but that doesn't mean the same machine binary opcode is used for edsp and crc32?
07:38 < laanwj> sipa: oh definitely not
07:38 < sipa> right, so it's strange luke is getting a misaligned error
07:38 < sipa> i'd expect an "unknown instruction" or so instead
07:38 < laanwj> wait, the crc* instructions don't access memory at all
07:39 < laanwj> it's the memory fetch before it that gets a SIGBUS
07:39 < sipa> ah
07:39 < laanwj> it doesn't even get to the instruction
07:39 < sipa> right, it's 3 registry operands
07:40 < laanwj> right, i think the code, right now, makes the assumption pointers are 64-bit aligned, which isn't true on 32-bit ARM, so it bolts out even before getting to the instruction itself
07:40 < sipa> 17:07:22 < luke-jr> crc32c/src/crc32c_arm64.cc:101:20: runtime error: load of misaligned address 0x06d96d36 for type 'uint64_t', which requires 8 byte
07:40 < sipa> that's not even 4-byte aligned!
07:40 < laanwj> heeh
07:40 < luke-jr> XD
07:40 < Guest3749> no answer to my question? must we mine BTCC OR can we buy it somewhere? Thank you for answering me.
07:41 < sipa> Guest3749: off topic, sorry
07:45 < prayank> Guest3749: Where did you get the link for this IRC channel?
07:48 < Guest3749> I am also a developer. there is the irc on the website, then i dont know why even if it is not the right place why no one just answers my question. or buy BTCC, simple question.
07:50 < sipa> Guest3749: this channel is about the development of the bitcoin core software; anything else is off-topic; last warning
07:50 < luke-jr> Guest3749: even if someone knows, they respect the topic of the channel and won't answer here.
07:52 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
07:53 < Guest3749> so you are idiots ... in the street if someone asks you the time when you are going to buy bread i hope you will answer him anyway .. not like saying no i am going to get my bread there is none report. answer a simple question and move on. anyway, the mentality is pretty low for dev.
07:55 -!- mode/#bitcoin-core-dev [+b Guest3749!*@*] by ChanServ
07:55 -!- Guest3749 was kicked from #bitcoin-core-dev by ChanServ [Banned: off-topic]
08:01 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
08:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:13 < laanwj> that escalated quickly
08:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:24 -!- davterra [~davterra@143.198.56.186] has quit [Quit: Leaving]
08:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:34 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-core-dev
08:34 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has quit [Client Quit]
08:35 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-core-dev
08:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:49 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/226731ac1144...d809d8bf1264
08:49 < bitcoin-git> bitcoin/master 7c3712f klementtan: cli: Display all proxies in -getinfo
08:49 < bitcoin-git> bitcoin/master d809d8b W. J. van der Laan: Merge bitcoin/bitcoin#22959: cli: Display all proxies in -getinfo
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:49 < bitcoin-git> [bitcoin] laanwj merged pull request #22959: cli: Display all proxies in -getinfo (master...getinfo-multiple-proxies) https://github.com/bitcoin/bitcoin/pull/22959
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:49 < luke-jr> laanwj: why couldn't it have worked previously? O.o
08:50 < luke-jr> if you had edsp and crc32 stuff?
08:51 < laanwj> because the code is broken for ARM64
08:51 < laanwj> eh, for ARM32, it works only for ARM64
08:53 < luke-jr> depends on the source of the unalignment? :P
08:53 < laanwj> come on... it's clear from various things that that code was never qualified for ARM32 in any way
08:54 < luke-jr> sure, but it did apparently work in 0.21
08:54 < laanwj> why do you think that?
08:54 < luke-jr> I didn't encounter this failure until 22.0
08:55 < luke-jr> noteworthy, only on Ubuntu impish
08:55 < laanwj> because the check worked before, something changed in your build environment
08:55 < luke-jr> I suppose it's possible
08:55 < laanwj> for the release binaries and everyone else's build env, it failed that build system check on armhf so the issue never comes up
08:55 < laanwj> crc32 doesn't even *work* on your CPU, it's not in /proc/cpusinfo
08:56 < laanwj> even separately from the architecture misdetection
08:57 < laanwj> if it'd actually execute one of the crc32c* instructions it'd give SIGILL, if it wouldn't have failed on the alignment issue before
08:58 < luke-jr> you're right
08:58 < luke-jr> grepped the 0.21 binaries for crc32 yielded nothing
08:59 -!- klementtan [~klementta@218.212.82.3] has joined #bitcoin-core-dev
08:59 < luke-jr> eh, but neither do the arm64 bins
09:00 < laanwj> interesting
09:01 < sipa> did we recently update libcrc32c?
09:01 < laanwj> or maybe the compiler used previously didn't know the intrinsics
09:02 < luke-jr> found _ZN6crc32c11ExtendArm64EjPKhm in arm64 debug symbol file, but absent in armhf
09:02 < luke-jr> laanwj: hard to be sure, since impish is still evolving
09:02 < luke-jr> sipa: yes, but nothing significant in there from what I saw
09:04 < luke-jr> laanwj: anyway, my ACK is simply waiting on the build to finish ;)
09:04 < luke-jr> might be nice to get ARM32 supported since it seems reasonably common, but I don't have a Pi4 to try with at the moment
09:11 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev
09:13 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
09:15 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
09:17 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
09:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:24 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
09:27 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
09:28 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
09:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:36 < luke-jr> fanquake: found a bug in your merged PR https://github.com/bitcoin/bitcoin/pull/22859#discussion_r712334971 maybe fix?
09:37 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
09:39 < laanwj> does Rpi4 have CRC32 instructions? i don't have one
09:41 < sipa> it does: https://www.raspberrypi.org/forums/viewtopic.php?t=243882
09:42 < laanwj> wait i do have a Odroid-C2 which has them, but it's used for something important i can't just install another OS on it, does 32-bit software run on 64-bit ARM? i don't remember
09:42 < sipa> it does
09:43 < sipa> either by having a full 32-bit OS only, or if you have 32-bit userspace libraries installed
09:43 < sipa> same as with x86_64/x86
09:44 < laanwj> right, i didn't know for sure because it's not like that for riscv32/64
09:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:46 < bitcoin-git> [bitcoin] Fi3 opened pull request #23049: net: implement a StratumV2 Template Provider in core (master...add_sv2) https://github.com/bitcoin/bitcoin/pull/23049
09:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:59 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
09:59 < laanwj> it indeed looks like "dpkg --add-architecture armhf && apt update && apt install libc6:armhf" is enough to run armhf release bitcoin-cli on aarch64 host
10:01 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
10:02 < laanwj> no need to install a 32-bit OS
10:03 < laanwj> although i haven't checked yet what the AT_HWCAP flags look like, i'd guess they'd be passed correctly to 32-bit userspace though, and that the same extension instruction sets are available
10:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:10 < luke-jr> #12677 & #22974 look rtm
10:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/12677 | RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr · Pull Request #12677 · bitcoin/bitcoin · GitHub
10:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/22974 | addrman: Improve performance of Good by mzumsande · Pull Request #22974 · bitcoin/bitcoin · GitHub
10:13 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
10:16 < laanwj> ... getauxval(AT_HWCAP2)=0x00000010 looks like it, as expected, getauxval in a 32-bit binary on 64-bit ARM returns the correct value for 32-bit ARM, and also, 1<<4 (HWCAP2_CRC32) is available in 32-bit mode
10:18 < laanwj> luke-jr: will take a look
10:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:26 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d809d8bf1264...488e7455608d
10:26 < bitcoin-git> bitcoin/master 3f77dfd Luke Dashjr: Expose ancestorsize and ancestorfees via getTransactionAncestry
10:26 < bitcoin-git> bitcoin/master 6966e80 Luke Dashjr: RPC: Add ancestor{count,size,fees} to listunspent output
10:26 < bitcoin-git> bitcoin/master 0be2f17 Luke Dashjr: QA: Add tests for listunspent ancestor{count,size,fees} to mempool_packages
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:26 < bitcoin-git> [bitcoin] laanwj merged pull request #12677: RPC: Add ancestor{count,size,fees} to listunspent output (master...listunspent_ancestorinfo) https://github.com/bitcoin/bitcoin/pull/12677
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:27 -!- first_mersible [~mersible@92.119.17.210] has joined #bitcoin-core-dev
10:29 -!- dongcarl [~dongcarl@70.107.207.192] has quit [Ping timeout: 260 seconds]
10:29 -!- dongcarl [~dongcarl@70.107.207.192] has joined #bitcoin-core-dev
10:29 -!- mersible [~mersible@92.119.17.211] has quit [Ping timeout: 246 seconds]
10:31 -!- dongcarl1 [~dongcarl@70.107.207.192] has joined #bitcoin-core-dev
10:34 -!- dongcarl [~dongcarl@70.107.207.192] has quit [Ping timeout: 246 seconds]
10:34 -!- dongcarl1 is now known as dongcarl
10:35 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
10:40 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 264 seconds]
10:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:45 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:48 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/488e7455608d...7f7bd3111cdc
10:48 < bitcoin-git> bitcoin/master eb2e113 Martin Zumsande: addrman: Improve performance of Good
10:48 < bitcoin-git> bitcoin/master acf656d Martin Zumsande: fuzz: Use public interface to fill addrman tried tables
10:48 < bitcoin-git> bitcoin/master 57ce203 Martin Zumsande: fuzz: allow lower number of sources
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:48 < bitcoin-git> [bitcoin] laanwj merged pull request #22974: addrman: Improve performance of Good (master...202109_goodspeed) https://github.com/bitcoin/bitcoin/pull/22974
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [bitcoin] jb55 closed pull request #18985: bloom: use Span instead of std::vector for `insert` and `contains` [ZAP3] (master...2020-05-bloom-span) https://github.com/bitcoin/bitcoin/pull/18985
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [bitcoin] jb55 closed pull request #18849: The Zero Allocations project (master...zeroalloc) https://github.com/bitcoin/bitcoin/pull/18849
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:53 -!- kinlo [~peter@user/kinlo] has quit [Ping timeout: 260 seconds]
10:55 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 265 seconds]
10:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:06 -!- kinlo [~peter@user/kinlo] has joined #bitcoin-core-dev
11:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:15 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
11:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:19 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
11:20 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
11:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:38 -!- klementtan [~klementta@218.212.82.3] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:44 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 246 seconds]
11:44 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
11:45 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
11:45 -!- Henrik [~textual@84.212.107.177] has quit [Client Quit]
11:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:04 -!- prayank [~andr0irc@51.158.144.32] has quit [Read error: Connection reset by peer]
12:05 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Ping timeout: 276 seconds]
12:06 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
12:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:17 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 246 seconds]
12:19 -!- Guyver2_ is now known as Guyver2
12:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:25 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
12:26 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
12:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:39 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
12:40 -!- Henrik [~textual@84.212.107.177] has quit [Client Quit]
12:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
12:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:50 -!- Kiminuo [~Kiminuo@141.98.103.197] has joined #bitcoin-core-dev
12:50 < Kiminuo> Hi, would anyone know an answer for this https://github.com/bitcoin/bitcoin/pull/12677#discussion_r711712521?
12:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:57 < laanwj> Kiminuo: I think you're right
12:57 < sipa> just commented; i think ancestorfees should just use ValueFromAmount()?
12:57 < sipa> (i haven't followed the PR, perhaps there are reasons to deviate?)
12:58 < laanwj> i don't really understand it either
12:58 < laanwj> i think it's good practice to use ValueFromAmount unless there's good reason to deviate, like consistency within a RPC call
12:58 < sipa> right
12:59 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:59 < laanwj> as listunspent uses btc-denominated amounts everywhere else it should there too
13:00 < laanwj> sorry for missing that before merge
13:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 246 seconds]
13:01 -!- Guyver2_ is now known as Guyver2
13:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:08 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin]
13:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:17 < laanwj> (otoh this PR has been open since 2018, i'm sure it was good to move forward with it and fix some things in a follow-up)
13:17 < Kiminuo> laanwj: Finally, I found it https://github.com/bitcoin/bitcoin/pull/20484#issuecomment-734786305
13:18 < sipa> Kiminuo: but that's about feerate; this is a fee, not a feerate
13:18 < Kiminuo> This is a PR where I got the impression that "fee (rate)" is fine in sat/vB
13:19 < Kiminuo> sipa: ok, then
13:23 < Kiminuo> So just to have some conclusion here: Should I try to create a follow-up PR for the Luke's one to change `ancestorfees` to BTC denomination? Or is anyone calling dibs? :)
13:23 < laanwj> right, this is not per vB
13:24 < laanwj> well if you're going to change it, it needs to be changed before the release, once it's in a release for better or worse we're stuck with this inconsistency
13:24 < Kiminuo> how long till the next release?
13:24 < laanwj> #22969
13:24 <@gribble> https://github.com/bitcoin/bitcoin/issues/22969 | Release schedule for 23.0 · Issue #22969 · bitcoin/bitcoin · GitHub
13:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:26 < bitcoin-git> [bitcoin] jonatack opened pull request #23050: log: change an incorrect fee to fee rate, and vice-versa (master...fee-vs-feerate) https://github.com/bitcoin/bitcoin/pull/23050
13:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:26 < Kiminuo> haha
13:27 < Kiminuo> I thought that Jon has just created the PR :)
13:27 < jonatack> hehe, thought this would be a good time to open this silly patch I've had on the side for a while
13:29 < jonatack> Kiminuo: confusion is normal....until Murch[m] opened my eyes to it a year ago, I didn't realize how often fees are mixed with fee rates/feerates
13:30 < Kiminuo> I should really check it here https://github.com/bitcoin/bitcoin/pull/21422 then :)
13:31 < Kiminuo> but you probably have discovered all invalid cases already
13:32 < jonatack> it was just something I wondered about during review of another pull, didn't look anywhere else
13:32 < Kiminuo> jonatack: https://github.com/bitcoin/bitcoin/pull/12677#pullrequestreview-759043318 - I don't really want to try to beat somebody in addressing these but I should have some time over the coming days to address that so I'll do it, ok? Saying that just because I don't want to compete with somebody
13:34 < jonatack> Kiminuo: sure. I don't plan to
13:38 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
13:39 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
13:40 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:43 < luke-jr> Kiminuo: laanwj: all other ancestorfees use satoshis
13:44 < sipa> oh, that's a good reason
13:45 < luke-jr> I'm not sure about the doc type tho. Maybe it should be NUM or such
13:46 < sipa> right
13:50 < jonatack> luke-jr: not sure it's related, but in #22689 (open) the four mempool rpcs are returning the ancestor fee fields and others in BTC, maybe have a look
13:50 <@gribble> https://github.com/bitcoin/bitcoin/issues/22689 | rpc: deprecate top-level fee fields in getmempool RPCs by josibake · Pull Request #22689 · bitcoin/bitcoin · GitHub
13:51 < jonatack> where some were previously in satoshis
13:53 < laanwj> listunspent is a wallet RPC call, i think it's strange to have the amount in BTC and then the fees in satoshis
13:54 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev
13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:54 < bitcoin-git> [bitcoin] gruve-p closed pull request #22961: Update zmq to 4.3.4 (master...zmq-update) https://github.com/bitcoin/bitcoin/pull/22961
13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:54 < laanwj> if you have quantities that you could plausibly compare it makes sense to use the same unit
13:55 < laanwj> fee*rate* and amount are clearly different units of course
13:55 < laanwj> i don't think you can say the same for fee and amount
13:57 < laanwj> but i'm sure this is very controversial for some reason, sorry for merging something that makes things even more of a mess
13:59 < jonatack> "this PR has been open since 2018, i'm sure it was good to move forward with it and fix some things in a follow-up" ... agree :)  admirable patience by luke, too
14:00 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
14:02 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
14:02 < laanwj> yes exactly
14:02 -!- jeremyrubin [~jeremyrub@047-025-087-245.res.spectrum.com] has joined #bitcoin-core-dev
14:05 -!- jeremyrubin [~jeremyrub@047-025-087-245.res.spectrum.com] has quit [Client Quit]
14:07 -!- jeremy [~jeremy@ec2-44-199-24-18.compute-1.amazonaws.com] has joined #bitcoin-core-dev
14:07 < jeremy> 👋 finally got my IRC setup working again, I hope :)
14:07 < jeremy> Can folks see this?
14:08 < laanwj> jeremy: welcome!
14:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:16 < luke-jr> Libera working is easy. Try getting on freenode these days otoh… >_<
14:18 -!- jeremy [~jeremy@ec2-44-199-24-18.compute-1.amazonaws.com] has quit [Quit: The Lounge - https://thelounge.chat]
14:18 -!- jeremy [~jeremy@ec2-44-199-24-18.compute-1.amazonaws.com] has joined #bitcoin-core-dev
14:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:30 < achow101> sipa: I had left the same comment during review: https://github.com/bitcoin/bitcoin/pull/12677#discussion_r707609663
14:32 < achow101> ancestorfees in satoshis is used everywhere we have mempool entries in the RPC. except that that format is deprecated and has been replaced with one that has the fees in BTC
14:33 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
14:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:47 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
14:47 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:00 < luke-jr> should we just drop ancestorfees and replace it with ⁇? then?
15:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:26 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
15:26 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
15:37 -!- stonefox [~stonefox@user/stonefox] has quit [Ping timeout: 252 seconds]
15:40 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Remote host closed the connection]
15:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:57 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:15 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 246 seconds]
16:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:19 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
16:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:20 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
16:24 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
16:26 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
16:31 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
16:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:44 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
16:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:05 -!- davterra [~davterra@143.198.56.186] has quit [Quit: Leaving]
17:06 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
17:13 -!- jespada [~jespada@2803:9800:9842:7a62:edd5:5e74:3ec2:1b19] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:16 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
17:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:21 -!- infernix [nix@spirit.infernix.net] has quit [Ping timeout: 252 seconds]
17:32 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
17:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:50 -!- bodhi [~bodhi@c-73-93-87-220.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
17:55 -!- provoostenator [~quassel@user/provoostenator] has quit [Ping timeout: 260 seconds]
17:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:00 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev
18:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:06 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 246 seconds]
18:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:14 -!- provoostenator [~quassel@user/provoostenator] has quit [Ping timeout: 246 seconds]
18:15 -!- infernix [nix@2a02:22a0:bbb1:d500::2] has joined #bitcoin-core-dev
18:17 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
18:17 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
18:19 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
18:21 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev
18:29 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
18:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:22 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
19:22 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:24 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
19:24 -!- jesseposner_ [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:12 -!- first_mersible [~mersible@92.119.17.210] has quit [Quit: Leaving]
20:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:29 -!- klementtan [~klementta@218.212.82.3] has joined #bitcoin-core-dev
20:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:33 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev
20:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:43 -!- klementtan [~klementta@218.212.82.3] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:46 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f7bd3111cdc...133446f3dcb8
20:46 < bitcoin-git> bitcoin/master fac67b3 MarcoFalke: ci: Set --nocleanup for Windows functional tests
20:46 < bitcoin-git> bitcoin/master 133446f fanquake: Merge bitcoin/bitcoin#23043: ci: Set --nocleanup for Windows functional te...
20:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:46 < bitcoin-git> [bitcoin] fanquake merged pull request #23043: ci: Set --nocleanup for Windows functional tests (master...2109-ciWinCleanup) https://github.com/bitcoin/bitcoin/pull/23043
20:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:50 < laanwj> can't say i've ever tried to join freenode since i left
20:51 < sipa> same
20:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:55 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
20:57 -!- commmon [~common@096-033-221-075.res.spectrum.com] has quit [Quit: Leaving]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:11 -!- Kiminuo [~Kiminuo@141.98.103.197] has quit [Ping timeout: 256 seconds]
21:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:27 < luke-jr> laanwj: it requires SASL (and an account) now, and their website is down so you can't create new accounts >_<
21:28 < sipa> it sounds like they have succesfully shot themselves in the foot
21:28 < luke-jr> multiple times
21:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:53 < kallewoof> with a nuclear warhead
21:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:57 < laanwj> hehe
21:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:00 -!- paulo [paulo@user/paulo/x-9032687] has joined #bitcoin-core-dev
22:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:11 -!- glix [~glix@152.67.8.183] has quit [Changing host]
22:11 -!- glix [~glix@user/glix] has joined #bitcoin-core-dev
22:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:15 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
23:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/133446f3dcb8...e4ae0008d81e
23:43 < bitcoin-git> bitcoin/master fad5dbc MarcoFalke: ci: Update s390x config
23:43 < bitcoin-git> bitcoin/master fa660de MarcoFalke: ci: Update valgrind config
23:43 < bitcoin-git> bitcoin/master e4ae000 merge-script: Merge bitcoin/bitcoin#23014: ci: Bump distro version, disable feature_bind...
23:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23014: ci: Bump distro version, disable feature_bind_extra for two configurations (master...2109-ciUpdates) https://github.com/bitcoin/bitcoin/pull/23014
23:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:47 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4ae0008d81e...1260b7e483f1
23:47 < bitcoin-git> bitcoin/master 9bdda50 Jeremy Rand: Enable TLS in links in documentation
23:47 < bitcoin-git> bitcoin/master 1260b7e fanquake: Merge bitcoin/bitcoin#23001: doc: Enable TLS in links in documentation
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:47 < bitcoin-git> [bitcoin] fanquake merged pull request #23001: doc: Enable TLS in links in documentation (master...docs-tls) https://github.com/bitcoin/bitcoin/pull/23001
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:49 -!- kappa [~kappa@host-87-2-208-83.retail.telecomitalia.it] has joined #bitcoin-core-dev
23:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
23:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
--- Log closed Tue Sep 21 00:00:13 2021