--- Log opened Wed Sep 22 00:00:14 2021 00:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:06 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 246 seconds] 00:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:19 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23059: Revert "test: Add missing suppression signed-integer-overflow:addrman.cpp" (master...2109-testSanSupU) https://github.com/bitcoin/bitcoin/pull/23059 00:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:21 < paulo> is there a "wishlist" of features I can possibly work on? 00:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:27 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 264 seconds] 00:29 -!- dviola [~diego@179.235.12.99] has joined #bitcoin-core-dev 00:30 < meshcollider> paulo: Best thing to do would be to check out the "issues" list on github :) there are tonnes of ideas there 00:36 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 00:40 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has quit [Remote host closed the connection] 00:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:42 -!- instagibbs [~instagibb@119247204116.ctinets.com] has quit [Ping timeout: 246 seconds] 00:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:07 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Ping timeout: 276 seconds] 01:08 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev 01:10 < shiza> paulo: Stay away or you risk becoming maintainer! 01:14 < paulo> shiza: what do you mean, is that a joke? 01:14 < paulo> meshcollider: thanks! 01:15 < paulo> I mean, I don't even C++ 01:16 < shiza> paulo: Yes it is a joke. 01:16 < shiza> paulo: Don't C++. It's legacy. 01:19 < shiza> That was a joke. I'll go away now. 01:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:19 < bitcoin-git> [bitcoin] fanquake opened pull request #23060: release: increase minimum compiler and lib(std)c++ requirements (master...23_0_min_compiler_libcpp_requires) https://github.com/bitcoin/bitcoin/pull/23060 01:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:31 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 01:33 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev 01:37 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev 01:37 -!- midnight [~midnight@user/midnight] has quit [Quit: quit] 01:37 -!- cold [~cold@user/cold] has quit [Quit: Quitting...] 01:38 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev 01:38 < prayank> paulo: if you have things in wishlist that improve privacy in bitcoin core but you don't feel like creating an issue in the repository, feel free to write them down in a gist and share the link here. Will be helpful. 01:38 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev 01:41 < meshcollider> prayank: I think they want to work on something, not add to the wishlist, based on the message :) 01:42 < prayank> Sorry I misunderstood 01:45 < prayank> paulo: There are lot of things to work on. You can start with https://github.com/bitcoin/bitcoin/issues/22368 (It's less than 20 lines of code if correctly done but nobody wants to work on it for some reason) 01:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:16 < shiza> prayank: If you know it's less than 20 lines of code, why wouldn't you code it yourself? Maybe the issue you describe is not an important issue for paulo, and it's not labeled as good first issue and even have no concept ACKs. If you direct a newcomer towards a poorly welcomed issue, chances are his efforts could end up being for naught. 02:16 < prayank> shiza: I tried. Failed. Have shared the details in the Stackexchange link. 02:17 < prayank> This is an important issue. Improves privacy and pending since 2012. 02:19 < prayank> It can get more than 10 concept ACKs if few influential devs ACK it or its discussed in core pr review club if you need ACKs before improving privacy 02:22 < shiza> I know it's not the point right now, but there is no such thing as influential developers in peer directed projects. 02:25 < prayank> I disagree and it's better if we don't discuss this. Efforts to fix this issue won't go waste. 02:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:33 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23061: Fix (inverse) meaning of -persistmempool (master...2109-fixArgParse) https://github.com/bitcoin/bitcoin/pull/23061 02:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:42 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection] 02:42 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev 02:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:47 < MarcoFalke> paulo: See also https://github.com/MarcoFalke/bitcoin-core/issues/18 for an entry point to getting started (if you need one) 02:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:52 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev 02:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:08 -!- prayank [~andr0irc@51.158.144.31] has quit [Quit: irc thread exit] 03:12 -!- bodhi [~bodhi@c-73-93-87-220.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 03:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51c7d88e6790...971cad475f38 03:40 < bitcoin-git> bitcoin/master fa45a13 MarcoFalke: refactor: Remove unused validation includes 03:40 < bitcoin-git> bitcoin/master 971cad4 merge-script: Merge bitcoin/bitcoin#23044: refactor: Remove unused validation includes 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23044: refactor: Remove unused validation includes (master...2109-valInc) https://github.com/bitcoin/bitcoin/pull/23044 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:04 -!- jespada [~jespada@2803:9800:9842:7a62:4d47:2975:7b31:a447] has joined #bitcoin-core-dev 04:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:24 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23064: fuzz: Fix memory leak in system fuzz target (master...2109-fuzzMemLeakSys) https://github.com/bitcoin/bitcoin/pull/23064 05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:27 < bitcoin-git> [bitcoin] meshcollider opened pull request #23065: Allow UTXO locks to be written to wallet DB (master...202109_lockunspent_persistence) https://github.com/bitcoin/bitcoin/pull/23065 05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:27 < meshcollider> prayank: ^ 05:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:32 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection] 05:32 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev 05:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:08 -!- dviola [~diego@179.235.12.99] has quit [Changing host] 06:08 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev 06:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:12 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has joined #bitcoin-core-dev 06:16 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has quit [Client Quit] 06:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:26 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has joined #bitcoin-core-dev 06:34 -!- c_arc_ [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:36 -!- TheCharlatan [~drgrid@2a01:4f9:4a:2adc::2] has quit [Ping timeout: 250 seconds] 06:36 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds] 06:37 -!- TheCharlatan [~drgrid@2a01:4f9:4a:2adc::2] has joined #bitcoin-core-dev 06:38 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 06:42 -!- c_arc_ [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:45 < bitcoin-git> [bitcoin] fanquake closed pull request #22966: doc: Improve documentation around the ACK statement (master...ack-documentation) https://github.com/bitcoin/bitcoin/pull/22966 06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:00 < dviola> sipa: someone already reported it: https://github.com/bitcoin-core/gui/issues/429 07:02 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:05 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 252 seconds] 07:05 -!- Guyver2_ is now known as Guyver2 07:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:18 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 07:20 -!- kappa [~kappa@host-87-9-156-56.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:22 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 07:23 < Bullit> at 952.5 Volt a transistor in the cubic grid of the uk intents that that doesnt matter that it is more than 420k in euro... 8.553Fractal balance deducted from 3KWmEuAXy8HauiZRhUJLVdn4eFKvoGCtap 1AG SXY 07:26 -!- mode/#bitcoin-core-dev [+b Bullit!*@*] by ChanServ 07:26 -!- Bullit was kicked from #bitcoin-core-dev by ChanServ [Banned: spam] 07:29 < michaelfolkson> laanwj: What is/was the answer to this question? https://github.com/bitcoin/bitcoin/pull/9919#issuecomment-841577083 07:30 < michaelfolkson> Presumably not using http with UNIX socket support was how c-lightning got it to work without needing the PR to libevent? 07:31 < michaelfolkson> I'm guessing it has to be http for some reason but not sure why 07:34 < sipa> michaelfolkson: c-lightning just calls bitcoin-cli 07:34 < sipa> and you can implement HTTP without libevent; it's just a pain to get right 07:36 < sipa> as for why JSON-RPC has to be HTTP.. i guess that's the standard approach, but just using a plain line based protocol could work too... that would be easier to implement, but perhaps breaks compatibility with other intended applications? 07:36 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!] 07:36 < sipa> this sort of stuff is generally up to whoever ends up implementing it... and i suspect laanwj lost interest in it 07:41 < darosior> I think michaelfolkson refered to C-lightning's JSONRPC interface in which case the answer is: C-lightning doesn't use HTTP, it just sends the JSONRPC messages through the socket 07:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 07:43 < sipa> ah, i see 07:44 < michaelfolkson> darosior: Right, I guess there are different configurations of the server-client relationship. Server=Core Client=c-lightning is one. Server=c-lightning Client=c-lightning plugins is another. 07:44 < michaelfolkson> And with UNIX sockets in Core you could maybe do Core plugins or at least a Python client connecting to Core 07:47 < sipa> you can already have a python client connecting to corr 07:47 < sipa> that's what the functional test framework uses 07:48 < darosior> And plugins ala C-lightning is orthogonal to the transport used 07:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:52 < michaelfolkson> darosior: This should probably be in the c-lightning channel but c-lightning plugins use UNIX sockets right? That's what is in pyln-client. Your point is they don't have to but they currently do? 07:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:52 < sipa> yes, they just some means of communication 07:56 -!- Guest9472 [~Guest94@2a02:8084:2165:7000:7584:58ae:20ae:f705] has joined #bitcoin-core-dev 07:56 < michaelfolkson> Ok thanks. So the answer to my original question is most likely breaking compatibility, makes sense. And that's most likely why laanwj stuck with http and went the libevent PR route 07:57 < sipa> yes, this is mostly a non-technical issue 07:57 < sipa> *anything* could have been chosen for bitcoin core's RPC interface, but the one that was chosen was json-rpc over http with user/pass authentication 07:58 < sipa> and it's reasonable to expect that to keep working 07:58 < sipa> in any case, back on topic: i don't see any problem personally with adding support for unix sockets rpc server / client that uses plain json-rpc lines, if someone wants to work on that 07:59 -!- kappa [~kappa@host-87-9-156-56.retail.telecomitalia.it] has quit [Quit: Client closed] 08:01 < michaelfolkson> Oh in addition rather than as a replacement.... yes that could work. Perhaps downsides of code replication, maintenance burden of having two approaches? 08:02 < sipa> unix sockets is inherently limited to local communication, so it would always be in addition to 08:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:06 -!- Guest9472 [~Guest94@2a02:8084:2165:7000:7584:58ae:20ae:f705] has quit [Quit: Client closed] 08:08 < michaelfolkson> It is recommended to not enable Core RPC connections over public internet but UNIX sockets wouldn't allow that use case at all and we want to support that if it is SSL wrapped? 08:08 < sipa> but yes, that's the advantage of using http-based json-rpc... being able to reuse more code (then again, line-based is so simple that there is probably just not that much to add) 08:08 < sipa> you can also use bitcoin core RPC in a local trusted network 08:08 < sipa> or over a VPN or so 08:10 < michaelfolkson> Gotcha, thanks 08:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:30 -!- smartin [~Icedove@88.135.18.171] has quit [Ping timeout: 252 seconds] 08:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:42 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 276 seconds] 08:44 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev 08:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:55 < jeremyrubin> I think what we'd want is to remove the http support from Bitcoin core and then build a separate binary with a simple http proxy to it 08:56 < jeremyrubin> That doesn't even have to live in core. 08:56 < sipa> that's also a possibility, but probably not a short-term one 08:56 < sipa> (also, unix domain sockets don't exist on windows...) 08:56 < jeremyrubin> It would be a breaking change so would be a maj release 08:57 < jeremyrubin> I think they have something that can be used the same way these days 08:57 < sipa> right, but we'd need that too :) 08:57 < jeremyrubin> I think it's basically the exact same 08:58 < darosior> Windows does support Unix Domain Sockets since W10 08:58 < jeremyrubin> Just different headers and negative FDs 09:04 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 09:06 < jeremyrubin> I think over the span of a few releases could reasonably do deprecated, not built by default, removed. 09:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 09:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 09:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:25 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 09:30 < laanwj> yes, modern windows has them too 09:36 < laanwj> i might give 'simple line protocol over UNIX socket' a try, if there is really enthousiasm for adding such a thing; at least i don't have to fight libevent's http client then, that's what i lost interest in 09:38 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev 09:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 09:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:43 < laanwj> i guess the only context information from HTTP that is used inside RPC calls is the wallet name from the path, in case of wallet RPC calls 09:44 < laanwj> but would be straightforward to wrap in an object that provides the context otherwise, e.g. { 'wallet': 'name', 'params': {...} } 09:46 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:49 -!- kexkey [~kexkey@static-198-54-132-91.cust.tzulo.com] has joined #bitcoin-core-dev 09:53 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has quit [Read error: Connection reset by peer] 09:53 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has joined #bitcoin-core-dev 09:54 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has quit [Read error: Connection reset by peer] 09:54 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev 09:57 < jeremyrubin> i guess the only other question is the rest API thing? 09:58 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-core-dev 09:58 < jeremyrubin> that also seems like stuff that should just be a proxy over core tho 09:58 < jeremyrubin> (or just removed and see if anyone complains?) 10:01 < laanwj> rest is very closely bound to http, how i imagine this would purely be for RPC calls (all information on rest is also available through RPC it's 'extra') 10:02 < laanwj> i think that could very well be an optional thing that people can enable if they want it 10:03 < laanwj> sharing the http server between rest and the json-rpc interface was always a bit questionable, they are separate things 10:05 < jeremyrubin> laanwj does anyone use the rest interface in practice? 10:05 < laanwj> i have no idea 10:06 < jeremyrubin> i've never heard of anyone using it either 10:06 < laanwj> it's much faster than JSON-RPC for some things as it saves on formatting and the info can (basically) directly be dumped to the socket 10:10 < laanwj> though it's not as great as it sounds, i wanted to add a rest call for streaming utxo data once (without buffering it in memory first), but libevent's http server wouldn't let me due to not really being thread safe 10:10 -!- Guest7230 [~Guest72@148.69.98.142] has joined #bitcoin-core-dev 10:12 < laanwj> mostly it's not even issues with http itself we run against, but issues with libevent's http, but adding another dependency for http would be not nice 10:13 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 264 seconds] 10:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:17 < jeremyrubin> laanwj i think given that there are few users for rest (most likely) we could ship a /share script with a python http proxy for rest, altho performance might suffer a bit (maybe we add a raw response mode for the json rpcs if it's a concern?) 10:20 < laanwj> yes... 10:21 -!- earnestly [~earnest@user/earnestly] has quit [Read error: Connection reset by peer] 10:22 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 10:22 < laanwj> in the case where we directly 'own' the socket, and the protocol is up to us to define, in principle it could reply in a different way than a line with JSON on it if so requested, this does make clients that want to support that more complex, so everything should at least support JSON line in JSON line out 10:24 < laanwj> honestly that kind of thing seems far enough away, i'm not sure it's worth spendng time on, it works as it does now, not sure about the added benefit of doing things slightly different 10:25 < laanwj> i think my reply on twitter was more hypothetical, in a perfect clean-slate world where you don't have to balance so many different concerns and backwards compatibility, it would have been nice 10:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:21 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev 11:25 -!- vnogueir| [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev 11:25 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection] 11:28 -!- vnogueir- [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds] 11:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:35 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 252 seconds] 11:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 246 seconds] 11:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:51 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:53 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev 11:55 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Remote host closed the connection] 11:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:21 -!- roconnor [~roconnor@host-45-58-209-171.dyn.295.ca] has joined #bitcoin-core-dev 12:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:29 < bitcoin-git> [bitcoin] stevebanik opened pull request #23067: Adding link to original bitcoin whitepaper (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23067 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:32 -!- Guest7230 [~Guest72@148.69.98.142] has quit [Quit: Connection closed] 12:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 12:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 12:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:00 -!- emcy_ [~emcy@user/emcy] has joined #bitcoin-core-dev 13:02 -!- emcy [~emcy@user/emcy] has quit [Ping timeout: 260 seconds] 13:02 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 13:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:15 -!- emcy_ [~emcy@user/emcy] has quit [Ping timeout: 265 seconds] 13:17 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 13:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:24 -!- emcy [~emcy@user/emcy] has quit [Ping timeout: 252 seconds] 13:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:32 < bitcoin-git> [bitcoin] laanwj closed pull request #23067: Adding link to original bitcoin whitepaper (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23067 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:36 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 13:38 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 13:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] katesalazar opened pull request #23068: Add aliases to the `-chain` param (master...20210922) https://github.com/bitcoin/bitcoin/pull/23068 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:05 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has joined #bitcoin-core-dev 14:06 -!- yyaac [~andirc@2400:4052:8383:5c00:35c0:d596:1b08:deec] has quit [Client Quit] 14:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:48 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 14:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:54 -!- [\\\] [~triplesla@user/tripleslash] has quit [Ping timeout: 260 seconds] 14:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:54 < bitcoin-git> [bitcoin] amjadshaheed opened pull request #23070: Bitcoinrupee (master...Bitcoinrupee) https://github.com/bitcoin/bitcoin/pull/23070 14:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:55 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev 14:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:01 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds] 15:03 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 15:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:03 < bitcoin-git> [bitcoin] ryanofsky closed pull request #22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (master...pr/u8path) https://github.com/bitcoin/bitcoin/pull/22937 15:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:03 < bitcoin-git> [bitcoin] ryanofsky reopened pull request #22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (master...pr/u8path) https://github.com/bitcoin/bitcoin/pull/22937 15:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:06 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:08 < bitcoin-git> [bitcoin] sipa closed pull request #23070: Bitcoinrupee (master...Bitcoinrupee) https://github.com/bitcoin/bitcoin/pull/23070 15:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:10 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:20 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Ping timeout: 276 seconds] 15:21 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving] 15:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:29 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Remote host closed the connection] 15:30 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 15:32 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Remote host closed the connection] 15:33 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 15:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:43 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Quit: yanmaani1] 15:47 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 15:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:56 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 246 seconds] 15:58 < fanquake> Looking for opinions on whether we want to merge #22858 and cut an rc3 for 0.21.2. As we we really should get that out soon. If not, we could just about tag final. 15:58 <@gribble> https://github.com/bitcoin/bitcoin/issues/22858 | [0.21] Potential rc3 backports by fanquake · Pull Request #22858 · bitcoin/bitcoin · GitHub 16:00 < fanquake> As for 0.20.2rc3, jonasschnelli: are you able to push some sigs up https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.20 ? 16:03 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 16:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:07 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Ping timeout: 264 seconds] 16:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:14 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 16:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:35 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Remote host closed the connection] 16:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:43 -!- roconnor [~roconnor@host-45-58-209-171.dyn.295.ca] has quit [Ping timeout: 252 seconds] 16:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:02 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 17:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:17 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 252 seconds] 17:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:45 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Ping timeout: 276 seconds] 17:46 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 17:49 -!- jespada [~jespada@2803:9800:9842:7a62:4d47:2975:7b31:a447] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:49 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 17:50 -!- jespada [~jespada@2803:9800:9842:7a62:4d47:2975:7b31:a447] has joined #bitcoin-core-dev 17:53 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 252 seconds] 17:55 -!- jespada [~jespada@2803:9800:9842:7a62:4d47:2975:7b31:a447] has quit [Client Quit] 18:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:17 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 18:19 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 18:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:07 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev 19:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:59 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Remote host closed the connection] 19:59 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 20:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:41 -!- Guest1149 [~Guest11@107-216-117-78.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 20:42 -!- Guest1149 [~Guest11@107-216-117-78.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 20:49 <@gribble> ugh.. double your bitcoin scam on bitcoin.org 20:50 < jarolrod> ^ yes, and that is the first website to come up when someone googles bitcoin 20:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:03 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection] 21:04 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev 21:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:56 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds] 22:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:08 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 22:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:25 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Remote host closed the connection] 22:28 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 22:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:35 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 246 seconds] 22:37 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 22:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:43 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Ping timeout: 252 seconds] 22:45 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 22:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:57 -!- commmon [~common@096-033-221-075.res.spectrum.com] has quit [Remote host closed the connection] 22:58 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 23:02 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 23:03 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 23:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:43 < laanwj> fanquake: so is #21330 critical enough to warrant doing another rc, instead of simply moving on with final? 23:43 <@gribble> https://github.com/bitcoin/bitcoin/issues/21330 | Deal with missing data in signature hashes more consistently by sipa · Pull Request #21330 · bitcoin/bitcoin · GitHub 23:44 < laanwj> i'm not sure, there's always something last minute that could be considered, but that way you'll be doing rc's forever 23:44 < fanquake> laanwj: it was just mentioned in #22720 that we could do it. Although given no review / feedback I'd be happy to drop that change from the PR, and just do the doc change, which wouldn't need a new RC either 23:44 <@gribble> https://github.com/bitcoin/bitcoin/issues/22720 | v0.21.2 Testing · Issue #22720 · bitcoin/bitcoin · GitHub 23:45 < fanquake> That way we could just merge that PR, with the doc addition, and move onto tagging final 23:45 < laanwj> exactly, the doc change could go in without an rc 23:46 < fanquake> I'll drop the other change out of that PR. We should be getting 0.21.2 out soon. 23:46 < laanwj> sgtm 23:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:56 < laanwj> a shorter rc cycle is generally enough for minor releases, as there aren't new features or large changes, no regressions have been reported so i think this one has been long enough --- Log closed Thu Sep 23 00:00:15 2021