--- Log opened Thu Sep 30 00:00:22 2021
00:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:10 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Quit: Good day old chaps]
00:10 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #bitcoin-core-dev
00:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:22 -!- saranshsharma [~saranshsh@202.142.81.26] has joined #bitcoin-core-dev
00:26 -!- saranshsharma [~saranshsh@202.142.81.26] has quit [Ping timeout: 245 seconds]
00:30 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
00:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:46 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 252 seconds]
00:47 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
00:49 < jonatack> meshcollider: was looking into it too and updated that assertion helper in #23136   ⎦˚◡˚⎣
00:49 <@gribble> https://github.com/bitcoin/bitcoin/issues/23136 | test: update fee rate assertion helper in the functional test framework by jonatack · Pull Request #23136 · bitcoin/bitcoin · GitHub
00:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:55 < S3RK> #proposedwalletmeetingtopic two descriptors generating same scriptpubkey
00:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:59 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
00:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:00 < vasild> laanwj: right, a "node" victim.com:80 that never speaks bitcoin p2p would propagate less and fall out of addrmans. So a rate from a well propagated real bitcoin node with public ipv4 address and port 80 would give an upper bound. If that is not high enough to be considered as a dos attack, then a lower number will also not be.
01:01 < vasild> s/and port 80/and port 8333/
01:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:10 -!- dermoth [~dermoth@dsl-199-102-159-155.mtl.aei.ca] has joined #bitcoin-core-dev
01:11 < laanwj> vasild: okay, good point
01:13 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:16 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/69a66dcd0dac...f52929063f48
01:16 < bitcoin-git> bitcoin/master 489060d Hennadii Stepanov: qt: Do not show unused widgets at startup
01:16 < bitcoin-git> bitcoin/master f529290 Hennadii Stepanov: Merge bitcoin-core/gui#439: Do not show unused widgets at startup
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:17 < _aj_> vasild: would it propogate less? i didn't think whether you'd tested a node influenced its propogation?
01:19 < vasild> _aj_: I did not test whether it will propagate less, but the point is that it is an _upper bound_ (even if it propagates equally well). But anyway, I _guess_ it will propagate less because it will drop from some addrmans.
01:21 < vasild> during gossip we don't test a peer (try to connect to it) and we gossip it regardless, but I think this "initial" propagation is not enough to get the peer in everybody's addrmans.
01:21 < _aj_> vasild: no it's not, but all propogation is just repeats of this "initial" propogation
01:22 < vasild> getaddr?
01:25 -!- fedecuci [~fedecuci@ww090827.uvt.nl] has joined #bitcoin-core-dev
01:29 < _aj_> vasild: hmm, does that count for a non-trivial number of addresses?
01:29 < laanwj> oh crap, had to shut down the node to move around a few things, a disk is full 
01:29 < jnewbery> whether or not an address is actually a viable peer does not affect how well it propagates in addr gossip
01:30 < vasild> _aj_: I don't know
01:30 < _aj_> jnewbery: it does for getaddr; normal propogation you'll relay before you test it, but for getaddr there's a decent chance you'll have dropped a bad address before you get the getaddr request
01:32 < _aj_> vasild: could be significant for nodes that aren't online all the time, but i wonder if that's a plausible set of nodes for creating a botnet in the first place
01:32 < vasild> anyway, I do not insist that a junk address propagates worse than a real one. I insist that it propagates worse, or equally well (it does not propagate better for sure). So, a number from a real node will be an upper bound.
01:33 < _aj_> vasild: the other thing is you could relay "secret-nuclear-facility.gov:22" and then wait for the cia to start going after node operators with "why are you trying to hack into our nuclear facilities" ? i don't know if anyone still overreacts to connection attempts in this day and age like that though
01:34 < vasild> :)
01:35  * _aj_ remembers telnet'ing to the smtp port for some AusCERT computers and getting a stern talking to back in his uni days
01:35 < vasild> my !=8333 port node is getting 5 incoming connections per minute
01:37 < laanwj> i wonder if logic like "don't connect to ports under 1024" or such makes sense
01:37 < laanwj> i mean if we're talking about old school sysadmins getting pissed about connections, that  was usually the threshold below not to mess around with :)
01:39 < jnewbery> _aj_: right, that's why I referred to addr gossip specifically, which I think is what matters more here. getaddr requests won't return bogus addresses that are IsTerrible()
01:39 < laanwj> and on UNIX-like operating systems you'd need to run bitcoind as root to do that
01:41 < vasild> in case anybody is curious how many incoming connections his node is getting (and lazy to type wretched bash commands), assuming debug=net is switched off on the node: bitcoin-cli logging '["net"]' && sleep 3600 && bitcoin-cli logging '[]' '["net"]'
01:41 < vasild> and then: grep -E '2021-09-30.+connection from .+ accepted' debug.log |grep -v '\[' |grep -v 127.0.0.1 |grep -v i2p |wc -l
01:43 < laanwj> i tried that but my disk was almost full and the ballooning debug.log pushed it over the edge, will try it again later
01:43 < vasild> :-X
01:45 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 265 seconds]
01:49 -!- Guyver2_ is now known as Guyver2
01:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:54 -!- saranshsharma [~saranshsh@202.142.81.26] has joined #bitcoin-core-dev
01:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:13 -!- saranshsharma [~saranshsh@202.142.81.26] has quit [Remote host closed the connection]
02:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:35 < bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/f52929063f48...81e7748bc18a
02:35 < bitcoin-git> bitcoin/master 13f6188 Hennadii Stepanov: qt: Add GUIUtil::ShowModalDialogAndDeleteOnClose
02:35 < bitcoin-git> bitcoin/master 7830cd0 Hennadii Stepanov: qt, refactor: Keep OptionsDialog in the main event loop
02:35 < bitcoin-git> bitcoin/master 59f7ba4 Hennadii Stepanov: qt, refactor: Keep CoinControlDialog in the main event loop
02:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:36 < bitcoin-git> [gui] laanwj merged pull request #336: Do not exit and re-enter main event loop during shutdown (master...210516-loop) https://github.com/bitcoin-core/gui/pull/336
02:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:47 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
02:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:03 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
03:05 -!- fedecuci [~fedecuci@ww090827.uvt.nl] has quit [Quit: Client closed]
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:11 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81e7748bc18a...80b4e8fb87a2
03:11 < bitcoin-git> bitcoin/master 90be29c Sebastian Falbesoner: wallet: enable SQLite extended result codes
03:11 < bitcoin-git> bitcoin/master 80b4e8f W. J. van der Laan: Merge bitcoin/bitcoin#23112: wallet: enable SQLite extended result codes
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:11 < bitcoin-git> [bitcoin] laanwj merged pull request #23112: wallet: enable SQLite extended result codes (master...202109-wallet-enable_sqlite_extended_result_codes) https://github.com/bitcoin/bitcoin/pull/23112
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:20 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
03:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:24 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
03:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:34 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80b4e8fb87a2...dbbb7fbcc02e
03:34 < bitcoin-git> bitcoin/master 8ff3743 Hennadii Stepanov: Revert "doc: Remove outdated comments"
03:34 < bitcoin-git> bitcoin/master dbbb7fb W. J. van der Laan: Merge bitcoin/bitcoin#23130: doc: Revert "Remove outdated comments" and pl...
03:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:34 < bitcoin-git> [bitcoin] laanwj merged pull request #23130: doc: Revert "Remove outdated comments" and place comment correctly (master...210929-revert) https://github.com/bitcoin/bitcoin/pull/23130
03:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:46 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 245 seconds]
03:47 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
03:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:52 -!- fedecuci [~fedecuci@ww090827.uvt.nl] has joined #bitcoin-core-dev
03:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:13 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:15 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 252 seconds]
04:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 245 seconds]
04:16 -!- Guyver2_ is now known as Guyver2
04:24 -!- Guyver2_ [~Guyver@2001:985:f3f:1:9897:b926:f3e9:ee7a] has joined #bitcoin-core-dev
04:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 245 seconds]
04:26 -!- Guyver2_ is now known as Guyver2
04:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:40 -!- jtrag [~jtrag@c-71-207-125-151.hsd1.pa.comcast.net] has joined #bitcoin-core-dev
04:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dbbb7fbcc02e...bd40cd81083a
04:44 < bitcoin-git> bitcoin/master 1d44513 MarcoFalke: Squashed 'src/crc32c/' changes from b5ef9be675..0d624261ef
04:44 < bitcoin-git> bitcoin/master fac1c13 MarcoFalke: Update crc32c subtree
04:44 < bitcoin-git> bitcoin/master bd40cd8 fanquake: Merge bitcoin/bitcoin#23133: Update crc32c subtree
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] fanquake merged pull request #23133:  Update crc32c subtree  (master...2109-subtreeCrc32c) https://github.com/bitcoin/bitcoin/pull/23133
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:53 < fedecuci> Hi guys, I am curious, how many people have a very strong understanding of the Bitcoin protocol and source code? I am talking about people that are comfortable with at least 80% of the codebase and would know almost immediately where to go to fix a bug in case it arises. Any estimate?
04:54 < fedecuci> Also please let me know if this is not the place to ask such questions and I won't anymore of course. 
04:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:00 -!- kpcyrd [~kpcyrd@archlinux/trusteduser/kpcyrd] has left #bitcoin-core-dev []
05:03 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 245 seconds]
05:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:13 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
05:14 -!- jespada [~jespada@2803:9800:9842:7a62:a5:6e91:7fa0:aa24] has joined #bitcoin-core-dev
05:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:30 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
05:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:37 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd40cd81083a...7f81f5459ffa
05:37 < bitcoin-git> bitcoin/master e56100c fanquake: build: remove arm includes from getauxval() check
05:37 < bitcoin-git> bitcoin/master 4446ef0 fanquake: build: remove support for weak linking getauxval()
05:37 < bitcoin-git> bitcoin/master 7f81f54 W. J. van der Laan: Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove ...
05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:37 < bitcoin-git> [bitcoin] laanwj merged pull request #23082: build: improve gexauxval() detection, remove getauxval() weak linking (master...remove_weak_auxval) https://github.com/bitcoin/bitcoin/pull/23082
05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:42 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7f81f5459ffa...1cf7fb9fd658
05:42 < bitcoin-git> bitcoin/master faffaa8 MarcoFalke: log: Avoid broken SELECTCOINS log
05:42 < bitcoin-git> bitcoin/master faeae29 MarcoFalke: log: Avoid broken DEBUG_LOCKORDER log
05:42 < bitcoin-git> bitcoin/master fa6c1e8 MarcoFalke: test: Fix typos in tests
05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:43 < bitcoin-git> [bitcoin] laanwj merged pull request #23104: log: Avoid breaking single log lines over multiple lines in the log file (master...2109-logCont) https://github.com/bitcoin/bitcoin/pull/23104
05:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:54 -!- Guest38 [~Guest38@2a02:908:1a8:a6a0:ccc:55d7:8471:5ec5] has joined #bitcoin-core-dev
05:54 -!- Guest38 [~Guest38@2a02:908:1a8:a6a0:ccc:55d7:8471:5ec5] has quit [Client Quit]
06:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:07 -!- jtrag [~jtrag@c-71-207-125-151.hsd1.pa.comcast.net] has quit [Changing host]
06:07 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:15 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1cf7fb9fd658...2d8e0c0c3c0d
06:15 < bitcoin-git> bitcoin/master 4747db8 practicalswift: util: Introduce ToIntegral<T>(const std::string&) for locale independent p...
06:15 < bitcoin-git> bitcoin/master 2d8e0c0 W. J. van der Laan: Merge bitcoin/bitcoin#20457: util: Make Parse{Int,UInt}{32,64} use locale ...
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:15 < bitcoin-git> [bitcoin] laanwj merged pull request #20457: util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull} (master...locale-independent-parseint) https://github.com/bitcoin/bitcoin/pull/20457
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:24 -!- fedecuci [~fedecuci@ww090827.uvt.nl] has quit [Quit: Client closed]
06:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [gui] hebasto closed pull request #59: Do not block GUI thread in RPCConsole (master...200814-rpc) https://github.com/bitcoin-core/gui/pull/59
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:34 < TallTim> I'd like to report using addnode to sync bitcoin core client with my personal full node has sped up my sync time. Thanks again to sipa for the advice.
06:35 < sipa> :)
06:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:42 < laanwj> nice!
06:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:47 < TallTim> I appreciate the work you put in. Its obvious core has continually improved. Thank you.
06:58 < shiza> +1
07:04 -!- jtrag [~jtrag@user/jtrag] has quit [Quit: <-----  is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...]
07:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:24 < jamesob> Are there people who're attesting to release binaries using opentimestamps?
07:24 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
07:29 -!- saranshsharma [~saranshsh@202.142.81.26] has joined #bitcoin-core-dev
07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:35 < bitcoin-git> [bitcoin] hebasto pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2d8e0c0c3c0d...9013f23b0a6e
07:35 < bitcoin-git> bitcoin/master f9b633e Hennadii Stepanov: qt, wallet: Move activity progress dialog from data member to local
07:35 < bitcoin-git> bitcoin/master 4a024fc Hennadii Stepanov: qt, wallet, refactor: Move connection to QObject::deleteLater to ctor
07:35 < bitcoin-git> bitcoin/master f6991cb Hennadii Stepanov: qt, wallet: Add LoadWalletsActivity class
07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:36 < bitcoin-git> [gui] hebasto merged pull request #342: wallet: Move wallets loading out from the main GUI thread (master...210521-wallet) https://github.com/bitcoin-core/gui/pull/342
07:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:44 < sipa> jamesob: i'm interested in knowing whether "-flto" and/or "-fdata-sections -ffunction-sections -Wl,--gc-sections" are possible/beneficial with our current compiler suite; what would be a good way to have your test infrastructure benchmark things?
07:47 < laanwj> jamesob: not that i know, there's https://bitcoincore.org/bin/bitcoin-core-22.0/SHA256SUMS.ots but it gets generated prior to upload, it's not part of any of the attestations
07:51 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
07:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:57 -!- saranshsharma [~saranshsh@202.142.81.26] has quit [Remote host closed the connection]
08:00 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
08:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:07 -!- kexkey [~kexkey@static-198-54-132-172.cust.tzulo.com] has joined #bitcoin-core-dev
08:08 < cfields> sipa: +1, I'd like to know about lto as well. It seems mature enough across the board to switch to imo, as long as there are no obvious regressions.
08:09 < cfields> (IIRC last time you tested it there were some weird slowdowns)
08:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:17 < jamesob> sipa cfields: not familiar with that stuff, will investigate though 
08:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:26 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev
08:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:26 < bitcoin-git> [bitcoin] jonatack opened pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
08:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:27 -!- davterra [~davterra@143.198.56.186] has quit [Ping timeout: 245 seconds]
08:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:35 -!- emcy [~emcy@user/emcy] has quit [Remote host closed the connection]
08:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:43 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
08:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:59 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
09:00 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
09:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:31 < cfields> sipa: blah, good point about mixed-use codebases. I guess https://github.com/sipa/minisketch/pull/51 is kinda a counterpoint to disabling the warning wholesale, as it pointed out something legal but logically broken.
09:31 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
09:32 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
09:33 < sipa> cfields: FWIW, libsecp256k1 does assume that some signed integer behavior is actually well-defined (and it has compile-time assertions to check that), which means it's not fully C language neutral
09:34 < sipa> (not UB though; only parts of signed integer behavior that are implementation defined)
09:36 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:36 < sipa> cfields: but i do think that we probably want to disable unsigned-integer sanitizers wholesale for minisketch
09:39 -!- gleb7 [~gleb@178.150.137.228] has quit [Ping timeout: 252 seconds]
09:43 < laanwj> disabling unsigned-integer sanitizers for cryptographic code makes a lot of sense
09:48 < cfields> ACK, will just do it there. I'm still surprised that this happens rarely enough for our tests to pass with only a few exceptions. Guess it is pretty specific to crypto/mathy stuff.
09:48 < sipa> we already pretty much do that
09:49 < sipa> it's disputable whether minisketch is cryptographic, but it's pretty mathy :)
09:49 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
09:49 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
09:56 < laanwj> right, it would have been nice if C had explicit wraparound and non-wraparound arithmetic, but this works
09:59 < sipa> compilers actually do make use of this, FWIW; sometimes using signed integer as a loop variable is faster, because the compiler can assume it can't run forever
09:59 < sipa> even if it never takes on a negative value
09:59 < cfields> sipa: heh, I remember that as an ancient gcc bug. hope that's not still the case :)
10:00 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Remote host closed the connection]
10:04 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin]
10:04 < laanwj> not related to signed/unsigned or wraparound but i recently learned that on RISC-V 64-bit, explicitly using 64-bit loop counters can be much faster, as it doesn't have 32-bit arithmetic, so if the compiler can't reason that your value won't wrap, it will add AND (1<<32)-1 everywhere ... this is pretty annoying for code that needs to be fast on 32-bit hardware too
10:05 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
10:06 < sipa> cfields: not sure what you're referring too, but it may well not be a bug; a for (int x = 0;; x++) { ... } loop, which doesn't modify x in the body is guaranteed to not run forever for example (because that would require a signed int overflow, which is UB)
10:06 < laanwj> of course, this only matters for really tiny loops, as in micro-benchmarks, normally the work actually done in the loop dominates
10:07 < cfields> laanwj: I wonder if that's a case that int_fast32_t is suited for?
10:07 < sipa> hmm, what is int_fast32_t on x86_64 and riscv64?
10:08 < laanwj> lets see
10:08 -!- emcy_ [~emcy@user/emcy] has joined #bitcoin-core-dev
10:08 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
10:08 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
10:09 < cfields> sipa: blah, I can't remember it now, but it was a relatively widely-known missed (safe) optimization. So maybe the loop count is known.
10:10 -!- dodo__ [~dodo@user/dodo] has joined #bitcoin-core-dev
10:11 < laanwj> both int_fast32_t and int_fast64_t are 64 bit on 64-bit RISC-V
10:11 -!- adiabat_ [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
10:11 -!- javi404_ [~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev
10:11 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:12 -!- Guest65 [~Guest65@dynamic-adsl-78-15-71-43.clienti.tiscali.it] has joined #bitcoin-core-dev
10:12 -!- sturles_ [~sturles@sauron.uio.no] has joined #bitcoin-core-dev
10:12 -!- diego [~diego@179.235.12.99] has joined #bitcoin-core-dev
10:12 < cfields> same on x86_64.
10:13 < sipa> that makes sense
10:13 < sipa> it's not universal though... iirc 64-bit multiplication and division are slower on x86_64 than 32-bit ones
10:13 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev
10:13 -!- Guest65 [~Guest65@dynamic-adsl-78-15-71-43.clienti.tiscali.it] has quit [Quit: Connection closed]
10:17 -!- Netsplit *.net <-> *.split quits: jespada, sturles, upekkha, jarthur, Lightsword, promag, mikehu44, javi404, luke-jr, emcy,  (+7 more, use /NETSPLIT to show all of them)
10:17 -!- lukedashjr is now known as luke-jr
10:17 -!- dodo__ is now known as dodo
10:18 -!- cryptolightning [~cryptolig@70-131-42-184.lightspeed.rlghnc.sbcglobal.net] has joined #bitcoin-core-dev
10:18 -!- cryptolightning [~cryptolig@70-131-42-184.lightspeed.rlghnc.sbcglobal.net] has quit [Changing host]
10:18 -!- cryptolightning [~cryptolig@user/cryptolightning] has joined #bitcoin-core-dev
10:20 -!- Netsplit over, joins: lightlike
10:21 -!- Netsplit over, joins: promag
10:21 -!- mekster66 [~mekster@user/mekster] has quit [Read error: Connection reset by peer]
10:21 -!- mekster66 [~mekster@user/mekster] has joined #bitcoin-core-dev
10:21 -!- rockhouse3 [~rockhouse@user/rockhouse] has joined #bitcoin-core-dev
10:22 -!- jespada [~jespada@2803:9800:9842:7a62:a5:6e91:7fa0:aa24] has joined #bitcoin-core-dev
10:22 -!- jarthur [~jarthur@2603-8080-1540-002d-f169-568c-84c0-edb5.res6.spectrum.com] has joined #bitcoin-core-dev
10:22 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
10:22 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
10:23 -!- promag_ [~promag@188.250.84.129] has quit [Ping timeout: 265 seconds]
10:23 < shiza> Functional tests runner defaults to as many jobs as virtual processors? And, shouldn't it default to one job for consistency with "make check"?
10:24 -!- rockhouse [~rockhouse@user/rockhouse] has quit [Ping timeout: 265 seconds]
10:24 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Ping timeout: 265 seconds]
10:24 -!- rockhouse3 is now known as rockhouse
10:24 -!- tripleslash [~triplesla@user/tripleslash] has quit [Read error: Connection reset by peer]
10:26 -!- jarthur [~jarthur@2603-8080-1540-002d-f169-568c-84c0-edb5.res6.spectrum.com] has quit [Quit: jarthur]
10:26 -!- jarthur [~jarthur@2603-8080-1540-002d-5422-0cb4-aeaf-4572.res6.spectrum.com] has joined #bitcoin-core-dev
10:27 < laanwj> that makes sense if they're different instructions; for RISC-V there's work on an extension that adds explicit 32-bit arithmetic (as part of more general bit manipulation extensions)
10:28 < laanwj> shiza: have you tried that it runs faster in that case? the functional tests tend to peg 100% CPU already here so i don't think it'd make a difference
10:29 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
10:29 -!- dongcarl [~dongcarl@70.107.207.192] has quit [Read error: Connection reset by peer]
10:29 < laanwj> oh, sorry, read it wrong, thought you meant defaulting to number of cores + 1
10:29 -!- dongcarl7 [~dongcarl@70.107.207.192] has joined #bitcoin-core-dev
10:29 < shiza> If a random functional test tends to peg to 100% CPU already, why at all default to more than 1 or 2?
10:30 < shiza> Alright, then I haven't written anything.
10:31 < shiza> I should try it around more, before being sure it feels weird.
10:32 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:33 < shiza> I suppose "make check" honors equivalence with "make -j 1 check". :thonking:
10:33 < shiza> But I don't know.
10:34 < shiza> Sometimes I've used "make -j TARGET" and it somehow exploded exponentially, but that's a topic for another day. 
10:34 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Client Quit]
10:35 < shiza> Well not exponentially, but exploded further than the number of virtual processors.
10:35 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:40 < cfields> shiza: -j launches every possible build job simultaneously. It's not intended to be bounded by cpu count.
10:40 < cfields> If you use a bare -j, you probably want -l too.
10:42 -!- glix_ [~glix@152.67.8.183] has joined #bitcoin-core-dev
10:43 < shiza> It looked like -j was being passed to nested makes, but I imagine how -l would help, didn't knew that, thanks.
10:43 -!- jnewbery_ [~john@user/jnewbery] has joined #bitcoin-core-dev
10:44 -!- _aj__ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
10:44 -!- _aj__ [aj@cerulean.erisian.com.au] has quit [Changing host]
10:44 -!- _aj__ [aj@user/aj/x-5857768] has joined #bitcoin-core-dev
10:44 -!- __nick__ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
10:44 < cfields> Yes, nested "$(MAKE)" invocations will share the same jobqueue, but manual "make"s will start over, potentially launching new parallel builds.
10:44 -!- glix [~glix@user/glix] has quit [Ping timeout: 265 seconds]
10:44 -!- _aj_ [aj@user/aj/x-5857768] has quit [Ping timeout: 265 seconds]
10:44 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Ping timeout: 265 seconds]
10:44 -!- jnewbery [~john@user/jnewbery] has quit [Ping timeout: 265 seconds]
10:44 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 265 seconds]
10:44 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 265 seconds]
10:44 < cfields> -l doesn't always help a ton though. Sometimes the jobs ramp up faster than the load can reflect.
10:45 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev
10:47 -!- bijoo [~bijoo@96.86.11.105] has joined #bitcoin-core-dev
10:50 < shiza> Remembering now, every project demonstrates parallel make useless when matured enough.
10:51 < shiza> "Useless". Not exactly.
10:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:00 < laanwj> i don't know about useless? bitcoin core's build should have plenty of potential parallelism, i once saw a screenshot of someone building on a 64-core machine, all cores 100%, though probably this won't be the case in the latter parts of the process during linking etc which have to merge a lot of build artifacts
11:01 < laanwj> haven't personally tried with more than 8
11:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:13 < shiza> I've seen many projects having problems with more than one make job, different problems on different projects. If I remember correctly, increasing the number of parallel makes on a CI server will tend to be better than increasing the number of make jobs.
11:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:14 < shiza> Naturally, multiple Make jobs will work OK most of the time.
11:15 < shiza> But on the CI server it has to work OK all of the time, and it seems the only way to guarantee that is by running make without multiple nested jobs.
11:16 < shiza> Again I mean the only way to guarantee that for every single project generically.
11:17 < sipa> i build bitcoin core with -j48
11:17 < sipa> without ccache it takes a minute or two
11:18 < shiza> If it never fails, let's hope it stays that good forever. But there are a million different projects using or depending on Make.
11:19 < laanwj> fwiw, some other build systems (such as meson/ninja) default to number_of_cores and always assume parallelism
11:19 < shiza> Maybe what I once read was about naive projects getting lost at Make complexity.
11:20 < shiza> Don't remember clearly.
11:20 < laanwj> it's fairly easy with make to make a mistake with regard to ordering dependencies which causes issues (either errors or non-determinism) with high parallelism, if you find such a issue with bitcoin core please report it
11:21 < laanwj> i think it's more likely nowadays for projects to get this correct because everyone has multicore PCs
11:21 < sipa> ccache -C && git clean -dfx && ./autogen && ./configure --with-incompatible-bdb && time make -j48 check
11:21 < shiza> Of course I would, and I doubt I'll find them, I won't be using master normally.
11:21 < sipa> real    2m49.548s
11:21 < sipa> user    53m18.218s
11:21 < sipa> sys     4m41.772s
11:22 < sipa> (which includes 30s of the single-threaded libsecp tests)
11:23 < laanwj> that *is* fast
11:25 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
11:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:41 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
11:41 -!- tralfaz [~davterra@143.198.56.186] has quit [Remote host closed the connection]
11:41 -!- TheRec [~toto@user/therec] has quit [Read error: Connection reset by peer]
11:41 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev
11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:42 < bitcoin-git> [gui] shaavan closed pull request #437: Show received bitcoins in green (master...green-coins) https://github.com/bitcoin-core/gui/pull/437
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:50 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9013f23b0a6e...571bb94dfb50
11:50 < bitcoin-git> bitcoin/master 6c00649 Samuel Dobson: Remove outdated dummy wallet -salvagewallet arg
11:50 < bitcoin-git> bitcoin/master f963b0f Samuel Dobson: Corrupt wallet tx shouldn't trigger rescan of all wallets
11:50 < bitcoin-git> bitcoin/master bccd1d9 Samuel Dobson: Remove -rescan startup parameter
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:51 < cfields> sipa: I'm stepping through the individual minisketch ubsan warnings and making sure they're all false-positives before marking them as such. ok if I pm you with a few of the less obvious ones?
11:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:57 -!- CoinForensics [CoinForens@gateway/vpn/protonvpn/coinforensics] has joined #bitcoin-core-dev
12:00 -!- diego [~diego@179.235.12.99] has quit [Quit: WeeChat 3.2.1]
12:01 < hebasto> meeting?
12:01 < laanwj> #startmeeting
12:01 < core-meetingbot> Meeting started Thu Sep 30 19:01:54 2021 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:01 < core-meetingbot> Available commands: action commands idea info link nick
12:02 < kvaciral[m]> hi
12:02 < ariard> hi
12:02 < hebasto> hi
12:02 < jonatack> hi
12:02 < laanwj> no proposed meeting topics for this week, any last-minute ones?
12:02 < cfields> hi
12:03 < meshcollider> hi
12:03 < achow101> hi
12:03 < larryruane> Hi
12:03 < meshcollider> Proposed topic: giving fanquake permissions in the repo to block users
12:03 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
12:03 < laanwj>  #23123 this is weird, i just merged it and it's not showing as such on github
12:04 < meshcollider> laanwj: I've had that issue a few times too, so have the other maintainers, it's become quite common
12:05 < laanwj> meshcollider: i don't think he's here, might be weird to discuss it behind his back
12:05 < meshcollider> laanwj: I asked him yesterday if he was okay with me proposing it :)
12:05 < laanwj> okay
12:05 < gleb7> hi
12:06 < ariard> I see 23123 as opened on my GH
12:06 < laanwj> i'm not actually sure what priv that is, i think you need full admin privileges over the github t be able to do that
12:06 < meshcollider> e.g.  #23097 also didn't close on GH
12:07 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
12:07 < meshcollider> laanwj: yeah I think so
12:07 < gene> hi
12:07 < laanwj> #topic High priority for review
12:07 < core-meetingbot> topic: High priority for review
12:08 < laanwj> https://github.com/bitcoin/bitcoin/projects/8   7 blockers, 2 chasing concept ACK at the moment
12:08 < achow101> #22019 for me please
12:08 -!- r-ush [~r-ush@52.187.184.81] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
12:09 -!- r-ush [~r-ush@52.187.184.81] has joined #bitcoin-core-dev
12:09 < laanwj> achow101: added
12:09 < laanwj> anything else to add/remove or that is ready for merge?
12:09 -!- _aj__ is now known as _aj_
12:11 < laanwj> I think #20487 is getting close to ready
12:11 < laanwj> https://github.com/bitcoin/bitcoin/pull/20487 Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) 
12:11 < laanwj> gah no gribble
12:12 < jonatack> #21943 soon hopefully
12:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:12 < bitcoin-git> [bitcoin] meshcollider closed pull request #23123: Remove `-rescan` startup parameter (master...202109_remove_rescan) https://github.com/bitcoin/bitcoin/pull/23123
12:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:12 < laanwj> yes, that one too
12:12 < jonatack> can i add ##22932
12:13 < laanwj> jonatack: added
12:14 < laanwj> anything else?
12:15 < laanwj> #topic Giving fanquake permissions in the repo to block users (meshcollider)
12:15 < core-meetingbot> topic: Giving fanquake permissions in the repo to block users (meshcollider)
12:16 < laanwj> so we have a pretty bad spam/troll problem lately so i think it makes sense, but there doesn't seem to be a fine-grained way to give this permission
12:16 < laanwj> well maybe through the API i need to check
12:16 < meshcollider> Indeed, fanquake seems a sensible choice of person to be given the extra permissions
12:16 < achow101> I think the "maintain" permission can?
12:16 < laanwj> yes
12:18 < achow101> ack
12:19 < luke-jr> NACK
12:19 < luke-jr> fanquake merged the BIP9 consensus change without community consensus, he shouldn't have any access at this point
12:19 < meshcollider> luke-jr: please provide reasoning for your nack
12:19 < hebasto> agree to give additional permissions to fanquake
12:20 < meshcollider> This could also be something which we leave for people to discuss throughout the week and make a decision at next week's meeting too, if that's more comfortable
12:20 < meshcollider> So others that aren't online can weigh in if they have anything to say
12:20 < ariard> meshcollider: yes i agree here
12:21 < laanwj> ok...
12:21 < luke-jr> developers are not supposed to be deciding consensus changes; someone who doesn't understand that isn't suited to having roles that can be abused for it
12:22 < laanwj> i feel really uncomfortable with this behind his back, i'm ending this topic
12:22 < laanwj> any other topics?
12:22 < meshcollider> Sounds good, although he probably won't be up at 3am next week either :)
12:23 < gene> is there a good time to reschedule, so that fanquake can attend?
12:23 < laanwj> #endmeeting
12:23 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:23 < core-meetingbot> Meeting ended Thu Sep 30 19:23:10 2021 UTC.  
12:23 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-09-30-19.01.moin.txt
12:23 < laanwj> i'm sure things can be discussed outside the meeting
12:23 < gene> +1
12:23 < jonatack> laanwj: thanks for adding
12:24 < luke-jr> (I agree he should be present for any such discussion, FWIW)
12:26 -!- Guest92 [~Guest92@p200300f1171dcd00492658d988dcfa1b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
12:27 < Guest92> luke-jr: Seeing how the pr you refer to hasn't been reverted since, doesn't that mean the other maintainers implicitly endorsed it (and thus, should als be fired in your logic)?
12:29 < meshcollider> +1 on discussing when he's online, just thought the meeting was a good place to propose it formally 
12:29 < meshcollider> luke-jr: (Which PR is this specifically anyway?)
12:29 -!- TallTim [~TallTim@184-83-239-155-dynamic.midco.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
12:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:37 -!- Guest92 [~Guest92@p200300f1171dcd00492658d988dcfa1b.dip0.t-ipconnect.de] has quit [Quit: Client closed]
12:39 -!- TallTim [~TallTim@184-83-239-155-dynamic.midco.net] has joined #bitcoin-core-dev
12:39 < luke-jr> meshcollider: #21377
12:41 < laanwj> meshcollider: yes, imo good idea to bring it up
12:43 -!- CoinForensics [CoinForens@gateway/vpn/protonvpn/coinforensics] has quit [Ping timeout: 252 seconds]
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:44 < bitcoin-git> [gui] achow101 opened pull request #441: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin-core/gui/pull/441
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:44 < bitcoin-git> [bitcoin] achow101 closed pull request #18789: qt: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin/bitcoin/pull/18789
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:44 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
12:45 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
12:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:56 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
13:03 -!- Neojack [Neojack@pear.bnc4free.com] has quit [Ping timeout: 250 seconds]
13:03 -!- pigeons [~pigeons@androzani.sysevolve.com] has quit [Ping timeout: 240 seconds]
13:04 -!- rockhouse [~rockhouse@user/rockhouse] has quit [Ping timeout: 250 seconds]
13:04 -!- takinbo [~takinbo@user/takinbo] has quit [Ping timeout: 250 seconds]
13:04 -!- emzy [~quassel@user/emzy] has quit [Ping timeout: 260 seconds]
13:05 -!- doubleqp [~doubleqp@162.55.6.42] has quit [Ping timeout: 260 seconds]
13:06 -!- rockhouse [~rockhouse@user/rockhouse] has joined #bitcoin-core-dev
13:06 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev
13:06 -!- takinbo [~takinbo@user/takinbo] has joined #bitcoin-core-dev
13:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
13:07 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
13:07 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Read error: Connection reset by peer]
13:07 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has quit [Read error: Connection reset by peer]
13:07 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Read error: Connection reset by peer]
13:07 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Write error: Connection reset by peer]
13:07 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Read error: Connection reset by peer]
13:07 -!- vasild [~vd@user/vasild] has quit [Read error: Connection reset by peer]
13:07 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Read error: Connection reset by peer]
13:07 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
13:07 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
13:07 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev
13:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:08 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
13:08 -!- doubleqp [~doubleqp@162.55.6.42] has joined #bitcoin-core-dev
13:08 -!- Neojack [Neojack@pear.bnc4free.com] has joined #bitcoin-core-dev
13:09 -!- pigeons [~pigeons@androzani.sysevolve.com] has joined #bitcoin-core-dev
13:10 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
13:12 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev
13:12 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:12 < bitcoin-git> [bitcoin] kiminuo closed pull request #21577: refactor: Remove superfluous "return" from "addUnchecked" in txmempool.cpp (master...feature/2021-04-02-superfluous-return) https://github.com/bitcoin/bitcoin/pull/21577
13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:24 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
13:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:40 < yanmaani> why'd you take out the -rescan?
13:41 < yanmaani> I recall having problems that caused Core to not start, but it didn't offer to do a rescan.
13:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:48 -!- tripleslash [~triplesla@user/tripleslash] has quit [Ping timeout: 252 seconds]
13:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:53 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
13:54 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
13:55 -!- Guest2123 [~Guest2123@185.49.110.238] has joined #bitcoin-core-dev
13:56 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
14:00 -!- Guest2123 [~Guest2123@185.49.110.238] has quit [Quit: Client closed]
14:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:10 < yanmaani> Has it been discussed to standardize all the argument parsing boilerplate in the RPCs?
14:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:24 -!- Guyver2 [~Guyver@2001:985:f3f:1:9897:b926:f3e9:ee7a] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:28 < luke-jr> yanmaani: are you confusing -rescan with -reindex?
14:28 < luke-jr> yanmaani: what "boilerplate" do you mean?
14:29 < luke-jr> I tried this but no review: https://github.com/bitcoin/bitcoin/pull/17356
14:30 < luke-jr> (can rebase if people say they want to review..)
14:33 < sipa> yanmaani: -rescan in happy cases is _never_ necessary; the wallet stores itself up to where it is in sync (since 0.3.21; 2011) and will at startup rescan whatever part is necessary
14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:33 < bitcoin-git> [bitcoin] meshcollider opened pull request #23147: trivial refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (master...202110_rename_rescan_enum) https://github.com/bitcoin/bitcoin/pull/23147
14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:34 < bitcoin-git> [bitcoin] meshcollider closed pull request #23141: test: Fix intermitent failure in wallet_basic.py (master...202109_fix_test_rounding) https://github.com/bitcoin/bitcoin/pull/23141
14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:34 < sipa> and it's very annoying with the introduction of multiwallet, as now wallets can be loaded and unloaded on demand, rather than always being a single wallet at startup thing
14:34 < sipa> so there is a rescan RPC instead now, if you really need it
14:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:53 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
14:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:08 -!- tralfaz is now known as davterra
15:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:19 < yanmaani> luke-jr: sorry, yeah, I mean reindex.
15:22 < yanmaani> luke-jr: yeah, that would be very cool and clean up a lot of code. Does this fix the part where you have to specify the types separately for the docs and for the CLI too?
15:27 < yanmaani> e.g. on lines 566-567 of your patch, it specifies bantime is RPCArg::Type::NUM and absolute is BOOL. But you also need to, in /src/rpc/client.cpp (lines 160-161), specify that bantime and absolute are non-string RPC arguments that need to be converted from JSON.
15:28 < yanmaani> Likewise with the default values, which are (correct me if I'm wrong here) implemented by checking if(null) value = myDefault, but also specified (unchecked!) in the docs. Which is a violaiton of DRY and generally ungainly
15:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:32 < yanmaani> also, I think I'm missing something - most methods invoke RPCTypeCheck() on their request, but setban doesn't, even before your PR. Is this intentional? Would your PR obviate the need for it?
15:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:35 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
15:35 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
15:38 < meshcollider> yanmaani: We don't need to typecheck optional parameters that use e.g. get_int, get_str, get_bool, etc. because those functions will typecheck when called
15:39 < meshcollider> setban uses get_str and get_int64
15:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:46 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
15:48 -!- __nick__ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 252 seconds]
15:51 -!- bijoo [~bijoo@96.86.11.105] has quit [Quit: Client closed]
15:54 -!- Guest64 [~Guest64@a85-15-119-151.pppoe.vtelecom.ru] has joined #bitcoin-core-dev
15:56 < Guest64> Guys, hello. Tell me who's in the subject. I send a certain amount of money from Bitcoin Core to a Bitcoin address, the commission is generally acceptable. But the balance of the wallet itself is reduced by an amount that is 42 times more than the amount of funds sent. I canceled the operation. What can be wrong?
15:58 < yanmaani> meshcollider: ohh, right
15:58 < yanmaani> So the need for that would be a separate patch, yes?
15:59 < yanmaani> (1) default values, (2) non-string arguments in RPC client, and (3) RPCTypeCheck
16:01 < meshcollider> yanmaani: as I said, we don't need RPCTypeCheck? Not sure what you mean
16:01 < jonatack> yanmaani: have a look in src/univalue/lib/univalue_get.cpp for the get_int, get_str, get_bool, etc. type checking, if you're curious
16:01 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 250 seconds]
16:04 < yanmaani> meshcollider: I'm asking if luke-jr's patch would obviate the need for RPCTypeCheck.
16:05 < yanmaani> Or if that would be a separate thing.
16:05 < yanmaani> (Or if it's not needed in new code)
16:05 < yanmaani> jonatack: right, but that only works for primitive/normal types, right?
16:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:10 < jonatack> yanmaani: best to review it :)  ...from looking at it quickly, the patch seems to add named args. so that for instance, instead of:
16:10 < jonatack> bool absolute{request.params[3].isTrue() ? true : false)
16:10 < jonatack> we could write
16:10 < jonatack> bool absolute{request.m_params["absolute"].isTrue() ? true : false)
16:12 < jonatack> er, more correct examples: const bool absolute{request.params[3].isTrue() ? true : false}; -> const bool absolute{request.m_params["absolute"].isTrue() ? true : false};
16:12 < jonatack> etc.
16:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:15 -!- Guest64 [~Guest64@a85-15-119-151.pppoe.vtelecom.ru] has quit [Quit: Client closed]
16:20 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
16:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:32 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
16:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:22 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
17:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:47 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
17:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:54 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
17:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:58 < bitcoin-git> [bitcoin] dongcarl opened pull request #23148: build: Fix guix linker-loader path and add symbol-checks (master...2021-09-fix-loader-quick) https://github.com/bitcoin/bitcoin/pull/23148
17:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:12 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 252 seconds]
18:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:25 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
18:26 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
18:28 -!- Guest8342 [~Guest83@ptr-cloxibpae9k8qpi9ih6.18120a2.ip6.access.telenet.be] has joined #bitcoin-core-dev
18:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:35 -!- Guest8342 [~Guest83@ptr-cloxibpae9k8qpi9ih6.18120a2.ip6.access.telenet.be] has quit [Quit: Client closed]
18:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:54 < yanmaani> jonatack: Yeah, I understand that bit. Well, it looks really good, I hope it gets merged!
19:00 -!- Guest17 [~Guest17@c-73-160-42-82.hsd1.nj.comcast.net] has joined #bitcoin-core-dev
19:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:14 -!- Guest17 [~Guest17@c-73-160-42-82.hsd1.nj.comcast.net] has quit [Quit: Client closed]
19:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:36 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
19:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/571bb94dfb50...33b0696d3106
19:40 < bitcoin-git> bitcoin/master 8615507 Samuel Dobson: scripted-diff: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN
19:40 < bitcoin-git> bitcoin/master 33b0696 fanquake: Merge bitcoin/bitcoin#23147: refactor: rename DBErrors::RESCAN_REQUIRED to...
19:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:47 < bitcoin-git> [bitcoin] fanquake closed pull request #23147: refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (master...202110_rename_rescan_enum) https://github.com/bitcoin/bitcoin/pull/23147
19:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:26 -!- dermoth [~dermoth@dsl-199-102-159-155.mtl.aei.ca] has quit [Ping timeout: 260 seconds]
20:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:31 < bitcoin-git> [bitcoin] fanquake opened pull request #23149: build: make --enable-werror just -Werror (master...make_enable_werror_full_werror) https://github.com/bitcoin/bitcoin/pull/23149
20:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:39 -!- dermoth [~dermoth@dial-216-221-45-39.mtl.aei.ca] has joined #bitcoin-core-dev
20:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
21:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Client Quit]
21:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:24 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Quit: bye]
21:25 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
21:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:29 < bitcoin-git> [bitcoin] evil-maid opened pull request #23150: Update README.md - grammar fixes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23150
21:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:34 < bitcoin-git> [bitcoin] fanquake closed pull request #23150: Update README.md - grammar fixes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23150
21:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:59 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
22:00 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection]
22:00 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev
22:03 -!- jarthur [~jarthur@2603-8080-1540-002d-5422-0cb4-aeaf-4572.res6.spectrum.com] has quit [Ping timeout: 246 seconds]
22:04 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
22:06 -!- jarthur [~jarthur@2603-8080-1540-002d-bcfd-e74c-43c9-4dcf.res6.spectrum.com] has joined #bitcoin-core-dev
22:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:28 < shiza> Happy hacktoberfest!
22:29 < fanquake> Does that mean we're about to get a flood of trivial / low quality PRs, that pay no attention to our contributing guidelines
22:32 < shiza> Yea.
22:34 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:34 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
22:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:39 < shiza> Hadn't noticed you had already closed the first one.
22:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:44 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds]
22:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:03 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
23:03 -!- contrapumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev
23:04 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev
23:04 -!- doubleqp9 [~doubleqp@162.55.6.42] has joined #bitcoin-core-dev
23:04 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:06 -!- jrawsthorne_ [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
23:06 -!- raj [~raj@2602:ffb6:4:e396:f816:3eff:fe47:ca2a] has joined #bitcoin-core-dev
23:06 -!- nathanael_ [~nathanael@user/nathanael] has joined #bitcoin-core-dev
23:07 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev
23:09 -!- kexkey_ [~kexkey@static-198-54-132-172.cust.tzulo.com] has joined #bitcoin-core-dev
23:10 -!- murrayn_ [~murray@static.38.4.181.135.clients.your-server.de] has joined #bitcoin-core-dev
23:10 -!- niska` [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
23:11 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
23:11 -!- ryanofsky_ [~russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
23:14 -!- Netsplit *.net <-> *.split quits: niska, chaotic_good, doubleqp, promag, kexkey, core-meetingbot, pigeons, davterra, ravish0007, raj_,  (+7 more, use /NETSPLIT to show all of them)
23:14 -!- doubleqp9 is now known as doubleqp
23:14 -!- ryanofsky_ is now known as ryanofsky
23:16 -!- Netsplit over, joins: pigeons, promag, ravish0007, chaotic_good
23:17 -!- murrayn_ [~murray@static.38.4.181.135.clients.your-server.de] has quit [Quit: ZNC 1.8.2 - https://znc.in]
23:18 -!- murrayn [~murray@static.38.4.181.135.clients.your-server.de] has joined #bitcoin-core-dev
23:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/33b0696d3106...4e1de1fc5905
23:19 < bitcoin-git> bitcoin/master 0dc8bf5 Niklas Gögge: [net processing] Dont request compact blocks in blocks-only mode
23:19 < bitcoin-git> bitcoin/master 5bf6587 Niklas Gögge: [test] Test that -blocksonly nodes do not request high bandwidth mode.
23:19 < bitcoin-git> bitcoin/master 5e231c1 Niklas Gögge: [test] Test that -blocksonly nodes do not send getdata(CMPCT) on a low ban...
23:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:19 -!- murrayn [~murray@static.38.4.181.135.clients.your-server.de] has quit [Changing host]
23:19 -!- murrayn [~murray@user/murrayn] has joined #bitcoin-core-dev
23:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:26 -!- pigeons_ [~pigeons@androzani.sysevolve.com] has joined #bitcoin-core-dev
23:26 -!- chaotic_good_ [~chaotic_g@irc.chaoticgood.sh] has joined #bitcoin-core-dev
23:26 -!- pigeons [~pigeons@androzani.sysevolve.com] has quit [Ping timeout: 252 seconds]
23:26 -!- chaotic_good [~chaotic_g@irc.chaoticgood.sh] has quit [Ping timeout: 252 seconds]
23:27 -!- commmon [~common@096-033-221-075.res.spectrum.com] has quit [Remote host closed the connection]
23:29 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
23:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:45 < laanwj> first one already? this is absurd, you can set your watch to it
23:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:54 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
23:56 -!- paulo [paulo@user/paulo/x-9032687] has quit [Remote host closed the connection]
23:56 -!- meshcollider [meshcollid@user/meshcollider] has quit [Remote host closed the connection]
23:56 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 252 seconds]
--- Log closed Fri Oct 01 00:00:23 2021