--- Log opened Sun Oct 03 00:00:11 2021
--- Day changed Sun Oct 03 2021
00:00 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
00:05 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 245 seconds]
00:05 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
00:06 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
00:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:21 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Ping timeout: 252 seconds]
00:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:26 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
00:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:31 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
00:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:36 -!- earnest [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:39 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds]
00:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
00:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
00:46 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
00:46 -!- Talkless [~Talkless@m83-179-92-235.cust.tele2.lt] has quit [Read error: Connection reset by peer]
00:48 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has joined #bitcoin-core-dev
00:52 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 245 seconds]
00:52 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
00:53 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 252 seconds]
00:56 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds]
00:58 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
00:58 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
01:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:20 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Ping timeout: 252 seconds]
01:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:45 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has joined #bitcoin-core-dev
01:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
01:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
01:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:03 -!- kexkey [~kexkey@static-198-54-132-92.cust.tzulo.com] has quit [Ping timeout: 246 seconds]
02:05 -!- kexkey [~kexkey@static-198-54-132-156.cust.tzulo.com] has joined #bitcoin-core-dev
02:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:17 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Ping timeout: 252 seconds]
02:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
02:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
02:45 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has joined #bitcoin-core-dev
02:49 < yanmaani> how do you add comments on the code on github? it doesn't seem to let me
02:50 < yanmaani> am I just stupid or is it locked down somehow?
02:51 < hebasto> yanmaani: in the "Files changed" tab select line(s) you want to comment first
02:51 < yanmaani> hebasto: I click the line and it goes yellow, is there something more I need to do?
02:52 < yanmaani> usually there's two sets of plus signs
02:53 < hebasto> comments are available for lines that actually modified; if it goes yellow then it is not modified
02:54 < yanmaani> Wait, so I can't review added lines, just lines that are modified?
02:54 < yanmaani> The line is green and has a plus to the left
02:54 < yanmaani> huh, just reloading the page fixed it, please forget we ever had this conversation
03:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:17 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Ping timeout: 252 seconds]
03:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:42 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has joined #bitcoin-core-dev
03:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
03:53 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
03:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
03:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
04:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
04:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:14 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Ping timeout: 252 seconds]
04:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:21 -!- skeels [~skeels@103.10.29.109] has joined #bitcoin-core-dev
04:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:29 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
04:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:33 -!- Henrik [~textual@84.212.107.177] has quit [Client Quit]
04:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:42 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has joined #bitcoin-core-dev
04:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:51 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
04:51 -!- Henrik [~textual@84.212.107.177] has quit [Client Quit]
04:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
04:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
04:59 -!- skeels [~skeels@103.10.29.109] has quit [Quit: Leaving]
05:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:11 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:11 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:14 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
05:14 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Ping timeout: 252 seconds]
05:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:37 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
05:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:46 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has joined #bitcoin-core-dev
05:49 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 252 seconds]
05:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
05:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
05:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:03 -!- Talkless [~Talkless@m83-179-92-235.cust.tele2.lt] has joined #bitcoin-core-dev
06:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:07 -!- Talkless [~Talkless@m83-179-92-235.cust.tele2.lt] has quit [Client Quit]
06:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:13 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
06:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:55 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
06:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
06:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:07 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
07:08 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
07:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:12 < michaelfolkson> prayank: I agree more should be discussed openly even when it is uncomfortable and more time consuming. I definitely feel some are pushing consistently to not have any discussion in public and that makes me uncomfortable
07:13 < michaelfolkson> prayank: Having said that I don't think storing up a list of feedback for an individual and drop it when they are proposed as a maintainer isn't the best way to provide feedback
07:14 < michaelfolkson> *is the best way
07:14 < michaelfolkson> If you don't like something someone has done you should feel free to raise it here or on the mailing list at the time
07:18 -!- mikehu44 [~quassel@206.189.41.250] has quit [Read error: Connection reset by peer]
07:18 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
07:19 < michaelfolkson> I'd like fanquake to engage here with prayank on the specific concerns he's raised. And prayank to provide specific details of the PR numbers etc so he can take a look at them
07:19 -!- mikehu44 [~quassel@206.189.41.250] has quit [Read error: Connection reset by peer]
07:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:24 < michaelfolkson> Although this is proposed to fight spam it is a significant increase in permissions over the repo. It is a shame GitHub doesn't have more finegrained permissions
07:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:29 < michaelfolkson> On the Taproot activation params issue I think it is unfair to pin that responsibility on one maintainer because he merged it. No other maintainer has commented afaik that they disagreed with the merge decision
07:30 < michaelfolkson> If another maintainer had commented that they had disagreed with the merge decision then we would be in a different place. But they haven't and so in that sense I think it can be perceived as a maintainer team decision rather than an individual maintainer decision
07:34 < michaelfolkson> Anyone is free to disagree with that decision but using that as a reason to not give someone more permissions seems unfair to me
07:34 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
07:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:43 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:43 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:45 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds]
07:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
07:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
07:50 < darosior> +1 on giving more permissions to fanquake.
07:50 < darosior> These accusations on Taproot activation strike me as backed by the belief that maintainers would decide the network rules. Correct me if i'm wrong but code is integrated to the repo after being evaluated on a technical basis, not a political one. The PR was reviewed and acknowledged as technically right by contributors knowledgeable in this area.
07:50 < darosior> As such i think this makes any objection to giving a maintainer more permission based on the merge of this PR invalid.
07:50 < darosior> Another (pretty confused) objection was raised. I would like to ask the objector to first clarify any *objective* concern they might have and second to explain how the proposed increase in permission would make any concern worse (if there is any valid one in the first place).
07:52 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
07:53 -!- Henrik [~textual@84.212.107.177] has quit [Client Quit]
07:56 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
07:57 < michaelfolkson> darosior: I wouldn't say "political" but there is definitely a community consensus element to decisions like activation params
07:58 < michaelfolkson> Some decisions have technical arguments on both sides. Doesn't mean that that is somehow political and avoiding technical discussion
08:00 < michaelfolkson> There is also assessing the ACKs, NACKs on a PR which has a lot of subtlety when deciding on whether or when to merge a PR. Again I wouldn't call that political but you can if you want
08:01 < michaelfolkson> For example you are free to disagree with Luke but it would be hard to claim he is not a contributor knowledgeable in the area of soft fork activation
08:03 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds]
08:05 < michaelfolkson> And for the record I don't have a problem with the activation params merge decision. I thought it was the slightly inferior solution and thought Luke had strong arguments but based on reviews I don't think it was wrong to merge it
08:05 < darosior> On your last point: i certainly don't claim this, fwiw. His disapproval of 21686 wasn't based on any technical basis?
08:05 < darosior> But i don't want to rehash this again tbf :)
08:06 < michaelfolkson> darosior: "His disapproval of 21686 wasn't based on any technical basis?" I think it was more community consensus but then that community consensus was built up initially around a technical solution (BIP 8). And he thought BIP 8 was superior that what was merged
08:07 < michaelfolkson> darosior: But yeah rehashing history :)
08:10 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
08:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:25 < michaelfolkson> I'm also a +1 on fanquake permissions
08:25 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
08:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:37 -!- mikehu44 [~quassel@206.189.41.250] has quit [Read error: Connection reset by peer]
08:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
08:53 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
08:54 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit]
08:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
08:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:07 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:21 < darosior> achow101: in descriptor_tests, DoCheck assumes a descriptor with xpubs has no raw keys https://github.com/bitcoin/bitcoin/blob/446b706696451ae1a66ac416f347d734c5741d7c/src/test/descriptor_tests.cpp#L190-L208 . Descriptors with both are supported, right? Just want to be sure
09:22 < achow101> yes
09:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:35 -!- TallTim__ is now known as TallTim
09:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:42 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
09:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
09:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
09:51 < jarolrod> fanquake is a very active maintainer for a decent amount of time now. fanquake is almost always the first to get rid of spam issues and comments. I don't understand opposition to allow him to deal with spam users.
09:53 < fjahr> +1 for giving required permissions to block spammers to fanquake. I think he is doing great work as a maintainer.
09:54 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
09:57 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
10:00 < TallTim> Slow sunday question - Is Taproot "active" at blockheight 709,632 - I realize its locked in...
10:01 < TallTim> Given that we're approx 703,390 now
10:01 < sipa> 6 weeks
10:02 < TallTim> roger that
10:03 < sipa> +- nov 16th
10:04 < michaelfolkson> jarolrod: This isn't specific to fanquake but this is a significant increase in permissions due to lack of granularity in GitHub permissions. I don't think there is a problem to have a discussion on concerns people have
10:04 < michaelfolkson> If there was a GitHub permission to just deal with spam this would be a no brainer
10:07 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
10:10 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
10:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:16 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds]
10:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:24 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 252 seconds]
10:26 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
10:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:32 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
10:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:36 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:36 -!- Talkless [~Talkless@mail.dargis.net] has quit [Client Quit]
10:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:40 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
10:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:41 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
10:45 -!- kabaum [~kabaum@h-46-59-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 252 seconds]
10:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
10:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
10:52 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
10:53 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit]
10:57 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
10:57 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
10:57 -!- kabaum [~kabaum@h-46-59-13-35.a163.priv.bahnhof.se] has joined #bitcoin-core-dev
11:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:12 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
11:14 -!- dviola [~diego@179.235.12.99] has quit [Changing host]
11:14 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
11:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:20 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
11:21 -!- Henrik [~textual@84.212.107.177] has quit [Client Quit]
11:24 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
11:33 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:1834:cb58:2698:81ad] has quit [Remote host closed the connection]
11:33 -!- jarthur [~jarthur@2603-8080-1540-002d-3171-5bf3-53f0-51fc.res6.spectrum.com] has joined #bitcoin-core-dev
11:35 -!- jarthur [~jarthur@2603-8080-1540-002d-3171-5bf3-53f0-51fc.res6.spectrum.com] has quit [Client Quit]
11:37 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
11:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:42 -!- kabaum [~kabaum@h-46-59-13-35.a163.priv.bahnhof.se] has quit [Ping timeout: 252 seconds]
11:46 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
11:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
11:58 -!- jespada [~jespada@2803:9800:9842:7a62:54d3:aa01:71e2:7a22] has joined #bitcoin-core-dev
12:01 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:04 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:e010:bbd3:9c44:588c] has joined #bitcoin-core-dev
12:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:13 -!- kabaum [~kabaum@h-46-59-13-35.a163.priv.bahnhof.se] has joined #bitcoin-core-dev
12:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:20 < bitcoin-git> [gui] luke-jr opened pull request #444: Qt: Network Watch tool (master...gui_netwatch) https://github.com/bitcoin-core/gui/pull/444
12:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:30 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
12:30 -!- commmon is now known as common
12:31 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Changing host]
12:31 -!- common [~common@user/common] has joined #bitcoin-core-dev
12:34 -!- kabaum [~kabaum@h-46-59-13-35.a163.priv.bahnhof.se] has quit [Ping timeout: 252 seconds]
12:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
12:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
12:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:02 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
13:06 -!- mikehu44 [~quassel@206.189.41.250] has quit [Read error: Connection reset by peer]
13:08 -!- Victorsueca [~Victorsue@user/victorsueca] has joined #bitcoin-core-dev
13:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:19 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
13:21 -!- mikehu44 [~quassel@206.189.41.250] has quit [Read error: Connection reset by peer]
13:23 -!- haakon_ is now known as haakon
13:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:48 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
13:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
13:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
13:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:23 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:34 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
14:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
14:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
14:57 -!- jespada [~jespada@2803:9800:9842:7a62:54d3:aa01:71e2:7a22] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:06 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:06 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
15:51 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds]
15:52 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
15:53 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
15:54 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Client Quit]
15:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
15:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:04 -!- jespada [~jespada@2803:9800:9842:7a62:54d3:aa01:71e2:7a22] has joined #bitcoin-core-dev
16:08 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:e010:bbd3:9c44:588c] has quit [Remote host closed the connection]
16:11 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
16:11 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
16:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:17 -!- belcher_ [~belcher@user/belcher] has quit [Read error: Connection reset by peer]
16:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:32 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
16:35 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
16:39 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:e010:bbd3:9c44:588c] has joined #bitcoin-core-dev
16:40 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com]
16:42 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
16:44 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:e010:bbd3:9c44:588c] has quit [Ping timeout: 252 seconds]
16:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
16:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
16:49 -!- jespada [~jespada@2803:9800:9842:7a62:54d3:aa01:71e2:7a22] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:51 -!- orange_apple [~orange_ap@2800:810:443:1db4::1001] has joined #bitcoin-core-dev
16:54 -!- orange_apple [~orange_ap@2800:810:443:1db4::1001] has quit [Quit: Leaving]
16:58 -!- AaronvanW [~AaronvanW@c-174-61-29-13.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
17:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:03 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
17:07 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:13 -!- AaronvanW [~AaronvanW@c-174-61-29-13.hsd1.fl.comcast.net] has quit [Ping timeout: 252 seconds]
17:13 -!- earnest [~earnest@user/earnestly] has quit [Ping timeout: 245 seconds]
17:17 -!- c_arc_ [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:21 -!- c_arc_ [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:35 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:e010:bbd3:9c44:588c] has joined #bitcoin-core-dev
17:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
17:58 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
17:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:02 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
18:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:16 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
18:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
18:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:05 < bitcoin-git> [bitcoin] meshcollider closed pull request #23090: Deprecate `main` and `test` `-chain` params (master...20210924) https://github.com/bitcoin/bitcoin/pull/23090
19:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:49 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
19:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
19:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
19:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:12 -!- c_arc_ [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:16 -!- c_arc_ [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:16 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:27 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:27 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
20:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
20:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:03 -!- panpan [~panpan@dolos.media.mit.edu] has joined #bitcoin-core-dev
21:03 -!- ogola [~ogola@dolos.media.mit.edu] has joined #bitcoin-core-dev
21:05 -!- sdfgsdfgDropBear [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev
21:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:18 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
21:20 < prayank> michaelfolkson: I don't have personal issues with anyone. Neither I know anyone enough to even have one. We are strangers from different culture and background interacting online and have similar goals. Trying to keep it professional, I will always share my honest opinion on things. I have appreciated things I like and will criticize things I don't like.
21:20 < prayank> 4 points I mentioned are good enough to be considered and I agree I should have discussed them earlier. Apologize if timing was incorrect or used wrong words.
21:24 -!- AaronvanW [~AaronvanW@2601:586:4a00:b860:e010:bbd3:9c44:588c] has quit [Remote host closed the connection]
21:33 < meshcollider> Review beg for #17211, it is finally close to merge
21:33 <@gribble> https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
21:34 < meshcollider> yanmaani: you may like to re-review ^
21:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:45 < yanmaani> meshcollider: thanks. nothing I saw was blocking at all but will take a look!
21:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
21:51 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer]
21:55 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
21:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
21:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:04 < yanmaani> done
22:08 < prayank> yanmaani: crACK is for code review only
22:08 < yanmaani> what does it ... mean? "Code review ACK"?
22:09 < prayank> Reviewed code. Found no issues.
22:09 < prayank> AFAIK
22:10 < yanmaani> ohh didn't find it documented anywhere
22:12 < yanmaani> > After conceptual agreement on the change, code review can be provided. A review begins with ACK BRANCH_COMMIT, where BRANCH_COMMIT is the top of the PR branch, followed by a description of how the reviewer did the review. The following language is used within pull request comments:
22:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:13 < bitcoin-git> [bitcoin] fanquake opened pull request #23168: build: no-longer fail default configure if BDB isn't available (master...dont_fail_no_bdb_default_configure) https://github.com/bitcoin/bitcoin/pull/23168
22:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:15 -!- sdfgsdfgDropBear [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: sdfgsdfgDropBear]
22:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:42 < jarolrod> yanmaani: see #22966. While these shorthands are used, the consensus is to discourage placing any real meaning behind them. All these variations should just be treated as an ACK, and the reviewer is asked to elaborate.
22:42 <@gribble> https://github.com/bitcoin/bitcoin/issues/22966 | doc: Improve documentation around the ACK statement by jarolrod · Pull Request #22966 · bitcoin/bitcoin · GitHub
22:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:50 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
22:54 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
22:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
22:58 -!- sdfgsdfgDropBear [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev
23:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:03 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
23:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:05 < bitcoin-git> [bitcoin] martinus opened pull request #23169: Fix `-Wmaybe-uninitialized` warnings found by building with `-flto` (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
23:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:21 -!- kabaum [~kabaum@h-46-59-13-35.a163.priv.bahnhof.se] has joined #bitcoin-core-dev
23:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection]
23:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
23:43 -!- common [~common@user/common] has quit [Remote host closed the connection]
23:44 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
23:48 < michaelfolkson> yanmaani: The guidance in the docs (which ideally everyone should follow) is to write Code Review ACK commit_hash or ACK commit_hash Reviewed code by doing... rather than abbreviated crACK or whatever
23:48 < michaelfolkson> Habits die hard though :)
23:59 -!- prayank [~andr0irc@51.158.144.31] has quit [Read error: Connection reset by peer]
--- Log closed Mon Oct 04 00:00:26 2021