--- Log opened Thu Oct 07 00:00:28 2021 00:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:03 -!- raj [~raj@2602:ffb6:4:e396:f816:3eff:fe47:ca2a] has quit [Killed (NickServ (GHOST command used by raj_!uid72176@user/raj))] 00:03 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 00:03 -!- raj [~raj@167.182.81.172.lunanode-rdns.com] has joined #bitcoin-core-dev 00:04 -!- raj [~raj@167.182.81.172.lunanode-rdns.com] has quit [Killed (NickServ (GHOST command used by raj_!uid72176@user/raj))] 00:04 -!- raj_ [~raj@2602:ffb6:4:e396:f816:3eff:fe47:ca2a] has joined #bitcoin-core-dev 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8911de619d4...b4437d7dfe23 00:10 < bitcoin-git> bitcoin/master fa2ac58 MarcoFalke: test: Replace satoshi_round with int() or Decimal() 00:10 < bitcoin-git> bitcoin/master b4437d7 MarcoFalke: Merge bitcoin/bitcoin#23210: test: Replace satoshi_round with int() or Dec... 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23210: test: Replace satoshi_round with int() or Decimal() (master...2110-testRound) https://github.com/bitcoin/bitcoin/pull/23210 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:41 -!- saranshsharma [~saranshsh@202.142.67.118] has joined #bitcoin-core-dev 00:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:49 -!- saranshsharma [~saranshsh@202.142.67.118] has quit [Ping timeout: 245 seconds] 00:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 00:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 00:57 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Remote host closed the connection] 00:58 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4437d7dfe23...c0b6c96eee7c 01:00 < bitcoin-git> bitcoin/master 502f50d Jon Atack: Test transactions conflicted by double spend in listtransactions 01:00 < bitcoin-git> bitcoin/master c0b6c96 MarcoFalke: Merge bitcoin/bitcoin#23146: Test transactions conflicted by double spend ... 01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:00 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146 01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:07 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 01:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:24 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev 01:25 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 265 seconds] 01:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:43 -!- saranshsharma [~saranshsh@202.142.67.118] has joined #bitcoin-core-dev 01:45 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 265 seconds] 01:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 01:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 01:54 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23213: rest: Return error when header count is not integral (master...2110-restInt) https://github.com/bitcoin/bitcoin/pull/23213 02:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:00 -!- midnight [~midnight@user/midnight] has quit [Quit: quit] 02:00 -!- cold [~cold@user/cold] has quit [Quit: Quitting...] 02:02 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev 02:03 -!- kexkey [~kexkey@static-198-54-132-156.cust.tzulo.com] has quit [Ping timeout: 245 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-172.cust.tzulo.com] has joined #bitcoin-core-dev 02:06 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev 02:10 -!- dermoth [~dermoth@dsl-66-36-141-108.mtl.aei.ca] has joined #bitcoin-core-dev 02:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:13 < bitcoin-git> [gui] promag opened pull request #448: qt: Add helper to load font (master...2021-10-font-helper) https://github.com/bitcoin-core/gui/pull/448 02:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:14 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev 02:15 -!- greypw25 [~greypw2@grey.pw] has quit [Read error: Connection reset by peer] 02:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:15 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23214: Replace stoul with ToIntegral in dbwrapper (master...2110-dbwInt) https://github.com/bitcoin/bitcoin/pull/23214 02:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:31 < darosior> maintainers: #22539 looks close to be ready for merge 02:31 <@gribble> https://github.com/bitcoin/bitcoin/issues/22539 | Re-include RBF replacement txs in fee estimation by darosior · Pull Request #22539 · bitcoin/bitcoin · GitHub 02:38 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:38 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:38 < laanwj> darosior: will take a look, thanks 02:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:46 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 02:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 02:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 02:52 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 02:54 -!- mikehu44 [~quassel@206.189.41.250] has quit [Read error: Connection reset by peer] 02:55 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 03:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:12 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:12 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:12 < bitcoin-git> [bitcoin] hebasto opened pull request #23215: ci: Add vcpkg downloads cache (master...211007-ci) https://github.com/bitcoin/bitcoin/pull/23215 03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:16 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23216: clang-format: Set BraceWrapping:AfterControlStatement:MultiLine (master...2110-srcFormat) https://github.com/bitcoin/bitcoin/pull/23216 03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:17 -!- saranshsharma [~saranshsh@202.142.67.118] has quit [Remote host closed the connection] 03:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 03:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 03:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:02 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Remote host closed the connection] 04:02 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 04:06 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:08 < bitcoin-git> [bitcoin] hebasto opened pull request #23217: [DO NOT MERGE] ci: Test required resources for native Windows tasks (master...211007-mem) https://github.com/bitcoin/bitcoin/pull/23217 04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:10 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 04:14 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:16 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev 04:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:27 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:31 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23218: p2p: Use mocktime for ping timeout (master...2110-mockPingTime) https://github.com/bitcoin/bitcoin/pull/23218 04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:37 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev 04:39 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 04:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 04:41 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 04:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b6c96eee7c...6f0cbc75be76 04:48 < bitcoin-git> bitcoin/master 06c5ce9 Antoine Poinsot: Re-include RBF replacement txs in fee estimation 04:48 < bitcoin-git> bitcoin/master 053415b Antoine Poinsot: qa: split run_test into smaller parts 04:48 < bitcoin-git> bitcoin/master 4556406 Antoine Poinsot: qa: test fee estimation with replacement transactions 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] laanwj merged pull request #22539: Re-include RBF replacement txs in fee estimation (master...fee_est_rbf) https://github.com/bitcoin/bitcoin/pull/22539 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 04:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 04:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:02 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:08 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 265 seconds] 05:08 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds] 05:11 -!- yakshaver [yakshaver@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 05:11 -!- yakshaver [yakshaver@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev 05:11 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 05:12 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev 05:13 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Client Quit] 05:15 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev 05:25 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.3] 05:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:39 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6f0cbc75be76...6334ff7364e2 05:39 < bitcoin-git> bitcoin/master 64085b3 W. J. van der Laan: util: Add __NR_copy_file_range syscall constant for sandbox 05:39 < bitcoin-git> bitcoin/master ac402e7 W. J. van der Laan: util: Conditionalize some syscalls in syscall name table 05:39 < bitcoin-git> bitcoin/master 6334ff7 W. J. van der Laan: Merge bitcoin/bitcoin#23196: util: Make syscall sandbox compilable with ke... 05:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:40 < bitcoin-git> [bitcoin] laanwj merged pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196 05:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 05:50 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 05:53 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev 05:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 05:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:09 -!- DeanGuss [~dean@user/deanguss] has quit [Quit: buhbye] 06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:11 < bitcoin-git> [bitcoin] jonatack opened pull request #23219: p2p: remove unneeded CNetAddr vector in LookupSubNet() and update/tidy up (master...LookupSubNet-todo-fix) https://github.com/bitcoin/bitcoin/pull/23219 06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:12 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #bitcoin-core-dev 06:12 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host] 06:12 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-core-dev 06:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:20 < bitcoin-git> [bitcoin] hebasto opened pull request #23220: ci: Reduce Windows memory for faster scheduling (master...211007-mem1) https://github.com/bitcoin/bitcoin/pull/23220 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:26 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 245 seconds] 06:26 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds] 06:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:42 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6334ff7364e2...991753e4d50e 06:42 < bitcoin-git> bitcoin/master 429b493 Sebastian Falbesoner: test: introduce script_util helper for creating P2PK scripts 06:42 < bitcoin-git> bitcoin/master 991753e W. J. van der Laan: Merge bitcoin/bitcoin#23118: test: refactor: introduce `script_util` helpe... 06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:43 < bitcoin-git> [bitcoin] laanwj merged pull request #23118: test: refactor: introduce `script_util` helper for creating P2PK scripts (master...202109-test-add_helper_for_creating_p2pk_scripts) https://github.com/bitcoin/bitcoin/pull/23118 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:43 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 06:44 -!- mikehu44_ [~quassel@206.189.41.250] has joined #bitcoin-core-dev 06:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 06:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 06:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:06 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:08 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev 07:09 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds] 07:10 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 07:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:23 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:31 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:31 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:35 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:35 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:46 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:46 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 07:52 -!- zg_guest [~zg_guest@163.182.135.8] has joined #bitcoin-core-dev 07:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 07:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:01 -!- saranshsharma [~saranshsh@202.142.67.118] has joined #bitcoin-core-dev 08:07 -!- saranshsharma [~saranshsh@202.142.67.118] has quit [Remote host closed the connection] 08:07 -!- saranshsharma [~saranshsh@202.142.67.118] has joined #bitcoin-core-dev 08:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:15 -!- saranshsharma [~saranshsh@202.142.67.118] has quit [Remote host closed the connection] 08:18 -!- saranshsharma [~saranshsh@202.142.67.118] has joined #bitcoin-core-dev 08:20 -!- saranshsharma [~saranshsh@202.142.67.118] has quit [Remote host closed the connection] 08:22 -!- zg_guest [~zg_guest@163.182.135.8] has quit [Quit: Client closed] 08:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:29 -!- zg_guest [~zg_guest@163.182.135.8] has joined #bitcoin-core-dev 08:29 -!- saranshs_ [~saranshsh@202.142.81.207] has joined #bitcoin-core-dev 08:33 -!- saranshs_ [~saranshsh@202.142.81.207] has quit [Ping timeout: 245 seconds] 08:37 -!- saranshsharma [~saranshsh@223.233.15.67] has joined #bitcoin-core-dev 08:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:44 -!- saranshsharma [~saranshsh@223.233.15.67] has quit [Ping timeout: 245 seconds] 08:48 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 08:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 08:56 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 08:56 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 09:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Excess Flood] 09:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 09:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:11 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Ping timeout (120 seconds)] 09:11 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 09:11 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 09:13 -!- jamesob [uid180710@id-180710.helmsley.irccloud.com] has quit [Quit: Connection closed for inactivity] 09:19 -!- paairs [~rabidus@user/paairs] has quit [Ping timeout: 250 seconds] 09:20 -!- gleb7 [~gleb@178.150.137.228] has quit [Quit: Ping timeout (120 seconds)] 09:20 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 09:20 -!- johnzweng [~johnzweng@zweng.at] has quit [Ping timeout: 268 seconds] 09:21 -!- nathanael [~nathanael@user/nathanael] has quit [Ping timeout: 246 seconds] 09:21 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev 09:21 -!- xor9[m] [~xor9matri@2001:470:69fc:105::d186] has quit [Ping timeout: 260 seconds] 09:21 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Ping timeout: 260 seconds] 09:21 -!- Murch[m] [~murchmatr@2001:470:69fc:105::2aa8] has quit [Ping timeout: 260 seconds] 09:22 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Ping timeout: 265 seconds] 09:24 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Ping timeout: 276 seconds] 09:28 -!- nathanael [~nathanael@user/nathanael] has joined #bitcoin-core-dev 09:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 09:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 09:35 -!- paairs [~rabidus@user/paairs] has joined #bitcoin-core-dev 09:35 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-core-dev 09:36 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 09:41 -!- xor9[m] [~xor9matri@2001:470:69fc:105::d186] has joined #bitcoin-core-dev 09:41 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 09:43 -!- Murch[m] [~murchmatr@2001:470:69fc:105::2aa8] has joined #bitcoin-core-dev 09:44 -!- Guest49 [~Guest49@37.164.27.10] has joined #bitcoin-core-dev 09:46 -!- Guest49 [~Guest49@37.164.27.10] has quit [Client Quit] 09:49 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:50 -!- zg_guest [~zg_guest@163.182.135.8] has quit [Quit: Client closed] 10:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:02 -!- jarthur_ [~jarthur@2603-8080-1540-002d-9006-d8f2-cc1e-b078.res6.spectrum.com] has joined #bitcoin-core-dev 10:03 -!- jarthur [~jarthur@2603-8080-1540-002d-3d8e-e9e6-0356-d7f3.res6.spectrum.com] has quit [Ping timeout: 245 seconds] 10:09 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 10:10 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:14 -!- jonatack [jonatack@user/jonatack] has quit [Remote host closed the connection] 10:17 -!- jaybny [~jaybny@135-180-101-211.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 10:18 < jaybny> ping 10:20 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 10:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:30 -!- jaybny2 [~jaybny@135-180-101-211.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 10:30 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 10:31 < jaybny2> pong 10:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:47 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:47 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 10:55 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 10:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 10:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:00 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 11:00 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit] 11:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:08 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 11:12 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 11:18 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:22 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:35 < bitcoin-git> [bitcoin] jonatack opened pull request #23223: Add NoLockLoggingTestingSetup to test utilities, use in checkqueue_tests (master...alleviate-checkqueue-tests-contention-logging) https://github.com/bitcoin/bitcoin/pull/23223 11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:44 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:52 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 11:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 11:53 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 11:54 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:00 < laanwj> #startmeeting 12:00 < jeremyrubin> hi 12:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos 12:00 < laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 12:00 < achow101> hi 12:01 < laanwj> no bot today, apparently 12:01 < michaelfolkson> hi 12:01 < darosior> hi 12:01 < jarolrod> Hi 12:01 < meshcollider> hi 12:01 < hebasto> hi 12:01 < kvaciral[m]> hi 12:01 < laanwj> doesn't look like any topics have been proposed for this week (use #proposedmeetingtopic to propose topics you want to discuss in the meeting) 12:02 < laanwj> any last minute ones? 12:02 < laanwj> i think we should cancel the IRC meeting next week due to the IRL coredev meeting 12:02 < jeremyrubin> disagree 12:03 < jeremyrubin> i'd like to move some things onto blockers 12:03 < jeremyrubin> err priority 12:03 < laanwj> well, i'm not going to chair it, feel free to meet anyway 12:03 < jeremyrubin> kk 12:03 < jeremyrubin> also won't be at IRL i think :( 12:04 < jeremyrubin> #topic high priority for review 12:04 < laanwj> eh, 12:04 < laanwj> please leave that to me 12:04 < jeremyrubin> laanwj: "well, i'm not going to chair it, feel free to meet anyway" 12:04 < laanwj> jeremyrubin: next week 12:04 < cfields> hi 12:04 * jeremyrubin slaps forehead 12:05 < laanwj> i'm here now why wouldn't i 12:05 < michaelfolkson> You can always request things are moved to blockers outside an actual meeting right laanwj? 12:05 < jonatack> hi 12:05 < cfields> hehe 12:05 < laanwj> michaelfolkson: yes, sure 12:05 < michaelfolkson> Wouldn't need a meeting next week if that is all jeremyrubin wants to do 12:05 < laanwj> anyhow, yes, high priority for review 12:05 < jeremyrubin> sorry for the read-o, i thought you were saying cancel right now 12:05 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 2 chasing concept ACK 12:06 < laanwj> anything to add/remove or that is almost ready for merge? 12:06 < fjahr> hi 12:06 < darosior> #22539 can be removed now it was merged (thanks laanwj for looking at it today btw) 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/22539 | Re-include RBF replacement txs in fee estimation by darosior · Pull Request #22539 · bitcoin/bitcoin · GitHub 12:06 < michaelfolkson> #22950 is merged too 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/22950 | [p2p] Pimpl AddrMan to abstract implementation details by amitiuttarwar · Pull Request #22950 · bitcoin/bitcoin · GitHub 12:07 < lightlike> 22950 and 20487 were also merged 12:07 < jeremyrubin> i'd like to put #21702 as my high priority -- up to you on removing the other one currently my priority 12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub 12:08 < laanwj> thanks, removed the merged ones, 7 blockers, 1 chasing concept ACK left 12:08 < jonatack> among the open ones, i'd like to suggest #22702 and #21943 to reviewers, please have a look if you have some bandwidth 12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub 12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/21943 | Dedup and RAII-fy the creation of a copy of CConnman::vNodes by vasild · Pull Request #21943 · bitcoin/bitcoin · GitHub 12:09 < michaelfolkson> A new soft fork is high priority? 12:09 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:09 < laanwj> jeremyrubin: added 12:09 < cfields> "for review" 12:09 < jeremyrubin> michaelfolkson: well, high priority is for communicating personal priority + review precedence. afaiu contributors get to pick what they want there 12:09 < jonatack> the first for performance and lower memory use, the second appears to reduce some of the most frequent lock contentions 12:10 < laanwj> jonatack: intend to look into them 12:11 < laanwj> anything else? 12:12 < jonatack> laanwj: great! 12:12 < laanwj> nothing else to add to high prio? no other topics? 12:12 < meshcollider> We could re-visit the discussion about fanquake now we have a lot of ACKs :) 12:13 -!- jamesob [uid180710@id-180710.helmsley.irccloud.com] has joined #bitcoin-core-dev 12:13 < jeremyrubin> Is this about increased GH permissions? 12:13 < michaelfolkson> What's your best case for the timing of a #21702 merge jeremyrubin? It is an interesting time to put it as your highest priority for review 12:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub 12:13 < meshcollider> jeremyrubin: yep 12:14 < michaelfolkson> Perhaps not the best place for this discussion, probably mailing list is better 12:14 < michaelfolkson> For the PR 12:14 < michaelfolkson> fanquake discussion sounds good 12:15 < michaelfolkson> I think there were a lot of ACKs with two NACKs (from what I saw) 12:15 < laanwj> didn't keep a tally but a lot of people voted +1 for fanquake being able to block people from the github, outside the meeting 12:15 < laanwj> yes 12:15 < meshcollider> FWIW, we had 15 ACKs (darosior, michaelfolkson, jarolrod, fjahr, MarcoFalke, laanwj, dhruv, jnewbery, amiti, ariard, larryruane, sipa, achow101, hebasto, and myself) on IRC in support, while only 2 against (prayank, luke-jr) 12:16 < laanwj> meshcollider: ok! 12:16 < jeremyrubin> i'll ack --> perhaps we can just keep a log wiki somewhere of who is blocked and why 12:16 < luke-jr> laanwj: I don't think the problem is him being able to block spammers, just having full access 12:17 < meshcollider> jeremyrubin: I think the only thing anyone is ever blocked for is unintelligible spam 12:17 < laanwj> to be clear, we only block, ever, for obvious spamming and scamming attempts 12:17 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:17 < luke-jr> meshcollider: I've seen a lot of issues locked to stop non-spam discussion lately 12:17 < jeremyrubin> that's fine then, email notification are sufficient IMO 12:17 < luke-jr> (but not sure that's fanquake) 12:17 < luke-jr> laanwj: that isn't accurate 12:17 < meshcollider> luke-jr: I haven't seen that, you'll need to provide specific examples 12:17 < luke-jr> unless the distinction is lock vs block 12:18 < laanwj> luke-jr: i mean block as in making specific users unable to post or PR to the repository 12:18 < luke-jr> meshcollider: I'll bring them up next time; IIRC the last one I noticed was rebroad commenting 12:18 < luke-jr> rebroad may be dense sometimes, but he isn't spam 12:18 < laanwj> rebroad isn't blocked from the repo !!! 12:19 < laanwj> you're bringing other things into this 12:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:19 < bitcoin-git> [bitcoin] dougEfresh opened pull request #23224: [RFC] util: Add suffix byte unit parser for ArgsManager (master...add-args-byte-units) https://github.com/bitcoin/bitcoin/pull/23224 12:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:19 < michaelfolkson> I would like more transparency and explanations on why certain issues are locked (if people ask) 12:19 < luke-jr> ok, sorry for the confusion 12:19 < michaelfolkson> But I don't think that is fanquake specific 12:20 < lightlike> luke-jr: the locking of old PRs was done by MacroFalke, see 2021-10-05 09:57 in logs 12:20 < jamesob> (ACK fanquake, fwiw) 12:20 < laanwj> i think the idea is that people open new issues instead of post on ancient ones 12:20 < michaelfolkson> Recently MarcoFalke closed 3 year old issues and told this channel (which was fine I think) 12:20 < michaelfolkson> As long as this channel is told and people can enquire why if there is confusion 12:21 < laanwj> e.g. some old issues and PRs that have been merged years ago keep accumulating replies that don't really apply to the original topic anymore 12:21 < meshcollider> michaelfolkson: He didn't close them, he locked inactive issues which were already closed I think 12:21 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 12:21 < michaelfolkson> meshcollider: Ok sure, thanks for correction 12:21 < laanwj> right 12:22 < laanwj> in any case i think it makes sense to post why before closing/locking an issue, i tend to to that unless it's obvious 12:22 < meshcollider> (locking issues is also a lower permission than maintainer, a number of other users have that permission) 12:22 < meshcollider> The "issue management" team 12:22 < laanwj> right 12:22 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 12:23 < laanwj> in any case, if your pR or issue is closed and you disagree, bring it up here 12:24 < jeremyrubin> maybe we should just declare issue/pr bankruptcy and close everything w/o activity in the last week and allow folks to reopen if they want, that way there's less 'moral judgement' of should be closed or not and we can just clean shop 12:24 < laanwj> doing issue management is simply needed in a busy project like this, and i'm sure there are mistakes sometimes 12:24 < meshcollider> jeremyrubin: if an issue is closed by a maintainer I don't think the user can re-open it themselves 12:25 < jeremyrubin> we could do a 'reopen bot' that checks for a request to reopen as a comment... but i know that's extra work for someone 12:25 < laanwj> why would that need a bot 12:25 < laanwj> simply ask a maintainer when it happens 12:25 < laanwj> or better, simply post here 12:26 < jeremyrubin> didn't want to make more work for maintainer as noted by meshcollider, but I agree that works 12:26 < jonatack> meshcollider: seems so, i've had pulls unilaterally closed several times this year and had to open a new pull 12:26 < luke-jr> jeremyrubin: not all of us have funding to touch every PR once a week; sometimes it takes me months to address things 12:26 < laanwj> jonatack: why didn't you ask to reopen them? 12:27 < meshcollider> ^ 12:27 < jonatack> laanwj: wu wei, going with the flow i guess :D 12:27 < jeremyrubin> luke-jr: i'm saying do it as a 1x pr-bankruptcy, not every week. (maybe 1x a year?) 12:28 < michaelfolkson> It seems communication could be improved in both directions between PR authors and maintainers :) 12:28 < michaelfolkson> Definitely ask next time jonatack :) 12:28 < meshcollider> I think this is a very separate conversation anyway 12:28 < laanwj> jonatack: heh 12:28 < jonatack> i mean, it's not important, just confirming meshcollider's statement 12:31 < laanwj> i think that concludes the meeting 12:32 < laanwj> luke-jr: in your case we know that, it's sometimes different with new contributors that open a PR then never respond again :) 12:32 < laanwj> #endmeeting 12:33 < laanwj> oh, yeah, no bot 12:33 < cfields> ## meep morp, meeting adjourned. 12:33 < laanwj> :D 12:34 < jeremyrubin> michaelfolkson i moved it to my high priority since i'm not going to be able to attend IRL it seems, that was the appropriate other choice for communicating my intent. 12:34 < jeremyrubin> there is no specific timeline i have, i'm noting that it would be good to get more eyes on it 12:36 < jonatack> yes iirc the guideline has been that anyone can request more or less any pull, the only limit being just normally not more than one at a time of their own 12:37 < jeremyrubin> the PR itself contains no deployment params, so is fully revertible. nor does it change any standardness rules. so it'd be fine to merge it (assuming correct) and then discuss potential deployment (as was done with e.g. taproot). i'm not advocating that before technical consensus is reached, just explaining how the software works. 12:38 < michaelfolkson> I think at some point there will need to be a discussion on where people are standing on "the next soft fork", possible timing, makeup of it. Ideally that discussion would be put off as long as possible though imo 12:38 < michaelfolkson> I suspect there will be some strong disagreements 12:39 < laanwj> normally only one per person, we do have two PRs in the list by jeremyrubin now, but i guess the mempool optimization is dissimilar enough it's not really an issue 12:41 < jeremyrubin> yep, as noted welcome to remove that if you like. but i don't really have the motivation to push on that one really much further at present, i'm hoping some other contributors will prioritize seeing it through beyond basic maitnenance. 12:41 < jeremyrubin> michaelfolkson: can you say more about what you view as this timeline for when things can or cannot be discussed? 12:42 < jamesob> laanwj: sorry, missed the beginning of the meeting. can I add #23174 to high prio list? 12:42 <@gribble> https://github.com/bitcoin/bitcoin/issues/23174 | validation: have LoadBlockIndex account for snapshot use by jamesob · Pull Request #23174 · bitcoin/bitcoin · GitHub 12:43 < michaelfolkson> jeremyrubin: I can only speak for myself. But putting something as high priority today if the plan is for a soft fork in e.g. 2 years (name a longish period from now) seems bizarre to me. That's why I asked on best case timing 12:44 < jamesob> jeremyrubin: I'm definitely in the process of doing a conceptual evaluation of OP_CTV for myself atm - specifically in the context of covenants for vaulting 12:45 < michaelfolkson> Anything can be discussed whenever people want to discuss them. But prioritizing is the act of weighing up what is most urgent, important versus other possible priorities 12:46 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 12:46 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:46 < _aj_> laanwj: (maybe it would make sense to rename high-pri to "top-pri" as in "this is contributor x's top priority pr") 12:47 < jeremyrubin> well, I put it on priority for review since i've been talking with more and more potential users of CTV there seems to be more desire to evaluate it to solve problems (e.g. vaults) as well as to know what kind of timeline there could be. a timeline can't evolve until there's been enough core review. 12:48 < jonatack> laanwj: oh heh, i didn't see there were two now, wasn't commenting on that :D there have been other times as well if i'm not misremembering 12:48 < jeremyrubin> in the conversations i've been having with orgs they seem to want to solve problems on a 6 months to 1 year horizon, beyond that is too far out for them to dedicate resources 12:48 < michaelfolkson> I'm definitely following OP_CTV and have recently discussed it at multiple Socratics, it is really interesting. I just think we potentially strongly disagree on timing and how much time should be given to weighing up what should be in a covenant/vault soft fork before it happens 12:48 < michaelfolkson> But that's only my personal view, I have no idea what other people think 12:50 < michaelfolkson> Anyway, gtg 12:50 < jeremyrubin> i think the orgs i've mostly been speaking to would strongly like *something* in place that's studied to be safe sooner than later so that they can work on getting tech out to end users based on it. 12:51 < jeremyrubin> a better thing can always be added later, but there's a preference to have more options on the table now than there is to design the 'one covnenant system to rule them all'. 12:52 < jeremyrubin> i've not been hyping it as an argument for deployement since i think it could still use more support and review, but there's a list i'm tracking on utxos.org/signals for orgs/ppl that would like ctv 12:52 < jamesob> e.g. vaulting is really compelling for custody operations, and CTV-style covenants could add a ton of security in short order by enabling better forms of them. alternative is doing presigned txns, but proving key deletion is difficult. 12:56 < jeremyrubin> the other one i've seen a lot of excitement for is batch channel creation. 12:57 < jeremyrubin> especially with the El Salvador stuff people are trying to figure out better ways to create a large number of channels w/o resorting to more custodial setups 12:57 < _aj_> jeremyrubin: hmm, bip 119 has (expired) activation parameters currently? 12:57 < jaybny2> think op_ctv doesnt go far enough - but its a good first step, and hope more can eventually more can part of the next soft fork including op_apo 12:58 < jeremyrubin> _aj_: ah yeah i think when i put that in the BIP there may not have been the disabled specific flags. that's that the PR currently uses 12:58 < jeremyrubin> I can update to copy what's in the PR 12:59 < _aj_> jeremyrubin, jamesob: fwiw, when last i looked at the bip, and skimmed the code, it seemed like the simplest possible implmentation of the idea, which resolved the concerns i'd had with earlier versions. i think i'd nitpick how the hash is constructed, but otherwise if the code isn't buggy, it seems plausible 12:59 < jeremyrubin> https://github.com/bitcoin/bitcoin/blob/118ff53bab10120943d987b4d3fb404c76922765/src/chainparams.cpp#L95 12:59 < jeremyrubin> we also didn't have speedy trial then, which we do now :) 13:00 < _aj_> jeremyrubin, jamesob: i think sighash_group would be a big bang-for-buck feature so it's highest on my list atm (very subject to change), and i'm curious as to whether ctv and sighash_group could be made compatible, so that the same technique to combine sighash_group payments into a single tx could allow combining multiple ctv paymnts into a single tx 13:01 < jamesob> I'm interested in TLUV and any other idea for covenant implementations, but they seem much more general/in-direct/hard to assess for code janitors like me. I think I'm Concept ACK unless I hear reasonable concerns about safety from some of the devs here with grayer beards than mine 13:02 < jamesob> _aj_ where can I read about sighash_group? Must've missed the ML post 13:02 < _aj_> (i think eltoo channels might need ANYPREVOUT and SIGHASH_GROUP, and eltoo factories (3+ participants who can establish off-chain internal channels amongst subgroups) might also need TLUV) 13:02 < jeremyrubin> it's a good question. my preferred technique for that would be to do it as follow on whenever bundles are sufficiently reviewed, and then enable it as a 33 byte hash for CTV only under taproot where the annex contains the bitmask? 13:03 < laanwj> jamesob: added 13:03 < jamesob> laanwj: thanks 13:04 < jeremyrubin> i think the thing that concerns me re bundles and CTV is that it limits the benefits of caching hashes so i'd be worried if the bundle spec were not per input (e.g., bundle spec tag on hash could lead to quad hashing) 13:05 < _aj_> jeremyrubin: yeah, that makes sense to me too. i think CTV is philosophically "SIGHASH_ANYPREVOUT" but without bothering to do the signature, so this would be "SIGHASH_ANYPREVOUT | SIGHASH_GROUP" again without doing the signature, so you'd just be adding a sighash-byte at the start/end to differentiate just like for sigs 13:05 < jeremyrubin> and i also am curious about thinking through allowing overlapping bundles and if there is any merit or use of that 13:05 < _aj_> sighash_group specifies no overlapping bundles 13:06 < jeremyrubin> _aj_ is there a link for most recent thinking on sighash group for jamesob? 13:06 < _aj_> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-July/019243.html 13:06 < _aj_> took me a while to find it 13:06 < jamesob> _aj_ jeremyrubin: thanks 13:06 < jamesob> yeah neither duckduckgo nor google turn up results 13:07 < jeremyrubin> _aj_ btw i don't care much about the specific hash construction if you have thoughts on that. 13:08 < jeremyrubin> i think there are tradeoffs any way you define it, but there absolutely could be some benefit to different orders interactions with CAT or SHASTREAM or caching or something 13:08 < _aj_> jeremyrubin: i think my thoughts were just "should use tagged hashes, and maybe otherwise be more similar to taproot than to segwitv0/whatever" but i haven't actually compared or thought about any pitfalls 13:08 < jeremyrubin> Ah 13:08 < jeremyrubin> the main reason not to do a tagged hash is to make it easier to work with on the stack if there is a future CAT fork 13:09 < _aj_> jeremyrubin: pretty easy to construct tagged hashes with CAT though 13:09 < jeremyrubin> at cost of bigger txns 13:09 < laanwj> _aj_: we couldrename it, but i'm not sure top-prio versus high-prio is that much clearer 13:09 < jeremyrubin> is there a benefit to the safety of using tagged hashes? 13:10 < _aj_> laanwj: yeah, i put brackets around things that probably aren't good ideas :) 13:11 < _aj_> laanwj: at least that's a helpful way of thinking about it for me though -- "high pri" sounds like something the "project" thinks is high priority to me, especially if you're a newb; realising it's only indiviual people's things requires a moment of insight... 13:12 < _aj_> jeremyrubin: when you're not trying to sign it, perhaps not? 13:12 < jeremyrubin> i was actually thinking w.r.t. hash construction that doing merkle trees of the outputs would be interesting, but would be very bikesheddy given it would presuppose how some mtree manipulation code would work (and could just be done as a tagged version). 13:12 < laanwj> it might help that the sub-category is called 'blockers', it would be slightly strange if they were blocking the entire project and not one person's work, but yes i understand the confusion 13:12 < jamesob> laanwj _aj_: whatever the list is called, it's really just "where do I look for the next thing to review" 13:12 < laanwj> jamesob: right, that's the idea, just to give people ideas what to review 13:12 < jeremyrubin> _aj_ yeah i did consider it a while back and couldn't think of any benefit and only a mild annoyance in the future so i did a plain hash 13:14 < _aj_> jeremyrubin: maybe if we also had checkdatasig or whatever? though then it'd presumably be people signing components that get CATed to make the hash anyway (if you were signing the full ctv hash, might as well just use checksig/anyprevout, presumably) 13:15 < _aj_> jeremyrubin: you're not on wizards? 13:16 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 13:19 < jeremyrubin> oops 13:19 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 13:20 < jeremyrubin> _aj_ the checkdatasig thing is interesting, you can actually do eltoo like thing with just CTV and CDS 13:21 < jeremyrubin> so it is possible you'd want to sign hashes? 13:21 < jeremyrubin> That said, it depends if CDS gets a 'raw' API (sign arbitrary message) or if the message to CDS gets hashed (and therefore, can have it's own tag) 13:21 < _aj_> jeremyrubin: that's just emulating ANYPREVOUT because CTV has it (more or less) but CHECKSIG doesn't, no? 13:22 < jeremyrubin> can you reword that? what's it? 13:22 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 13:23 < _aj_> jeremyrubin: that's just emulating CHECKSIG-ANYPREVOUT because CTV has ANYPREVOUT (more or less) but CHECKSIG doesn't, no? 13:24 < jeremyrubin> ah, yes 13:24 < jeremyrubin> if you do CTV CHECKSIGFROMSTACKVERIFY you basically get something that's like anyprevout 13:24 < jeremyrubin> the main difference is no sighash flags 13:25 < jeremyrubin> but you can always e.g. sign a couple copies of the txn with extra *inputs* if you want (no adding outputs) 13:25 < jeremyrubin> then you can do eltoo like stuff with 13:26 < jeremyrubin> CTV CHECKSIGFROMSTACKVERIFY CLTV 13:26 < jeremyrubin> which gives you the ratchet to burn old H's signed by PKu 13:27 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:28 < bitcoin-git> [bitcoin] katesalazar opened pull request #23225: Reject float at satoshi_round (master...20211006) https://github.com/bitcoin/bitcoin/pull/23225 13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:33 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:35 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 13:36 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:36 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 13:39 < gene> sipa: after messing around with mull for mutation tests, not sure if it's suitable for CI 13:40 < gene> even running mull-cxx (mutation compiler) with only one worker takes 12-16G ram 13:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:48 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 13:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:01 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:22 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has quit [Ping timeout: 250 seconds] 14:23 -!- ziggie [uid521459@user/ziggie] has quit [Ping timeout: 245 seconds] 14:23 -!- glozow [sid453516@user/glozow] has quit [Ping timeout: 252 seconds] 14:23 -!- fanquake [sid369002@user/fanquake] has quit [Ping timeout: 268 seconds] 14:23 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has quit [Ping timeout: 260 seconds] 14:23 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 260 seconds] 14:23 -!- hugohn [sid304114@id-304114.lymington.irccloud.com] has quit [Ping timeout: 250 seconds] 14:23 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has quit [Ping timeout: 250 seconds] 14:23 -!- bw [sid2730@user/betawaffle] has quit [Ping timeout: 250 seconds] 14:23 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has quit [Ping timeout: 250 seconds] 14:23 -!- hsmiths [uid95325@id-95325.helmsley.irccloud.com] has quit [Ping timeout: 260 seconds] 14:23 -!- jamesob [uid180710@id-180710.helmsley.irccloud.com] has quit [Ping timeout: 245 seconds] 14:24 -!- ziggie [uid521459@user/ziggie] has joined #bitcoin-core-dev 14:24 -!- hendi [sid489601@id-489601.lymington.irccloud.com] has quit [Ping timeout: 252 seconds] 14:24 -!- stick [sid403625@user/prusnak] has quit [Ping timeout: 252 seconds] 14:24 -!- rodarmor [sid210835@id-210835.helmsley.irccloud.com] has quit [Ping timeout: 250 seconds] 14:24 -!- dergoegge [sid453889@lymington.irccloud.com] has joined #bitcoin-core-dev 14:24 -!- glozow [sid453516@user/glozow] has joined #bitcoin-core-dev 14:24 -!- sebx2a_ [sid356034@uxbridge.irccloud.com] has joined #bitcoin-core-dev 14:24 -!- hebasto [sid449604@id-449604.uxbridge.irccloud.com] has quit [Ping timeout: 268 seconds] 14:24 -!- hebasto_ [sid449604@uxbridge.irccloud.com] has joined #bitcoin-core-dev 14:24 -!- stick [sid403625@user/prusnak] has joined #bitcoin-core-dev 14:24 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has quit [Ping timeout: 246 seconds] 14:24 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has quit [Ping timeout: 246 seconds] 14:24 -!- sebx2a [sid356034@id-356034.uxbridge.irccloud.com] has quit [Ping timeout: 268 seconds] 14:24 -!- sebx2a_ is now known as sebx2a 14:24 -!- RubenSomsen_ [sid301948@user/rubensomsen] has joined #bitcoin-core-dev 14:24 -!- ajonas [sid385278@helmsley.irccloud.com] has joined #bitcoin-core-dev 14:24 -!- jkczyz [sid419941@lymington.irccloud.com] has joined #bitcoin-core-dev 14:24 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Ping timeout: 260 seconds] 14:24 -!- Evolver [sid32215@user/evolver] has quit [Ping timeout: 260 seconds] 14:24 -!- FelixWeis_ [sid154231@hampstead.irccloud.com] has joined #bitcoin-core-dev 14:24 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has quit [Ping timeout: 252 seconds] 14:24 -!- RubenSomsen_ is now known as RubenSomsen 14:24 -!- schmidty [sid297174@id-297174.lymington.irccloud.com] has quit [Ping timeout: 240 seconds] 14:25 -!- schmidty [sid297174@lymington.irccloud.com] has joined #bitcoin-core-dev 14:25 -!- sugarpuff__ [sid92283@lymington.irccloud.com] has joined #bitcoin-core-dev 14:25 -!- FelixWeis [sid154231@id-154231.hampstead.irccloud.com] has quit [Ping timeout: 268 seconds] 14:25 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has quit [Ping timeout: 268 seconds] 14:25 -!- FelixWeis_ is now known as FelixWeis 14:25 -!- josibake [sid509132@id-509132.helmsley.irccloud.com] has quit [Ping timeout: 260 seconds] 14:25 -!- amiti [sid373138@id-373138.lymington.irccloud.com] has quit [Ping timeout: 264 seconds] 14:25 -!- sugarpuff_ [sid92283@id-92283.lymington.irccloud.com] has quit [Ping timeout: 264 seconds] 14:25 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Ping timeout: 264 seconds] 14:25 -!- sugarpuff__ is now known as sugarpuff_ 14:25 -!- lightlike [uid521075@user/lightlike] has quit [Ping timeout: 268 seconds] 14:25 -!- fjahr [sid374480@uxbridge.irccloud.com] has joined #bitcoin-core-dev 14:27 -!- rodarmor [sid210835@helmsley.irccloud.com] has joined #bitcoin-core-dev 14:27 -!- Evolver [sid32215@user/evolver] has joined #bitcoin-core-dev 14:27 -!- josibake [sid509132@helmsley.irccloud.com] has joined #bitcoin-core-dev 14:28 -!- hsmiths [uid95325@helmsley.irccloud.com] has joined #bitcoin-core-dev 14:28 -!- elichai2 [sid212594@hampstead.irccloud.com] has joined #bitcoin-core-dev 14:28 -!- bw [sid2730@user/betawaffle] has joined #bitcoin-core-dev 14:28 -!- hendi [sid489601@lymington.irccloud.com] has joined #bitcoin-core-dev 14:29 -!- lightlike [uid521075@user/lightlike] has joined #bitcoin-core-dev 14:29 -!- amiti [sid373138@lymington.irccloud.com] has joined #bitcoin-core-dev 14:30 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:32 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev 14:37 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has joined #bitcoin-core-dev 14:38 -!- fanquake [sid369002@user/fanquake] has joined #bitcoin-core-dev 14:38 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has joined #bitcoin-core-dev 14:38 -!- jamesob [uid180710@id-180710.helmsley.irccloud.com] has joined #bitcoin-core-dev 14:38 -!- hugohn [sid304114@id-304114.lymington.irccloud.com] has joined #bitcoin-core-dev 14:38 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has joined #bitcoin-core-dev 14:40 < michaelfolkson> laanwj: Perhaps the description for High-priority for review could be added to 14:40 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-core-dev 14:41 < michaelfolkson> Currently it is "These either block other important work in progress, or are necessary for backport to a minor release. Also includes a list of PRs that are in a mergeable state." 14:42 < michaelfolkson> Something like "from the PR author's perspective" after "block other important work in progress" 14:42 < michaelfolkson> The description sounds like it is high priority for the project 14:43 < michaelfolkson> Some may think it is (e.g. the PR author) but to have a new soft fork as a high priority for the project is at least disputable imo 14:50 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 14:50 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 14:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 14:54 < jeremyrubin> what is high priority for the project that's indisputible? 14:55 < michaelfolkson> I guess nothing hence my suggested wording change 14:58 < michaelfolkson> Putting a consensus change as high priority could certainly give the wrong impression to an outside observer (as others have pointed out) 15:02 < michaelfolkson> I don't even know if it can be considered for merging until there is community consensus on it being in the next soft fork can it? If it can't be considered for merging it can't be high priority for the project 15:03 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:06 < lightlike> how could a community consensus form if not through peer review? It's called "high priority for review" after all, not "high priority for merge" 15:10 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:11 < michaelfolkson> lightlike: I'm not sure whether the only way you get peer review is by marking it as "high priority for review" and a "blocker" on Bitcoin Core 15:12 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:16 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 15:16 < michaelfolkson> I just think there is (potentially) a fundamental disagreement on how we consider consensus changes in future. Merging a consensus change PR once it has ~5 ACKs on a Core PR doesn't seem to be the right process for a consensus change to me 15:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:21 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 15:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:30 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 15:33 < TallTim> Perhaps changes should be factored as to their economic impact, given that this is a financial system after all. UI/UX? Probably minor. Protcol level? Bigger impact. 15:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 15:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 15:41 < michaelfolkson> I would factor it by risk personally. And there is nothing more risky than a soft fork other than perhaps a hard fork. Doing one every time a consensus change PR gets ~5 ACKs on the Core repo sounds crazy to me 15:41 < michaelfolkson> But maybe we have to learn that lesson in real life 15:41 < jeremyrubin> tbh soft forks aren't particularly more or less dangerous than other changes we make to bitcoin 15:41 < jeremyrubin> all changes have risks and rewards 15:42 < jeremyrubin> think of it like skydiving vs driving 15:42 < michaelfolkson> I couldn't disagree any more strongly. Even with a soft fork that had overwhelming community consensus (Taproot) activation was concerning 15:43 < jeremyrubin> skydiving isn't more dangerous than driving -- did you know that? it's actually safer 15:43 < michaelfolkson> And that was the safest it gets. Couldn't have had any more community consensus 15:44 < jeremyrubin> but obviously jumping out of a plane is more dangerous than driving a car 15:44 < michaelfolkson> Maybe we just have to have that disputed soft fork so we can learn that lesson 15:44 < jeremyrubin> but when you jump out of a plane you take more precautions than driving, which makes it safer 15:45 < jeremyrubin> so i think you're having the reaction that "it's jumping out of a plane it's so unsafe" and ignoring the fact that we're driving day by day by day 15:45 < jeremyrubin> courting review is a part of "packing the chute", so is the fact that we do signalled activation for soft forks 15:46 < jeremyrubin> i think that leads to the way that we do soft forks for bitcoin being no more unsafe than other changes we make 15:46 < michaelfolkson> I just think the above is nonsense. But I'm not going to be able to convince you 15:48 < michaelfolkson> Either a consensus change has overwhelming community buy in or you take shortcuts and try to get it in with a few reviews on the Core repo 15:48 < jeremyrubin> i think what you're arguing for is tantamount to just shouting that we shouldn't even think about going for another jump because sky diving is so scary when you think about it, and telling people to not bother checking the chute is proprely packed because we shouldn't go because it's so dangerous. 15:48 < jeremyrubin> there's nothing wrong with checking that the chute is properly packed 15:48 < jeremyrubin> there's nothing wrong with reviewing the code for ctv 15:50 < jeremyrubin> i'm really not sure what shortcuts you're accusing me of. i am requesting more reviewers and you are saying that i shouldn't request more reviewers because i'm trying to get it merged with few reviewers 15:50 < jeremyrubin> i think it's utter nonsense and i don't get why you're pursuing these convoluted arguments 15:51 < michaelfolkson> I don't know how we avoid the disputed soft fork then 15:53 < jeremyrubin> i think you're manufacturing factionalized controversy for controversy's sake 15:53 < michaelfolkson> I think there should be overwhelming community consensus on what is in the soft fork. You think you do a soft fork whenever a consensus change gets merged into Core 15:53 < michaelfolkson> (I think) 15:53 < jeremyrubin> i don't see where you are getting that from 15:53 < jeremyrubin> the PR has no activation parameters in it 15:53 < michaelfolkson> Right but once merged into Core the next phase is activation 15:54 < jeremyrubin> presumably core doesn't merge activation parameters until there's community consensus. 15:54 < jeremyrubin> even then, soft forks have signals which can be used as a second safety check for community consensus 15:54 < michaelfolkson> I don't think it should merge consensus code changes until there's community consensus 15:55 < jeremyrubin> we do that pretty often 15:55 < jeremyrubin> many changes to bitcoin core affect the consensus code 15:55 < jeremyrubin> we hope in ways that are not observable, of course 15:55 < jeremyrubin> similar to an un activated soft fork, which should not be observable 15:58 < jeremyrubin> michaelfolkson was there overwhelming community consensus for taproot? for segwit? for CSV? etc? 15:58 < jeremyrubin> can you quantify or qualify what that means? 15:58 < michaelfolkson> For Taproot, yes. I think only contributor I'm aware who NACKed it was on quantum concerns 15:58 < michaelfolkson> That is a very high bar 15:59 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev 15:59 < jeremyrubin> so the bar for "overhwhelming community consensus" is just what contributors think? 16:00 < jeremyrubin> it's my recollection there were actually a lot of NACKs for the activation mechanism (you know, the actual fork part) 16:00 -!- TheRec [~toto@user/therec] has quit [Ping timeout: 246 seconds] 16:00 < jeremyrubin> to the point where a potentially incompatible client was released 16:01 < michaelfolkson> That was activation. And that will happen for the next soft fork too 16:01 < jeremyrubin> so isn't that actually a low bar then? 16:01 < jeremyrubin> well activation code is definitionally consensus code 16:01 < michaelfolkson> So add a disputed soft fork into the mix of activation concerns and you've got quite the bonfire 16:02 < jeremyrubin> are there plans to not reuse speedy trial again? it seemed to go very smoothly 16:03 < michaelfolkson> It hasn't been discussed. I would guess it will be used next time but I'm sure we'll have similar dynamics around the alternative client 16:03 < michaelfolkson> (or at least I'm not aware it has been discussed) 16:07 < jeremyrubin> so you think taproot had community consensus, but what about segwit? 16:08 < michaelfolkson> Speedy Trial seemed to go smoothly for a soft fork with one contributor NACK and although harder to measure what seemed like overwhelming community consensus. I didn't see (m)any people saying Taproot shouldn't be activated 16:09 < michaelfolkson> SegWit was part of a block size, ASICBoost, hard fork war. I'm not sure that is what we should be comfortable with for the next soft fork 16:12 < jeremyrubin> counterpoint, not getting segwit would have been pretty bad for bitcoin overall, no? should we let 'bullies' who don't want bitcoin to progress to roadblock the rest of the network? if we can't get an important upgrade in the face of bad actors, that sounds bad for bitcoin... 16:13 < luke-jr> jeremyrubin: yet you wanted to empower such bullies ;) 16:14 < BlueMatt> can y'all take this to a more appropriate forum? this is not the right place. 16:15 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 16:15 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 16:15 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev 16:19 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 245 seconds] 16:19 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Quit: Leaving...] 16:21 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 245 seconds] 16:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:34 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:35 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 16:39 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:39 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 16:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 16:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:01 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:01 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:10 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:16 < bitcoin-git> [bitcoin] theuni opened pull request #23226: c++20: Opt-in to modeling view and borrowed_range for Span (master...borrowed-span) https://github.com/bitcoin/bitcoin/pull/23226 17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:19 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/991753e4d50e...99e53967c85c 17:19 < bitcoin-git> bitcoin/master 4356878 Gregory Sanders: External input fund support cleanups 17:19 < bitcoin-git> bitcoin/master 99e5396 fanquake: Merge bitcoin/bitcoin#23188: wallet: fund transaction external input clean... 17:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:20 < bitcoin-git> [bitcoin] fanquake merged pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188 17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:50 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 17:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 17:58 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 265 seconds] 18:02 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:02 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:15 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:15 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:24 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:24 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:28 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:28 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:32 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:32 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 18:57 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 18:58 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 18:58 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 18:59 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 19:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:14 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:14 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:18 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:18 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:22 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:22 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:30 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:30 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 19:49 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 19:52 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:00 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:00 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:04 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:08 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:08 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:12 -!- Guest6683 [~Guest66@123.31.133.45] has joined #bitcoin-core-dev 20:14 -!- uvhw [~uvhw@123.31.133.45] has joined #bitcoin-core-dev 20:19 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:19 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:27 -!- uvhw [~uvhw@123.31.133.45] has quit [Quit: Client closed] 20:27 -!- Guest6683 [~Guest66@123.31.133.45] has quit [Quit: Client closed] 20:27 -!- uvhw [~uvhw@123.31.133.45] has joined #bitcoin-core-dev 20:27 -!- Guest6683 [~Guest6683@123.31.133.45] has joined #bitcoin-core-dev 20:32 -!- Guest6683 [~Guest6683@123.31.133.45] has quit [Client Quit] 20:32 -!- uvhw [~uvhw@123.31.133.45] has quit [Client Quit] 20:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:42 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 20:42 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 20:43 -!- Guest99 [~Guest99@123.31.133.45] has joined #bitcoin-core-dev 20:43 -!- Guest99 [~Guest99@123.31.133.45] has quit [Client Quit] 20:46 -!- Guest99 [~Guest99@123.31.133.45] has joined #bitcoin-core-dev 20:47 -!- Guest59 [~Guest59@123.31.133.45] has joined #bitcoin-core-dev 20:47 -!- Guest59 [~Guest59@123.31.133.45] has quit [Client Quit] 20:51 -!- Guest99 [~Guest99@123.31.133.45] has quit [Quit: Client closed] 20:51 -!- saranshs_ [~saranshsh@202.142.81.207] has joined #bitcoin-core-dev 20:51 -!- Guest99 [~Guest99@123.31.133.45] has joined #bitcoin-core-dev 20:52 -!- Guest99 [~Guest99@123.31.133.45] has quit [Client Quit] 20:53 -!- Guest99 [~Guest99@123.31.133.45] has joined #bitcoin-core-dev 20:53 -!- Guest99 [~Guest99@123.31.133.45] has quit [Client Quit] 20:54 -!- Guest99 [~Guest99@123.31.133.45] has joined #bitcoin-core-dev 20:55 -!- saranshs_ [~saranshsh@202.142.81.207] has quit [Ping timeout: 245 seconds] 20:57 -!- Guest99 [~Guest99@123.31.133.45] has quit [Client Quit] 20:59 -!- Guest99 [~Guest99@123.31.133.45] has joined #bitcoin-core-dev 21:00 -!- Guest99 [~Guest99@123.31.133.45] has quit [Client Quit] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:05 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:05 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:14 < bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/99e53967c85c...97e2435ac43f 21:14 < bitcoin-git> bitcoin/master 56303e3 John Newbery: [fuzz] Create a FastRandomContext in addrman fuzz tests 21:14 < bitcoin-git> bitcoin/master 491975c John Newbery: [fuzz] Pass FuzzedDataProvider& into Fill() in addrman fuzz tests 21:14 < bitcoin-git> bitcoin/master 90ad8ad John Newbery: [fuzz] Make RandAddr() a free function in fuzz/addrman.cpp 21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:14 < bitcoin-git> [bitcoin] fanquake merged pull request #23053: [fuzz] Use public methods in addrman fuzz tests (master...2021-09-addrman-fuzzer-public-methods2) https://github.com/bitcoin/bitcoin/pull/23053 21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:20 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:22 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 21:26 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:26 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:28 -!- jarthur_ [~jarthur@2603-8080-1540-002d-9006-d8f2-cc1e-b078.res6.spectrum.com] has quit [Ping timeout: 245 seconds] 21:30 -!- solocshaw [~Thunderbi@181.215.179.237] has joined #bitcoin-core-dev 21:33 -!- solocshaw [~Thunderbi@181.215.179.237] has left #bitcoin-core-dev [] 21:37 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:37 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:41 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:45 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:45 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:45 < fanquake> Seems to be a lot of misinformation/confusing about the difference between someone being blocked from the repository and issues being locked. The two have nothing todo with each other. Obviously there is a distinction between "lock vs block". 21:45 < fanquake> The only users who get blocked from bitcoin/bitcoin are the ones posting outright nonsense / spam. 21:45 < fanquake> As mentioned, Marco recently went through and did a bulk lock of a number of old, already closed issues. This is something I've also done in the past to proactively prevent spam, although never in bulk. 21:46 < fanquake> There are many cases where an issue can be locked immediately, as there is not going to be any further useful discussion, for example, #23056, so just leaving it open for spam comments seems pointless. 21:46 <@gribble> https://github.com/bitcoin/bitcoin/issues/23056 | configure script failure · Issue #23056 · bitcoin/bitcoin · GitHub 21:46 < fanquake> In any case, any user is always free to open a new issue, or if they'd like to comment on something that has been locked, they can post in IRC, email a maintainer, or just open a new issue anyway, and say they wanted to comment on the older one. However, I'm not aware of this actually having been an issue yet. 21:46 < fanquake> Similar to comments about instances of issue locking, PR closing etc, they never seem to be bought up at the time they may happen, it's only during a discussion like in the meeting, and then no-one seems to have examples. If you've got a problem with an action taken on the repository, please just make someone aware, even if by posting into this channel. 21:47 < fanquake> In regard to certain users, who aren't spammers (and won't be blocked), but have a long history of opening low quality / spammy PRs (i.e see the ratio of opened PRs to merged), and a tendency to perform code review on PRs that may be 5+ years old, after being asked many times not to do so, yes, sometimes those threads get locked, in order to prevent what might as well be spam comments. 21:51 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:51 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:55 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:55 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 21:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 21:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:04 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:09 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:09 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:13 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:13 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:17 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:17 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:29 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:29 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:33 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:34 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:41 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:42 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 22:44 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds] 22:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:53 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:53 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 22:55 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 22:59 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 22:59 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:03 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:03 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:12 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev 23:15 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 23:17 -!- saranshsharma [~saranshsh@202.142.67.7] has joined #bitcoin-core-dev 23:21 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:21 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:25 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:25 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:27 -!- Kiminuo [~Kiminuo@141.98.103.76] has joined #bitcoin-core-dev 23:29 -!- saranshsharma [~saranshsh@202.142.67.7] has quit [Remote host closed the connection] 23:36 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:36 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:40 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:40 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:44 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:44 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:48 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:49 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 23:57 -!- c_arc [~c_arc@4.53.92.114] has quit [Remote host closed the connection] 23:58 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev --- Log closed Fri Oct 08 00:00:27 2021