--- Log opened Fri Oct 22 00:00:10 2021
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81cdbecd75ae...9469ffcb17f0
00:03 < bitcoin-git> bitcoin/master fa38d98 MarcoFalke: doc: Add note on deleting past-EOL release branches
00:03 < bitcoin-git> bitcoin/master 9469ffc MarcoFalke: Merge bitcoin/bitcoin#23323: doc: Add note on deleting past-EOL release br...
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23323: doc: Add note on deleting past-EOL release branches (master...2110-docRelDel) https://github.com/bitcoin/bitcoin/pull/23323
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:04 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 260 seconds]
00:04 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
00:09 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 260 seconds]
00:09 -!- mikehu44__ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
00:11 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
00:26 -!- mikehu44__ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 258 seconds]
00:26 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
00:29 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Client Quit]
00:32 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
00:42 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
00:47 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 258 seconds]
00:58 -!- dougefish [~dougefish@5.29.58.227] has quit [Ping timeout: 260 seconds]
01:05 -!- commmon [~common@096-033-221-075.res.spectrum.com] has quit [Remote host closed the connection]
01:06 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
01:25 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:29 -!- jesseposner_ [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
01:34 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
01:38 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
02:01 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 265 seconds]
02:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
02:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
02:19 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
02:23 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 264 seconds]
02:26 < jnewbery> laanwj fanquake: #23042 seems ready for merge
02:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/23042 | net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer by MarcoFalke · Pull Request #23042 · bitcoin/bitcoin · GitHub
02:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
02:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
02:51 < jnewbery> also #23140
02:51 <@gribble> https://github.com/bitcoin/bitcoin/issues/23140 | Make CAddrman::Select_ select buckets, not positions, first by sipa · Pull Request #23140 · bitcoin/bitcoin · GitHub
02:53 < michaelfolkson> sipa: Right, just a template sketched out roadmap over multiple major versions to have discussions around. Some people raised on the mailing list (reasonably imo) that we shouldn't attempt this given it isn't binding in any way, no authority to ensure it happens, hard to predict what should be in future major versions etc
02:55 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
02:55 < michaelfolkson> But some things should be phased in/out over multiple major versions (if they are to happen at all) so to attempt this it needs a sketched out roadmap which hopefully reviewers will engage with and provide feedback. Deprecation of BDB is in similar boat
02:56 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
03:00 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
03:01 -!- dougefish [~dougefish@5.29.58.227] has joined #bitcoin-core-dev
03:23 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Ping timeout: 260 seconds]
03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9469ffcb17f0...4833d1fdf39f
03:29 < bitcoin-git> bitcoin/master 077a875 Joan Karadimov: refactor: include a missing <limits> header in fs.cpp
03:29 < bitcoin-git> bitcoin/master 4833d1f MarcoFalke: Merge bitcoin/bitcoin#23335: refactor: include a missing <limits> header i...
03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23335: refactor: include a missing <limits> header in fs.cpp (master...include-missing-header) https://github.com/bitcoin/bitcoin/pull/23335
03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:29 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
03:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4833d1fdf39f...c001da306b29
03:30 < bitcoin-git> bitcoin/master d50fbd4 glozow: create explicit GenTxid::{Txid, Wtxid} ctors
03:30 < bitcoin-git> bitcoin/master 4307849 glozow: [mempool] delete exists(uint256) function
03:30 < bitcoin-git> bitcoin/master c001da3 MarcoFalke: Merge bitcoin/bitcoin#23325: mempool: delete exists(uint256) function
03:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23325: mempool: delete exists(uint256) function (master...2021-10-exists-txid) https://github.com/bitcoin/bitcoin/pull/23325
03:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:34 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 258 seconds]
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23336: refactor: Make GenTxid boolean constructor private (master...2110-delGenTxid) https://github.com/bitcoin/bitcoin/pull/23336
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:36 < laanwj> jnewbery: will have a look, thanks
03:53 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev
03:57 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Read error: Connection reset by peer]
03:58 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev
04:06 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
04:20 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:23 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c001da306b29...788909f3c79c
04:23 < bitcoin-git> bitcoin/master fa2662c MarcoFalke: net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer
04:23 < bitcoin-git> bitcoin/master 788909f fanquake: Merge bitcoin/bitcoin#23042: net: Avoid logging AlreadyHaveTx when disconn...
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:23 < bitcoin-git> [bitcoin] fanquake merged pull request #23042: net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer (master...2109-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/23042
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:25 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 258 seconds]
04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/788909f3c79c...02feae54a53f
04:32 < bitcoin-git> bitcoin/master f19ad40 Andrew Chow: rpc, wallet: Descriptor wallets are no longer experimental
04:32 < bitcoin-git> bitcoin/master 9c1052a Andrew Chow: wallet: Default new wallets to descriptor wallets
04:32 < bitcoin-git> bitcoin/master 02feae5 MarcoFalke: Merge bitcoin/bitcoin#23002: Make descriptor wallets by default
04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23002: Make descriptor wallets by default (master...default-desc-wallets) https://github.com/bitcoin/bitcoin/pull/23002
04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 < dougefish> Is there any demand to speed up the CI runs? For example, 04_install.sh updates/installs ubuntu packages every run. One way to decrease runtime is to create a fixed docker image. The default image ubuntu:bionic in .cirrus.yml would be replaced by our own image (e.g. itcoin-core:ubuntu-$SHA1). This also provides reproducale build/CI results, as well as easier to run locally.
04:35 < dougefish> One downside i see is maintaince of this new image and where to "push" it
04:39 -!- dougefish [~dougefish@5.29.58.227] has quit [Quit: dougefish]
04:41 -!- dougefish [~dougefish@5.29.58.227] has joined #bitcoin-core-dev
04:43 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21954: Some minor code changes to improve efficiency of processing TXs (master...TXcatches) https://github.com/bitcoin/bitcoin/pull/21954
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:46 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21841: Send fewer feefilter messages (avoid the wobbling number issue) (master...SteadierFeefilter) https://github.com/bitcoin/bitcoin/pull/21841
04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:48 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21827: Display progress of LoadBlockDB() on splash screen (master...SplashLoadBlockProgress) https://github.com/bitcoin/bitcoin/pull/21827
04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:48 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21618: WIP: Reduce MinRelayFee slower when Mempool utilised and faster when needed. (master...MinRelayFeeReductionChanges) https://github.com/bitcoin/bitcoin/pull/21618
04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:49 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21780: WIP - Add maxmempool RPC (master...MaxMempoolRPC) https://github.com/bitcoin/bitcoin/pull/21780
04:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:51 < bitcoin-git> [bitcoin] dougEfresh opened pull request #23337: tests: Add assert_less_than and assert_less_than_or_equal to test framework (master...23119-assert_less) https://github.com/bitcoin/bitcoin/pull/23337
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:55 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02feae54a53f...58275db3717e
04:55 < bitcoin-git> bitcoin/master 632aad9 Pieter Wuille: Make CAddrman::Select_ select buckets, not positions, first
04:55 < bitcoin-git> bitcoin/master 58275db W. J. van der Laan: Merge bitcoin/bitcoin#23140: Make CAddrman::Select_ select buckets, not po...
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:55 < bitcoin-git> [bitcoin] laanwj merged pull request #23140: Make CAddrman::Select_ select buckets, not positions, first (master...202109_addrmanbias) https://github.com/bitcoin/bitcoin/pull/23140
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:56 < jnewbery> thanks fanquake and laanwj!
05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18902: Bugfix: Only use git for build info if the repository is actually the right one (master...fix_gitdir_again) https://github.com/bitcoin/bitcoin/pull/18902
05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:01 -!- mikehu44_ [~quassel@206.189.41.250] has quit [Ping timeout: 260 seconds]
05:02 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 260 seconds]
05:09 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev
05:10 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
05:13 < real_or_random> dougefish: one neat possibility for cirrus CI is that you can use Cirrus to build the image, let them store it and then use it to run CI
05:14 < real_or_random> we do this in secp256k1. it works pretty well there. though I think it's not compatible with some other features
05:15 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 264 seconds]
05:16 < MarcoFalke> dougefish: Our CI is platfrom agnostic. You should be able to run it on any CI provider, or even locally. I am not sure how much hassle this would be with self-made docker images.
05:19 -!- ravan [~ravan@user/ravan] has quit [Quit: Leaving]
05:28 < MarcoFalke> jonasschnelli: I was about to ask you whether you planned to remove your fingerprint from the "trusted-keys" for merging, but it looks like this will break verify-commits ...
05:31 < laanwj> you would also have a add all his merge commits to exceptions, i guess
05:32 < laanwj> or patch the script to allow different key for different ranges of commits
05:33 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
05:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58275db3717e...5bb03fba049b
05:36 < bitcoin-git> bitcoin/master 6911ab9 Sebastian Falbesoner: wallet: fix segfault by avoiding invalid default-ctored `external_spk_mana...
05:36 < bitcoin-git> bitcoin/master 5bb03fb fanquake: Merge bitcoin/bitcoin#23333: wallet: fix segfault by avoiding invalid defa...
05:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:36 < bitcoin-git> [bitcoin] fanquake merged pull request #23333: wallet: fix segfault by avoiding invalid default-ctored `external_spk_managers` entry (master...202110-wallet-fix_getwalletinfo_segfault_after_importing_descriptor) https://github.com/bitcoin/bitcoin/pull/23333
05:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:39 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:52 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
05:55 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
06:01 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
06:05 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
06:13 -!- jespada [~jespada@2803:9800:9842:7a62:c904:aff:1e1a:fc0a] has joined #bitcoin-core-dev
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:14 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/5bb03fba049b...12eda278ac03
06:14 < bitcoin-git> bitcoin/master a5595b1 Andrew Chow: tests: Remove global vCoins and testWallet from coinselector_tests
06:14 < bitcoin-git> bitcoin/master 5e54aa9 Andrew Chow: bench: remove global testWallet from CoinSelection benchmark
06:14 < bitcoin-git> bitcoin/master 9bf0243 Andrew Chow: bench: Use DescriptorScriptPubKeyMan for wallet things
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:15 < bitcoin-git> [bitcoin] laanwj merged pull request #23288: tests: remove usage of LegacyScriptPubKeyMan from some wallet tests (master...rm-testWallet-tests) https://github.com/bitcoin/bitcoin/pull/23288
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:15 < jonasschnelli> MarcoFalke: I had no plan to remove my keyid,… would that make sense and how would you fix verify commits?
06:16 < jonasschnelli> Ideally, we should set en expiration date next to those keyid
06:30 -!- Guest54 [~Guest54@75.177.176.83] has joined #bitcoin-core-dev
06:30 -!- Guest54 [~Guest54@75.177.176.83] has quit [Client Quit]
06:44 < laanwj> intermittent error in unit tests: ./src/test/blockfilter_index_tests.cpp(140): fatal error: in "blockfilter_index_tests/blockfilter_index_initial_sync": critical check time_start + timeout_ms > GetTimeMillis() has failed
06:47 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Remote host closed the connection]
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:52 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12eda278ac03...a685da55b5d4
06:52 < bitcoin-git> bitcoin/master ea4b61a Pasta: refactor: remove references to deprecated values under std::allocator
06:52 < bitcoin-git> bitcoin/master a685da5 W. J. van der Laan: Merge bitcoin/bitcoin#23181: refactor: remove references to deprecated val...
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:52 < bitcoin-git> [bitcoin] laanwj merged pull request #23181: refactor: remove references to deprecated values under std::allocator (master...btc-allocator) https://github.com/bitcoin/bitcoin/pull/23181
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:55 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
06:59 -!- Guest48 [~Guest48@2600:1700:b950:d740:d85b:abae:b59f:78b1] has quit [Quit: Ping timeout (120 seconds)]
07:00 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
07:04 -!- Guest48 [~Guest48@2600:1700:b950:d740:d85b:abae:b59f:78b1] has joined #bitcoin-core-dev
07:05 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:13 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a685da55b5d4...91c7d66c8b84
07:13 < bitcoin-git> bitcoin/master d047ed7 Sebastian Falbesoner: external_signer: improve fingerprint matching logic (stop on first match)
07:13 < bitcoin-git> bitcoin/master 91c7d66 W. J. van der Laan: Merge bitcoin/bitcoin#22789: external_signer: improve fingerprint matching...
07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:13 < bitcoin-git> [bitcoin] laanwj merged pull request #22789: external_signer: improve fingerprint matching logic (stop on first match) (master...202108-external_signer-improve_fingerprint_matching) https://github.com/bitcoin/bitcoin/pull/22789
07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:14 -!- Guest48 [~Guest48@2600:1700:b950:d740:d85b:abae:b59f:78b1] has quit [Quit: Client closed]
07:22 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:27 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/91c7d66c8b84...a1d55ced099f
07:27 < bitcoin-git> bitcoin/master d95913f Jon Atack: rpc: fix "trusted" description in TransactionDescriptionString
07:27 < bitcoin-git> bitcoin/master 296cfa3 Jon Atack: test: add listtransactions/listsinceblock "trusted" coverage
07:27 < bitcoin-git> bitcoin/master 66f6efc Jon Atack: rpc: improve TransactionDescriptionString() "generated" help
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:27 < bitcoin-git> [bitcoin] laanwj merged pull request #23139: rpc: fix "trusted" field in TransactionDescriptionString(), add coverage (master...fix-rpc-trusted-field-help) https://github.com/bitcoin/bitcoin/pull/23139
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:28 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 258 seconds]
08:02 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a1d55ced099f...224e90d9fdf8
08:18 < bitcoin-git> bitcoin/master faeb9a5 MarcoFalke: remove unused CTxMemPool::info(const uint256& txid)
08:18 < bitcoin-git> bitcoin/master fa4ec1c MarcoFalke: Make GenTxid boolean constructor private
08:18 < bitcoin-git> bitcoin/master 224e90d MarcoFalke: Merge bitcoin/bitcoin#23336: refactor: Make GenTxid boolean constructor pr...
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23336: refactor: Make GenTxid boolean constructor private (master...2110-delGenTxid) https://github.com/bitcoin/bitcoin/pull/23336
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9127:9bab:6e25:cfb7] has joined #bitcoin-core-dev
08:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9127:9bab:6e25:cfb7] has quit [Quit: Client closed]
08:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7] has joined #bitcoin-core-dev
09:04 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
09:07 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 260 seconds]
09:09 < michaelfolkson> glozow: Just looking at #23121. Was there a reason to put the 2 things the PR does in the same PR?
09:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/23121 | [policy] check ancestor feerate in RBF, remove BIP125 Rule2 by glozow · Pull Request #23121 · bitcoin/bitcoin · GitHub
09:10 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
09:13 < michaelfolkson> This getting through the fog of what is a bug and what isn't, how it should be disclosed if it is, how we should deal with policy long term going forward etc is hard to wade through (and it isn't your fault, I'm unsure too)
09:18 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
09:19 < michaelfolkson> Btw I'm not suggesting you split into 2 PRs, just want to understand why you thought they should go together
09:30 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
09:31 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
09:35 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit]
09:39 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Remote host closed the connection]
09:39 -!- Kaizen_Kintsugi [~Kaizen_Ki@d137-186-173-66.abhsia.telus.net] has joined #bitcoin-core-dev
09:51 -!- ravan [~ravan@user/ravan] has joined #bitcoin-core-dev
09:57 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
09:57 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
09:58 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
10:06 -!- Kaizen_Kintsugi [~Kaizen_Ki@d137-186-173-66.abhsia.telus.net] has quit [Remote host closed the connection]
10:07 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
10:13 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 258 seconds]
10:13 < jnewbery> achow101: is it possible that #23288 has made `make check` run a lot more slowly?
10:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/23288 | tests: remove usage of LegacyScriptPubKeyMan from some wallet tests by achow101 · Pull Request #23288 · bitcoin/bitcoin · GitHub
10:13 < jnewbery> on master:
10:13 < jnewbery> time ./src/test/test_bitcoin --run_test=coinselector_tests
10:13 < jnewbery> [...]
10:13 < jnewbery> real	1m13.509s
10:13 < jnewbery> on 12eda278ac038fb998c2e6c19c4f07c91fcb83c2~ (commit before #23288 merge):
10:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/23288 | tests: remove usage of LegacyScriptPubKeyMan from some wallet tests by achow101 · Pull Request #23288 · bitcoin/bitcoin · GitHub
10:13 < jnewbery> time ./src/test/test_bitcoin --run_test=coinselector_tests
10:13 < jnewbery> [...]
10:13 < jnewbery> real	0m4.267s
10:13 < jnewbery> so that single unit test has gone from ~4s to ~1min13s for me
10:14 < achow101> jnewbery: seems plausible
10:14 < achow101> each test case is doing setup now rather than having it occur globally
10:14 < achow101> setup for descriptors may also take a little bit longer than setup for legacy
10:14 < jnewbery> coinselector_tests is one of the last unit tests run, so even with -j it adds a lot of time to the `make check` run
10:15 < achow101> I will see if it can be sped up
10:15 < jnewbery> thank you!
10:25 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
10:47 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
10:51 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 264 seconds]
11:07 -!- xavihers [~xavihers@2803:2d60:1103:24c:2589:6983:ad21:29ac] has joined #bitcoin-core-dev
11:07 < xavihers> Hello everyone, good afternoon
11:08 < xavihers> one question!
11:08 < xavihers> I want develop a wallet for bitcoin on my country.
11:09 < xavihers> What do you recommend?
11:09 < xavihers> Regards,
11:12 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
11:12 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
11:12 < sipa> this channel is for development of the bitcoin core software, not recommendations for other software
11:13 < xavihers> Ok I understand!
11:17 -!- xavihers [~xavihers@2803:2d60:1103:24c:2589:6983:ad21:29ac] has quit [Quit: Client closed]
11:18 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
11:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7] has quit [Quit: Client closed]
11:31 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
11:31 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:36 < michaelfolkson> Don't think gnusha picked up these for the wallet meeting in 30 minutes
11:36 < michaelfolkson> [21:46:21]  <achow101> #proposedwalletmeetingtopic feature_segwit.py
11:36 < michaelfolkson> [21:46:28]  <achow101> #proposedwalletmeetingtopic feature_segwit.py's dependency on legacy wallet
11:38 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:46 < bitcoin-git> [bitcoin] JeremyRubin closed pull request #22948: [Tests] Compute the Power Set of all flags instead of one by one exclusion (master...flag-powerset) https://github.com/bitcoin/bitcoin/pull/22948
11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:47 < jeremyrubin> does anyone have any feelings on #22954 and #22876?
11:47 <@gribble> https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
11:47 <@gribble> https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub
11:49 < jeremyrubin> i recall sipa ack'd this approach in IRC a while back as being the lesser evil (of that, or making CTV valid in mempool before active)
11:49 < jeremyrubin> but i don't think that approach ack extended to these testing changes
11:56 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
11:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7] has joined #bitcoin-core-dev
12:00 < achow101> #startmeeting
12:00 < core-meetingbot> Meeting started Fri Oct 22 19:00:49 2021 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:00 < core-meetingbot> Available commands: action commands idea info link nick
12:01 < achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd 
12:01 < achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:01 < michaelfolkson> hi
12:01 < S3RK> hi
12:01 < meshcollider> hi
12:02 < achow101> there is one preproposed topic, any other topics?
12:03 < achow101> #topic feature_segwit.py's dependency on legacy wallet (achow101)
12:03 < core-meetingbot> topic: feature_segwit.py's dependency on legacy wallet (achow101)
12:03 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:03 < achow101> feature_segwit.py is currently legacy wallet only test
12:03 < brunoerg> hi
12:03 < achow101> I was wondering if we thought it was important enough to refactor to not depend on the lgacy wallet
12:03 < gene> hi
12:04 < achow101> or if it was ok to just ditch it
12:04 < achow101> it seems like a big chunk of it is testing legacy wallet only things
12:04 < achow101> but there is also a part that tests segwit activation and non-wallet things
12:04 < sipa> let me see
12:05 < michaelfolkson> Is this resolved by extending the functionality of MiniWallet (longer term potentially)?
12:05 < achow101> michaelfolkson: no, it's specifically testing weird IsMine behavior
12:05 < achow101> and how the legacy wallet deals with imports, adding segwit addresses, etc.
12:06 < sipa> as long as we have the legacy wallet, i think it's important that those things get tested
12:06 < S3RK> is it covered by other tests?
12:06 < sipa> but it should be separate from testing segwit consensus/activation logic
12:06 < achow101> sipa: yes, but after legacy wallet removal?
12:06 < sipa> what do you mean by removal?
12:07 < achow101> sipa: I've been experimenting with removing the legacy wallet outright (except for migration) and seeing what other things will need to be done in order to get that through
12:07 < sipa> that's useful i guess to see what unnecessarily depends on it
12:07 < sipa> though, i hope we're not planning to actually drop support for legacy wallets anytime soon?
12:08 < michaelfolkson> For the benefit of those following along achow101 is in process of deprecating both the legacy wallet and BerkeleyDB https://github.com/bitcoin/bitcoin/issues/20160
12:08 < achow101> see #20160
12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/20160 | Proposed Timeline for Legacy Wallet and BDB removal · Issue #20160 · bitcoin/bitcoin · GitHub
12:08 < achow101> sipa: the plan is for a few years
12:08 < michaelfolkson> Legacy wallet is non-descriptor wallet
12:08 < michaelfolkson> "The 4 combinations of type and format are: legacy-bdb, legacy-sqlite, descriptor-bdb, and descriptor-sqlite"
12:08 < sipa> yeah, ok, a few years from now
12:09 < sipa> i think in principle, tests testing the wallet behavior should be separate from tests of other behavior
12:10 < achow101> agreed
12:10 < sipa> the feature_segwit.py test does seem to mix these
12:11 < michaelfolkson> So split feature_segwit.py up into 2+ files?
12:11 < sipa> i don't think files matter
12:11 < sipa> just cleanly separating the tests would be a nice improvement already
12:13 < michaelfolkson> It seems to me that legacy wallet support in the tests has to linger to a limited extent to do migration test etc
12:13 < achow101> #23312 puts all of the legacy wallet specific tests of feature_segwit behind --legacy-wallet
12:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/23312 | tests: reduce feature_segwit.py usage of the legacy wallet by achow101 · Pull Request #23312 · bitcoin/bitcoin · GitHub
12:13 < sipa> there is a difference between a test _of non-wallet code_ that happens to use the wallet
12:13 < sipa> and a test of the wallet code itself
12:14 < achow101> although I'm not sure if the first part that does some stuff with multisig is testing legacy wallet or just incidental
12:15 < michaelfolkson> "a test _of non-wallet code_ that happens to use the wallet" should use MiniWallet longer term right?
12:15 < sipa> maybe, i haven't paid attention to that
12:15 < sipa> but probably, yes
12:15 < michaelfolkson> But not "a test of the wallet code itself"
12:17 < achow101> ok, I guess I will try to split it up
12:17 < sipa> FWIW, i think a bunch of non-wallet tests of script features etc can probably be redone in feature_taproot.py
12:17 < sipa> it has a whole framework of randomly constructing errors/transactions/scripts
12:17 < michaelfolkson> Hmm I guess a refactor would be better but maybe someone other than achow101 could attempt it (if he has enough to do!)
12:18 < michaelfolkson> Interested S3RK? :)
12:18 < sipa> and feature_taproot.py itself might be portable to use miniwallet for the wallet side of things (it already mostly does its own utxo management etc)
12:19 < S3RK> i can take on it, once i finish the coin selection improvement that I started
12:20 < S3RK> i hope it can wait, because with my speed it might take a while :) 
12:20 < sipa> it's been there for 4 years, it won't run away
12:21 < achow101> I have another topic if we're done with this one?
12:21 < achow101> #topic having ScriptPubKeyMans fetch keys from a wallet keystore rather than handling keys individually
12:21 < core-meetingbot> topic: having ScriptPubKeyMans fetch keys from a wallet keystore rather than handling keys individually
12:23 < achow101> one of the issues with setting up multisigs and setting up new descriptors is that keys are tied to ScriptPubKeyMans, so it is difficult to get a "wallet key"
12:23 < sipa> (judging based just on the one-line summary) that sounds like a good idea... you could think of it as the integrated "software signing device" of the wallet
12:23 < S3RK> do you mean master key, right?
12:24 < achow101> sipa: yes, I was thinking of something in the same model of external hardware signer but internal and software
12:24 < sipa> i think it makes sense... there is nothing that makes private keys tied to specific SPKmans
12:24 < achow101> S3RK: kind of
12:25 < sipa> spkmans mostly ought to live in the "deciding what is ours" domain, not in the "what can we sign" domain
12:25 < achow101> sipa: but "what can we sign" should align with "what is ours"
12:25 < sipa> achow101: well, maybe- there are also external signers, watch-only wallets, multisig you can participate in
12:26 < sipa> those are modeled by spkmans, but their signing story is kind of orthogonal
12:26 < achow101> sipa: but all of those things would be tied to a spkman that should be in the wallet
12:26 < sipa> right, but does it matter _which_ spkman?
12:26 < sipa> holds the keys
12:27 < sipa> like you can sign for something, or you can't
12:27 < achow101> sure
12:27 < sipa> if you'd have the same pubkey/xpub in multiple distinct descriptors, would you ever not want to sign with one, because it was linked with another descriptor?
12:27 < sipa> you have the key, might as well use it
12:28 < achow101> I think that's fine
12:28 < achow101> what I want to avoid is signing for things for which we don't have a spkman for
12:28 < achow101> e.g. if the wallet only has a wpkh(), then it shouldn't sign for multisigs even if it has the keys
12:28 < sipa> i think that's fine; i'm not sure it's necessarily a problem if it's different
12:29 < sipa> once an output is created it's "too late" in a sense - if you can sign for it, and it's in a transaction that you agree with, why wouldn't you?
12:30 < sipa> of course, in practice, in order to sign you'll likely need access to an SPKMan to pull things like redeemscripts and whatnot
12:30 < achow101> if it's in a psbt, not necessarily
12:30 < sipa> right
12:30 < sipa> in a psbt, i think there is no problem at all with signing whatever you can, independent of whether it's something you consider yours or not
12:31 < sipa> but i'm also fine with "that's too hard to make work, and isn't supported"
12:31 < achow101> it's probably easier to make that work given the way our signing code is setup
12:32 < achow101> in any case, it seems like this change would be a good idea
12:32 < S3RK> fwiw, I think it's good
12:33 < achow101> it would also make adding new descriptors like tr() easier
12:33 < S3RK> and multisig
12:33 < achow101> any other topics
12:33 < sipa> right, import the same xpub (maybe different branch), and signing will just work?
12:34 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:34 < achow101> #endmeeting
12:34 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:34 < core-meetingbot> Meeting ended Fri Oct 22 19:34:23 2021 UTC.  
12:34 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-10-22-19.00.moin.txt
12:34 < S3RK> achow101: do you plan to implement it before doing "upgrade wallet to tr" feature?
12:35 < achow101> S3RK: probably
12:35 < S3RK> i was about to ask how is it going. but I guess this topic was the answer
12:35 < achow101> I'm going to try it on monday
12:36 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev
12:36 < achow101> S3RK: I do have a functional branch that does tr upgrade. but I don't really like that approach which is why there isn't a PR for it
12:36 -!- freesprung [~freesprun@user/freesprung] has joined #bitcoin-core-dev
12:36 < S3RK> understandable, it's hacky. well looking forward to it
12:37 < michaelfolkson> This functional branch does what exactly?
12:37 -!- davterra [~davterra@143.198.56.186] has quit [Ping timeout: 245 seconds]
12:38 < michaelfolkson> tr(KEY) is supported already so this branch upgrades to what?
12:38 < achow101> michaelfolkson: automagically adds a tr descriptor to a wallet
12:38 < michaelfolkson> Ah ok
12:38 < michaelfolkson> Without user generating it?
12:38 < achow101> yes-ish
12:39 < achow101> it requires knowing the spkman id for something already in the wallet and it pulls the key to use from there
12:39 < achow101> kinda shit in terms of ux
12:40 < S3RK> wouldn't you have the same problem when trying to pull the keys from spkman to the wallet?
12:40 < S3RK> how do you know which key to pick? (in case different descriptors have different keys)
12:40 < achow101> my current idea is that there would be a record in the wallet similar to the hdchain record
12:41 < achow101> it would store the xpub of the key last used for autogenerating descriptors
12:41 < S3RK> but that's only for the new wallets. What about the existing ones?
12:41 < achow101> for existing wallets, we can determine that with a bit of heuristics. it would pretty much be the only key that has a descriptor for each address type
12:41 < achow101> I think it is highly unlikely that someone would import 1 descriptor for each address type all using the same key
12:42 < S3RK> should work 99% of the time :) 
12:42 < achow101> and if they did, I feel like they would expect that key to be used for tr too, so not really a problem :)
12:42 < achow101> s/expect/want
12:42 < S3RK> yes, that make sense to me
12:43 < achow101> additionally, we should try to get this in before 23.0 because then we can say "it was experimental :shrug:"
12:43 < S3RK> so it'll be some upgrade wallet code at load time (w/o explicit user action)?
12:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7] has quit [Quit: Client closed]
12:43 < S3RK> I'd happily review and test this
12:44 < achow101> yes, I don't think it will need any explicit user action
12:44 < S3RK> sounds goot to me
12:44 < S3RK> s/goot/good/
12:46 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
12:46 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 260 seconds]
13:10 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Remote host closed the connection]
13:11 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
13:15 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 245 seconds]
13:18 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
13:20 -!- kinlo [~peter@user/kinlo] has quit [Ping timeout: 245 seconds]
13:22 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
13:26 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
13:26 -!- kinlo [~peter@user/kinlo] has joined #bitcoin-core-dev
13:39 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:41 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 276 seconds]
13:44 -!- Kaizen_Kintsugi [~Kaizen_Ki@d137-186-173-66.abhsia.telus.net] has joined #bitcoin-core-dev
13:48 -!- Kaizen_Kintsugi [~Kaizen_Ki@d137-186-173-66.abhsia.telus.net] has quit [Ping timeout: 245 seconds]
13:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:50 < bitcoin-git> [gui] hebasto merged pull request #454: Use only Qt translation primitives in GUI code (master...2021-10-qt-use-at-translation) https://github.com/bitcoin-core/gui/pull/454
13:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:51 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/224e90d9fdf8...bdbefdcd5cce
13:51 < bitcoin-git> bitcoin/master 58765a4 W. J. van der Laan: qt: Use only Qt translation primitives in GUI code
13:51 < bitcoin-git> bitcoin/master bdbefdc Hennadii Stepanov: Merge bitcoin-core/gui#454: Use only Qt translation primitives in GUI code...
13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:53 -!- copumpkin [~woohoo@user/copumpkin] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:58 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:09 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
14:09 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
14:10 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:21 < bitcoin-git> [bitcoin] achow101 opened pull request #23338: tests: speed up coinselector_tests (master...speed-up-cs-tests) https://github.com/bitcoin/bitcoin/pull/23338
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:31 -!- Netsplit *.net <-> *.split quits: jkczyz, hendi, fjahr, cdecker, real_or_random, @gribble, sturles, Nebraskka, jarolrod, lightlike,  (+5 more, use /NETSPLIT to show all of them)
14:31 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has joined #bitcoin-core-dev
14:31 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #bitcoin-core-dev
14:31 -!- Netsplit over, joins: sturles, Keele
14:31 -!- lightlike [sid521075@user/lightlike] has joined #bitcoin-core-dev
14:31 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has joined #bitcoin-core-dev
14:31 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has joined #bitcoin-core-dev
14:32 -!- Netsplit over, joins: Evolver
14:32 -!- hendi [sid489601@id-489601.lymington.irccloud.com] has joined #bitcoin-core-dev
14:33 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #bitcoin-core-dev
14:33 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has joined #bitcoin-core-dev
14:34 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev
14:38 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
14:38 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
14:42 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin]
14:43 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:54 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Remote host closed the connection]
14:54 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
15:37 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
15:58 -!- jespada [~jespada@2803:9800:9842:7a62:c904:aff:1e1a:fc0a] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:00 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
16:02 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit]
16:18 -!- ravan [~ravan@user/ravan] has quit [Remote host closed the connection]
16:18 -!- ravan [~ravan@user/ravan] has joined #bitcoin-core-dev
16:19 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Remote host closed the connection]
16:20 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
16:24 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:31 < bitcoin-git> [bitcoin] PastaPastaPasta opened pull request #23340: build: upgrade to boost 1.73 to fix c++20 compilation (master...bump-boost-version-1.73-btc) https://github.com/bitcoin/bitcoin/pull/23340
16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:39 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net] has joined #bitcoin-core-dev
16:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:14 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
17:31 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com]
18:05 -!- yanmaani1 is now known as yanmaani
18:33 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 258 seconds]
18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:38 < bitcoin-git> [bitcoin] meshcollider opened pull request #23341: RPC: Better safety with newkeypool command and wallet backups (master...202110_newkeypool_documentation) https://github.com/bitcoin/bitcoin/pull/23341
18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:43 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bdbefdcd5cce...04437ee721e6
18:43 < bitcoin-git> bitcoin/master f778845 Hennadii Stepanov: ci: Add vcpkg tools cache
18:43 < bitcoin-git> bitcoin/master 04437ee fanquake: Merge bitcoin/bitcoin#23215: ci: Add vcpkg tools cache
18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:43 < bitcoin-git> [bitcoin] fanquake merged pull request #23215: ci: Add vcpkg tools cache (master...211007-ci) https://github.com/bitcoin/bitcoin/pull/23215
18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:01 -!- BUSY [~BUSY@user/busy] has quit [Remote host closed the connection]
19:06 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
19:10 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Ping timeout: 265 seconds]
19:12 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Read error: Connection reset by peer]
19:12 -!- cryptapus_ [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev
19:20 -!- sirdigby727 [uid523338@id-523338.lymington.irccloud.com] has quit [Ping timeout: 258 seconds]
19:20 -!- fanquake [sid369002@user/fanquake] has quit [Read error: Connection reset by peer]
19:20 -!- glozow [sid453516@user/glozow] has quit [Read error: Connection reset by peer]
19:20 -!- Evolver [sid32215@user/evolver] has quit [Ping timeout: 260 seconds]
19:20 -!- Evolver [sid32215@user/evolver] has joined #bitcoin-core-dev
19:20 -!- bw [sid2730@user/betawaffle] has quit [Ping timeout: 252 seconds]
19:21 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Ping timeout: 258 seconds]
19:21 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has quit [Ping timeout: 260 seconds]
19:21 -!- sirdigby727 [uid523338@lymington.irccloud.com] has joined #bitcoin-core-dev
19:22 -!- fanquake [sid369002@user/fanquake] has joined #bitcoin-core-dev
19:22 -!- glozow [sid453516@user/glozow] has joined #bitcoin-core-dev
19:22 -!- larryruane [sid473749@uxbridge.irccloud.com] has joined #bitcoin-core-dev
19:23 -!- bw [sid2730@user/betawaffle] has joined #bitcoin-core-dev
19:23 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 245 seconds]
19:24 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has joined #bitcoin-core-dev
19:30 -!- glozow [sid453516@user/glozow] has quit [Ping timeout: 264 seconds]
19:31 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has quit [Ping timeout: 258 seconds]
19:31 -!- glozow [sid453516@user/glozow] has joined #bitcoin-core-dev
19:32 -!- fanquake [sid369002@user/fanquake] has quit [Ping timeout: 252 seconds]
19:32 -!- jkczyz_ [sid419941@lymington.irccloud.com] has joined #bitcoin-core-dev
19:32 -!- hendi [sid489601@id-489601.lymington.irccloud.com] has quit [Ping timeout: 260 seconds]
19:32 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has quit [Ping timeout: 260 seconds]
19:32 -!- jkczyz_ is now known as jkczyz
19:32 -!- fjahr [sid374480@uxbridge.irccloud.com] has joined #bitcoin-core-dev
19:32 -!- jarolrod_ [sid475272@uxbridge.irccloud.com] has joined #bitcoin-core-dev
19:32 -!- lightlike_ [sid521075@user/lightlike] has joined #bitcoin-core-dev
19:32 -!- lightlike [sid521075@user/lightlike] has quit [Ping timeout: 258 seconds]
19:32 -!- lightlike_ is now known as lightlike
19:32 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 264 seconds]
19:32 -!- jarolrod_ is now known as jarolrod
19:33 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev
19:33 -!- hendi [sid489601@lymington.irccloud.com] has joined #bitcoin-core-dev
19:35 -!- fanquake [sid369002@user/fanquake] has joined #bitcoin-core-dev
20:13 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
20:18 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
20:31 -!- jtrag [~jtrag@user/jtrag] has quit [Quit: <-----  is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:21 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 260 seconds]
21:33 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
23:05 -!- ravan [~ravan@user/ravan] has quit [Quit: Leaving]
23:15 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
23:28 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
23:30 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
23:49 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 265 seconds]
--- Log closed Sat Oct 23 00:00:11 2021