--- Log opened Tue Nov 02 00:00:21 2021 00:25 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev 00:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 00:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 00:32 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!] 00:36 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev 00:41 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 00:41 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 00:53 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 00:53 -!- goatpig [~goat@pop.92-184-106-30.mobile.abo.orange.fr] has joined #bitcoin-core-dev 00:55 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 00:58 -!- goatpig [~goat@pop.92-184-106-30.mobile.abo.orange.fr] has quit [Ping timeout: 268 seconds] 01:00 -!- goatpig [~goat@pop.92-184-106-30.mobile.abo.orange.fr] has joined #bitcoin-core-dev 01:10 -!- goatpig_ [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev 01:10 -!- goatpig [~goat@pop.92-184-106-30.mobile.abo.orange.fr] has quit [Ping timeout: 268 seconds] 01:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 01:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 01:22 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev 01:33 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5adc5c02800f...76886ce11e85 01:43 < bitcoin-git> bitcoin/master c02a674 Hennadii Stepanov: doc: Add output script descriptors BIPs 380..386 01:43 < bitcoin-git> bitcoin/master 76886ce MarcoFalke: Merge bitcoin/bitcoin#23410: doc: Add output script descriptors BIPs 380..... 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23410: doc: Add output script descriptors BIPs 380..386 (master...211101-bips) https://github.com/bitcoin/bitcoin/pull/23410 01:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:55 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 268 seconds] 02:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 02:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 260 seconds] 02:15 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.3] 02:19 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev 02:38 -!- Xandrah [~Xandrah@user/xandrah] has quit [Quit: Leaving] 02:51 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev 02:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 03:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 03:03 -!- kexkey [~kexkey@static-198-54-132-132.cust.tzulo.com] has quit [Ping timeout: 268 seconds] 03:05 -!- kexkey [~kexkey@static-198-54-132-84.cust.tzulo.com] has joined #bitcoin-core-dev 03:12 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:13 < bitcoin-git> [bitcoin] dougEfresh closed pull request #23337: tests: Add assert_less_than and assert_less_than_or_equal to test framework (master...23119-assert_less) https://github.com/bitcoin/bitcoin/pull/23337 03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:13 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 03:13 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 03:18 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds] 03:18 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 03:23 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 03:41 -!- kinlo [~peter@user/kinlo] has quit [Ping timeout: 260 seconds] 03:41 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev 03:47 -!- kinlo [~peter@user/kinlo] has joined #bitcoin-core-dev 03:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 03:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 04:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 04:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Remote host closed the connection] 04:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 04:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 04:49 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:52 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds] 04:53 -!- Guyver2_ is now known as Guyver2 04:58 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Remote host closed the connection] 04:58 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 05:07 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Remote host closed the connection] 05:08 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 05:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 05:22 -!- laanwj [~laanwj@user/laanwj] has joined #bitcoin-core-dev 05:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 05:41 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/76886ce11e85...9e3f7dcaa2f8 05:41 < bitcoin-git> bitcoin/master 8c96008 Troy Giorshev: [net] Don't return an optional from TransportDeserializer::GetMessage() 05:41 < bitcoin-git> bitcoin/master f3e451b Troy Giorshev: [net] Replace GetID() with id in TransportDeserializer constructor 05:41 < bitcoin-git> bitcoin/master 9e3f7dc MarcoFalke: Merge bitcoin/bitcoin#22735: [net] Don't return an optional from Transport... 05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22735: [net] Don't return an optional from TransportDeserializer::GetMessage() (master...2021-08-20364-rebased) https://github.com/bitcoin/bitcoin/pull/22735 05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:00 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 268 seconds] 06:17 -!- ghostkee_ [~ghostkeep@47.196.70.51] has joined #bitcoin-core-dev 06:19 -!- ghostkee_ [~ghostkeep@47.196.70.51] has quit [Client Quit] 06:24 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 06:24 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 06:27 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev 06:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 06:31 -!- goatpig_ [~goat@static-193-13-33-110.cust.tele2.se] has quit [Remote host closed the connection] 06:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 06:39 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:21 -!- Guest0 [~Guest0@2a02:1206:4592:4820:1521:cf99:29aa:a0de] has joined #bitcoin-core-dev 07:22 -!- Guest0 [~Guest0@2a02:1206:4592:4820:1521:cf99:29aa:a0de] has quit [Client Quit] 07:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 07:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:52 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23416: doc: Remove fee delta TODO from txmempool.cpp (master...2111-docFeeDelta) https://github.com/bitcoin/bitcoin/pull/23416 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:53 < ryanofsky> Could I get #21206 added to https://github.com/bitcoin/bitcoin/projects/8 now that #22766 is off? 07:53 <@gribble> https://github.com/bitcoin/bitcoin/issues/21206 | refactor: Make CWalletTx sync state type-safe by ryanofsky · Pull Request #21206 · bitcoin/bitcoin · GitHub 07:53 <@gribble> https://github.com/bitcoin/bitcoin/issues/22766 | refactor: Clarify and disable unused ArgsManager flags by ryanofsky · Pull Request #22766 · bitcoin/bitcoin · GitHub 07:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 08:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 08:06 -!- meshcollider [meshcollid@user/meshcollider] has quit [Quit: :wave:] 08:06 -!- paulo [paulo@user/paulo/x-9032687] has quit [Quit: ZNC 1.8.2 - https://znc.in] 08:07 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 268 seconds] 08:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 08:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 08:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 08:18 -!- kexkey [~kexkey@static-198-54-132-84.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 08:19 -!- kexkey [~kexkey@static-198-54-132-166.cust.tzulo.com] has joined #bitcoin-core-dev 08:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 08:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 08:26 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!] 08:27 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-dev 08:28 -!- paulo [paulo@user/paulo/x-9032687] has joined #bitcoin-core-dev 08:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 08:33 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:36 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds] 08:36 -!- Guyver2_ is now known as Guyver2 08:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 260 seconds] 08:37 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 08:37 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:42 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 08:42 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:57 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 09:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 09:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 09:15 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev 09:25 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!] 09:31 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Read error: Connection reset by peer] 09:31 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 09:32 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 09:37 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 268 seconds] 09:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 09:39 < provoostenator> The addrman documentation is pretty clear about when put stuff _into_ a "tried" bucket, but I'm having a hard time understanding when we actually use the tried bucket over the new bucket. 09:42 -!- jarthur [~jarthur@2603-8080-1540-002d-d4d1-6d9f-a6fc-1fe3.res6.spectrum.com] has joined #bitcoin-core-dev 09:42 < provoostenator> Inside the Select() implementation it says there's a 50% chance of using the tried or the new table. 09:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 09:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 09:44 < provoostenator> And Select() is called in net.cpp when making outbound connections. So that part makes sense. 09:47 < provoostenator> IIUC in response to GetAddr we use both new and tried, but do check against IsTerrible? 09:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 09:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 09:50 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev 09:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 264 seconds] 09:58 -!- kexkey [~kexkey@static-198-54-132-166.cust.tzulo.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:59 -!- kexkey [~kexkey@static-198-54-132-134.cust.tzulo.com] has joined #bitcoin-core-dev 10:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 10:03 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 268 seconds] 10:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 10:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 10:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 10:11 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 10:15 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 10:16 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds] 10:16 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 268 seconds] 10:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 10:20 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 10:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 10:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 10:23 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev 10:27 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 264 seconds] 10:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 10:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 10:42 < lightlike> provoostenator: correct, Select() first flips a coin between new/tried, and then searches inside the respective table until it's found an address. GetAddr() picks randomly non-terrible addresses, it doesn't take care whether they are in new or tried 10:48 < provoostenator> And addresses that we proactively gossip? 10:49 < sipa> there is no such thing 10:50 < sipa> we gossip addresses (a) our own, periodically (b) relaying addrs received from other peers (c) in response to getaddr 10:50 < provoostenator> Right, I meant (b) 10:50 < sipa> addrman isn't involved there 10:51 < provoostenator> I see, not even a check against IsTerrible? 10:51 < sipa> maybe, let me check 10:52 < sipa> nope, just against banning/discouraging 10:52 < provoostenator> Context: I'm tring to understand #22387 and https://arxiv.org/abs/2108.00815 10:52 <@gribble> https://github.com/bitcoin/bitcoin/issues/22387 | Rate limit the processing of rumoured addresses by sipa · Pull Request #22387 · bitcoin/bitcoin · GitHub 10:52 < provoostenator> I first assumed we would only relay tried addresses, but that's obviously not so. 10:53 < provoostenator> Presumably because then there'd be too few? 10:54 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 10:56 < sipa> generally rumoured addresses wouldn't be things we already know 10:57 < sipa> so perhaps you're suggesting is that rumoured addr messages should be drawn from addrman rather than from what we receive from others? 10:57 < sipa> that's... not impossible, but very different from what we call relay 10:57 < provoostenator> Not so much suggesting, but wondering why. 10:58 < sipa> well the idea is that when you gossip your own address, the expectation is that it will generally reach a substantial fraction of the network nodes 10:58 < sipa> not just your peers 10:59 < provoostenator> It would indeed propagate very slowly if your peers first had to check it and their peers, etc. 10:59 < provoostenator> R=0.0001 slowly :-) 10:59 < sipa> idd 11:00 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 11:00 < provoostenator> So (b) is only done to serve (a)? (even though of course we can't check that it's not used to broadcast other stuff) 11:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 11:01 < sipa> indeed, (b) is what makes (a) relay to the entire network 11:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 260 seconds] 11:06 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds] 11:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:11 < bitcoin-git> [bitcoin] achow101 opened pull request #23417: wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager (master...wallet-keyman) https://github.com/bitcoin/bitcoin/pull/23417 11:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:34 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 11:39 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 260 seconds] 11:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:40 -!- satoshi [~satoshi@gateway/tor-sasl/satoshi] has joined #bitcoin-core-dev 11:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 11:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 260 seconds] 11:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 12:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 12:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 12:05 -!- satoshi [~satoshi@gateway/tor-sasl/satoshi] has quit [Quit: satoshi] 12:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 260 seconds] 12:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 12:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 12:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 12:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 260 seconds] 12:29 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 12:34 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 260 seconds] 12:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23418: Fix signed integer overflow in prioritisetransaction RPC (master...2111-txPoolPrioOverflow) https://github.com/bitcoin/bitcoin/pull/23418 12:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e3f7dcaa2f8...3c4729a515d8 12:56 < bitcoin-git> bitcoin/master 6ae9f1c Jon Atack: Disable lock contention logging in checkqueue_tests 12:56 < bitcoin-git> bitcoin/master 3c4729a MarcoFalke: Merge bitcoin/bitcoin#23223: Disable lock contention logging in checkqueue... 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23223: Disable lock contention logging in checkqueue_tests (master...alleviate-checkqueue-tests-contention-logging) https://github.com/bitcoin/bitcoin/pull/23223 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:57 -!- satoshi [~satoshi@gateway/tor-sasl/satoshi] has joined #bitcoin-core-dev 13:01 < satoshi> Discussion about the recent version number change. #proposedmeetingtopic 13:04 < shiza> It was a bad idea, but it's done now. Save your strength. 13:05 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 13:07 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 13:07 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 13:08 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 13:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 13:21 < fjahr> shiza: Why was it a bad idea? 13:24 < shiza> It creates unnecesary confusion in users and breaks a lot of unimportant deployment pipelines. It wastes store in version defines. 13:26 < shiza> It was an unnecesary change with just a few unimportant benefits for a lot of unimportant disadvantages. 13:27 < shiza> But everybody knew that, so it's OK. 13:30 < shiza> Good sign such an unimportant change is a source of dissent. 13:39 < sipa> "it wastes store" ? 13:42 < shiza> that was quite poorly worded, but what I mean is unimportant as well 13:43 < sipa> i don't understand; the version define didn't even change 13:43 < sipa> but i'm also not going to argue about it again :) 13:45 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 13:45 < shiza> I assumed Bitcoin uses a Boost style version define. 13:46 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 13:46 < shiza> Something like 210000 bumping to 220000 13:47 < sipa> perhaps look at the actual code change before commenting on it :) 13:47 < sipa> https://github.com/bitcoin/bitcoin/pull/20223 13:47 < sipa> 0.21 had CLIENT_VERSION 210000, 22.0 has 220000 13:48 < shiza> I promise I read the whole commit (weeks ago) 13:49 < shiza> I was promptly unamused by the change as much as by not having good arguments against it 13:49 < sipa> haha 13:51 < satoshi> The original format originally indicated time, as part of the timestamp. 13:52 < sipa> i have no idea what you're talking about 13:52 < satoshi> Example: Bitcoin 0.1.0 - 2009:01:07 01:00:00 13:53 < shiza> The date is redundant information there. Resides in the repository. 13:54 < satoshi> The current version number should be 2.2.0 13:56 -!- radixrat [~radixrat@bras-base-ptboon6211w-grc-98-76-64-75-198.dsl.bell.ca] has joined #bitcoin-core-dev 13:56 < shiza> Old clients don't care if future clients are 22.0 or 2.2.0 13:57 < shiza> The unbroken protocol is all that matters. 13:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Remote host closed the connection] 13:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has joined #bitcoin-core-dev 13:59 -!- radixrat [~radixrat@bras-base-ptboon6211w-grc-98-76-64-75-198.dsl.bell.ca] has quit [Client Quit] 13:59 -!- radixrat [~radixrat@bras-base-ptboon6211w-grc-98-76-64-75-198.dsl.bell.ca] has joined #bitcoin-core-dev 14:02 -!- brunoerg_ [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 14:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8838:55b5:51e0:8700] has quit [Ping timeout: 268 seconds] 14:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 264 seconds] 14:07 -!- brunoerg_ [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 264 seconds] 14:08 < satoshi> Linux kernel version history probably a good reference to illustrate why the current versioning in Bitcoin is wrong: https://en.wikipedia.org/wiki/Linux_kernel_version_history 14:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 14:14 < shiza> Those are tidy version numbers compared to bumping 0 to 22. But the beauty doesn't justify a revision of the topic. 14:15 < shiza> Rolling back costs more than keeping forward. 14:16 < shiza> Anyway, old wallets are going to start causing problems, so better warn users early that things are moving faster now. 14:16 < satoshi> Would correct myself, the current version number should be Bitcoin 0.22.0. Reaching 0.99 is not that far in future, Reaching 1.0.0 would have the CLIENT_VERSION 1 million. It makes more sense to me, than reaching 99.0 in 15 years. This is not a rush for highest CLIENT_VERSION. 14:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 264 seconds] 14:19 < satoshi> CLIENT_VERSION would flip to a million in a few years from now. We should not do that, after us there will be many releases. It makes sense to keep the version format as it was otherwise the flip happens faster than it should. 14:19 < sipa> CLIENT_VERSION _has not changed_ 14:19 < satoshi> it will change when reached 99.0 14:20 < satoshi> CLIENT_VERSION will be 1000000 14:20 < sipa> that's entirely orthogonal to the version naming discussion 14:20 < sipa> The old version scheme was woefully obsolete; it had basically digressed into effectively being 0.MAJOR.MINOR, where the 0 was redundant. There were reasonable discussions to be had about whether that was sufficient to justify replacing it, and about what the new scheme should be. But we're not going to revert back to a older worse scheme. This discussion is pointless. 14:20 < earnestly> https://0ver.org/ 14:21 < satoshi> earnestly thanks 14:22 < shiza> wkhtmltopdf embraces 0ver, and wkhtmltopdf can't be wrong! 14:22 < earnestly> Just have a number, then number go up 14:24 < satoshi> https://0ver.org/ still listing Bitcoin. 14:25 < sipa> Version 0.0.1 of ZeroVer was published by Mahmoud Hashemi, with help from Moshe, Mark, Kurt, and other patient collaborators, on 2018-04-01. ZeroVer is satire, please do not use it. We sincerely hope no project release schedules were harmed as a result of this humble attempt at programmer humor. 14:26 < sipa> -- https://0ver.org/about.html 14:27 < satoshi> I see it, they start from 0.0.1 which is not how Bitcoin started. Bitcoin 0.1.0 14:28 < sipa> The whole thing is a joke. Seriously. 14:28 < luke-jr> satoshi: .99 does not become 1.0 14:28 < satoshi> sipa is this a joke to you? https://bitcoincore.org/en/lifecycle/ 14:28 < sipa> satoshi: 0ver.org is a joke 14:29 < sipa> It's making fun of projects that never manage to get rid of their 0-based version number. 14:29 < shiza> bitcoincore.org source is public, you can propose fixes to it 14:31 < luke-jr> would make more sense to bump to 22.0.1 for the first bugfix release instead of 22.1, but is it worth arguing? not so sure 14:32 < earnestly> I'm surprised the satire wasn't obvious, those leading quotes are excellent 14:33 < earnestly> Version numbers don't really need to mean anything. A single number that increases is usually enough. What does .1 add? All it signals is "This is a version you don't have to update to" 14:34 < earnestly> Some add meaning like semver for API/ABI changes, etc. It's often not enough in practice and people end up doing version pinning through git checkouts 14:34 < luke-jr> earnestly: it doesn't signal that; you need a way to express "fixes only" vs "new features" 14:34 < satoshi> luke-jr I don't see any problem with that, technically 0.999.0 would produce CLIENT_VERSION 9990000. Bitcoin 2.1.0 would be 21000000. 14:34 < luke-jr> earnestly: consider the recent 0.20.x release 14:34 < earnestly> In both cases it's just indicating "You don't have to update" 14:35 < luke-jr> earnestly: it's more important to upgrade for fixes (.1) than features (.0) 14:35 < sipa> https://github.com/mahmoud/zerover/issues/112 14:35 < earnestly> I don't know anymore, I've spent so many years looking at this, and I just can't see it as a long term viable model. In the end it doesn't really matter and people do what they want 14:36 < earnestly> But in general, and thankfully so, more people are realising that just keeping things up to date is a much better strategy than any notion of patching, backporting, etc. 14:36 -!- radixrat [~radixrat@bras-base-ptboon6211w-grc-98-76-64-75-198.dsl.bell.ca] has quit [Quit: leaving] 14:36 < luke-jr> earnestly: it's not 14:37 < earnestly> Considering backporting empricially doesn't even work 14:37 < shiza> In a world that Bitcoin never hard forks itself, the leading 0 is unnecesary. 14:37 -!- Guest67 [~Guest67@13.110.54.41] has joined #bitcoin-core-dev 14:37 < luke-jr> of course it does 14:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 14:37 < earnestly> Not even redhat and debian can keep up with the CVEs, let alone the non-CVEs 14:37 < luke-jr> shiza: the version is for Bitcoin Core, not Bitcoin 14:37 < earnestly> That's how you get glibc GHOST 14:37 < luke-jr> earnestly: nobody said backporting needs to be centralised 14:38 < earnestly> So no, backporting is a fools game. Security researchers have been calling this out for over a decade now 14:38 < shiza> I need more sleep, obviously. 14:38 < earnestly> So, people are learning, slowly 14:38 < earnestly> luke-jr: There is no backporting outside of people dedicated, and paid, to do so. Everything else is version pinning 14:38 < luke-jr> earnestly: bleeding edge introduces new vulns 14:39 < earnestly> This is true, it introduces unknowns. But addressing the knowns is more valuable 14:39 < luke-jr> that's what backports do 14:39 < earnestly> In theory this is true but in practice it doesn't pan out 14:40 < earnestly> It could be one of those 80/20 things at best but even then it's not even close 14:40 < earnestly> (And that's just for stuff which is open source, and backportable) 14:40 < shiza> You are both right, unfortunately. 14:40 < luke-jr> earnestly: are you saying Core 0.20.2 has known vulnerabilities? 14:41 < luke-jr> what isn't panning out with it? 14:41 < earnestly> I assume any non-trivial codebase has them 14:41 < earnestly> backporting doesn't scale, it doesn't work as a strategy 14:41 < lightlike> sipa: your zerover Issue seems unnecessary to me, Bitcoin is rightfully listed in the "Emeritii" section as a former member of the club. 14:41 < luke-jr> 0.20.2 is likely more secure than 22.0 (aside from the impending degradation of 0.20 due to Taproot) 14:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 260 seconds] 14:42 < earnestly> You can have a microcosm of developers and users maintaining backporting for a specific bit of software for some time but eventually they burn out and stop 14:42 < sipa> lightlike: OH! 14:42 < luke-jr> earnestly: it extends the lifetime 14:42 < shiza> earnestly: a single active branch difficults planning upgrades 14:42 < luke-jr> earnestly: it gives the newer versions more time to mature, and have their bugs worked out 14:42 < sipa> Certainly backport releases get much less testing than master, and that's unfortunate. But we're also not going to stop creating backports. Sometimes new features actually unintentionally interfere with how the software is used by some. 14:43 < earnestly> shiza: branch management is outside of it 14:43 < sipa> earnestly: i really have no idea what you're talking about 14:43 < earnestly> luke-jr: At the same rate it regresses the bug discovery rate as fewer use it 14:43 < sipa> the project maintainers create backport releases, just along with new releases 14:43 < luke-jr> earnestly: no, not the same rate 14:43 < earnestly> Not all project maintainers do that 14:43 < shiza> earnestly: no, if you only maintain master, distros can't keep up to it, and people is forced to compile compilers 14:44 < luke-jr> earnestly: bugs discovered in 22.0 that predate it will get fixed in backports 14:44 < sipa> earnestly: this channel is about Bitcoin Core development 14:44 < earnestly> shiza: I'm not suggesting that 14:44 < sipa> i'm not talking about anything else 14:44 < luke-jr> ^ 14:44 < earnestly> sipa: I'm only mentioning it to luke-jr, not you 14:44 < luke-jr> earnestly: blaming backports because some people don't do backports, is nonsense 14:44 < earnestly> I didn't blame backports for anything 14:44 < sipa> certainly if nobody used the backport releases at all, we shouldn't make them 14:45 < earnestly> Yeah, that sort of thing is completely up to you 14:45 < sipa> but they are used; not nearly as much as new releases, but they see usage 14:45 < sipa> earnestly: i have no idea what you're trying to argue for, or against, then 14:45 < earnestly> Yeah, backporting and patches are still quite common for the time being 14:45 < luke-jr> On another note, any idea if this is legit C++? namespace x { class y { static void z(); }; } 14:46 < luke-jr> or do you need the full class definition? 14:46 < sipa> luke-jr: legal 14:46 < luke-jr> sipa: ty 14:46 < sipa> you can have a "void x::y::z() { ... }" or "namespace x { void y::z() { ... } }" afterwards to provide the definition 14:46 < earnestly> shiza: (fwiw, I did once make a distro with nothing but HEAD/tip versions of everything from glibc, mpfr, etc. to linux, ffmpeg, etc.) 14:47 < shiza> earnestly: I understood your point (the second time) 14:48 < luke-jr> earnestly: sounds like Gentoo with ACCEPT_KEYWORDS=⁑ :p 14:48 < luke-jr> (minus the Unicode ofc) 14:49 < earnestly> It was a LFS style thing 14:49 < earnestly> (CLFS specifically) 14:49 < fjahr> #23154 seems to be ready for merge 14:49 <@gribble> https://github.com/bitcoin/bitcoin/issues/23154 | doc: add assumeutxo notes by jamesob · Pull Request #23154 · bitcoin/bitcoin · GitHub 14:51 < earnestly> luke-jr: (On a side note, I can't express how nice git (or any vcs) for providing a nice standard way to pull/clone/checkout all these repos) 14:56 < luke-jr> sipa: what if x::y::z is private in the real class? :x 14:59 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te69spdbqy17ml4.ipv6.telus.net] has quit [Remote host closed the connection] 14:59 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te476tdn744fmqj.ipv6.telus.net] has joined #bitcoin-core-dev 14:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 14:59 < sipa> luke-jr: doesn't matter, afaict 15:00 < sipa> private/protected/public is about access to members from other classes 15:01 < sipa> it's not about where the implementation code can live 15:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Remote host closed the connection] 15:02 < satoshi> Bitcoin 0.1.0 : static const int VERSION = 101; Bitcoin 0.3.0 : static const int VERSION = 300; Bitcoin 0.10.0 : return strprintf("%d.%d.%d", nVersion / 1000000, (nVersion / 10000) % 100, (nVersion / 100) % 100); Additional: https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki 15:09 < sipa> satoshi: that change was made in release v0.3.13, in september 2010, by satoshi 15:10 < sipa> commit a790fa46f40d751307f86c37a709eb119768ce5b 15:10 < sipa> Author: s_nakamoto 15:10 < sipa> Date: Thu Sep 30 16:23:07 2010 +0000 15:10 < sipa> don't count or spend payments until they have 1 confirmation, misc cleanup, changed internal version number from 312 to 31300 -- version 0.3.13 15:19 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 15:22 -!- jouf [~Joufflu-Z@ptr-178-51-36-208.dyn.mobistar.be] has joined #bitcoin-core-dev 15:24 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 260 seconds] 15:24 < satoshi> BIP 14: https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki should be followed. Changing from 0.21.x to 22.x is disruptive. 15:25 < sipa> satoshi: you seem to have problems reading 15:25 < sipa> BIP14 is about separating the protocol version from the implementation version 15:27 < sipa> it's not dictating how implementations choose to set their version numbers (in fact, it's the opposite; it's letting them choose it independently from the protocol version number) 15:27 < sipa> anyway, this discussion is going nowhere 15:27 < sipa> at this point i'm going to assume you're a troll 15:29 < satoshi> We talking about Bitcoin Core not the version number of Spesmilo. 15:34 < satoshi> BIP 14 don't say that we should have 22.0, it is however referring to RFC 1945 15:50 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 264 seconds] 15:53 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 15:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 15:56 < satoshi> sipa, can you link me the discussion about https://github.com/bitcoin/bitcoin/commit/8f7b93047581c67f2133cdb8c7845471de66c30f 15:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 268 seconds] 16:05 -!- satoshi [~satoshi@gateway/tor-sasl/satoshi] has quit [Ping timeout: 276 seconds] 16:06 -!- jespada [~jespada@190.7.36.46] has joined #bitcoin-core-dev 16:11 -!- jespada_ [~jespada@190.7.36.46] has joined #bitcoin-core-dev 16:12 -!- jespada [~jespada@190.7.36.46] has quit [Read error: Connection reset by peer] 16:13 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 16:17 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 16:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 16:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 260 seconds] 16:48 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Quit: Leaving...] 16:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:06 -!- jespada_ [~jespada@190.7.36.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:08 -!- jouf [~Joufflu-Z@ptr-178-51-36-208.dyn.mobistar.be] has quit [Ping timeout: 268 seconds] 17:18 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:20 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 17:25 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev 17:26 -!- tralfaz [~davterra@143.198.56.186] has quit [Ping timeout: 260 seconds] 17:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 17:28 -!- sdfgsdfg [sdfgsdfg@user/sdfgsdfg] has quit [Quit: BNC by #bnc4you] 17:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 268 seconds] 18:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 18:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 260 seconds] 18:22 -!- jarthur_ [~jarthur@2603-8080-1540-002d-d06a-c06b-a13c-ec3f.res6.spectrum.com] has joined #bitcoin-core-dev 18:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:24 < bitcoin-git> [bitcoin] prius opened pull request #23420: [MyPy] Correct typing for @subtest decorator (master...master) https://github.com/bitcoin/bitcoin/pull/23420 18:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:24 -!- jarthur [~jarthur@2603-8080-1540-002d-d4d1-6d9f-a6fc-1fe3.res6.spectrum.com] has quit [Ping timeout: 260 seconds] 18:30 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Read error: Connection reset by peer] 18:30 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 18:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:40 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23423: Delete SECURITY.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23423 18:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:41 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23424: Delete .gitignore (master...patch-2) https://github.com/bitcoin/bitcoin/pull/23424 18:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:41 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23425: Delete .cirrus.yml (master...patch-3) https://github.com/bitcoin/bitcoin/pull/23425 18:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:41 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23426: Delete COPYING (master...patch-4) https://github.com/bitcoin/bitcoin/pull/23426 18:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:42 < bitcoin-git> [bitcoin] fanquake closed pull request #23424: Delete .gitignore (master...patch-2) https://github.com/bitcoin/bitcoin/pull/23424 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:42 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23427: Delete Makefile.am (master...patch-5) https://github.com/bitcoin/bitcoin/pull/23427 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:42 < bitcoin-git> [bitcoin] fanquake closed pull request #23425: Delete .cirrus.yml (master...patch-3) https://github.com/bitcoin/bitcoin/pull/23425 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:42 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23428: Delete bug_report.md (master...patch-6) https://github.com/bitcoin/bitcoin/pull/23428 18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:43 < bitcoin-git> [bitcoin] fanquake closed pull request #23423: Delete SECURITY.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23423 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:43 < bitcoin-git> [bitcoin] fanquake closed pull request #23427: Delete Makefile.am (master...patch-5) https://github.com/bitcoin/bitcoin/pull/23427 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:43 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23429: Update README.md (master...patch-7) https://github.com/bitcoin/bitcoin/pull/23429 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:43 < bitcoin-git> [bitcoin] nnihsotas opened pull request #23430: Delete .editorconfig (master...patch-8) https://github.com/bitcoin/bitcoin/pull/23430 18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:44 < bitcoin-git> [bitcoin] fanquake closed pull request #23426: Delete COPYING (master...patch-4) https://github.com/bitcoin/bitcoin/pull/23426 18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:44 < bitcoin-git> [bitcoin] fanquake closed pull request #23428: Delete bug_report.md (master...patch-6) https://github.com/bitcoin/bitcoin/pull/23428 18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:44 < bitcoin-git> [bitcoin] fanquake closed pull request #23429: Update README.md (master...patch-7) https://github.com/bitcoin/bitcoin/pull/23429 18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:45 < bitcoin-git> [bitcoin] fanquake closed pull request #23430: Delete .editorconfig (master...patch-8) https://github.com/bitcoin/bitcoin/pull/23430 18:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:48 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 18:50 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 18:59 -!- jarthur_ is now known as jarthur 19:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 19:12 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 19:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 268 seconds] 19:18 -!- Guest64 [~Guest64@45.76.31.184] has joined #bitcoin-core-dev 19:19 -!- Guest64 [~Guest64@45.76.31.184] has quit [Client Quit] 19:39 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 260 seconds] 19:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:40 < bitcoin-git> [bitcoin] rooprob closed pull request #23277: wallet: Add size check on meta.key_origin.path (master...bugfix/21605-segfault-in-legacyscriptpubkeyman) https://github.com/bitcoin/bitcoin/pull/23277 19:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:43 -!- sdfgsdfg [sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 20:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 20:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 268 seconds] 20:23 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 20:31 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Changing host] 20:31 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-dev 20:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 276 seconds] 20:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 20:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 268 seconds] 21:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev 21:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 268 seconds] 22:17 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 22:22 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 268 seconds] 23:18 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 23:23 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 23:24 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 23:26 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:27 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 23:27 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 260 seconds] 23:36 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!] 23:59 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev 23:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev --- Log closed Wed Nov 03 00:00:22 2021