--- Log opened Fri Nov 12 00:00:30 2021
00:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
00:05 -!- seaona [~seaona@93.176.136.171] has joined #bitcoin-core-dev
00:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 246 seconds]
00:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
00:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 250 seconds]
00:14 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev
00:24 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
00:38 -!- rockhouse [~rockhouse@user/rockhouse] has joined #bitcoin-core-dev
00:41 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
00:45 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds]
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/c1fb30633b6d...1ff265a20c36
00:49 < bitcoin-git> bitcoin/master a749fa5 John Newbery: [addrman] Remove AddrMan friends
00:49 < bitcoin-git> bitcoin/master 7784a9a John Newbery: [addrman] [tests] Remove deterministic argument and member from AddrManTes...
00:49 < bitcoin-git> bitcoin/master d02098d John Newbery: [addrman] [tests] Tidy up unused arguments in addrman test functions
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23477: addrman: tidy up unit tests (master...2021-11-addrman-tidyups) https://github.com/bitcoin/bitcoin/pull/23477
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:50 -!- b10c [uid500648@ilkley.irccloud.com] has joined #bitcoin-core-dev
00:56 -!- XCUSEM3 [~XCUSEM3@92.119.18.165] has joined #bitcoin-core-dev
00:56 -!- XCUSEM3 [~XCUSEM3@92.119.18.165] has left #bitcoin-core-dev []
00:58 < laanwj> ^ seems like a bit of a rushed merge? i think jnewbery should have had time to respond to thestack's nits
00:59 < laanwj> even if the response is 'i prefer not to do this'
01:00 -!- dermoth [~dermoth@dsl-10-130-67.b2b2c.ca] has quit [Ping timeout: 256 seconds]
01:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has joined #bitcoin-core-dev
01:11 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
01:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:280b:ec08:a2a8:566c] has quit [Ping timeout: 245 seconds]
01:12 -!- dermoth [~dermoth@dsl-153-127.b2b2c.ca] has joined #bitcoin-core-dev
01:14 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
01:15 -!- realies [~realies@user/realies] has quit [Ping timeout: 240 seconds]
01:16 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 264 seconds]
01:18 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
01:18 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 246 seconds]
01:23 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
01:32 -!- An0rak [An0rak@user/an0rak] has quit [Ping timeout: 256 seconds]
01:32 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev
01:37 -!- An0rak [An0rak@user/an0rak] has joined #bitcoin-core-dev
01:43 < jnewbery> laanwj: I've responded to the review comments
01:46 -!- realies [~realies@user/realies] has quit [Quit: Ping timeout (120 seconds)]
01:46 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
01:52 -!- realies [~realies@user/realies] has quit [Quit: Ping timeout (120 seconds)]
01:54 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
02:00 < b10c> roasbeef: based on https://www.dsn.kastel.kit.edu/bitcoin/ data on publicly reachable nodes: 12.50% pruned SegWit nodes
02:00 < b10c> 76.32% are non-pruned SegWit (i.e. have NETWORK, NETWORK_LIMITED, and WITNESS set)
02:01 < b10c> https://gist.github.com/0xB10C/c9d715500665df46862e35b0e2b4209d
02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23491: scripted-diff: Move minisketchwrapper to src/node (master...2111-libNode) https://github.com/bitcoin/bitcoin/pull/23491
02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:03 -!- z0d [~z0d@c-73-238-143-196.hsd1.ct.comcast.net] has quit [Quit: ZZZzzz…]
02:03 -!- kexkey_ [~kexkey@static-198-54-132-149.cust.tzulo.com] has quit [Ping timeout: 256 seconds]
02:05 -!- kexkey [~kexkey@static-198-54-132-165.cust.tzulo.com] has joined #bitcoin-core-dev
02:15 -!- seaona [~seaona@93.176.136.171] has quit [Ping timeout: 256 seconds]
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23492: test: tidy up addrman unit tests (master...2111-testAddrm) https://github.com/bitcoin/bitcoin/pull/23492
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:51 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23493: Use c++17 in clang-format (master...2111-srcFormat17) https://github.com/bitcoin/bitcoin/pull/23493
02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:57 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev
02:58 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.2]
02:58 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has quit [Client Quit]
02:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
03:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Remote host closed the connection]
03:10 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
03:11 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Ping timeout: 250 seconds]
03:18 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
03:20 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:28 -!- jarthur [~jarthur@2603-8080-1540-002d-b1c5-5665-681a-caa6.res6.spectrum.com] has quit [Quit: jarthur]
03:29 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection]
03:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
03:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:32 < bitcoin-git> [bitcoin] fanquake opened pull request #23494: build: minor boost tidyups (master...boost_cleanups) https://github.com/bitcoin/bitcoin/pull/23494
03:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
03:40 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev
03:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
03:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 250 seconds]
03:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
03:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
03:55 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
04:00 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds]
04:04 < laanwj> jnewbery: thanks
04:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
04:10 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- awesome_doge [~awesome-d@2001:470:69fc:105::1:252c] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- cotsuka [~cotsuka@user/cotsuka] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- Enki[m] [~enkimatri@2001:470:69fc:105::382c] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- Murch[m] [~murchmatr@2001:470:69fc:105::2aa8] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- objdefined[m] [~objdefine@2001:470:69fc:105::1:2bb1] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM]
04:10 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has quit [Quit: Bridge terminating on SIGTERM]
04:26 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev
04:29 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-dev
04:29 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-core-dev
04:29 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-dev
04:29 -!- Enki[m] [~enkimatri@2001:470:69fc:105::382c] has joined #bitcoin-core-dev
04:29 -!- Murch[m] [~murchmatr@2001:470:69fc:105::2aa8] has joined #bitcoin-core-dev
04:29 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has joined #bitcoin-core-dev
04:29 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has joined #bitcoin-core-dev
04:29 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev
04:29 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has joined #bitcoin-core-dev
04:29 -!- objdefined[m] [~objdefine@2001:470:69fc:105::1:2bb1] has joined #bitcoin-core-dev
04:29 -!- awesome_doge [~awesome-d@2001:470:69fc:105::1:252c] has joined #bitcoin-core-dev
04:29 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has joined #bitcoin-core-dev
04:29 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-core-dev
04:46 -!- connecta [~connecta@2804:14c:cc92:814c:85a8:8939:2219:7a8b] has joined #bitcoin-core-dev
04:48 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev
04:50 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has quit [Client Quit]
04:50 -!- Murch[m] [~murchmatr@2001:470:69fc:105::2aa8] has quit [Quit: Client limit exceeded: 20000]
04:50 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has quit [Quit: Client limit exceeded: 20000]
04:51 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Client limit exceeded: 20000]
04:51 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Client limit exceeded: 20000]
04:51 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Quit: Client limit exceeded: 20000]
04:51 -!- cotsuka [~cotsuka@user/cotsuka] has quit [Quit: Client limit exceeded: 20000]
04:51 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has quit [Quit: Client limit exceeded: 20000]
04:51 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has quit [Quit: Client limit exceeded: 20000]
04:52 -!- Enki[m] [~enkimatri@2001:470:69fc:105::382c] has quit [Quit: Client limit exceeded: 20000]
04:53 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Connection closed]
05:07 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
05:14 -!- connecta [~connecta@2804:14c:cc92:814c:85a8:8939:2219:7a8b] has quit [Ping timeout: 256 seconds]
05:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:48 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:49 -!- fulldecent [~textual@wikipedia/fulldecent] has joined #bitcoin-core-dev
06:02 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Remote host closed the connection]
06:05 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
06:05 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Read error: Connection reset by peer]
06:08 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev
06:10 < sipa> jeremyrubin: getdata for transactions only works for recently announced ones
06:10 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev
06:11 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-dev
06:11 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-core-dev
06:11 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-dev
06:11 -!- Murch[m] [~murchmatr@2001:470:69fc:105::2aa8] has joined #bitcoin-core-dev
06:11 -!- Enki[m] [~enkimatri@2001:470:69fc:105::382c] has joined #bitcoin-core-dev
06:11 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has joined #bitcoin-core-dev
06:11 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has joined #bitcoin-core-dev
06:11 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev
06:28 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
06:35 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:36 < MarcoFalke> Assuming I have a minisketch with capacity 1, two entries. And another one with no entries. Does Decode(1) on the difference return false or true?
06:36 < MarcoFalke> I'd expect false, but it does return true in my fuzz test 
06:38 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
06:38 -!- Guyver2_ is now known as Guyver2
06:40 < sipa> MarcoFalke: is one of the entries 0?
06:40 < MarcoFalke> The entries are 4193909242 and 1
06:41 < MarcoFalke> the large one is f9f9f9fa in hex
06:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Remote host closed the connection]
06:41 < sipa> there is always a probability that decoding succeeds even if the capacity is exceeded
06:41 < sipa> the fuzzer may have found an input for which that is the case
06:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
06:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
06:54 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Read error: Connection reset by peer]
06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:54 < bitcoin-git> [bitcoin] hebasto opened pull request #23495: build: Bump Fonconfig version up to 2.12.6 (master...211112-fc) https://github.com/bitcoin/bitcoin/pull/23495
06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
07:01 < MarcoFalke> ok, thx
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23496: fuzz: Add minisketch fuzz test (master...2111-fuzzMiniSketch) https://github.com/bitcoin/bitcoin/pull/23496
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
07:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
07:04 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has quit [Ping timeout: 245 seconds]
07:05 -!- V01101011 [~V01101011@177-86-157-82.netecom.net.br] has joined #bitcoin-core-dev
07:08 -!- V01101011 [~V01101011@177-86-157-82.netecom.net.br] has quit [Client Quit]
07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ff265a20c36...c9dd5c8d6e59
07:08 < bitcoin-git> bitcoin/master fab9264 MarcoFalke: test: Remove unused CDataStream copy
07:08 < bitcoin-git> bitcoin/master 0000eda MarcoFalke: style: Use 4 spaces for indentation, not 5
07:08 < bitcoin-git> bitcoin/master c9dd5c8 MarcoFalke: Merge bitcoin/bitcoin#23492: test: tidy up addrman unit tests
07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #23492: test: tidy up addrman unit tests (master...2111-testAddrm) https://github.com/bitcoin/bitcoin/pull/23492
07:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:19 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds]
07:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
07:20 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
07:20 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has joined #bitcoin-core-dev
07:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
07:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
07:35 -!- kouloumos [~kouloumos@athedsl-250775.home.otenet.gr] has joined #bitcoin-core-dev
07:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
07:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
07:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
07:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
07:49 < jnewbery> sipa: getrawtransaction will succeed if the block hash is passed (and the block is available on disk)
07:50 < sipa> jnewbery: we're talking about P2P
07:50 < sipa> (i thought?)
07:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
07:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
07:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
07:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
08:08 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
08:12 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
08:13 < jnewbery> I think jeremyrubin is proposing to add a new p2p message that requests a tx from a given block
08:14 < jnewbery> > < jeremyrubin> E.g. oh you say you're a full node? Give me the nth txn in block at height x
08:14 < sipa> i didn't interpret that as adding a new message, but sure, no technical reason why that couldn't be done
08:15 < sipa> generating merkle proofs for that would be kind of expensive though
08:15 < sipa> (similar to the BIP37 dos potential)
08:15 < jnewbery> right, I'm not saying it's a good idea :)
08:22 -!- fulldecent [~textual@wikipedia/fulldecent] has quit [Quit: Textual IRC Client: www.textualapp.com]
08:22 < jeremyrubin> You can't get dos'd through this because it's only for outbound peers from the prover, and we only really need to do a challenge every now and again. You could of course just send the whole block but that seems a waste of bandwidth
08:23 < jeremyrubin> You can limit how often you're willing to re verify
08:27 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Remote host closed the connection]
08:27 < luke-jr> why a merkle proof?
08:27 < luke-jr> just send the txid?
08:27 < luke-jr> or heck, it could just be a random 16 bytes from the block (though that forces a specific serialisation so maybe worse)
08:28 < luke-jr> but *any* proof is going to be MITM-able, and why is there a desire to do so anyway?
08:29 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
08:29 < sipa> you could do better actually
08:29 < sipa> send a challenge
08:29 < sipa> and a txid
08:30 < sipa> and have them respond with hmac(key=challenge, msg=tx)
08:31 < sipa> (still unconvinced this is desirable at all, just pointing out that one can prove to have a tx without building a merkle proof for it, if the challenger already has the tx as well)
08:34 < jeremyrubin> The verifier runs a pruned node 
08:35 < jeremyrubin> They have headers but not the tx, that's why the challenge is the nth transaction at some block
08:36 < sipa> ah, right
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:37 < bitcoin-git> [bitcoin] ryanofsky opened pull request #23497: Add `src/node/` and `src/wallet/` code to `node::` and `wallet::` namespaces (master...pr/names) https://github.com/bitcoin/bitcoin/pull/23497
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:37 < jeremyrubin> W.r.t. it being MITM-able, the challenge is forward able sure. But only to a dishonest archival node. 
08:38 < jeremyrubin> You can also do a fair coin flip type thing to select the block/txn so that it guarantees there's no possibility of forwarding the request to any honest node even w rate limit 
08:38 < jeremyrubin> But tbh this is too in the weeds. 
08:39 < jeremyrubin> The main question is is it desirable to ensure that every pruned node has a connection to at least one archival node?
08:40 < sipa> i'm not sure that it is
08:40 < sipa> (also not sure that it isn't)
08:42 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
08:57 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
08:59 < jeremyrubin> Is it desirable to ensure that a member of the graph of archival nodes willing to serve blocks  is easily discoverable for new peers?
09:01 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
09:02 < sipa> nodes rumour peer addresses regardless of whether they're node_network or not
09:02 < sipa> so unless there is some reason to believe there is a clustering effect that we want to counteract, i'm not sure that's a useful criterion
09:04 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 256 seconds]
09:07 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
09:12 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 264 seconds]
09:13 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
09:19 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 264 seconds]
09:21 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
09:25 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Read error: Connection reset by peer]
09:28 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
09:29 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Client Quit]
09:31 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 260 seconds]
09:31 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
09:32 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev
09:34 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:39 -!- Guest78 [~Guest78@14.207.200.44] has joined #bitcoin-core-dev
09:39 < Guest78> าีั
09:39 < Guest78> kuy
09:40 -!- Guest78 [~Guest78@14.207.200.44] has quit [Client Quit]
09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:43 < bitcoin-git> [bitcoin] theStack opened pull request #23498: test: remove unnecessary block rehashing prior to solving (master...202111-test-remove_superflous_block_rehashs_before_solving) https://github.com/bitcoin/bitcoin/pull/23498
09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:50 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
10:03 -!- infernix [nix@spirit.infernix.net] has quit [Quit: ZNC - http://znc.sourceforge.net]
10:13 -!- aconit [~aconit@213.55.244.162] has joined #bitcoin-core-dev
10:17 < luke-jr> jeremyrubin: the pruned verifier just asks his own peer to verify it for him
10:29 -!- b10c [uid500648@ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
10:34 -!- aconit [~aconit@213.55.244.162] has quit [Quit: Client closed]
10:34 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
10:58 < jeremyrubin> As noted above making the challenge the result of a fair coin flip blocks that forwardability issue 
11:04 -!- copumpkin [~woohoo@user/copumpkin] has quit [Remote host closed the connection]
11:04 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
11:11 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 245 seconds]
11:15 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
11:18 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
11:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Remote host closed the connection]
11:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
11:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
11:37 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
11:52 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
11:54 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
11:55 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
11:56 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection]
11:58 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
11:59 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
12:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
12:04 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
12:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
12:13 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has quit [Ping timeout: 264 seconds]
12:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 265 seconds]
12:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
12:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
12:25 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev
12:27 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
12:27 -!- copumpkin [~woohoo@user/copumpkin] has quit [Client Quit]
12:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
12:30 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev
12:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
12:38 -!- davterra [~davterra@143.198.56.186] has quit [Quit: Leaving]
12:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:42 < bitcoin-git> [bitcoin] ryanofsky opened pull request #23499: multiprocess: Add interfaces::Node::broadCastTransaction method (master...pr/ipc-broadcast) https://github.com/bitcoin/bitcoin/pull/23499
12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:44 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
12:44 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
12:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
12:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
12:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
13:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 245 seconds]
13:08 -!- Guest88 [~Guest88@2001:1890:128c:440:51ee::25c] has joined #bitcoin-core-dev
13:09 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:13 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
13:13 -!- Guyver2_ is now known as Guyver2
13:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
13:20 -!- Guest32 [~Guest32@dynamic-002-211-085-157.2.211.pool.telefonica.de] has joined #bitcoin-core-dev
13:21 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
13:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
13:30 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
13:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:31 < bitcoin-git> [gui] achow101 opened pull request #469: gui: Load Base64 PSBT string from file (master...b64-psbt-gui) https://github.com/bitcoin-core/gui/pull/469
13:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:35 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 264 seconds]
13:37 -!- karonto [~karonto@dynamic-002-211-085-157.2.211.pool.telefonica.de] has joined #bitcoin-core-dev
13:41 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
13:44 -!- Guest32 [~Guest32@dynamic-002-211-085-157.2.211.pool.telefonica.de] has quit [Quit: Client closed]
13:45 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds]
13:47 < achow101> anyone doing taproot spends notice that sometimes taproot spends end up severely under the feerate target?
13:48 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
13:49 < sipa> achow101: hmm, how?
13:50 < achow101> sipa: seems like with some(?) script path spends it ends up way under the target feerate
13:50 < achow101> I think it's that the estimation occurs on the key path, but then script path is actually used
13:50 < achow101> just noticed this while trying to construct a script path spend
13:51 < achow101> also trying to write a test, and the size esimation seems to be ending up 1 byte short too (key path spend fails, with estimated vsize 1 vbyte less than real vsize)
13:54 < sipa> ah yes, for script path spend i can imagine it's wildly off
13:56 < achow101> why would it be?
13:56 < achow101> if the actual signer uses the script path, shouldn't the dummy signer figure that out as well?
13:56 < sipa> hmm
13:57 < achow101> I think the dummy signer thinks we have the privkey for the internal key
13:57 < achow101> but for this particular construction, we don't
13:58 < sipa> it's inherently difficult, because the role constructing the transaction may not know what path the signers will be using
13:58 -!- z0d [~z0d@c-73-238-143-196.hsd1.ct.comcast.net] has joined #bitcoin-core-dev
14:00 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds]
14:02 < achow101> sure, but in the single signer context, it shouldn't be
14:03 < sipa> true
14:03 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
14:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
14:31 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:33 -!- fulldecent [~textual@wikipedia/fulldecent] has joined #bitcoin-core-dev
14:33 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
14:38 -!- kouloumos [~kouloumos@athedsl-250775.home.otenet.gr] has quit [Quit: Connection closed]
14:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
14:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
14:51 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
14:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
14:55 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
14:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
14:59 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
15:03 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds]
15:12 -!- javi404 [~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net] has quit [Ping timeout: 245 seconds]
15:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:13 < bitcoin-git> [bitcoin] fanquake pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/c9dd5c8d6e59...5cc083cd46ad
15:13 < bitcoin-git> bitcoin/master a874637 fanquake: build: AX_CHECK_LINK_FLAG serial 6
15:13 < bitcoin-git> bitcoin/master 5e6bc43 fanquake: build: cleanup AX_CHECK_LINK_FLAG() usage
15:13 < bitcoin-git> bitcoin/master b3dd6c1 fanquake: build: AX_CHECK_COMPILE_FLAG() serial 6
15:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:13 < bitcoin-git> [bitcoin] fanquake merged pull request #23473: build: boring autotools cleanup (master...boring_autotools_cleanup) https://github.com/bitcoin/bitcoin/pull/23473
15:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:16 -!- fulldecent [~textual@wikipedia/fulldecent] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
15:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
15:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
15:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
15:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
15:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
15:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
15:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:48 < bitcoin-git> [bitcoin] rex4539 opened pull request #23500: depends, wallet: fix typos (master...typos) https://github.com/bitcoin/bitcoin/pull/23500
15:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:01 < bitcoin-git> [bitcoin] theStack opened pull request #23501: test: various feature_nulldummy.py improvements (master...202111-test-nulldummy_improvements) https://github.com/bitcoin/bitcoin/pull/23501
16:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
16:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:05 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 265 seconds]
16:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
16:09 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
16:15 -!- Guest88 [~Guest88@2001:1890:128c:440:51ee::25c] has quit [Ping timeout: 256 seconds]
16:19 -!- javi404 [~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev
16:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
16:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:36 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Read error: Connection reset by peer]
16:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
16:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
16:47 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Read error: Connection reset by peer]
16:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:49 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 260 seconds]
16:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
16:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
16:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
17:10 < achow101> sipa: I suppose there isn't some way to indicate in a tr() descriptor that the internal key is bogus?
17:16 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
17:20 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 260 seconds]
17:25 < sipa> achow101: no, but there probably should be (both a standardized way of doing that, and a way to do that in descriptors)
17:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
17:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
17:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
17:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
17:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
17:44 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
17:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:58 < bitcoin-git> [bitcoin] achow101 opened pull request #23502: wallet: Avoid underpaying transaction fees when signing taproot spends (master...tr-low-fee-est) https://github.com/bitcoin/bitcoin/pull/23502
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:05 < roasbeef> achow101: so what's the logic behind that? if a node can serve all blocks (node_network), then it can also serve the last 288 (node_limited), so why set them both? seems wrong imo 
18:05 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
18:06 < roasbeef> given node network subsumes node limited 
18:08 < roasbeef> since "I can serve all blocks" also entails that you can serve the last 288, so it's a redundant bit/signal 
18:08 < achow101> roasbeef: not sure. https://github.com/bitcoin/bitcoin/pull/10387#discussion_r142410638 sounds like there was probably some mailing list discussion about that
18:09 < roasbeef> heh, interesting they argued for the opposite: always set it since one implies the other 
18:10 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 268 seconds]
18:10 < roasbeef> well led to a bug fix in btwallet/lnd, so that's nice, but don't fault the OP of the code given that was a safe assumption (that they were exclusive) 
18:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
18:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
18:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
18:25 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Quit: Leaving...]
18:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
18:38 -!- jesseposner [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:44 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
18:49 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 268 seconds]
18:54 -!- fulldecent [~textual@wikipedia/fulldecent] has joined #bitcoin-core-dev
18:55 -!- karonto [~karonto@dynamic-002-211-085-157.2.211.pool.telefonica.de] has quit [Ping timeout: 256 seconds]
19:05 < sipa> roasbeef: nodes OR service flags together when rumoured addresses conflict
19:06 < sipa> i had forgotten myself that NODE_LIMITED didn't imply pruning, it only means being able to serve the last 288
19:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
19:08 < sipa> but this ORing logic kind of means you have to see service flags as independent capabilities, and you can't do things easily like interpreting a group of 2 bits as a 4-valued choice
19:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
19:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
19:13 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te7f3bvp32sv6xr.ipv6.telus.net] has quit [Remote host closed the connection]
19:13 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te49851s1p2rehu.ipv6.telus.net] has joined #bitcoin-core-dev
19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
19:18 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te49851s1p2rehu.ipv6.telus.net] has quit [Ping timeout: 268 seconds]
19:21 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has quit [Remote host closed the connection]
19:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
19:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
19:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
19:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
19:32 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te49851s1p2rehu.ipv6.telus.net] has joined #bitcoin-core-dev
19:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
19:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
19:35 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
19:35 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Client Quit]
19:36 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
19:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
19:46 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has joined #bitcoin-core-dev
19:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
19:59 -!- fulldecent [~textual@wikipedia/fulldecent] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
20:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
20:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
20:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
20:58 -!- jarthur [~jarthur@2603-8080-1540-002d-c9b9-834f-44a0-976a.res6.spectrum.com] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
21:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
21:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
21:13 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 256 seconds]
21:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
21:19 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev
21:23 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 260 seconds]
21:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
21:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
21:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
21:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
21:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
21:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
21:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
21:48 -!- martinus [~martinus@2001:4bc9:823:e7a0:ce4:a0d6:761e:2] has quit [Remote host closed the connection]
21:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
21:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
22:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
22:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
22:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
22:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
22:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
22:31 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
22:32 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev
22:36 -!- seaner [~seanicide@bras-base-clwdon2201w-grc-48-174-89-150-139.dsl.bell.ca] has quit [Remote host closed the connection]
22:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
22:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
22:43 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has quit [Remote host closed the connection]
22:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
22:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
22:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
22:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 268 seconds]
23:05 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 256 seconds]
23:13 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev
23:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
23:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 245 seconds]
23:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
23:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 265 seconds]
23:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
23:53 -!- kallewoof [~quassel@user/kallewoof] has quit [Ping timeout: 268 seconds]
23:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has quit [Ping timeout: 264 seconds]
23:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:b932:5106:76df:c8dd] has joined #bitcoin-core-dev
--- Log closed Sat Nov 13 00:00:31 2021