--- Log opened Thu Dec 02 00:00:49 2021 00:05 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 00:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:10 < bitcoin-git> [bitcoin] meshcollider opened pull request #23647: Split rpcwallet into multiple smaller parts (master...202111_split_walletrpc_total) https://github.com/bitcoin/bitcoin/pull/23647 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:10 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has joined #bitcoin-core-dev 00:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 00:15 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has quit [Ping timeout: 252 seconds] 00:15 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 00:16 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has joined #bitcoin-core-dev 00:16 -!- Guest99 [~Guest99@2a03:e581:a::199] has joined #bitcoin-core-dev 00:17 -!- Guest99 [~Guest99@2a03:e581:a::199] has quit [Client Quit] 00:19 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 240 seconds] 00:20 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has quit [Ping timeout: 252 seconds] 00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af1067c4b732...282cc0cda7a2 00:26 < bitcoin-git> bitcoin/master fa7da22 MarcoFalke: refactor: Fix implicit-signed-integer-truncation in cuckoocache.h 00:26 < bitcoin-git> bitcoin/master 282cc0c fanquake: Merge bitcoin/bitcoin#23626: refactor: Fix implicit-signed-integer-truncat... 00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:26 < bitcoin-git> [bitcoin] fanquake merged pull request #23626: refactor: Fix implicit-signed-integer-truncation in cuckoocache.h (master...2111-int) https://github.com/bitcoin/bitcoin/pull/23626 00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:29 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6qzgmzwv44b01.ipv6.telus.net] has joined #bitcoin-core-dev 00:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 00:31 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3yhbwe34iov8v.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 00:39 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 00:40 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 00:41 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6qzgmzwv44b01.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 00:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te64zw4dbf0s1bw.ipv6.telus.net] has joined #bitcoin-core-dev 00:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te64zw4dbf0s1bw.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 00:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 00:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:01 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 01:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 01:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te44yfdsmnl435o.ipv6.telus.net] has joined #bitcoin-core-dev 01:06 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 01:07 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit] 01:10 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 01:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te44yfdsmnl435o.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 01:12 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 01:18 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 01:21 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has joined #bitcoin-core-dev 01:26 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has quit [Ping timeout: 268 seconds] 01:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te44yfdsmnl435o.ipv6.telus.net] has joined #bitcoin-core-dev 01:30 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 01:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 01:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 01:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:35 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/282cc0cda7a2...6acda4b00b3f 01:35 < bitcoin-git> bitcoin/master ffd0928 James O'Beirne: rpc: various fixups for dumptxoutset 01:35 < bitcoin-git> bitcoin/master 6acda4b W. J. van der Laan: Merge bitcoin/bitcoin#23155: rpc: various fixups for dumptxoutset 01:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:36 < bitcoin-git> [bitcoin] laanwj merged pull request #23155: rpc: various fixups for dumptxoutset (master...2021-10-au-rpc-fixes) https://github.com/bitcoin/bitcoin/pull/23155 01:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:36 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 01:41 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 01:45 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:45 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 01:46 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit] 01:46 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 01:47 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 01:47 -!- Guyver2_ is now known as Guyver2 01:49 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 01:51 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 01:53 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 02:03 -!- kexkey [~kexkey@static-198-54-132-84.cust.tzulo.com] has quit [Ping timeout: 256 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-148.cust.tzulo.com] has joined #bitcoin-core-dev 02:20 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 02:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 02:23 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 02:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 02:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te44yfdsmnl435o.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 02:32 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 02:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te71wlbk6rixqtv.ipv6.telus.net] has joined #bitcoin-core-dev 02:40 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te71wlbk6rixqtv.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 02:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4bqz4dh3xweut.ipv6.telus.net] has joined #bitcoin-core-dev 02:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4bqz4dh3xweut.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 02:58 -!- dougefish [~dougefish@5.29.49.79] has quit [Ping timeout: 252 seconds] 02:58 -!- Guest70 [~Guest70@2a02:908:2549:2100:bd68:5288:eb1e:5874] has joined #bitcoin-core-dev 02:58 -!- Guest70 [~Guest70@2a02:908:2549:2100:bd68:5288:eb1e:5874] has quit [Client Quit] 03:00 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Ping timeout: 256 seconds] 03:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te5tlsv9obx9jx3.ipv6.telus.net] has joined #bitcoin-core-dev 03:08 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev 03:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te5tlsv9obx9jx3.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 03:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 03:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Remote host closed the connection] 03:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:19 < bitcoin-git> [bitcoin] dougEfresh opened pull request #23648: test: Add functional test for -maxuploadtarget with byte unit '1M' (master...test-byteunit-maxuploadtarget) https://github.com/bitcoin/bitcoin/pull/23648 03:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:20 < bitcoin-git> [bitcoin] dougEfresh closed pull request #23584: test: Adding functional test for -maxuploadtarget with byte unit 'M' (master...maxuploadtarget-functional-byteunit) https://github.com/bitcoin/bitcoin/pull/23584 03:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:25 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te5tlsv9obx9jx3.ipv6.telus.net] has joined #bitcoin-core-dev 03:29 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 03:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 03:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 03:43 -!- earnest [~earnest@user/earnestly] has joined #bitcoin-core-dev 04:00 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:03 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 04:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:06 < bitcoin-git> [bitcoin] glozow opened pull request #23649: circular dependency followups (master...22677-followups) https://github.com/bitcoin/bitcoin/pull/23649 04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 04:15 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 252 seconds] 04:16 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 04:21 -!- mikehu44 [~quassel@206.189.41.250] has quit [Ping timeout: 256 seconds] 04:21 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 04:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te5tlsv9obx9jx3.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 04:28 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-dev 04:34 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:38:ddc2:9fe7:8093] has joined #bitcoin-core-dev 04:36 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te7lxjz4rmiti5c.ipv6.telus.net] has joined #bitcoin-core-dev 04:37 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te5yydea8bnfruv.ipv6.telus.net] has joined #bitcoin-core-dev 04:38 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:38:ddc2:9fe7:8093] has quit [Ping timeout: 252 seconds] 04:38 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 04:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 04:40 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te7lxjz4rmiti5c.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 04:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 04:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te49gei1zrqoigq.ipv6.telus.net] has joined #bitcoin-core-dev 04:47 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te5yydea8bnfruv.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 04:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te49gei1zrqoigq.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 04:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6kii6jnmgvsac.ipv6.telus.net] has joined #bitcoin-core-dev 05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6acda4b00b3f...0bd7ca9a036e 05:00 < bitcoin-git> bitcoin/master fab0d99 MarcoFalke: style: Remove whitespace 05:00 < bitcoin-git> bitcoin/master 3333070 MarcoFalke: refactor: Call type-solver earlier in decodescript 05:00 < bitcoin-git> bitcoin/master 0bd7ca9 MarcoFalke: Merge bitcoin/bitcoin#23642: refactor: Call type-solver earlier in decodes... 05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #23642: refactor: Call type-solver earlier in decodescript (master...2112-rpcRefDec) https://github.com/bitcoin/bitcoin/pull/23642 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:03 -!- flooded is now known as _flood 05:08 -!- Zayn [muhammadir@2607:5300:60:21b::1] has joined #bitcoin-core-dev 05:09 -!- Zayn [muhammadir@2607:5300:60:21b::1] has left #bitcoin-core-dev [] 05:12 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 05:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 05:31 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has quit [Remote host closed the connection] 05:31 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has joined #bitcoin-core-dev 05:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 05:35 < laanwj> dongcarl: it depends on translatability of the error message; if it's general enough: say, someone with basic knowledge of bitcoin internals can understand it, it should be translated 05:37 < laanwj> dongcarl: on the other hand if it's a message about some internal failure scenario then it shouldn't be, it would just confuse and demotivate translators and result in sub-par error messages 05:37 < laanwj> but that's the reason to have the *option* of passing a translation string in 05:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:38 < bitcoin-git> [bitcoin] KambizAsadzadeh opened pull request #23650: Added some safety features from permissions. (master...master) https://github.com/bitcoin/bitcoin/pull/23650 05:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:40 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has joined #bitcoin-core-dev 05:49 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has quit [Ping timeout: 252 seconds] 05:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:49 < bitcoin-git> [gui] KambizAsadzadeh opened pull request #496: Added some safety features from permissions. (master...master) https://github.com/bitcoin-core/gui/pull/496 05:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6kii6jnmgvsac.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 06:02 < laanwj> i just realized we don't mention in the code comments (nor dev docs of the structures) anywhere that ATMP stands for AcceptToMemoryPool 06:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te496146ry4q1iy.ipv6.telus.net] has joined #bitcoin-core-dev 06:06 -!- sav_ [~savio@177.12.48.155] has joined #bitcoin-core-dev 06:06 < sipa> ow 06:06 < ryanofsky> Could I get #23497 added to https://github.com/bitcoin/bitcoin/projects/8 now that #21206 is off? 06:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/23497 | Add `src/node/` and `src/wallet/` code to `node::` and `wallet::` namespaces by ryanofsky · Pull Request #23497 · bitcoin/bitcoin · GitHub 06:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/21206 | refactor: Make CWalletTx sync state type-safe by ryanofsky · Pull Request #21206 · bitcoin/bitcoin · GitHub 06:13 < laanwj> ryanofsky: added 06:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te496146ry4q1iy.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 06:17 -!- littlesh [~Username@bras-base-clwdon2201w-grc-48-174-89-150-139.dsl.bell.ca] has joined #bitcoin-core-dev 06:18 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:41d0:e871:c74:428] has joined #bitcoin-core-dev 06:19 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 06:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 06:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0bd7ca9a036e...26a1147ce560 06:28 < bitcoin-git> bitcoin/master fa815f8 MarcoFalke: Replace addrman.h include with forward decl in net.h 06:28 < bitcoin-git> bitcoin/master fa551b3 MarcoFalke: Remove GetAdjustedTime from init.cpp 06:28 < bitcoin-git> bitcoin/master 26a1147 MarcoFalke: Merge bitcoin/bitcoin#23636: Remove GetAdjustedTime from init.cpp 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #23650: Added some safety features from permissions. (master...master) https://github.com/bitcoin/bitcoin/pull/23650 06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #23636: Remove GetAdjustedTime from init.cpp (master...2111-noTimeInit) https://github.com/bitcoin/bitcoin/pull/23636 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:31 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 06:32 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection] 06:33 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 06:34 -!- dougefish [~dougefish@5.29.49.79] has joined #bitcoin-core-dev 06:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 06:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 06:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6vjoa2yswzzsa.ipv6.telus.net] has joined #bitcoin-core-dev 06:40 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te3xpnfhzs6f6ie.ipv6.telus.net] has joined #bitcoin-core-dev 06:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 06:44 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6vjoa2yswzzsa.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 06:44 -!- mudsip [~mudsip@user/mudsip] has quit [] 06:48 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has quit [Remote host closed the connection] 06:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 06:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 07:04 -!- gnaf [~gnaf@51.15.9.205] has joined #bitcoin-core-dev 07:04 -!- Elzington [~Elzington@static-68-235-44-10.cust.tzulo.com] has joined #bitcoin-core-dev 07:16 < ryanofsky> laanwj: Thanks! 07:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 07:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 07:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 07:24 -!- sav_ [~savio@177.12.48.155] has quit [Quit: Leaving] 07:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 07:35 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has quit [Remote host closed the connection] 07:35 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has joined #bitcoin-core-dev 07:41 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 07:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3zx6m4301bhqy.ipv6.telus.net] has joined #bitcoin-core-dev 07:44 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te3xpnfhzs6f6ie.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 07:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 07:50 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has joined #bitcoin-core-dev 07:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 07:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 07:58 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4z3j5oc63uyy2.ipv6.telus.net] has joined #bitcoin-core-dev 08:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 08:00 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te56ehth1vri6a5.ipv6.telus.net] has joined #bitcoin-core-dev 08:01 -!- Kaize____ [~Kaizen_Ki@node-1w7jr9yi65te519xt19hrjjy4.ipv6.telus.net] has joined #bitcoin-core-dev 08:02 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3zx6m4301bhqy.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 08:03 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4z3j5oc63uyy2.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 08:05 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te56ehth1vri6a5.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 08:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 08:07 -!- Aaronvan_ [~AaronvanW@190.53.113.19] has quit [Ping timeout: 256 seconds] 08:10 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:12 -!- gnaf [~gnaf@51.15.9.205] has quit [Quit: Konversation terminated!] 08:14 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 08:15 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 08:16 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 08:16 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:17 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 08:18 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:20 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 08:21 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23652: doc: Document optional result fields in getpeerinfo (master...2112-docOptPeer) https://github.com/bitcoin/bitcoin/pull/23652 08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:52 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:54 < bitcoin-git> [bitcoin] sipa opened pull request #23653: Generalize/simplify VectorReader into SpanReader (master...202112_spanreader) https://github.com/bitcoin/bitcoin/pull/23653 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Remote host closed the connection] 09:02 -!- ZeroMaster [~webirc@95-42-105-42.ip.btc-net.bg] has joined #bitcoin-core-dev 09:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 09:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 09:13 -!- sav [~savio@177.12.48.155] has joined #bitcoin-core-dev 09:13 -!- sav is now known as Guest5350 09:16 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 252 seconds] 09:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 09:20 -!- gnaf [~gnaf@51.15.9.205] has joined #bitcoin-core-dev 09:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 09:21 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 09:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 09:23 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 09:24 -!- Guyver2_ is now known as Guyver2 09:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 09:28 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 09:30 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 09:32 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 09:33 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 09:37 -!- Guyver2_ [~Guyver@2001:985:f3f:1:cd8d:75ec:d720:d4db] has joined #bitcoin-core-dev 09:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 09:40 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 252 seconds] 09:40 -!- Guyver2_ is now known as Guyver2 09:43 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 09:48 -!- MatanHamilis [uid502224@id-502224.tinside.irccloud.com] has joined #bitcoin-core-dev 09:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 09:55 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 09:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 10:00 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev 10:04 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6ov1prfkcgbtm.ipv6.telus.net] has joined #bitcoin-core-dev 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23654: fuzz: Rework rpc fuzz target (master...2112-fuzzRpc) https://github.com/bitcoin/bitcoin/pull/23654 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:07 -!- Guest5350 [~savio@177.12.48.155] has quit [Quit: Leaving] 10:07 -!- sav [~savio@177.12.48.155] has joined #bitcoin-core-dev 10:07 -!- Kaize____ [~Kaizen_Ki@node-1w7jr9yi65te519xt19hrjjy4.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 10:08 -!- sav is now known as Guest5157 10:09 -!- Guest5157 [~savio@177.12.48.155] has quit [Client Quit] 10:16 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 10:23 -!- Herbsman [~Herbsman@user/herbsman] has quit [Remote host closed the connection] 10:24 -!- Herbsman [~Herbsman@user/herbsman] has joined #bitcoin-core-dev 10:26 -!- gnaf [~gnaf@51.15.9.205] has quit [Quit: Konversation terminated!] 10:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:38 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/26a1147ce560...bce58bbb3d7b 10:38 < bitcoin-git> bitcoin/master 456e350 S3RK: wallet: resolve ambiguity of two ScriptPubKey managers providing same scri... 10:38 < bitcoin-git> bitcoin/master 03840c2 S3RK: Add CWallet::IsInternalScriptPubKeyMan 10:38 < bitcoin-git> bitcoin/master c1b99c0 S3RK: Return used destinations from ScriptPubKeyMan::MarkUnusedAddresses 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:38 < bitcoin-git> [bitcoin] laanwj merged pull request #22929: wallet: Automatically add receiving destinations to the address book (master...fix_19856) https://github.com/bitcoin/bitcoin/pull/22929 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:51 -!- tru3nrg [~tru3nrg@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bce58bbb3d7b...0b30bdd519ae 10:57 < bitcoin-git> bitcoin/master 5c3033d Hennadii Stepanov: Add thread safety annotations to CBlockPolicyEstimator public functions 10:57 < bitcoin-git> bitcoin/master 5ee5b69 Hennadii Stepanov: refactor: Add non-thread-safe CBlockPolicyEstimator::_removeTx helper 10:57 < bitcoin-git> bitcoin/master 8c277b1 Hennadii Stepanov: refactor: Make m_cs_fee_estimator non-recursive 10:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22014: refactor: Make m_cs_fee_estimator non-recursive (master...210521-fees) https://github.com/bitcoin/bitcoin/pull/22014 10:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:00 < laanwj> #startmeeting 11:00 < core-meetingbot> Meeting started Thu Dec 2 19:00:12 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 11:00 < core-meetingbot> Available commands: action commands idea info link nick 11:00 < hebasto> hi 11:00 < b10c> hi 11:00 < kvaciral[m]> hi 11:00 < sipa> hi 11:01 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 11:01 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 11:01 < laanwj> one proposedmeetingtopic: Warn when we have only _old_ peers? (b10c) 11:01 < lightlike> hi 11:01 < jamesob> hi 11:02 < laanwj> any last minute topics? 11:03 < laanwj> #topic High priority for review 11:03 < core-meetingbot> topic: High priority for review 11:03 < meshcollider> hi 11:03 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 1 chasing concept ACK 11:04 < laanwj> anything to add/remove or that is almost ready for merge? 11:04 < MarcoFalke> can i haz #19499 pls ? 11:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/19499 | p2p: Make timeout mockable and type safe, speed up test by MarcoFalke · Pull Request #19499 · bitcoin/bitcoin · GitHub 11:04 < jamesob> MarcoFalke: oh cool, will review 11:05 < laanwj> MarcoFalke: added 11:05 < MarcoFalke> thx 11:06 < laanwj> would it make sense to add #23443? it's a blocker for erlay and the next step 11:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub 11:07 < sipa> won't hurt to add it i guess 11:08 < laanwj> ok, will do 11:08 -!- dougefish [~dougefish@5.29.49.79] has quit [Quit: dougefish] 11:09 < laanwj> does anyone have other suggestions? or wants to discuss an existing high prio PR? 11:09 -!- dougefish [~dougefish@5.29.49.79] has joined #bitcoin-core-dev 11:10 < laanwj> if not, let's move on to the next topic 11:10 < laanwj> #topic Warn when we have only _old_ peers? (b10c) 11:10 < core-meetingbot> topic: Warn when we have only _old_ peers? (b10c) 11:10 < b10c> I've posted a few comments about why F2Pool initially didn't include P2TR spends in their blocks to the ML: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-November/019608.html 11:10 < b10c> TLDR: buggy patches to their peer selection. An unmaintained heuristic filtered newer Bitcoin Core peers. But, (IMO) unpublished patches are out of scope for the Bitcoin Core project. 11:10 < b10c> However, with currently only ~50% of nodes upgraded, it could still be relevant to warn node operators about e.g. only being connected to peers old that don't relay P2TR spends. 11:10 < sipa> a first question is: how would this even be detectable 11:11 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 256 seconds] 11:11 < b10c> Something like this could be a feature we want before the next soft-fork affecting transaction relay. 11:11 < b10c> sipa: right 11:11 < b10c> Bump PROTOCOL_VERSION for soft-fork tx relay? service flag e.g. TAPROOT_RELAY? Flag in the version message indicate soft-fork readiness? 11:11 < sipa> but this isn't about softforks 11:11 < sipa> it's about any change in relay policy 11:12 < sipa> though, at least the past few years, the only invasive changes to relay policy (in bitcoin core at least) have been due to softforks, i think 11:13 < b10c> and the next question would be: How to warn node operators (besides logging to debug.log)? getnodealerts/getnodewarnings RPC? 11:14 < sipa> i think the best approach (assuming there was a way to detect it), would be to add more outgoing connections and/or rotate them faster 11:14 < laanwj> we've become kind fo careful about warnings that are not relevant to most users 11:14 < sipa> we kind of do something like that when we believe we're only connected to consensus-incompatible peers already 11:15 -!- tru3nrg [~tru3nrg@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has quit [Quit: Connection closed] 11:15 < sipa> but detecting is kind of ugly, i think... because it goes to concerns like should we try to inform our peers about the entirety of our relay policy? 11:15 < sipa> and i'm not sure the problem is big enough of a concern to even get into that 11:16 < sipa> relay policy is just policy, after all 11:16 < b10c> hmm agree, if it would only be for soft-forks maybe a simple flag would be enough. but gets messy with the entirety of policy 11:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 11:16 < lightlike> has this also been an issue in normal circumstances? The mailing list post talks about some artifical addnode scenario, extra automtic outbounds wouldn't help with that. 11:16 < laanwj> i do think some heuristic would make sense when broadcasting, e.g. when you broadcast a transaction and no peer relays it back to you 11:17 -!- mamilis [sid502224@id-502224.tinside.irccloud.com] has joined #bitcoin-core-dev 11:17 < sipa> laanwj: that would be useful! 11:17 -!- mamilis [sid502224@id-502224.tinside.irccloud.com] has quit [Client Quit] 11:17 < sipa> though, that may not be sufficient for this case even 11:17 < b10c> that would help in the sender case, not in the miner case 11:17 < sipa> as it would only make the original tx broadcasters notice, not intermediaries 11:18 < b10c> lightlike: I haven't heard about any other case 11:18 -!- Guest92 [~Guest92@p200300f1172bc40030d6fc7a913aa5cd.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:19 < sipa> given that the first P2TR spends actually reached miners fine within a few blocks kind of shows there were no relay problems (that we know of) 11:19 < sipa> and if it's just unfortunate local configuration on the miners side, i don't think this would do much, given what lightlike said 11:19 < laanwj> peers witholding certain transactions from you is a subset of the general eclipse problem 11:20 -!- Guest92 [~Guest92@p200300f1172bc40030d6fc7a913aa5cd.dip0.t-ipconnect.de] has quit [Client Quit] 11:20 < laanwj> if you're worried about that, especially as a miner you'd likely want to make sure you connect to a few trusted peers (preferably over overlay networks) 11:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 11:21 < sipa> b10c: oh i see, your assumption was that it would be warning operators, not just trying to fix things automatically 11:21 < sipa> i think the only reliable way to warn operators is by shutting down... 11:22 < b10c> that is definitely reliable for a mining pool, but also a DoS vector 11:22 < sipa> indeed 11:22 < laanwj> shutting down based on a heuristic about connected peers seems kind of drastic 11:23 < sipa> yes, i only mentioned it in jest 11:23 < laanwj> you can do that of course (a watchdog kind of script), but i see no reason to build that into bitcoin core 11:23 < b10c> one idea was a RPC interface (e.g. getnodewarnings) to hook into from your monitoring stack 11:24 < b10c> to at least have something well defined 11:24 < laanwj> but if you have monitoring software, why not call getpeerinfo 11:24 < MarcoFalke> there is already getblockchaininfo()[warnings] 11:24 < sipa> yeah... 11:24 < laanwj> i suppose all the information you need to decide about node versions is there 11:25 < laanwj> it's never more than a heuristic, untrusted nodes can lie about versions, version bits, etc 11:26 < laanwj> service bits* 11:27 < b10c> cool, thanks! This discussion was helpful for me. Maybe a heuristic for a sender if his transaction got relayed back to him... Everything else might be to ambitious and messy 11:27 < sipa> yeah i don't really have any good ideas 11:27 < b10c> not relayed* 11:27 < laanwj> (which is also what makes it somewhat scary as a built-in warning; i remember the spurious new-unsupported-version warnings with the block version bits when miners started using them for... other things) 11:27 < laanwj> right 11:28 < laanwj> any other topics? 11:30 < laanwj> closing the meeting, thanks everyone for attending 11:30 < laanwj> #endmeeting 11:30 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:30 < core-meetingbot> Meeting ended Thu Dec 2 19:30:19 2021 UTC. 11:30 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-12-02-19.00.moin.txt 11:30 < gene> thanks for the meeting all 11:30 -!- Guest50 [~Guest50@2601:587:200:98f0:ecf0:7f15:438c:58a1] has joined #bitcoin-core-dev 11:30 < b10c> thanks! 11:37 -!- pescador [~pescador@user/pescador] has joined #bitcoin-core-dev 11:41 -!- Guest50 [~Guest50@2601:587:200:98f0:ecf0:7f15:438c:58a1] has quit [Quit: Client closed] 11:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 11:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 12:08 < cfields> whoops, missed the meeting. 12:16 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te5s4lfwjywtjgw.ipv6.telus.net] has quit [Remote host closed the connection] 12:16 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:16 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has joined #bitcoin-core-dev 12:16 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te67b3loc2zr2n8.ipv6.telus.net] has joined #bitcoin-core-dev 12:18 < laanwj> heh 12:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6ov1prfkcgbtm.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 12:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te694jze2v6mnjm.ipv6.telus.net] has joined #bitcoin-core-dev 12:21 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 12:22 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te67b3loc2zr2n8.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 12:23 -!- pescador [~pescador@user/pescador] has quit [Remote host closed the connection] 12:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te694jze2v6mnjm.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 12:35 -!- Elzington_ [~Elzington@68.235.43.38] has joined #bitcoin-core-dev 12:37 -!- Elzington [~Elzington@static-68-235-44-10.cust.tzulo.com] has quit [Ping timeout: 252 seconds] 12:38 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 12:38 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 252 seconds] 12:38 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has joined #bitcoin-core-dev 12:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te7a6vfz38ujw97.ipv6.telus.net] has joined #bitcoin-core-dev 12:40 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 12:44 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 252 seconds] 12:45 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 12:46 -!- flooded is now known as _flood 12:56 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Read error: Connection reset by peer] 13:01 -!- jarthur [~jarthur@2603-8080-1540-002d-119c-b00a-a373-e238.res6.spectrum.com] has joined #bitcoin-core-dev 13:02 -!- smartin [~Icedove@88.135.18.171] has quit [Remote host closed the connection] 13:03 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 13:11 -!- Guyver2 [~Guyver@2001:985:f3f:1:cd8d:75ec:d720:d4db] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:11 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has quit [Remote host closed the connection] 13:11 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has joined #bitcoin-core-dev 13:12 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 13:17 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 13:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:32 < bitcoin-git> [bitcoin] Baumgartl opened pull request #23658: contrib: add check for wget command in install_db4.sh (master...contrib-patches) https://github.com/bitcoin/bitcoin/pull/23658 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:33 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has quit [Remote host closed the connection] 13:34 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has joined #bitcoin-core-dev 13:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 13:38 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 13:41 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6g5lgwsjt6wz5.ipv6.telus.net] has joined #bitcoin-core-dev 13:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te7a6vfz38ujw97.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 13:44 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te606hdydeqaxxk.ipv6.telus.net] has joined #bitcoin-core-dev 13:46 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6g5lgwsjt6wz5.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 13:46 -!- ZeroMaster [~webirc@95-42-105-42.ip.btc-net.bg] has quit [Remote host closed the connection] 13:48 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4jw9os3uixn8n.ipv6.telus.net] has joined #bitcoin-core-dev 13:49 -!- ZeroMaster [~webirc@95-42-105-42.ip.btc-net.bg] has joined #bitcoin-core-dev 13:51 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te4fcj8of78jxhi.ipv6.telus.net] has joined #bitcoin-core-dev 13:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te606hdydeqaxxk.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 13:52 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Remote host closed the connection] 14:00 < jamesob> was there some merge causing unrebased PRs to start failing? seeing a lot of unrelated "TypeError: generatetoaddress() missing 1 required keyword-only argument: 'invalid_call'" failures in the functional tests for new PRs 14:01 -!- littlesh [~Username@bras-base-clwdon2201w-grc-48-174-89-150-139.dsl.bell.ca] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:02 < sipa> i'm seeing that too 14:04 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 14:04 < jamesob> fix incoming 14:05 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 14:08 < jamesob> https://github.com/bitcoin/bitcoin/pull/23659 14:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:08 < bitcoin-git> [bitcoin] jamesob opened pull request #23659: test: fix: remove outdated TestNode.generate calls (master...2021-12-fix-listtransactions-generate) https://github.com/bitcoin/bitcoin/pull/23659 14:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:10 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 14:15 -!- Guest38 [~Guest38@2a02:26f7:ba48:4000:de71:74c4:cd24:71c7] has joined #bitcoin-core-dev 14:16 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 14:22 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 14:23 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 14:23 -!- Guest38 [~Guest38@2a02:26f7:ba48:4000:de71:74c4:cd24:71c7] has quit [Quit: Client closed] 14:31 -!- pinheadmz_ [~pinheadmz@hns-contributor.dev] has quit [Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in] 14:33 -!- pinheadmz [~pinheadmz@hns-contributor.dev] has joined #bitcoin-core-dev 14:35 -!- BUSY [~BUSY@user/busy] has quit [Remote host closed the connection] 14:42 -!- smartin [~Icedove@88.135.18.171] has quit [Ping timeout: 256 seconds] 14:52 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4jw9os3uixn8n.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 14:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te7ldv7ozmuzkku.ipv6.telus.net] has joined #bitcoin-core-dev 14:56 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Ping timeout: 252 seconds] 14:57 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 15:01 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 252 seconds] 15:21 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 15:48 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 15:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 15:55 -!- d4TuR4 [~d4TuR4@121.99.244.62] has joined #bitcoin-core-dev 15:56 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6dkp0c8958aud.ipv6.telus.net] has joined #bitcoin-core-dev 15:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te7ldv7ozmuzkku.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 16:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te62lp1w1yk3tjx.ipv6.telus.net] has joined #bitcoin-core-dev 16:02 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te4075i4yr3i0rx.ipv6.telus.net] has joined #bitcoin-core-dev 16:04 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev 16:04 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6dkp0c8958aud.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 16:06 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te62lp1w1yk3tjx.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 16:18 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection] 16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:18 < bitcoin-git> [gui] luke-jr opened pull request #497: Enable users to configure their monospace font specifically (master...qt_fontsel) https://github.com/bitcoin-core/gui/pull/497 16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:18 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev 16:20 -!- Aaronvan_ [~AaronvanW@176.119.195.70] has joined #bitcoin-core-dev 16:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 16:23 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Ping timeout: 256 seconds] 16:24 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 16:25 -!- Aaronvan_ [~AaronvanW@176.119.195.70] has quit [Read error: Connection reset by peer] 16:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 16:27 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 16:43 -!- jarthur_ [~jarthur@2603-8080-1540-002d-10a9-6df7-8cac-a961.res6.spectrum.com] has joined #bitcoin-core-dev 16:46 -!- roconnor [~roconnor@coq/roconnor] has quit [Ping timeout: 256 seconds] 16:46 -!- jarthur [~jarthur@2603-8080-1540-002d-119c-b00a-a373-e238.res6.spectrum.com] has quit [Ping timeout: 252 seconds] 16:46 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 252 seconds] 16:59 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 17:00 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 17:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 17:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6r2fad1p51lds.ipv6.telus.net] has joined #bitcoin-core-dev 17:06 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te4075i4yr3i0rx.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 17:07 -!- roconnor [~roconnor@coq/roconnor] has joined #bitcoin-core-dev 17:07 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4fd1hop6yijm2.ipv6.telus.net] has joined #bitcoin-core-dev 17:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te6r2fad1p51lds.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 17:12 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Remote host closed the connection] 17:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 17:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 17:42 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 17:44 -!- earnest [~earnest@user/earnestly] has quit [Ping timeout: 256 seconds] 17:47 -!- AaronvanW [~AaronvanW@190.53.113.19] has quit [Ping timeout: 256 seconds] 17:47 -!- earnest [~earnest@user/earnestly] has joined #bitcoin-core-dev 17:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 17:52 -!- jarthur_ [~jarthur@2603-8080-1540-002d-10a9-6df7-8cac-a961.res6.spectrum.com] has quit [Quit: jarthur_] 17:52 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 17:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 18:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 18:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te613xz1e1vny0f.ipv6.telus.net] has joined #bitcoin-core-dev 18:11 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4fd1hop6yijm2.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 18:14 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404] 18:15 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6i7diu8vyk62p.ipv6.telus.net] has joined #bitcoin-core-dev 18:18 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te613xz1e1vny0f.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 18:18 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 18:20 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te6i7diu8vyk62p.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 18:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3tjofz8jvbq1g.ipv6.telus.net] has joined #bitcoin-core-dev 18:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 18:34 -!- AaronvanW [~AaronvanW@190.53.113.19] has joined #bitcoin-core-dev 18:34 -!- kallewoof [~quassel@user/kallewoof] has quit [Ping timeout: 268 seconds] 18:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 18:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 276 seconds] 18:57 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 19:17 -!- outfox [~outfox@user/outfox] has quit [Ping timeout: 252 seconds] 19:19 -!- outfox [~outfox@213.144.147.16] has joined #bitcoin-core-dev 19:19 -!- outfox [~outfox@213.144.147.16] has quit [Changing host] 19:19 -!- outfox [~outfox@user/outfox] has joined #bitcoin-core-dev 19:21 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te5400p5jojjt11.ipv6.telus.net] has joined #bitcoin-core-dev 19:24 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3tjofz8jvbq1g.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 19:27 -!- earnest [~earnest@user/earnestly] has quit [Ping timeout: 252 seconds] 19:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 19:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 19:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 19:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 20:04 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev 20:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:21 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0b30bdd519ae...ffe414bd9a9c 20:21 < bitcoin-git> bitcoin/master b01784f glozow: remove unnecessary casts and use braced initialization 20:21 < bitcoin-git> bitcoin/master c4efc4d glozow: change TestLockPointValidity to take a const reference 20:21 < bitcoin-git> bitcoin/master ddd74ff glozow: clean up txmempool includes 20:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:21 < bitcoin-git> [bitcoin] fanquake merged pull request #23649: circular dependency followups (master...22677-followups) https://github.com/bitcoin/bitcoin/pull/23649 20:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 20:23 -!- saranshsharma [~saranshsh@117.196.151.206] has joined #bitcoin-core-dev 20:24 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3vsrt9lgrgg68.ipv6.telus.net] has joined #bitcoin-core-dev 20:26 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te5400p5jojjt11.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 20:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 20:27 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te3yfoifte0k2jp.ipv6.telus.net] has joined #bitcoin-core-dev 20:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te3vsrt9lgrgg68.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 20:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4m9a23nif6vg6.ipv6.telus.net] has joined #bitcoin-core-dev 20:32 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te3yfoifte0k2jp.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 20:34 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4qol4dyuxbkcx.ipv6.telus.net] has joined #bitcoin-core-dev 20:35 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4m9a23nif6vg6.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:38 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ffe414bd9a9c...927a9b077768 20:38 < bitcoin-git> bitcoin/master 4e1cb90 James O'Beirne: test: fix: remove outdated TestNode.generate calls 20:38 < bitcoin-git> bitcoin/master 927a9b0 fanquake: Merge bitcoin/bitcoin#23659: test: fix: remove outdated TestNode.generate ... 20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:38 < bitcoin-git> [bitcoin] fanquake merged pull request #23659: test: fix: remove outdated TestNode.generate calls (master...2021-12-fix-listtransactions-generate) https://github.com/bitcoin/bitcoin/pull/23659 20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:41 -!- RobYatty [~me@user/robyatty] has quit [Remote host closed the connection] 20:43 -!- RobYatty [~me@107-139-231-17.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 20:44 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te5c7vhs38suw48.ipv6.telus.net] has joined #bitcoin-core-dev 20:45 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te55z1y3hyagsp0.ipv6.telus.net] has joined #bitcoin-core-dev 20:47 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4qol4dyuxbkcx.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 20:49 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te5c7vhs38suw48.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:01 -!- RobYatty [~me@107-139-231-17.lightspeed.irvnca.sbcglobal.net] has quit [Remote host closed the connection] 21:13 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 21:17 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 21:45 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 21:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te761jpv9750kqd.ipv6.telus.net] has joined #bitcoin-core-dev 21:49 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te55z1y3hyagsp0.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 22:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 22:06 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te56hkgrclftjlp.ipv6.telus.net] has joined #bitcoin-core-dev 22:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 22:09 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te66ps7xi7jcoz9.ipv6.telus.net] has joined #bitcoin-core-dev 22:09 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te761jpv9750kqd.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 22:11 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te56hkgrclftjlp.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 22:13 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 22:20 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 22:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 276 seconds] 22:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 22:38 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 22:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 22:39 -!- saranshs_ [~saranshsh@117.196.151.206] has joined #bitcoin-core-dev 22:39 -!- saranshsharma [~saranshsh@117.196.151.206] has quit [Read error: Connection reset by peer] 22:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 252 seconds] 22:53 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 22:55 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 23:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 23:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 23:07 -!- goatpig [~goat@static-193-13-33-110.cust.tele2.se] has joined #bitcoin-core-dev 23:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te62b0loj5uza26.ipv6.telus.net] has joined #bitcoin-core-dev 23:13 -!- Kaizen___ [~Kaizen_Ki@node-1w7jr9yi65te66ps7xi7jcoz9.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 23:15 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4ffk0wtwhtf2h.ipv6.telus.net] has joined #bitcoin-core-dev 23:17 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te62b0loj5uza26.ipv6.telus.net] has quit [Ping timeout: 268 seconds] 23:19 -!- flag [~flag@net-37-116-7-126.cust.vodafonedsl.it] has quit [Ping timeout: 256 seconds] 23:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has joined #bitcoin-core-dev 23:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:edaa:c165:6500:e697] has quit [Ping timeout: 268 seconds] 23:58 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 252 seconds] --- Log closed Fri Dec 03 00:00:50 2021