--- Log opened Wed Dec 15 00:00:01 2021 00:08 -!- Guest58 [~Guest58@2405:201:c009:fc79:ad99:37aa:1e12:9022] has joined #bitcoin-core-dev 00:08 -!- Guest58 [~Guest58@2405:201:c009:fc79:ad99:37aa:1e12:9022] has quit [Client Quit] 00:14 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 252 seconds] 00:26 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev 00:31 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 00:35 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 00:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 00:37 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 00:48 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds] 00:51 -!- meshcollider [meshcollid@jujube.ircnow.org] has quit [Changing host] 00:51 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-dev 00:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9015d118425d...40fdb9ece979 00:56 < bitcoin-git> bitcoin/master 207f1c8 josibake: refactor: make AddrMan::Good return bool 00:56 < bitcoin-git> bitcoin/master f961c47 josibake: refactor: check Good() in tried_collisions test 00:56 < bitcoin-git> bitcoin/master caac999 josibake: refactor: remove dependence on AddrManTest 00:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23713: refactor, test: refactor addrman_tried_collisions test to directly check for collisions (master...josibake-addrman-collisions-refactor) https://github.com/bitcoin/bitcoin/pull/23713 00:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:03 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 252 seconds] 01:03 -!- RobYatty is now known as RoyBatty 01:04 -!- RoyBatty [~me@107-139-231-17.lightspeed.irvnca.sbcglobal.net] has quit [Changing host] 01:04 -!- RoyBatty [~me@user/robyatty] has joined #bitcoin-core-dev 01:13 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 01:20 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 01:20 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 01:29 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-dev 01:36 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 01:52 -!- befalou [~befalou@2a01:4f8:1c1c:ea1c:e3ef:d8ca:53c4:fcac] has joined #bitcoin-core-dev 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/40fdb9ece979...7006496a5c03 02:01 < bitcoin-git> bitcoin/master fad6761 MarcoFalke: Fix implicit integer sign changes in strencodings 02:01 < bitcoin-git> bitcoin/master fa5865a MarcoFalke: Reduce size of strencodings decode tables 02:01 < bitcoin-git> bitcoin/master 7006496 MarcoFalke: Merge bitcoin/bitcoin#23756: refactor: Fix implicit integer sign changes i... 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:01 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23756: refactor: Fix implicit integer sign changes in strencodings (master...2111-int) https://github.com/bitcoin/bitcoin/pull/23756 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:04 -!- kexkey_ [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-105.cust.tzulo.com] has joined #bitcoin-core-dev 02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7006496a5c03...b67115dd044d 02:09 < bitcoin-git> bitcoin/master d0c6e61 James O'Beirne: validation: don't modify genesis during snapshot load 02:09 < bitcoin-git> bitcoin/master 0fd599a James O'Beirne: validation: have LoadBlockIndex account for snapshot use 02:09 < bitcoin-git> bitcoin/master 2283b9c James O'Beirne: test: add tests for LoadBlockIndex when using multiple chainstates 02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23174: validation: have LoadBlockIndex account for snapshot use (master...2021-10-au-loadblockindex) https://github.com/bitcoin/bitcoin/pull/23174 02:09 -!- zonemix_ [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:11 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 260 seconds] 02:12 -!- saranshsharma [~saranshsh@59.93.228.149] has joined #bitcoin-core-dev 02:21 -!- zonemix_ [~zonemix@216.16.35.204] has quit [Ping timeout: 252 seconds] 02:22 -!- saranshsharma [~saranshsh@59.93.228.149] has quit [Remote host closed the connection] 02:23 -!- saranshsharma [~saranshsh@59.93.228.149] has joined #bitcoin-core-dev 02:28 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 02:29 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 02:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:38 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b67115dd044d...965ffe2bed04 02:38 < bitcoin-git> bitcoin/master 6fc5c77 Igor Cota: build, qt: use static QAndroidPlatformIntegrationPlugin 02:38 < bitcoin-git> bitcoin/master 27f353d Igor Cota: build, android: Fix Android GUI not loading on Qt 5.15 02:38 < bitcoin-git> bitcoin/master 965ffe2 fanquake: Merge bitcoin/bitcoin#23757: [build] Android: fix GUI not loading on Qt 5.... 02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:38 < bitcoin-git> [bitcoin] fanquake merged pull request #23757: [build] Android: fix GUI not loading on Qt 5.15 (master...qt-515-android) https://github.com/bitcoin/bitcoin/pull/23757 02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:53 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 02:54 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 02:55 -!- paairs [~rabidus@user/paairs] has quit [Ping timeout: 240 seconds] 02:57 -!- paairs [~rabidus@user/paairs] has joined #bitcoin-core-dev 03:00 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 260 seconds] 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:03 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/965ffe2bed04...2d0bdb208964 03:03 < bitcoin-git> bitcoin/master faa6c3d MarcoFalke: net: Drop only invalid entries when reading banlist.json 03:03 < bitcoin-git> bitcoin/master 2d0bdb2 W. J. van der Laan: Merge bitcoin/bitcoin#22362: Drop only invalid entries when reading banlis... 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:03 < bitcoin-git> [bitcoin] laanwj merged pull request #22362: Drop only invalid entries when reading banlist.json (master...2106-addrdb) https://github.com/bitcoin/bitcoin/pull/22362 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:13 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 03:14 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 03:19 -!- jarthur [~jarthur@2603-8080-1540-002d-b1ee-87e3-1ad0-a6a9.res6.spectrum.com] has quit [Quit: jarthur] 03:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:37 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20273: Extend support for nested commands to bitcoin-cli (master...2020/10/client_rpc_nested) https://github.com/bitcoin/bitcoin/pull/20273 03:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:38 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev 03:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:38 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16883: WIP: Qt: add QML based mobile GUI (master...qt-mobile) https://github.com/bitcoin/bitcoin/pull/16883 03:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:43 -!- saranshsharma [~saranshsh@59.93.228.149] has quit [Remote host closed the connection] 03:48 -!- saranshsharma [~saranshsh@59.93.228.149] has joined #bitcoin-core-dev 03:48 -!- saranshsharma [~saranshsh@59.93.228.149] has quit [Remote host closed the connection] 03:48 -!- saranshsharma [~saranshsh@59.93.228.149] has joined #bitcoin-core-dev 03:56 -!- boxframes [~Saloframe@2607:9000:2000:15::a45d] has joined #bitcoin-core-dev 04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:03 < bitcoin-git> [bitcoin] josibake opened pull request #23780: refactor, test: update `addrman_tests.cpp` to use output from `AddrMan::Good()` (master...josibake-addrman-test-refactors) https://github.com/bitcoin/bitcoin/pull/23780 04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:04 -!- saranshsharma [~saranshsh@59.93.228.149] has quit [Remote host closed the connection] 04:04 -!- saranshsharma [~saranshsh@59.93.228.149] has joined #bitcoin-core-dev 04:05 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 04:06 -!- saranshsharma [~saranshsh@59.93.228.149] has quit [Remote host closed the connection] 04:09 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2d0bdb208964...60b5795133a2 04:09 < bitcoin-git> bitcoin/master fad7ead MarcoFalke: refactor: Use type-safe std::chrono in net 04:09 < bitcoin-git> bitcoin/master fa663a4 MarcoFalke: Use mockable time for peer connection time 04:09 < bitcoin-git> bitcoin/master fad9438 MarcoFalke: scripted-diff: Rename touched member variables 04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23758: net: Use type-safe mockable time for peer connection time (master...2112-timeMockp2p) https://github.com/bitcoin/bitcoin/pull/23758 04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:10 < bitcoin-git> [bitcoin] hebasto opened pull request #23781: test: Fix `system_tests/run_command` on Windows (master...211215-bptest) https://github.com/bitcoin/bitcoin/pull/23781 04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:18 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 250 seconds] 04:19 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 04:35 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:40 < bitcoin-git> [bitcoin] seaona opened pull request #23782: test: include two more interruptions points (master...2021-12-feature-init-test-interruptions) https://github.com/bitcoin/bitcoin/pull/23782 04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:48 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:c132:c943:2f35:ef2c] has joined #bitcoin-core-dev 04:49 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 05:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:10 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/60b5795133a2...b8cc75435a0b 05:10 < bitcoin-git> bitcoin/master 71d3338 HiLivin: qt: prevent negative values of progressPerHour 05:10 < bitcoin-git> bitcoin/master b8cc754 Hennadii Stepanov: Merge bitcoin-core/gui#508: Prevent negative values of progressPerHour 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:11 < bitcoin-git> [gui] hebasto merged pull request #508: Prevent negative values of progressPerHour (master...master) https://github.com/bitcoin-core/gui/pull/508 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:26 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:27 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 05:29 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 252 seconds] 05:31 -!- befalou [~befalou@2a01:4f8:1c1c:ea1c:e3ef:d8ca:53c4:fcac] has quit [Quit: befalou] 05:37 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 05:41 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 05:57 -!- littlesh [~Username@bras-base-clwdon2201w-grc-48-174-89-150-139.dsl.bell.ca] has joined #bitcoin-core-dev 06:02 -!- arythmetic [~arythmeti@2607:fea8:85c1:db00:c132:c943:2f35:ef2c] has quit [Remote host closed the connection] 06:10 -!- saranshsharma [~saranshsh@59.93.228.149] has joined #bitcoin-core-dev 06:15 -!- saranshsharma [~saranshsh@59.93.228.149] has quit [Ping timeout: 265 seconds] 06:21 -!- zonemix [~zonemix@138.247.240.137] has joined #bitcoin-core-dev 06:27 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Read error: Connection reset by peer] 06:27 -!- roconnor [~roconnor@coq/roconnor] has quit [Quit: Konversation terminated!] 06:58 -!- harding [quassel@newmail.dtrt.org] has quit [Ping timeout: 252 seconds] 06:58 -!- harding [~quassel@newmail.dtrt.org] has joined #bitcoin-core-dev 06:59 -!- arythmetic [~arythmeti@38.112.106.67] has joined #bitcoin-core-dev 07:07 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 245 seconds] 07:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b8cc75435a0b...c09b41dc665b 07:11 < bitcoin-git> bitcoin/master fada66f MarcoFalke: Disallow copies of CChain 07:11 < bitcoin-git> bitcoin/master faf2614 MarcoFalke: style: Use 4 spaces for indendation, not 5 07:11 < bitcoin-git> bitcoin/master c09b41d MarcoFalke: Merge bitcoin/bitcoin#23769: Disallow copies of CChain 07:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23769: Disallow copies of CChain (master...2112-chainNoCopy) https://github.com/bitcoin/bitcoin/pull/23769 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:13 -!- jtrag [~jtrag@user/jtrag] has quit [Ping timeout: 252 seconds] 07:15 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 07:17 -!- gleb74 [~gleb@178.150.137.228] has quit [Ping timeout: 240 seconds] 07:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:25 < bitcoin-git> [bitcoin] theStack opened pull request #23784: bitcoin-tx: Require that input amount is provided for witness transactions (master...bitcoin-tx_check_witness_input_amount) https://github.com/bitcoin/bitcoin/pull/23784 07:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13608: WIP: bitcoin-tx: Require that input amount is provided for witness transactions (master...bitcoin-tx-sign-amount) https://github.com/bitcoin/bitcoin/pull/13608 07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:40 -!- kexkey [~kexkey@static-198-54-132-105.cust.tzulo.com] has quit [Ping timeout: 256 seconds] 07:42 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has joined #bitcoin-core-dev 07:46 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 07:51 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:04 -!- jtrag [~jtrag@user/jtrag] has quit [Quit: Fuck y'all I'm out dis bitch! ✌️ out yo!] 08:07 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 08:20 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 08:21 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:29 -!- daedin [~daedin@213.55.244.17] has joined #bitcoin-core-dev 08:33 -!- hsdjkfhfshfsi [~SomeAdmin@104-181-157-226.lightspeed.austtx.sbcglobal.net] has quit [Quit: Leaving] 08:37 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 08:44 -!- An0rak [An0rak@user/an0rak] has quit [] 08:45 -!- gleb74 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 08:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:48 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23785: 2112 move c man (master...2112-moveCMan) https://github.com/bitcoin/bitcoin/pull/23785 08:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:09 < luke-jr> bleh, now DrahtBot is just spamming :/ 09:11 -!- haakon_ [~haakonn@82.196.8.209] has quit [Ping timeout: 250 seconds] 09:23 -!- jb55 [~jb55@S0106606c634dbdd3.vc.shawcable.net] has joined #bitcoin-core-dev 09:28 -!- nat [~nat@nazareth.nekopon.pl] has quit [Quit: ZNC 1.8.2 - https://znc.in] 09:29 -!- daedin [~daedin@213.55.244.17] has quit [Ping timeout: 240 seconds] 09:29 -!- nat [~nat@nazareth.nekopon.pl] has joined #bitcoin-core-dev 09:36 -!- dougefish_ [~dougefish@5.29.49.79] has quit [Quit: dougefish_] 09:36 < jamesob> dongcarl: what's next for libbitcoinkernel? 09:38 -!- dougefish [~dougefish@5.29.49.79] has joined #bitcoin-core-dev 09:38 -!- jtrag is now known as Guest3856 09:39 -!- daedin [~daedin@213.55.244.17] has joined #bitcoin-core-dev 09:39 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 09:39 -!- Guest3856 [~jtrag@user/jtrag] has quit [Ping timeout: 260 seconds] 09:48 < darosior> Interested too ^ 09:56 -!- arythmetic [~arythmeti@38.112.106.67] has quit [Remote host closed the connection] 09:57 -!- arythmetic [~arythmeti@38.112.106.67] has joined #bitcoin-core-dev 09:59 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 10:01 -!- arythmetic [~arythmeti@38.112.106.67] has quit [Ping timeout: 252 seconds] 10:02 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:09 -!- daedin [~daedin@213.55.244.17] has quit [Ping timeout: 250 seconds] 10:18 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 10:18 -!- mikehu44 [~quassel@206.189.41.250] has quit [Client Quit] 10:21 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 10:24 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 10:30 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has joined #bitcoin-core-dev 10:32 -!- arythmetic [~arythmeti@38.112.106.67] has joined #bitcoin-core-dev 10:38 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has quit [Ping timeout: 256 seconds] 10:50 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:58 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has joined #bitcoin-core-dev 11:03 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [] 11:05 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has quit [Quit: Client closed] 11:10 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has joined #bitcoin-core-dev 11:10 -!- sirdigby727 [uid523338@id-523338.lymington.irccloud.com] has joined #bitcoin-core-dev 11:15 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 11:15 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 11:15 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has quit [Ping timeout: 256 seconds] 11:15 -!- jtrag [~jtrag@user/jtrag] has quit [Quit: Fuck y'all I'm out dis bitch! ✌️ out yo!] 11:19 -!- chris23lngr [~chris23ln@2a02:908:742:6460:c403:932d:323a:fb8] has joined #bitcoin-core-dev 11:20 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 11:20 < chris23lngr> hey everyone, i have some questions on bitcoin. Can anyone help? 11:22 -!- chris23lngr [~chris23ln@2a02:908:742:6460:c403:932d:323a:fb8] has quit [Client Quit] 11:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:22 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15861: Restore warning for individual unknown version bits, as well as unknown version schemas (master...restore_vbits_warning) https://github.com/bitcoin/bitcoin/pull/15861 11:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:22 -!- jb55 [~jb55@S0106606c634dbdd3.vc.shawcable.net] has quit [Ping timeout: 256 seconds] 11:28 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has joined #bitcoin-core-dev 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:29 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #23731: [RFC] wallet: Always prefer bech32(m) change by default (master...2112-walletChangeChange) https://github.com/bitcoin/bitcoin/pull/23731 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:40 -!- zonemix [~zonemix@138.247.240.137] has quit [Remote host closed the connection] 11:41 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:43 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/c09b41dc665b...216f4ca9e7cc 11:43 < bitcoin-git> bitcoin/master 9b2fdca glozow: [packages] add static IsChildWithParents function 11:43 < bitcoin-git> bitcoin/master ba26169 glozow: [unit test] context-free package checks 11:43 < bitcoin-git> bitcoin/master d59ddc5 glozow: [packages/doc] define and document package rules 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:43 < bitcoin-git> [bitcoin] laanwj merged pull request #22674: validation: mempool validation and submission for packages of 1 child + parents (master...package-child-with-parents) https://github.com/bitcoin/bitcoin/pull/22674 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:45 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 11:48 -!- esats [~esats@2601:47:4383:560:9c91:d395:c278:8723] has quit [Quit: Client closed] 11:49 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:50 -!- masta`` [~oyster@user/masta/x-2645138] has joined #bitcoin-core-dev 11:51 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 11:51 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 11:52 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 11:53 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 11:56 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 250 seconds] 12:05 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 12:05 -!- shiza is now known as pink_sarco 12:06 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection] 12:07 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 12:08 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 12:08 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:08 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev 12:10 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 12:12 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection] 12:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #23789: wallet: Strictly match in TransactionChangeType to improve privacy [skip ci] [ci skip] (master...2112-walletChangeChange) https://github.com/bitcoin/bitcoin/pull/23789 12:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:20 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 265 seconds] 12:25 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Ping timeout: 276 seconds] 12:30 < ariard> yeah maybe a bit quick to land #22674 with only one ack on tip, i'll have a post-merge look :) 12:30 <@gribble> https://github.com/bitcoin/bitcoin/issues/22674 | validation: mempool validation and submission for packages of 1 child + parents by glozow · Pull Request #22674 · bitcoin/bitcoin · GitHub 12:31 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Quit: No Ping reply in 180 seconds.] 12:31 < ariard> though i'm too blame to not review back faster 12:31 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 12:34 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 12:34 -!- yanmaani1 is now known as yanmaani 12:35 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 12:36 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 12:36 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 12:37 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 12:39 -!- kexkey [~kexkey@static-198-54-132-137.cust.tzulo.com] has joined #bitcoin-core-dev 12:43 -!- emzy [~quassel@user/emzy] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 12:53 < laanwj> lots of previous ACKs though 12:54 < laanwj> if you only look at acks on tip you're punishing people for actually listing to nits 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:56 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/216f4ca9e7cc...fee16b15fa34 12:56 < bitcoin-git> bitcoin/master 66a20a5 Hennadii Stepanov: build, qt: Drop support for `i686-linux-android` host 12:56 < bitcoin-git> bitcoin/master fee16b1 W. J. van der Laan: Merge bitcoin/bitcoin#23744: build, qt: Drop support for i686-linux-androi... 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:56 < bitcoin-git> [bitcoin] laanwj merged pull request #23744: build, qt: Drop support for i686-linux-android host (master...211211-android32) https://github.com/bitcoin/bitcoin/pull/23744 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:57 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 12:58 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 12:59 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev 12:59 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 13:00 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev 13:01 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 13:02 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 252 seconds] 13:03 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 13:06 < MarcoFalke> Maybe the merge script could include previous ACKs if they are "close enough" to the tip? 13:10 < laanwj> yes, though that's hard to judge programmatically 13:16 < MarcoFalke> or just a list of all stale ACKs without "judgement" 13:18 < laanwj> right 13:18 < luke-jr> but then if something bad gets merged, someone who ACK'd a version without it might not appreciate the "blame" 13:19 < luke-jr> perhaps just list them with " (stale)" on the end or smth 13:19 < luke-jr> might be nice to include the commit hash they did ACK too, but then it gets long 13:19 < MarcoFalke> right, I mean a separate section with stale ACKs 13:20 -!- sirdigby727 [uid523338@id-523338.lymington.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:22 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 13:28 -!- littlesh [~Username@bras-base-clwdon2201w-grc-48-174-89-150-139.dsl.bell.ca] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:29 -!- nat [~nat@nazareth.nekopon.pl] has quit [Quit: ZNC 1.8.2 - https://znc.in] 13:29 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 13:30 -!- nat [~nat@nazareth.nekopon.pl] has joined #bitcoin-core-dev 13:31 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 13:31 -!- emzy [~quassel@user/emzy] has quit [Ping timeout: 250 seconds] 13:32 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev 13:38 -!- nat [~nat@nazareth.nekopon.pl] has quit [Quit: ZNC 1.8.2 - https://znc.in] 13:39 -!- nat [~nat@nazareth.nekopon.pl] has joined #bitcoin-core-dev 13:41 -!- masta`` [~oyster@user/masta/x-2645138] has quit [Read error: Connection reset by peer] 13:57 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 14:02 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 14:07 -!- arythmetic [~arythmeti@38.112.106.67] has quit [Remote host closed the connection] 14:15 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 14:31 -!- roconnor [~roconnor@coq/roconnor] has joined #bitcoin-core-dev 14:34 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:41 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 14:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 14:47 -!- ozawa [~ozawa@cpe-98-14-66-91.nyc.res.rr.com] has joined #bitcoin-core-dev 14:49 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has quit [Quit: ZzzZ] 15:02 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 15:07 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:13 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 15:19 -!- zonemix [~zonemix@216.16.35.204] has quit [Remote host closed the connection] 15:19 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 15:21 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 15:25 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:26 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 250 seconds] 15:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 15:33 < jeremyrubin> TBH i think we should allow addressing nits in follow up PRs 15:33 < jeremyrubin> i don't think unsquashed fixup commits are a worse burden on the code than the risk of uncareful re-reviews 15:34 < jeremyrubin> might be a minority on that opinion though 15:37 < lightlike> Isn't that allowed already? It seems to happen regularly with larger PRs that nits are addressed in follow-ups. 15:39 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 15:42 -!- roconnor [~roconnor@coq/roconnor] has quit [Ping timeout: 250 seconds] 15:42 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:44 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 256 seconds] 15:49 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 15:53 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 15:56 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 15:59 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 16:05 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-core-dev 16:05 -!- Topic for #bitcoin-core-dev: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 16:05 -!- Topic set by laanwj [] [Sat May 22 03:05:22 2021] 16:05 [Users #bitcoin-core-dev] 16:05 [@gribble ] [ devrandom ] [ jarolrod ] [ Murch[m] ] [ ryanofsky ] 16:05 [ _0x0ff ] [ dhruv ] [ javi404 ] [ murrayn ] [ sandipndev123 ] 16:05 [ _aj_ ] [ dodo ] [ jb55 ] [ nanotube ] [ sanket1729_ ] 16:05 [ _flood ] [ dougefish ] [ jeremyrubin ] [ nat ] [ sanket_cell_ ] 16:05 [ achow101 ] [ dvd ] [ jetpack ] [ nathanael ] [ schmidty ] 16:05 [ ademan[m] ] [ earnestly ] [ jkczyz ] [ Nebraskka ] [ sdaftuar1 ] 16:05 [ ajonas ] [ elichai2 ] [ jnewbery ] [ neha ] [ sebx2a ] 16:05 [ Alina-malina ] [ emzy ] [ johnzweng ] [ Neojack ] [ sipa ] 16:05 [ amiti ] [ Enki[m] ] [ jonasschnelli_] [ nickler ] [ siv2r[m] ] 16:05 [ andrewtoth_ ] [ Evel-Knievel] [ jonatack ] [ niska ] [ SpellChecker ] 16:05 [ andytoshi ] [ Evolver ] [ joshuajbouw ] [ noonien ] [ stevenroose ] 16:05 [ Ara ] [ ExEric3 ] [ josibake ] [ notmandatory_ ] [ stick ] 16:05 [ ariard ] [ face ] [ jrawsthorne ] [ ogola ] [ stick[m] ] 16:05 [ awesome_doge ] [ fanquake ] [ jrayhawk ] [ otoburb ] [ stickies-v ] 16:05 [ b10c ] [ FelixWeis ] [ kakolainen[m] ] [ outfox ] [ sturles ] 16:05 [ baakeydow ] [ fjahr ] [ kanzure ] [ ozawa ] [ sugarpuff_ ] 16:05 [ bcdarc ] [ Flow ] [ kcalvinalvin ] [ paairs ] [ takinbo ] 16:05 [ belcher ] [ freesprung ] [ Keele ] [ panpan_ ] [ TallTim ] 16:05 [ berndj ] [ geyaeb ] [ kexkey ] [ paulo ] [ TheCharlatan ] 16:05 [ bfsfhkacjzgcytf] [ gleb74 ] [ kinlo ] [ phantomcircuit] [ TheRec ] 16:05 [ blkncd ] [ glozow ] [ kvaciral[m] ] [ pigeons ] [ theStack ] 16:05 [ BlueMatt ] [ glozow[m] ] [ laanwj ] [ pinheadmz ] [ tinova ] 16:05 [ boxframes ] [ gnaf ] [ larryruane ] [ pink_sarco ] [ tla2k21 ] 16:05 [ bw ] [ gnusha ] [ lightlike ] [ provoostenator] [ tripleslash ] 16:05 [ cfields_ ] [ GoldmanSats ] [ lightningbot ] [ qubenix ] [ uasf ] 16:05 [ chaotic_good_ ] [ greypw254 ] [ Lightsword ] [ r-ush ] [ upekkha ] 16:05 [ cmirror ] [ grubman9001 ] [ livestradamus ] [ raj ] [ vasild ] 16:05 [ cncr04s ] [ gwillen ] [ lsilva_ ] [ real_or_random] [ vincenzopalazzo] 16:05 [ cold ] [ harding ] [ luke-jr ] [ realies ] [ warren ] 16:05 [ Common ] [ hebasto ] [ MarcoFalke ] [ roasbeef ] [ willcl_ark ] 16:05 [ core-meetingbot] [ helo_ ] [ MatanHamilis ] [ robertspigler ] [ windsok ] 16:05 [ cotsuka ] [ hendi ] [ mekster669 ] [ robot-dreams ] [ x88x88x ] 16:05 [ cryptapus ] [ Henry151 ] [ merkle_noob[m]] [ rockhouse ] [ yakshaver ] 16:05 [ da2ce7 ] [ hirish_ ] [ meshcollider ] [ rodarmor ] [ ZeroMaster ] 16:05 [ darosior ] [ hsmiths ] [ michaelfolkson] [ ron-slc ] 16:05 [ deanguss ] [ hugohn ] [ mjdietzx ] [ RoyBatty ] 16:05 [ dergoegge ] [ Jackielove4u] [ moneyball_ ] [ RubenSomsen ] 16:05 -!- Irssi: #bitcoin-core-dev: Total of 182 nicks [1 ops, 0 halfops, 0 voices, 181 normal] 16:05 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev 16:05 -!- Channel #bitcoin-core-dev created Wed May 19 06:52:47 2021 16:05 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev 16:05 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-core-dev 16:06 -!- jespada [~jespada@87.74.33.157] has joined #bitcoin-core-dev 16:07 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 16:07 -!- Irssi: Join to #bitcoin-core-dev was synced in 133 secs 16:07 -!- M0xb10c[m] [~M0xb10cni@2001:470:69fc:105::bac4] has joined #bitcoin-core-dev 16:07 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-core-dev 16:08 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 16:10 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 16:12 -!- Victorsueca [~Victorsue@user/victorsueca] has joined #bitcoin-core-dev 16:14 -!- infernix [~nix@155.137.21.90] has joined #bitcoin-core-dev 16:14 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving] 16:14 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 16:26 -!- EPiSKiNG- [~EPiSKiNG-@episking.com] has joined #bitcoin-core-dev 16:33 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 256 seconds] 16:34 -!- roconnor [~roconnor@coq/roconnor] has joined #bitcoin-core-dev 16:49 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 16:52 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev 16:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 17:02 < jeremyrubin> well it's always kind of a negotiation of if the nits need to be addressed here or later. part of the joy of having a guideline on how to handle is that there's a default answer. 17:02 < jeremyrubin> I think we may even get better quality code, because right now i don't nit things i don't want to bother the author to fix given the costs of re-review 17:04 < sipa> occasionally i don't bother leaving nits on the PRs directly, but make a follow-up PR myself after it's merged. 17:10 < jeremyrubin> i think that's reasonable -- no nits, but just fix it yourself as a follow up. they who nit-it fix-it? 17:21 < luke-jr> I planned to do that with NAT-PMP but never got around to it :x 17:21 -!- ozawa [~ozawa@cpe-98-14-66-91.nyc.res.rr.com] has quit [Quit: Connection closed] 17:22 -!- b10c [uid500648@ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 17:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 17:52 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 18:03 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 18:04 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 18:09 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 18:09 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 18:12 -!- jtrag [~jtrag@user/jtrag] has quit [Ping timeout: 250 seconds] 18:13 -!- ozawa [~ozawa@cpe-98-14-66-91.nyc.res.rr.com] has joined #bitcoin-core-dev 18:21 -!- zonemix [~zonemix@216.16.35.204] has quit [Read error: Connection reset by peer] 18:21 -!- zonemix_ [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 18:30 < ariard> laanwj: yeah sad with the premature merge of 22674, commit e12fafd was added on the last push and not previously reviewed, you have a good chunk of context with implications for the rest of package relay support imho :( 18:30 < ariard> nice if past reviewers can re-look on that 18:39 < laanwj> okay, sorry 18:41 < laanwj> yes i screwed up well it's the last PR i'll merge for a while 18:45 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 18:48 < laanwj> and reverting e12fafd would make sense then (better to do it as a new PR) 18:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:53 < bitcoin-git> [bitcoin] laanwj opened pull request #23793: validation: Revert "de-duplicate package transactions already in mempool" (master...2021-12-revert-package-dedup) https://github.com/bitcoin/bitcoin/pull/23793 18:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:58 < laanwj> there 19:00 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 250 seconds] 19:02 < laanwj> oh, it isn't possible to revert it by itself, revert the entire PR then? 19:05 < laanwj> ok: it introduces MempoolAcceptResult::ResultType::MEMPOOL_ENTRY which is used in the commit after it, but that's only tests, could remove or comment out the test for now 19:15 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 19:18 < laanwj> done that 19:24 -!- zonemix_ [~zonemix@216.16.35.204] has quit [Remote host closed the connection] 19:25 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 19:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:35 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 19:49 -!- zonemix [~zonemix@216.16.35.204] has quit [Remote host closed the connection] 19:49 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 20:15 -!- zonemix [~zonemix@216.16.35.204] has quit [Remote host closed the connection] 20:16 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 20:17 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has quit [Remote host closed the connection] 20:22 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 240 seconds] 20:32 -!- tla2k21 [~tla2k21@gateway/tor-sasl/tla2k21] has joined #bitcoin-core-dev 20:44 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 20:50 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev 20:51 -!- ozawa [~ozawa@cpe-98-14-66-91.nyc.res.rr.com] has quit [Quit: Connection closed] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:08 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 21:10 -!- mikehu44 [~quassel@206.189.41.250] has joined #bitcoin-core-dev 21:31 -!- jtrag [~jtrag@user/jtrag] has quit [Ping timeout: 268 seconds] 21:36 -!- mikehu44 [~quassel@206.189.41.250] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 21:47 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 268 seconds] 22:16 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 22:22 -!- zonemix [~zonemix@216.16.35.204] has quit [Ping timeout: 240 seconds] 22:29 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-dev 22:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:35 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 22:47 -!- zonemix [~zonemix@216.16.35.204] has joined #bitcoin-core-dev 22:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fee16b15fa34...98c362a4d3d8 22:49 < bitcoin-git> bitcoin/master 71115a5 seaona: test: include two more interruptions points 22:49 < bitcoin-git> bitcoin/master 618f4d2 seaona: test: re-organized array according to order of logs and included 2 more in... 22:49 < bitcoin-git> bitcoin/master 98c362a MarcoFalke: Merge bitcoin/bitcoin#23782: test: include two more interruptions points 22:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23782: test: include two more interruptions points (master...2021-12-feature-init-test-interruptions) https://github.com/bitcoin/bitcoin/pull/23782 22:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 23:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:43 -!- freesprung [~freesprun@user/freesprung] has quit [Ping timeout: 260 seconds] 23:44 -!- freesprung [~freesprun@user/freesprung] has joined #bitcoin-core-dev 23:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/98c362a4d3d8...a30642926a5e 23:45 < bitcoin-git> bitcoin/master 4807f73 w0xlt: refactor: Implement restorewallet() logic in the wallet section 23:45 < bitcoin-git> bitcoin/master abbb7ec w0xlt: refactor: Move restorewallet() RPC logic to the wallet section 23:45 < bitcoin-git> bitcoin/master 62fa61f w0xlt: refactor: remove the wallet folder if the restore fails 23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:46 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23721: wallet, refactor: Move restorewallet() logic to the wallet section (master...restore_wallet_gui) https://github.com/bitcoin/bitcoin/pull/23721 23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a30642926a5e...ce463cf45053 23:48 < bitcoin-git> bitcoin/master 65efbba Antoine Poinsot: rpcwallet: mention labels are deactivated for ranged descriptors 23:48 < bitcoin-git> bitcoin/master ce463cf MarcoFalke: Merge bitcoin/bitcoin#23750: rpcwallet: mention labels are disabled for ra... 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23750: rpcwallet: mention labels are disabled for ranged descriptors (master...no_label_range_descriptors) https://github.com/bitcoin/bitcoin/pull/23750 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:51 -!- gleb74 [~gleb@178.150.137.228] has quit [Quit: Ping timeout (120 seconds)] 23:52 -!- gleb74 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce463cf45053...df6e961c417b 23:57 < bitcoin-git> bitcoin/master e4a8d56 Martin Zumsande: doc: add explanations for assert in index and magic numbers in test 23:57 < bitcoin-git> bitcoin/master df6e961 MarcoFalke: Merge bitcoin/bitcoin#23777: doc: follow-ups from #23365 (index backwards ... 23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #23777: doc: follow-ups from #23365 (index backwards search) (master...202112_index_followups) https://github.com/bitcoin/bitcoin/pull/23777 23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] --- Log closed Thu Dec 16 00:00:02 2021