--- Log opened Thu Feb 03 00:00:48 2022 00:06 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] 00:06 -!- Guest40 [~Guest40@2405:201:4018:91bc:94b1:20ea:b798:aeb7] has joined #bitcoin-core-dev 00:09 -!- Guest40 [~Guest40@2405:201:4018:91bc:94b1:20ea:b798:aeb7] has quit [Client Quit] 00:13 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 00:23 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:29 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:41 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:44 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 01:02 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds] 01:04 -!- goatpig [~goat@176-184-135-134.abo.bbox.fr] has joined #bitcoin-core-dev 01:22 < Guest> I am new to git.. I am trying to push a commit regarding this (https://github.com/bitcoin/bitcoin/issues/20576) .. I am getting this message when I am trying to push the code remote: Permission to bitcoin/bitcoin.git denied to anshu-khare-design .. 01:23 < Guest> My commit branch is different from master branch 01:23 < fanquake> This isn't a how-to-use git / github support channel 01:29 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 01:34 -!- mudsip [~mudsip@user/mudsip] has quit [] 02:03 -!- kexkey [~kexkey@static-198-54-132-126.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 02:06 -!- kexkey [~kexkey@static-198-54-132-94.cust.tzulo.com] has joined #bitcoin-core-dev 02:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:26 < bitcoin-git> [bitcoin] anshu-khare-design opened pull request #24247: Issue 20576 (master...issue_20576) https://github.com/bitcoin/bitcoin/pull/24247 02:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:42 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] 03:23 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:620a] has quit [Changing host] 03:23 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev 03:28 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 03:43 -!- Guest [~Guest@223.226.228.254] has quit [Quit: Client closed] 03:44 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 03:54 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:57 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 03:57 -!- Guyver2_ is now known as Guyver2 04:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:21 < bitcoin-git> [bitcoin] laanwj opened pull request #24250: Update translations for 0.23 string freeze (master...2022-02-english-translation) https://github.com/bitcoin/bitcoin/pull/24250 04:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:23 -!- goatpig [~goat@176-184-135-134.abo.bbox.fr] has quit [Ping timeout: 240 seconds] 04:26 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 04:27 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 276 seconds] 04:30 < laanwj> fanquake: agree, it's not even a "building bitcoin core" support channel 04:31 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 250 seconds] 04:31 < laanwj> it's fine to ask questions about specific weird issues here but it's a development discussion channel, not a hand-holding channel, please see the topic 04:34 < laanwj> that said, you should push to your own remote (clone) of the repository, not to the upstream one, that's not allowed for obvious reasons :) 04:51 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 04:56 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 276 seconds] 05:11 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 05:11 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 05:12 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 05:15 -!- goatpig [~goat@176-184-135-134.abo.bbox.fr] has joined #bitcoin-core-dev 05:35 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds] 05:36 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] 05:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c98c:16e0:a06f:367a] has quit [Remote host closed the connection] 05:45 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 05:45 -!- pavanj [~pavanj@2409:4042:2380:b43d:7830:e390:d945:a142] has joined #bitcoin-core-dev 06:01 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 06:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 06:13 -!- jespada [~jespada@87.74.36.188] has quit [Ping timeout: 256 seconds] 06:13 -!- pavanj is now known as pavanjs 06:14 -!- pavanjs is now known as pavanj 06:15 -!- jespada [~jespada@87.74.36.188] has joined #bitcoin-core-dev 06:19 -!- pavanj [~pavanj@2409:4042:2380:b43d:7830:e390:d945:a142] has quit [Quit: Leaving] 06:34 -!- pavanj [~pavanj@2409:4042:2380:b43d:7830:e390:d945:a142] has joined #bitcoin-core-dev 06:35 < pavanj> Hello! I am Pavan. Looking forward to contribute to this Community 06:36 < sipa> Hello Pavan! 06:38 < pavanj> It will be great, if someone can assign me any Beginner task or good first issue on which I can work on. 06:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Remote host closed the connection] 06:48 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c194293883fb...3ace3a17c9bc 06:53 < bitcoin-git> bitcoin/master ffc89d1 fanquake: build: add support for std::filesystem 06:53 < bitcoin-git> bitcoin/master 41d7166 Kiminuo: refactor: replace boost::filesystem with std::filesystem 06:53 < bitcoin-git> bitcoin/master b87f9c5 Kiminuo: build: remove boost::filesystem usage 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20744: Use std::filesystem. Remove Boost Filesystem & System (master...use_std_filesystem) https://github.com/bitcoin/bitcoin/pull/20744 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 < hebasto> \o/ 06:58 < Earnestly> hmm 07:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 07:06 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 07:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 250 seconds] 07:14 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:14 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 07:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 07:41 -!- tralfaz [~davterra@143.198.56.186] has quit [Ping timeout: 250 seconds] 07:41 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev 07:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 256 seconds] 07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:46 < bitcoin-git> [bitcoin] ryanofsky opened pull request #24251: Re-enable windows path tests disabled by #20744 (master...pr/wp) https://github.com/bitcoin/bitcoin/pull/24251 07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:53 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 07:54 -!- pavanj [~pavanj@2409:4042:2380:b43d:7830:e390:d945:a142] has quit [Ping timeout: 240 seconds] 07:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:55 < bitcoin-git> [bitcoin] ryanofsky opened pull request #24252: bench: Represent paths with fs::path instead of std::string (master...pr/bp) https://github.com/bitcoin/bitcoin/pull/24252 07:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:02 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev 08:03 -!- davterra [~davterra@143.198.56.186] has quit [Ping timeout: 256 seconds] 08:07 < Earnestly> nice, it builds 08:16 -!- mikehu44 [~quassel@159.65.11.175] has quit [Ping timeout: 256 seconds] 08:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 08:18 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 08:19 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 08:19 < cfields> woohoo, cya boost (file)system! 08:19 < Earnestly> This is nice trend 08:20 < sipa> Your services are no longer required. 08:20 < sipa> (we hope) 08:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 250 seconds] 08:22 < MarcoFalke> Likely will have to re-introduce boost system on Ubuntu Bionic, but let's see 08:23 -!- JimBer110 [~jimmy@83-233-132-57.cust.bredband2.com] has joined #bitcoin-core-dev 08:24 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 08:25 -!- JimBer110 [~jimmy@83-233-132-57.cust.bredband2.com] has quit [Client Quit] 08:29 -!- pavanj [~pavanj@2409:4042:2699:66e8:2965:6379:1901:bb9] has joined #bitcoin-core-dev 08:30 -!- pavanj [~pavanj@2409:4042:2699:66e8:2965:6379:1901:bb9] has quit [Client Quit] 08:32 -!- pavanj [~pavanj@2409:4042:2699:66e8:2965:6379:1901:bb9] has joined #bitcoin-core-dev 08:47 < stick> what's the oldest version of debian and ubuntu we aim to support? 08:48 < stick> debian 9 is still supported by upstream; do we support debian 9? 08:49 -!- pavanj [~pavanj@2409:4042:2699:66e8:2965:6379:1901:bb9] has quit [Quit: Leaving] 08:50 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 256 seconds] 08:50 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 08:50 < hebasto> debian 9 has boost 1.62, so building depends required 08:52 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 08:52 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 08:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 09:27 < MarcoFalke> stick: See #24164 09:27 <@gribble> https://github.com/bitcoin/bitcoin/issues/24164 | build: Bump minimum required clang/libc++ to 8.0 by MarcoFalke · Pull Request #24164 · bitcoin/bitcoin · GitHub 09:27 < MarcoFalke> They all ship with clang-10 or better, so you can build from depends 09:37 < stick> MarcoFalke: thanks, makes sense 09:49 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 09:59 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Remote host closed the connection] 10:06 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 10:09 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 10:18 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 10:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 10:32 -!- mikehu44 [~quassel@159.65.11.175] has quit [Ping timeout: 256 seconds] 10:33 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 10:34 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 10:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Remote host closed the connection] 10:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 10:46 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 10:59 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 11:00 < laanwj> #startmeeting 11:00 < core-meetingbot`> Meeting started Thu Feb 3 19:00:04 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 11:00 < core-meetingbot`> Available commands: action commands idea info link nick 11:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Remote host closed the connection] 11:00 < dongcarl> hello 11:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 11:00 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 11:00 < jonatack> hi 11:00 < provoostenator> hi 11:00 < hebasto> hi 11:00 < achow101> hi 11:00 < sipa> hi 11:00 < laanwj> there have been no proposed meeting topics this week (this can be done using #proposedmeetingtopic ), any last-minute ones? 11:00 < michaelfolkson> hi 11:01 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 11:01 < MarcoFalke> hi 11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24253: Remove broken and unused CDataStream methods (master...2202-s) https://github.com/bitcoin/bitcoin/pull/24253 11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:02 < cfields> hi 11:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 11:03 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 11:03 < warren> hi 11:03 < laanwj> PSA: today the string freeze for 0.23 started, after #24250 is merged i'll open the translations 11:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/24250 | Update translations for 0.23 string freeze by laanwj · Pull Request #24250 · bitcoin/bitcoin · GitHub 11:03 < jeremyrubin> Gm 11:04 < laanwj> #topic High priority for review 11:04 < core-meetingbot`> topic: High priority for review 11:04 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 -- only 6 blockers left 11:04 < kanzure> hi 11:04 < b10c> hi 11:04 < sipa> i'd like to suggest #23542 for high priority (or really, for trying to get it in v23) 11:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/23542 | net: open p2p connections to nodes that listen on non-default ports by vasild · Pull Request #23542 · bitcoin/bitcoin · GitHub 11:05 < laanwj> sipa: added (and added 23.0 milestone) 11:05 < sipa> Thanks! 11:05 < jonatack> #23604 has 4 acks 11:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/23604 | Use Sock in CNode by vasild · Pull Request #23604 · bitcoin/bitcoin · GitHub 11:06 < jonatack> sipa: +1 11:06 < laanwj> jonatack: great! 11:07 < laanwj> anything else to add, remove or that is (almost) ready for merge? 11:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 256 seconds] 11:08 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 11:09 < laanwj> the boost::filesystem removal was merged today, i'd recommend testing the current master branch on as many platforms and operating systems as you can to make sure any issues come to light 11:09 < sipa> Good idea. 11:09 < warren> That was the last boost dependency? 11:09 < laanwj> i don't expect anything but you never know! 11:09 < michaelfolkson> Presumably #22558 shouldn't get 23.0 milestone? Not much review yet 11:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/22558 | psbt: Taproot fields for PSBT by achow101 · Pull Request #22558 · bitcoin/bitcoin · GitHub 11:10 < michaelfolkson> Would be nice to get some Taproot stuff in 23.0 but obviously needs review 11:10 < laanwj> warren: there's still signals2, which is quite easy to replace, and boost::multi_index, which is not 11:10 < sipa> warren: We have lots of boost dependencies still, but most are headers-only 11:10 < sipa> or all? 11:10 < warren> Is it a goal to get rid of boost eventually? 11:10 < laanwj> sipa: afaik yes 11:10 < hebasto> all are headers only except for Boost.Test 11:10 < sipa> warren: I don't care about getting rid of headers-only ones. 11:11 < luke-jr> no 11:11 < sipa> They're just a build-time dependency. 11:11 < laanwj> ah yes, boost::test, didn't count that one as it's test only 11:11 < laanwj> right, there's no real hurry, though signals2 is kinda ugly due to the enormous backtraces it generates 11:11 < sipa> boost::multi_index in particular would be a major engineering challenge to replace with anything similar in functionality 11:12 < laanwj> yeah... might just import that one :) 11:12 < MarcoFalke> Someone should shepherd multi_index into C++26 11:12 < laanwj> in any case, it's fine, would be good if it was behind a pimpl though so it didn't get imported into every other file 11:13 < laanwj> MarcoFalke: yea! 11:13 < sipa> right 11:14 < laanwj> michaelfolkson: not sure really, if it makes 23.0 it makes 23.0, but i'm not sure it makes sense to specialy label it for that 11:14 < jonatack> could #24165 be tagged for v23? 11:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/24165 | p2p: extend inbound eviction protection by network to CJDNS peers by jonatack · Pull Request #24165 · bitcoin/bitcoin · GitHub 11:15 < jonatack> vasild and i are coordinating to propose a doc/cjdns.md for v23 as well 11:15 < sipa> cool 11:15 < laanwj> if it's unlikely to make it, it shouldn't be added to the milestone, generally nothing but critical fixes actually blocks a release anyway 11:15 < laanwj> jonatack: will do 11:15 < jonatack> thanks! 11:16 < laanwj> jonatack: concept ACK, though, should keep it compact imo, i don't think we should end up with extensive documentation about setting up all kind of overlay network in our repo 11:17 < laanwj> granted, tor.md is pretty big but that's mainly because we have a lot of configurability related to tor 11:18 < jonatack> laanwj: yes. the main thing people seem to trip up on when getting started is the find a friend part (myself included). 11:18 < laanwj> jonatack: yes, that's always the difficult part :) 11:19 < Murch> #proposedmeetingtopic sweep vs subtract-fee-from-output 11:19 < laanwj> i hope cjdns.md will help some people find friends :p 11:19 < jonatack> :))) 11:19 < sipa> Murch: For this meeting, or wallet meeting? 11:20 < michaelfolkson> Has to wait a week if it is wallet meeting :) 11:20 < Murch> Pieter: If this meeting runs out of topics, I'd be happy to talk about it here, but otherwise wallet meeting is fine, too. 11:21 < laanwj> we're out of topic right now, so, happy to take it 11:21 < Murch> Okay 11:21 < laanwj> #topic sweep vs subtract-fee-from-output (Murch) 11:21 < core-meetingbot`> topic: sweep vs subtract-fee-from-output (Murch) 11:21 < warren> summary writeup of this anywhere? 11:21 < Murch> achow101 and I have been looking into implementing a Sweep RPC in https://github.com/bitcoin/bitcoin/pull/24118 11:22 < Murch> The main motivation is that SFFO creates a bunch of issues for coin selection and makes testing more complex 11:23 < Murch> Our impression was that the main use case for SFFO was to perform sweeps and to spend the full balance of wallet 11:23 < Murch> This was at least the cited reasons in #4331 when it was proposed. 11:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/4331 | Subtract fee from amount by cozz · Pull Request #4331 · bitcoin/bitcoin · GitHub 11:23 < laanwj> it's useful for sending entire utxos to another wallet 11:24 < Murch> laanwj: We intend for sweep to also allow specifying input UTXOs 11:24 < Murch> It's not in the current iteration, but something we want to do in a follow-up 11:24 < laanwj> i've used it pretty often and never for sweeps 11:24 < jeremyrubin> very much supportive of sweep and getting rid of SFFO; generally speaking if i am trying to pay someone 10000 sats and they get 9999, that might not be a valid payment anymore. SFFO seems like a huge footgun. 11:24 < laanwj> the target might not be a bitcoin core wallet (e.g. c-lightning, joinmarket, etc) 11:25 < provoostenator> We could call it "sendcoins" instead of sweep, but potato potato 11:25 < warren> I've used SFFO often to selectively combine only specific UTXO's where I don't want change outputs. It seems strange if that's taken away. 11:25 < laanwj> it's not useful for sending to other people, agree 11:25 < Murch> laanwj: Could you describe the use case that leads to an SFFO payment? 11:25 < Murch> We've been trying to figure out what people use it for. 11:25 < laanwj> Murch: coinjoin, sending an entire utxo without generating an extra change input 11:25 < laanwj> or combining a bunch of utxos 11:26 < provoostenator> Murch: sending 1 UTXO to an exchange 11:26 < laanwj> it's good for privacy generally to not generate change 11:26 < Murch> laanwj: So if you could specify a set of UTXOs in sweep, that seems to be covered 11:26 < laanwj> especially if your utxos are already not linked 11:26 < provoostenator> And to not combine coins from different source 11:26 < laanwj> right 11:26 < jeremyrubin> laanwj: altho not generating change is also a privacy leak itself 11:27 < laanwj> jeremyrubin: it's kind of subtle 11:27 < Murch> jeremyrubin: Not when you have multiple recipients. ;) 11:27 < laanwj> Murch: can you sweep to another address or set of addresses? 11:27 < jeremyrubin> laanwj: if you're one of the only people in the world with this pattern rn, i may be able to find you ;) 11:28 < sipa> using SFFO to construct the spending of specific UTXOs without change is kind of a roundabout way of doing it... it's essentially trying to trick the coin selection into doing what you want, rather that just not doing coin selection at all 11:28 < provoostenator> jeremyrubin: that's what on chain dobbelgangers are for, I'm sure you can hire those. 11:28 < Murch> laanwj: Yes, the rpc takes multiple addresses of which at least one must not specify an amount and gets the remainder. If multiple are unspecified, it splits equally. 11:28 < laanwj> jeremyrubin: sigh, sure, we can't really talk about use-cases here and this whole discussion is moot 11:28 -!- prayank [~Prayank@45.64.9.48] has joined #bitcoin-core-dev 11:29 < warren> Several users I recruited over the years use SFFO with multiple outputs to obscure which output is payment further making the amounts sent not round numbers. But I've personally used it to avoid creating change outputs when sending to myself or to other people were exact amounts don't matter or they're willing to eat the tx fee as part of the bargain. 11:29 < jeremyrubin> laanwj: didn't mean to badger you, just a reminder that 'good for privacy' depends on the behavior being widespread generating anonymity set. 11:29 < Murch> Another use case we've gotten feedback about on Twitter was that you "can make the receiver pay the fees". This seems like a roundabout way of making the receiver take a risk on how large a transaction is going to be, and would imho be better implemented by deducting a flat amount. 11:30 < provoostenator> I don't have strong feelings about what it should look like under the hood. But the current manual coin selection GUI works fine for it. 11:30 < prayank> This was the thread: https://nitter.net/achow101/status/1488624425285079048 11:30 < laanwj> in any case, i do like the sffo functionality, and would be sad to see it go 11:30 < laanwj> roundabout way or not 11:30 < provoostenator> Murch: or just setting the fee to 1 sat/byte? 11:30 < Murch> Mh, okay, noted. 11:30 < laanwj> i'm fine if it only works with manual coin control 11:31 < _aj_> maybe don't deprecate until the "specifying input UTXOs" part is done? 11:31 < warren> +1 provoostenator I like the current coin control GUI and option for SFFO I use almost always. How it works under the hood is a different matter. 11:31 < Murch> provoostenator: I'm not sure I follow 11:31 < laanwj> and skips coin selection 11:31 < sipa> _aj_: I'd assume that'd be the case 11:31 < jonatack> if SFFO includes the subtractfeefromamount option in RPCs like sendtoaddress, i find it useful when someone wants to buy btc, sets the feerate, and pays the fee 11:31 < provoostenator> Murch: if the recipient wants to CPFP you can just use a low fee rate 11:31 < laanwj> warren: right-i suspect it's pretty much always used with manual coin control 11:31 < jeremyrubin> laanwj: what about just being able to generate a transaction automatically and then modify it to deduct the fees manually from the outputs you want to deduct? 11:31 < Murch> provoostenator: That requires sending a second transaction, though. 11:32 < _aj_> #24142 11:32 <@gribble> https://github.com/bitcoin/bitcoin/issues/24142 | Deprecate SubtractFeeFromOutputs by achow101 · Pull Request #24142 · bitcoin/bitcoin · GitHub 11:32 < laanwj> jeremyrubin: i like it's user friendly and easy to use now 11:32 < provoostenator> Indeed limiting it to manual coin selection would be fine by me too 11:32 < provoostenator> So basically if you select any coins, we don't auto select more. 11:32 < warren> +1 11:32 < achow101> apparently bull bitcoin (an exchange) uses sffo to make their users pay the fee if they want to opt out of batched transactions. limiting to manual would break that use case 11:32 < laanwj> sure, i know how to make manual transactions and subtract fee etc, but having to compute things manually sucks compared to just using the interface 11:33 < cfields> +1 11:33 < jonatack> +1 11:33 < provoostenator> achow101: Murch: oh now it makes sense 11:33 < jeremyrubin> i think subtracting fees could be done in a user friendly 11:33 < cfields> jeremyrubin: Indeed I've done that several times. 11:33 < jeremyrubin> like 10 - x works in e.g. GIMP 11:33 < jeremyrubin> (for computing pixels or whatever) 11:33 < provoostenator> So they're "paying" by just lowering the amount they receive? 11:34 < laanwj> it's clearly controversial to remove this functionality 11:35 < achow101> indeed 11:35 < laanwj> not arguing against adding a sweep RPC, but i think proposing it to replace sffo is getting ahead of things 11:35 < warren> +1 11:35 < Murch> Right, thanks for the feedback! 11:35 < achow101> i guess we need to unbreak sffo first 11:35 -!- prayank [~Prayank@45.64.9.48] has left #bitcoin-core-dev [] 11:36 < Murch> Indeed 11:36 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev 11:36 < Murch> Alright, this was very helpful (even if not the outcome I was hoping for 0:-)) 11:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 11:38 < laanwj> any other topics? 11:39 < laanwj> looks like not, thanks for attending, closing the meeting 11:39 < laanwj> #endmeeting 11:39 < core-meetingbot`> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:39 < core-meetingbot`> Meeting ended Thu Feb 3 19:39:50 2022 UTC. 11:39 < core-meetingbot`> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-02-03-19.00.moin.txt 11:40 < dongcarl> thanks for hosting laanwj! 11:41 < laanwj> Murch: fwiw "sweep specified utxos to one or multiple addresses (with amounts, or that receive the rest)" covers all my usecases 11:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 250 seconds] 11:43 < Murch> That's what we propose for sweep. 11:46 < Murch> FWICT, there just remains one case that we cannot cover which is sending to a recipient using the amount owed to them as the budget. 11:47 < jeremyrubin> Murch: would it help if you had a min / max for a recipient? 11:48 -!- bitcoin1o1 [~bitcoin1o@189.194.249.94] has joined #bitcoin-core-dev 11:48 < achow101> I think that would make things worse 11:48 < jeremyrubin> achow101: ok then we should do it ;) 11:49 * jeremyrubin ducks 12:02 -!- bitcoin1o1 [~bitcoin1o@189.194.249.94] has quit [Ping timeout: 256 seconds] 12:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 12:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 250 seconds] 12:18 -!- goatpig [~goat@176-184-135-134.abo.bbox.fr] has quit [Remote host closed the connection] 12:20 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 12:21 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 12:26 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:27 -!- gnaf [gnaf@gateway/vpn/protonvpn/gnaf] has joined #bitcoin-core-dev 12:29 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 12:30 -!- jespada [~jespada@87.74.36.188] has quit [Ping timeout: 256 seconds] 12:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 12:32 -!- jespada [~jespada@87.74.36.188] has joined #bitcoin-core-dev 12:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 12:40 -!- tralfaz [~davterra@143.198.56.186] has quit [Ping timeout: 256 seconds] 12:45 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 240 seconds] 12:51 -!- Guest1 [~Guest1@h-5-150-220-142.A785.priv.bahnhof.se] has joined #bitcoin-core-dev 12:51 -!- Guest1 [~Guest1@h-5-150-220-142.A785.priv.bahnhof.se] has quit [Client Quit] 12:58 -!- bitcoin1o1 [~bitcoin1o@189.194.249.94] has joined #bitcoin-core-dev 13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:07 < bitcoin-git> [bitcoin] hebasto opened pull request #24254: build: Add Boost.Process link check (master...220203-bp) https://github.com/bitcoin/bitcoin/pull/24254 13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:16 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds] 13:16 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 13:17 -!- gleb74543861 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 13:18 -!- gleb7454386 [~gleb@178.150.137.228] has quit [Ping timeout: 256 seconds] 13:18 -!- gleb74543861 is now known as gleb7454386 13:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 240 seconds] 14:01 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 14:06 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 14:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 14:10 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:10 -!- jespada [~jespada@87.74.36.188] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:12 -!- jespada [~jespada@87.74.36.188] has joined #bitcoin-core-dev 14:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:17 < bitcoin-git> [bitcoin] achow101 closed pull request #24142: Deprecate SubtractFeeFromOutputs (master...deprecate-sffo) https://github.com/bitcoin/bitcoin/pull/24142 14:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:21 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 15:22 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds] 15:39 -!- jarthur [~jarthur@2603-8080-1540-002d-7df6-2fc1-a099-d746.res6.spectrum.com] has joined #bitcoin-core-dev 15:44 -!- bitcoin1o1 [~bitcoin1o@189.194.249.94] has quit [Ping timeout: 256 seconds] 15:49 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 256 seconds] 15:52 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 15:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Remote host closed the connection] 16:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 16:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Remote host closed the connection] 16:30 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 16:33 -!- dviola [~diego@187.39.23.21] has joined #bitcoin-core-dev 16:34 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 16:35 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:35 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 16:36 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 16:37 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 16:39 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 16:47 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 16:47 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 16:49 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 16:51 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 16:53 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev 16:54 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 16:56 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 16:56 -!- dviola [~diego@187.39.23.21] has quit [Ping timeout: 240 seconds] 16:57 -!- dviola [~diego@187.39.23.21] has joined #bitcoin-core-dev 17:07 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 17:11 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 17:17 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 17:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:27 < bitcoin-git> [bitcoin] fanquake opened pull request #24256: [22.x] ci: Backport CentOS 8 (22.x...backport_centos_8) https://github.com/bitcoin/bitcoin/pull/24256 17:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:36 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 17:38 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 17:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 17:44 -!- davterra [~davterra@143.198.56.186] has quit [Ping timeout: 256 seconds] 17:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 256 seconds] 18:11 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 18:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 18:23 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 268 seconds] 18:29 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 18:29 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 18:34 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:39 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 18:47 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 18:54 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 18:57 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:06 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev 19:11 -!- Common_ [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 19:14 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 240 seconds] 19:14 -!- kexkey [~kexkey@static-198-54-132-94.cust.tzulo.com] has quit [Ping timeout: 256 seconds] 19:16 -!- kexkey [~kexkey@static-198-54-132-110.cust.tzulo.com] has joined #bitcoin-core-dev 19:17 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 19:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 240 seconds] 19:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 19:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 240 seconds] 20:01 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 20:12 -!- Guest53 [~Guest53@8.8.229.108] has joined #bitcoin-core-dev 20:14 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 20:15 -!- Guest53 [~Guest53@8.8.229.108] has quit [Client Quit] 20:20 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 20:21 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 20:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 240 seconds] 20:33 -!- sloorush [~sloorush@2405:201:301b:9018:6b92:da2d:b3f:4135] has joined #bitcoin-core-dev 20:37 -!- sloorush [~sloorush@2405:201:301b:9018:6b92:da2d:b3f:4135] has quit [Quit: Bye Bye!] 20:37 -!- sloorush [~sloorush@2405:201:301b:9018:6b92:da2d:b3f:4135] has joined #bitcoin-core-dev 20:37 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [] 20:43 -!- pavanj [~pavanj@2409:4042:2699:66e8:c0f6:2e41:55af:2183] has joined #bitcoin-core-dev 20:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 20:46 -!- davterra [~davterra@143.198.56.186] has quit [Ping timeout: 256 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 250 seconds] 21:49 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:50 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 22:25 -!- Cory [~Cory@user/pasha] has quit [Ping timeout: 240 seconds] 22:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has joined #bitcoin-core-dev 22:56 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 256 seconds] 23:23 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev 23:24 -!- pavanj [~pavanj@2409:4042:2699:66e8:c0f6:2e41:55af:2183] has quit [Quit: Leaving] 23:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:19d9:43e6:a650:2946] has quit [Ping timeout: 256 seconds] 23:48 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 23:58 -!- boxframes [~Saloframe@2607:9000:2000:15::a45d] has joined #bitcoin-core-dev --- Log closed Fri Feb 04 00:00:49 2022