--- Log opened Wed Feb 16 00:00:00 2022 00:05 -!- paulo [paulo@user/paulo/x-9032687] has quit [Ping timeout: 250 seconds] 00:08 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 00:10 -!- Neozul [Neozul@109.136.19.223] has joined #bitcoin-core-dev 00:14 -!- paulo [paulo@user/paulo/x-9032687] has joined #bitcoin-core-dev 00:24 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:27 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 00:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:39 < bitcoin-git> [bitcoin] kristapsk opened pull request #24353: RPC: Return external_signer command in getwalletinfo (master...getwalletinfo-external_signer-2) https://github.com/bitcoin/bitcoin/pull/24353 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:41 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:45 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 00:50 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 00:50 -!- anrichp [~anrichp@82-68-12-63.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-dev 00:51 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:57 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #24295: Remove std::move from fs wrapper to work around -D_LIBCPP_DEBUG=1 bug (master...2202-bug) https://github.com/bitcoin/bitcoin/pull/24295 00:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 01:09 -!- goatpig [~goat@2a01cb000fbd4200fde0d2b50e4978e7.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 01:26 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Ping timeout: 256 seconds] 01:41 -!- Guest16 [~Guest16@240d:1a:1b1:dc00:6dc5:5d90:8cb1:7949] has joined #bitcoin-core-dev 01:42 -!- Guest16 [~Guest16@240d:1a:1b1:dc00:6dc5:5d90:8cb1:7949] has quit [Client Quit] 01:52 < laanwj> i meannn it's the same discussion every time but clearly bitcoin and cryptocurrency is still experimental on several levels, which makes it useful as a warning/disclaimer, and also not in some other ways, it's really not worth getting into that discussion over a single word in the documentation 01:53 < laanwj> better to ask yourself why it matters to you why that word is there 01:53 -!- goatpig_ [~goat@2a01cb068009259f08c07850c5f8f366.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 01:53 -!- goatpig [~goat@2a01cb000fbd4200fde0d2b50e4978e7.ipv6.abo.wanadoo.fr] has quit [Ping timeout: 252 seconds] 01:55 < laanwj> if it makes you more careful, it's good to have 01:58 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 01:58 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 02:02 -!- Neozul [Neozul@109.136.19.223] has quit [Remote host closed the connection] 02:04 -!- kexkey [~kexkey@static-198-54-132-118.cust.tzulo.com] has quit [Ping timeout: 252 seconds] 02:06 -!- kexkey [~kexkey@static-198-54-132-102.cust.tzulo.com] has joined #bitcoin-core-dev 02:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:49 -!- Victorsueca [~Victorsue@user/victorsueca] has joined #bitcoin-core-dev 02:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 02:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 02:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 03:00 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:08 -!- Guest71 [~Guest71@203.110.242.42] has joined #bitcoin-core-dev 03:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 03:24 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:26 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds] 03:26 -!- Guyver2_ is now known as Guyver2 03:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 03:48 -!- goatpig_ [~goat@2a01cb068009259f08c07850c5f8f366.ipv6.abo.wanadoo.fr] has quit [Read error: Connection reset by peer] 03:50 -!- goatpig_ [~goat@2a01cb000fbd4200fde0d2b50e4978e7.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 03:53 -!- Guest71 [~Guest71@203.110.242.42] has quit [Quit: Client closed] 03:57 -!- ronoaldo [~ronoaldo@187.75.45.227] has quit [Quit: Konversation terminated!] 03:58 -!- ronoaldo [~ronoaldo@187.75.45.227] has joined #bitcoin-core-dev 04:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 04:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 04:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 04:43 -!- goatpig_ [~goat@2a01cb000fbd4200fde0d2b50e4978e7.ipv6.abo.wanadoo.fr] has quit [Read error: Connection reset by peer] 04:44 -!- goatpig [~goat@2a01cb000fbd4200fde0d2b50e4978e7.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 04:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 05:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 05:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:01 < bitcoin-git> [bitcoin] hebasto opened pull request #24355: util, refactor: Add UNIQUE_NAME helper macro (master...220216-unique) https://github.com/bitcoin/bitcoin/pull/24355 05:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:01 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] dev7ba closed pull request #24318: doc: ZMQ documentation fix regarding topics (master...zmqDocFix) https://github.com/bitcoin/bitcoin/pull/24318 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:10 -!- mikehu44 [~quassel@159.65.11.175] has quit [Ping timeout: 256 seconds] 05:14 -!- goatpig [~goat@2a01cb000fbd4200fde0d2b50e4978e7.ipv6.abo.wanadoo.fr] has quit [Quit: Konversation terminated!] 05:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 05:24 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 05:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 05:41 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev 05:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 05:53 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 05:56 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 252 seconds] 06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:03 < bitcoin-git> [bitcoin] vasild opened pull request #24356: refactor: replace CConnman::SocketEvents() with mockable Sock::WaitMany() (master...WaitMany) https://github.com/bitcoin/bitcoin/pull/24356 06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 06:11 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:20 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 06:20 -!- goatpig [~goat@2a01cb068009259f08c07850c5f8f366.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 06:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 06:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 06:37 -!- paulo [paulo@user/paulo/x-9032687] has quit [Ping timeout: 240 seconds] 06:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 06:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 06:44 -!- paulo [paulo@user/paulo/x-9032687] has joined #bitcoin-core-dev 06:58 -!- RepeatedNonce [~RepeatedN@49.204.142.3] has joined #bitcoin-core-dev 06:59 -!- bit-pleb-paul [~bit-pleb-@24.225.251.48] has joined #bitcoin-core-dev 06:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 07:00 -!- bit-pleb-paul [~bit-pleb-@24.225.251.48] has quit [Client Quit] 07:09 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:12 < bitcoin-git> [bitcoin] vasild opened pull request #24357: refactor: make setsockopt() and SetSocketNoDelay() mockable/testable (master...mockable_SetSocketNoDelay_and_setsockopt) https://github.com/bitcoin/bitcoin/pull/24357 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:14 -!- RepeatedNonce [~RepeatedN@49.204.142.3] has quit [Quit: Client closed] 07:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 07:32 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 07:53 -!- realies [~realies@user/realies] has quit [Ping timeout: 252 seconds] 08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:03 < bitcoin-git> [bitcoin] 0xB10C opened pull request #24358: test: USDT tracepoint interface tests (master...2022-02-tracepoint-tests-a) https://github.com/bitcoin/bitcoin/pull/24358 08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:10 < ronoaldo> laanwj: that makes sense! that word means a lot comming from the maintainers, that is why I was asking. 08:29 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 08:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 08:55 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:59 -!- ziggie [uid521459@user/ziggie] has joined #bitcoin-core-dev 09:00 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 09:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 09:03 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 09:03 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 09:06 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 09:07 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 09:15 -!- Franklin [~Franklin@197.210.55.60] has joined #bitcoin-core-dev 09:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 09:19 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Remote host closed the connection] 09:19 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-dev 09:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 09:26 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 09:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 09:28 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:31 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 09:33 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 09:37 -!- Franklin [~Franklin@197.210.55.60] has quit [Quit: Client closed] 09:38 -!- Franklin [~Franklin@197.210.227.23] has joined #bitcoin-core-dev 09:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 09:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 09:48 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 09:50 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:54 < bitcoin-git> [bitcoin] acktsap opened pull request #24359: node, wallet: Fix 'the the' in comments (master...fix-the-the-comment) https://github.com/bitcoin/bitcoin/pull/24359 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:55 < bitcoin-git> [bitcoin] jonatack opened pull request #24360: doc: improve -netinfo help based on feedback from users and devs (master...netinfo-doc-improvements) https://github.com/bitcoin/bitcoin/pull/24360 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:57 -!- Franklin [~Franklin@197.210.227.23] has quit [Ping timeout: 256 seconds] 10:00 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [] 10:01 -!- Franklin [~Franklin@197.210.227.23] has joined #bitcoin-core-dev 10:03 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 10:10 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 10:16 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 10:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 10:29 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 10:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 10:31 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 10:35 -!- Franklin [~Franklin@197.210.227.23] has quit [Ping timeout: 256 seconds] 10:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:38 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 10:41 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 10:45 -!- jarthur [~jarthur@2603-8080-1540-002d-3498-71fb-df6e-0b01.res6.spectrum.com] has joined #bitcoin-core-dev 10:59 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 11:03 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 11:09 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 11:13 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 252 seconds] 11:24 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 11:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 11:29 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 11:30 -!- zxrqmz88 [~private@2603-7000-1302-b6f3-c512-c11f-d285-8ab2.res6.spectrum.com] has joined #bitcoin-core-dev 11:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 11:36 -!- zxrqmz88 [~private@2603-7000-1302-b6f3-c512-c11f-d285-8ab2.res6.spectrum.com] has quit [Quit: Quit] 11:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 11:39 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 11:41 -!- goatpig [~goat@2a01cb068009259f08c07850c5f8f366.ipv6.abo.wanadoo.fr] has quit [Read error: Connection reset by peer] 11:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:44 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 272 seconds] 12:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:05 < bitcoin-git> [bitcoin] dongcarl closed pull request #24332: [kernel 2/n] Decouple from `netaddress`+`asmap`, parts of `timedata`+`init/common` (master...2022-02-libbitcoinkernel-p2-minimal) https://github.com/bitcoin/bitcoin/pull/24332 12:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 12:14 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 12:16 -!- emcy [~emcy@user/emcy] has quit [Read error: Connection reset by peer] 12:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 12:16 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 12:17 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 272 seconds] 12:17 -!- lukedashjr is now known as luke-jr 12:20 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 12:27 -!- Skyz [~Skyz@user/skyz] has joined #bitcoin-core-dev 12:42 -!- gleb7454386 [~gleb@178.150.137.228] has quit [Ping timeout: 256 seconds] 12:42 -!- gleb7454386 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 12:42 -!- kexkey [~kexkey@static-198-54-132-102.cust.tzulo.com] has quit [Ping timeout: 256 seconds] 12:46 -!- kexkey [~kexkey@static-198-54-132-120.cust.tzulo.com] has joined #bitcoin-core-dev 12:46 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 12:47 < jonatack> hebasto: regarding #24338 haven't been able to make the new tests fail without the fix commit....with debian testing, tried compiling with an older gcc 8 (Debian 8.4.0-7). Any tips? 12:47 <@gribble> https://github.com/bitcoin/bitcoin/issues/24338 | util: Work around libstdc++ create_directories issue by laanwj · Pull Request #24338 · bitcoin/bitcoin · GitHub 12:48 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 272 seconds] 12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:49 < bitcoin-git> [bitcoin] sipa opened pull request #24361: Descriptor unit tests and simplifications (master...202202_desctests) https://github.com/bitcoin/bitcoin/pull/24361 12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:50 < hebasto> jonatack: could you check changelog for your compiler? maybe it has been patched? 12:51 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 13:12 < jonatack> hebasto: thanks, hm maybe, don't see the PR number in the output of `apt changelog gcc-8` locally but there is surely a better way to search 13:13 < hebasto> jonatack:: sorry, my bad 13:14 < hebasto> debian testing has libstdc++ patched 13:14 < hebasto> I mean, not compiler 13:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 13:23 -!- asdfsfdasdfw [~asdfsfdas@12.182.213.210] has joined #bitcoin-core-dev 13:30 < jonatack> hebasto: thanks 13:30 < hebasto> yw :) 13:30 < jonatack> :) 13:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Remote host closed the connection] 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:36 < bitcoin-git> [bitcoin] achow101 opened pull request #24362: wallet: Do not match legacy addresses for change type (master...rm-legacy-change) https://github.com/bitcoin/bitcoin/pull/24362 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:38 -!- Skyz [~Skyz@user/skyz] has quit [Quit: Client closed] 13:38 -!- asdfsfdasdfw [~asdfsfdas@12.182.213.210] has left #bitcoin-core-dev [Closing Window] 13:47 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:50 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 14:03 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 14:04 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 14:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 14:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 14:28 -!- anrichp [~anrichp@82-68-12-63.dsl.in-addr.zen.co.uk] has quit [Read error: Connection reset by peer] 14:39 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 14:39 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] 14:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 14:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:47 < bitcoin-git> [bitcoin] hebasto opened pull request #24363: ci: Catch assertion error message into logs for test_bitcoin.exe (master...220216-assert) https://github.com/bitcoin/bitcoin/pull/24363 14:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:21 -!- gossie [~gossie@2001:1c02:11e:c700:4a28:456f:cfe0:5c8e] has quit [Ping timeout: 252 seconds] 15:22 -!- gossie [~gossie@2001:1c02:11e:c700:c824:f8ed:a210:e662] has joined #bitcoin-core-dev 15:25 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 15:35 -!- robot-dreams [sid463268@id-463268.uxbridge.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- stick [sid403625@user/prusnak] has quit [Ping timeout: 245 seconds] 15:35 -!- hugohn [sid304114@id-304114.lymington.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- josibake [sid509132@id-509132.helmsley.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- lightlike [sid521075@user/lightlike] has quit [Read error: Connection reset by peer] 15:35 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- amiti [sid373138@id-373138.lymington.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- josibake [sid509132@id-509132.helmsley.irccloud.com] has joined #bitcoin-core-dev 15:35 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #bitcoin-core-dev 15:35 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- GoldmanSats [sid428607@id-428607.ilkley.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- amiti [sid373138@id-373138.lymington.irccloud.com] has joined #bitcoin-core-dev 15:35 -!- GoldmanSats [sid428607@id-428607.ilkley.irccloud.com] has joined #bitcoin-core-dev 15:35 -!- sugarpuff_ [sid92283@id-92283.lymington.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has quit [Read error: Connection reset by peer] 15:35 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has quit [Read error: Connection reset by peer] 15:36 -!- sugarpuff_ [sid92283@id-92283.lymington.irccloud.com] has joined #bitcoin-core-dev 15:36 -!- bw [sid2730@user/betawaffle] has quit [Read error: Connection reset by peer] 15:36 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-core-dev 15:36 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has joined #bitcoin-core-dev 15:36 -!- ajonas [sid385278@2a03:5180:f:1::5:e0fe] has joined #bitcoin-core-dev 15:36 -!- robot-dreams [sid463268@2a03:5180:f:5::7:11a4] has joined #bitcoin-core-dev 15:36 -!- hugohn [sid304114@2a03:5180:f:2::4:a3f2] has joined #bitcoin-core-dev 15:36 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has joined #bitcoin-core-dev 15:36 -!- jarolrod [sid475272@2a03:5180:f:5::7:4088] has joined #bitcoin-core-dev 15:36 -!- stick [sid403625@user/prusnak] has joined #bitcoin-core-dev 15:36 -!- larryruane [sid473749@2a03:5180:f:5::7:3a95] has joined #bitcoin-core-dev 15:36 -!- lightlike [sid521075@user/lightlike] has joined #bitcoin-core-dev 15:37 -!- bw [sid2730@user/betawaffle] has joined #bitcoin-core-dev 15:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 15:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 15:54 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 15:54 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Read error: Connection reset by peer] 16:01 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 16:02 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 16:08 -!- jamesob [~jamesob@pool-108-31-54-223.washdc.fios.verizon.net] has quit [Quit: Ping timeout (120 seconds)] 16:09 -!- jamesob [~jamesob@pool-108-31-54-223.washdc.fios.verizon.net] has joined #bitcoin-core-dev 16:10 -!- bcdarc_ [~bcdarc@4.53.92.114] has joined #bitcoin-core-dev 16:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds] 16:10 -!- Nebraskka_ [~Nebraskka@user/nebraskka] has joined #bitcoin-core-dev 16:11 -!- hirish_ [~hirish@ip85.ip-137-74-20.eu] has joined #bitcoin-core-dev 16:11 -!- hirish [~hirish@ip85.ip-137-74-20.eu] has quit [Ping timeout: 256 seconds] 16:11 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Ping timeout: 256 seconds] 16:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 16:12 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 16:14 -!- bcdarc [~bcdarc@4.53.92.114] has quit [Ping timeout: 250 seconds] 16:15 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #bitcoin-core-dev 16:15 -!- Nebraskka_ [~Nebraskka@user/nebraskka] has quit [Ping timeout: 240 seconds] 16:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 16:37 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 16:37 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 16:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 16:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 17:04 -!- S3RK [~S3RK@user/s3rk] has quit [Ping timeout: 256 seconds] 17:06 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev 17:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:42 -!- ronoaldo [~ronoaldo@187.75.45.227] has quit [Quit: Konversation terminated!] 17:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 17:56 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:03 -!- m011 [sid489830@id-489830.helmsley.irccloud.com] has quit [Quit: Updating details, brb] 18:03 -!- l_sx01 [sid489830@id-489830.helmsley.irccloud.com] has joined #bitcoin-core-dev 18:12 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 18:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 18:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:20 < bitcoin-git> [bitcoin] jamesob opened pull request #24364: refactor: remove duplicate code from BlockAssembler (master...2022-02-ba-dup-code) https://github.com/bitcoin/bitcoin/pull/24364 18:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 18:35 -!- kexkey [~kexkey@static-198-54-132-120.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 18:36 -!- kexkey [~kexkey@static-198-54-132-56.cust.tzulo.com] has joined #bitcoin-core-dev 18:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 18:40 -!- kexkey [~kexkey@static-198-54-132-56.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 18:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 18:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:56 < roasbeef> hey y'all, been finishing up my taproot impl over the past few days, the generated test vectors are amazing so kudos to all that contributed there 18:56 < roasbeef> also the BIP text is superb as well, though I think certain statements/ordering in BIP 342 when it comes to the checksig ops are ambigious 18:56 < roasbeef> for example this line: 18:56 < roasbeef> > For OP_CHECKSIGVERIFY, execution continues without any further changes to the stack. 18:57 < roasbeef> my original interpretation was the the verify op now doesn't pop anything from teh stack and just leaves it there, w/ the new behavior being to only exit if the sig is invalid 18:57 < roasbeef> however test case 44b2a5681330965efa5dadccd65e4296cb9bb54c showed be that isn't the case, and the op is effectively unchanged (checksigverify) 18:57 < roasbeef> what do y'all think of modifying that line to something like this 18:58 < roasbeef> > For CHECKSIGVERIFY, execution continues as normal 18:58 < roasbeef> here's the full test case for the curious: https://0bin.net/paste/XpC38DR4#sv006mN7nCzfWBRls5+Yuk90gsevJ67-uS73aXuNcV7 19:09 < sipa> @roasbeef No objection, if you feel that would have helped. 19:20 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 19:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 240 seconds] 19:54 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-dev 19:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:58 < bitcoin-git> [bitcoin] achow101 opened pull request #24365: wallet: Don't generate keys for wallets with private keys disabled during upgradewallet (master...upgrade-disable-privkeys) https://github.com/bitcoin/bitcoin/pull/24365 19:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:00 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection] 20:00 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev 20:01 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection] 20:01 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev 20:02 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection] 20:02 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev 20:03 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection] 20:03 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev 20:04 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection] 20:04 -!- Bikram [~Bikram@103.220.88.193] has joined #bitcoin-core-dev 20:04 -!- Bikram [~Bikram@103.220.88.193] has quit [Client Quit] 20:23 -!- RepeatedNonce [~RepeatedN@49.205.80.205] has joined #bitcoin-core-dev 20:32 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 20:36 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:44 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 272 seconds] 20:44 -!- RepeatedNonce [~RepeatedN@49.205.80.205] has quit [Quit: Client closed] 20:48 -!- dviola [~diego@187.39.23.21] has joined #bitcoin-core-dev 20:58 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Read error: Connection reset by peer] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:04 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving] 21:24 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 21:28 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] 21:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 21:56 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 22:00 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Read error: Connection reset by peer] 22:08 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev 22:12 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 22:25 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 240 seconds] 22:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has quit [Ping timeout: 252 seconds] 22:38 -!- mikehu44 [~quassel@159.65.11.175] has quit [Read error: Connection reset by peer] 22:39 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 22:50 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 22:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9d7:c243:f6c3:1ebf] has joined #bitcoin-core-dev 22:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1e8aa02ec5cc...b304b657828c 22:59 < bitcoin-git> bitcoin/master ba4906f Taeik Lim: doc: Fix typos 22:59 < bitcoin-git> bitcoin/master b304b65 MarcoFalke: Merge bitcoin/bitcoin#24359: doc: Fix typos 22:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24359: doc: Fix typos (master...fix-the-the-comment) https://github.com/bitcoin/bitcoin/pull/24359 22:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b304b657828c...03c8c6937ee0 23:03 < bitcoin-git> bitcoin/master 37af8a2 Jon Atack: Add missing thread safety lock assertions in validation.cpp 23:03 < bitcoin-git> bitcoin/master f485a07 Jon Atack: Add missing thread safety lock assertions in validation.h 23:03 < bitcoin-git> bitcoin/master 03c8c69 MarcoFalke: Merge bitcoin/bitcoin#24177: validation, refactor: add missing thread safe... 23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24177: validation, refactor: add missing thread safety lock assertions (master...add-missing-lock-assertions-in-validation) https://github.com/bitcoin/bitcoin/pull/24177 23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:08 -!- kcalvinalvin [~kcalvinal@ec2-3-38-183-204.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev 23:31 -!- kcalvinalvin [~kcalvinal@ec2-3-38-183-204.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 23:39 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.] --- Log closed Thu Feb 17 00:00:01 2022