--- Log opened Thu Mar 10 00:00:21 2022 00:01 < ziggie> jeremyrubin> e.g. fill-or-kill-by-date? Yes 00:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 00:03 < laanwj> from what i remember one significant problem with that was fragility under reorg conditions; e.g. a reorg would put the transactions in different blocks, possibly making all transactions after the locked transaction invalid because it's expired 00:04 < sipa> One problem with that is that it isn't reorg-safe: in an (innocent) reorg, if the transaction got confirmed and had descendants, and can't get into the replacement block by the same height/time, it gets invalidated along with all its children. 00:05 < sipa> Another is that it makes reasoning about confirmations much harder for wallets as the timeout point gets closer, because you need to reason about probabilities of it getting confirmed before that time. 00:08 < MarcoFalke> sdaftuar: (re CI failure) The CI is re-run every week on all pull requests to catch silent merge conflict early. This will also mean that the usual false positives (like network errors) might be hit during the re-run. In your instance, it looks like GitHub went down (https://cirrus-ci.com/task/5260393814687744?logs=ci#L2031) so it is fine to just re-run. 00:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 00:14 < laanwj> provoostenator: it's probably been screaming that for half a year or so :) (depending on when you upgraded tor to a post-v2 version) 00:15 < ziggie> thank you 00:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 00:23 < laanwj> provoostenator: so that leaves two ways to go (1) strip tor and rudimentary I2P support from the crawler (2) add both (e.g. https://github.com/sipa/bitcoin-seeder/issues/92), both are valid ways to go depending on what is deemed to be the scope of it (and whoever implements it) 00:24 < sipa> I think over time we should implement (2), and also change it from publishing through DNS to just listening on Bitcoin P2P and responding to getaddr. 00:24 -!- NorrinRadd [~username@105.112.37.77] has joined #bitcoin-core-dev 00:25 < laanwj> sipa: thanks, yes that makes sense 00:26 < sipa> that way it isn't restricted to a single port, can convey service flags, etc... 00:29 -!- NorrinRadd [~username@105.112.37.77] has quit [Read error: Connection reset by peer] 00:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 00:31 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev 00:31 -!- NorrinRadd [~username@102.67.16.112] has quit [Client Quit] 00:32 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev 00:34 -!- ifeanyi24 [~ifeanyi@154.72.167.9] has joined #bitcoin-core-dev 00:35 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:40 -!- NorrinRadd [~username@102.67.16.112] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:40 -!- ifeanyi24 [~ifeanyi@154.72.167.9] has quit [Ping timeout: 256 seconds] 00:40 -!- ifeanyi [~ifeanyi@154.72.167.9] has quit [Ping timeout: 272 seconds] 00:50 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:fc46:f60:614b:bd] has joined #bitcoin-core-dev 00:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 00:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 01:01 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Ping timeout (120 seconds)] 01:02 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 01:03 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev 01:08 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 250 seconds] 01:08 < _aj_> sipa: i guess querying SRV records is still ugly compared to getaddrinfo 01:08 -!- harding [quassel@newmail.dtrt.org] has quit [Ping timeout: 252 seconds] 01:08 -!- harding [quassel@newmail.dtrt.org] has joined #bitcoin-core-dev 01:09 < sipa> I don't think there is a portable way of doing that (besides having your own DNS implementation) 01:15 -!- NorrinRadd [~username@102.67.16.112] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:17 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Read error: Connection reset by peer] 01:18 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 01:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/430acb7d2a32...5e33620ad813 01:26 < bitcoin-git> bitcoin/master a84650e klementtan: util: Fix ReadBinaryFile reading beyond maxsize 01:26 < bitcoin-git> bitcoin/master 5e33620 MarcoFalke: Merge bitcoin/bitcoin#24371: util: Fix `ReadBinaryFile` reading beyond max... 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24371: util: Fix `ReadBinaryFile` reading beyond maxsize (master...fix-readwritefile) https://github.com/bitcoin/bitcoin/pull/24371 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:28 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 01:31 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 01:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 01:45 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:45 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/cbdfb46b55a2...430808ab13d9 01:45 < bitcoin-git> bitcoin/23.x 4607f70 Ryan Ofsky: test: Add tests for GetArg methods / settings.json type coercion 01:45 < bitcoin-git> bitcoin/23.x 7e1b968 Ryan Ofsky: qt: Avoid crash on startup if int specified in settings.json 01:45 < bitcoin-git> bitcoin/23.x 430808a fanquake: Merge bitcoin/bitcoin#24511: [23.x] qt: Avoid crash on startup if int spec... 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:45 < bitcoin-git> [bitcoin] fanquake merged pull request #24511: [23.x] qt: Avoid crash on startup if int specified in settings.json (23.x...23.x-settings-json-crash) https://github.com/bitcoin/bitcoin/pull/24511 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:47 < bitcoin-git> [bitcoin] fanquake merged pull request #24514: [23.x] Second round signapple backports (M1) (23.x...second_round_signapple_backports) https://github.com/bitcoin/bitcoin/pull/24514 01:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 01:55 -!- NorrinRadd [~username@105.112.153.240] has joined #bitcoin-core-dev 01:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 01:59 -!- NorrinRadd [~username@105.112.153.240] has quit [Client Quit] 02:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 02:04 -!- kexkey [~kexkey@static-198-54-132-89.cust.tzulo.com] has quit [Ping timeout: 272 seconds] 02:06 -!- kexkey [~kexkey@static-198-54-132-153.cust.tzulo.com] has joined #bitcoin-core-dev 02:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 02:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5e33620ad813...05957a888de9 02:22 < bitcoin-git> bitcoin/master 20b6c87 Hennadii Stepanov: build: Specify `zeromq` port explicitly for MSVC builds 02:22 < bitcoin-git> bitcoin/master 7ff43e5 Hennadii Stepanov: ci: Invalidate vcpkg binary cache if dependencies changed 02:22 < bitcoin-git> bitcoin/master c3296b2 Hennadii Stepanov: build: Drop `double-conversion` from MSVC dependencies 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24516: build, ci: Fix MSVC builds and other improvements (master...220310-msvc-ci) https://github.com/bitcoin/bitcoin/pull/24516 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:25 < achow101> rc2 soon? 02:25 < fanquake> yes 02:27 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has joined #bitcoin-core-dev 02:28 * Willtech joined 02:40 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:43 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 272 seconds] 02:43 -!- Guyver2_ is now known as Guyver2 02:45 < jonatack> opened #24512 for 23.0, if anyone would like to tag it 02:45 <@gribble> https://github.com/bitcoin/bitcoin/issues/24512 | [23.x] init, doc: improve -onlynet help and related tor/i2p documentation by jonatack · Pull Request #24512 · bitcoin/bitcoin · GitHub 02:48 < jonatack> "TeresaHodges764" is spamming the bitcoin core repo 02:49 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:fc46:f60:614b:bd] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:49 < fanquake> they've already been blocked 02:49 < jonatack> thx 02:52 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:55 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/2bd5fdbceda5...71866d856679 02:55 < bitcoin-git> bitcoin/23.x 60ca24a laanwj: build: Bump to 23.0rc2 02:55 < bitcoin-git> bitcoin/23.x 71866d8 laanwj: doc: Update manual pages for rc2 02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:56 < bitcoin-git> [bitcoin] laanwj pushed tag v23.0rc2: https://github.com/bitcoin/bitcoin/compare/v23.0rc2 02:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:57 < fanquake> 🚀 02:58 < laanwj> jonatack: i'm not sure i understand the rationale for backporting that, i mean it's not risky but also isn't a bugfix 03:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 03:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 03:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 03:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:15 < bitcoin-git> [bitcoin] jonatack opened pull request #24519: doc: update multisig-tutorial.md to descriptor wallet by default (master...multisig-tutorial-update) https://github.com/bitcoin/bitcoin/pull/24519 03:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:15 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:16 < bitcoin-git> [bitcoin] fanquake opened pull request #24520: guix: only check for the macOS SDK once (master...check_macOS_SDK_one_time) https://github.com/bitcoin/bitcoin/pull/24520 03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 03:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:31 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05957a888de9...d1a940f729a7 03:31 < bitcoin-git> bitcoin/master e802310 fanquake: guix: only check for the macOS SDK once 03:31 < bitcoin-git> bitcoin/master d1a940f Andrew Chow: Merge bitcoin/bitcoin#24520: guix: only check for the macOS SDK once 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:31 < bitcoin-git> [bitcoin] achow101 merged pull request #24520: guix: only check for the macOS SDK once (master...check_macOS_SDK_one_time) https://github.com/bitcoin/bitcoin/pull/24520 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 03:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 03:46 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 03:47 -!- test_ is now known as _flood 03:50 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit] 03:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d1a940f729a7...76d44e832f5b 03:52 < bitcoin-git> bitcoin/master 2f5fd3c Ryan Ofsky: test: Correctly decode UTF-8 literal string paths 03:52 < bitcoin-git> bitcoin/master 76d44e8 MarcoFalke: Merge bitcoin/bitcoin#24469: test: Correctly decode UTF-8 literal string p... 03:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:52 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24469: test: Correctly decode UTF-8 literal string paths (master...pr/testu) https://github.com/bitcoin/bitcoin/pull/24469 03:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:54 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 04:04 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 04:05 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:06 < bitcoin-git> [bitcoin] hebasto closed pull request #24415: build: Fix Boost.Process test for Boost 1.78 (master...220222-boost) https://github.com/bitcoin/bitcoin/pull/24415 04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:08 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds] 04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:08 < bitcoin-git> [bitcoin] hebasto opened pull request #24521: build: Fix Boost.Process detection on macOS arm64 (master...220310-boost) https://github.com/bitcoin/bitcoin/pull/24521 04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:11 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 04:16 < jonatack> laanwj: oops having connection issues here. PR 24512 is to fix the -onlynet docs that are somewhat incorrect as a follow-up to the onlynet changes in v23, there is seemingly user confusion related to it and my thinking was that docs could be backported. happy to close too if it doesn't pass the backport bar :) 04:18 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 04:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:41 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76d44e832f5b...4f5d3ce5a059 04:41 < bitcoin-git> bitcoin/master 8ea6167 Sebastian Falbesoner: wallet: refactor: dedup sqlite blob binding 04:41 < bitcoin-git> bitcoin/master 4f5d3ce fanquake: Merge bitcoin/bitcoin#24486: wallet: refactor: dedup sqlite blob binding 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:41 < bitcoin-git> [bitcoin] fanquake merged pull request #24486: wallet: refactor: dedup sqlite blob binding (master...202203-wallet-refactor-dedup_sqlite_blob_binding) https://github.com/bitcoin/bitcoin/pull/24486 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:43 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 04:48 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 04:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 04:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 05:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:14 < bitcoin-git> [bitcoin] fanquake opened pull request #24522: ci: remove compiled-but-unused BDB from MSAN job (master...remove_unused_bdb_msan) https://github.com/bitcoin/bitcoin/pull/24522 05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:15 < bitcoin-git> [bitcoin] promag opened pull request #24523: build: Fix Boost.Process test for Boost 1.78 (master...220222-boost) https://github.com/bitcoin/bitcoin/pull/24523 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 05:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 05:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 05:27 < fanquake> detached signatures for rc2 and now pushed 05:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 05:42 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:43 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 05:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:57 -!- arythmetic [~arythmeti@201.192.159.130] has joined #bitcoin-core-dev 05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4f5d3ce5a059...6c37eae0ad94 05:58 < bitcoin-git> bitcoin/master faa1aec MarcoFalke: Remove confusing P1008R1 violation in ATMPArgs 05:58 < bitcoin-git> bitcoin/master 6c37eae fanquake: Merge bitcoin/bitcoin#24404: refactor: Remove confusing P1008R1 violation ... 05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:58 < bitcoin-git> [bitcoin] fanquake merged pull request #24404: refactor: Remove confusing P1008R1 violation in ATMPArgs (master...2202-cpp🥲) https://github.com/bitcoin/bitcoin/pull/24404 05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:05 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 06:07 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 06:15 -!- kmlroot [~kmlroot@193.36.224.203] has joined #bitcoin-core-dev 06:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:20 -!- kmlroot [~kmlroot@193.36.224.203] has quit [Quit: Client closed] 06:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:22 < bitcoin-git> [bitcoin] achow101 closed pull request #23534: wallet: Allow negative effective value inputs when subtracting fee from outputs (master...no-change-fee-w-sffo) https://github.com/bitcoin/bitcoin/pull/23534 06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c37eae0ad94...597ee30b5e23 06:24 < bitcoin-git> bitcoin/master 3566353 fanquake: ci: remove compiled-but-unused BDB from MSAN job 06:24 < bitcoin-git> bitcoin/master 597ee30 MarcoFalke: Merge bitcoin/bitcoin#24522: ci: remove compiled-but-unused BDB from MSAN ... 06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24522: ci: remove compiled-but-unused BDB from MSAN job (master...remove_unused_bdb_msan) https://github.com/bitcoin/bitcoin/pull/24522 06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] fanquake opened pull request #24524: doc: remove Boost LDFLAGS from netBSD build docs (master...remove_boost_ldflags) https://github.com/bitcoin/bitcoin/pull/24524 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 06:39 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Connection closed] 06:42 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 06:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 06:49 -!- jarthur [~jarthur@2603-8080-1540-002d-4da4-5828-7bb7-83bf.res6.spectrum.com] has joined #bitcoin-core-dev 06:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds] 06:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 06:54 < fanquake> I've checked thatt the M1 binary is correctly codesign, and runs on an M1 06:55 < fanquake> You still need to perform the Right-click and open step, due to it not being notarized. 06:56 < hebasto> fanquake: great! 06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:57 < bitcoin-git> [gui] hebasto merged pull request #563: qt: Remove network detection based on address in BIP21 (master...2022-03-remove-autodetect-code) https://github.com/bitcoin-core/gui/pull/563 06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:58 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/597ee30b5e23...93feabcb30e3 06:58 < bitcoin-git> bitcoin/master b7dbc83 laanwj: qt: Remove network detection based on address in BIP21 06:58 < bitcoin-git> bitcoin/master 93feabc Hennadii Stepanov: Merge bitcoin-core/gui#563: qt: Remove network detection based on address ... 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:58 < sdaftuar> MarcoFalke: thanks for the explanation! 07:00 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 07:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 07:03 -!- shesek [~shesek@user/shesek] has quit [Ping timeout: 252 seconds] 07:06 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 07:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 07:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 07:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 250 seconds] 07:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 07:14 -!- Common_ [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 07:16 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 240 seconds] 07:21 -!- Common__ [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 07:25 -!- Common_ [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 256 seconds] 07:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 07:29 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 07:31 -!- Common__ [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 256 seconds] 07:34 < sdaftuar> _aj_: for adding m_disable_tx to getpeerinfo() output -- do you have a viewpoint on whether we should expose the variable (which represents what the peer has sent us), or the idea (do we believe that transaction relay is disabled on this link)? 07:36 < sdaftuar> ie for peers that don't support disabletx, we might still think relay is disabled because (eg) we selected the peer to be block-relay-only and sent fRelay=0 and disabletx, and would disconnect if we received an inv. 07:37 < sdaftuar> anyway i could try to expose either of those ideas, just the variable is simplest but occurred to me that it might not be the most useful? unsure 07:40 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 07:46 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 07:47 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 07:54 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 07:54 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 07:57 < _aj_> sdaftuar: we've got relaytxes and connection_type=blocks-only already exposed, so just m_disable_tx status seems fine to me 08:04 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:06 < bitcoin-git> [bitcoin] fanquake opened pull request #24526: build: don't install deprecated libevent headers (master...dont_install_deprecated_libevent_headers) https://github.com/bitcoin/bitcoin/pull/24526 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 08:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 08:26 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 08:27 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 08:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 08:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:31 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 08:36 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 08:37 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 08:38 -!- davterra [~davterra@143.198.56.186] has quit [Quit: Leaving] 08:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 08:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 08:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 08:48 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 08:48 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 08:52 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 08:56 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:58 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 272 seconds] 08:58 -!- Guyver2_ is now known as Guyver2 09:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 09:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 09:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 09:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 09:22 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:23 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:31 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 09:31 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 09:36 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 09:38 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 09:54 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 09:54 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:56 < bitcoin-git> [bitcoin] hebasto closed pull request #23861: build: Update Guix build free space requirements (master...211224-kib) https://github.com/bitcoin/bitcoin/pull/23861 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:57 -!- arythmetic [~arythmeti@201.192.159.130] has quit [Remote host closed the connection] 09:57 -!- arythmetic [~arythmeti@201.192.159.130] has joined #bitcoin-core-dev 09:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 10:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 10:01 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 10:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 10:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 10:23 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 10:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 10:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 10:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 10:35 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 10:46 < jeremyrubin> do pruned nodes store block filters? 10:49 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 10:50 < lightlike> since #15946, they can 10:51 <@gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub 10:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 11:00 < MarcoFalke> hi 11:00 < laanwj> #startmeeting 11:00 < core-meetingbot`> Meeting started Thu Mar 10 19:00:15 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 11:00 < core-meetingbot`> Available commands: action commands idea info link nick 11:00 < jonatack> hi 11:00 < sdaftuar> hi 11:00 < michaelfolkson> hi 11:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 11:00 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 11:00 < dongcarl> hi 11:00 < sipa> hi 11:00 < kvaciral[m]> hi 11:00 < provoostenator> hi 11:00 < lightlike> hi 11:01 < hebasto> hi 11:01 < achow101> hi 11:01 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has quit [Quit: Willtech] 11:01 < laanwj> PSA: 23.0rc1 had some build issues, so 23.0rc2 was tagged today with fixes for that, please start your guix builds if you haven't yet 11:01 < jeremyrubin> hello 11:01 < darosior> hi 11:02 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has joined #bitcoin-core-dev 11:02 < laanwj> any topics for today? none have been proposed during the week with #proposedmeetingtopic, as far as i can see 11:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 11:02 < MarcoFalke> Can I haz #24080 for hi-prio pls? 11:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/24080 | policy: Remove unused locktime flags by MarcoFalke · Pull Request #24080 · bitcoin/bitcoin · GitHub 11:03 < laanwj> we're not at the high prio topic yet, but sure 11:03 < MarcoFalke> ups 11:03 < glozow> hi 11:04 < laanwj> #topic High priority for review 11:04 < core-meetingbot`> topic: High priority for review 11:04 < laanwj> MarcoFalke: added 11:04 < MarcoFalke> thx 11:04 < sipsorcery> hi 11:04 < provoostenator> I'd still like to get this into v23 if if survives more review: https://github.com/bitcoin-core/gui/pull/555 11:04 < provoostenator> (already tagged with the milestone, so I guess not high prio list needed) 11:04 < laanwj> is there anything else people want to add to high priority for review, or to remove, or that is ready for merge? 11:05 < dongcarl> Could I have #24322 for high prio? Will update within the next hour with the changes just discussed in #bitcoin-core-builds (shouldn't change much) 11:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub 11:05 -!- gnaf [gnaf@gateway/vpn/protonvpn/gnaf] has joined #bitcoin-core-dev 11:05 < laanwj> provoostenator: is that a bugfix? 11:06 < laanwj> dongcarl: added 11:06 < dongcarl> thx! 11:06 < provoostenator> laanwj: yes 11:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 11:07 < provoostenator> Well at least it fixes a regression compared to v22 11:07 < laanwj> provoostenator: makes sense then, it wasn't clear to me from the title enabling the send button sounded more like a feature 11:08 < provoostenator> Good point, renamed to more dramatic word choice: restore 11:08 < laanwj> yess 11:09 < fjahr> hi 11:09 < MarcoFalke> (off-topic: My C++20 patch is now ready #24169. Not sure if this needs discussion, if it does, then this is my topic suggestion) 11:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/24169 | build: Add --enable-c++20 option by MarcoFalke · Pull Request #24169 · bitcoin/bitcoin · GitHub 11:11 < laanwj> good to know, i don't think that particular PR needs discussion, only if the goal is to make c++20 a minimum requirement 11:11 < laanwj> but i suppose that's still some time away 11:12 < sipa> @MarcoFalke cool 11:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:12 < MarcoFalke> Yes, the minimum will be changed later (not sure when) 11:12 < sipa> (i don't think there is much more to discuss about that either) 11:13 < laanwj> is there any pressing reason for c++20? 11:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 11:13 < laanwj> in the context of our project 11:13 < MarcoFalke> Yeah, the pull shouldn't affect anyone unless they opt-in 11:14 < MarcoFalke> laanwj: named arguments (which work since clang 3) were only officially added in C++20 11:14 < laanwj> ok 11:14 < jonatack> will try it. there are also some niceties in std::chrono and std::algorithm that I would have liked to use 11:15 < jonatack> (so far) 11:15 < sipa> it's not like you can actually use them with this already, except inside #if #else variants. 11:15 < sipa> This is really just to make sure that our codebase is c++20 compliant (as well as c++17 compliant) 11:15 < MarcoFalke> See also #23363 11:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/23363 | Discussion: Upgrading to C++20 · Issue #23363 · bitcoin/bitcoin · GitHub 11:16 < laanwj> it seems a bit eary to break compatibility with compilers again 11:16 < dongcarl> MarcoFalke: Named arguments would really help my branch removing argsmanager from validation, where I introduce a few Options structs, alas perhaps too early to bump min C++ 11:17 < laanwj> sipa: yes, making sure it can be compiled with c++20 makes sense of course 11:17 < MarcoFalke> Named arguments choke only the msvc C++17 compiler, so as a hack we could bump msvc to C++20 and then start using named args with C++17 on clang/gcc 11:17 < _aj_> dongcarl: have you seen https://github.com/bitcoin/bitcoin/pull/24032/commits/3d3724e95b34931a4de8d31450f33ef0a32965e7#diff-ff53e63501a5e89fd650b378c9708274df8ad5d38fcffa6c64be417c4d438b6dR376-R382 ? gives fake named arguments 11:17 * MarcoFalke hides 11:18 < sipa> GCC only fully supports C++20 as of GCC 11, which was released 9 momths ago. It'll be a few years I think before we can assume common platforms have it available. 11:18 < laanwj> right 11:19 < jonatack> oh 11:19 < sipa> or even some parts in GCC 12 11:19 < dongcarl> sipa: True 11:19 < dongcarl> MarcoFalke: No flag on msvc to enable _just_ named arguments? 11:19 < MarcoFalke> At least Ubuntu/Debian seem agressive in backporting compilers 11:19 < laanwj> i dont't think we should be jumping on bumping the minimum gcc faster and faster 11:19 < dongcarl> _aj_: Lol very cool hack! 11:20 < sipa> It's true that the guix based build allows us to go a bit faster, but still..m 11:21 * jeremyrubin sends aj to c++ jail 11:21 < sipa> and removes all his friend classes? 11:22 < MarcoFalke> Right, I am not too happy that this needs bumping so far 11:22 < MarcoFalke> Let's see how many people will complain about the gcc-8 minimum in 23.x 11:22 < laanwj> _aj_: scary lol 11:24 < MarcoFalke> Though, designated initializers is already implemented in gcc-8 11:26 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:26 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 11:26 < laanwj> gcc 8 was released in 2018, hopefully not too many 11:27 < MarcoFalke> dongcarl: Not aware of a flag for that, but I don't think our msvc users are running that old software, so at least for them C++20 shouldn't be an issue 11:28 < laanwj> and yes guix allows bumping faster, though, it's generally nice if it's possible to build bitcoind with a platforms' existing compiler as-is 11:29 < laanwj> for MSVC there's less reason to support old versions 11:30 < dongcarl> +1 "it's generally nice if it's possible to build bitcoind with a platforms' existing compiler as-is" 11:30 < sipa> indeed 11:31 < _aj_> jeremyrubin: i'm not stuck in here with c++, c++ is stuck in here with me 11:31 < laanwj> any other topics for today? 11:31 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has quit [Quit: Willtech] 11:32 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has joined #bitcoin-core-dev 11:32 < MarcoFalke> So would people object using C++17 + designated initializers? 11:33 < sipa> I'm not very much a fan of enabling features too selectively, but I guess if there is a good reason? 11:33 < jonatack> I think I agree with sipa's comment against whitelisting features granularly 11:33 < dongcarl> I'd support it since it's been in gcc and clang for so long, but I don't know the msvc situation 11:33 < sipa> *granularly 11:33 < MarcoFalke> Seems slightly preferable to me than to implement designated initializers ourselves 11:33 < laanwj> it's a bit weird to conform to a standard but then make an exception, then again, like with browsers it seems that there's so little competition that "if it works with gcc and clang" is all that matters... 11:34 < jeremyrubin> building our own c++ compiler seems like something we'll do at some point 11:34 < laanwj> so i don't have a big problem with it either 11:34 < dongcarl> I found it very useful in mostly heterogenous structs to make sure I'm not setting the wrong element, or to set only a subset of elements and leave the rest to default. 11:35 < laanwj> jeremyrubin: who is this we 11:35 < MarcoFalke> Just saying, if we want #24032, then it seems we want designated initializers. If not, then well no need to discuss ;) 11:35 <@gribble> https://github.com/bitcoin/bitcoin/issues/24032 | Refactor vDeployments setup to avoid uninitialized variables by ajtowns · Pull Request #24032 · bitcoin/bitcoin · GitHub 11:35 < dongcarl> You could do it in other ways, but it's much nicer with designated initializers 11:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 11:36 < dongcarl> other ways = clang-tidy annotations / Options foo{}; foo.this_particular_item = 0; foo.that_particular_item = 5; 11:36 < MarcoFalke> yeah, a workaround could be to add a constructor to the struct that takes all arguments and then use clang-tidy's named argument check 11:37 < _aj_> (foo.this=1; foo.that=2; prevents "foo" from being const) 11:37 < dongcarl> _aj_: TRUE! I ran into that ytd 11:37 < jeremyrubin> _aj_: you can rebind it after to a const? 11:37 < jeremyrubin> if it's moveable 11:37 < _aj_> jeremyrubin: or wrap it in a function, sure 11:38 < laanwj> so to be clear, using designated initializers works right now, without any build system changes? 11:38 < laanwj> and without bumping minimum compiler versions 11:38 < MarcoFalke> const Options foo{[]{ Options _foo{}; _foo.a = 0; _foo.b = 1; return _foo; }()}; 11:39 < MarcoFalke> laanwj: Yes, we already did that a long time ago 11:39 < dongcarl> MarcoFalke: 🤮 11:39 < MarcoFalke> laanwj: Only found out when we started compiling the code (fuzz tests) with msvc 11:39 < dongcarl> MarcoFalke: Oh it doesn't fail on msvc? It's just review that's stopping designated initializers? 11:39 < laanwj> i mean in that case i don't see a big problem with using them 11:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 11:40 < MarcoFalke> dongcarl: It does fail msvc. Though, bumping msvc to c++20 should fix that issue. 11:40 < laanwj> bump the msvc requirement to c++20 11:40 < _aj_> https://en.cppreference.com/w/cpp/compiler_support -- lists Apple's Clang as only having partial support 11:40 < laanwj> right 11:41 < MarcoFalke> Jup, but that should be the same partial support that clang-7 has 11:41 < laanwj> so we can only use the partial support 11:41 < MarcoFalke> Right 11:41 < laanwj> if that isn't enough then there's no need to bother 11:42 * dongcarl wonders if we should start using {fmt} in preparation for C++20 std::format 11:42 < _aj_> sgtm 11:43 < MarcoFalke> dongcarl: std::format lands with improvements in C++23, so is it ready for production in C++20 already? 11:43 < Earnest> Is there an issue/pr for dumpwallet with descriptor wallets? 11:44 < dongcarl> MarcoFalke: oh perhaps not, haven't looked into it yet. {fmt} is compatible with C++20 std::format and has users, so I assume it's somewhat usable? 11:44 < Earnest> Or will that be replaced with new 'listdescriptors true' rpc? 11:44 < laanwj> i dont think there is an urgent reason to switch to another way of string formatting 11:44 < MarcoFalke> The designated initializers partial support doesn't allow braces, which no one should be using anyway unless required 11:45 < dongcarl> laanwj: Right, not urgent at all 11:47 < laanwj> replacing tinyformat is something we can do after c++20 or even c++23 11:48 < dongcarl> Yup! 11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:48 < bitcoin-git> [bitcoin] mzumsande opened pull request #24527: test: set segwit height back to 0 on regtest (master...202203_regtest_segwitheight) https://github.com/bitcoin/bitcoin/pull/24527 11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:48 < _aj_> replacing tinyformat sounds like a lot of lines of code to change 11:48 < laanwj> but it could be mechanical, maybe 11:49 < laanwj> given that format strings map in some way 11:49 < laanwj> in any case, it's not urgent 11:49 < laanwj> any other topics? 11:51 < laanwj> #endmeeting 11:51 < core-meetingbot`> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:51 < core-meetingbot`> Meeting ended Thu Mar 10 19:51:41 2022 UTC. 11:51 < core-meetingbot`> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-03-10-19.00.moin.txt 11:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 12:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 12:06 -!- arythmetic [~arythmeti@201.192.159.130] has quit [Remote host closed the connection] 12:07 -!- arythmetic [~arythmeti@201.192.159.130] has joined #bitcoin-core-dev 12:07 -!- arythmetic [~arythmeti@201.192.159.130] has quit [Remote host closed the connection] 12:13 -!- arythmetic [~arythmeti@201.192.159.130] has joined #bitcoin-core-dev 12:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 12:16 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:16 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 12:17 -!- gnaf [gnaf@gateway/vpn/protonvpn/gnaf] has quit [Quit: Konversation terminated!] 12:17 -!- arythmetic [~arythmeti@201.192.159.130] has quit [Ping timeout: 252 seconds] 12:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 12:45 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:45 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 12:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 12:57 < luke-jr> #24294 should probably be in 23.x or closed :/ 12:57 <@gribble> https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub 12:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 250 seconds] 13:13 < jonatack> luke-jr: or perhaps updated to snakecase "status-next" (if not used elsewhere, seems no) and "blockhash" in getdeploymentinfo 13:15 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 13:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:18 -!- arythmetic [~arythmeti@201.192.159.130] has joined #bitcoin-core-dev 13:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 13:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 13:22 -!- arythmetic [~arythmeti@201.192.159.130] has quit [Ping timeout: 250 seconds] 13:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 13:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 13:29 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has quit [Quit: Willtech] 13:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 256 seconds] 13:34 -!- morcos_ [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 13:35 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 13:35 -!- morcos_ is now known as morcos 13:39 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 13:51 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 13:52 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 14:05 -!- arythmetic [~arythmeti@201.192.159.130] has joined #bitcoin-core-dev 14:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 14:09 -!- arythmetic [~arythmeti@201.192.159.130] has quit [Ping timeout: 240 seconds] 14:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 14:23 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 14:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 14:38 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 14:38 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 14:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 14:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 14:46 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 14:46 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 14:47 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:19c8:2a3e:4c40:5c44] has joined #bitcoin-core-dev 14:49 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:19c8:2a3e:4c40:5c44] has quit [Client Quit] 15:01 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 15:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 15:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 15:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 15:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 15:31 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 15:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 15:52 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 15:53 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 15:58 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 16:03 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 16:07 -!- gossie [~gossie@2001:1c02:11e:c700:32f5:9458:805a:6409] has quit [Ping timeout: 250 seconds] 16:07 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 16:08 -!- gossie [~gossie@2001:1c02:11e:c700:32f5:9458:805a:6409] has joined #bitcoin-core-dev 16:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 16:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 16:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 16:23 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 16:25 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:19c8:2a3e:4c40:5c44] has joined #bitcoin-core-dev 16:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 16:45 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 256 seconds] 16:45 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 16:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 16:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 16:59 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:00 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:05 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 17:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:08 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:08 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:19c8:2a3e:4c40:5c44] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 17:11 -!- Guest76 [~Guest76@2607:fb91:482:8a54:c8e5:21ef:c34f:f50e] has joined #bitcoin-core-dev 17:11 -!- shesek_ [~shesek@user/shesek] has quit [Ping timeout: 240 seconds] 17:12 -!- Guest76 [~Guest76@2607:fb91:482:8a54:c8e5:21ef:c34f:f50e] has quit [Client Quit] 17:14 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:17 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 252 seconds] 17:18 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 17:18 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 17:18 -!- shesek__ [~shesek@user/shesek] has quit [Ping timeout: 240 seconds] 17:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 17:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 17:26 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 17:38 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:38 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 17:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 18:00 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Quit: upekkha] 18:00 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev 18:19 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 18:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 18:22 -!- shesek_ [~shesek@user/shesek] has quit [Ping timeout: 240 seconds] 18:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 18:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 18:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 18:45 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 18:48 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 18:48 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 18:53 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 18:56 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Remote host closed the connection] 18:57 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 18:58 -!- shesek__ [~shesek@user/shesek] has quit [Ping timeout: 256 seconds] 19:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 19:08 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 19:08 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 19:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 19:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 19:25 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 19:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 19:30 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 256 seconds] 19:32 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 19:37 -!- synch [~synch@155.33.133.44] has joined #bitcoin-core-dev 19:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 19:45 -!- shesek_ is now known as shesek 19:48 -!- ebaySatoshi [~ebaySatos@41.191.6.51.dyn.plus.net] has joined #bitcoin-core-dev 19:49 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:19c8:2a3e:4c40:5c44] has joined #bitcoin-core-dev 19:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 19:55 < ebaySatoshi> Where can I see the lines of code of Satoshi that were removed, possibly related to the implementation of a shopping feature in Bitcoin a bit like ebay shopping system? 19:56 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 20:04 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 20:06 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 20:06 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 20:07 -!- synch [~synch@155.33.133.44] has quit [Quit: Client closed] 20:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:23 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 240 seconds] 20:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 20:29 -!- da39a3ee5e6b4b0_ [~textual@2403:6200:8876:d2a9:cd54:b207:d3aa:c763] has joined #bitcoin-core-dev 20:32 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-dev 20:32 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:19c8:2a3e:4c40:5c44] has quit [Ping timeout: 240 seconds] 20:35 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 20:39 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has joined #bitcoin-core-dev 20:39 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 252 seconds] 20:46 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 20:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:58 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Ping timeout: 240 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:04 -!- Willtech [~Willtech@159-196-71-245.9fc447.mel.static.aussiebb.net] has quit [Quit: Willtech] 21:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 21:06 -!- da39a3ee5e6b4b0_ [~textual@2403:6200:8876:d2a9:cd54:b207:d3aa:c763] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:07 -!- TallTim [~talltim@184-83-250-114-dynamic.midco.net] has quit [Remote host closed the connection] 21:07 -!- da39a3ee5e6b4b0d [~textual@67.23.55.162] has joined #bitcoin-core-dev 21:07 -!- TallTim [~talltim@184-83-250-114-dynamic.midco.net] has joined #bitcoin-core-dev 21:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 21:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 21:16 -!- da39a3ee5e6b4b0d [~textual@67.23.55.162] has quit [Ping timeout: 256 seconds] 21:18 < jeremyrubin> https://github.com/jeremyrubin/satoshis-version ebaySatoshi that might be close to what you want 21:18 < jeremyrubin> feel free to make PRs if you see anything fun to document 21:19 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:cd54:b207:d3aa:c763] has joined #bitcoin-core-dev 21:22 -!- ebaySatoshi [~ebaySatos@41.191.6.51.dyn.plus.net] has quit [Quit: Ping timeout (120 seconds)] 21:29 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 21:32 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:33 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit [Client Quit] 21:35 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 21:40 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 21:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 21:46 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 21:47 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 21:57 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 272 seconds] 21:57 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 21:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 22:00 -!- ifeanyi [~ifeanyi@154.72.167.36] has joined #bitcoin-core-dev 22:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 22:08 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 22:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 22:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 22:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 22:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 22:54 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:54 -!- ifeanyi [~ifeanyi@154.72.167.36] has quit [Ping timeout: 256 seconds] 22:55 -!- ifeanyi [~ifeanyi@154.72.167.36] has joined #bitcoin-core-dev 22:55 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has quit [Client Quit] 23:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 23:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 23:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 250 seconds] 23:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:13 -!- bandal [~bandal@209.23.8.246] has joined #bitcoin-core-dev 23:15 -!- ifeanyi [~ifeanyi@154.72.167.36] has quit [Ping timeout: 272 seconds] 23:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 23:16 -!- ifeanyi [~ifeanyi@154.72.167.36] has joined #bitcoin-core-dev 23:20 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:39 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 23:42 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 23:42 -!- ifeanyi [~ifeanyi@154.72.167.36] has quit [Ping timeout: 256 seconds] 23:42 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 23:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-dev 23:59 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:cd54:b207:d3aa:c763] has quit [Quit: Textual IRC Client: www.textualapp.com] --- Log closed Fri Mar 11 00:00:22 2022