--- Log opened Tue Mar 22 00:00:32 2022 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:03 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24635: test: Run non-wallet tests only once (master...2203-noWalletOnce-🌘) https://github.com/bitcoin/bitcoin/pull/24635 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:06 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 00:07 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 00:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 00:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 00:10 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Remote host closed the connection] 00:10 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 00:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:19 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 00:19 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 00:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 00:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 00:23 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 00:23 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 00:24 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:32 -!- Kiminuo [~Kiminuo@141.98.103.181] has quit [Ping timeout: 256 seconds] 00:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has quit [Ping timeout: 252 seconds] 00:55 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Ping timeout (120 seconds)] 00:59 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 00:59 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 01:02 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 01:02 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 01:02 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 01:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:07 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 01:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3206c9445f8...b8f498f80dbb 01:12 < bitcoin-git> bitcoin/master fa8593f MarcoFalke: test: Fix generate calls and comments in feature_segwit 01:12 < bitcoin-git> bitcoin/master b8f498f MarcoFalke: Merge bitcoin/bitcoin#24535: test: Fix generate calls and comments in feat... 01:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24535: test: Fix generate calls and comments in feature_segwit (master...2203-test_fix_seg-🏌) https://github.com/bitcoin/bitcoin/pull/24535 01:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has joined #bitcoin-core-dev 01:14 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 01:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has quit [Ping timeout: 252 seconds] 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8f498f80dbb...138d55e6a024 01:17 < bitcoin-git> bitcoin/master facd5d9 MarcoFalke: doc: Fix getblockchaininfo/getdeploymentinfo RPC docs 01:17 < bitcoin-git> bitcoin/master 138d55e MarcoFalke: Merge bitcoin/bitcoin#24579: doc: Fix getblockchaininfo/getdeploymentinfo ... 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24579: doc: Fix getblockchaininfo/getdeploymentinfo RPC docs (master...2203-docRpc-🔅) https://github.com/bitcoin/bitcoin/pull/24579 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:27 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:29 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 01:32 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 01:35 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has joined #bitcoin-core-dev 01:49 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 01:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has quit [Ping timeout: 252 seconds] 01:55 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 01:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:56 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751 01:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:56 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:01 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15068: Install icon & .desktop file to XDG data (master...xdg) https://github.com/bitcoin/bitcoin/pull/15068 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:02 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/138d55e6a024...44dbf918d3ab 02:02 < bitcoin-git> bitcoin/master fa9086d MarcoFalke: test: Limit scope of id global which is shared between subtests 02:02 < bitcoin-git> bitcoin/master 44dbf91 fanquake: Merge bitcoin/bitcoin#24627: test: Limit scope of id global which is share... 02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:03 < bitcoin-git> [bitcoin] fanquake merged pull request #24627: test: Limit scope of id global which is shared between subtests (master...2203-gid-🥒) https://github.com/bitcoin/bitcoin/pull/24627 02:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:03 -!- kexkey [~kexkey@static-198-54-132-125.cust.tzulo.com] has quit [Ping timeout: 252 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has joined #bitcoin-core-dev 02:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 02:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has joined #bitcoin-core-dev 02:35 -!- Willtech [~Willtech@user/Willtech] has quit [Remote host closed the connection] 02:37 < fanquake> What has everyone found after there first 5 days of testing rc2 ? 02:40 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has quit [Read error: Connection reset by peer] 02:40 < hebasto> running rc2 in GUI mode on Ubuntu 22.04 every time reminds me about #22708 :) 02:40 <@gribble> https://github.com/bitcoin/bitcoin/issues/22708 | build, qt: Add Wayland support for Linux builds with depends by hebasto · Pull Request #22708 · bitcoin/bitcoin · GitHub 02:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 02:41 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 02:42 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 02:43 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has joined #bitcoin-core-dev 03:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 03:04 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 03:05 -!- jonatack [~jonatack@user/jonatack] has quit [Client Quit] 03:11 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 03:11 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 03:20 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 03:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has quit [Ping timeout: 252 seconds] 03:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 03:42 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Read error: Connection reset by peer] 03:49 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 03:49 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 03:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:50 < bitcoin-git> [bitcoin] fanquake closed pull request #22698: Implement RBF inherited signaling and fix getmempoolentry returned bip125-replaceable status (master...fix_bip125_inherited_signaling) https://github.com/bitcoin/bitcoin/pull/22698 03:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:50 -!- darosior [~darosior@194.36.189.246] has quit [Remote host closed the connection] 03:50 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 03:53 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:57 < bitcoin-git> [bitcoin] fanquake closed pull request #18086: Accurately account for mempool index memory (master...201910_accounting_allocator) https://github.com/bitcoin/bitcoin/pull/18086 03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:57 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44dbf918d3ab...2948d6dea098 03:57 < bitcoin-git> bitcoin/master b2774fc Luke Dashjr: torcontrol: Query Tor for correct -onion configuration 03:57 < bitcoin-git> bitcoin/master 2948d6d laanwj: Merge bitcoin/bitcoin#15423: torcontrol: Query Tor for correct -onion conf... 03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:58 < bitcoin-git> [bitcoin] laanwj merged pull request #15423: torcontrol: Query Tor for correct -onion configuration (master...tor_socks_port) https://github.com/bitcoin/bitcoin/pull/15423 03:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:58 < bitcoin-git> [bitcoin] fanquake closed pull request #24448: Guix: Fix building for i686-linux-gnu (master...guix_linux_i686) https://github.com/bitcoin/bitcoin/pull/24448 03:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24636: doc: Fix decodepsbt docs (master...2203-docBug-💧) https://github.com/bitcoin/bitcoin/pull/24636 04:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:20 < bitcoin-git> [bitcoin] theStack opened pull request #24637: test: use MiniWallet for mempool_package_onemore.py (master...20220322-test-use_MiniWallet_for_mempool_packages_onemore) https://github.com/bitcoin/bitcoin/pull/24637 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:26 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Ping timeout (120 seconds)] 04:33 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 04:33 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has joined #bitcoin-core-dev 04:37 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has quit [Client Quit] 04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:37 < bitcoin-git> [bitcoin] fanquake closed pull request #23507: Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference (master...ret_UniValue_instead_of_pass_by_ref) https://github.com/bitcoin/bitcoin/pull/23507 04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:38 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has joined #bitcoin-core-dev 04:40 -!- flooded is now known as _flood 04:55 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 04:58 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 04:58 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 04:58 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 05:04 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 05:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:12 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 250 seconds] 05:13 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 05:20 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 05:20 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 05:24 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Read error: Connection reset by peer] 05:33 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 05:34 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 05:34 < michaelfolkson> I think I'm getting confused on some of the supposedly non-wallet functional tests. Something like rpc_createmultisig.py seems like partially a wallet test to me 05:36 < michaelfolkson> I get that if the Core wallet is disabled this test running with Miniwallet is better than it being skipped. But if the Core wallet isn't disabled it is surely better to use (and test) the Core wallet than use Miniwallet? 05:36 < sipa> createmultisig is not a wallet RPC 05:36 < MarcoFalke> michaelfolkson: Oh, actually you might be right. addmultisig is run if the bdb wallet is compiled 05:37 < MarcoFalke> But then passing --legacy-wallet or --descriptor-wallet doesn't make sense 05:37 < MarcoFalke> (I think) 05:38 < MarcoFalke> The test should automatically check if bdb is available and run addmultisig if so 05:39 < MarcoFalke> I am assuming that creating a bdb-descriptor wallet or legacy-sqlite wallet is impossible, correct me if that is wrong on current master 05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2948d6dea098...f05cf59d91eb 05:41 < bitcoin-git> bitcoin/master d8641f0 Hennadii Stepanov: qt: Use human-readable strings in preference to hard-coded integers 05:41 < bitcoin-git> bitcoin/master acd98ad Hennadii Stepanov: qt: Avoid potential -Wdeprecated-enum-enum-conversion warning 05:41 < bitcoin-git> bitcoin/master f05cf59 MarcoFalke: Merge bitcoin/bitcoin#24624: qt: Avoid potential -Wdeprecated-enum-enum-co... 05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:41 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24624: qt: Avoid potential -Wdeprecated-enum-enum-conversion warnings (master...220321-enum) https://github.com/bitcoin/bitcoin/pull/24624 05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:44 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:44 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:47 < michaelfolkson> sipa: It is not in the wallet RPCs category, right. But creating a multisig address seems like wallet functionality to me 05:48 < michaelfolkson> Hazy boundaries 05:48 < sipa> createmultisig is a utility RPC, which computes a multisig address given the constituent keys; it's unrelated to the wallet 05:48 < sipa> it's also very old and pretty pointless these days (even more so than when it was introduced) 05:49 < michaelfolkson> Ok thanks 05:49 < michaelfolkson> MarcoFalke: I'm unsure, I thought you could still create those wallets with flags, they're just not the defaults anymore. But I'll check 05:52 < MarcoFalke> I mean if they were, we'd need to run the wallet tests 4 times? 05:56 < michaelfolkson> sipa: Maybe the createmultisig RPC should be deprecated if it is pointless? (I know the project is extremely conservative in terms of deprecating anything in case anyone is using it) 05:56 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 05:57 < michaelfolkson> Certainly possible someone out there is using it 05:57 < sipa> I think that would be reasonable. `deriveaddresses` can do everything it can do. 05:57 < sipa> IIRC 06:00 < michaelfolkson> Ok I'll set up a good first issue to deprecate it. Others can NACK it if they disagree with it being deprecated. We can get rid of the functional test entirely if we deprecate the RPC 06:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:02 < michaelfolkson> Maybe not good first issue, just an issue 06:04 < lightlike> my understanding is that the goal is to completely separate non-wallet tests from designated wallet tests. and not have mixed tests with the rationale that more indirect testing of the wallet can't hurt, even if it's not the main point of the test. 06:13 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 06:13 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 06:16 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 06:16 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 06:20 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 06:20 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] hebasto opened pull request #24639: guix: Drop code for the unsupported `i686-linux-gnu` host (master...220322-guix686) https://github.com/bitcoin/bitcoin/pull/24639 06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:22 < michaelfolkson> lightlike: Doesn't the first part of your statement contradict with the second part? I think it was a bunch of tests were being skipped that shouldn't necessarily be skipped because they needed the Core wallet and it was disabled 06:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 06:24 < michaelfolkson> I agree that more indirect testing of the wallet can't hurt (and could be beneficial) but you get that from using the Core wallet when it is available rather than always using MiniWallet 06:27 < sipa> I think it's just that tests should only be interacting with the Bitcoin Core wallet if they're trying to test the Bitcoin Core wallet. But there are lots of tests that need a wallet for something, but not for the thing being tested. Those should use MiniWallet. 06:27 < lightlike> michaelfolkson: sorry, I phrased the second part ambigously. I thought that the plan was NOT to have indirect testing with the rationale "it can't hurt", and instead chose to have a stricter separation, even if it that means no indirect testing. Otherwise, why migrate all these tests to the Miniwallet? 06:29 < sipa> Using the Core wallet when available and MiniWallet otherwise would need a ton of complexity for no reason. 06:30 < michaelfolkson> lightlike: The reason would be allowing more tests to run when the Core wallet is disabled. But yeah if you read sipa above (and below) an additional motivation seems to be clear separation (in which case use MiniWallet when not testing the Core wallet) 06:30 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: issued !quit command] 06:35 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has quit [Ping timeout: 260 seconds] 06:37 -!- willcl_ark [~will256k1@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev 06:37 < sipa> @michaelfolkson: The Bitcoin Core wallet is interacted with for two reasons in the functional tests: (a) for testing the Bitcoin Core wallet or (b) because a test needs *a* wallet-like thing to construct transactions for the purpose of testing some non-wallet component of Bitcoin Core. 06:37 < sipa> In case the Bitcoin Core wallet is disabled, (a) is pointless; there just isn't anything to be tested. 06:39 < sipa> The purpose of this effort is making sure that (b) can run without Bitcoin Core wallet, so that we don't lose test coverage of those non-wallet components. 06:40 -!- willcl_ark [~will256k1@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting] 06:40 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-core-dev 06:40 < michaelfolkson> sipa: I won't argue (because I think you're right!) but there is an argument to indirectly use the Core wallet for things in non-wallet tests and then maybe you stumble on problems that aren't tested by the `wallet_` tests 06:40 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Changing host] 06:40 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev 06:41 < sipa> Sure, perhaps. But that'd be so much effort that if that is truly a concern, we should just add more (a) tests that actually use the wallet. 06:41 < michaelfolkson> Presumably it is only the `wallet_` tests that are supposed to test the wallet and everything without `wallet_` in front of it aren't supposed to test the wallet 06:42 < michaelfolkson> sipa: Right 06:42 < sipa> The thing is also that the (b) tests generally don't do anything particularly complicated/interesting with the wallet. 06:42 < sipa> They generally just create some boring transactions. 06:42 < sipa> Because the test needs some. 06:42 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has left #bitcoin-core-dev [] 06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:42 < bitcoin-git> [bitcoin] luke-jr opened pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640 06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:43 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev 06:50 -!- arowser [~quassel@111.192.100.250] has joined #bitcoin-core-dev 07:01 -!- gnaf [~gnaf@163-172-58-132.rev.poneytelecom.eu] has joined #bitcoin-core-dev 07:11 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 07:12 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 07:13 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:24 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 07:28 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 07:40 -!- arowser [~quassel@111.192.100.250] has quit [Remote host closed the connection] 07:41 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 07:42 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:43 < bitcoin-git> [bitcoin] fanquake closed pull request #21061: [p2p] Introduce node rebroadcast module (master...2021-01-the-realest-rebroadcast) https://github.com/bitcoin/bitcoin/pull/21061 07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:47 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 07:47 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 07:47 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 07:57 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 07:57 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 08:00 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 08:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 08:09 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 08:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 08:21 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24641: Add AGGREGATE_NO_COPY_ONLY_MOVE helper (master...2203-copy-move-🌺) https://github.com/bitcoin/bitcoin/pull/24641 08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:37 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:40 -!- emcy [~emcy@user/emcy] has quit [Remote host closed the connection] 08:40 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 08:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 08:50 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 08:57 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 08:58 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 09:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 09:01 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev 09:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 09:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 09:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 09:29 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 09:29 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 09:57 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 09:59 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 10:07 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 10:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 10:23 -!- dviola [~diego@187.39.20.187] has joined #bitcoin-core-dev 10:24 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 10:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 10:29 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 10:30 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 10:38 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:41 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 10:47 < dongcarl> When fuzzing, the initialize_ function only gets run once, and the FUZZ_TARGET function gets run multiple times? 10:47 < sipa> Correct. 10:49 < dongcarl> sipa: 👍 10:59 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 11:00 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Connection closed] 11:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 11:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:16 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 11:16 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 11:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 11:21 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 11:26 < luke-jr> weird, Assume() breaks the context for member calls 11:26 < luke-jr> have to use this->… 11:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 11:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 11:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:45 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:46 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has left #bitcoin-core-dev [Closing Window] 12:00 < jeremyrubin> ctv meeting beginning shortly 12:04 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 12:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 12:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 12:24 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 12:25 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 12:25 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has quit [Ping timeout: 250 seconds] 12:26 -!- kexkey [~kexkey@static-198-54-132-93.cust.tzulo.com] has joined #bitcoin-core-dev 12:48 -!- jb55_ is now known as jb55 12:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 13:08 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:08 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 13:09 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 13:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 13:13 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 13:19 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 13:20 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 13:29 -!- zxrqmz88 [~private@2603-7000-1302-b6f3-0db4-e5c8-a6e0-d81e.res6.spectrum.com] has joined #bitcoin-core-dev 13:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 13:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 13:38 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 13:39 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 13:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds] 13:51 -!- kexkey [~kexkey@static-198-54-132-93.cust.tzulo.com] has quit [Ping timeout: 250 seconds] 13:52 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has joined #bitcoin-core-dev 14:10 -!- zxrqmz88 [~private@2603-7000-1302-b6f3-0db4-e5c8-a6e0-d81e.res6.spectrum.com] has quit [Quit: Quit] 14:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 14:13 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te4b5an1eoo8mnl.ipv6.telus.net] has quit [Remote host closed the connection] 14:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4zbh4bt8qqbxd.ipv6.telus.net] has joined #bitcoin-core-dev 14:16 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection] 14:16 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4zbh4bt8qqbxd.ipv6.telus.net] has quit [Remote host closed the connection] 14:19 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te4zbh4bt8qqbxd.ipv6.telus.net] has joined #bitcoin-core-dev 14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:28 < bitcoin-git> [bitcoin] achow101 opened pull request #24644: wallet: add tracepoints and algorithm information to coin selection (master...tracepoints-coin-selection) https://github.com/bitcoin/bitcoin/pull/24644 14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 14:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 14:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has joined #bitcoin-core-dev 14:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4152:dcc5:5862:734] has quit [Ping timeout: 252 seconds] 14:50 -!- hashfuncf39 [~user@2601:5c0:c280:7090:29ba:fcc0:8f3a:efac] has joined #bitcoin-core-dev 14:52 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 15:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:05 < bitcoin-git> [bitcoin] amogyisabogy1 opened pull request #24645: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/24645 15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:06 < bitcoin-git> [bitcoin] fanquake closed pull request #24645: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/24645 15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:06 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 15:15 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 15:15 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 15:19 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 15:19 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 15:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 15:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 15:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:54 -!- CoinForensics [~coinforen@193.32.127.220] has joined #bitcoin-core-dev 15:54 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 268 seconds] 16:01 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has joined #bitcoin-core-dev 16:10 -!- hashfuncf39 [~user@2601:5c0:c280:7090:29ba:fcc0:8f3a:efac] has quit [Ping timeout: 240 seconds] 16:11 -!- CoinForensics [~coinforen@193.32.127.220] has quit [] 16:12 -!- CoinForensics [~coinforen@gateway/vpn/pia/coinforensics] has joined #bitcoin-core-dev 16:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 16:15 -!- CoinForensics [~coinforen@gateway/vpn/pia/coinforensics] has quit [Client Quit] 16:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 16:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 16:24 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 245 seconds] 16:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 16:43 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has quit [Quit: leaving] 16:55 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 16:55 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 17:03 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has quit [Quit: ZNC 1.8.2 - https://znc.in] 17:03 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has joined #bitcoin-core-dev 17:07 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 17:08 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds] 17:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 17:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has quit [Ping timeout: 252 seconds] 17:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:17 < bitcoin-git> [bitcoin] jessebarton closed pull request #24618: doc: Update OpenBSD build docs, added resources for pkg_add and doas (master...openbsd_install_doc_doas) https://github.com/bitcoin/bitcoin/pull/24618 17:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:20 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 17:21 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 17:22 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 17:25 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 17:26 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 17:28 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 17:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 17:31 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 17:32 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 17:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:35 < bitcoin-git> [bitcoin] jessebarton opened pull request #24646: doc: remove unneeded documentation on basic package management on FreeBSD (master...freebsd_remove_basic_doc_info) https://github.com/bitcoin/bitcoin/pull/24646 17:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:35 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:36 -!- JesseBarton [~JesseBart@ip72-203-188-10.tu.ok.cox.net] has joined #bitcoin-core-dev 18:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 18:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 18:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 18:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 18:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 18:26 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 18:26 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 18:29 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 18:35 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 18:36 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 18:38 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 18:41 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 18:41 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 18:45 -!- CoinForensics [~coinforen@gateway/vpn/pia/coinforensics] has joined #bitcoin-core-dev 18:51 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds] 18:51 * luke-jr prods #24294 again 18:51 <@gribble> https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub 19:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has joined #bitcoin-core-dev 19:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has quit [Ping timeout: 252 seconds] 19:05 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 19:05 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 19:10 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 19:10 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 19:11 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 19:11 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 19:12 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-dev 19:12 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 19:12 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 19:15 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 19:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 19:32 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Ping timeout: 240 seconds] 19:35 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-dev 19:42 < _aj_> luke-jr: where are you seeing: weird, Assume() breaks the context for member calls 19:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has joined #bitcoin-core-dev 20:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 20:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 20:26 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 20:28 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 20:29 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 20:31 -!- kexkey_ [~kexkey@static-198-54-132-125.cust.tzulo.com] has joined #bitcoin-core-dev 20:33 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 20:34 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 20:38 -!- ronoaldo [~ronoaldo@187.75.45.227] has quit [Quit: Konversation terminated!] 20:47 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 20:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has quit [Ping timeout: 268 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:06 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 21:11 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 21:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has joined #bitcoin-core-dev 21:11 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds] 21:13 -!- lukedashjr is now known as luke-jr 21:16 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 21:17 -!- kexkey_ [~kexkey@static-198-54-132-125.cust.tzulo.com] has quit [Ping timeout: 252 seconds] 21:19 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has joined #bitcoin-core-dev 21:19 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 21:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 21:23 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 21:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:36 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 21:45 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 21:46 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 250 seconds] 21:47 -!- lukedashjr is now known as luke-jr 21:58 < luke-jr> _aj_: when writing wallet code; pushed as bugfix_rpc_getbalance_hacky to my github - now has a "this->" added 22:00 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 22:00 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 22:00 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 22:02 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 22:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 22:09 < _aj_> luke-jr: interesting; seems to work with clang but not gcc for me 22:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has quit [Ping timeout: 256 seconds] 22:23 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 22:25 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds] 22:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:25 -!- lukedashjr is now known as luke-jr 22:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 22:34 -!- CoinForensics [~coinforen@gateway/vpn/pia/coinforensics] has quit [Changing host] 22:34 -!- CoinForensics [~coinforen@user/CoinForensics] has joined #bitcoin-core-dev 22:41 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 22:42 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 22:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has joined #bitcoin-core-dev 22:44 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev 22:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has quit [Ping timeout: 252 seconds] 22:50 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has quit [Read error: Connection reset by peer] 22:50 -!- lucasdcf_ [~lucasdcf@2804:431:c7d8:eb7d:f0e4:e054:c2d:c68f] has joined #bitcoin-core-dev 23:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3] has joined #bitcoin-core-dev 23:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 23:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 23:38 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 23:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 23:46 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 23:49 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds] 23:49 -!- lukedashjr is now known as luke-jr --- Log closed Wed Mar 23 00:00:34 2022