--- Log opened Thu Mar 31 00:00:41 2022 00:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 00:12 -!- gnaf [~gnaf@163-172-90-106.rev.poneytelecom.eu] has joined #bitcoin-core-dev 00:20 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 00:21 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 00:22 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 00:26 -!- An0rak [An0rak@user/an0rak] has quit [Ping timeout: 246 seconds] 00:26 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 250 seconds] 00:26 -!- emcy [~emcy@user/emcy] has quit [Read error: Connection reset by peer] 00:27 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 00:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 00:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mgn7ohjr3n9duz.ipv6.telus.net] has joined #bitcoin-core-dev 00:29 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:39 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev 01:00 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:02 -!- Kaizen_K_ [~Kaizen_Ki@d162-157-52-46.abhsia.telus.net] has joined #bitcoin-core-dev 01:04 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:04 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 01:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mgn7ohjr3n9duz.ipv6.telus.net] has quit [Ping timeout: 245 seconds] 01:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 01:07 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:11 -!- hsmiths [uid95325@id-95325.helmsley.irccloud.com] has quit [Quit: Connection closed for inactivity] 01:11 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has left #bitcoin-core-dev [Closing Window] 01:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 01:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 01:19 -!- jonatack85 [jonatack@user/jonatack] has joined #bitcoin-core-dev 01:22 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 01:30 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 01:31 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 01:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 256 seconds] 01:32 -!- Kaizen_K_ [~Kaizen_Ki@d162-157-52-46.abhsia.telus.net] has quit [Ping timeout: 246 seconds] 01:35 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 01:35 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 01:41 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 272 seconds] 01:45 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 01:52 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 01:52 -!- jespada_ [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 01:55 -!- jespada_ [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 01:55 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:00 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:00 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 02:04 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 02:04 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 272 seconds] 02:06 -!- kexkey [~kexkey@static-198-54-132-105.cust.tzulo.com] has joined #bitcoin-core-dev 02:15 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:16 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:17 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:17 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c8ac7e6a6513...1a54c060b3b3 02:21 < bitcoin-git> bitcoin/master 71038a1 laanwj: rpc: Fix documentation assertion for `getrawtransaction` 02:21 < bitcoin-git> bitcoin/master 1a54c06 MarcoFalke: Merge bitcoin/bitcoin#24716: rpc: Fix documentation assertion for `getrawt... 02:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24716: rpc: Fix documentation assertion for `getrawtransaction` (master...2022-03-rpc-getrawtransaction-assert) https://github.com/bitcoin/bitcoin/pull/24716 02:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7meqszmjwlf09et.ipv6.telus.net] has joined #bitcoin-core-dev 02:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 02:28 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:28 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:35 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:35 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:40 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:40 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 02:46 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds] 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:46 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24721: doc: Use DecodeTxDoc helper (master...2203-doc-rpc-raw-tx-🚁) https://github.com/bitcoin/bitcoin/pull/24721 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:50 -!- Guest77 [~Guest77@host-82-56-171-4.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:50 -!- Guest77 [~Guest77@host-82-56-171-4.retail.telecomitalia.it] has quit [Client Quit] 02:52 -!- Willtech [~Willtech@user/Willtech] has quit [Read error: Connection reset by peer] 02:52 -!- Willtech_ [~Willtech@user/Willtech] has joined #bitcoin-core-dev 02:52 -!- Willtech_ is now known as Willtech 02:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:59 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 03:00 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 03:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 272 seconds] 03:03 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 03:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 03:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 03:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 260 seconds] 03:21 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds] 03:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 03:26 -!- noonien [~noonien@user/noonien] has quit [Quit: The Lounge - https://thelounge.chat] 03:27 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev 03:40 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 260 seconds] 03:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7meqszmjwlf09et.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 03:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 03:50 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 03:51 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 03:52 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 04:02 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mfcda03vuyuiff.ipv6.telus.net] has joined #bitcoin-core-dev 04:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:04 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:07 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:07 < bitcoin-git> [bitcoin] fanquake opened pull request #24722: build: patch around qt duplicate symbol issue (master...more_qt_nonsense) https://github.com/bitcoin/bitcoin/pull/24722 04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:07 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:20 < bitcoin-git> [bitcoin] fanquake pushed 16 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/7d03cf632d16...c243e0835166 04:20 < bitcoin-git> bitcoin/23.x 2a6fcf9 Jon Atack: init, doc: improve -onlynet help and tor/i2p documentation 04:20 < bitcoin-git> bitcoin/23.x ef6a37b Jon Atack: rpc: rename getdeploymentinfo status-next to status_next 04:20 < bitcoin-git> bitcoin/23.x b1646f1 Martin Zumsande: test: set segwit height back to 0 on regtest 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:20 < bitcoin-git> [bitcoin] fanquake merged pull request #24512: 23.x backports (23.x...23.x-onlynet-help-and-doc-improvements) https://github.com/bitcoin/bitcoin/pull/24512 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:20 < hebasto> rc3? 04:32 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 04:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 250 seconds] 04:54 < willcl_ark> Should I be able to use the `redeemScript` from a `bitcoin-cli createmultisig 1-of-4` as the signet challenge for a custom signet? Struggling to get it working like this... 04:57 -!- Kaizen_K_ [~Kaizen_Ki@d162-157-52-46.abhsia.telus.net] has joined #bitcoin-core-dev 04:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mfcda03vuyuiff.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 05:08 < _aj_> willcl_ark: should start with 51 and end with 54ae? yeah, should work. 05:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:10 < willcl_ark> _aj_: hmmm thanks.It does indeed start and end with those chars 05:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:11 < _aj_> willcl_ark: (they're "1" and "of 4 CHECKMULTISIG" respectively) 05:11 < provoostenator> Pre heating CPU for Guix... 05:11 < willcl_ark> (I have been documenting my steps here: https://hackmd.io/KLaH9u6iTBuNokLhgJ0lnA?view=#Notes ) 05:12 < willcl_ark> Right! The error thrown by bitcoind when trying to mine (on a machine which only has one of the private keys imported) is "Specified sighash value does not match value stored in PSBT" 05:12 < _aj_> willcl_ark: last time i tried, i had difficulty generating a private key then importing it into a wallet that i could use with the signet it was signing for -- wallets use the network magic to stop you from using your mainnet wallet on testnet, but the network magic for signet depends on the signet challenge 05:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:12 < _aj_> willcl_ark: update to newer master / 23.x rc, fix for that was merged a few hours ago i think 05:13 < _aj_> not 23.x rc, 23.x branch; hasn't been a new rc for it yet i think 05:13 < willcl_ark> oh, that woudl be nice! 05:13 < willcl_ark> will try, thanks! 05:13 < _aj_> https://github.com/bitcoin/bitcoin/pull/24553 05:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:16 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 05:17 < willcl_ark> Worked! 05:17 < willcl_ark> thanks v. much :) 05:18 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev 05:21 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 05:29 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 05:33 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev 05:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 05:50 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds] 05:56 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:09 -!- Kaizen_K_ [~Kaizen_Ki@d162-157-52-46.abhsia.telus.net] has quit [Ping timeout: 246 seconds] 06:12 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 256 seconds] 06:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 06:26 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds] 06:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net] has joined #bitcoin-core-dev 06:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:33 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:39 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 06:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 06:54 -!- hsmiths [uid95325@id-95325.helmsley.irccloud.com] has joined #bitcoin-core-dev 06:55 < laanwj> going to tag rc3 in a bit 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a54c060b3b3...243197ba9c4b 06:58 < bitcoin-git> bitcoin/master fa58427 MarcoFalke: doc: Use DecodeTxDoc helper 06:58 < bitcoin-git> bitcoin/master 243197b MarcoFalke: Merge bitcoin/bitcoin#24721: doc: Use DecodeTxDoc helper 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24721: doc: Use DecodeTxDoc helper (master...2203-doc-rpc-raw-tx-🚁) https://github.com/bitcoin/bitcoin/pull/24721 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 07:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:15 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/c243e0835166...e181e94e8663 07:15 < bitcoin-git> bitcoin/23.x 2a1d3a4 laanwj: build: Bump rc to 23.0rc3 07:15 < bitcoin-git> bitcoin/23.x 752c9d8 laanwj: qt: 23.0rc3 translations update 07:15 < bitcoin-git> bitcoin/23.x e181e94 laanwj: doc: Update manual pages for 23.0rc3 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:15 < bitcoin-git> [bitcoin] laanwj pushed tag v23.0rc3: https://github.com/bitcoin/bitcoin/compare/v23.0rc3 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:15 < laanwj> ^^ 07:15 < fanquake> 🚀 07:16 < sipa> Boom. 07:20 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 07:21 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 07:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Remote host closed the connection] 07:24 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 07:26 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 07:28 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 07:31 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:34 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 07:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 07:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Remote host closed the connection] 07:42 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 07:45 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net] has joined #bitcoin-core-dev 07:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds] 07:58 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 08:01 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 08:02 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 08:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 08:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds] 08:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 08:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:16 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24723: ci: Bump msan to clang-14 (master...2203-msan-ci-bump-🔏) https://github.com/bitcoin/bitcoin/pull/24723 08:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 08:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 08:29 * stick 🖤 v23.0rc3 08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:36 < bitcoin-git> [bitcoin] fanquake opened pull request #24724: test: fix incorrect named args in txpackage tests (master...txpackage_named_args) https://github.com/bitcoin/bitcoin/pull/24724 08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:51 -!- Kaizen_K_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 256 seconds] 08:58 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has quit [Quit: ZNC 1.8.2 - https://znc.in] 09:00 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has joined #bitcoin-core-dev 09:01 -!- Guest5843 [~Guest58@93.100.104.234] has joined #bitcoin-core-dev 09:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 09:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 09:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 09:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 260 seconds] 09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:43 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/243197ba9c4b...b7d78e624474 09:43 < bitcoin-git> bitcoin/master aeee419 Hennadii Stepanov: wallet, refactor: Add wallet::NotifyWalletLoaded() function 09:43 < bitcoin-git> bitcoin/master 0c12f01 Hennadii Stepanov: wallet: Postpone NotifyWalletLoaded() for encrypted wallets 09:43 < bitcoin-git> bitcoin/master b7d78e6 Andrew Chow: Merge bitcoin/bitcoin#24711: wallet: Postpone wallet loading notification ... 09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:43 < bitcoin-git> [bitcoin] achow101 merged pull request #24711: wallet: Postpone wallet loading notification for encrypted wallets (master...220329-taproot) https://github.com/bitcoin/bitcoin/pull/24711 09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:46 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev 09:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 09:52 -!- gnaf [~gnaf@163-172-90-106.rev.poneytelecom.eu] has quit [Ping timeout: 260 seconds] 09:53 -!- gnaf [~gnaf@163-172-90-118.rev.poneytelecom.eu] has joined #bitcoin-core-dev 09:54 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24725: 23.0: rc4 backport (23.x...2203-23rc4-🏅) https://github.com/bitcoin/bitcoin/pull/24725 10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:02 < MarcoFalke> If ^ makes it in fast enough we could abort rc3 and put the eggs into the rc4 basket, hoping it will be the final rc? 10:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 10:07 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 250 seconds] 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #24723: ci: Bump msan to clang-14 (master...2203-msan-ci-bump-🔏) https://github.com/bitcoin/bitcoin/pull/24723 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7d78e624474...1021e4cc6877 10:09 < bitcoin-git> bitcoin/master 21520b9 Martin Zumsande: fuzz: add target for coinselection 10:09 < bitcoin-git> bitcoin/master 1021e4c Andrew Chow: Merge bitcoin/bitcoin#24602: fuzz: add target for coinselection algorithms... 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] achow101 merged pull request #24602: fuzz: add target for coinselection algorithms (master...202203_fuzz_coinselection) https://github.com/bitcoin/bitcoin/pull/24602 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:11 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:13 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 10:16 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 10:17 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 10:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 10:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 240 seconds] 11:00 < laanwj> i don't really think it makes sense to abort rc3 now, one rc per week should be a good testing pace 11:02 < laanwj> rcs being doa should imo be reserved for when something goes wrong in the build process 11:02 < laanwj> not to slip in some patch last minute 11:08 < jonatack85> agree (i did think we were waiting for the remaining bugfixes to be backported before rc3) 11:08 < jonatack85> agree it's not doa though 11:08 < laanwj> there's always more bugfixes to wait for 11:09 < jonatack85> heh true 11:09 < laanwj> i think it was a good idea to cut another rc 11:09 < laanwj> at least the binaries should have the right name now (no more manual remame for macos) 11:10 < jonatack85> yes, and anyway there is also still #24454 11:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/24454 | tests: Calculate input weight more accurately by achow101 · Pull Request #24454 · bitcoin/bitcoin · GitHub 11:11 < fanquake> I'd rather get our first (proper) rc out and hopefully have more people test it 11:11 < fanquake> clearly plenty of things aren't being tested if the gui was broken for months and no-one noticed 11:11 < jonatack85> yes 11:11 < laanwj> the gui was broken for months? 11:12 < fanquake> laanwj: #24711 is a fix for https://github.com/bitcoin-core/gui/issues/571 11:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/24711 | wallet: Postpone wallet loading notification for encrypted wallets by hebasto · Pull Request #24711 · bitcoin/bitcoin · GitHub 11:13 < jonatack85> since dec 22 11:13 < jonatack85> of last year 11:13 < fanquake> basically if you created a new wallet, and encrypted it, you couldn't use Bech32m 11:13 < laanwj> ok, i wouldn't call that "the gui is broken" it's one specific issue in a specific condition 11:14 < laanwj> still a serious issue but let's not overstate it 11:14 < fanquake> Yes, although given it's one of the new exciting things for 23.0, it's very surprising nobody noticed it didn't work until now 11:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 11:15 < laanwj> wallet encryption seems more like a danger than something useful sometimes 11:20 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:20 < laanwj> at least the problem was caught in the rc phase, that's what it's for 11:20 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 11:21 < fanquake> indeed. it's good to get bug reports from (new) users 11:29 < provoostenator> You couldn't use bech32m immedidately after creation, but you could after a restart. 11:29 < sipa> "gui is broken" sounds more like the whole of bitcoin-qt is unusable 11:29 < provoostenator> It's definately not a good experience if we want people to start using bech32m. 11:30 < hebasto> ^^^ or wallet reload 11:30 < provoostenator> No strong preference on whether we should do rc4 now. But I'm happy to guix build it. 11:31 < hebasto> rc4 could accept more bugfixes, e.g., #24726 11:31 <@gribble> https://github.com/bitcoin/bitcoin/issues/24726 | Cross-compiled `bitcoind -signet` silently fails on Windows · Issue #24726 · bitcoin/bitcoin · GitHub 11:33 < fanquake> so is that literally "signet is broken" 11:33 < laanwj> sigh 11:33 < fanquake> hebasto: does it just stop after "[0%]..." ? 11:33 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 11:33 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 11:34 < hebasto> in 50% cases 11:34 < hebasto> in another 50% of cases it fails immediately 11:35 < laanwj> that's really bad 11:35 < sipa> That's bizarre. 11:35 < fanquake> definitely only happens for cross-compiled windows? 11:36 < MarcoFalke> Another compiler bug? 11:38 < hebasto> ^^ that is I can say 11:38 < laanwj> either that or undefined c++ behavior 11:39 < laanwj> which ahppens to be compiled correctly on MSVC but faulty in mingw, but yeahh who knows, if there's not any kind of error 11:39 < MarcoFalke> Does it crash in gdb.exe as well? 11:40 < laanwj> might try to compile with hardening disabled (to test, not to release), it has been a source of compile bugs on windows 11:41 < laanwj> i don't have windows i could try in wine though 11:42 < lightlike> hebasto: does that also happen when syncing signet fresh from genesis? In the log linked in 24726, you seems to use an existing datadir synced to 99%. 11:43 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 11:45 < hebasto> lightlike: removed signet dir, and it fails immediately appr. in a half of cases 11:46 < fanquake> I'm trying to recreate. cross-compiled master and running bitcoind.exe -signet under wine 11:46 < fanquake> haven't seen a crash yet 11:47 < lightlike> oh - i had no problems syncing signet with win 10, but will try more times if it happens only sometimes 11:48 < hebasto> fwiw, currently testing on Windows 11 Pro 21H2 virtual machine 11:49 < laanwj> the report was for rc2 not master (if that makes the difference it would be interesting ofc) 11:49 < laanwj> slightly differnt guix env maybe 11:50 < laanwj> or maybe it's not a problem in wine but only on windows 11 that points even more at a possible issue with hardening features 11:51 < fanquake> have downloaded the rc2 bins to test under wine 11:52 < fanquake> ok, got a crash 11:52 < fanquake> wine: Unhandled page fault on read access to FFFFFFFFFFFFFFFF at address 000000014051CC65 (thread 003f), starting debugger... 11:52 < laanwj> happy to see it reproduces 11:55 < laanwj> and that it's apparently fixed on master 9?) 11:59 < fanquake> got one with -debug, so a bit more info: https://github.com/bitcoin/bitcoin/issues/24726#issuecomment-1084989560 12:00 < laanwj> #startmeeting 12:00 < core-meetingbot> Meeting started Thu Mar 31 19:00:59 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 12:00 < core-meetingbot> Available commands: action commands idea info link nick 12:01 < achow101> hi 12:01 < fanquake> hi 12:01 < sipa> hi 12:01 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 12:01 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 12:01 < sipsorcery> hi 12:01 < hebasto> hi 12:01 < cfields> hi 12:01 < laanwj> fanquake: i don't have the debug symbols handy for rc2 right now, but it should be possible to figure out where that is in the binary 12:02 < fjahr> hi 12:02 < laanwj> PSA: 23.0rc3 has been tagged, please start your guix builders :) 12:02 < jonatack85> hi 12:02 < laanwj> welcome to the weekly general bitcoin-core-dev meeting 12:03 < laanwj> there have been no pre-propsed meeting topics, any last minute ones? 12:05 < laanwj> ok, let's discuss high priority for review 12:05 < laanwj> #topic High priority for review 12:05 < core-meetingbot> topic: High priority for review 12:05 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 1 chasing concept ACK 12:06 < Murch> hi 12:06 < laanwj> i'd reallly ask to review and test #22702 it would be good to get that in early in the release window 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub 12:06 < jonatack85> +1 for 22702, will do 12:06 < laanwj> anything to add, remove, or that is in the list and almost ready for merge? 12:07 < luke-jr> #24294 should probably be in the list 12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub 12:08 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev 12:09 < laanwj> luke-jr: added, though you have two in the list now 12:09 < luke-jr> oops, wrong list. I meant the 23.0 list 12:10 < luke-jr> sorry 12:11 < laanwj> ok 12:11 < jonatack85> luke-jr: i argued against that change in my review feedback there but agree there's something to be said for the principle of least surprise. so ~0 but in that case the developer notes about rpc argument naming should maybe be clarified 12:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Remote host closed the connection] 12:11 < laanwj> i've added it to 23.0 milestone, no opinion on the change really 12:12 < jonatack85> there's maybe also a question of naming consistency within an rpc, versus across rpcs 12:12 < luke-jr> I kinda see it as 23.0 or not worth the effort, myself 12:12 < laanwj> but agree that if it is to be changed back it needs to be before the release 12:12 < laanwj> otherwise it's another breaking change 12:13 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has left #bitcoin-core-dev [] 12:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:14 < laanwj> anything else? any other topics? 12:14 < jeremyrubin> hi 12:16 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev 12:16 < laanwj> there's something to be said for standardizing parameter names across RPCs, it's kind of annoying as user if every RPC has slightly different inconsistent spelling for the same thing 12:17 < laanwj> it's also a lot of work and may result in breaking changes in itself if persued too obsessively, so it's more of a best effort within the other constraints thing 12:17 < jeremyrubin> i am indifferent -- i don't think we have strong enough consistency in the RPCs right now that one more inconsistency hurts, if we want things to be really strongly consistent we should fix it all up in a big breaking API changes release. the worst case, IMO, is subtle small changes that might not get caught. better to just have nothing work than 12:17 < jeremyrubin> for things to seem to work. 12:18 < jeremyrubin> otoh, this seems like a good one since it's a reversion of an unecessary change 12:18 < glozow> hi 12:19 < laanwj> jeremyrubin: right, for new RPCs it makes sense to choose a parameter name already used by other RPCs for a same thing instead of trying to come up with something cleverer 12:19 < laanwj> i definitely agree absolute consistency is not a goal let that be clear 12:20 < laanwj> anyhow, any other topics? 12:21 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 12:22 < laanwj> #endmeeting 12:22 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 12:22 < core-meetingbot> Meeting ended Thu Mar 31 19:22:10 2022 UTC. 12:22 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-03-31-19.00.moin.txt 12:26 < laanwj> fanquake: i suppose it also happens on rc3? 12:26 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 12:26 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 12:27 < fanquake> laanwj: not sure. doing a cross compile of master with mingw-w64 and gcc 10.3 to match guix, and see if it still happens 12:28 < fanquake> i would assume it would though 12:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 12:28 < laanwj> that's a good thing to try 12:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 260 seconds] 12:34 < fanquake> can't make that crash 12:39 -!- Guest5843 [~Guest58@93.100.104.234] has quit [Quit: Client closed] 12:40 < laanwj> interesting, so there's really something different on master 12:42 < fanquake> i couldn't make the self-compiled 23.x, built with GCC 9 crash either, only the release binaries so far, so I'm leaning towards something in guix 12:42 < hebasto> ^ agree 12:43 < laanwj> trying freshly built 23.0rc3 bitcoind.exe -signet in wine now 12:44 < laanwj> it's at block 1000, when is it supposed to crash 12:44 < hebasto> at start 12:44 < hebasto> try to stop and re-run it 12:44 < laanwj> ok-seems that guix rc3 doesn't have the problem, then 12:44 < laanwj> oh it's at restart? 12:45 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 12:45 < hebasto> yes 12:45 < laanwj> it doesn't crash here 12:45 < hebasto> with `-signet`, right? 12:45 < laanwj> yes 12:45 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 12:49 < hebasto> hmm, our guix environment has no significant changes between rc2 and rc3 12:49 -!- An0rak [An0rak@user/an0rak] has joined #bitcoin-core-dev 12:49 < laanwj> same with rc2, no crash 12:50 < laanwj> wine-7.4 (staging) fwiw 12:51 < laanwj> let's try with ubuntu 22.04 standard wine 12:56 < laanwj> ok: wine 6.0.3, fresh environment, let rc2 sync to block 1000 again, restarted, no crash 13:01 < laanwj> restarted about 10 times, no crashes, i'm afraid i cannot help reproduce here 13:04 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 13:05 -!- bytes1440000 [~bytes1440@yal.riseup.net] has joined #bitcoin-core-dev 13:06 < bytes1440000> I had some issues with rc2 on windows. It was crashing and I had to restart 10 times to finally use it (bitcoind and bitcoin-qt). Could not find anything in logs. Never had this issue with any release in past. 13:06 < laanwj> could it depend on the processor architecture ? 13:06 < bytes1440000> Ignored because it could have been a system specific issue or something wrong with windows. 13:06 < bytes1440000> Can troubleshoot or provide more logs if someone can guide me. 13:07 < laanwj> anyhow fanquake's report has a memory map we shoudl be able to find out where it crashes 13:08 < luke-jr> laanwj: bytes1440000 is talking about the same issue? 13:08 < laanwj> luke-jr: could be? 13:08 < bytes1440000> luke-jr: I am not sure 13:13 < laanwj> rebuilding rc2 guix to get the debug information 13:15 < laanwj> as it happens semi-randomly it could be some kind of race condition, in worst case threading is broken in the guix windows env 13:17 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds] 13:20 -!- bytes1440000 [~bytes1440@yal.riseup.net] has left #bitcoin-core-dev [] 13:23 < laanwj> wait… is DEBUG_LOCKORDER on for the guix build? 13:24 < laanwj> i'm seeing "Enter: lock contention m_mutex, ./checkqueue.h:…" early in -debug output 13:24 < jonatack85> it's no longer a build option, it's a runtime one 13:25 < laanwj> seems like heavy overhead to always be doing that, i don't expect it to be the cause of the issue ofc 13:25 < jonatack85> the "lock" logging category 13:26 < laanwj> so for every lock it first does try_lock then lock? 13:26 < laanwj> even with lock debugging disabled 13:27 < jonatack85> yes 13:28 < sipa> that sounds expensive; was the impact of that benchmarked? 13:29 < laanwj> right, try_lock might be more expensive 13:29 < laanwj> really depends on the platform 13:29 < jonatack85> discussion in 22736 13:30 < laanwj> i even posted that there https://github.com/bitcoin/bitcoin/pull/22736#discussion_r691277896 13:31 < fanquake> It certainly looks like there was never really any benchmarking done? It's mentioned in the thread a number of times 13:31 < laanwj> you didn't gate the try_lock on the debug category as i suggested 13:31 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 13:32 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 13:34 < jonatack85> initially yes, it did 13:35 < laanwj> i really think we shouldn't mess with the good-weather case (simply calling ::lock) if there's no reason not to 13:37 < sipa> thinking about how it's likely implemented (but i don't know exactly), i suspect that a succesful lock and succesful try_lock are very similar in performance 13:37 < laanwj> our synchronization wrappers probably inline quite a lot of overhead to every lock call in any case 13:37 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 13:38 < sipa> which would mean that a change like this mostly hurts in case there is contention, not so much in happy cases 13:38 < laanwj> it's unnecessary though 13:38 < sipa> yes 13:38 < jonatack85> sipa: that was my conclusion 13:39 < sipa> i'd still like to see benchmarks... 13:39 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection] 13:39 < jonatack85> more precisely https://github.com/bitcoin/bitcoin/pull/22736#issuecomment-902851054 13:40 < laanwj> i mean this affects every single lock call in the program 13:40 < laanwj> did it noticably affect binary size, for example? 13:41 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 13:41 < laanwj> anyhow, probably a distraction from the windows crash issue 13:43 < laanwj> i still haven't been able to reproduce that 13:44 < cfields> laanwj: fwiw, i _really_ didn't like that change either, complained at the time for a different reason here: https://github.com/bitcoin/bitcoin/pull/22904#issuecomment-930484001 13:46 < laanwj> cfields: whoa 13:46 < cfields> (I think we're talking about the same change, at least) 13:46 < laanwj> cfields: my intuition says the same really, it's fine to have as a compile time option, this is not something that should be on by default 13:47 < laanwj> would really prefer for #22904 and #22736 to be reverted 13:47 <@gribble> https://github.com/bitcoin/bitcoin/issues/22904 | sync, log: inline lock contention logging macro to fix duration, improve BCLog::LogMsg() by jonatack · Pull Request #22904 · bitcoin/bitcoin · GitHub 13:47 <@gribble> https://github.com/bitcoin/bitcoin/issues/22736 | log, sync: change lock contention from preprocessor directive to log category by jonatack · Pull Request #22736 · bitcoin/bitcoin · GitHub 13:47 < jonatack85> cfields: that was the checkqueue unit tests causing a large log file because the test is *intended* to create contentions 13:48 < jonatack85> see https://github.com/bitcoin/bitcoin/pull/23223 13:49 < cfields> jonatack85: right, I was complaining about the contention tracking itself there, not the specific test failure. 13:49 < jonatack85> yes, it was an issue with DEBUG_LOCKCONTENTION defined as well 13:50 < laanwj> even it it's unlikely to cause any issues, complicating the locking default case seems risky 13:50 < laanwj> jonatack85: yes, but that was only enabled for debugging, not in production 13:50 < jonatack85> the lock logging on by default in the unit tests only revealed it 13:51 < laanwj> most users won't want to debug lock contention and don't need that overhead, so it makes sense to disable it in the release builds 13:52 < cfields> right, the only reason I can think of that we'd want it on for release builds is if we intended to actually use it for decision making: if (contended_time > x), which would be a really nasty idea :) 13:53 < laanwj> now that is the kind fo cursed idea i like to hear ! :) 13:55 < jonatack85> is the suggestion is to remove it from releases while leaving as a runtime option on master? 13:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 13:56 < sipa> laanwj: Don't give anyone ideas, please! 13:58 < laanwj> jonatack85: i think it should be a compile-time option, which is disabled unless something is passed to --configure, i don't mind if it's also gated by a runtime option or not 13:58 < laanwj> master or a branch shouldn't matter 13:59 < cfields> I believe that's what I tried to do here, but I can't remember now what I was actually fixing at the time heh: https://github.com/bitcoin/bitcoin/pull/22904#issuecomment-930486533 14:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 252 seconds] 14:02 -!- larpsus [~larpsus@yal.riseup.net] has joined #bitcoin-core-dev 14:02 -!- larpsus [~larpsus@yal.riseup.net] has left #bitcoin-core-dev [] 14:03 -!- larpsus [~larpsus@yal.riseup.net] has joined #bitcoin-core-dev 14:03 < larpsus> sipa: lol 14:03 < jonatack85> cfields: might compile quicker, iiuc? DEBUG_LOCKCONTENTION took a long time to build and couldn't be turned off at run time, impractical to use for development 14:03 -!- larpsus [~larpsus@yal.riseup.net] has left #bitcoin-core-dev [] 14:04 < laanwj> eeeeeekkkkkkk 14:05 < cfields> jonatack85: eh, it's been a while and I've largely forgotten the details now. I'll just stay out of it and review a follow-up PR if something arises :) 14:05 < laanwj> fanquake: 0x000000014051cc65: sha256d64_avx2::Transform_8way(unsigned char*, unsigned char const*) at /distsrc-base/distsrc-23.0rc2-x86_64-w64-mingw32/src/crypto/sha256_avx2.cpp:316 14:06 < laanwj> this explains why i can't reproduce it; i don't have a avx2 capable CPU 14:06 < cfields> OoOooh 14:06 -!- gnaf [~gnaf@163-172-90-118.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 14:07 < sipa> You may need an AVX2 capacable CPU which does not have SHA-NI. 14:07 < sipa> *capable 14:07 < jonatack85> laanwj, cfields: ok 14:18 < sipa> @laa 14:18 < cfields> jonatack85: just had another look, yeah, looks like I moved the defines out of the header so that you only have to recompile 1 object instead of everything, and also lends itself to runtime switching. IIRC the only real downside was lost inlining for some lock operations. 14:18 < sipa> laanwj: Do you know exactly what instruction it's failing on? 14:19 < sipa> It wouldn't surprise me that the lost cost of inlining is worse than what is gained by doing lock instead of trylock+lock. 14:20 < sipa> (because the happy path of trylock and lock both on x86 is just a memory fetch) 14:21 < jonatack85> cfields: nice. I'll start with reverting for now and happy to review if you take that further. 14:21 < sipa> > Unhandled page fault on read access to FFFFFFFFFFFFFFFF at address 000000014051CC65 14:22 < cfields> sipa: I don't disagree about the cost, but there's so much fluff in our locking I think there's ~0 chance it currently compiles down to a fetch. 14:22 < sipa> Easy to find out. 14:23 < laanwj> sipa: vmovdqa %ymm4, 0x260(%rsp) 14:24 < sipa> heh, that's just copying a variable from the stack 14:24 < sipa> so... stack underflow? 14:24 < cfields> sure that's the crashing thread? 14:26 < laanwj> could it be a misalignment or something 14:26 < laanwj> misaligned stack pointer, it would explain the chance element 14:28 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 14:29 < laanwj> nah there's other vmovdqa instructions in the function as well, why would it choose this one to crash 14:33 < sipa> this is in the output producing part of Transform_8way 14:33 < sipa> the only memory that should be accessing is the output 14:33 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds] 14:33 < sipa> which it can't assume is aligned 14:34 < laanwj> the other vmovdqa instructions involve other registers or rip-relative addressing, this is the first stack relative one 14:35 < sipa> But why would it be copying anything to the stack in the first place. It should be accessing the output. 14:35 < sipa> And it's not an alignment problem I think... 0xFFFFFFFFFFFFFFFF actually sounds like a bogus address being addressed. 14:35 < laanwj> i don't know it's likely a compiler bug, we haven't seen this on other platforms 14:36 < laanwj> i don't know enough about wine error reporting to know if that message is really showing an address or it doesn't know what to do with avx2 instructions 14:36 < sipa> Fair. 14:36 < cfields> fanquake: ^^ how's that clang+mingtw work coming along? :) 14:37 < cfields> *mingw 14:37 < laanwj> getting 0xFFFFFFFFFFFFFFFF exactly on a %esp+0x260 access would be pretty unlikely as well :) 14:38 < sipa> Yeah, indeed. 14:38 < laanwj> i think it's writing to a stack temporary (spilling) 14:43 < sipa> The x86_64 ABI requires %sp+8 to be 16-byte aligned on entry/exit of functions. 14:43 < laanwj> the ABI defines the stack should be 16-byte aligned on windows at function calls, is this enough? ymms are 256 bits? but i don't know the alignment requirements 14:43 < laanwj> oh, %sp+8? 14:44 < sipa> ymms are 256 bits and require 16-byte alignment. 14:44 < sipa> oh, or maybe even 32-byte alignment 14:44 < laanwj> it pushes %r12, %rbx, then subtracts 0x338 from %rsp 14:44 < laanwj> (at function prolog) 14:45 < sipa> yeah, it needs 32-byte alignment 14:45 < laanwj> 50 50 then :) 14:50 < laanwj> here's the entire disassembly of the function: https://gist.github.com/laanwj/95d97cd218d99c68c1437115e0db9394 14:52 < sipa> could it be some inconsistent ABI issue? 14:53 < sipa> -mavx2 code expecting higher alignment of stack pointers, e.g. 14:54 < laanwj> but i think we found the compiler bug: it runs out of registers, spills to the stack using vmovdqa, and forgets it cannot make a 32-byte alignment assumption 14:54 < laanwj> right 14:55 < sipa> right, that sounds like a plausible explanation 14:58 < laanwj> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412 an ancient bug report about avx which is still open 14:58 < laanwj> i think we'll want to avoid using 256 bit types on windows 14:59 < sipa> that looks like it could be it 14:59 < sipa> easy to just #ifdef out the avx2 logic on win 15:00 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 15:00 < laanwj> at least for mingw, apparently MSVC is ok 15:00 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 15:00 < sipa> may just be that the avx2 detection or compilation doesn't work in the first place on msvc? 15:01 < sipa> (but sure, no reason to expect this bug exists on MSVC as well) 15:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 15:04 < laanwj> right, i don't know 15:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Ping timeout: 245 seconds] 15:07 < cfields> laanwj: that gcc bug report you linked mentions that it's not a problem if __m256i's are passed around via const ref, which we don't do. 15:07 < cfields> I'm not suggesting we make that change, but we might be able to use it to verify if we're affected by that bug or not. 15:09 < laanwj> please 15:10 < laanwj> oh to verify, yeah sure 15:10 < laanwj> but i really don't want some brittle workaround, it's not that important 15:10 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 15:10 < laanwj> newer systems will have SHANI and others will fall back to some other optimized sha256 implementation 15:11 < jonatack85> cfields: this one? "As a workaround, one can either use __attribute__((always_inline)) for *all* the functions accepting __m256 or pass *all* arguments by const-ref. Const-ref arguments are passed correctly." 15:11 < laanwj> cfields: i also don't think that considers register spilling 15:14 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:17 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 15:17 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 15:19 < sipa> the shani code uses only 128bit registers afaik 15:19 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 15:20 < cfields> jonatack85: right 15:22 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Ping timeout: 246 seconds] 15:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:24 < bitcoin-git> [bitcoin] laanwj opened pull request #24727: build: Disable AVX2 code path on mingw builds (master...2022-03-windows-noavx2) https://github.com/bitcoin/bitcoin/pull/24727 15:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:25 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 15:25 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 15:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has joined #bitcoin-core-dev 15:27 < cfields> laanwj: from your asm dump it looks like all of those calls are inlined already anyway, so agreed that wouldn't change the spilling. 15:28 < laanwj> sipa: yep, also verified that 15:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 15:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 15:33 < reardencode> Is there a way in PSBT to encode a position or ordering of signatures, or is it expected that the finalizer will (if needed for a particular script) do O(n^2) sig verifications to get the sigs in the right order (when order matters)? 15:34 -!- surveillancechai [~surveilla@garza.riseup.net] has joined #bitcoin-core-dev 15:34 < surveillancechai> bitcoin, privacy, censorship, monero etc. love that altcoiners still would comeback, contribute and use bitcoin if bitcoin developers care about privacy at protocol level 15:34 < sipa> @reardencode It can just look at the order of keys in the script? 15:34 < surveillancechai> https://nitter.net/stephanlivera/status/1509240817319387145 15:34 -!- surveillancechai [~surveilla@garza.riseup.net] has left #bitcoin-core-dev [] 15:36 < laanwj> cfields: right, the problem doesn't arise with function arguments in our case 15:36 < reardencode> @sipa "just look at the order" meaning try verify(sig, pubkey) for each sig for each pubkey? 15:36 < laanwj> cfields: it's kind of disappointing, if they'd use the non-aligned store it'd maybe fractionally slower but at least not crash 15:37 < sipa> @reardencode No. The script has pubkeys in a particular order. The PSBT has a map from keys to sigs. The finalizer just needs to emit the sigs in the order implied by their corresponding keys. 15:37 < reardencode> @sipa ah, thank you! I was not seeing that the partial signatures are a map! 15:39 < cfields> laanwj: yeah, i was just reading up on -mavx256-split-unaligned-store, thinking toggling that on/off might change the heuristic used to decide on aligned/unaligned. But even if it did work, that'd just be more voodoo to rely on. 15:39 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Ping timeout: 260 seconds] 15:47 < laanwj> cfields: it's intersting that such a flag exists at all 15:48 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:48 < sipa> my entirely uninformed guess is that that flag wouldn't do anything, because this is a store which GCC (for better of worse) considers to be aligned 15:51 < laanwj> maybe gcc got 'smarter' about alignment in newer versions explaining why it turns up now 15:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 15:52 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 15:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 15:54 -!- hashfunc159a [~user@2601:5c0:c280:7090:4533:6252:8e32:243] has joined #bitcoin-core-dev 15:54 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 15:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 15:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 16:24 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 16:29 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Ping timeout: 260 seconds] 16:31 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Quit: upekkha] 16:32 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev 16:32 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 16:34 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 16:36 -!- Victorsueca [~Victorsue@user/victorsueca] has joined #bitcoin-core-dev 16:43 -!- mudsip [~mudsip@user/mudsip] has quit [] 16:49 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 16:49 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 16:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 17:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 17:07 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 17:08 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-dev 17:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc] has quit [Remote host closed the connection] 17:11 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:12 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 17:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 256 seconds] 17:36 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 17:39 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:40 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 17:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 18:00 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 18:00 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 18:01 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:06 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 18:09 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 18:16 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 246 seconds] 18:16 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@d75-156-179-9.abhsia.telus.net] has quit [Ping timeout: 250 seconds] 18:16 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 18:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:23 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 18:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 18:32 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 18:33 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 18:42 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 18:43 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 18:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 18:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 252 seconds] 18:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 18:53 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 18:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 18:58 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Ping timeout: 260 seconds] 18:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 19:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 19:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 19:06 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 19:14 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 19:14 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 19:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:18 -!- hashfunc159a [~user@2601:5c0:c280:7090:4533:6252:8e32:243] has quit [Remote host closed the connection] 19:35 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 19:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 19:42 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 19:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 20:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds] 20:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 20:13 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 20:20 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 20:20 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 21:00 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye] 21:00 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:02 -!- realies [~realies@user/realies] has quit [Quit: ~] 21:10 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 21:11 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 21:11 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 21:12 < jeremyrubin> reardencode: i think this can still come up with codesep, but YMMV 21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:14 < bitcoin-git> [bitcoin] ajtowns opened pull request #24729: util/check: avoid unused parameter warnings (master...202204-assume-gcc-fix) https://github.com/bitcoin/bitcoin/pull/24729 21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 250 seconds] 21:17 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 21:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 250 seconds] 21:30 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev 21:37 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 21:38 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection] 21:40 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 21:41 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 21:42 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 21:44 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 21:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 21:49 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 21:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds] 22:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-dev 22:04 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:04 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 22:04 -!- mikehu44_ [~quassel@159.65.11.175] has joined #bitcoin-core-dev 22:08 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:16 -!- mikehu44__ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 22:16 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds] 22:23 -!- mikehu44_ [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 22:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 22:25 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:26 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 22:35 -!- mikehu44__ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds] 22:40 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 22:43 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:43 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 22:49 < hebasto> "Using the 'standard' SHA256 implementation" means no hardware acceleration, right? 22:50 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 22:52 -!- hashfunc929 [~user@2601:5c0:c280:7090:4533:6252:8e32:243] has joined #bitcoin-core-dev 23:01 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds] 23:02 -!- hashfunc929 [~user@2601:5c0:c280:7090:4533:6252:8e32:243] has quit [Remote host closed the connection] 23:03 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 23:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@d75-156-179-9.abhsia.telus.net] has quit [Ping timeout: 260 seconds] 23:06 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 23:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 23:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 240 seconds] 23:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 23:38 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds] 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1021e4cc6877...7ab9fc32d6a8 23:47 < bitcoin-git> bitcoin/master bf77fea fanquake: test: fix incorrect named args in txpackage tests 23:47 < bitcoin-git> bitcoin/master 7ab9fc3 MarcoFalke: Merge bitcoin/bitcoin#24724: test: fix incorrect named args in txpackage t... 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24724: test: fix incorrect named args in txpackage tests (master...txpackage_named_args) https://github.com/bitcoin/bitcoin/pull/24724 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/e181e94e8663...e089c68aa17a 23:49 < bitcoin-git> bitcoin/23.x 4f3ba85 Hennadii Stepanov: wallet, refactor: Add wallet::NotifyWalletLoaded() function 23:49 < bitcoin-git> bitcoin/23.x 1448c99 Hennadii Stepanov: wallet: Postpone NotifyWalletLoaded() for encrypted wallets 23:49 < bitcoin-git> bitcoin/23.x e089c68 MarcoFalke: Merge bitcoin/bitcoin#24725: 23.0: rc4 backport 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24725: 23.0: rc4 backport (23.x...2203-23rc4-🏅) https://github.com/bitcoin/bitcoin/pull/24725 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev 23:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev 23:55 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Quit: jarthur] --- Log closed Fri Apr 01 00:00:43 2022