--- Log opened Fri Apr 01 00:00:43 2022
00:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24731: Change code (master...2203-change-code-🎵) https://github.com/bitcoin/bitcoin/pull/24731
00:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:07 -!- jonatack85 [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
00:07 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
00:10 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 260 seconds]
00:10 -!- lukedashjr is now known as luke-jr
00:36 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
00:37 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
00:49 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
00:50 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
00:54 < laanwj> kidding aside wine is a pretty cool platform, i'm always surprised how well it works
00:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
00:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 250 seconds]
01:02 < laanwj> hebasto: yes
01:06 < laanwj> but that shouldn't realistically happen on x86_64, sse4 is so common
01:06 < laanwj> and, definitely everything that has AVX2 will have that
01:07 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:07 < hebasto> laanwj: this is our msvc build
01:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
01:15 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
01:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
01:19 < laanwj> hebasto: oh, i would guess the special instructions code isn't compiled at all on that, it takes some build system magic to compile the right modules with the right instruction support
01:20 < fanquake> To https://github.com/bitcoin-core/bitcoin-detached-sigs
01:20 < fanquake> * [new tag]         v23.0rc3 -> v23.0rc3
01:20 < fanquake> cfields: clang + mingw-w64 is still a work in progress 😅
01:21 < laanwj> fanquake: thanks!
01:23 -!- hsmiths [uid95325@id-95325.helmsley.irccloud.com] has quit [Quit: Connection closed for inactivity]
01:25 < real_or_random> only remotely related: it's even possible to use MSVC + wine with autotools  https://github.com/bitcoin-core/secp256k1/pull/1084
01:26 < laanwj> real_or_random: nice! not an option for bootstrappable deterministic builds, but still
01:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:27 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24732: Remove buggy and confusing IncrementExtraNonce (master...2204-remove-code-🌗) https://github.com/bitcoin/bitcoin/pull/24732
01:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
01:29 < real_or_random> oh just noticed that the PR description was still outdated. this now uses the full MSVC toolchain including lib.exe and dumpbin.exe
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:29 < bitcoin-git> [bitcoin] hebasto opened pull request #24733: build: Fix "ERR: Unsigned tarballs do not exist" (master...220401-sign) https://github.com/bitcoin/bitcoin/pull/24733
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:29 < fanquake> heh. I just ran into the same issue
01:30 < fanquake> I think rc3 might just become rc4
01:32 < laanwj> still good we tried to go forward with rc3 to run into this issue
01:33 < fanquake> yep. at least now that the tarball naming / normalizing is done, it's done
01:36 < laanwj> but it will be after the weekend, i first need to rebuild 22.0 to get the symbols to know where to disassemble, this will take a while as i've guix-cleaned everything the 22.x dependency chain apparently
01:37 < laanwj> hebasto: but fwiw 22.0 has no vmovdqa instructions involving the stack, at all
01:38 < hebasto> so, it is a compiler, right?
01:38 < laanwj> yes, it's a compiler change
01:39 < laanwj> it just happened to work with last version (this might be accidental, e.g. some -mavx256-split-unaligned-store tuning cfields was talking about yesterday), or an actually introduced new bug
01:49 < laanwj> pretty sure i found the function without hand-holding actually (there's only one function where ymmX is used)
01:50 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
01:51 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
01:53 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
01:53 < laanwj> ok https://gist.github.com/laanwj/95d97cd218d99c68c1437115e0db9394 has both v22.0 and v23.0rc2 implementations now (you might want to check out the repo or download the zip it's too large to view in the browser)
01:54 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
01:56 < laanwj> the 22.0 implementation is smaller and looks more streamlined, did we *disable* any kind of optimization?
02:00 < laanwj> notably, _ZN14sha256d64_avx212_GLOBAL__N_16Write8EPhiDv4_x [sha256d64_avx2::(anonymous namespace)::Write8(unsigned char*, int, long long __vector(4))] is only called in the 23.0rc2 implementation
02:01 < laanwj> in comparison the 22.0 implementation has only one call, at the end, i suppose the stack check failure
02:02 < jonatack> laanwj: (looked at the lock logging undo, will push a pull soon)
02:03 < laanwj> this relates to the problematic 0x260(%rsp) ... so it looks like an inlining failure!
02:03 < laanwj> jonatack: awesome, thanks
02:04 < laanwj> maybe it's not actually spilling as thought
02:04 -!- kexkey [~kexkey@static-198-54-132-105.cust.tzulo.com] has quit [Ping timeout: 246 seconds]
02:05 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has joined #bitcoin-core-dev
02:07 < laanwj> maybe always inlining __attribute__((always_inline)) at least ::Write would work around it
02:08 < laanwj> it feels scary and could break any time, of course
02:10 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
02:11 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
02:11 < jonatack> gg almost 11k lines in that gist, when it's finished would love to learn more how you are troubleshooting this
02:12 < laanwj> jonatack: direct zip link: https://gist.github.com/laanwj/95d97cd218d99c68c1437115e0db9394/archive/2c052c5ea2d469d1466306565712fab7050f92a5.zip
02:13 < jonatack> thanks, i have it opened in my editor now
02:13 < fanquake> It looks like atleast Debian / Ubuntu mingw-w64 gcc is patching around either this, or a very similar issue
02:15 < fanquake> "Use unaligned VMOV instructions to avoid crashes caused by mis-aligned values; thanks to Claude Heiland-Allen for the patch! Closes: #939559."
02:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/939559 | HTTP Error 404: Not Found
02:16 < laanwj> fanquake: sounds vaguely like it may be it
02:16 < fanquake> 939559 is this issue, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939559, which concludes that it's related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412
02:16 < fanquake> which is the GCC bug you also seemed to have stumbled on
02:17 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 256 seconds]
02:17 < laanwj> so if we do the always_inline for Write *and* apply that patch it seems reasonably safe, that said, #24727 is simple and we're sure
02:17 <@gribble> https://github.com/bitcoin/bitcoin/issues/24727 | build: Disable AVX2 code path on mingw builds by laanwj · Pull Request #24727 · bitcoin/bitcoin · GitHub
02:18 < fanquake> the Debian patch is this one: https://salsa.debian.org/mingw-w64-team/gcc-mingw-w64/-/blob/master/debian/patches/vmov-alignment.patch
02:20 < laanwj> it looks like that would successfully prevent vmovdqa instructions from being generated
02:20 < fanquake> I guess this also explains why we don't see it in non-guix builds (at least on Debian / Ubuntu). Need to see if Fedora etc patches this too
02:21 < laanwj> right, good catch, i'm kind of shocked that something essential like this is part of distro patches
02:22 < laanwj> that said i can see why the gcc people deem it too extreme, you wouldn't want to do it on platforms where the alignment assumptions are correct
02:23 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 246 seconds]
02:23 < laanwj> i'm also a littlbe bit surprised by the different inlining decision between 22.0 and 23.0rc2, we didn't change any optimization flags did we?
02:24 < laanwj> it deosn't need to i mean the 'when to inline' heuristics get tweaked all the time
02:24 < laanwj> but the resulting code for 22.0 just looks better
02:24 < fanquake> No, but we did change from using GCC 7 iirc to GCC 10.3.0
02:25 < fanquake> sorry, 8 to 10.3
02:25 < laanwj> right
02:27 < laanwj> ok it's not as bad as i thought, looking at actual code size instead of .asm text size, (0x14051ce2f-0x1405108d0)/(0x88a15d-0x87da00)=~0.99  the 23.0rc2 implementation is ever so slightly smaller (which makes sense if you stopped inlining something)
02:29 < laanwj> so, yeah, i guess applying that patch (for mingw gcc build only) will simply make this problem go away
02:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 240 seconds]
02:33 < fanquake> I'll look at combining that into a guix build we can test
02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:37 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ab9fc32d6a8...afac75f140a3
02:37 < bitcoin-git> bitcoin/master 7762c56 Hennadii Stepanov: build: Fix "ERR: Unsigned tarballs do not exist"
02:37 < bitcoin-git> bitcoin/master afac75f laanwj: Merge bitcoin/bitcoin#24733: build: Fix "ERR: Unsigned tarballs do not exi...
02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:37 < bitcoin-git> [bitcoin] laanwj merged pull request #24733: build: Fix "ERR: Unsigned tarballs do not exist" (master...220401-sign) https://github.com/bitcoin/bitcoin/pull/24733
02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:45 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
02:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
02:48 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
02:49 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
02:49 -!- greypw2546 [~greypw254@grey.pw] has quit [Quit: I'll be back!]
02:49 -!- greypw2546 [~greypw254@grey.pw] has joined #bitcoin-core-dev
02:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds]
02:53 -!- Willtech [~Willtech@user/Willtech] has quit [Read error: Connection reset by peer]
02:53 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
03:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
03:02 < fanquake> test branch: https://github.com/fanquake/bitcoin/tree/guix_mingw_w64_vmov_alignment
03:03 < laanwj> fanquake: thanks, testing build
03:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
03:15 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Quit: The Lounge - https://thelounge.chat]
03:15 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
03:15 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
03:19 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 245 seconds]
03:22 < fanquake> can't seem to find any vmovdqa instructions in the disassembled binary
03:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
03:23 < fanquake> just vmovdqu vmovd vmovups
03:28 < fanquake> running bitcoind.exe -signet -debug and it hasn't crashed yet
03:28 < fanquake> (under wine)
03:35 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
03:42 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
03:43 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
03:47 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Ping timeout: 252 seconds]
03:47 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 260 seconds]
03:48 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
03:58 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
03:58 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:03 < bitcoin-git> [bitcoin] jonatack opened pull request #24734: sync: revert lock contention from log category to preprocessor directive (master...change-lock-logging-to-DEBUG_LOCKCONTENTION) https://github.com/bitcoin/bitcoin/pull/24734
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:11 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Connection closed]
04:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 245 seconds]
04:35 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds]
04:38 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
04:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
04:46 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
04:46 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
04:49 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
04:49 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
04:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds]
05:00 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
05:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 256 seconds]
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:14 < bitcoin-git> [bitcoin] fanquake opened pull request #24735: ci: use DWARF-4 for Valgrind jobs (master...remove_boost_valgrind) https://github.com/bitcoin/bitcoin/pull/24735
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
05:21 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
05:23 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:26 < bitcoin-git> [bitcoin] fanquake opened pull request #24736: guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64 (master...guix_mingw_w64_vmov_alignment) https://github.com/bitcoin/bitcoin/pull/24736
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24737:  Remove taproot chain param  (master...2204-rem-code-🥊) https://github.com/bitcoin/bitcoin/pull/24737
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:27 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
05:28 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
05:35 -!- dermoth [~dermoth@user/dermoth] has quit [Read error: Connection reset by peer]
05:36 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds]
05:39 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
05:42 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:46 -!- ashishkr [uid540896@id-540896.tinside.irccloud.com] has joined #bitcoin-core-dev
05:50 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:03 < bitcoin-git> [bitcoin] laanwj closed pull request #24727: build: Disable AVX2 code path on mingw builds (master...2022-03-windows-noavx2) https://github.com/bitcoin/bitcoin/pull/24727
06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:03 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
06:04 -!- hsmiths [uid95325@id-95325.helmsley.irccloud.com] has joined #bitcoin-core-dev
06:06 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-core-dev
06:16 -!- Willtech [~Willtech@user/Willtech] has quit [Ping timeout: 260 seconds]
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:21 < bitcoin-git> [bitcoin] fanquake opened pull request #24738: build: remove faketime unsetting and comments from configure (master...remove_faketime) https://github.com/bitcoin/bitcoin/pull/24738
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:22 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
06:22 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 252 seconds]
06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:22 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #24739: test: Fix intermittent test failure in wallet_listreceivedby.py (master...2204-test-fail-🍰) https://github.com/bitcoin/bitcoin/pull/24739
06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:23 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/afac75f140a3...a7f0c37c2bae
06:40 < bitcoin-git> bitcoin/master a24ef27 fanquake: build: patch around qt duplicate symbol issue
06:40 < bitcoin-git> bitcoin/master a7f0c37 fanquake: Merge bitcoin/bitcoin#24722: build: patch around qt duplicate symbol issue...
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:40 < bitcoin-git> [bitcoin] fanquake merged pull request #24722: build: patch around qt duplicate symbol issue (master...more_qt_nonsense) https://github.com/bitcoin/bitcoin/pull/24722
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:52 < bitcoin-git> [bitcoin] fanquake opened pull request #24740: doc: remove incorrect mention of PR_GET_NAME (master...remove_threadnames_comment) https://github.com/bitcoin/bitcoin/pull/24740
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:17 < cfields> dongcarl: does the guix compiler define any macro for detection?
07:18 < cfields> Re #24736 , I'm wondering if we could gate that on "#ifdef _GUIX_" or so
07:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/24736 | guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64 by fanquake · Pull Request #24736 · bitcoin/bitcoin · GitHub
07:20 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
07:22 < fanquake> cfields: that is all happening inside guix, so I'm not quite sure what you mean?
07:26 < laanwj> also mind it's a really old problem, that has existed ever since AVX2 support was added to the build, no one ever reported problems with it before so either everyone is using patched cross-compilers or no one is actually using mingw-w64 to build windows binaries for themselves
07:28 < laanwj> most windows devs seem to use the MSVC build (which doesn't even support instruction sets, apparently :-)
07:28 < cfields> fanquake: sometimes builders or distros hack in their own defines to compilers so that downstreams can test to see if they're using that distro's compiler. Thought that may be the case here.
07:29 < cfields> laanwj: yeah, thinking about it more, I guess you're right...
07:30 < laanwj> i mean you could cook up some script that does gcc then objdump to see what instructioss are generated to see if the comiler is patched, but i dunno
07:30 < cfields> getting a working windows compiler is kinda a dark art, and I guess we kinda have to put the onus on the builder to get themselves a working toolchain.
07:30 < laanwj> i guess the safest option is to disable AVX2 for mingw builds, then provide an option to force it to enable
07:31 < laanwj> that said, i'm not sure it's worth the extra complexity for something no one encounters in practice
07:31 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
07:32 < fanquake> my assumption would be that most regular users / devs would end up with a working mingw-w64 compiler, from their distro. Anyone who’s doing something a bit more non-mainstream / supported, is also probably more likely to notice if something isn’t working
07:32 < laanwj> yeah...
07:33 < laanwj> we should encourage using guix to build anyway
07:33 < cfields> fanquake: ack
07:33 < fanquake> we do have at least one compiler bug test, so we could even add another unit test, where if you’re building for windows, using gcc, and your compiler is emitting aligned vmov instructions, we fail, or similar
07:34 < cfields> wait, yeah, right...
07:35 < laanwj> a test cuold work, though adding AVX2 code to the test suite does comlicate the build system
07:36 < cfields> I thought fanquake meant trying to isolate the crasher and actually make it part of the sha2 sanity check.
07:36 < laanwj> e.g. support has to be detected both run and compile time
07:36 < laanwj> you'd have to control the stack pointer
07:36 < laanwj> that's pretty nasty
07:37 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds]
07:37 < sipa> but also don't know if it's worth the effort
07:37 < laanwj> yeah, i'd say not
07:37 < sipa> call it from a recursive function that has a 1 byte stack variable, called at various depths
07:38 < sipa> that should be pretty likely to trigger it, i think
07:38 < laanwj> it's also a very apparent crash, not like a silent corruption
07:38 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 260 seconds]
07:39 < sipa> right
07:41 < laanwj> you would also have to explicitly call the AVX2 variant in that sanity check so it doesn't depend on the CPU being in a fairly narrow range
07:41 < laanwj> but only if the CPU supports AVX2, of course
07:42 < laanwj> tbh for rc4 we just need to get this working for our build
07:43 < sipa> i think the current open PR is fine
07:44 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
07:45 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
07:45 < sipa> wahaha, i just look at what the #ChangeTheCode PR is actually doing. That's hilarious.
07:45 < cfields> agreed. I didn't mean to complicate. the status quo is clearly the patched compiler. it's just annoying that the status quo is a patched compiler :)
07:46 < laanwj> it's sad that the issue sits unpatched upstream for so long wonder if clang does better
07:46 < laanwj> windows support is and will be always a second thought in gcc
07:48 < cfields> laanwj: yeah. I have a gcc bugzilla account, will drop a "we're affected too" note on the bug, unless you were planning on it.
07:49 < laanwj> cfields: feel free to :)
07:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
07:52 < sipa> I also believe that on nearly all CPUs (except the very first that had AVX2), movdqu and movdqa have the same performance (in situations where they both work).
07:55 < laanwj> that's good to know
07:55 -!- ashishkr [uid540896@id-540896.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
07:56 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 256 seconds]
07:57 < Earnestly> That cleanupbitcoin website is unbelievable, the amount of js and css anims needed will probably outpace the power usage of bitcoin in a few weeks
07:58 -!- Guest547 [~Guest5@2401:4900:1c29:ba5:f130:dd79:350e:8e42] has joined #bitcoin-core-dev
07:58 < Earnestly> sipa: Where is the PR?
07:58 < laanwj> although i suspect the impact would be minimal anyway even if there was a difference; the only memory-facing (so, not register to register) 256-bit movdqX instructions are to fetch some constant, and to write the result for Write, it's not some memory heavy inner loop
07:58 < Earnestly> (They don't link to it)
07:59 < sipa> Earnestly: we're talking about the response to it, #24731
07:59 <@gribble> https://github.com/bitcoin/bitcoin/issues/24731 | Change code by MarcoFalke · Pull Request #24731 · bitcoin/bitcoin · GitHub
08:01 < Earnestly> Ah, I did see that, but skipped it before some reason, thanks
08:02 -!- Guest547 [~Guest5@2401:4900:1c29:ba5:f130:dd79:350e:8e42] has quit [Client Quit]
08:13 -!- Guest568 [~Guest5@2401:4900:1c29:ba5:f130:dd79:350e:8e42] has joined #bitcoin-core-dev
08:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
08:27 < achow101> laanwj: it seems you missed the mac code signed bins
08:30 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 272 seconds]
08:30 -!- Guest568 [~Guest5@2401:4900:1c29:ba5:f130:dd79:350e:8e42] has quit [Ping timeout: 250 seconds]
08:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
08:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
08:36 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
08:41 -!- Talkless [~Talkless@mail.dargis.net] has quit [Ping timeout: 260 seconds]
08:42 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
08:42 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
08:57 < laanwj> achow101: huh, yeah that's what you get for having HOSTS only set to windows i guess
08:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
09:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
09:03 < laanwj> from now on windows is my favorite platform and i'm only going to build for that !
09:05 < provoostenator> Bitcoin Bill Gates Vision
09:06 < laanwj> lol
09:21 -!- mekster66949 [~mekster@user/mekster] has quit [Quit: mekster66949]
09:22 -!- mekster66949 [~mekster@user/mekster] has joined #bitcoin-core-dev
09:26 < fanquake> we could probably even suggest the vmov patch for upstreaming in guix
09:26 < fanquake> Although currently the mingw-w64 build is only carrying reproducibility patches, so they might not be open to it
09:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds]
09:33 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
09:33 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
09:37 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
09:38 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 272 seconds]
09:40 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
09:40 -!- kexkey [~kexkey@static-198-54-132-105.cust.tzulo.com] has joined #bitcoin-core-dev
09:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
09:46 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
09:47 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 245 seconds]
09:49 -!- NorrinRadd [~username@102.67.16.112] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:59 < cfields> the bug report has some action already: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412#c34
10:00 < sipa> why does this only affect mingw, does anyone know?
10:04 < cfields> "Clang does indeed realign the stack a la GCC, which is OK in simple cases like this with SEH, i.e. when no DRAP is required (MSVC does things totally backwards, since it realigns the frame instead of the stack but we just cannot do that in GCC)."
10:04 < cfields> I don't really understand several parts of that answer, but it's an answer :)
10:04 < cfields> I guess that translates to: "clang _successfully_ realigns the stack" ?
10:06 < laanwj> achow101: added macos build, it matches with you
10:09 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
10:10 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
10:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
10:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Remote host closed the connection]
10:44 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 260 seconds]
10:49 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
10:50 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Read error: Connection reset by peer]
10:51 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
10:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
11:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection]
11:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
11:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 256 seconds]
11:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
11:15 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
11:15 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
11:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
11:21 -!- khannasid [~khannasid@103.84.214.25] has joined #bitcoin-core-dev
11:23 -!- khannasid [~khannasid@103.84.214.25] has left #bitcoin-core-dev []
11:24 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Read error: Connection reset by peer]
11:25 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
11:25 -!- realies [~realies@user/realies] has quit [Quit: Ping timeout (120 seconds)]
11:26 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
11:36 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
11:38 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:41 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
11:45 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:58 -!- jamesob [~jamesob@45.129.56.197] has quit [Quit: Ping timeout (120 seconds)]
11:58 -!- jamesob [~jamesob@45.129.56.197] has joined #bitcoin-core-dev
12:00 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
12:22 -!- jamesob [~jamesob@45.129.56.197] has quit [Quit: Ping timeout (120 seconds)]
12:22 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection]
12:22 -!- jamesob [~jamesob@45.129.56.197] has joined #bitcoin-core-dev
12:23 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
12:25 -!- mudsip [~mudsip@user/mudsip] has quit []
12:27 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Ping timeout: 260 seconds]
12:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-dev
12:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:32 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@d75-156-179-9.abhsia.telus.net] has quit [Ping timeout: 256 seconds]
12:35 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds]
12:49 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
12:53 -!- jamesob [~jamesob@45.129.56.197] has quit [Quit: Ping timeout (120 seconds)]
12:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Remote host closed the connection]
12:53 -!- jamesob [~jamesob@45.129.56.197] has joined #bitcoin-core-dev
12:54 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 240 seconds]
13:04 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has quit [Remote host closed the connection]
13:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net] has joined #bitcoin-core-dev
13:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
13:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
13:37 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 260 seconds]
13:37 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting]
13:38 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev
13:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
13:45 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
13:50 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
13:54 < laanwj> sipa: on linux, at least with gcc 11.2 i'm using locally, sp-relative accesses appear to use vmovdqu, it doesn't align the stack but uses the correct alignment assumptions
13:54 < sipa> dqu or dqa?
13:55 < laanwj> wait, that was actually a clang build
13:55 < laanwj> dqu
13:55 < laanwj> it doesn't assume the stack is aligned to 32 bytes, which makes sense
13:57 < sipa> oh, i misread what you said; i see
13:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
14:01 < laanwj> it uses the aligned variant only to move between registers (doubt it makes a difference which one is used there?) and accessing constant data it knows to be aligned
14:02 < laanwj> i don't get it really, it could do exactly the same on windows and it'd be correct?
14:02 < sipa> right
14:03 < sipa> i could understand if it uses the same codegen, but the alignment assumptions are different between the teo
14:03 < sipa> but here it seems it's actually different code being generated?
14:04 < laanwj> i think it's just the alignment assumptions that are different
14:05 < laanwj> i'd assume so, i'm not comparing against the same version of gcc right now
14:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
14:09 < laanwj> what i don't get what the alignment assumptions made by gcc on windows even are; why would it *ever* think the stack is 32-byte aligned? as i see it could just err on the safe side, but it doesn't
14:09 < laanwj> that's what #24736 does but it removes all reasoning about alignment at all
14:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/24736 | guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64 by fanquake · Pull Request #24736 · bitcoin/bitcoin · GitHub
14:10 < laanwj> which is okay as a workaround
14:10 < laanwj> but i guess to patch upstream, one'd have to be more precise
14:12 < fanquake> btw there is even more discusion in the issue now: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412
14:14 < laanwj> ah, this comment states exactly what i mean: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412#c36
14:17 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
14:18 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
14:18 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
14:22 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
14:25 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
14:26 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
14:34 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:39 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
14:39 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
14:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
14:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 240 seconds]
14:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
15:04 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
15:09 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:10 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
15:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
15:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:38 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
15:38 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
15:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
15:41 < cfields> laanwj: cunningham's law strikes again, heh.
15:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 240 seconds]
16:13 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
16:13 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
16:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
16:33 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
16:34 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
16:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
16:37 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
17:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
17:07 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404]
17:07 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
17:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 256 seconds]
17:12 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
17:13 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
17:35 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
17:37 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection]
17:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
18:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
18:12 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev
18:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
18:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 256 seconds]
18:39 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
18:39 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
18:40 -!- mekster66949 [~mekster@user/mekster] has quit [Quit: mekster66949]
18:44 -!- mekster66949 [~mekster@user/mekster] has joined #bitcoin-core-dev
18:45 -!- Willtech [~Willtech@user/Willtech] has quit [Quit: Willtech]
18:46 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
18:46 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
18:47 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
18:47 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
18:59 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev
19:01 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
19:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
19:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 256 seconds]
19:11 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
19:13 -!- shesek__ [~shesek@user/shesek] has quit [Read error: Connection reset by peer]
19:48 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 260 seconds]
19:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
19:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
20:06 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
20:06 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
20:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
20:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 260 seconds]
20:52 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
20:53 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:11 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
21:12 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
21:18 -!- x88x88x [~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb] has joined #bitcoin-core-dev
21:21 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
21:22 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
21:27 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
21:38 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
21:41 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
21:42 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
22:09 -!- hashfunce31 [~user@2601:5c0:c280:7090:4533:6252:8e32:243] has joined #bitcoin-core-dev
22:15 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
22:18 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
22:21 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds]
22:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has joined #bitcoin-core-dev
22:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:54b8:7574:b1fa:4488] has quit [Ping timeout: 245 seconds]
22:36 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:42 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
22:43 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev
23:15 -!- hashfunce31 [~user@2601:5c0:c280:7090:4533:6252:8e32:243] has quit [Remote host closed the connection]
23:18 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
23:23 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
23:27 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
23:46 -!- Guest101 [~Guest101@2401:4900:1c28:95:7111:c2e0:5104:6ada] has joined #bitcoin-core-dev
23:48 -!- Guest101 [~Guest101@2401:4900:1c28:95:7111:c2e0:5104:6ada] has quit [Client Quit]
23:54 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 272 seconds]
23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:57 < bitcoin-git> [bitcoin] fanquake closed pull request #24731: Change code (master...2203-change-code-🎵) https://github.com/bitcoin/bitcoin/pull/24731
23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
--- Log closed Sat Apr 02 00:00:44 2022