--- Log opened Wed Apr 13 00:00:53 2022 00:01 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 00:04 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev 00:06 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 240 seconds] 00:15 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev 00:22 -!- gnaf [~gnaf@195-154-105-157.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 00:33 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 250 seconds] 00:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 00:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 00:44 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 250 seconds] 00:44 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 01:44 -!- Willtech [~Willtech@user/Willtech] has quit [Remote host closed the connection] 02:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 02:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 02:04 -!- kexkey [~kexkey@static-198-54-132-110.cust.tzulo.com] has quit [Ping timeout: 256 seconds] 02:05 -!- kexkey [~kexkey@178.249.214.27] has joined #bitcoin-core-dev 02:12 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has joined #bitcoin-core-dev 02:15 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Ping timeout: 240 seconds] 02:21 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 02:45 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 02:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 03:05 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 03:10 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 03:30 -!- dougefish2 [~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239] has joined #bitcoin-core-dev 03:37 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 03:39 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Read error: Connection reset by peer] 03:40 -!- realies [~realies@user/realies] has quit [Quit: Ping timeout (120 seconds)] 03:40 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 03:42 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 03:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 03:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds] 03:57 < fanquake> hebasto / laanwj: I've added another GCC patch to our Guix build, that may fix https://github.com/bitcoin-core/gui/issues/582: https://github.com/fanquake/bitcoin/tree/guix_fix_windows_longjmp, if you wanted to test 03:57 < hebasto> fanquake: thanks! 03:57 < fanquake> unlike the vmov fix, this isn't being backported by distros as far as I can tell. 03:57 < fanquake> Bit of a stab in the dark based on GCC commits 04:10 -!- TheRec [~toto@user/therec] has quit [] 04:19 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 04:47 < hebasto> fanquake: I've applied your patch into the 23.x branch, and tested it on Windows 11 Pro and in `wine` on Ubuntu 22.04 04:47 < hebasto> everything works flawlessly 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] hebasto closed pull request #24838: build, windows: Use Direct2D plugin (master...220412-d2d) https://github.com/bitcoin/bitcoin/pull/24838 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:57 -!- ronoaldo [~ronoaldo@191.19.24.11] has joined #bitcoin-core-dev 04:58 < fanquake> I guess I should turn that into a considerable patch 04:58 < laanwj> fanquake: that's absolutely great 05:00 < laanwj> fixing SEH is the right way to fix this 05:03 < laanwj> better than a freetype/qt specific workaround, it potentially affects other uses of frame unwinding as well liee C++ exceptions 05:04 < fanquake> I'll write a proper commit message, split it out of the vmov patch handling, and open a PR 05:04 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 05:07 < laanwj> thank you 05:10 -!- dougefish2 [~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239] has quit [Quit: Client closed] 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:15 < bitcoin-git> [bitcoin] chinggg opened pull request #24841: test: fix connman UB by calling derived constructor (master...fix-test-connman-ub) https://github.com/bitcoin/bitcoin/pull/24841 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:36 < bitcoin-git> [bitcoin] fanquake opened pull request #24842: guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues (master...guix_fix_windows_longjmp) https://github.com/bitcoin/bitcoin/pull/24842 05:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:02 -!- An0rak [An0rak@user/an0rak] has joined #bitcoin-core-dev 06:04 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev 06:08 -!- An0rak [An0rak@user/an0rak] has quit [] 06:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:09 < bitcoin-git> [bitcoin] fanquake opened pull request #24843: [23.x] rc5 backports (23.x...rc5_backports) https://github.com/bitcoin/bitcoin/pull/24843 06:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:11 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-dev 06:25 -!- An0rak [An0rak@user/an0rak] has joined #bitcoin-core-dev 07:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 07:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds] 07:33 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 07:34 -!- mekster66949 [~mekster@user/mekster] has quit [Quit: mekster66949] 07:34 -!- mekster66949 [~mekster@user/mekster] has joined #bitcoin-core-dev 07:46 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 07:50 < hebasto> #24157 looks good, maybe final review and merge it? 07:50 <@gribble> https://github.com/bitcoin/bitcoin/issues/24157 | p2p: Replace RecursiveMutex `cs_totalBytesSent` with Mutex and rename it by w0xlt · Pull Request #24157 · bitcoin/bitcoin · GitHub 07:59 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has joined #bitcoin-core-dev 08:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Remote host closed the connection] 08:01 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 08:02 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 08:05 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 08:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has joined #bitcoin-core-dev 08:06 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 08:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Ping timeout: 240 seconds] 08:11 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has quit [Quit: Leaving] 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:14 < bitcoin-git> [gui] hebasto closed pull request #108: WIP: mempool stats chart (master...2020/03/mempool_graph) https://github.com/bitcoin-core/gui/pull/108 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:15 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 08:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:16 < bitcoin-git> [gui] hebasto closed pull request #305: Display send/recv in Bps instead of totals in the debug window (master...SendRecvSpeed-gui) https://github.com/bitcoin-core/gui/pull/305 08:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has joined #bitcoin-core-dev 08:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Ping timeout: 240 seconds] 08:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:22 < bitcoin-git> [gui] hebasto closed pull request #494: Replace testnet with signet as a default network for Android (master...211201-signet) https://github.com/bitcoin-core/gui/pull/494 08:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:22 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 08:27 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 08:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has joined #bitcoin-core-dev 08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:33 < bitcoin-git> [gui] w0xlt opened pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583 08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:42 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 08:42 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 08:42 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev 09:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:16 < bitcoin-git> [bitcoin] Kvaciral opened pull request #24844: lint: Convert lint-whitespace.sh to Python (master...lint-whitespace-port) https://github.com/bitcoin/bitcoin/pull/24844 09:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:21 < bitcoin-git> [gui] hebasto opened pull request #584: Getting ready to Qt 6 (5/n). Do not assume `qDBusRegisterMetaType` return type (master...220413-metatype) https://github.com/bitcoin-core/gui/pull/584 09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:25 < bitcoin-git> [bitcoin] furszy opened pull request #24845: wallet: createTransaction, return proper error description for "too-long-mempool-chain" + introduce generic Result classes (master...2022_wallet_operationresult) https://github.com/bitcoin/bitcoin/pull/24845 09:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:25 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 09:45 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 09:47 -!- Skyz [~Skyz@user/skyz] has joined #bitcoin-core-dev 09:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:48 < bitcoin-git> [bitcoin] jamesob opened pull request #24846: developer-notes: allow lowerCamelCase for methods (master...jamesob-22-04-dev-notes-methods) https://github.com/bitcoin/bitcoin/pull/24846 09:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:05 -!- Skyz [~Skyz@user/skyz] has quit [Quit: Client closed] 10:40 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 10:47 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has quit [Remote host closed the connection] 10:51 -!- An0rak [An0rak@user/an0rak] has quit [Ping timeout: 240 seconds] 11:18 -!- Earnestly [~earnest@user/earnestly] has quit [Read error: Connection reset by peer] 11:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 250 seconds] 11:21 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 11:29 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:38 -!- lowhope [~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e] has quit [Ping timeout: 256 seconds] 11:51 -!- jarthur_ is now known as jarthur 12:07 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:08 -!- An0rak [An0rak@user/an0rak] has joined #bitcoin-core-dev 12:16 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 12:17 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 12:36 -!- lowhope [~lowhope@cow9.org] has joined #bitcoin-core-dev 12:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 12:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 12:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:50 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f60a63cc5f16...3bbc46ddafb6 12:50 < bitcoin-git> bitcoin/master 0cea7b1 /dev/fd0: print `(none)` if no warnings in -getinfo 12:50 < bitcoin-git> bitcoin/master 3bbc46d laanwj: Merge bitcoin/bitcoin#24632: add `(none)` in -getinfo `Warnings:` if no wa... 12:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:50 < bitcoin-git> [bitcoin] laanwj merged pull request #24632: add `(none)` in -getinfo `Warnings:` if no warning returned (master...getinfo-warning) https://github.com/bitcoin/bitcoin/pull/24632 12:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:51 < sipa> laanwj: I think you left https://github.com/bitcoin/bitcoin/pull/24846#issuecomment-1098420896 in the wrong PR 12:51 < sipa> Ah, it's gone. 12:53 < laanwj> sipa: hehe i noticed, it was for #24632 12:53 <@gribble> https://github.com/bitcoin/bitcoin/issues/24632 | add `(none)` in -getinfo `Warnings:` if no warning returned by 1440000bytes · Pull Request #24632 · bitcoin/bitcoin · GitHub 12:56 < laanwj> it's good that we have the commit id in the ACK message or it could be a dangerous mistake :< 13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 256 seconds] 13:04 -!- Guest60 [~Guest60@2001:861:3204:e660:1425:6fd1:eb83:c179] has joined #bitcoin-core-dev 13:25 -!- Saloframes [~Saloframe@user/Saloframes] has joined #bitcoin-core-dev 13:26 -!- Guest60 [~Guest60@2001:861:3204:e660:1425:6fd1:eb83:c179] has quit [Quit: Client closed] 13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:28 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3bbc46ddafb6...9b7eb584ade2 13:28 < bitcoin-git> bitcoin/master e644591 Hennadii Stepanov: build, refactor: Drop useless `call` Make function 13:28 < bitcoin-git> bitcoin/master 9b7eb58 laanwj: Merge bitcoin/bitcoin#24285: build, refactor: Drop useless `call` Make fun... 13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:28 < bitcoin-git> [bitcoin] laanwj merged pull request #24285: build, refactor: Drop useless `call` Make function (master...220207-call) https://github.com/bitcoin/bitcoin/pull/24285 13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:45 < laanwj> re: #24559 how does a functional test explicitly request a bdb wallet? 13:45 <@gribble> https://github.com/bitcoin/bitcoin/issues/24559 | test: add test for signet miner script by theStack · Pull Request #24559 · bitcoin/bitcoin · GitHub 13:46 < laanwj> it would be better not to, but it makes use of importprivkey at the moment 13:47 -!- kexkey [~kexkey@178.249.214.27] has quit [Ping timeout: 246 seconds] 13:47 < laanwj> maybe someone has a better idea 13:48 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 13:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Remote host closed the connection] 13:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has joined #bitcoin-core-dev 14:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:00 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b7eb584ade2...decde9bba6f9 14:00 < bitcoin-git> bitcoin/master 1633f5e Hennadii Stepanov: util, refactor: Add UNIQUE_NAME helper macro 14:00 < bitcoin-git> bitcoin/master decde9b laanwj: Merge bitcoin/bitcoin#24355: util, refactor: Add UNIQUE_NAME helper macro 14:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:00 < bitcoin-git> [bitcoin] laanwj merged pull request #24355: util, refactor: Add UNIQUE_NAME helper macro (master...220216-unique) https://github.com/bitcoin/bitcoin/pull/24355 14:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:05 -!- hashfuncb3b [~user@2601:5c0:c280:7090:fd34:28ad:6238:526d] has joined #bitcoin-core-dev 14:07 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Ping timeout: 240 seconds] 14:09 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev 14:11 < theStack> laanwj: i just noticed that our functional test framework maps `importprivkey` to `importdescriptors` for descriptor wallets (class RPCOverloadWrapper) 14:12 < theStack> so maybe my assumption that it only works for legacy wallets is just wrong... i will try in a bit 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:31 < bitcoin-git> [bitcoin] hebasto opened pull request #24847: ci: Bump vcpkg to the latest version `2022.04.12` (master...220413-vcpkg) https://github.com/bitcoin/bitcoin/pull/24847 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:31 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 250 seconds] 14:33 < laanwj> theStack: that would explain things 14:34 < laanwj> i mean after all it's passing, it doesn't explicitly request a bdb wallet, and descriptor wallets are the default nowadays? 14:36 < laanwj> this really confused me, but yes, that it maps the method could well be the explanation 14:36 < theStack> right now it does explicitly request bdb, there is a call to "self.skip_if_no_bdb()" 14:36 < theStack> would be nice if it works with both legacy and descriptor wallets though 14:38 < theStack> oh wait, skip_if_no_bdb doesn't mean that a run with descriptor wallets is prevented right... hm 14:40 < theStack> (locally calling the test with --descriptors fails for me, so i'm even more confused :D) 14:40 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 14:42 < laanwj> skip_if_no_bdb means 'skip if bitcoind is not built with bdb', it does not do amnything else 14:43 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 14:45 < laanwj> that's very strange as --descriptors defaults to true 14:49 < laanwj> you're right though, it does 14:49 < laanwj> can't we make this test work without wallet? 14:51 < laanwj> it doesn't ever check the wallet, what does it use it for 14:51 < theStack> looks like the default used is BDB, ("# Prefer BDB unless it isn't available"), see test_framework.py:216 oO probably this should be changed to default to descriptor wallets 14:53 < theStack> the signet mining script calls the `walletprocesspsbt` RPC, that's why a wallet is needed on the node 14:53 < laanwj> that's super surprising after first defaulting the other way around 14:53 < laanwj> ohh it's internal to the script, that makes sense 14:56 < theStack> and that seems also to be the call that fails if a descriptor wallet is used, i'm trying to find out why... 15:00 < laanwj> but the answer to my initial question "how does a functional test explicitly request a bdb wallet?" seems to be "it doesn't", it's decided from outside, all it can do is skip the test if self.options.descriptors==True 15:03 -!- ExEric3 [~exeric3@mail.miners-zone.net] has quit [Read error: Connection reset by peer] 15:04 -!- ExEric3 [~exeric3@mail.miners-zone.net] has joined #bitcoin-core-dev 15:04 < theStack> yes, i agree 15:05 < theStack> interesting that the CI didn't fail, i thought we have a target that only has descriptor wallet support but not legacy wallet (didn't check though) 15:05 < theStack> ah, but then the test is skipped due to bdb missing 15:05 -!- An0rak [An0rak@user/an0rak] has quit [Ping timeout: 250 seconds] 15:15 < laanwj> yes, if bdb is available it will apparently run with that, if bdb is missing it skips due to skip_if_no_bdb 15:16 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 15:17 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 15:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 248 seconds] 15:23 < theStack> so, it seems that the problem is that the descriptor wallet can't sign the 1-of-1 multisig script 15:23 < theStack> if i change the signetchallenge to a p2wpkh script, it works with both legacy and descriptor wallet 15:24 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:24 < theStack> (1-of-1 multisig doesn't make sense of course, but for some reason i wrongly assumed that signet requests a multisig challenge) 15:29 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:35 -!- hashfuncb3b [~user@2601:5c0:c280:7090:fd34:28ad:6238:526d] has quit [Ping timeout: 250 seconds] 15:41 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 15:41 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 15:49 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 15:57 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 15:57 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 16:03 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 248 seconds] 16:16 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 16:16 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 16:25 < laanwj> 1-of-1 multisig heh 16:26 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 16:27 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 16:27 < sipa> Trivia: is 0-of-0 OP_CHECKMULTISIG-based multisig allowed? 16:34 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 16:35 < theStack> i would have guessed no, but looking at the code it seems like it is allowed by consensus rules, but we don't treat it as standard? 16:36 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection] 16:38 < theStack> (if that is true, i wonder how many 0-of-0 multisig outputs can be found on the main chain :D) 17:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 17:08 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:09 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:12 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:13 -!- shesek_ [~shesek@user/shesek] has quit [Read error: Connection reset by peer] 17:25 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:25 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:34 < sipa> theStack: That's exactly my recollection 17:36 -!- bhelm [~brandon@2604:3d08:a185:9f00:622c:3e85:fc3f:3153] has quit [Quit: Leaving] 17:37 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:38 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-dev 17:42 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:45 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 260 seconds] 17:51 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404] 17:52 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 18:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:00 < bitcoin-git> [bitcoin] Kvaciral opened pull request #24849: lint: Convert lint-logs.sh to Python (master...lint-logs-port) https://github.com/bitcoin/bitcoin/pull/24849 18:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:14 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404] 18:15 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 18:22 < luke-jr> fanquake: is there background to #24722 somewhere? why doesn't it affect 23.x? 18:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/24722 | build: patch around qt duplicate symbol issue by fanquake · Pull Request #24722 · bitcoin/bitcoin · GitHub 18:33 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 19:22 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 19:30 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 248 seconds] 19:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Ping timeout: 260 seconds] 19:46 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 19:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has joined #bitcoin-core-dev 20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:01 < bitcoin-git> [bitcoin] seejee opened pull request #24851: consensus: ignore BIP-30 verification in DisconnectBlock for problematic blocks (master...bip30-disconnect-block) https://github.com/bitcoin/bitcoin/pull/24851 20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:10 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Remote host closed the connection] 20:10 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev 20:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Ping timeout: 248 seconds] 21:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:08 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev 21:29 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 256 seconds] 22:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:15 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/decde9bba6f9...8e3c266a4f02 22:15 < bitcoin-git> bitcoin/master a4f4f89 Samer Afach: Replace uint256 specific implementations of base_uint::GetHex() and base_u... 22:15 < bitcoin-git> bitcoin/master 8e3c266 laanwj: Merge bitcoin/bitcoin#24077: util: Make base_uint::GetHex() and base_uint:... 22:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:16 < bitcoin-git> [bitcoin] laanwj merged pull request #24077: util: Make base_uint::GetHex() and base_uint::SetHex() not depend on uint256 (master...fix/arith_uint256-specializations) https://github.com/bitcoin/bitcoin/pull/24077 22:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:23 < bitcoin-git> [bitcoin] martinus opened pull request #24852: util: optimizes HexStr (master...2022-03-HexStr-optimizations) https://github.com/bitcoin/bitcoin/pull/24852 22:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:52 -!- Willtech [~Willtech@user/Willtech] has quit [Remote host closed the connection] 22:52 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 248 seconds] 23:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9] has quit [Ping timeout: 248 seconds] 23:21 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:51 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 23:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:59 < bitcoin-git> [bitcoin] laanwj closed pull request #24273: p2p: Split network logging into two categories #24247 (master...first_issue) https://github.com/bitcoin/bitcoin/pull/24273 23:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] --- Log closed Thu Apr 14 00:00:54 2022