--- Log opened Wed Apr 27 00:00:06 2022
00:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
00:16 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
00:22 < laanwj> why embarassed? spradic failures can indicate a real problem like a race condition
00:22 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 276 seconds]
00:22 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
00:22 < laanwj> agreed, usually it's just timeout nonsense, but still
00:28 < fanquake> laanwj: was just being sarcastic
00:29 < laanwj> kay :)
00:35 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
00:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
00:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 240 seconds]
00:48 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:55 -!- baldur [~baldur@pool-74-108-229-157.nycmny.fios.verizon.net] has quit [Ping timeout: 276 seconds]
01:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 256 seconds]
01:11 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
01:15 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Client Quit]
01:15 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
01:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
01:18 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
01:18 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 248 seconds]
01:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 240 seconds]
01:27 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 240 seconds]
01:36 < laanwj> with all the PR spam about one word, i wonder if we can't just remove the "What is bitcoin" section from the readme, everyone has their own ideas about it anywhere, replace it with a small blurb what bitcoin core (this specific software) does
01:39 < laanwj> there's zero argument about that, and if there is, one can simly check the code
01:47 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
01:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
01:49 -!- evanlinjin__ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
01:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 260 seconds]
01:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has joined #bitcoin-core-dev
02:01 -!- evanlinjin__ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
02:13 -!- cold [~cold@user/cold] has quit [Ping timeout: 240 seconds]
02:13 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 260 seconds]
02:15 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev
02:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
02:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 240 seconds]
02:54 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
03:01 -!- Flow [~none@gentoo/developer/flow] has quit [Remote host closed the connection]
03:02 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has quit [Ping timeout: 250 seconds]
03:08 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev
03:26 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
03:27 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
03:31 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds]
03:31 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has joined #bitcoin-core-dev
03:37 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has quit [Ping timeout: 250 seconds]
03:46 -!- cryptoquick8 [~cryptoqui@8.46.89.33] has joined #bitcoin-core-dev
03:46 -!- cryptoquick [~cryptoqui@8.46.89.33] has quit [Ping timeout: 260 seconds]
03:46 -!- cryptoquick8 is now known as cryptoquick
03:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has joined #bitcoin-core-dev
04:00 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
04:04 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds]
04:16 < PaperSword> I don't quite have a statement on the "What is bitcoin" section. Search engine SEO might be a reason to leave it. Plus it does implicitly separate the bitcoin protocol from the software.
04:17 < PaperSword> If that section does remain long term it might be nice to link the whitepaper instead of leaving it to the user to find it. Just my 2 sats
04:17 < fanquake> we aren't going to link to the whitepaper. that we removed on purpose, and not a discussion we need to rehash
04:18 < PaperSword> sorry I was not around for that.
04:18 < fanquake> No worries. You can find all the relevant discussion on GitHub
04:20 < PaperSword> So I can see the commit where it was removed. How would I go about finding the discussing associated with that action.
04:20 < PaperSword> https://github.com/bitcoin/bitcoin/commit/77772a1b809e443a6861ee49009ff8bc55cff9c3
04:21 < PaperSword> found the way :D 
04:21 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
04:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 240 seconds]
05:02 -!- evanlinjin__ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
05:03 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
05:04 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
05:04 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has quit [Ping timeout: 248 seconds]
05:05 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:06 < bitcoin-git> [bitcoin] mruddy opened pull request #25000: gui: avoid unclean exit due to permissions issues when setting start on system startup (master...issue_24953) https://github.com/bitcoin/bitcoin/pull/25000
05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
05:10 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
05:10 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:10 < bitcoin-git> [bitcoin] mruddy closed pull request #25000: gui: avoid unclean exit due to permissions issues when setting start on system startup (master...issue_24953) https://github.com/bitcoin/bitcoin/pull/25000
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:11 < MarcoFalke> sipa: Should I open a new pull or push to your repo? (:sweat-smile:)
05:13 < sipa> @MarcoFalke Ha, do I even have that enabled?
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:14 < bitcoin-git> [bitcoin] sipa closed pull request #24764: Modernize util/strencodings and util/string: `string_view` and `optional` (master...202204_stringview) https://github.com/bitcoin/bitcoin/pull/24764
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:14 < MarcoFalke> heh, it is enabled by default for maintainers for anyone that opens a pull
05:14 < sipa> Anyway, closed it - feel free to open your own.
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25001: Modernize util/strencodings and util/string: `string_view` and `optional` (master...2204-span-stuff-🐘) https://github.com/bitcoin/bitcoin/pull/25001
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:20 < MarcoFalke> thx, done
05:25 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
05:27 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
05:31 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has joined #bitcoin-core-dev
05:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:35 < bitcoin-git> [gui] mruddy opened pull request #595: gui: avoid unclean exit due to permissions issues when setting start on system startup (master...issue_24953) https://github.com/bitcoin-core/gui/pull/595
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:37 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:adf2:32d7:1c5a:583f] has quit [Ping timeout: 250 seconds]
05:44 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
05:48 -!- jungly [~jungly@host-62-211-28-62.retail.telecomitalia.it] has joined #bitcoin-core-dev
05:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:51 < bitcoin-git> [gui] hebasto merged pull request #589: Getting ready to Qt 6 (7/n). Do not pass `WalletModel*` to a queued connection (master...220420-walletmodel) https://github.com/bitcoin-core/gui/pull/589
05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:51 < bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f58c1f1a4467...0b8e2868f5cb
05:51 < bitcoin-git> bitcoin/master 61457c1 Hennadii Stepanov: refactor: Guard `RPCConsole::{add,remove}Wallet()` with `ENABLE_WALLET`
05:51 < bitcoin-git> bitcoin/master fdf7285 Hennadii Stepanov: refactor: Make `RPCExecutor*` a member of the `RPCConsole` class
05:51 < bitcoin-git> bitcoin/master ab73d59 Hennadii Stepanov: Do not pass `WalletModel*` to queued connection
05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:57 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:bc46:d63f:2e5f:7485] has joined #bitcoin-core-dev
06:07 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
06:14 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
06:20 -!- Guest45 [~Guest45@197.184.172.157] has joined #bitcoin-core-dev
06:22 -!- Guest45 [~Guest45@197.184.172.157] has quit [Client Quit]
06:33 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
06:37 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
06:39 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
06:41 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Client Quit]
06:42 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
06:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 250 seconds]
07:04 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
07:05 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
07:15 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds]
07:16 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
07:21 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
07:25 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 240 seconds]
07:38 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:44 < bitcoin-git> [bitcoin] theStack opened pull request #25003: tracing: fix `coin_selection:aps_create_tx_internal` calling logic (master...202204-tracing_fix_coin_selection-aps_create_tx_internal_log) https://github.com/bitcoin/bitcoin/pull/25003
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:54 -!- realies [~realies@user/realies] has quit [Ping timeout: 256 seconds]
08:01 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
08:02 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:09 < bitcoin-git> [bitcoin] furszy opened pull request #25005: wallet: remove extra wtx lookup in 'AvailableCoins' + several code improvements. (master...2022_availableBalance_improvements) https://github.com/bitcoin/bitcoin/pull/25005
08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds]
08:12 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
08:19 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:19 < bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/0b8e2868f5cb...132d5f8c2f23
08:19 < bitcoin-git> bitcoin/master c1d165a Pieter Wuille: Make ParseHex use string_view
08:19 < bitcoin-git> bitcoin/master 4006299 Pieter Wuille: Make IsHex use string_view
08:19 < bitcoin-git> bitcoin/master 963bc9b Pieter Wuille: Make IsHexNumber use string_view
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:20 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
08:20 -!- jarthur [~jarthur@user/jarthur] has quit [Client Quit]
08:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:23 < bitcoin-git> [bitcoin] fanquake closed pull request #25001: Modernize util/strencodings and util/string: `string_view` and `optional` (master...2204-span-stuff-🐘) https://github.com/bitcoin/bitcoin/pull/25001
08:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:31 < bitcoin-git> [bitcoin] fanquake opened pull request #25006: guix: consolidate kernel headers to 4.19, specify 3.2.0 as minimum supported (master...specify_minimum_kernel) https://github.com/bitcoin/bitcoin/pull/25006
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:40 -!- baldur [~baldur@pool-74-108-229-157.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:41 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 250 seconds]
08:46 -!- Willtech [~Willtech@user/Willtech] has quit [Quit: Willtech]
08:47 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
08:54 -!- Willtech [~Willtech@user/Willtech] has quit [Quit: Willtech]
08:55 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
09:13 -!- vasild [~vd@user/vasild] has quit [Quit: leaving]
09:15 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 246 seconds]
09:15 < achow101> 23.0 release notes missing the big PR list
09:20 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25009: Crash debug builds on PCKG_MEMPOOL_ERROR (master...2204-crash-debug-🏦) https://github.com/bitcoin/bitcoin/pull/25009
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
09:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection]
09:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
10:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/132d5f8c2f23...f0a834e2f10a
10:02 < bitcoin-git> bitcoin/master 77ccb7f Gleb Naumenko: Use std::chrono for salting when randomizing ADDR destination
10:02 < bitcoin-git> bitcoin/master 2ff8f4d Gleb Naumenko: Add tests for addr destination rotation
10:02 < bitcoin-git> bitcoin/master f0a834e MacroFake: Merge bitcoin/bitcoin#18642: Use std::chrono for the time to rotate destin...
10:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18642: Use std::chrono for the time to rotate destination of addr messages + tests (master...2020_04_mock_addr_rotation_time) https://github.com/bitcoin/bitcoin/pull/18642
10:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:07 -!- franks [~dsd@user/ironsoba] has quit [Ping timeout: 276 seconds]
10:15 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
10:18 -!- jungly [~jungly@host-62-211-28-62.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
10:23 -!- stijn [~stijn@2a02-a44e-3f48-1-831a-d2c7-df9f-e068.fixed6.kpn.net] has joined #bitcoin-core-dev
10:27 -!- stijn [~stijn@2a02-a44e-3f48-1-831a-d2c7-df9f-e068.fixed6.kpn.net] has quit [Client Quit]
10:42 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
10:46 < laanwj> achow101: someone noticed!
10:46 < achow101> was that intentional?
10:48 < laanwj> no entirely, though i have had my doubts whether it still was worth the trouble, as it's so many lines, and people are encouraged to write release notes for things that are notable or impactful enough
10:48 < laanwj> but also for 23.0 i simply forgot it and no one reminded me
10:51 < laanwj> but this works as a way to see if people miss it; you're the first to mention it at all
10:57 < jeremyrubin> i think the PR list is a good idea, the acknowledgement less so :)
10:58 < jeremyrubin> i usually do scan through the PR list 
10:59 < achow101> it's sometimes useful
10:59 < achow101> it mostly just felt like the release notes were too short and I finally figured out why
11:13 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev
11:22 < Murch> Definitely useful for downstream users. I would go over the list when I was evaluating whether a Bitcoin Core release may cause additional upgrade hurdles for the backend integration at my previous employer's
11:24 < instagibbs> ditto
11:25 < sipa> Murch: Arguably, if that were the case, those things should be listed in the actual release notes, though.
11:29 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
11:29 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Remote host closed the connection]
11:29 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev
11:32 < Murch> Not if you're running a patched version of Bitcoin Core for some reason
11:34 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 240 seconds]
11:52 < sipa> Ah, fair.
11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:56 < bitcoin-git> [bitcoin] achow101 opened pull request #25011: tests: Do not always create a descriptor wallet in wallet_createwallet (master...fix-legacy-createwallet-test) https://github.com/bitcoin/bitcoin/pull/25011
11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:58 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
12:11 -!- Guest59 [~Guest59@130.105.211.122] has joined #bitcoin-core-dev
12:11 -!- Guest59 [~Guest59@130.105.211.122] has quit [Client Quit]
12:33 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:55 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 250 seconds]
13:00 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection]
13:00 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
13:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 240 seconds]
13:13 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
13:30 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev
14:06 -!- Guest61 [~Guest61@2620:10d:c090:500::2:cef] has joined #bitcoin-core-dev
14:07 -!- Guest61 [~Guest61@2620:10d:c090:500::2:cef] has quit [Client Quit]
14:24 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
14:31 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:36 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
14:57 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 272 seconds]
15:08 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 276 seconds]
15:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 250 seconds]
15:41 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:45 -!- DeanGuss [~dean@user/deanguss] has quit [Quit: buhbye]
15:45 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:49 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #bitcoin-core-dev
15:49 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host]
15:49 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-core-dev
15:55 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection]
15:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
16:04 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Remote host closed the connection]
16:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
16:17 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 250 seconds]
16:39 -!- cryptoquick0 [~cryptoqui@8.46.89.33] has joined #bitcoin-core-dev
16:40 -!- cryptoquick [~cryptoqui@8.46.89.33] has quit [Ping timeout: 240 seconds]
16:40 -!- cryptoquick0 is now known as cryptoquick
16:41 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:bc46:d63f:2e5f:7485] has quit [Quit: Client closed]
16:45 -!- cryptoquick [~cryptoqui@8.46.89.33] has quit [Quit: Ping timeout (120 seconds)]
16:46 -!- cryptoquick [~cryptoqui@8.46.89.33] has joined #bitcoin-core-dev
16:47 -!- sipa [~sipa@user/sipa] has quit [Ping timeout: 240 seconds]
16:47 -!- Murch [~murch@user/murch] has quit [Ping timeout: 240 seconds]
16:47 -!- whitehorse[m] [~whitehors@2001:470:69fc:105::1:f3cf] has quit [Ping timeout: 240 seconds]
16:48 -!- whitehorse[m] [~whitehors@2001:470:69fc:105::1:f3cf] has joined #bitcoin-core-dev
16:49 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-dev
16:50 -!- Murch [~murch@user/murch] has joined #bitcoin-core-dev
17:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Remote host closed the connection]
17:20 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 246 seconds]
17:21 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev
17:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
17:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 250 seconds]
17:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
17:56 -!- Willtech [~Willtech@user/Willtech] has quit [Quit: Willtech]
17:56 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
18:14 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
18:17 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
18:20 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 240 seconds]
18:42 -!- Willtech [~Willtech@user/Willtech] has quit [Quit: Willtech]
18:43 -!- Willtech [~Willtech@user/Willtech] has joined #bitcoin-core-dev
18:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 260 seconds]
18:51 < jamesob> hmmmmm have we totally-definitely-certainly outlawed `goto` use?
18:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
18:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:55 < _aj_> jamesob: "how can i do [pastebin] better than using goto?"
18:59 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
18:59 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
19:03 < jamesob> _aj_: it's just so tempting to pretend I'm a kernel hacker rather than introduce yet another refactoring commit
19:06 < jamesob> and debatably what this would be replacing is less clear than goto IMO (using `continue` in a do-while to do poor man's recursion during init)
19:06 < jamesob> but I'll relent, despite always being on the lookout for innovative ways to make assumeutxo PRs harder to merge
19:07 < sipa> Unless you're using it in a super tight performance-critical loop, and there is no way to achieve the same performance with a more structured approach... I'd say no.
19:11 < jamesob> sipa: you mean "yes[, we have outlawed goto]"
19:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
19:18 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:bc46:d63f:2e5f:7485] has joined #bitcoin-core-dev
19:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection]
19:21 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
19:21 < sipa> we have a goto somewhere in the codebase!
19:21 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
19:21 < sipa> there's at least one in src/crypto/poly1305 i believe
19:22 < sipa> (but it's code copied from elsewhere)
19:26 < jamesob> IIRC dongcarl tried to introduce one recently to the libbitcoinkernel client code
19:27 < dongcarl> Yup
19:27 < dongcarl> It's example code and will be moved to src/kernel/example in future PRs tho
19:49 < luke-jr> aren't examples usually under contrib/ ?
19:56 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
20:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 260 seconds]
20:27 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
20:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev
20:33 < jeremyrubin> jamesob: show me a code snippet and i'll show you goto free code 
20:36 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
20:44 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
20:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
20:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
21:19 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 250 seconds]
21:38 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
21:40 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
21:46 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 276 seconds]
21:47 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
22:19 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev
22:23 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 250 seconds]
22:25 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
22:43 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds]
22:44 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0a834e2f10a...4381681e554d
22:44 < bitcoin-git> bitcoin/master 786b3a7 Andrew Chow: tests: Do not always create a descriptor wallet in wallet_createwallet
22:44 < bitcoin-git> bitcoin/master 4381681 MacroFake: Merge bitcoin/bitcoin#25011: tests: Do not always create a descriptor wall...
22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25011: tests: Do not always create a descriptor wallet in wallet_createwallet (master...fix-legacy-createwallet-test) https://github.com/bitcoin/bitcoin/pull/25011
22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:55 -!- Alina-malina [~Alina-mal@user/alina-malina] has quit [Ping timeout: 246 seconds]
22:59 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev
23:05 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
23:08 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds]
23:24 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
23:30 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
23:32 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
23:46 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds]
23:55 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev
--- Log closed Thu Apr 28 00:00:07 2022