--- Log opened Thu Apr 28 00:00:07 2022 00:00 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 00:01 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:09 -!- hashfunc1ebd [~user@128-092-093-090.biz.spectrum.com] has joined #bitcoin-core-dev 00:14 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds] 00:16 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds] 00:17 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 00:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 00:22 -!- Willtech [~Willtech@user/Willtech] has quit [Remote host closed the connection] 00:28 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 00:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:32 < laanwj> if you're running a patched version you should be able to ask git for the necessary information yourself, though 00:33 < laanwj> so i'm still not really convinced 00:33 < laanwj> jamesob: yes, goto has no place in C++ code, in C code it's sometimes ok 00:34 < laanwj> in C code it's useful (often, the least insane way) to do cleanup in case of errors, in C++ code you should use RAII for cleanup instead 00:36 < laanwj> please avoid "kernel hacking" in this project if possible, if dumb, easy to understand code (in far as that's even possible with C++) suffices, go for that, the less tricks and surprises the better 00:36 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:39 < laanwj> anyhow wrt the merge list: the only thing git log --merges v.... v.... *doesn't* do is sort the PRs per category, but this is a painstaking process anyway, there's some automation using the github API and labels but it's often only a heuristic and still needs careful checking 00:40 < laanwj> for 23.0 i just didn't get around to that, if someone else does i'm not going to stop them 00:40 < laanwj> well, for next release i man, for 23.0 it's too late 00:41 < laanwj> mean* 00:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 240 seconds] 00:44 -!- hashfunc1ebd [~user@128-092-093-090.biz.spectrum.com] has quit [Ping timeout: 272 seconds] 00:51 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds] 00:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4381681e554d...9446de160f37 01:08 < bitcoin-git> bitcoin/master c79ad93 fanquake: refactor: fix includes in src/compat 01:08 < bitcoin-git> bitcoin/master 74cd038 fanquake: refactor: fix includes in src/init 01:08 < bitcoin-git> bitcoin/master 9b0a13a fanquake: tidy: Add include-what-you-use 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24831: tidy: add include-what-you-use (master...include_what_you_use) https://github.com/bitcoin/bitcoin/pull/24831 01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:00 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: You have been kicked for being idle] 02:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Ping timeout: 260 seconds] 02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:10 < bitcoin-git> [bitcoin] laanwj opened pull request #25012: doc: Update blurb in README.md (master...2022-04-readme-blurb) https://github.com/bitcoin/bitcoin/pull/25012 02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:12 -!- NorrinRadd [~username@102.67.16.112] has quit [Ping timeout: 256 seconds] 02:14 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 02:14 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev 02:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:24 < bitcoin-git> [bitcoin] laanwj closed pull request #25012: doc: Update blurb in README.md (master...2022-04-readme-blurb) https://github.com/bitcoin/bitcoin/pull/25012 02:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:25 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25013: Remove cs_main from verifymessage, move msg utils to new file (master...2204-rpc-misc-🔌) https://github.com/bitcoin/bitcoin/pull/25013 02:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has joined #bitcoin-core-dev 02:47 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 02:50 < laanwj> re: #25012 I really hoped to remove the 'whether bitcoin is experimental' concern from our repo once and for all, but seems it just comes back in a different form then, really, never mind 02:50 <@gribble> https://github.com/bitcoin/bitcoin/issues/25012 | doc: Update blurb in README.md by laanwj · Pull Request #25012 · bitcoin/bitcoin · GitHub 02:54 < laanwj> 'File "..." contains a shebang line, but has the file permission 775 instead of the expected executable permission 755. Do "chmod 755 test/lint/lint-python-mutable-default-parameters.py" (or remove the shebang line)' huh 02:55 < fanquake> laanwj: I think removing that is fine 03:10 < laanwj> fanquake: thanks 03:12 < _aj_> laanwj: <3 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/9446de160f37...b51e60f91472 03:17 < bitcoin-git> bitcoin/master 98f4bda Carl Dong: refactor: Convert warningcache to std::array 03:17 < bitcoin-git> bitcoin/master 6e747e8 Anthony Towns: validation: default initialize and guard chainman members 03:17 < bitcoin-git> bitcoin/master 5921b86 Carl Dong: init: Reset mempool and chainman via reconstruction 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22564: refactor: Move mutable globals cleared in `::UnloadBlockIndex` to `BlockManager` (master...2021-07-kirby-inhale-global-muts) https://github.com/bitcoin/bitcoin/pull/22564 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:18 < laanwj> _aj_: 💜 03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:29 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b51e60f91472...85aea18ae660 03:29 < bitcoin-git> bitcoin/master 29f44fe hiago: Converting `lint-all.sh` to `lint-all.py`. 03:29 < bitcoin-git> bitcoin/master 85aea18 laanwj: Merge bitcoin/bitcoin#24982: tests: Port `lint-all.sh` to `lint-all.py` 03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:29 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:29 < bitcoin-git> [bitcoin] laanwj merged pull request #24982: tests: Port `lint-all.sh` to `lint-all.py` (master...port_lint-all.sh_to_python) https://github.com/bitcoin/bitcoin/pull/24982 03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:40 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Quit: Konversation terminated!] 03:40 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 03:42 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Client Quit] 03:43 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 03:59 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 03:59 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 04:09 -!- Guest50 [~Guest50@2601:58b:c600:c390:dbf2:b052:d8fb:6245] has joined #bitcoin-core-dev 04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:29 < bitcoin-git> [bitcoin] laanwj opened pull request #25015: test: Use permissions from git in lint-files.py (master...2022-04-lint-permissions-git) https://github.com/bitcoin/bitcoin/pull/25015 04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:30 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 04:32 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 04:32 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds] 04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85aea18ae660...e36c612e5a9b 04:40 < bitcoin-git> bitcoin/master fa82a1e MacroFake: lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py 04:40 < bitcoin-git> bitcoin/master e36c612 fanquake: Merge bitcoin/bitcoin#24988: lint: Mention NONFATAL_UNREACHABLE in lint-as... 04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:41 < bitcoin-git> [bitcoin] fanquake merged pull request #24988: lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py (master...2204-lint-abort-🐛) https://github.com/bitcoin/bitcoin/pull/24988 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:44 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 04:45 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 276 seconds] 04:48 -!- mudsip [~mudsip@user/mudsip] has quit [] 05:27 -!- dougefish [~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239] has quit [Ping timeout: 250 seconds] 05:33 -!- dougefish [~dougefish@5.29.11.69] has joined #bitcoin-core-dev 05:38 -!- test_ is now known as _flood 05:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 05:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 06:05 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:39 < jamesob> jeremyrubin: no trouble constructing the goto-free code, just entails a lot of refactoring etc. 06:39 < jamesob> laanwj: don't worry, I was kidding about the "kernel hacking" comment 06:40 < jamesob> attempted humor not conveying well I guess 06:48 < _aj_> laanwj: or 🍦 06:48 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Quit: Konversation terminated!] 06:49 < laanwj> jamesob: sorry for taking it so serious, it's hard to gauge sometimes! 06:49 < laanwj> _aj_: yess 06:50 < jamesob> laanwj: no worries, I was just delirious and in a rambling mood during a rebase last night :) 06:50 < laanwj> jamesob: i meann remmeber that we have an actual system call sandbox in bitcoin core, it's scary close to kernel hacking 06:51 < jamesob> haha, good point! 06:54 -!- jespada [~jespada@194.37.96.158] has quit [Ping timeout: 240 seconds] 06:55 -!- jespada [~jespada@89.238.130.78] has joined #bitcoin-core-dev 06:58 < jonatack> 10 PRINT "HELLO WORLD" 20 GOTO 10 06:58 < sipa> what a basic joke 06:58 < jonatack> I think that was the first program I ever wrote :D 06:58 < sipa> mine's probably close 06:58 < jonatack> indeed basic 06:59 < jamesob> you guys are old-timers! my first program was in *visual* basic, truly high-tech stuff 07:00 < sipa> which version? i used visual basic 3, 5, and 6 07:02 -!- gnaf [~gnaf@163-172-90-106.rev.poneytelecom.eu] has joined #bitcoin-core-dev 07:02 < jamesob> all I remember was that it was on Windows ME... 07:02 < sipa> My condolences. 07:03 < jamesob> lol 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:15 < bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/e36c612e5a9b...dd17c42a1642 07:15 < bitcoin-git> bitcoin/master 1392e8e Carl Dong: build: Don't add unrelated libs to LIBTEST_* 07:15 < bitcoin-git> bitcoin/master 64caf94 Carl Dong: build: Remove vestigial LIBLEVELDB_SSE42 07:15 < bitcoin-git> bitcoin/master 05d1525 Carl Dong: build: Create .la library for crc32c 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:15 < bitcoin-git> [bitcoin] fanquake merged pull request #24322: [kernel 1/n] Introduce initial `libbitcoinkernel` (master...2022-02-libbitcoinkernel-p1-minimal) https://github.com/bitcoin/bitcoin/pull/24322 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:15 < laanwj> in MSX basic you could do this cursed thing where you stripped the line numbers, and replaced gotos by assignments to the interpreter pointer in the token stream— 07:16 < laanwj> there are things much worse than gotos :) 07:17 < sipa> Duff's device? 07:19 -!- Guest50 [~Guest50@2601:58b:c600:c390:dbf2:b052:d8fb:6245] has quit [Quit: Client closed] 07:20 < laanwj> yes, i'd say that qualifies 07:39 < laanwj> or what about the gcc computed goto extension 07:41 < laanwj> maybe it could be combined with a Duff's device for extra curse points 07:46 < cfields> libbitcoinkernel \o/ 07:48 < sipa> laanwj: Throw in another longjmp() too 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:49 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:49 < laanwj> cfields: oh no 07:50 < lightlike> maybe disguise the goto as "do{...} while(false)" with breaks and hope no one will notice (I think we had this kind of thing until recently) 07:52 < roconnor> https://github.com/bitcoin-core/secp256k1/blob/master/src/util.h#L93 07:53 < laanwj> sipa: ah ye our old friend longjmp, was surpised to see it actually used in freetype in #582 07:53 <@gribble> https://github.com/bitcoin/bitcoin/issues/582 | Bitcoin-Qt signmessage GUI by luke-jr · Pull Request #582 · bitcoin/bitcoin · GitHub 07:53 < sipa> That doesn't simulate a goto; it's a trick to construct a macro that works without branches in an if then else 07:53 < roconnor> oh, "with breaks" 07:54 < laanwj> the other 582 https://github.com/bitcoin-core/gui/issues/582 07:54 < roconnor> ... wait, I don't get it. 07:54 < sipa> roconnor: https://stackoverflow.com/questions/257418/do-while-0-what-is-it-good-for 07:56 < sipa> (not that we permit branchless if/then/elses in the first place, but it doesn't hurt...) 07:56 < roconnor> https://stackoverflow.com/a/257421 -- okay I'm impressed. 07:58 < sipa> lightlike roconnor: that approach has the advance that it still works in C++ code with new variables defined in the body (in C++ a goto cannot cross the definition of a variable) 07:59 < sipa> I don't know... I think that do ... break ... break ... while(0) pattern is a slight improvement over a goto, but I can see it'd be controversial 08:00 < roconnor> For me it has the advantage that it is supported by VST while goto is not. 08:01 < laanwj> i'd agree, it's "an improvement over a goto" but then also everything is said, if awkward constructions can completely be avoided that'd be even better 08:01 < roconnor> C has fewer ways of avoiding akward constructions than C++ does. 08:02 < laanwj> yes, very true 08:02 < sipa> at some point you just resort to an asm { ... } block ;) 08:03 < laanwj> sometimes a high level language just gets in the way :) 08:04 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:bc46:d63f:2e5f:7485] has quit [Quit: Client closed] 08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:04 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909 08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:06 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds] 08:17 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has joined #bitcoin-core-dev 08:20 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:7962:a6a5:10e5:4fc] has joined #bitcoin-core-dev 08:57 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 256 seconds] 09:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev 09:31 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:32 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Remote host closed the connection] 09:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 09:39 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev 09:52 < cfields> laanwj: "oh no" ? 09:53 < laanwj> cfields: i mean in the sense that there's an actual kernel in bitcoin now so we can't have anything against "kernel hacking" 09:54 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev 09:54 < laanwj> jamesob won 09:55 < sipa> "kernel" and "core" are practically synonyms anyway 09:55 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 09:56 < cfields> oh :) 10:04 < laanwj> but yeah i can see how that could be interpreted wrong, to be clear i really like libbitcoinkernel 10:11 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 10:16 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has joined #bitcoin-core-dev 10:17 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has quit [Client Quit] 10:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:18 < bitcoin-git> [bitcoin] jonatack opened pull request #25016: blockstorage, refactor: improve GetFirstStoredBlock() (master...GetFirstStoredBlock-improvements) https://github.com/bitcoin/bitcoin/pull/25016 10:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:19 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 260 seconds] 10:25 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:26 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd17c42a1642...47b8256da872 10:26 < bitcoin-git> bitcoin/master fafd674 MarcoFalke: test: Remove previous release check 10:26 < bitcoin-git> bitcoin/master 47b8256 laanwj: Merge bitcoin/bitcoin#24937: test: Remove previous release check in featur... 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:26 < bitcoin-git> [bitcoin] laanwj merged pull request #24937: test: Remove previous release check in feature_taproot.py (master...2204-noPrevRelTap-🏥) https://github.com/bitcoin/bitcoin/pull/24937 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:27 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/47b8256da872...8730bd3fc87c 10:27 < bitcoin-git> bitcoin/master bbbcb96 Hennadii Stepanov: build, refactor: Fix indentation 10:27 < bitcoin-git> bitcoin/master 65cddf6 Hennadii Stepanov: build: Fix `AC_CHECK_HEADERS` and `AC_CHECK_LIB` for `miniupnpc` package 10:27 < bitcoin-git> bitcoin/master 1659034 Hennadii Stepanov: build: Fix `AC_CHECK_HEADERS` and `AC_CHECK_LIB` for `libnatpmp` package 10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:27 < bitcoin-git> [bitcoin] laanwj merged pull request #24958: build: Fix macOS Apple M1 build with miniupnpc and libnatpmp. Again :) (master...220424-flags) https://github.com/bitcoin/bitcoin/pull/24958 10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:31 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 10:31 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:33 -!- Guest60 [~Guest60@ip5f5becb1.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 10:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:33 < bitcoin-git> [bitcoin] jonatack opened pull request #25017: validation: make the CScriptCheck::swap() member function `noexcept` (master...swap-noexcept) https://github.com/bitcoin/bitcoin/pull/25017 10:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:34 -!- Guest60 [~Guest60@ip5f5becb1.dynamic.kabel-deutschland.de] has quit [Client Quit] 10:50 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:54 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] scgbckbone opened pull request #25019: normalize (lowercase) master fp in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev 11:07 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Remote host closed the connection] 11:09 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 11:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection] 11:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 11:17 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection] 11:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8730bd3fc87c...dabec990135c 11:25 < bitcoin-git> bitcoin/master fab34d3 MarcoFalke: Call CHECK_NONFATAL only once where needed 11:25 < bitcoin-git> bitcoin/master dabec99 MacroFake: Merge bitcoin/bitcoin#24956: Call CHECK_NONFATAL only once where needed 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24956: Call CHECK_NONFATAL only once where needed (master...2204-once-check-tip-🦅) https://github.com/bitcoin/bitcoin/pull/24956 11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:36 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection] 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:37 < bitcoin-git> [bitcoin] hebasto opened pull request #25020: contrib: Check symbols in the `bitcoinconsensus` shared library (master...220428-shared) https://github.com/bitcoin/bitcoin/pull/25020 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:54 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dabec990135c...4cf9fa0b662a 11:54 < bitcoin-git> bitcoin/master 2052e3a Martin Zumsande: wallet: ignore chainStateFlushed notifications while attaching chain 11:54 < bitcoin-git> bitcoin/master 4cf9fa0 Andrew Chow: Merge bitcoin/bitcoin#24984: wallet: ignore chainStateFlushed notification... 11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:55 < bitcoin-git> [bitcoin] achow101 merged pull request #24984: wallet: ignore chainStateFlushed notifications while attaching chain (master...202204_wallet_rescan) https://github.com/bitcoin/bitcoin/pull/24984 11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:55 < hebasto> cfields: in the context of your https://github.com/bitcoin/bitcoin/pull/24322#issuecomment-1112453779 mind looking into #24387 ? 11:55 <@gribble> https://github.com/bitcoin/bitcoin/issues/24387 | build: Fail to build `libmultiprocess` for the `arm-linux-gnueabihf` target · Issue #24387 · bitcoin/bitcoin · GitHub 12:00 < laanwj> #startmeeting 12:00 < core-meetingbot> Meeting started Thu Apr 28 19:00:52 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 12:00 < core-meetingbot> Available commands: action commands idea info link nick 12:01 < hebasto> hi 12:01 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball 12:01 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 12:01 < glozow> hi 12:01 < sipsorcery> hi 12:01 < sipa> hi 12:01 < laanwj> welcome to the weekly general bitcoin-core-dev meeting! 12:02 < laanwj> there have been no topics proposed in advance using #proposedmeetingtopic, any last minute ones people would like to discuss today? 12:02 < cfields> hi 12:02 < jonatack> 10 print "hi" 20 goto 10 12:03 < dongcarl> I can give a very quick update/announcement on libbitcoinkernel if no other topics are there 12:03 < lightlike> hi 12:03 < laanwj> dongcarl: sounds good to me, let's have that as topic after high prio for review 12:03 < dongcarl> cool 12:04 < jonatack> dongcarl: post-merge ack modulo the clang build chatter ;) 12:04 < kanzure> hi 12:04 < jeremyrubin> Hi 12:04 < laanwj> #topic High priority for review 12:04 < core-meetingbot> topic: High priority for review 12:05 < laanwj> currently 11 blockers 1 chasing concept ACK https://github.com/bitcoin/bitcoin/projects/8 12:05 < laanwj> anything to add/remove? 12:05 < achow101> hi 12:05 < laanwj> or that's on the list and (almost) ready for merge 12:06 < lightlike> #24322 was merged and can be removed 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub 12:06 < glozow> #23443 seems close, though needs rebase 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub 12:07 < jonatack> #24757 for me, please 12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/24757 | build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI by jonatack · Pull Request #24757 · bitcoin/bitcoin · GitHub 12:07 < laanwj> lightlike: even better! should we add the next one dongcarl? 12:08 < laanwj> glozow: thanks! 12:08 < dongcarl> Yes! #24410 it is 12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub 12:08 < laanwj> jonatack: added 12:08 < sipa> kernel 2a is written in c++2a? 12:09 < dongcarl> Hahaha I wish! 12:09 < laanwj> dongcarl: added 12:09 < dongcarl> laanwj: Thanks! 12:10 < laanwj> #topic Quick update on libbitcoinkernel (dongcarl) 12:10 < core-meetingbot> topic: Quick update on libbitcoinkernel (dongcarl) 12:10 < dongcarl> Hi all, after the merge of #24322, the initial build systems changes of libbitcoinkernel are done. 12:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub 12:11 < dongcarl> We will now be doing the more meaningful part of decoupling consensus from other modules. I hope that these PRs will have a wider review base, since it doesn’t require any knowledge of build system minutiae. 12:11 < dongcarl> The first PR ready for review is #24410, which is fairly straightforward. 12:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub 12:11 < dongcarl> A lot of these PRs are not dependent on each other, so at times we will have multiple PRs that are ready for review and not based on one another. There’s no need to wait for a PR to be merged to review the other one! 12:11 < jonatack> laanwj: ty! 12:11 < dongcarl> One last note: I’m happy to chat about any of these PRs to get people up to speed. It also helps me know what parts are unclear so I can improve my docs/commit messages. 12:11 < dongcarl> Hit me up on any communication channel, and I'm also more than happy to do a video/audio call for better bandwidth 12:12 * dongcarl is done, but can answer questions if people have any 12:12 < sipa> Cool. 12:12 < laanwj> dongcarl: thanks for the update 12:13 < dongcarl> :) 12:13 < laanwj> sounds clear to me, there's a lot to review but hopefully we can make quite some progress before 24.0 12:14 < dongcarl> Yup that is my hope too. If anyone spots anything that I could be doing to make things easier to review, let me know! 12:14 < hebasto> dongcarl: thanks! 12:14 < jonatack> dongcarl: do you recommend we developers build with --enable-experimental-util-chainstate or --with-experimental-kernel-lib? (for the moment i have both in my bash alias) 12:15 < dongcarl> jonatack: setting --enable-experimental-util-chainstate will automatically turn on --with-experimental-kernel-lib, unless you set --without-experimental-kernel-lib, in which case configure will fail 12:16 < laanwj> heh 12:16 < jonatack> ok, thanks, so --enable-experimental-util-chainstate sgtm then (and [kernel 2a/n] looks straightforward to review) 12:16 < dongcarl> jonatack: :-) 12:17 < cfields> atm the results are intended to be not very usable, but the kernel lib and bitcoin-chainstate (excluding some windows weirdness) should at least build successfully. Please report if that's not the case anywhere. 12:18 < dongcarl> Many thanks to cfields who got me through various tough situations in kernel 1/n and in upcoming PRs 12:19 < cfields> thanks ryanofsky for great review as well. 12:19 < dongcarl> ryan truly is of the sky 12:21 < laanwj> i guess that concludes the meeting, or does anyone have any last last minute topic 12:21 < jonatack> following the review feedback by both of you on [kernel 1a] was enlightening, as were the excellent commit messages 12:23 < laanwj> thanks everyone for attending, see you next week 12:23 < laanwj> #endmeeting 12:23 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 12:23 < core-meetingbot> Meeting ended Thu Apr 28 19:23:11 2022 UTC. 12:23 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-04-28-19.00.moin.txt 12:23 < dongcarl> jonatack: Haha I'm glad you think so! :-) 12:23 < dongcarl> laanwj: Thanks! 12:29 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev 12:44 < jamesob> dongcarl: looking forward to reviewing 2/n! 12:49 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:51 < dongcarl> jamesob: 🎉 13:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:00 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4cf9fa0b662a...606ce05ec225 13:00 < bitcoin-git> bitcoin/master 9687659 Seibart Nedor: wallet: ensure wallet files are not reused across chains 13:00 < bitcoin-git> bitcoin/master 5f21321 Seibart Nedor: tests: add tests for cross-chain wallet use prevention 13:00 < bitcoin-git> bitcoin/master 606ce05 Andrew Chow: Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused ac... 13:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:00 < bitcoin-git> [bitcoin] achow101 merged pull request #18554: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/18554 13:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:33 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 276 seconds] 13:41 < fanquake> jonatack: what clang build chatter ? 13:46 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 246 seconds] 14:25 < jonatack> fanquake: https://github.com/bitcoin/bitcoin/pull/24322#issuecomment-1079367319 14:29 < jonatack> can be ironed gradually along with any other more significant issues that come up 14:41 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 14:42 -!- dlb76 [~dlb76@user/dlb76] has joined #bitcoin-core-dev 14:57 < dongcarl> achow101: Known failure? https://cirrus-ci.com/task/4571677035069440 15:04 < cfields> hebasto: i'm not ignoring you btw, just investigating more fully and waiting to put all my thoughts in one place. 15:07 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:7962:a6a5:10e5:4fc] has quit [Quit: Client closed] 15:16 < achow101> dongcarl: not to me 15:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 248 seconds] 15:22 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Remote host closed the connection] 15:25 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:30 < jonatack> fixing 15:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:32 < bitcoin-git> [bitcoin] jonatack opened pull request #25021: test: fix intermittent wallet_encryption functional test (master...fix-intermittent-wallet_encryption-test) https://github.com/bitcoin/bitcoin/pull/25021 15:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:01 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 250 seconds] 16:20 -!- tecnecio [~tecnecio_@84.121.106.211.dyn.user.ono.com] has joined #bitcoin-core-dev 16:22 < hebasto> cfields: thank you 16:34 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 17:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581] has quit [Remote host closed the connection] 17:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection] 17:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has joined #bitcoin-core-dev 17:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has quit [Ping timeout: 240 seconds] 18:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has joined #bitcoin-core-dev 18:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 18:19 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 18:39 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 19:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has quit [Ping timeout: 260 seconds] 19:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection] 19:13 < luke-jr> if (newSize < FONT_RANGE.width() || newSize > FONT_RANGE.height()) 19:13 < luke-jr> wut @.@ 19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has joined #bitcoin-core-dev 19:25 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 19:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 19:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 250 seconds] 19:45 -!- An0rak [An0rak@user/an0rak] has joined #bitcoin-core-dev 20:07 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 20:20 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has joined #bitcoin-core-dev 20:41 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 20:45 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Ping timeout: 250 seconds] 20:57 -!- ziggie [uid521459@user/ziggie] has quit [Quit: Connection closed for inactivity] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:11 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev 21:25 -!- ryanofsky [~russ@jumpy.yanofsky.org] has quit [Ping timeout: 260 seconds] 21:26 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 21:27 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 21:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has joined #bitcoin-core-dev 22:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c] has quit [Remote host closed the connection] 22:24 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 22:28 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds] 22:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has quit [Ping timeout: 240 seconds] 22:38 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Read error: Connection reset by peer] 22:39 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 22:43 -!- ronoaldo [~ronoaldo@191.19.24.11] has quit [Quit: Konversation terminated!] 22:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has joined #bitcoin-core-dev 22:49 -!- An0rak [An0rak@user/an0rak] has quit [Read error: Connection reset by peer] 23:05 -!- Guest9070 [~Guest90@2601:204:ed80:62a0:c1c2:c9e8:a21:e083] has joined #bitcoin-core-dev 23:08 -!- Guest9070 [~Guest90@2601:204:ed80:62a0:c1c2:c9e8:a21:e083] has quit [Client Quit] 23:08 -!- cowboyted [~cowboyted@2601:204:ed80:62a0:c1c2:c9e8:a21:e083] has joined #bitcoin-core-dev 23:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/606ce05ec225...91a673613646 23:22 < bitcoin-git> bitcoin/master fa10c9f MacroFake: Crash debug builds on PCKG_MEMPOOL_ERROR 23:22 < bitcoin-git> bitcoin/master 91a6736 MacroFake: Merge bitcoin/bitcoin#25009: Crash debug builds on PCKG_MEMPOOL_ERROR 23:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25009: Crash debug builds on PCKG_MEMPOOL_ERROR (master...2204-crash-debug-🏦) https://github.com/bitcoin/bitcoin/pull/25009 23:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:23 -!- cowboyted [~cowboyted@2601:204:ed80:62a0:c1c2:c9e8:a21:e083] has quit [Quit: Client closed] 23:24 -!- tecnecio [~tecnecio_@84.121.106.211.dyn.user.ono.com] has quit [Remote host closed the connection] 23:31 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 23:43 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 23:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 23:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ec00:8040:6332:4961] has quit [Ping timeout: 260 seconds] 23:48 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 23:50 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has quit [Quit: Textual IRC Client: www.textualapp.com] 23:51 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev 23:52 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds] --- Log closed Fri Apr 29 00:00:08 2022