--- Log opened Wed May 04 00:00:13 2022 00:14 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- provoostenator [~provooste@user/provoostenator] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- ademan[m] [~ademan@2001:470:69fc:105::1:16db] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- stijnbtc[m] [~stijnbtcm@2001:470:69fc:105::1:fec3] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- sipa [~sipa@user/sipa] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- Murch [~murch@user/murch] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- whitehorse[m] [~whitehors@2001:470:69fc:105::1:f3cf] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- bitcoin-git [~bitcoin-g@2001:470:69fc:105::2:690] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- untor3h[m] [~untor3hma@2001:470:69fc:105::1:10ce] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- kvaciral [~kvaciral@2001:470:69fc:105::17b] has quit [Quit: Bridge terminating on SIGTERM] 00:14 -!- stijnbtc[m]1 [~stijnbtcm@2001:470:69fc:105::2:cc] has quit [Quit: Bridge terminating on SIGTERM] 00:15 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur] 00:17 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has joined #bitcoin-core-dev 00:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 00:20 -!- ademan[m] [~ademan@2001:470:69fc:105::1:16db] has joined #bitcoin-core-dev 00:20 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has joined #bitcoin-core-dev 00:20 -!- Murch [~murch@user/murch] has joined #bitcoin-core-dev 00:20 -!- untor3h[m] [~untor3hma@2001:470:69fc:105::1:10ce] has joined #bitcoin-core-dev 00:20 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-dev 00:20 -!- provoostenator [~provooste@user/provoostenator] has joined #bitcoin-core-dev 00:20 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-core-dev 00:20 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev 00:20 -!- bitcoin-git [~bitcoin-g@2001:470:69fc:105::2:690] has joined #bitcoin-core-dev 00:20 -!- glix [~glix@user/glix] has joined #bitcoin-core-dev 00:20 -!- whiteh0rse[m] [~whitehors@2001:470:69fc:105::1:f3cf] has joined #bitcoin-core-dev 00:20 -!- stijnbtc[m] [~stijnbtcm@2001:470:69fc:105::1:fec3] has joined #bitcoin-core-dev 00:20 -!- stijnbtc[m]1 [~stijnbtcm@2001:470:69fc:105::2:cc] has joined #bitcoin-core-dev 00:20 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has joined #bitcoin-core-dev 00:20 -!- kvaciral [~kvaciral@2001:470:69fc:105::17b] has joined #bitcoin-core-dev 00:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 00:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 00:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 252 seconds] 00:26 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 00:27 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 00:28 -!- geyaeb2 [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev 00:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:30 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 252 seconds] 00:40 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 00:46 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev 00:48 -!- NorrinRadd [~username@102.67.16.112] has quit [Client Quit] 00:52 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12455acca2c3...880cec91fab1 00:52 < bitcoin-git> bitcoin/master c2b2958 fanquake: tidy: add readability-redundant-declaration 00:52 < bitcoin-git> bitcoin/master 880cec9 MacroFake: Merge bitcoin/bitcoin#25047: tidy: add readability-redundant-declaration 00:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25047: tidy: add readability-redundant-declaration (master...tidy_redundant_externs) https://github.com/bitcoin/bitcoin/pull/25047 00:59 -!- MatrixBot12 [~matrixbot@2001:bc8:1828:379::1] has quit [K-Lined] 00:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/880cec91fab1...9b42d62f426f 00:59 < bitcoin-git> bitcoin/master d1bfe5e brunoerg: test: add coverage for invalid requests for `blockfilterheaders` 00:59 < bitcoin-git> bitcoin/master 9b42d62 MacroFake: Merge bitcoin/bitcoin#25045: test: add coverage for invalid requests for `... 00:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25045: test: add coverage for invalid requests for `blockfilterheaders` (REST) (master...2022-04-invalid-blockfilterheaders) https://github.com/bitcoin/bitcoin/pull/25045 01:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 01:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 01:16 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has joined #bitcoin-core-dev 01:37 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 01:41 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 248 seconds] 01:48 < laanwj> ugh, if people start wielding bitcoincore org membership as a badge of honor it's time to hide the members list, it's meant as a purely practical thing as lightlike says 01:51 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 260 seconds] 01:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 01:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b42d62f426f...14cb53dfe95e 01:56 < bitcoin-git> bitcoin/master fa4652c MacroFake: Pass lifetimebound reference to SingleThreadedSchedulerClient 01:56 < bitcoin-git> bitcoin/master 14cb53d MacroFake: Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to Sin... 01:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient (master...2204-sched-🔭) https://github.com/bitcoin/bitcoin/pull/25040 02:03 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 02:03 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/14cb53dfe95e...c290249fff81 02:03 < bitcoin-git> bitcoin/master fa87eb8 MacroFake: rpc: Move output script RPCs to separate file 02:03 < bitcoin-git> bitcoin/master fa758f9 MacroFake: scripted-diff: Rename rpc/misc.cpp to rpc/node.cpp 02:03 < bitcoin-git> bitcoin/master c290249 fanquake: Merge bitcoin/bitcoin#25058: rpc: Move output script RPCs to separate file... 02:03 < bitcoin-git> [bitcoin] fanquake merged pull request #25058: rpc: Move output script RPCs to separate file, rename misc.cpp (master...2205-rpc-out-script-📂) https://github.com/bitcoin/bitcoin/pull/25058 02:05 < bitcoin-git> [bitcoin] fanquake closed pull request #23035: p2p, rpc, test: expose tried and refcount in getnodeaddresses, update/improve tests (master...getnodeaddresses-tried-and-reference_count) https://github.com/bitcoin/bitcoin/pull/23035 02:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c290249fff81...d17bbc3c484e 02:08 < bitcoin-git> bitcoin/master 4cb9d21 Jon Atack: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time 02:08 < bitcoin-git> bitcoin/master d17bbc3 MacroFake: Merge bitcoin/bitcoin#25060: blockstorage: add LIFETIMEBOUND to GetFirstSt... 02:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25060: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time (master...add-LIFETIMEBOUND-to-GetFirstStoredBlock-start_time) https://github.com/bitcoin/bitcoin/pull/25060 02:14 -!- MatrixBot1 [~matrixbot@2001:bc8:1828:379::1] has joined #bitcoin-core-dev 02:28 -!- merlin_moci [~merlin_mo@2001:16b8:3045:c100:7c2b:c463:f0eb:1622] has joined #bitcoin-core-dev 02:30 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 02:36 -!- berndj [~berndj@197.189.254.139] has quit [Ping timeout: 250 seconds] 02:37 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 02:37 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye] 02:41 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 02:45 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 02:50 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19426: refactor: Change * to & in MutableTransactionSignatureCreator (master...2007-refactorSign) https://github.com/bitcoin/bitcoin/pull/19426 02:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 252 seconds] 02:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 02:58 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 03:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 248 seconds] 03:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 03:08 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 03:10 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 03:13 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 03:23 -!- berndj [~berndj@197.189.254.139] has joined #bitcoin-core-dev 03:31 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 03:33 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 03:37 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 04:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 248 seconds] 04:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 04:35 -!- jespada [~jespada@146.70.119.87] has quit [Ping timeout: 246 seconds] 04:36 -!- geyaeb2 [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Quit: WeeChat 3.5] 04:36 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev 04:38 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 04:51 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 04:58 -!- Guyver2_ [Guyver@77.174.98.73] has joined #bitcoin-core-dev 05:00 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 248 seconds] 05:08 < fanquake> given that "why does depends exist" / "why not just use system packages" has come up twice this week 05:08 < fanquake> I've posted a few reasons here: https://github.com/bitcoin/bitcoin/pull/25046#issuecomment-1117185586 05:10 -!- okunishinishi [~okunishin@2400:2410:c4a1:a000:894b:c5f:a6c1:cd9c] has joined #bitcoin-core-dev 05:12 -!- okunishinishi [~okunishin@2400:2410:c4a1:a000:894b:c5f:a6c1:cd9c] has quit [Client Quit] 05:14 < laanwj> yes, useful 05:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 256 seconds] 05:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 05:39 -!- ZeroMaster [~webirc@90-154-206-39.ip.btc-net.bg] has joined #bitcoin-core-dev 05:41 -!- Guyver2_ [Guyver@77.174.98.73] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:51 < MarcoFalke> dongcarl: I think it will take a few months at least (maybe years worst case) to get rid of adjusted time in validation 05:52 < MarcoFalke> Really depends on how hungry reviewers are to taste my pull requests 05:53 < MarcoFalke> As ripping out adjusted is (minimally) easier to review if it is type safe, I started doing that first 05:54 < MarcoFalke> Though, it was decided to make it "doubly type safe" by switching to clock types (instead of duration types) 05:54 < MarcoFalke> First pull in that series is #24921 05:54 <@gribble> https://github.com/bitcoin/bitcoin/issues/24921 | Add time helpers for std::chrono::steady_clock and FastRandomContext::rand_uniform_delay by MarcoFalke · Pull Request #24921 · bitcoin/bitcoin · GitHub 05:55 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Ping timeout: 248 seconds] 05:57 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has joined #bitcoin-core-dev 05:57 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has quit [Read error: Connection reset by peer] 05:58 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has joined #bitcoin-core-dev 06:00 -!- jespada_ [~jespada@185.195.232.138] has joined #bitcoin-core-dev 06:02 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Ping timeout: 252 seconds] 06:04 -!- antonleviathan [~antonlevi@cpe08a7c0b41e4e-cm08a7c0b41e4c.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 06:35 -!- merlin_moci [~merlin_mo@2001:16b8:3045:c100:7c2b:c463:f0eb:1622] has quit [Quit: Client closed] 06:48 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 06:48 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 06:52 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 07:14 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 07:23 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 07:33 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 07:37 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 260 seconds] 07:39 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 07:53 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 07:54 < bitcoin-git> [bitcoin] Sjors opened pull request #25063: test: previous releases: add v23.0 (master...2022/05/add_previous_release) https://github.com/bitcoin/bitcoin/pull/25063 08:03 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds] 08:19 -!- kobie [~kobie@2601:285:0:e5c0:b9d9:22aa:d271:35e7] has joined #bitcoin-core-dev 08:32 < bitcoin-git> [bitcoin] dongcarl closed pull request #24456: blockman: Properly guard blockfile members (master...2022-02-kirby-p4) https://github.com/bitcoin/bitcoin/pull/24456 08:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d17bbc3c484e...9183c66cc6ae 08:36 < bitcoin-git> bitcoin/master c0f5cc1 Hennadii Stepanov: build: Fix `libmultiprocess` cross-compiling to Linux hosts 08:36 < bitcoin-git> bitcoin/master 9183c66 fanquake: Merge bitcoin/bitcoin#25046: build: Fix `libmultiprocess` cross-compiling ... 08:36 < bitcoin-git> [bitcoin] fanquake merged pull request #25046: build: Fix `libmultiprocess` cross-compiling to Linux hosts (master...220501-mp-cross) https://github.com/bitcoin/bitcoin/pull/25046 08:46 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has quit [Ping timeout: 248 seconds] 08:48 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 08:50 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 256 seconds] 09:09 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 250 seconds] 09:11 -!- antonleviathan [~antonlevi@cpe08a7c0b41e4e-cm08a7c0b41e4c.cpe.net.cable.rogers.com] has quit [Ping timeout: 252 seconds] 09:19 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 09:19 -!- metallicc [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has joined #bitcoin-core-dev 09:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 09:31 -!- antonleviathan [~antonlevi@ec2-3-99-96-13.ca-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev 09:35 -!- baldur [~baldur@pool-74-108-229-157.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 09:48 < bitcoin-git> [bitcoin] dongcarl opened pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064 09:49 < dongcarl> MarcoFalke: Cool! I will assume that it stays in :-) 09:51 < dongcarl> Hi all: I just opened #25064, which is a "+24 −16" libbitcoinkernel PR that's not based on anything other than master. A much more manageable review than the other "+335 −280" one! Happy to answer questions. 09:51 <@gribble> https://github.com/bitcoin/bitcoin/issues/25064 | [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` by dongcarl · Pull Request #25064 · bitcoin/bitcoin · GitHub 09:52 < laanwj> at the least, validation will be the last place for adjusted time to disappear from 09:53 < laanwj> i'd be fine with ripping it out completely in a shorter timeframe but opinions differ on it 10:02 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:02 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:1834:9a8c:4864:a894] has joined #bitcoin-core-dev 10:08 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev 10:15 -!- stijn [~stijn@2a02-a44e-3f48-1-812-b06e-449c-cafd.fixed6.kpn.net] has joined #bitcoin-core-dev 10:19 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 10:19 -!- stijn [~stijn@2a02-a44e-3f48-1-812-b06e-449c-cafd.fixed6.kpn.net] has quit [Client Quit] 10:21 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9183c66cc6ae...bde5836f9996 10:21 < bitcoin-git> bitcoin/master b7ab9db Martin Leitner-Ankerl: Extend Split to work with multiple separators 10:21 < bitcoin-git> bitcoin/master 0d7efcd Martin Leitner-Ankerl: core_read: Replace boost::split with SplitString 10:21 < bitcoin-git> bitcoin/master d1a9850 Martin Leitner-Ankerl: http: replace boost::split with SplitString 10:21 < bitcoin-git> [bitcoin] fanquake merged pull request #25057: refactor: replace remaining boost::split with SplitString (master...2022-04-boost-split-exorcism) https://github.com/bitcoin/bitcoin/pull/25057 10:22 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-dev 10:43 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Remote host closed the connection] 10:43 < dongcarl> laanwj: Yup, makes sense. 10:44 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-dev 10:52 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bde5836f9996...0047d9b89b9f 10:52 < bitcoin-git> bitcoin/master 027aab6 brunoerg: test, contrib, refactor: use `with` when opening a file 10:52 < bitcoin-git> bitcoin/master 0047d9b laanwj: Merge bitcoin/bitcoin#24993: test, contrib, refactor: use `with` when open... 10:52 < bitcoin-git> [bitcoin] laanwj merged pull request #24993: test, contrib, refactor: use `with` when opening a file (master...2022-04-contrib-close-file) https://github.com/bitcoin/bitcoin/pull/24993 10:56 < fanquake> Now we just need to dump algorithm/string/replace and date_time 10:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0047d9b89b9f...33aaf434af27 10:58 < bitcoin-git> bitcoin/master e5d1831 dergoegge: [netgroup] Use nStartByte as offset for the last byte of the group 10:58 < bitcoin-git> bitcoin/master 33aaf43 fanquake: Merge bitcoin/bitcoin#24976: netgroup: Follow-up for #22910 10:58 < bitcoin-git> [bitcoin] fanquake merged pull request #24976: netgroup: Follow-up for #22910 (master...2022-04-nStartByte-followup) https://github.com/bitcoin/bitcoin/pull/24976 10:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7] has joined #bitcoin-core-dev 11:06 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 11:22 -!- Guest1540 [~Guest15@cpc108529-walt20-2-0-cust136.13-2.cable.virginm.net] has joined #bitcoin-core-dev 11:27 -!- antonleviathan [~antonlevi@ec2-3-99-96-13.ca-central-1.compute.amazonaws.com] has quit [Quit: Client closed] 11:29 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:29 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Remote host closed the connection] 11:31 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 11:32 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-dev 11:32 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Remote host closed the connection] 11:32 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-dev 11:33 -!- Guest1540 [~Guest15@cpc108529-walt20-2-0-cust136.13-2.cable.virginm.net] has quit [Quit: Client closed] 11:34 -!- antonleviathan [~antonlevi@ec2-3-99-96-13.ca-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev 11:36 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/33aaf434af27...fe6a299fc002 11:36 < bitcoin-git> bitcoin/master 67c8411 Martin Leitner-Ankerl: test: Adds a test for HexStr that checks all 256 bytes 11:36 < bitcoin-git> bitcoin/master 4e2b99f Martin Leitner-Ankerl: bench: Adds a benchmark for HexStr 11:36 < bitcoin-git> bitcoin/master 5e61532 Martin Leitner-Ankerl: util: optimizes HexStr 11:36 < bitcoin-git> [bitcoin] laanwj merged pull request #24852: util: optimize HexStr (master...2022-03-HexStr-optimizations) https://github.com/bitcoin/bitcoin/pull/24852 11:55 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [] 12:09 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fe6a299fc002...5e1aacab576b 12:09 < bitcoin-git> bitcoin/master 46971c6 laanwj: util: Replace non-threadsafe strerror 12:09 < bitcoin-git> bitcoin/master e7f2f77 laanwj: util: Use strerror_s for SysErrorString on Windows 12:09 < bitcoin-git> bitcoin/master 718da30 laanwj: util: Refactor SysErrorString logic 12:09 < bitcoin-git> [bitcoin] laanwj merged pull request #24933: util: Replace non-threadsafe strerror (master...2022-04-strerror-threadsafe) https://github.com/bitcoin/bitcoin/pull/24933 12:12 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 260 seconds] 12:13 -!- aleggg [~aleggg@179.179.114.239] has quit [Ping timeout: 272 seconds] 12:13 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/5e1aacab576b...d4475ea7ae70 12:13 < bitcoin-git> bitcoin/master b483084 josibake: doc: replace bitcoin.conf with placeholder file 12:13 < bitcoin-git> bitcoin/master 1c7e820 josibake: script: add script to generate example bitcoin.conf 12:13 < bitcoin-git> bitcoin/master 6aac946 Josiah Baker: doc: update bitcoin-conf.md 12:13 < bitcoin-git> [bitcoin] laanwj merged pull request #22235: script: add script to generate example bitcoin.conf (master...josibake-auto-generate-example-bitcoin-conf-file) https://github.com/bitcoin/bitcoin/pull/22235 12:15 < bitcoin-git> [bitcoin] fanquake closed pull request #24969: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/24969 12:18 -!- aleggg [~aleggg@179.179.114.239] has joined #bitcoin-core-dev 12:23 -!- a1ph4byte [~a1ph4byte@2600:1700:22f0:a7c0:1834:9a8c:4864:a894] has quit [Quit: a1ph4byte] 12:30 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:31 -!- a1ph4byte [~a1ph4byte@adsl-70-228-72-132.dsl.akrnoh.ameritech.net] has joined #bitcoin-core-dev 12:31 -!- a1ph4byte [~a1ph4byte@adsl-70-228-72-132.dsl.akrnoh.ameritech.net] has left #bitcoin-core-dev [] 12:32 -!- a1ph4byte [~a1ph4byte@adsl-70-228-72-132.dsl.akrnoh.ameritech.net] has joined #bitcoin-core-dev 12:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 12:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 12:55 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 260 seconds] 13:13 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 13:20 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 13:34 -!- djb27_ [~djb27@user/djb27] has joined #bitcoin-core-dev 13:35 -!- djb27__ [~djb27@user/djb27] has joined #bitcoin-core-dev 13:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 13:37 -!- djb27 [~djb27@user/djb27] has quit [Ping timeout: 260 seconds] 13:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 13:39 -!- djb27_ [~djb27@user/djb27] has quit [Ping timeout: 260 seconds] 13:46 -!- Guest52 [~Guest52@static.31.105.21.65.clients.your-server.de] has joined #bitcoin-core-dev 13:49 -!- Guest52 [~Guest52@static.31.105.21.65.clients.your-server.de] has quit [Client Quit] 13:51 -!- meri90 [~meri90@static.31.105.21.65.clients.your-server.de] has joined #bitcoin-core-dev 13:53 -!- meri90 [~meri90@static.31.105.21.65.clients.your-server.de] has quit [Client Quit] 13:53 -!- antonleviathan [~antonlevi@ec2-3-99-96-13.ca-central-1.compute.amazonaws.com] has quit [Quit: Client closed] 14:06 -!- Guyver2__ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 14:09 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 256 seconds] 14:20 -!- notmandatory_ [~notmandat@shindig.notmandatory.org] has joined #bitcoin-core-dev 14:21 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Ping timeout: 240 seconds] 14:22 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined #bitcoin-core-dev 14:37 -!- Guyver2__ [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:49 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 256 seconds] 15:04 -!- antonleviathan [~antonlevi@ec2-3-99-96-13.ca-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev 15:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 15:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 15:28 -!- hashfunc65d [~user@2601:5c0:c280:7090:7c25:cf68:625f:614f] has joined #bitcoin-core-dev 15:30 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 15:41 < bitcoin-git> [bitcoin] dongcarl opened pull request #25065: [kernel 2c/n] Extract only what we use of `init/common.cpp` (master...2022-03-libbitcoinkernel-initcommon) https://github.com/bitcoin/bitcoin/pull/25065 15:42 < dongcarl> Another easy review for libbitcoinkernel: #25065. +53 −24 15:42 <@gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Extract only what we use of `init/common.cpp` by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub 15:45 < sipa> I am watching the development of the numbering scheme for the libbitcoinkernel PRs with scientific interest. 15:46 -!- ctv [~ctv@yal.riseup.net] has joined #bitcoin-core-dev 15:47 < ctv> jeremyrubin: never give up.. the people who are crazy enough to think they can.. are the ones who do.. 15:47 -!- ctv [~ctv@yal.riseup.net] has quit [Quit: Client closed] 15:47 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 15:47 -!- djb27__ [~djb27@user/djb27] has quit [Ping timeout: 256 seconds] 15:59 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 16:04 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7] has quit [Remote host closed the connection] 16:04 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 16:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 16:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:47 -!- antonleviathan [~antonlevi@ec2-3-99-96-13.ca-central-1.compute.amazonaws.com] has quit [Quit: Client closed] 18:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Remote host closed the connection] 18:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 18:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 256 seconds] 18:19 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 18:24 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 18:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 18:27 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 18:27 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 18:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 248 seconds] 18:30 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 18:35 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 250 seconds] 18:40 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 18:41 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 18:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 19:00 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Quit: upekkha] 19:00 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev 19:11 -!- metallicc [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has quit [Remote host closed the connection] 19:15 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 19:15 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 19:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 19:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 252 seconds] 19:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 19:48 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur] 19:51 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 19:56 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev 20:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 20:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:13 -!- hashfunc65d [~user@2601:5c0:c280:7090:7c25:cf68:625f:614f] has quit [Ping timeout: 250 seconds] 20:17 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds] 20:21 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 20:29 -!- kobie [~kobie@2601:285:0:e5c0:b9d9:22aa:d271:35e7] has quit [Remote host closed the connection] 20:42 -!- a1ph4byte20 [~a1ph4byte@2600:1700:22f0:a7c0:98c8:7ecc:94f9:578a] has joined #bitcoin-core-dev 20:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 260 seconds] 20:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:08 -!- PaperSwordAlt [~PaperSwor@50.126.96.22] has quit [Read error: Connection reset by peer] 21:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 260 seconds] 21:20 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 21:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev 21:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 246 seconds] 21:40 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 21:42 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 276 seconds] 21:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751] has quit [Ping timeout: 256 seconds] 21:59 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 22:06 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7] has joined #bitcoin-core-dev 22:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7] has quit [Ping timeout: 248 seconds] 22:17 -!- a1ph4byte20 [~a1ph4byte@2600:1700:22f0:a7c0:98c8:7ecc:94f9:578a] has quit [Quit: Client closed] 22:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7] has joined #bitcoin-core-dev 23:04 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 23:08 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 23:19 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d4475ea7ae70...0d080a183bfc 23:40 < bitcoin-git> bitcoin/master 2b09593 Shashwat: scripted-diff: Rename message command to message type 23:40 < bitcoin-git> bitcoin/master e71c51b Shashwat: refactor: rename command -> message type in comments in the src/net* files 23:40 < bitcoin-git> bitcoin/master 0d080a1 MacroFake: Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* ... 23:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141 23:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7] has quit [Ping timeout: 260 seconds] 23:47 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev --- Log closed Thu May 05 00:00:14 2022