--- Log opened Mon May 16 00:00:24 2022
00:02 < luke-jr> wut
00:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 272 seconds]
00:09 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
00:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
00:28 -!- djb27_ [djb27@user/djb27] has joined #bitcoin-core-dev
00:32 -!- djb27 [djb27@user/djb27] has quit [Ping timeout: 256 seconds]
00:41 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:43 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
00:49 -!- aleggg [~aleggg@179.187.19.96.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 252 seconds]
00:49 -!- aleggg [~aleggg@177.204.163.75.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
00:52 < TallTim> verbose mode
01:21 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 260 seconds]
01:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b74a6dde8cf5...bc2eee72672a
01:40 < bitcoin-git> bitcoin/master 370120e Jon Atack: Remove obsolete BDB ENABLE_WALLET section in developer notes
01:40 < bitcoin-git> bitcoin/master fc4cb85 Jon Atack: Prefer Python for scripts in developer notes
01:40 < bitcoin-git> bitcoin/master 5fca70f Jon Atack: Link in developer notes style to internal interface exception
01:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25092: doc: various developer notes updates (master...developer-notes-updates-may-2022) https://github.com/bitcoin/bitcoin/pull/25092
01:47 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
01:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc2eee72672a...195df1eb883d
01:50 < bitcoin-git> bitcoin/master 23854f8 Jon Atack: refactor: make MainSignalsInstance() a class
01:50 < bitcoin-git> bitcoin/master 2aaec23 Jon Atack: refactor: remove unused forward declarations in validationinterface.h
01:50 < bitcoin-git> bitcoin/master ca1ac1f Jon Atack: scripted-diff: Rename MainSignalsInstance() class to MainSignalsImpl()
01:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25067: validationinterface: make MainSignalsInstance() a class, drop unused forward declarations (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
01:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
01:56 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 248 seconds]
02:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/195df1eb883d...1511c9efb405
02:01 < bitcoin-git> bitcoin/master 06822f8 Luke Dashjr: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's prunehe...
02:01 < bitcoin-git> bitcoin/master 1511c9e MacroFake: Merge bitcoin/bitcoin#24640: Bugfix: RPC/blockchain: Correct description o...
02:01 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640
02:05 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
02:09 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
02:18 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
02:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
02:30 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds]
02:51 -!- aleggg [~aleggg@177.204.163.75.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 260 seconds]
02:52 -!- aleggg [~aleggg@189.114.128.145.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
02:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
03:16 -!- TallTim_ [~talltim@184-83-250-114-dynamic.midco.net] has joined #bitcoin-core-dev
03:19 -!- TallTim [~talltim@184-83-250-114-dynamic.midco.net] has quit [Ping timeout: 276 seconds]
03:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 272 seconds]
03:29 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
03:31 -!- cold [~cold@user/cold] has quit [Ping timeout: 252 seconds]
03:31 -!- midnight_ [~midnight@user/midnight] has joined #bitcoin-core-dev
03:31 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 246 seconds]
03:31 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
03:34 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has quit [Remote host closed the connection]
03:34 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has joined #bitcoin-core-dev
03:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
04:03 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 240 seconds]
04:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 252 seconds]
04:04 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
04:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
04:13 -!- roconnor [~roconnor@coq/roconnor] has joined #bitcoin-core-dev
04:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
04:18 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
04:19 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
04:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
04:22 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 260 seconds]
04:30 -!- emcy_ [~emcy@user/emcy] has joined #bitcoin-core-dev
04:30 -!- emcy [~emcy@user/emcy] has quit [Ping timeout: 256 seconds]
04:35 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has quit [Read error: Connection reset by peer]
04:35 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has joined #bitcoin-core-dev
04:40 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
04:43 < bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/1511c9efb405...dc0ee573734e
04:43 < bitcoin-git> bitcoin/master cba909e John Newbery: [net] Stop testing version 1 compact blocks.
04:43 < bitcoin-git> bitcoin/master 16730b6 John Newbery: [net processing] Only advertise support for version 2 compact blocks
04:43 < bitcoin-git> bitcoin/master 42882fc John Newbery: [net processing] Only accept `sendcmpct` with version=2
04:43 < bitcoin-git> [bitcoin] fanquake merged pull request #20799: net processing: Only support version 2 compact blocks (master...2020-12-remove-cmpctblock-v1) https://github.com/bitcoin/bitcoin/pull/20799
04:47 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 260 seconds]
04:48 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
04:50 -!- aleggg [~aleggg@189.114.128.145.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 240 seconds]
04:51 -!- aleggg [~aleggg@179.179.117.164] has joined #bitcoin-core-dev
04:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
05:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc0ee573734e...aa3200d89672
05:19 < bitcoin-git> bitcoin/master 7d73f58 Anthony Towns: Increase threadsafety annotation coverage
05:19 < bitcoin-git> bitcoin/master 436ce02 Anthony Towns: sync.h: strengthen AssertLockNotHeld assertion
05:19 < bitcoin-git> bitcoin/master aa3200d MacroFake: Merge bitcoin/bitcoin#25109: Strengthen AssertLockNotHeld assertions
05:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25109: Strengthen AssertLockNotHeld assertions (master...202205-neg-anno-assertnotheld-only) https://github.com/bitcoin/bitcoin/pull/25109
05:19 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 240 seconds]
05:21 -!- roconnor_ [~roconnor@coq/roconnor] has joined #bitcoin-core-dev
05:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
05:22 -!- roconnor [~roconnor@coq/roconnor] has quit [Ping timeout: 276 seconds]
05:32 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
05:33 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
05:34 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
05:36 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
05:48 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
05:49 -!- Guyver2__ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
05:49 -!- TallTim_ is now known as TallTim
05:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
05:51 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 240 seconds]
05:52 -!- Guyver2_ [~Guyver@2a02-a45c-ba8d-1-d5c9-1ab9-92f7-fd69.fixed6.kpn.net] has joined #bitcoin-core-dev
05:53 -!- Guyver2__ [Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 248 seconds]
05:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 240 seconds]
06:06 < _aj_> hmm, seems like marco's wresting control of his github account back from drahtbot
06:07 < fanquake> ongoing situation
06:07 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
06:07 < _aj_> hopefully a short victorious battle will see him soon rejoin irc?
06:23 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
06:25 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa3200d89672...b019cdc03634
06:26 < bitcoin-git> bitcoin/master fa347a9 MacroFake: rpc: Fix implicit-integer-sign-change in gettxout
06:26 < bitcoin-git> bitcoin/master b019cdc fanquake: Merge bitcoin/bitcoin#25095: rpc: Fix implicit-integer-sign-change in gett...
06:26 < bitcoin-git> [bitcoin] fanquake merged pull request #25095: rpc: Fix implicit-integer-sign-change in gettxout (master...2205-rpc-int-ubsan-😛) https://github.com/bitcoin/bitcoin/pull/25095
06:29 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b019cdc03634...6b87fa540c40
06:29 < bitcoin-git> bitcoin/master fae3200 MacroFake: test: Slim down versionbits_tests.cpp
06:29 < bitcoin-git> bitcoin/master 6b87fa5 fanquake: Merge bitcoin/bitcoin#25125: test: Slim down versionbits_tests.cpp
06:29 < bitcoin-git> [bitcoin] fanquake merged pull request #25125: test: Slim down versionbits_tests.cpp (master...2205-test-slim-🍄) https://github.com/bitcoin/bitcoin/pull/25125
06:31 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: No Ping reply in 180 seconds.]
06:32 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
06:33 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
06:37 -!- Guyver2_ [~Guyver@2a02-a45c-ba8d-1-d5c9-1ab9-92f7-fd69.fixed6.kpn.net] has left #bitcoin-core-dev []
06:49 -!- aleggg [~aleggg@179.179.117.164] has quit [Ping timeout: 240 seconds]
06:50 -!- aleggg [~aleggg@179.176.67.181.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
06:55 -!- roconnor_ is now known as roconnor
06:56 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
07:11 < hebasto> luke-jr: re 20:07:36 <luke-jr> master GUI appears to segfault if it gets an unsupported wallet format :/ -- mind opening an issue?
07:15 -!- furszy [~furszy@user/furszy] has quit [Remote host closed the connection]
07:24 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25144: refactor: Pass Peer& to Misbehaving() (master...2205-mis-peer-🛥) https://github.com/bitcoin/bitcoin/pull/25144
07:27 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b87fa540c40...07cb4dee5d12
07:27 < bitcoin-git> bitcoin/master 11e7908 Martin Leitner-Ankerl: prevector: only allow trivially copyable types
07:27 < bitcoin-git> bitcoin/master 07cb4de MacroFake: Merge bitcoin/bitcoin#24962: prevector: enforce is_trivially_copyable_v
07:27 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24962: prevector: enforce is_trivially_copyable_v (master...2022-04_prevector_fixes) https://github.com/bitcoin/bitcoin/pull/24962
07:27 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 248 seconds]
07:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
07:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 248 seconds]
07:40 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
07:52 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds]
08:31 -!- jespada [~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
08:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 272 seconds]
08:44 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 240 seconds]
08:47 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Remote host closed the connection]
08:51 -!- aleggg [~aleggg@179.176.67.181.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 252 seconds]
08:52 -!- aleggg [~aleggg@179.177.106.54.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
08:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
09:11 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
09:18 -!- goatpig [~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2] has quit [Remote host closed the connection]
09:19 -!- cryptapus [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev
09:30 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
09:32 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
09:48 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
09:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 260 seconds]
10:00 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection]
10:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
10:32 < luke-jr> hebasto: do we want issues for master-only bugs now?
10:32 < sipa> Why not?
10:33 < luke-jr> idk, seems like it would hopefully be too short-lived
10:33 < sipa> If it's longer lived than you mentioning it on IRC, it seems preferable to have an issue open for it so it's not forgotten.
10:34 < luke-jr> maybe I should just debug it :x
10:34 < sipa> Like, if you or something else were to open a PR immediately to fix it, I'd say an issue isn't needed (but it still wouldn't hurt).
10:34 < sipa> *someone else
10:36 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
10:43 -!- NorrinRadd [~username@102.67.16.112] has quit [Ping timeout: 272 seconds]
10:46 < luke-jr> ugh, it's in spaghetti code
10:46  * luke-jr just opens an issue instead x.x
10:46 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
10:49 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
10:54 < bitcoin-git> [bitcoin] jnewbery opened pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
10:58 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
11:01 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:16 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has joined #bitcoin-core-dev
11:32 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:33 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:34 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
11:36 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/07cb4dee5d12...187504b038cc
11:36 < bitcoin-git> bitcoin/master a7b65af Sebastian Falbesoner: rpc: avoid scriptPubKeyCTxDestination conversions in `GetReceived` tally
11:36 < bitcoin-git> bitcoin/master f336ff7 Sebastian Falbesoner: rpc: avoid expensive `IsMine` calls in `GetReceived` tally
11:36 < bitcoin-git> bitcoin/master 187504b Andrew Chow: Merge bitcoin/bitcoin#23662: rpc: improve `getreceivedby{address,label}` p...
11:36 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:36 < bitcoin-git> [bitcoin] achow101 merged pull request #23662: rpc: improve `getreceivedby{address,label}` performance (master...202112-rpc-improve_getreceivedby_performance) https://github.com/bitcoin/bitcoin/pull/23662
11:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Remote host closed the connection]
11:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
11:56 < bitcoin-git> [bitcoin] hebasto opened pull request #25148: refactor: Remove `NO_THREAD_SAFETY_ANALYSIS` from non-test/benchmarking code (master...220516-todo) https://github.com/bitcoin/bitcoin/pull/25148
12:08 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
12:14 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:30 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/187504b038cc...98f4db33056b
12:30 < bitcoin-git> bitcoin/master ba10b90 Luke Dashjr: Wallet: Ensure m_attaching_chain is set before registering for signals
12:30 < bitcoin-git> bitcoin/master 98f4db3 Andrew Chow: Merge bitcoin/bitcoin#25088: Wallet: Ensure m_attaching_chain is set befor...
12:30 < bitcoin-git> [bitcoin] achow101 merged pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
12:57 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/98f4db33056b...91a42d63efaf
12:57 < bitcoin-git> bitcoin/master 2a22f03 avirgovi: parsing external signer master fingerprint string as bytes instead of cari...
12:57 < bitcoin-git> bitcoin/master 91a42d6 Andrew Chow: Merge bitcoin/bitcoin#25019: parse external signer master fp as bytes in E...
12:57 < bitcoin-git> [bitcoin] achow101 merged pull request #25019: parse external signer master fp as bytes in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 260 seconds]
13:10 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has quit [Quit: Leaving]
13:20 < bitcoin-git> [bitcoin] hebasto opened pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
13:37 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
13:49 -!- hashfunc16f7 [~user@2601:5c0:c280:7090:7c25:cf68:625f:614f] has joined #bitcoin-core-dev
14:04 -!- djb27_ [djb27@user/djb27] has quit [Ping timeout: 248 seconds]
14:56 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
14:59 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
15:09 -!- hashfunc16f7 [~user@2601:5c0:c280:7090:7c25:cf68:625f:614f] has quit [Ping timeout: 240 seconds]
15:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Remote host closed the connection]
15:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
15:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Remote host closed the connection]
15:15 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
15:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Remote host closed the connection]
15:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has joined #bitcoin-core-dev
15:34 < david-bakin> So, I understand you squash commits before submitting a PR.  But when responding to code review suggestions/requests - do you squash and force-push those fix commits?  Because doesn't that mess up the PR comment/history?
15:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f] has quit [Ping timeout: 248 seconds]
15:36 < sipa> There is a general philosophical divide on this among projects, but Bitcoin Core follows a very strong squash-before-merging policy.
15:36 < sipa> Your PR must be in a state where the individual commits make logical sense, without fixups.
15:37 < david-bakin> ok, squash-before-merge is fine for sure, but I thought I just read here the other day I should squash before submitting the PR?  or did I read that wrong?  the contributor note does talk about separating format/refactor commits from "featureish" commits ...
15:38 < sipa> Before submitting, definitely.
15:38 < sipa> No reason to bother the reviewers with the internal history your PR went through privately.
15:38 < david-bakin> ok ... so ... a) before submitting and c) at the merge-to-master but NOT necessairly b) during cr itself where it will mess up the PR's comment history?
15:41 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
15:42 < sipa> Up to you. It may make sense to squash during a PR's review process, or not.
15:43 < david-bakin> hmm.  ok ... I'll do what seems best & see what happens ...
15:43 < sipa> The goal is making things easy for reviewers, including after the fact ones that want to understand what a PR did after it got merged.
15:43 < david-bakin> ok
15:44 < sipa> If you've had a lot of in depth code review, you may not want to squash immediately, because reviewers may dislike having to go through it again.
15:47 < sipa> But also, a lot of time reviewers spend is on understanding your code changes and concept, rather than actual line-by-line review, and most of that isn't invalidated by squashing.
15:48 < david-bakin> ok.  here's a question I have about the bitcoin CR experience vs that I've experienced at companies:  Is the line-by-line review not valued in general or is it just the unfortunate lack of reviewers + reviewer's time?  IOW, I don't have the experience (yet) to do the "big picture" concept acks/nacks - but I _do_ know how to do close-reading of code for correctness.  Is it worth doing?
15:49 < sipa> I'm not sure what you mean. Both are important.
15:49 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
15:50 < sipa> But people only pay attention to PRs they are interested in obviously, as there is no one to tell them what to work on. That sometimes means fighting for reviewer attention (regardless of what type of review).
15:52 < david-bakin> ok
16:09 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
16:10 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 260 seconds]
16:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Remote host closed the connection]
16:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
16:16 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 260 seconds]
16:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
16:36 < luke-jr> david-bakin: I'd say the actual code review is *more* helpful than the high-level concept ack, since the latter is easy and the former tends to be the bottleneck
16:38 < david-bakin> luke-jr that's what I would have thought (again, based on my long experience as a software engineer) but ... I wasn't actually sure it was valued here ... especially by people (like me) who don't have the knowledge to give a concept (n)ack ... I'm thinking of doing CRs with _just_ the close reading and _not_ the concept (n)ack it that'd be appropriate
16:45 < sipa> luke-jr: it may depend on what PR you're talking about. I think it happens that some bigger, more conceptually invasive don't get reviewed (enough) precisely because it's unclear to reviewers to what extent it's likely the project will go that direction.
16:46 < sipa> There is a spectrum of course between very high level conceptual direction, and line-by-line nitty naming style comments.
16:47 < sipa> But personally, I find that even when I've done line-by-line review of a change, I don't actually mind it being squashed, because most of the work was trying to understand how and why the code changes are what they are. Going over the line-by-line changes again a second time tends to be a lot faster (and even if it's a lot, diffing the diffs can help).
16:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has quit [Remote host closed the connection]
16:48 < david-bakin> sipa yes I'm not much fussed about naming myself or other small things - my focus is generally on coding for reliability and testability and readability.  my question about squashing was becauase I'm not actually that used to how github handles comments on "squashed" code - i'm more used to dedicated code review tools that specifically know about diffs between different commits on 
16:48 < david-bakin> the way to the final pr 'cause that's their focus
16:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:53 < sipa> With a few very big changes in the past (my own PRs) I've maintained two parallel versions of the PR, one which was mostly append-only (adding fixup commits), and one with the merged-together clean-history version, keeping them in sync w.r.t. their final state.
16:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has joined #bitcoin-core-dev
16:54 < sipa> So that you could both see the result, and the history how it got there. But that's definitely overkill for most changes.
16:54 < david-bakin> i'm not there yet!  little bitty changes for me at this point!  but we'll see in a few years ...
16:54 < sipa> I like your enthousiasm.
16:55 < david-bakin> !!
16:55 <@gribble> Error: "!" is not a valid command.
16:55 < david-bakin> yes!
16:59 < david-bakin> ( I tried to answer "!!" but some bot said that wasn't a valid command - talk about squishing someone's enthusiasm - nuts to that!)
17:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has quit [Ping timeout: 260 seconds]
17:07 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
17:38 < luke-jr> sipa: about 1/3 of the Knots patchset at this point is simply bugfixes that presumably should be uncontroversial conceptually
17:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Ping timeout: 272 seconds]
17:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
17:55 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Ping timeout: 260 seconds]
18:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
18:11 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds]
18:19 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
18:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has joined #bitcoin-core-dev
18:40 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal]
19:03 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
19:06 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds]
19:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
19:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:16 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
19:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has quit [Ping timeout: 248 seconds]
19:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
19:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has joined #bitcoin-core-dev
20:14 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
20:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
20:18 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:23 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
20:26 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
20:31 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
20:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:07 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
21:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 246 seconds]
21:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
21:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has quit [Ping timeout: 260 seconds]
21:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
21:19 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 260 seconds]
21:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has joined #bitcoin-core-dev
21:47 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
21:49 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
21:49 -!- lukedashjr is now known as luke-jr
21:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
22:28 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
22:30 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:45 -!- aleggg [~aleggg@179.177.106.54.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 260 seconds]
22:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3] has quit [Ping timeout: 272 seconds]
22:52 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
23:01 -!- aleggg [~aleggg@177.132.197.239] has joined #bitcoin-core-dev
23:03 -!- cmirror [~cmirror@4.53.92.114] has quit [Ping timeout: 276 seconds]
23:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
23:16 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
23:19 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds]
23:21 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
23:23 -!- aleggg [~aleggg@177.132.197.239] has quit [Ping timeout: 272 seconds]
23:24 -!- aleggg [~aleggg@179.178.119.144] has joined #bitcoin-core-dev
23:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91a42d63efaf...8270740befa3
23:26 < bitcoin-git> bitcoin/master 8c5533c Sebastian Falbesoner: rpc: remove deprecated "softforks" field from getblockchaininfo
23:26 < bitcoin-git> bitcoin/master a01b92a Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=softforks` flag
23:26 < bitcoin-git> bitcoin/master 8270740 MacroFake: Merge bitcoin/bitcoin#25114: rpc: remove deprecated "softforks" field from...
23:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
23:43 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds]
23:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8270740befa3...0be1dc1f56f6
23:45 < bitcoin-git> bitcoin/master 8edd0d3 Sebastian Falbesoner: refactor: reduce scope of lock `m_most_recent_block_mutex`
23:45 < bitcoin-git> bitcoin/master 83003ff Sebastian Falbesoner: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex
23:45 < bitcoin-git> bitcoin/master 0be1dc1 MacroFake: Merge bitcoin/bitcoin#24062: refactor: replace RecursiveMutex `m_most_rece...
23:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24062: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex (master...202201-refactor_replace_recursive_mutex_cs_last_block) https://github.com/bitcoin/bitcoin/pull/24062
23:49 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
23:50 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
23:52 < bitcoin-git> [bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
23:53 < bitcoin-git> [bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
23:58 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev
--- Log closed Tue May 17 00:00:25 2022