--- Log opened Thu May 19 00:00:27 2022
00:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 244 seconds]
00:09 -!- mudsip [~mudsip@user/mudsip] has quit []
00:10 -!- x88x88x [~x88x88x@149.28.53.172] has quit [Remote host closed the connection]
00:12 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds]
00:15 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev
00:19 -!- hashfunc1204 [~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e] has quit [Ping timeout: 272 seconds]
00:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
00:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
00:27 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 240 seconds]
00:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
00:33 -!- ronoaldo [~ronoaldo@187.75.64.192] has joined #bitcoin-core-dev
00:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 272 seconds]
00:37 -!- x88x88x [~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb] has joined #bitcoin-core-dev
00:38 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:39 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:44 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 240 seconds]
00:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
00:55 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 260 seconds]
01:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
01:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
01:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
01:06 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev
01:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 240 seconds]
01:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
01:21 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving]
01:23 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds]
01:27 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bb83aba6c98b...986bae8e7248
01:27 < bitcoin-git> bitcoin/master 42e3250 John Newbery: [net processing] [refactor] Move m_next_send_feefilter and m_fee_filter_se...
01:27 < bitcoin-git> bitcoin/master 290a8da John Newbery: [net processing] Comment all TxRelay members
01:27 < bitcoin-git> bitcoin/master b0a4ac9 John Newbery: [net processing] Add m_tx_relay_mutex to protect m_tx_relay ptr
01:27 < bitcoin-git> [bitcoin] fanquake merged pull request #22778: net processing: Reduce resource usage for inbound block-relay-only connections (master...2021-02-tx-relay-init) https://github.com/bitcoin/bitcoin/pull/22778
01:28 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
01:30 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
01:32 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
01:37 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/986bae8e7248...fdb82a30bed2
01:37 < bitcoin-git> bitcoin/master c65bf50 John Newbery: Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
01:37 < bitcoin-git> bitcoin/master bf6526f John Newbery: [test] Remove segwit argument from build_block_on_tip()
01:37 < bitcoin-git> bitcoin/master fdb82a3 fanquake: Merge bitcoin/bitcoin#25147: Net processing: follow ups to #20799 (removin...
01:37 < bitcoin-git> [bitcoin] fanquake merged pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
01:39 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
01:43 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
01:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
01:54 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds]
01:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
01:54 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
01:55 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
01:58 -!- qubenix [~qubenix@user/qubenix] has quit [Quit: quit]
01:59 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdb82a30bed2...345d860f3818
01:59 < bitcoin-git> bitcoin/master 174f58c Marnix: Add link to NetBSD release
01:59 < bitcoin-git> bitcoin/master 345d860 fanquake: Merge bitcoin/bitcoin#25166: doc: Add link to NetBSD release
01:59 < bitcoin-git> [bitcoin] fanquake merged pull request #25166: doc: Add link to NetBSD release (master...NetBSD-release-link) https://github.com/bitcoin/bitcoin/pull/25166
02:00 -!- qubenix [~qubenix@user/qubenix] has joined #bitcoin-core-dev
02:00 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
02:02 -!- noonien [~noonien@user/noonien] has quit [Ping timeout: 276 seconds]
02:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 240 seconds]
02:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
02:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 240 seconds]
02:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
02:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
02:45 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
02:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
02:47 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 260 seconds]
02:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
02:53 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
02:53 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
03:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
03:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
03:19 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
03:22 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
03:38 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
03:57 < michaelfolkson> caraponz: Not exhaustive but Optech tries to follow and announce who is supporting PSBTs https://bitcoinops.org/en/topics/psbt/
04:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 272 seconds]
04:31 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
04:34 -!- djb27__ [~djb27@user/djb27] has joined #bitcoin-core-dev
04:36 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 260 seconds]
04:37 -!- djb27__ [~djb27@user/djb27] has quit [Read error: Connection reset by peer]
04:37 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
04:38 -!- djb27_ [djb27@user/djb27] has quit [Ping timeout: 244 seconds]
05:16 < hebasto> looks like https://github.com/boostorg/process/issues/207 has been solved recently
05:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 246 seconds]
05:47 < bitcoin-git> [bitcoin] sdaftuar closed pull request #20726: p2p: Add DISABLETX message for negotiating block-relay-only connections (master...2020-12-negotiate-block-relay) https://github.com/bitcoin/bitcoin/pull/20726
05:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:00 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345d860f3818...e18fd4763e77
06:00 < bitcoin-git> bitcoin/master 7171ebc Martin Zumsande: index: Don't commit a best block before indexing it during sync
06:00 < bitcoin-git> bitcoin/master e18fd47 fanquake: Merge bitcoin/bitcoin#25074: index: During sync, commit best block after i...
06:00 < bitcoin-git> [bitcoin] fanquake merged pull request #25074: index: During sync, commit best block after indexing (master...202205_index_sync_order) https://github.com/bitcoin/bitcoin/pull/25074
06:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
06:16 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Ping timeout: 240 seconds]
06:31 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
07:22 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
07:22 -!- Guest97 [~Guest97@2001:44b8:612c:3300:616c:4716:adc:1c0] has joined #bitcoin-core-dev
07:23 -!- Guest97 [~Guest97@2001:44b8:612c:3300:616c:4716:adc:1c0] has quit [Client Quit]
07:25 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds]
07:33 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 240 seconds]
07:35 < bitcoin-git> [bitcoin] theStack opened pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
07:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has joined #bitcoin-core-dev
07:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828] has quit [Ping timeout: 260 seconds]
08:03 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
08:04 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
08:12 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds]
08:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
08:27 -!- chinggg [~chinggg@198.16.63.47] has joined #bitcoin-core-dev
08:32 -!- chinggg [~chinggg@198.16.63.47] has quit [Quit: Client closed]
08:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e18fd4763e77...0de36941eca1
08:33 < bitcoin-git> [bitcoin] fanquake merged pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
08:35 < bitcoin-git> [bitcoin] fanquake opened pull request #25172: refactor: use std:: for mem*( funcs (master...use_std_variants) https://github.com/bitcoin/bitcoin/pull/25172
08:59 -!- Ignush [~Ignush@u193-11-161-109.studentnatet.se] has joined #bitcoin-core-dev
09:03 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 246 seconds]
09:11 -!- Ignush_ [~Ignush@u193-11-161-109.studentnatet.se] has joined #bitcoin-core-dev
09:14 -!- Ignush_ [~Ignush@u193-11-161-109.studentnatet.se] has quit [Client Quit]
09:14 -!- Ignush [~Ignush@u193-11-161-109.studentnatet.se] has quit [Quit: Leaving]
09:33 -!- NorrinRadd [~username@154.6.21.39] has joined #bitcoin-core-dev
09:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Ping timeout: 246 seconds]
09:41 -!- NorrinRadd [~username@154.6.21.39] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
09:48 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 260 seconds]
09:55 -!- roconnor [~roconnor@coq/roconnor] has quit [Ping timeout: 240 seconds]
09:59 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
10:15 < pinheadmz_> Is this a discrepency between bip341 and taproot sighash implementation?
10:15 < pinheadmz_> https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1532-L1535
10:15 < pinheadmz_> the bip says ANYONECANPAY commits to value of utxo being spent
10:17 < pinheadmz_> or is value || scriptpubkey in that cache.m_spent_outputs[in_pos] ?
10:19 < pinheadmz_> ok that must be it, its more explicit in the python version in tests
10:20 < pinheadmz_> ill show myself out (I'll show myself CTxOut)
10:21 < david-bakin> Decl of CTxOut in transactionh shows it is a struct with a CAmount and a CScript - it serializes as one after the other.  I think it would be clearer if the 2 fields were in fact serialized separately as it shows in BIP-341.  That's in fact what I did in the unit tests I'm writing - see https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f
10:21 < david-bakin> 55f83a7a166a388cc5c27115aR787
10:21 < david-bakin> oooh bit by IRC line length limit, here's the link again: https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f55f83a7a166a388cc5c27115aR787
10:22 < pinheadmz_> david-bakin thanks !
10:29 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
10:39 -!- aleggg [~aleggg@179.178.119.144] has joined #bitcoin-core-dev
10:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Remote host closed the connection]
10:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
10:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 244 seconds]
10:57 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
10:57 -!- gnaf [~gnaf@195-154-105-157.rev.poneytelecom.eu] has joined #bitcoin-core-dev
11:00 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:10 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
11:30 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
11:34 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
11:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Ping timeout: 240 seconds]
11:55 < laanwj> hebasto:  the solution looks weird https://github.com/boostorg/process/commit/7a81779ff77cb462170467c0146c5652da6b2cb9   seems like they just nested boost::filesystem under boost::process or am i misunderstanding something?
11:59 < hebasto> laanwj: I did not look into details
12:00 < laanwj> #startmeeting
12:00 < core-meetingbot> Meeting started Thu May 19 19:00:00 2022 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:00 < core-meetingbot> Available commands: action commands idea info link nick
12:00 < hebasto> hi
12:00 < jonatack> hi
12:00 < laanwj> hebasto: i was interested to see what they actually did to solve it (e.g. make it a choice, remove boost::Filesystem completely, etc) but... i don't really get it
12:00 < kvaciral> hi
12:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
12:00 < lightlike> hi
12:00 < laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:00 < achow101> hi
12:00 < sipa> hi
12:01 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has joined #bitcoin-core-dev
12:01 < kanzure> hi
12:01 < laanwj> hi!
12:01 < _aj_> hi
12:01 < ariard> yo
12:01 < laanwj> looks like there have been no topics proposed in advance this week (you can propose meeting topics with #proposedmeetingtopic <topic> during any time of the week)
12:02 < laanwj> any last minute topics?
12:03 < instagibbs> hi
12:04 < b10c> hi
12:04 < laanwj> then let's begin with the usual
12:04 < laanwj> #topic High priority for review
12:04 < core-meetingbot> topic: High priority for review
12:05 < laanwj> there's currently 12 blockers and 2 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
12:05 < laanwj> anything to add or remove?
12:05 < cfields> hi
12:05 < Murch> hi
12:05 < laanwj> or is anything on the list almost ready for merge?
12:06 < ariard> i think gleb is still happy to get more reviews on #23443
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
12:07 < laanwj> imo it'd be good to have some more eyes on #22702, it's had quite a bit of review and testing, the comments have been addresed, i think it's more or less ready to go
12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
12:08 < jonatack> laanwj: i've been running that branch as well (rebased to master), need to re-review it
12:08 < laanwj> jonatack: thanks!
12:10 < laanwj> ariard: yes, it's had quite a lot of review and ACKs, but looks like it has an unaddressed comment by jonatack
12:11 < laanwj> (and a discussion about include-what-you-use by jnewbery and glozow)
12:11 < jonatack> ariard: been chatting offline with gleb about review, those comments were only initial, i plan to review that child pull soon too
12:12 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:12 < laanwj> though i'm not sure that' s something that holds up the PR
12:13 < ariard> jonatack: ah nice, yeah wasn't sure if it holds up the PR
12:13 < laanwj> right
12:13 < ariard> i'll ping him for the comments, meetings are usually late for him
12:13 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Ping timeout: 240 seconds]
12:13 < laanwj> ariard: thank you!
12:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev
12:14 < laanwj> anything else for high priority? any other topics?
12:14 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
12:15 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
12:15 < laanwj> i think #23595 is close too
12:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/23595 | util: Add ParseHex () helper by MarcoFalke · Pull Request #23595 · bitcoin/bitcoin · GitHub
12:15 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev
12:16 < laanwj> there's some higher level discussion about updating the developer guide when to use std::byte but that doesn't have to hold up the PR
12:16 < laanwj> i don't think the change itself is controversial
12:17 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
12:18 < laanwj> if no one has further topics that concludes the meeting, thanks everyone for attending, see you next week
12:18 < laanwj> #endmeeting
12:18 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:18 < core-meetingbot> Meeting ended Thu May 19 19:18:08 2022 UTC.  
12:18 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-05-19-19.00.moin.txt
12:18 < _aj_> s/if/since/ :)
12:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:18 < laanwj> hebasto: thinking of it, it's very possible that they're doing a trick like we do with an aliased namespace, that boost::process::filesystem can be an alias for either std::filesystem or boost::filesystem
12:19 < jonatack> perhaps one suggestion, maybe an occasional hint to active reviewers who are not here to look at the high priority ones, review appears to follow a power law concentration on the newly opened ones and the ones with github activity notifications (review attracts review...)
12:19 < laanwj> _aj_: right
12:19 < jonatack> (suggestion directed to myself as much as anyone else ;)
12:19 < laanwj> jonatack: how would we reach active reviewers that are not here
12:20 < jonatack> idk, maybe a nudge sentence by the irc logon bot
12:20 < ariard> we pray for their inner kharmas to read the post-meeting logs :)
12:20 < jonatack> just a thought :D
12:20 < laanwj> hehe
12:22 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
12:23 < jonatack> or a random (but somewhat rare) irc message courtesy of a friendly bot
12:24 < jonatack> s/reviewers who are not here/everyone/
12:25 < _aj_> i get review requests via the github feature from fanquake every now and then, which i find helpful
12:26 < fanquake> yea I try and promt people where I think it’s relevant
12:27 < _aj_> i guess it indicates both "this is something you're probably interested in, and it's liable to get merged if it's not buggy so is a productive use of time"
12:27 -!- olokun [~olokunpll@pool-100-38-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:31 < fanquake> Yea. That is true as well
12:33 -!- olokun [~olokunpll@pool-100-38-250-150.nycmny.fios.verizon.net] has quit [Quit: Leaving]
12:33 -!- olokun [~olokunpll@pool-100-38-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:41 < laanwj> yes, using that seems like a good idea, though mostly for things that aren't already high priority (which is supposed to be a prompt for *everyone* interested in it)
12:43 < olokun> only 200 members, should be way more. do we have a slack channel?
12:44 < sipa> please no
12:45 < bitcoin-git> [gui] ryanofsky opened pull request #600: refactor: Add OptionsModel getOption/setOption methods (master...pr/qtopt) https://github.com/bitcoin-core/gui/pull/600
12:48 < laanwj> it's not about the quantity of people here, not really
12:53 < bitcoin-git> [gui] ryanofsky opened pull request #601: refactor: Pass interfaces::Node references to OptionsModel constructor (master...pr/qtnode) https://github.com/bitcoin-core/gui/pull/601
13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 260 seconds]
13:11 < bitcoin-git> [bitcoin] brunoerg opened pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
13:14 < bitcoin-git> [gui] ryanofsky opened pull request #602: Unify bitcoin-qt and bitcoind persistent settings #15936 (master...pr/qtsopt) https://github.com/bitcoin-core/gui/pull/602
13:14 < dongcarl> libbitcoinkernel #24410 reviewers: I would love feedback on this: https://github.com/bitcoin/bitcoin/pull/24410#issuecomment-1132161124
13:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
13:15 < dongcarl> Many thanks in advance!
13:26 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
13:29 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
13:31 < david-bakin> clang-format, using src/.clang-format as the style - comes up with some awfully long lines.  It has `ColumnLimit: 0` which is supposed to "respect the input’s line breaking decisions within statements unless they contradict other rules" - so apparently I'm contradicting other rules.  Very long expressions I guess that I had manually broken up into lines.  What's the preferred style 
13:31 < david-bakin> for avoiding this?
13:33 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
13:34 -!- ronoaldo [~ronoaldo@187.75.64.192] has quit [Quit: Konversation terminated!]
13:35 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
13:36 -!- ronoaldo [~ronoaldo@187.75.64.192] has joined #bitcoin-core-dev
13:39 -!- nahmane [~Daniel_Ro@2601:2c6:c080:1030:982d:b66:4f43:2c8] has joined #bitcoin-core-dev
13:53 -!- nahmane [~Daniel_Ro@2601:2c6:c080:1030:982d:b66:4f43:2c8] has left #bitcoin-core-dev []
13:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Remote host closed the connection]
13:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has joined #bitcoin-core-dev
13:55 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:cdb3:455a:6919:b836] has quit [Remote host closed the connection]
13:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
14:02 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
14:04 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 240 seconds]
14:22 -!- bomb-on is now known as bolito-lover
14:23 -!- bolito-lover [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
14:24 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
14:24 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
14:26 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
14:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
14:29 -!- pk-b2 [noc_@gateway/vpn/protonvpn/noc/x-98562394] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:32 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
14:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
14:37 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
14:38 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
14:49 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection]
14:54 -!- tripleslash [~triplesla@user/tripleslash] has quit [Ping timeout: 276 seconds]
14:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
14:57 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
14:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 248 seconds]
15:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
15:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
15:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
15:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
15:09 < luke-jr> MarcoFalke abuses his merge access again with #25153
15:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25153 | scripted-diff: Use getInt over get_int/get_int64 by MarcoFalke · Pull Request #25153 · bitcoin/bitcoin · GitHub
15:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
15:09 < luke-jr> or rather, I guess fanquake did it
15:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
15:10 -!- NorrinRadd [~username@154.6.21.39] has joined #bitcoin-core-dev
15:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
15:13 -!- NorrinRadd [~username@154.6.21.39] has quit [Client Quit]
15:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
15:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
15:14 -!- NorrinRadd [~username@154.6.21.39] has joined #bitcoin-core-dev
15:15 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
15:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 272 seconds]
15:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
15:17 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
15:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds]
15:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
15:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
15:28 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
15:31 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds]
15:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
15:33 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
15:35 < bitcoin-git> [bitcoin] ajtowns opened pull request #25174: net/net_processing: Add thread safety related annotations for CNode and Peer (master...202205-net-lock-annotations) https://github.com/bitcoin/bitcoin/pull/25174
15:38 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds]
15:51 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
15:52 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
15:54 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
15:55 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds]
15:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
15:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds]
16:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
16:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
16:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 272 seconds]
16:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
16:11 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
16:12 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
16:13 -!- Kaizen___ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
16:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds]
16:16 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
16:16 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds]
16:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
16:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
16:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
16:32 -!- frnandu [~frnandu@localhost] has joined #bitcoin-core-dev
16:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 272 seconds]
16:34 -!- frnandu [~frnandu@localhost] has quit [Client Quit]
16:40 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
16:44 -!- olokun [~olokunpll@pool-100-38-250-150.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
16:44 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds]
16:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
16:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
17:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
17:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 260 seconds]
17:12 -!- NorrinRadd [~username@154.6.21.39] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:28 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
17:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
17:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
17:47 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
17:50 -!- bytes1440000 [~bytes1440@garza.riseup.net] has joined #bitcoin-core-dev
17:50 < bytes1440000> I wish github had advanced search filters to find pull requests merged by someone with some NACKs in reviews.
17:50 < bytes1440000> Tried this: is:pr is:merged involves:fanquake NACK in:comment
17:50 < bytes1440000> But it has lot of false positives.
17:51 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds]
17:53 -!- Kaizen___ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
18:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
18:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
18:10 -!- bytes1440000 [~bytes1440@garza.riseup.net] has left #bitcoin-core-dev []
18:14 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 272 seconds]
18:31 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
18:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
18:32 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds]
18:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
18:35 -!- hashfunc1204 [~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e] has joined #bitcoin-core-dev
18:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds]
18:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
18:38 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
18:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds]
18:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:00 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
19:05 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds]
19:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
19:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 248 seconds]
19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
19:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
19:23 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
19:27 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
19:32 -!- realies [~realies@user/realies] has quit [Ping timeout: 246 seconds]
19:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
19:35 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
19:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
19:44 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
19:46 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
19:49 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
19:49 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
19:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
19:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
19:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
20:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 244 seconds]
20:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
20:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 272 seconds]
20:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has joined #bitcoin-core-dev
20:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c] has quit [Ping timeout: 240 seconds]
20:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
20:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 244 seconds]
20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
20:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 240 seconds]
20:58 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:02 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
21:07 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
21:08 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
21:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
21:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
21:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
21:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
21:21 < david-bakin> I just got a linker error from `ld`which ld
21:22 < david-bakin> oops
21:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
21:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 272 seconds]
21:24 < david-bakin> I just got a linker error from `ld`: "DWARF error: invalid or unhandled FORM value: 0x25" - now, web search tells me this happens when clang's using dwarf v5 and some tool isn't set up for it.  I see in 00_setup_env_native_valgrind.h that they had this problem with valgrind so they set `CXXFLAGS=-fdebug-default-version=4` to get around this.  BUT!
21:25 < david-bakin> 1) if I pass that to configure then all the _other_ CXXFLAGS are overridden - none show up.  So how do I set configure to ADD this to the CXXFLAGS?
21:26 < david-bakin> and 2) should I be doing this anyway?  If I go through with this in this PR won't it change everyone's build?  So ... do I simply need to avoid the C++ construct that triggers this?
21:26 < david-bakin> I'm using clang 15.0.0 and GNU ld 2.37.  Should I be using a different toolchain?
21:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
21:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
21:36 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
21:40 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds]
21:44 -!- chinggg [~chinggg@198.16.63.47] has joined #bitcoin-core-dev
21:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
21:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
22:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
22:06 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
22:11 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
22:12 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
22:32 -!- hashfunc1204 [~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e] has quit [Ping timeout: 260 seconds]
22:35 < david-bakin> NVM I just rewrote C++ code until the problem went away.  
22:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
22:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 248 seconds]
22:48 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
22:53 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds]
22:59 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
23:04 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds]
23:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
23:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
23:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
23:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds]
23:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
23:36 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds]
23:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 244 seconds]
23:42 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
23:43 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
23:45 -!- Guest4630 [~Guest46@94.155.240.227] has joined #bitcoin-core-dev
23:48 < laanwj> from what i've seen uusally if you get DWARF errors it means you have to clean your tree, it means object files from different compilers are used together in a way they shouldn't
23:48 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0de36941eca1...6407c0e8a33f
23:48 < bitcoin-git> bitcoin/master fa305fd MarcoFalke: Add mockable clock type and TicksSinceEpoch helper
23:48 < bitcoin-git> bitcoin/master 6407c0e fanquake: Merge bitcoin/bitcoin#25101: Add mockable clock type
23:48 < bitcoin-git> [bitcoin] fanquake merged pull request #25101: Add mockable clock type (master...2205-mock-clock-😃) https://github.com/bitcoin/bitcoin/pull/25101
23:48 -!- Guest4630 [~Guest46@94.155.240.227] has quit [Client Quit]
23:50 < laanwj> oh, yes, it could also mean your linker is not compatible with the debug information your compiler generates
23:51 < laanwj> it shouldn't be related to anything you wrote at the C++ level, nothing you do at that level should (unless a bug in the toolchain) result in a DWARF error
23:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev
23:58 < laanwj> jonatack ran into a similar error with clang 15 recently #25120
23:58 <@gribble> https://github.com/bitcoin/bitcoin/issues/25120 | test: fix DWARF string_view linker error in blockfilter_tests by jonatack · Pull Request #25120 · bitcoin/bitcoin · GitHub
23:58 < laanwj> his solution was to clear ccache 
--- Log closed Fri May 20 00:00:12 2022