--- Log opened Fri May 20 00:00:12 2022 --- Day changed Fri May 20 2022 00:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds] 00:08 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 00:10 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev 00:11 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 00:13 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 00:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6407c0e8a33f...d433f59f1eb8 00:19 < bitcoin-git> bitcoin/master 055d94d brunoerg: test: add coverage for unknown network in -onlynet 00:19 < bitcoin-git> bitcoin/master d433f59 MacroFake: Merge bitcoin/bitcoin#25173: test: add coverage for unknown network in -on... 00:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173 00:28 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 00:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev 00:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d433f59f1eb8...4a8709821e64 00:29 < bitcoin-git> bitcoin/master 1d4122d Ryan Ofsky: init: Allow -proxy="" setting values 00:29 < bitcoin-git> bitcoin/master 4a87098 MacroFake: Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values 00:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24830: init: Allow -proxy="" setting values (master...pr/proxy) https://github.com/bitcoin/bitcoin/pull/24830 00:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 248 seconds] 00:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev 00:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8709821e64...a39002e0c642 00:36 < bitcoin-git> bitcoin/master fafae67 MacroFake: build: Enable RPC_DOC_CHECK on --enable-debug 00:36 < bitcoin-git> bitcoin/master a39002e fanquake: Merge bitcoin/bitcoin#25170: build: Enable RPC_DOC_CHECK on --enable-debug 00:36 < bitcoin-git> [bitcoin] fanquake merged pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170 00:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 272 seconds] 00:40 < jonatack> #24150 might be RFM 00:40 <@gribble> https://github.com/bitcoin/bitcoin/issues/24150 | refactor: move index class members from protected to private by jonatack · Pull Request #24150 · bitcoin/bitcoin · GitHub 00:43 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 00:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a39002e0c642...a7e3afb22136 00:49 < bitcoin-git> bitcoin/master ef0aa74 Sebastian Falbesoner: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic 00:49 < bitcoin-git> bitcoin/master a4703ce Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=exclude_coinbas... 00:49 < bitcoin-git> bitcoin/master a7e3afb MacroFake: Merge bitcoin/bitcoin#25171: rpc: wallet: remove `-deprecatedrpc=exclude_c... 00:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171 00:58 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 00:59 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 01:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev 01:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds] 01:15 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:18 -!- Aaronvan_ [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 01:23 -!- david-bakin [~david-bak@c-174-61-163-5.hsd1.wa.comcast.net] has quit [Ping timeout: 272 seconds] 01:31 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev 01:32 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 240 seconds] 01:36 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 246 seconds] 01:38 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 01:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev 01:42 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev 01:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 260 seconds] 01:46 < laanwj> jonatack: yes 01:47 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a7e3afb22136...0cd1a2eff9e0 01:47 < bitcoin-git> bitcoin/master fabdf81 MarcoFalke: test: Add test for embedded null in hex string 01:47 < bitcoin-git> bitcoin/master facd1fb MarcoFalke: refactor: Use Span of std::byte in CExtKey::SetSeed 01:47 < bitcoin-git> [bitcoin] laanwj merged pull request #23595: util: Add ParseHexstd::byte() helper (master...2111-utilHexByte) https://github.com/bitcoin/bitcoin/pull/23595 01:52 < laanwj> jonatack: wait, i don't get it, why make CDBWrapper a struct instead of a class? 01:54 < laanwj> i don't really know what the guidance is for making something a struct or a class but anything that *inherits* from a parent class seems definitely in class territory to me 01:54 < laanwj> i mean, DB 01:55 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 01:55 < laanwj> CDBWrapper is a class, BaseIndex::DB is derived from it, so should imo be a class too 02:00 -!- Aaronvan_ [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 02:03 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 248 seconds] 02:03 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 02:11 < laanwj> this PR keeps confusing me on small c++ details 02:12 < laanwj> i'm sorry to say but i'm not sure it's really worth it or just a very marginal improvement 02:15 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 02:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has joined #bitcoin-core-dev 02:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd] has quit [Ping timeout: 240 seconds] 02:39 < vasild> https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes has some meaningful guidelines on struct VS class 02:42 < jonatack> was offline, now catching up on the discussion 02:44 < bitcoin-git> [gui] hebasto merged pull request #594: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS (master...q_os_macos) https://github.com/bitcoin-core/gui/pull/594 02:45 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0cd1a2eff9e0...8118970c869f 02:45 < bitcoin-git> bitcoin/master e3daeca João Barbosa: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS 02:45 < bitcoin-git> bitcoin/master 8118970 Hennadii Stepanov: Merge bitcoin-core/gui#594: scripted-diff: replace deprecated Q_OS_MAC wit... 02:49 < jonatack> laanwj: will drop that accessory change in the last commit 02:53 -!- greypw2546 [~greypw254@grey.pw] has quit [Quit: I'll be back!] 02:53 -!- greypw2546 [~greypw254@grey.pw] has joined #bitcoin-core-dev 03:01 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev 03:07 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 240 seconds] 03:12 < jonatack> Done. I think it's a good simplification, encapsulation improvement, and code clarification that helps new virtual functions be added in the right place rather than by default next to existing ones (that were misplaced). This came up in review feedback over several PRs. 03:14 < hebasto> has bitcoin-git bot just got another holiday? 03:25 < laanwj> jonatack: thanks! 03:25 < laanwj> hebasto: i didn't give if time off i'll check 03:27 < hebasto> laanwj: thank you 03:33 < bitcoin-git> [gui] hebasto merged pull request #581: refactor: Revamp `ClientModel` code to handle core signals (master...220410-invoke) https://github.com/bitcoin-core/gui/pull/581 03:35 < laanwj> i'm not entirely sure what happened (the matrix side was throwing an error resolving the room alias), restarting the bot seems to have solved it 03:36 < hebasto> thanks! 04:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 04:16 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 04:18 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds] 04:40 < bitcoin-git> [bitcoin] hebasto opened pull request #25175: refactor: Improve thread safety analysis by propagating some negative capabilities (master...220520-nega) https://github.com/bitcoin/bitcoin/pull/25175 04:41 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 244 seconds] 04:42 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 04:53 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 04:58 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 272 seconds] 05:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds] 05:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 05:01 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 05:18 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 05:23 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 05:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8c61374ba782...4d0c00dffd13 05:37 < bitcoin-git> bitcoin/master fa4ee53 MacroFake: Do not pass time getter to Chainstate helpers 05:37 < bitcoin-git> bitcoin/master faf012b MacroFake: Do not pass Consensus::Params& to Chainstate helpers 05:37 < bitcoin-git> bitcoin/master fafe5c0 MacroFake: Do not pass CChainParams& to BlockAssembler constructor 05:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168 05:42 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 05:48 < bitcoin-git> [bitcoin] jonatack opened pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176 05:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 06:03 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 06:29 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 06:55 < bitcoin-git> [bitcoin] theStack opened pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178 07:05 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 07:11 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev 07:16 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 07:20 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 08:13 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 08:16 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 260 seconds] 08:27 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 08:28 -!- david-bakin [~david-bak@c-174-61-163-5.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:31 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 08:41 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 09:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 09:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds] 09:11 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 09:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 09:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 09:28 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 09:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 09:33 -!- furszy [~furszy@user/furszy] has quit [Remote host closed the connection] 09:34 < david-bakin> hmm, clear ccache - i'll try that next time - but I don't rule out an incompatibility in the toolchain because it _did_ go away when I changed the code 10:06 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 10:38 -!- furszy [~furszy@user/furszy] has quit [] 11:17 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [] 11:40 < bitcoin-git> [gui] ryanofsky opened pull request #603: Add settings.json prune-prev, proxy-prev, onion-prev settings (master...pr/qtkeep) https://github.com/bitcoin-core/gui/pull/603 11:41 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:f8a2:49f0:843c:1b6d] has joined #bitcoin-core-dev 11:41 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:f8a2:49f0:843c:1b6d] has quit [Remote host closed the connection] 11:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/aac99faa66e2...640eb772e556 11:41 < bitcoin-git> bitcoin/master dbe45c3 Carl Dong: Add ChainstateManagerOpts, using as ::Options 11:41 < bitcoin-git> bitcoin/master 04c31c1 Carl Dong: Add ChainstateManager::m_adjusted_time_callback 11:41 < bitcoin-git> bitcoin/master 53494bc Carl Dong: validation: Have ChainstateManager own m_chainparams 11:41 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064 11:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 11:43 -!- gnaf [~gnaf@195-154-105-157.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 12:01 < achow101> #startmeeting 12:01 < core-meetingbot> Meeting started Fri May 20 19:01:43 2022 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 12:01 < core-meetingbot> Available commands: action commands idea info link nick 12:01 < achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier paveljanik 12:01 < achow101> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar S3RK sipa vasild 12:02 < achow101> we haven't had a wallet meeting in a while 12:02 < sipa> hi 12:02 < achow101> there aren't any pre-proposed wallet meeting topics. Does anyone have anything to discuss? 12:03 < Murch> hi 12:04 < kanzure> hi 12:04 < achow101> or any PRs to shill? 12:04 < Murch> I don't have anything from the top of my head 12:04 < Murch> https://github.com/bitcoin/bitcoin/pull/25083 12:05 < Murch> I think it's almost ready to go, could use another review or two 12:06 < achow101> I think #24649 and #25122 are close as well 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/24649 | wallet: do not count wallet utxos as external by S3RK · Pull Request #24649 · bitcoin/bitcoin · GitHub 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub 12:06 < Murch> Oh, I should look at #25122 12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub 12:07 < Murch> I have reviewed the other already 12:08 < achow101> It looks like there have been a lot of proposed changes to AvailableCoins that conflict with each other, but all look nice to get in 12:08 < Murch> Yeah, that's right 12:09 < achow101> e.g. #25005 #25118 #25083 #24699 #24584 12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub 12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25118 | wallet: unify “allow/block other inputs“ concept by furszy · Pull Request #25118 · bitcoin/bitcoin · GitHub 12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub 12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/24699 | wallet: Improve AvailableCoins performance by reducing duplicated operations by achow101 · Pull Request #24699 · bitcoin/bitcoin · GitHub 12:09 < achow101> any thoughts on what to prioritize? 12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub 12:09 < Murch> I don't think Josi's is close to getting merged. 12:09 < Murch> I haven't looked at #25005, so I can't comment on that 12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub 12:10 < achow101> 25083 and 25118 both are pretty simple 12:10 < Murch> How useful is 24699 now that we use different keys? 12:10 < achow101> so I think they can go in soon 12:11 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 12:11 < Murch> I'm biased, one of my PRs is building on #25083 ^^ 12:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub 12:11 < achow101> I think 24699 is still a worthwhile promovement. it improves more than just the reused addresses case 12:12 < achow101> *improvement 12:12 < Murch> okay 12:12 < Murch> I'll put all of the above on my review list 12:13 < Murch> I think just in the order that they're ready is fine 12:13 < Murch> I don't think rebasing would get too bad for any 12:14 < Murch> You should add josibake to your ping list ^^ 12:14 < achow101> I think 24584 might have a larger conflict with the others 12:14 < achow101> but it's also not ready imo 12:15 < Murch> Yeah, and it is also the biggest one 12:15 < achow101> anything else look ready or nearly ready? 12:15 < jonatack> hi  (...reading up) 12:17 < achow101> anything else to discuss? 12:17 < Murch> Not from the top of my head. Really curious to see some simulation results for #24584 12:17 <@gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub 12:18 < Murch> I'm wondering how splitting the UTXO pool in multiple ways will affect the tx costs 12:18 < Murch> Oh one more 12:18 < Murch> There is this very tight testing corset that S3RK proposed 12:19 < Murch> So far you and I reviewed it, achow101 12:19 < Murch> Yours sounded like a soft concept nack or approach nack 12:20 < achow101> #24580? 12:20 <@gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub 12:20 < Murch> I think maintaining the test when we start changing the coin selection algos will be annoying, but it's also kinda nice to see the exact boundaries 12:20 < Murch> yeah thanks! 12:20 < Murch> I think that S3RK might be a bit stuck there, no way forward not really shot down either 12:21 < achow101> perhaps more people should look at it 12:21 < Murch> Could we perhaps give more input how it should be developed to address maintainability concerns? 12:23 < achow101> maybe more programmatic math rather than hardcoded math 12:23 < Murch> Yeah 12:24 < Murch> Do you know what the status with Bruno's "Prefer changeless" PR is? 12:24 < Murch> That also seemed a bit stuck 12:24 < instagibbs> woof, lots of magic numbers 12:24 < instagibbs> re: #24580 12:24 <@gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub 12:26 < Murch> https://github.com/bitcoin/bitcoin/pull/23475 12:26 < achow101> Murch: it seems like it needs conceptual review as to whether that's a good idea? 12:27 < Murch> achow101: I think I'd be "concept ack, approach nack", wasn't sure whether that came out clearly 12:27 < Murch> Is brunoerg here? 12:27 < jonatack> having good boundary testing of expected behavior in place before making big changes can be good if the testing is of the right kind... maybe hoist the magic numbers up to constants or derive them programmatically as mentioned 12:28 < Murch> jonatack: that sounds like a good idea 12:28 < jonatack> might be good for people to weigh in on https://github.com/bitcoin/bitcoin/issues/25130 12:28 < instagibbs> derive please, don't make follow-on contributors hate life 12:29 < instagibbs> can even be done and merged piece by piece 12:29 < achow101> #23475 would interact pretty poorly with #24752 12:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub 12:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/24752 | wallet: increase BnB upper limit by S3RK · Pull Request #24752 · bitcoin/bitcoin · GitHub 12:29 < Murch> instagibbs, jonatack: I think one issue is also that it sorta depends on the current selection of algorithms we use, and sort of tests whether the outcome was Knapsack, or BnB at times 12:30 < instagibbs> Murch, yeah I'm not wading in on the overall thrust, deferring on that 12:30 < Murch> Yeah, #23475 needs some sanity limit, similar to the avoid_partial_spend approach 12:30 <@gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub 12:31 < Murch> Okay, I guess the overall result is, we could all take another glance at these and perhaps be a bit more direct with feedback? ;) 12:31 < achow101> yes 12:31 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 12:31 < jonatack> instagibbs: Murch: agree, may need more abstraction 12:32 < achow101> anything else to discuss? 12:33 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds] 12:33 -!- lukedashjr is now known as luke-jr 12:34 < Murch> No, just … by the way, I'm of the opinion that Knapsack needs to die 12:34 < Murch> :D 12:34 < achow101> #endmeeting 12:34 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 12:34 < core-meetingbot> Meeting ended Fri May 20 19:34:16 2022 UTC. 12:34 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-05-20-19.01.moin.txt 12:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 12:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 12:35 < Murch> Thanks for hosting 12:36 < sipa> @Murch channels his inner cato? 12:36 < Murch> Ceterum censeo Knapsackinem esse delendam. 12:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds] 12:39 < Murch> Keeps me focused on the important stuff 🤪 12:43 < instagibbs> what change size does SRD shoot for these days 12:43 < instagibbs> if any 12:49 < Murch> äääääässogzonbbclnreolrägnweenagcapshwhlhräl 12:49 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 12:50 < Murch> oops 12:50 < Murch> SRD uses the lower bound of the random change introduced by #24494 as a minimum now 12:50 <@gribble> https://github.com/bitcoin/bitcoin/issues/24494 | wallet: generate random change target for each tx for better privacy by glozow · Pull Request #24494 · bitcoin/bitcoin · GitHub 12:50 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 12:53 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds] 12:57 < Murch> And that's 50,000 ṩ 13:02 < instagibbs> oh wow great to see 13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 276 seconds] 13:14 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 246 seconds] 13:14 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 13:25 -!- mudsip [~mudsip@user/mudsip] has quit [] 13:38 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 13:40 -!- MiranDaniel [~MiranDani@46-13-162-93.customers.tmcz.cz] has joined #bitcoin-core-dev 13:53 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 13:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 14:04 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 14:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 14:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 14:10 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 14:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 14:35 -!- MiranDaniel [~MiranDani@46-13-162-93.customers.tmcz.cz] has quit [Quit: Client closed] 14:35 -!- MiranDaniel [~MiranDani@46-13-162-93.customers.tmcz.cz] has joined #bitcoin-core-dev 14:50 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 14:51 -!- jarthur_ [~jarthur@user/jarthur] has quit [Ping timeout: 248 seconds] 14:52 < bitcoin-git> [bitcoin] MiranDaniel opened pull request #25182: doc: Fix Markdown formatting (master...master) https://github.com/bitcoin/bitcoin/pull/25182 14:54 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 15:03 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 276 seconds] 15:13 -!- MiranDaniel [~MiranDani@46-13-162-93.customers.tmcz.cz] has quit [Quit: Client closed] 15:26 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 15:38 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 16:03 -!- chinggg [~chinggg@198.16.63.47] has quit [Quit: Client closed] 16:21 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection] 16:26 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 16:30 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds] 16:37 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 16:39 -!- Guest6 [~Guest6@120.29.77.62] has joined #bitcoin-core-dev 16:42 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds] 16:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 16:44 -!- Guest6 [~Guest6@120.29.77.62] has quit [Client Quit] 16:48 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 16:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 272 seconds] 16:50 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 16:53 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 16:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:56 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 16:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 17:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 17:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 17:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 17:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 244 seconds] 17:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 17:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 17:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 17:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 272 seconds] 18:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 18:02 -!- hashfunc1a22 [~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e] has joined #bitcoin-core-dev 18:02 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 18:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds] 18:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 18:07 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 18:08 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds] 18:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 18:11 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds] 18:26 -!- hashfunc1a22 [~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e] has quit [Ping timeout: 260 seconds] 18:34 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 18:38 -!- BUSY [~BUSY@user/busy] has quit [Remote host closed the connection] 18:38 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 18:39 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev 18:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 18:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 18:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 18:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 272 seconds] 18:56 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 19:00 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 19:01 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds] 19:02 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 19:07 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds] 19:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 19:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 19:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds] 19:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 19:21 < david-bakin> WUT? Consider `base_blob::SetHex(const char* psz)` from `uint256.cpp` It wants to do a big-endian external representation to little-endian internal representation, so it starts at the end of the string and works its way to the front. This is at lines 44-45 where it advances to the end and then you can see the `--` predecrements at lines 49 and 51. However! It does this by 19:21 < david-bakin> NIBBLES not BYTES! So the hex string "5A" becomes the byte "A5". This can't be right! But it IS used in `TransactionTableModel::updateTransaction`. There is no comment describing this behavior in `uint256.h` at the decl. 19:23 < david-bakin> luke-jr, fanquake, sipa: hate to bother you, but is this the intent? are there other places where endianness is at the nibble level, not the byte level? 19:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 272 seconds] 19:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 19:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 19:26 < sipa> That sounds very strange. 19:26 < david-bakin> I guess it is used in a few other places too - there are two overloads, one for string constant, other for std::string 19:29 < david-bakin> well hold on, i may have misinterpreted what was going on - it's a bit trick - hold a bit 19:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 19:29 < david-bakin> well damn me I take it back - of course now I can't explain what I'm seeing in MY test but it is obviously my problem 19:30 < david-bakin> OK I APOLOGIZE 19:33 < luke-jr> david-bakin: various historical aspects of Bitcoin do some crazy things re endian 19:33 < luke-jr> (but I don't recall that one specifically) 19:34 < david-bakin> well I have seen that! some things are, when turned into hex strings, "backwards" from others - endianness in external representation is not uniform. but I think this was my brain damage. 19:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 19:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 240 seconds] 19:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 19:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 252 seconds] 19:52 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 19:52 < david-bakin> I outsmarted myself by cleverly choosing a test data set that was nearly palindromic ... but not quite ... well, live and learn SOME BAD IDEAS I guess, sorry! 19:56 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 19:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 20:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 20:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 20:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 20:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 20:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 244 seconds] 20:15 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 20:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 20:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 20:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 20:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 20:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 240 seconds] 20:44 < bitcoin-git> [bitcoin] aureleoules opened pull request #25183: rpc: Witness-only inputs for fundrawtransaction (master...2022-05-witness-only-fundrawtransaction) https://github.com/bitcoin/bitcoin/pull/25183 20:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:10 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 21:10 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 21:13 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds] 21:19 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds] 21:20 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds] 21:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 21:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 21:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 21:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 21:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 21:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 244 seconds] 21:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 21:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 21:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 21:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 21:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 244 seconds] 22:00 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 22:04 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds] 22:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 22:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 22:13 -!- Common_ [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 22:14 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has quit [Quit: Ping timeout (120 seconds)] 22:14 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 22:16 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 244 seconds] 22:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 22:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 244 seconds] 22:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 22:48 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 22:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 22:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 22:53 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 23:06 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 23:10 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds] 23:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 23:13 -!- ronoaldo [~ronoaldo@187.75.64.192] has quit [Remote host closed the connection] 23:14 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 246 seconds] 23:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 272 seconds] 23:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 23:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 23:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] 23:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds] 23:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 23:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 23:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 244 seconds] 23:40 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:44 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds] 23:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has joined #bitcoin-core-dev 23:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc] has quit [Ping timeout: 260 seconds] --- Log closed Sat May 21 00:00:29 2022