--- Log opened Wed May 25 00:00:33 2022
00:01 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
00:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
00:06 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
00:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
00:21 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
00:25 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
00:27 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 240 seconds]
00:51 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/90e49c1ececd...bd57b4e0c01b
00:51 < bitcoin-git> bitcoin/master 247d170 Jon Atack: build: add DEBUG_LOCKCONTENTION to --enable-debug configuration
00:51 < bitcoin-git> bitcoin/master 345647c Jon Atack: ci: add DEBUG_LOCKCONTENTION to CI task containing DEBUG_LOCKORDER
00:51 < bitcoin-git> bitcoin/master bd5dbc3 Jon Atack: doc: update developer notes wrt --enable-debug and DEBUG_LOCKCONTENTION
00:51 < bitcoin-git> [bitcoin] fanquake merged pull request #24757: build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI (master...add-DEBUG_LOCKCONTENTION-to-enable-debug) https://github.com/bitcoin/bitcoin/pull/24757
01:01 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
01:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 240 seconds]
01:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
01:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd57b4e0c01b...8c721fff3a00
01:04 < bitcoin-git> bitcoin/master 295ff61 brunoerg: test: add coverage for unknown -blockfilterindex
01:04 < bitcoin-git> bitcoin/master 8c721ff MacroFake: Merge bitcoin/bitcoin#25192: test: add coverage for unknown value to -bloc...
01:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25192: test: add coverage for unknown value to -blockfilterindex (master...2022-05-unknown-blockfilter) https://github.com/bitcoin/bitcoin/pull/25192
01:08 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 248 seconds]
01:10 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-dev
01:12 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
01:17 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
01:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
01:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
01:36 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22956: validation: log CChainState::CheckBlockIndex() consistency checks (master...CheckBlockIndex-logging) https://github.com/bitcoin/bitcoin/pull/22956
01:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
01:42 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev
01:44 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
01:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
01:55 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
01:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
02:04 -!- kexkey [~kexkey@178.249.214.19] has quit [Ping timeout: 258 seconds]
02:06 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev
02:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
02:07 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
02:14 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
02:17 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
02:23 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
02:25 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
02:30 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
02:30 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
02:35 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
02:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 260 seconds]
02:55 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
03:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
03:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
03:10 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
03:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 258 seconds]
03:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
03:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
03:48 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/cb13ba6d1172...04fdd644b43a
03:48 < bitcoin-git> bitcoin/22.x 344537c Ryan Ofsky: qt: Avoid crash on startup if int specified in settings.json
03:48 < bitcoin-git> bitcoin/22.x 04fdd64 laanwj: Merge bitcoin/bitcoin#25180: [22.x] qt: Avoid crash on startup if int spec...
03:48 < bitcoin-git> [bitcoin] laanwj merged pull request #25180: [22.x] qt: Avoid crash on startup if int specified in settings.json (22.x...pr/setint22) https://github.com/bitcoin/bitcoin/pull/25180
04:04 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
04:05 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
04:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 258 seconds]
04:24 -!- Guest75 [~Guest75@98.20.168.164] has joined #bitcoin-core-dev
04:25 -!- Guest75 [~Guest75@98.20.168.164] has quit [Client Quit]
04:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 240 seconds]
04:28 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c721fff3a00...b4f686952a60
04:28 < bitcoin-git> bitcoin/master d4b3dc5 Hennadii Stepanov: contrib: Remove keys that are no longer used for merging
04:28 < bitcoin-git> bitcoin/master b4f6869 laanwj: Merge bitcoin/bitcoin#25197: contrib: Remove keys that are no longer used ...
04:28 < bitcoin-git> [bitcoin] laanwj merged pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
04:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
04:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
04:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
04:47 < jamesob> I've noticed that future witness version pubkeys are considered standard: https://github.com/jamesob/bitcoin/blob/fcf6c8f4eb217763545ede1766831a6b93f583bd/src/script/standard.cpp#L172-L176. I'm kind of surprised by that, because I would have figured once we introduce a new witness version, we wouldn't want unupgraded nodes relaying the new
04:47 < jamesob> witness-versioned transactions. Can someone remind me of the rationale? 
04:49 < jamesob> s/pubkeys/scriptPubKeys
04:52 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
04:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
04:56 < jamesob> Oh... I guess future witness versions are ruled out later on in the AreInputsStandard(...) checks
04:57 < stick> jamesob: why we wouldn’t want unupgraded nodes to relay them?
04:57 < stick> this will cause splits in the network, no?
04:58 < stick> (relay network)
04:59 < jamesob> stick: if an unupgraded miner was relayed a future witness version that was actually an invalid spend (per the new rules) they could mine a block that would split the chain between upgraded and non-upgraded
05:00 < jamesob> (I think?)
05:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 255 seconds]
05:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
05:05 < bitcoin-git> [bitcoin] jamesob opened pull request #25210: doc: remove misleading AreInputsStandard() comment (master...2022-05-areinputsstandard-comment) https://github.com/bitcoin/bitcoin/pull/25210
05:05 -!- ronoaldo [~ronoaldo@187.75.64.192] has joined #bitcoin-core-dev
05:06 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 258 seconds]
05:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
05:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
05:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
05:21 < jamesob> anyone know why we don't allow RBFability in the testmempoolaccept RPC?
05:24 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
05:27 < stick> jamesob: good point!
05:37 < lightlike> jamesob: I think #15846 was the relevant PR and has some more rationale.
05:37 <@gribble> https://github.com/bitcoin/bitcoin/issues/15846 | [POLICY] Make sending to future native witness outputs standard by sipa · Pull Request #15846 · bitcoin/bitcoin · GitHub
05:41 < jamesob> lightlike: thanks
05:52 < sipa> jamesob: The policy for spends was later changed in #20165 (specific for taproot, but the general idea behind it would be applicable for other softforks too).
05:52 <@gribble> https://github.com/bitcoin/bitcoin/issues/20165 | Only relay Taproot spends if next block has it active by sipa · Pull Request #20165 · bitcoin/bitcoin · GitHub
05:53 < jamesob> sipa: cool, thanks for the pointer
06:00 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
06:08 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
06:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
06:26 < TallTim> Just a lowly full-node operator here (BTC), but I can tell you if we ever collectively go down the road supporting Miner Extractable Value, that is when I'll be looking to jump ship. Rubin is right about being cautious to avoid it.
06:30 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds]
06:35 < instagibbs> TallTim, wrong channel for random FUD sorry
06:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
06:39 < TallTim> No fud, just a statement of truth. Pursuit of MEV results in me re-evaluating my involvement. Cheers.
06:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
06:45 < lightlike> this is probably related to today's optech newsletter, so not entirely random, but still offtopic for this channel.
06:46 < TallTim> True, a topic relating to discussion in this very channel is off-topic. My mistake. Thank you.
06:47 < sipa> TallTim: This channel is about the development of the Bitcoin Core software, an implementation of the Bitcoin protocol. It is not the place to discuss the direction the Bitcoin protocol itself is going.
06:48 < TallTim> Clarification then - did a meeting take place here regarding the topic?
06:48 < sipa> No?
06:48 < TallTim> Please indicate with yes/no.
06:48 < TallTim> Then my source was too vague, my mistake.
06:48 < instagibbs> there was a CTV meeting which is where optech picked up the discussion... 
06:48 < sipa> Not here, in any case.
06:49 < TallTim> Fair.
06:49 < TallTim> Cheers, back to PR's.
06:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
07:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
07:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
07:28 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
07:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Remote host closed the connection]
07:40 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
07:55 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
07:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
07:59 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
08:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
08:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
08:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
08:29 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
08:33 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds]
08:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
08:36 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev
08:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
08:40 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
08:43 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
08:43 < bitcoin-git> [bitcoin] Aw761678 opened pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
08:44 < bitcoin-git> [bitcoin] Aw761678 closed pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
08:44 < bitcoin-git> [bitcoin] Aw761678 reopened pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
08:45 < bitcoin-git> [bitcoin] fanquake closed pull request #25212: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25212
08:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
08:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
08:55 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
08:56 -!- Guest3 [~Guest@2401:4900:1f37:d3:71f1:5c6:9c55:8a0e] has joined #bitcoin-core-dev
08:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
08:58 -!- Guest3 [~Guest@2401:4900:1f37:d3:71f1:5c6:9c55:8a0e] has quit [Client Quit]
09:00 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 260 seconds]
09:00 -!- mrlemke [~mrlemke@208.74.105.200] has quit [Quit: Leaving]
09:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
09:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
09:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
09:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 255 seconds]
09:09 -!- furszy [~furszy@user/furszy] has quit [Remote host closed the connection]
09:11 -!- mudsip [~mudsip@user/mudsip] has quit []
09:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
09:20 -!- Guest73 [~Guest73@2405:201:c009:d876:d8cc:679d:ef2a:84ef] has joined #bitcoin-core-dev
09:23 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Ping timeout: 240 seconds]
09:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
09:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
09:29 -!- Guest73 [~Guest73@2405:201:c009:d876:d8cc:679d:ef2a:84ef] has quit [Quit: Ping timeout (120 seconds)]
09:34 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 258 seconds]
09:34 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
09:35 < bitcoin-git> [bitcoin] furszy opened pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
09:36 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
09:37 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has joined #bitcoin-core-dev
09:46 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:53 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has quit [Quit: Leaving]
09:56 < bitcoin-git> [bitcoin] ryanofsky opened pull request #25214: libmultiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (master...pr/mpdep) https://github.com/bitcoin/bitcoin/pull/25214
09:58 -!- PaperSword [~PaperSwor@50.126.96.22] has joined #bitcoin-core-dev
10:13 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
10:17 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer]
10:19 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev
10:23 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
10:25 -!- furszy [~furszy@user/furszy] has quit [Remote host closed the connection]
10:26 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:28 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 258 seconds]
10:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
10:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:34 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
10:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
10:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 258 seconds]
10:40 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
10:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:42 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
10:44 -!- Kaizen___ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:47 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 258 seconds]
10:48 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
10:49 -!- Kaizen___ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
10:50 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds]
11:18 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
11:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
11:34 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
11:35 -!- Aaronvan_ [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
11:37 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev
11:38 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 240 seconds]
11:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
11:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
11:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
11:49 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
11:52 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds]
12:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
12:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
12:20 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
12:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Read error: Connection reset by peer]
12:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:41 -!- Kaizen_K_ [~Kaizen_Ki@2607:fb90:22d2:5d08:d977:4580:f53b:c691] has joined #bitcoin-core-dev
12:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 258 seconds]
12:47 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev
12:52 -!- Guest65 [~Guest65@191.7.107.250] has joined #bitcoin-core-dev
12:53 -!- Guest65 [~Guest65@191.7.107.250] has quit [Client Quit]
12:56 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
13:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
13:33 < dongcarl> I might have asked this before but, in our fuzzing framework, we only call the initialize_* function once at the beginning then the FUZZ_TARGET_INIT multiple times, right?
13:47 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 255 seconds]
13:48 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev
13:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has joined #bitcoin-core-dev
14:00 -!- Kaizen_K_ [~Kaizen_Ki@2607:fb90:22d2:5d08:d977:4580:f53b:c691] has quit [Ping timeout: 240 seconds]
14:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has quit [Remote host closed the connection]
14:31 < bitcoin-git> [bitcoin] dongcarl opened pull request #25215: [kernel 2d/n] Reduce CTxMemPool constructor call sites (master...2022-03-libbitcoinkernel-reduce-mempool-ctor) https://github.com/bitcoin/bitcoin/pull/25215
14:45 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 255 seconds]
14:50 < bitcoin-git> [bitcoin] mutatrum opened pull request #25216: Update zmq.md: Fix parameter in hwm example block (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25216
14:52 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 244 seconds]
14:54 < bitcoin-git> [bitcoin] jonatack opened pull request #25217: scripts and tools: update lint-logs.py with LogPrintLevel() (master...update-logs-linter-script-with-LogPrintLevel) https://github.com/bitcoin/bitcoin/pull/25217
15:07 < sipa> dongcarl: FUZZ_TARGET_INIT is just a macro; it defines a fuzz function (the body following the macro) which gets run once for every fuzzer input, with an initializer whose name is the second argument to the macro.
15:08 < dongcarl> sipa: But the initializer only gets run once right?
15:08 < sipa> yes
15:09 < sipa> and only if that fuzzer is actually selected (through the env FUZZ variable).
15:09 < dongcarl> cool cool, thanks!
15:17 < bitcoin-git> [bitcoin] furszy opened pull request #25218: wallet: introduce generic 'Result' classes and connect it to `CreateTransaction` and `GetNewDestination` (master...2022_generic_result) https://github.com/bitcoin/bitcoin/pull/25218
15:22 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
15:23 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
15:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:33 < bitcoin-git> [bitcoin] natanleung opened pull request #25219: test: deploymentinfo.cpp unit tests (master...deploymentinfo_unit_test) https://github.com/bitcoin/bitcoin/pull/25219
15:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Remote host closed the connection]
15:45 -!- furszy [~furszy@user/furszy] has quit []
15:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
15:56 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds]
15:58 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
16:01 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds]
16:04 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4f686952a60...192d639a6b1b
16:04 < bitcoin-git> bitcoin/master c97e961 furszy: fuzz: coinselection, add missing fee rate.
16:04 < bitcoin-git> bitcoin/master 192d639 Andrew Chow: Merge bitcoin/bitcoin#25213: fuzz: fix crash at coinselection, add missing...
16:04 < bitcoin-git> [bitcoin] achow101 merged pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
16:05 -!- Earnestly [~earnest@user/earnestly] has quit [Read error: Connection reset by peer]
16:06 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
16:07 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds]
16:21 < dongcarl> Hi folks, what happens when we do `EXCLUSIVE_LOCKS_REQUIRED(m_mempool->cs)` and m_mempool is nullptr? What about when we LOCK(m_mempool->cs) and m_mempool is nullptr?
16:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
16:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 244 seconds]
16:31 < jonatack> dongcarl: if possible, maybe pass a reference that cannot be nullptr (otherwise add an assert?) am thinking of https://github.com/bitcoin/bitcoin/pull/25016/commits/86ce844d3b287012f27c7b0bad6d11c9bdd3120e for example
16:33 < jonatack> (oh erm, for locks...will beg off that it is very late here :)
16:33 < dongcarl> hehe nw
16:35 < jonatack> PT_GUARDED_BY?
16:47 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has joined #bitcoin-core-dev
16:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has quit [Remote host closed the connection]
17:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
17:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 240 seconds]
17:11 < luke-jr> dongcarl: afaik, doing -> on a nullptr is always UB
17:14 -!- jesseposner [~jesse@user/jesseposner] has quit [Quit: Textual IRC Client: www.textualapp.com]
17:17 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
17:19 < jamesob> dongcarl: it's a trick for allowing that annotation to work with nullable locks; it just doesn't enforce anything if there's no lock. See https://github.com/bitcoin/bitcoin/pull/22415#issuecomment-875999127
17:20 < dongcarl> Ah!
17:20 < dongcarl> Okay cool
17:24 < bitcoin-git> [bitcoin] brunoerg opened pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220
17:25 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection]
17:25 < jamesob> dongcarl: predictably it boils down to patented ryanofsky cpp wizardry
17:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
17:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 260 seconds]
17:47 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 260 seconds]
18:02 < luke-jr> laanwj: v23.0 rel notes don't have the changelog?
18:12 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
18:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
18:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 255 seconds]
18:27 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
18:31 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
18:43 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
18:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
18:55 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
18:58 -!- jesseposner [~jesse@user/jesseposner] has joined #bitcoin-core-dev
19:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
19:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has joined #bitcoin-core-dev
19:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has quit [Remote host closed the connection]
20:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has joined #bitcoin-core-dev
20:16 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
20:18 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has quit [Ping timeout: 255 seconds]
20:20 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
20:29 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has joined #bitcoin-core-dev
20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 260 seconds]
20:32 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
20:33 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
20:57 -!- jtraub91 [~Jason@098-147-176-043.res.spectrum.com] has joined #bitcoin-core-dev
20:58 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:01 -!- jtraub91 [~Jason@098-147-176-043.res.spectrum.com] has quit [Client Quit]
21:02 -!- jtraub91 [~Jason@098-147-176-043.res.spectrum.com] has joined #bitcoin-core-dev
21:02 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 258 seconds]
21:06 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Ping timeout: 240 seconds]
21:06 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev
21:35 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has quit [Ping timeout: 244 seconds]
21:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
21:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:c45d:c9ef:f1c8:c769] has joined #bitcoin-core-dev
22:15 < bitcoin-git> [bitcoin] antoinedesbois opened pull request #25221: Improve CMedianFilter algorithm (master...timedata_bench) https://github.com/bitcoin/bitcoin/pull/25221
22:22 -!- Guest52 [~Guest52@2409:4043:2e99:9522:a4f5:95f5:9e3e:4117] has joined #bitcoin-core-dev
22:23 -!- Guest52 [~Guest52@2409:4043:2e99:9522:a4f5:95f5:9e3e:4117] has quit [Client Quit]
22:35 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:50 < jonatack> jamesob: nice! noting that
22:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has quit [Ping timeout: 260 seconds]
22:51 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
22:52 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
22:58 < laanwj> luke-jr: correct
22:59 < laanwj> achow101: is there any way we can check/review #25201, besides just believing it and merging it :)
22:59 <@gribble> https://github.com/bitcoin/bitcoin/issues/25201 | windeploy: Renewed windows code signing certificate by achow101 · Pull Request #25201 · bitcoin/bitcoin · GitHub
22:59 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
23:00 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
23:04 -!- Guest71 [~Guest71@86.124.124.39] has joined #bitcoin-core-dev
23:07 -!- Guest71 [~Guest71@86.124.124.39] has quit [Client Quit]
23:14 -!- cryptoquick [~cryptoqui@8.46.89.33] has joined #bitcoin-core-dev
23:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
23:27 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection]
23:27 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev
23:33 < luke-jr> laanwj: is that intentional? (I see it's a pain..)
23:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8dad:ff4:acd:af20] has joined #bitcoin-core-dev
23:40 -!- PaperSwordAlt [~PaperSwor@50.126.96.22] has joined #bitcoin-core-dev
23:43 -!- PaperSword [~PaperSwor@50.126.96.22] has quit [Ping timeout: 240 seconds]
23:44 < laanwj> luke-jr: it's intentional in the sense that i didn't get around to doing it, i'm also not sure if it's worth the trouble (it's easy enough to get a list of merges/PRs, the time intensive is sorting them into categories), fwiw you seem to be only the second person to mention it at all
23:49 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
23:55 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
23:56 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
--- Log closed Thu May 26 00:00:34 2022