--- Log opened Fri May 27 00:00:35 2022
00:00 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
00:01 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
00:05 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
00:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 272 seconds]
00:37 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
00:37 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
00:45 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:49 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
00:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has quit [Ping timeout: 272 seconds]
01:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5e67be03bb0...77e125c486d0
01:06 < bitcoin-git> bitcoin/master 75848ec Jon Atack: scripts and tools: update lint-logs.py to detect LogPrintLevel()
01:06 < bitcoin-git> bitcoin/master 77e125c MacroFake: Merge bitcoin/bitcoin#25217: scripts and tools: update lint-logs.py to det...
01:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25217: scripts and tools: update lint-logs.py to detect LogPrintLevel, mention WalletLogPrintf (master...update-logs-linter-script-with-LogPrintLevel) https://github.com/bitcoin/bitcoin/pull/25217
01:09 -!- Guest93 [~Guest93@103.240.241.92] has joined #bitcoin-core-dev
01:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has joined #bitcoin-core-dev
01:13 -!- Guest93 [~Guest93@103.240.241.92] has quit [Client Quit]
01:15 -!- Guest93 [~Guest93@103.240.241.92] has joined #bitcoin-core-dev
01:21 -!- Guest93 [~Guest93@103.240.241.92] has quit [Quit: Client closed]
01:22 -!- Guest93 [~Guest93@103.240.241.92] has joined #bitcoin-core-dev
01:25 -!- Aniket6990 [~Aniket699@59.92.127.124] has joined #bitcoin-core-dev
01:33 -!- Aniket6990 [~Aniket699@59.92.127.124] has quit [Quit: Client closed]
01:33 -!- Aniket6990 [~Aniket699@59.92.127.124] has joined #bitcoin-core-dev
01:34 -!- Aniket6990 [~Aniket699@59.92.127.124] has quit [Client Quit]
02:00 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has quit [Quit: You have been kicked for being idle]
02:03 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 246 seconds]
02:06 -!- kexkey [~kexkey@178.249.214.25] has joined #bitcoin-core-dev
02:06 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
02:07 < vasild> Can I haz #24356 in high-prio for review? It would help move #21878 forward.
02:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/24356 | refactor: replace CConnman::SocketEvents() with mockable Sock::WaitMany() by vasild · Pull Request #24356 · bitcoin/bitcoin · GitHub
02:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/21878 | Make all networking code mockable by vasild · Pull Request #21878 · bitcoin/bitcoin · GitHub
02:10 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds]
02:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has quit [Ping timeout: 255 seconds]
02:18 -!- Guest93 [~Guest93@103.240.241.92] has quit [Quit: Client closed]
02:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has joined #bitcoin-core-dev
02:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has quit [Ping timeout: 260 seconds]
02:49 -!- greypw25460 [~greypw254@grey.pw] has quit [Quit: I'll be back!]
02:49 -!- greypw25460 [~greypw254@grey.pw] has joined #bitcoin-core-dev
02:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has joined #bitcoin-core-dev
03:00 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77e125c486d0...66bb4df41059
03:00 < bitcoin-git> bitcoin/master 7e9fe6d Andrew Chow: windeploy: Renewed windows code signing certificate
03:00 < bitcoin-git> bitcoin/master 66bb4df fanquake: Merge bitcoin/bitcoin#25201: windeploy: Renewed windows code signing certi...
03:00 < bitcoin-git> [bitcoin] fanquake merged pull request #25201: windeploy: Renewed windows code signing certificate (master...2022-05-win-cert) https://github.com/bitcoin/bitcoin/pull/25201
03:09 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25224: Get time less often in AddrManImpl::ResolveCollisions_() (master...2205-time-less-🐠) https://github.com/bitcoin/bitcoin/pull/25224
03:12 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
03:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has quit [Ping timeout: 244 seconds]
04:02 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
04:17 -!- Arvidt [~Arvidt@gateway/tor-sasl/arvidt] has joined #bitcoin-core-dev
04:18 -!- Arvidt [~Arvidt@gateway/tor-sasl/arvidt] has quit [Client Quit]
04:25 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
04:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has joined #bitcoin-core-dev
04:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has quit [Ping timeout: 260 seconds]
04:33 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
04:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has joined #bitcoin-core-dev
04:47 -!- mudsip [~mudsip@user/mudsip] has quit []
04:55 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
05:02 -!- Guest13 [~Guest13@136.56.164.223] has joined #bitcoin-core-dev
05:08 -!- Guest63 [~Guest63@167-179-176-185.a7b3b0.bne.nbn.aussiebb.net] has joined #bitcoin-core-dev
05:09 -!- Guest63 [~Guest63@167-179-176-185.a7b3b0.bne.nbn.aussiebb.net] has quit [Client Quit]
05:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 276 seconds]
05:25 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
05:26 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
05:28 -!- Guest13 [~Guest13@136.56.164.223] has quit [Ping timeout: 252 seconds]
05:29 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
05:30 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
05:31 < jamesob> I'm not understanding why the 26th iteration of this loop doesn't hit a "too many descendants for tx" error, anyone know? https://github.com/jamesob/bitcoin/blob/c5e67be03bb06a5d7885c55db1f016fbf2333fe3/test/functional/feature_rbf.py#L370-L376
05:35 < jamesob> Oh - the answer is that in the test setup, we manually specify the descendant count limit: https://github.com/jamesob/bitcoin/blob/c5e67be03bb06a5d7885c55db1f016fbf2333fe3/test/functional/feature_rbf.py#L42. So I'm still confused by RBF rule 5.
05:37 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
05:38 -!- mnl222 [~mnl222@137.175.69.68] has joined #bitcoin-core-dev
05:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:40 -!- mnl222 [~mnl222@137.175.69.68] has quit [Remote host closed the connection]
05:40 -!- mnl222 [~mnl222@137.175.69.68] has joined #bitcoin-core-dev
05:45 -!- mnl222 [~mnl222@137.175.69.68] has quit [Remote host closed the connection]
05:50 -!- furszy [~furszy@186.141.137.60] has joined #bitcoin-core-dev
05:50 -!- furszy [~furszy@186.141.137.60] has quit [Changing host]
05:50 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
06:00 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev
06:07 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
06:10 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 255 seconds]
06:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/66bb4df41059...57bf12523cf9
06:14 < bitcoin-git> bitcoin/master 7036cf5 KevinMusgrave: Delete UpdatePackagesForAdded at beginning of addPackageTxs.
06:14 < bitcoin-git> bitcoin/master 57bf125 MacroFake: Merge bitcoin/bitcoin#24934: refactor, miner: Delete call to UpdatePackage...
06:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24934: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs (master...2022-04-delete-UpdatePackagesForAdded) https://github.com/bitcoin/bitcoin/pull/24934
06:14 < sdaftuar2> jamesob: not sure if i'm misunderstanding your question, but i'll take a stab at it - imagine there are 5 transactions in the mempool that are unrelated, and each has 24 descendants. then a new transaction comes along that conflicts all 5 of those transactions.
06:14 -!- sdaftuar2 is now known as sdaftuar
06:15 < sdaftuar> that new transaction would cause 125 transactions to be evicted, so it would fail that rbf policy test
06:15 < sdaftuar> (even if it paid sufficient fees etc)
06:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/57bf12523cf9...3ba6dd6f4bb4
06:18 < bitcoin-git> bitcoin/master 4185570 t-bast: Add RPC to get mempool txs spending outputs
06:18 < bitcoin-git> bitcoin/master 3ba6dd6 MacroFake: Merge bitcoin/bitcoin#24408: rpc: add rpc to get mempool txs spending spec...
06:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24408: rpc: add rpc to get mempool txs spending specific prevouts (master...get-mempool-spending-tx) https://github.com/bitcoin/bitcoin/pull/24408
06:20 < sdaftuar> jamesob: or even simpler, imagine a transaction with 101 inputs -- that could directly conflict with 101 different in-mempool transactions, which would violate the rule
06:25 < jamesob> sdaftuar: thanks - what do you mean exactly by "directly conflict" in that simpler case? in that case, what exactly is being RBF'd to evict the 101 txns supplying those inputs?
06:25 -!- edouard[m] [~edouardma@2001:bc8:1828:379::1] has joined #bitcoin-core-dev
06:26 < sdaftuar> new tx B directly conflicts with existing tx A if an input of tx A is double-spent in B
06:26 < sdaftuar> so in theory, a transaction B with N inputs could directly conflict with N different transactions in the mempool
06:26 < jamesob> I thought we just didn't allow admission to the mempool for tx B on the basis that its inputs are not available?
06:26 < sdaftuar> well this is the RBF case! so the point is to allow it and evict the other transactions if the feerate/total fee checks pass
06:27 < jamesob> ooooh, I see - if each of those N transactions is marked RBFable
06:27 < sdaftuar> right
06:28 < sdaftuar> the point of that rule #5 is to avoid pathological situations where we might be evicted thousands of transactions to make room for a new one
06:28 < jamesob> okay, so the only practical case where rule 5 might apply is when a single RBF replacement txn is "uniting" a bunch of separate txn graphs
06:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
06:29 < jamesob> (or where the user has configured higher ancestor/descendant limits)
06:29 < sdaftuar> and there could be cpu dos concerns or something, we could probably reason about it more carefully but i think the 100 limit was designed to be accommodate anything reasonably anyone might want to do
06:29 < sdaftuar> (bah english is hard sorry)
06:30 < jamesob> no I gotcha
06:30 < jamesob> okay thanks, that all makes sense. Looks like we don't have a functional test for that case you just showed me
06:31 < jamesob> (rather we manually set the ancestor/desc limits higher and then trigger rule 5 with a single fully contiguous txn graph)
06:31 < sdaftuar> ah ok, yeah maybe it would be nice to conflict with multiple different transaction packages too then
06:32 < sdaftuar> i don't think that's a different code path, but is it a different logical thing so perhaps worth doing for the next person who has this question :)
06:32 < sdaftuar> but it is*
06:33 < jamesob> right
06:41 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 258 seconds]
06:43 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3ba6dd6f4bb4...345457b542b6
06:43 < bitcoin-git> bitcoin/master 6e1c16c Ryan Ofsky: multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory
06:43 < bitcoin-git> bitcoin/master 44904aa Ryan Ofsky: multiprocess build cleanup: comment on manual dependencies
06:43 < bitcoin-git> bitcoin/master 345457b fanquake: Merge bitcoin/bitcoin#25214: multiprocess build fix: ipc/capnp/init.capnp....
06:43 < bitcoin-git> [bitcoin] fanquake merged pull request #25214: multiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (master...pr/mpdep) https://github.com/bitcoin/bitcoin/pull/25214
06:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25227: Return empty vector on invalid hex encoding (master...2205-reject-non-hex-🌲) https://github.com/bitcoin/bitcoin/pull/25227
06:53 -!- furszy [~furszy@user/furszy] has quit []
06:58 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
07:10 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
07:13 -!- flooded is now known as _flood
07:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
07:53 < _aj_> jamesob: it's the test_too_many_replacements in feature_rbf.py, no?
08:01 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
08:02 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
08:13 < jamesob> _aj_: right, but that hinges on setting the descendant limit higher than default
08:14 < _aj_> jamesob: *nod*
08:14 < _aj_> omg, setting up CI for a bitcoin fork is easy now? <3 you guys
08:15 < jamesob> I'm writing a test case at the moment that will show what sdaftuar outlined above
08:16 < _aj_> jamesob: 30 comfirmed utxos, each spent by a single in mempool tx, then an attempt to RBF to a single tx that spends all 30 utxos?
08:17 < _aj_> s/30/101/ i guess
08:17 < davidbakin> wait, setting up CI for a fork is easy?  where can I find a step-by-step?
08:17 < _aj_> davidbakin: you just enable cirrus-ci for your repo
08:18 < _aj_> okay, that's not enough for the previous-releases test
08:19 < davidbakin> no i'm just interested in testing my own code before making a PR so that's ok
08:20 < davidbakin> i just get myself a cirrus-ci account I guess?  (preferably free?)
08:20 < _aj_> free for public repos
08:21 < davidbakin> huh.  i just want to be able to, for example, pass lint and win64 on my own rather than wait for bitcoin/bitcoin to find it in my PR.  thanks!
08:21 < jamesob> _aj_: yep, that's right
08:21 < davidbakin> (w.r.t. win64: I've been bit just recently by the standard annoying windows dev bugaboo of defining an enum value to be FALSE only to have it conflict with a win32 sdk macro FALSE ...)
08:22 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
08:33 < _aj_> "macro FALSE" sounds like drahtbot's next fake id
08:34 < sipa> MacroFake
08:44 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
08:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
09:05 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
09:07 < fanquake> davidbakin: you can just run the scripts locally, in the exact same many as the ci: https://github.com/bitcoin/bitcoin/tree/master/ci
09:08 < fanquake> *manner
09:17 < davidbakin> yes i've been meaning to try that for the lint run, also tidy, also ASAN & MSAN, but it won't work for win64.  So I'm glad to know about setting up cirrus-ci. (I haven't had any issues with ARM/Android/Mac ... yet ...)  (Huh, I just looked at a recent random PR and the memory consumption for ASAN & MSAN are both _much_ lower than I expected.  I guess it is within my capabilities to 
09:17 < davidbakin> run them.)
09:42 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
10:02 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
10:05 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 258 seconds]
10:08 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
10:13 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
10:17 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
10:20 -!- furszy [~furszy@user/furszy] has quit [Ping timeout: 260 seconds]
10:28 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
10:30 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
10:32 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
10:36 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
10:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 244 seconds]
10:51 < bitcoin-git> [bitcoin] jamesob opened pull request #25228: test: add BIP-125 rule 5 testcase with default mempool (master...2022-05-bip125-rule5-test) https://github.com/bitcoin/bitcoin/pull/25228
10:52 < jamesob> sdaftuar _aj_: ^
10:52 < jamesob> man I keep typing _aja_; too much Steely Dan in my subconscious
10:55 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
10:55 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
11:05 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
11:06 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds]
11:11 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
11:25 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
11:28 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:48 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 246 seconds]
11:56 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
11:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:00 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
12:18 -!- furszy [~furszy@user/furszy] has quit [Read error: Connection reset by peer]
12:18 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
12:44 -!- metallicc [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has joined #bitcoin-core-dev
12:45 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:56 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 246 seconds]
13:16 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 255 seconds]
13:19 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has joined #bitcoin-core-dev
13:33 -!- Guest13 [~Guest13@136.56.164.223] has joined #bitcoin-core-dev
13:39 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has quit [Quit: Leaving]
13:49 -!- DeanGuss [~dean@user/deanguss] has quit [Quit: buhbye]
13:58 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
14:03 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #bitcoin-core-dev
14:03 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host]
14:03 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-core-dev
14:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 255 seconds]
14:15 < willcl_ark> Is there a specific policy on what gets backported?
14:16 < sipa> bugs
14:17 < sipa> and softforks, if need be
14:17 < _aj_> sipa: i vote we try to backport the fixes, not the bugs
14:17 < sipa> I vote to follow _aj_'s suggestions.
14:19 < willcl_ark> Ok thanks. Is there any height bar for bugs, or is it just if they're deemed sufficiently inconvenient/bad?
14:20 < sipa> There are occasionally examples where it's debatable, but usually it's pretty clear when a commit/PR is fixing an issue vs. introducing a feature.
14:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:18a:d1ed:1e3d:3442] has quit [Remote host closed the connection]
14:21 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 255 seconds]
14:21 < willcl_ark> Ok thanks. And finally, if I was to make a fix on master, I'm not obligated to also provide an equivalent backport too am I? I think I've just seen those PRs get a new label assigned...
14:22 < willcl_ark> perhaps obligated is too strong, would good etiquette be to also provide a backport?
14:22 < sipa> Generally maintainers will do the backporting for you. Unless it's particularly nasty to do so, in which case either it may be decided not to backport it (depending on severity), or a backport-specific bugfix could be developed by the author of the fix.
14:23 < willcl_ark> Makes sense. Thanks for the insight
14:23 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
14:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
14:38 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
14:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 240 seconds]
14:41 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds]
14:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
14:48 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
15:04 -!- aleggg [~aleggg@179.177.109.104.dynamic.adsl.gvt.net.br] has quit []
15:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
15:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 260 seconds]
15:16 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
15:21 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 255 seconds]
15:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds]
15:24 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
15:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
15:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 244 seconds]
15:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
15:42 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
15:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds]
15:52 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:54 -!- ronoaldo [~ronoaldo@179.228.27.247] has joined #bitcoin-core-dev
15:57 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
16:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 244 seconds]
16:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
16:30 -!- aleggg [~aleggg@179.177.109.104.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
16:35 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Quit: The Lounge - https://thelounge.chat]
16:38 -!- Saloframes [~Saloframe@user/Saloframes] has joined #bitcoin-core-dev
16:50 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
16:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 240 seconds]
16:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
17:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 255 seconds]
17:02 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
17:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
17:44 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
17:49 -!- Guest13 [~Guest13@136.56.164.223] has quit [Ping timeout: 252 seconds]
18:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 276 seconds]
18:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 260 seconds]
18:50 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
18:52 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds]
19:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
19:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 258 seconds]
19:28 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
19:34 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
19:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
19:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 244 seconds]
19:48 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
19:52 < davidbakin> so I am now running CI tests on a branch on my fork.  `lint` fails in `lint-git-commit-check.py` with "Not a valid object name master" - is this something I did in my fork when creating my branch? or what?  there isn't any other useful information printed here, e.g., commit hash.  I'll try to run it locally to see if I can debug it but if you happen to know ...
19:54 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
19:55 < sipa> i suspect your repo doesn't have a master branch
19:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
20:07 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
20:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 255 seconds]
20:11 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
20:13 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
20:15 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
20:16 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
20:23 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
20:32 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
20:33 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
20:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 255 seconds]
20:55 -!- mekster66949 [~mekster@user/mekster] has quit [Quit: mekster66949]
20:56 -!- mekster66949 [~mekster@user/mekster] has joined #bitcoin-core-dev
20:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 255 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:14 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.4]
21:15 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
21:16 -!- ronoaldo [~ronoaldo@179.228.27.247] has quit [Ping timeout: 260 seconds]
21:20 -!- ronoaldo [~ronoaldo@179.228.27.247] has joined #bitcoin-core-dev
21:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
21:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 258 seconds]
21:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 258 seconds]
21:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev
21:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
22:26 < davidbakin> it does, it's just a fork of bitcoin/bitcoin - oh wait, i read something in the cirrus ci docs that it _only pulls your branch_ that triggered it - let me investigate
22:32 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 276 seconds]
22:44 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
22:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has quit [Ping timeout: 255 seconds]
23:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:15bb:b9b2:1dc3:2d0a] has joined #bitcoin-core-dev
23:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds]
23:23 -!- ronoaldo [~ronoaldo@179.228.27.247] has quit [Remote host closed the connection]
23:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
23:57 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
--- Log closed Sat May 28 00:00:36 2022