--- Log opened Mon May 30 00:00:37 2022 00:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds] 00:10 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 00:33 -!- Guest83 [~Guest83@110.235.227.100] has joined #bitcoin-core-dev 00:34 -!- Guest83 [~Guest83@110.235.227.100] has quit [Client Quit] 00:37 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 00:40 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 00:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 00:51 -!- z9z0b3t1c [~z9z0b3t1c@145.224.65.211] has joined #bitcoin-core-dev 00:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Ping timeout: 260 seconds] 00:53 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds] 00:56 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 256 seconds] 01:01 -!- dougefish [~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239] has quit [Read error: Connection reset by peer] 01:01 -!- dougefish [~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239] has joined #bitcoin-core-dev 01:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has joined #bitcoin-core-dev 01:09 -!- jarthur_ [~jarthur@user/jarthur] has quit [Quit: jarthur_] 01:10 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 01:15 < laanwj> div72: how do you even get a foreign key into that function? i don't think it's considered an issue because afaik, that function is only used for loading wallets, and it only supports the keys generated by bitcoin core itself 01:15 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 01:16 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b6ab45ae5c91...e3b7f10b1066 01:16 < bitcoin-git> bitcoin/master 20ff499 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck 01:16 < bitcoin-git> bitcoin/master e3b7f10 fanquake: Merge bitcoin/bitcoin#25237: rpc: Capture UniValue by ref for rpcdoccheck 01:16 < bitcoin-git> [bitcoin] fanquake merged pull request #25237: rpc: Capture UniValue by ref for rpcdoccheck (master...202205_rpcdoc_capture) https://github.com/bitcoin/bitcoin/pull/25237 01:17 < laanwj> e.g. it only needs to roundtrip with ec_seckey_export_der 01:25 < laanwj> but maybe i'm missing something, or this is an ancient wallet from the time bitcoin's wallet still used openssl? 01:27 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 246 seconds] 01:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b7f10b1066...8779adbdda76 01:42 < bitcoin-git> bitcoin/master cc61bc2 fanquake: compat: remove glibcxx sanity checks 01:42 < bitcoin-git> bitcoin/master 8779adb MacroFake: Merge bitcoin/bitcoin#25233: compat: remove glibcxx sanity checks 01:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25233: compat: remove glibcxx sanity checks (master...remove_glibcxx_sanity) https://github.com/bitcoin/bitcoin/pull/25233 01:47 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-馃搳) https://github.com/bitcoin/bitcoin/pull/25241 01:47 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-馃搳) https://github.com/bitcoin/bitcoin/pull/25242 01:50 < luke-jr> guix builds please * [new tag] v23.0.knots20220529 -> v23.0.knots20220529 01:51 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 01:54 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 255 seconds] 02:00 < laanwj> luke-jr: building 02:01 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev 02:04 -!- kexkey [~kexkey@178.249.214.25] has quit [Ping timeout: 244 seconds] 02:06 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 02:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Ping timeout: 258 seconds] 02:21 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [] 02:33 < bitcoin-git> [bitcoin] suhailsaqan opened pull request #25243: test: autogenerate bash completion (master...bash-completion) https://github.com/bitcoin/bitcoin/pull/25243 02:38 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 02:38 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye] 02:44 -!- donor [~donor@2409:4043:2c10:6f6c:61b7:7fd3:7714:ddca] has joined #bitcoin-core-dev 02:49 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 03:04 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 03:05 < luke-jr> laanwj: thanks 03:16 < hebasto> theStack: II've tested the master branch at 0be1dc1f56f611bebb4204a3f3221f425f156bcf, and it does not seem that #20640 changed behavior. Not being a wallet expert, I'm afraid I just failed to create the right testing transaction. Do you have an example of a tx which fires the `WalletModel::AmountWithFeeExceedsBalance` error (pre-20640)? 03:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack 路 Pull Request #20640 路 bitcoin/bitcoin 路 GitHub 03:32 < bitcoin-git> [bitcoin] fanquake opened pull request #25244: build: pass bdb cppflags only where needed (master...use_bdb_cppflags_needed) https://github.com/bitcoin/bitcoin/pull/25244 03:37 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25245: refactor: Remove no-op TIME_INIT on deser (master...2205-no-time-deser-馃寳) https://github.com/bitcoin/bitcoin/pull/25245 03:41 -!- donor [~donor@2409:4043:2c10:6f6c:61b7:7fd3:7714:ddca] has quit [Ping timeout: 250 seconds] 03:42 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 03:43 < bitcoin-git> [bitcoin] fanquake opened pull request #25246: Revert "build: more robustly check for fcf-protection support" (master...remove_clang_7_note) https://github.com/bitcoin/bitcoin/pull/25246 03:55 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 03:57 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds] 04:00 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 244 seconds] 04:02 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 04:06 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 04:25 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection] 04:26 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev 04:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has joined #bitcoin-core-dev 04:34 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds] 04:54 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 05:08 -!- erwanor [sid556324@id-556324.ilkley.irccloud.com] has joined #bitcoin-core-dev 05:14 < erwanor> Hey, I've been trying to find a design doc summarizing the different binary wallet formats / compatibility graph but so far no dice. Does anyone have a lead? if there isn't one, I'll try to write it myself (if you can point me to important release tags I should look at, that'd be extra cool!) 05:16 < sipa> there are two database formats (bdb and sqlite), and two type ways to encode "the set of watched addresses" in a wallet (legacy and descriptor). Old wallets are bdb/legacy, new wallets are sqlite/descriptor. 05:18 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 05:21 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 05:21 -!- ronoaldo [~ronoaldo@187.75.64.116] has joined #bitcoin-core-dev 05:24 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 272 seconds] 05:24 -!- ronoaldo [~ronoaldo@187.75.64.116] has quit [Client Quit] 05:28 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 05:31 -!- bytes1440000 [~bytes1440@garza.riseup.net] has joined #bitcoin-core-dev 05:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Ping timeout: 260 seconds] 05:33 < bytes1440000> hebasto: I followed everything from https://github.com/bitcoin/bitcoin/blob/master/doc/build-android.md but still get the same error as shared by achow101 in https://github.com/bitcoin/bitcoin/issues/22522 when compiling with https://github.com/bitcoin/bitcoin/pull/22555 05:33 < bitcoin-git> [gui] hebasto opened pull request #611: test, refactor: Use the same shutdown path as in bitcoin-qt binary (master...220530-exec2) https://github.com/bitcoin-core/gui/pull/611 05:35 < hebasto> bytes1440000: could you post your exact steps in a pr comment? 05:36 < bytes1440000> Sure 05:36 < hebasto> ty 05:36 -!- bytes1440000 [~bytes1440@garza.riseup.net] has left #bitcoin-core-dev [] 05:37 -!- ronoaldo [~ronoaldo@187.75.64.116] has joined #bitcoin-core-dev 05:57 -!- Guest6727 [~Guest67@197.210.54.229] has joined #bitcoin-core-dev 05:58 -!- Guest6727 [~Guest67@197.210.54.229] has quit [Client Quit] 06:01 -!- ronoaldo [~ronoaldo@187.75.64.116] has quit [Ping timeout: 240 seconds] 06:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has joined #bitcoin-core-dev 06:08 -!- ronoaldo [~ronoaldo@200-171-83-35.dsl.telesp.net.br] has joined #bitcoin-core-dev 06:19 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 06:20 < luke-jr> 23.0 just isn't the version for release notes. I messed up and put Core's 23.0 notes in Knots instead >_< 06:23 -!- ronoaldo [~ronoaldo@200-171-83-35.dsl.telesp.net.br] has quit [Ping timeout: 256 seconds] 06:51 -!- z9z0b3t1c [~z9z0b3t1c@145.224.65.211] has quit [Remote host closed the connection] 06:51 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 06:51 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has joined #bitcoin-core-dev 06:52 < b10c> theStack: not sure if you've seen https://bip324.com/sections/code-review/ (RE https://github.com/bitcoin/bitcoin/pull/24545#issuecomment-1141148561) also not sure if that's up-to-date 06:52 < b10c> dhruv ^ 06:53 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 06:55 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/8779adbdda76...ad9e5eaf77bf 06:55 < bitcoin-git> bitcoin/master 318655c Jon Atack: Add missing references to signet in the release process 06:55 < bitcoin-git> bitcoin/master b4d2d74 Jon Atack: Release process: specify blockchain/chain_state units, reduce repetition 06:55 < bitcoin-git> bitcoin/master e538ead laanwj: Release process: exclude huge files for mainnet m_assumed_blockchain_size 06:55 < bitcoin-git> [bitcoin] laanwj merged pull request #24424: doc: release process chainparams updates (master...release-process-chainparams-updates) https://github.com/bitcoin/bitcoin/pull/24424 07:03 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev 07:05 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 07:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 07:27 < theStack> hebasto: Thanks for taking a look! To my understanding, the error should be thrown if coin selection / fee calculation fails due to not having enough funds to cover the fees (if "fSubtractFeeFromAmount" is not set). The simplest transaction I can think of is one that simply spends _all_ funds of a wallet. Not sure though if the GUI is allowing that, maybe there is no possibility and throwing `AmountWithFeeExceedsBalance` was already dead code b 07:27 < theStack> efore #20640 was merged. 07:27 <@gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack 路 Pull Request #20640 路 bitcoin/bitcoin 路 GitHub 07:27 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds] 07:28 < theStack> b10c: (RE BIP324 link) That seems to be very useful, thanks! Indeed I wasn't aware that there is a dedicated webpage for BIP324 07:29 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25248: refactor: Add LIFETIMEBOUND / -Wdangling-gsl to Assert() (master...2205-assert-lifetime-馃悳) https://github.com/bitcoin/bitcoin/pull/25248 07:41 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 07:43 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 07:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25249: Bump univalue subtree (master...2205-univalue-馃帠) https://github.com/bitcoin/bitcoin/pull/25249 07:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 07:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ad9e5eaf77bf...269fa667f248 07:59 < bitcoin-git> bitcoin/master e93046c Daniela Brozzoni: MOVEONLY: Move signrawtransactionwithwallet test 07:59 < bitcoin-git> bitcoin/master e895900 Daniela Brozzoni: test: Use MiniWallet in rpc_rawtransaction.py 07:59 < bitcoin-git> bitcoin/master 269fa66 MacroFake: Merge bitcoin/bitcoin#25044: test: Use MiniWallet in rpc_rawtransaction.py 08:00 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25044: test: Use MiniWallet in rpc_rawtransaction.py (master...test_rawtransaction_miniwallet) https://github.com/bitcoin/bitcoin/pull/25044 08:10 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 08:19 < div72> laanwj: You're right, I've encountered the issue in a downstream where OpenSSL was still being used. The chances of this affecting Bitcoin is pretty slim as a wallet from a 7y old version which needs to be compiled with a pre 3 recent OpenSSL version is needed. 08:19 < div72> That's why I've come to ask instead of just making a PR. 08:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Remote host closed the connection] 08:23 -!- furszy [~furszy@user/furszy] has quit [Ping timeout: 240 seconds] 08:23 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 08:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has joined #bitcoin-core-dev 08:37 < davidbakin> so that means someone with such a wallet can't in fact use a newer bitcoin core to read it? 08:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Ping timeout: 240 seconds] 08:42 < sipa> it's not clear to me whether this is an issue for the bitcoin core codebase at all (includin historical versions) 08:42 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-馃懃) https://github.com/bitcoin/bitcoin/pull/25250 08:43 < sipa> there are certainly DER private key encodings that are valid but bitcoin core today wouldn't be able to parse, as it doesn't have a full DER parser 08:43 < sipa> but i believe that no version of bitcoin core (including very old ones) would emit such encodings 08:48 < div72> I am not sure on the exact conditions which can cause this, but pre-libsecp256k1 uses i2d_ECPrivateKey which can. 08:57 < sipa> Well, it didn't happen with Bitcoin Core versions from 2014 linked against OpenSSL from 2014 and before. 08:57 < sipa> And Bitcoin Core from back then cannot be used unmodified against today's OpenSSL's versions. 08:58 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 08:58 < div72> Fair point. 08:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 276 seconds] 09:01 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 09:05 < laanwj> "This repository contains Python scripts for allele-specific mapping. They were used to map ATAC-seq, RNA-seq and Hi-C reads in a mouse" heh apparently there's another "asmap" project on github with a quite different purpose 09:06 < sipa> Sorry, I'm not good at naming things. 09:06 < sipa> ;( 09:07 < laanwj> it would be hard to confuse them! 09:07 < sipa> I recently discovered that the code we were using to gather BGP dumps to extract ASN mapping data from was accessing the archive using "latest" file names rather than date-based ones. 09:08 < sipa> Now, some of the collectors in the archive have been offline for a while. 09:08 < sipa> Which meant that those "latest" dumps were in some cases from 2004. 09:08 < sipa> Dropping those reduced the resulting compressed asmap file size by 300 kB. 09:09 < sipa> e.g. https://data.ris.ripe.net/rrc08/ 09:11 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 09:12 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 09:13 -!- ubba [uid552050@user/ubba] has joined #bitcoin-core-dev 09:15 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds] 09:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 09:32 -!- furszy [~furszy@user/furszy] has quit [] 09:39 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 09:41 < theStack> bip324 question about handshake: in older slides (from breaking bitcoin 2019) i saw it was proposed that only odd pubkeys (i.e. starting with 0x03) are allowed, but the current BIP states only even pubkeys (i.e. starting with 0x02) are. any specific reason for this change? 09:42 < sipa> which spec draft are you looking at? 09:42 < theStack> https://gist.github.com/dhruv/5b1275751bc98f3b64bcafce7876b489 (not sure if that's the right one) 09:42 < sipa> the latest spec we're working on used elligator squared pubkeys, which are 64 byte uniform 09:43 < sipa> but that may not be published yet 09:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has joined #bitcoin-core-dev 09:47 < theStack> sipa: thanks, good to know. that explains why there are PRs around implementing elligator squared pubkeys (both in secp256k1 and bitcoin core), but no mention of it in the (obviously outdated) spec i read 09:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Ping timeout: 240 seconds] 09:52 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has quit [Quit: Konversation terminated!] 09:55 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has joined #bitcoin-core-dev 09:55 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has quit [Client Quit] 09:56 -!- bitcoinboi [~Jason@098-147-176-043.res.spectrum.com] has joined #bitcoin-core-dev 09:56 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has joined #bitcoin-core-dev 10:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:08 < sipa> @theStack So elligator square is an encoding for public keys that encodes points as 64-byte, but *every* 64 byte sequence corresponds to a point, and the encoder picks a random one. So the result is that you get bytes that are indistinguishable from uniform. 10:09 < sipa> I have a writeup on the implementation/math here: https://github.com/sipa/writeups/tree/main/elligator-square-for-bn 10:15 < theStack> sipa: so if i understand this correctly, we want the p2p-v2 handshake messages to look like an uniform byte string in order to disguise the fact that a (ecdh) handshake is happening in the first place? 10:16 < sipa> exactly! 10:17 < theStack> wouldn't an observer still have a high chance of concluding this by the fact that the messages have exactly 64 bytes in size? 10:20 < sipa> well after that the rest of the protocol follows, which also sends bytes indistinguishable from uniform 10:21 < sipa> there may be some information that can be inferred from timing and tcp boundaries 10:21 < sipa> but tcp doesn't have a concept of messages per se 10:24 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:25 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 10:30 -!- donor [~donor@157.34.159.173] has joined #bitcoin-core-dev 10:32 < theStack> right. though i'd assume that in a packet analyzer (like tcpdump or wireshark) one would see the initial pubkeys as messages of 64 bytes (given that we an observation spot both routes from A->B and B->A pass through), no? 10:32 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 10:32 < theStack> (if not, then nevermind, i heave to read up on tcp/ip again :D) 10:35 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 10:39 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 10:42 < sipa> you'd see a 64 byte message in one direction, then a 64+N message in the other direction (because it'll be a concatenation of the ECDH response + the next part of the protocol that follows) 10:44 < bitcoin-git> [gui] hebasto opened pull request #612: refactor: Drop unused `QFrame`s in `SendCoinsEntry` (master...220530-sendcoins) https://github.com/bitcoin-core/gui/pull/612 10:47 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/fcf6c8f4eb21...c3936cc53dab 10:48 < bitcoin-git> bitcoin/23.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck 10:48 < bitcoin-git> bitcoin/23.x c3936cc laanwj: Merge bitcoin/bitcoin#25241: [23.x] rpc: Capture potentially large UniValu... 10:48 < bitcoin-git> [bitcoin] laanwj merged pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-馃搳) https://github.com/bitcoin/bitcoin/pull/25241 10:48 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/04fdd644b43a...34cb63e89597 10:48 < bitcoin-git> bitcoin/22.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck 10:48 < bitcoin-git> bitcoin/22.x 34cb63e laanwj: Merge bitcoin/bitcoin#25242: [22.x] rpc: Capture potentially large UniValu... 10:48 < bitcoin-git> [bitcoin] laanwj merged pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-馃搳) https://github.com/bitcoin/bitcoin/pull/25242 10:52 -!- Guest18 [~Guest18@105.112.185.248] has joined #bitcoin-core-dev 10:53 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 10:55 -!- Guest18 [~Guest18@105.112.185.248] has quit [Client Quit] 10:55 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 10:56 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 10:57 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev 10:58 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 11:01 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 11:12 < laanwj> sipa: oops, good find, yes it's good to have a smaller file and i doubt that including data from 2004 was at all helpful 11:13 -!- donor [~donor@157.34.159.173] has quit [Ping timeout: 258 seconds] 11:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 260 seconds] 11:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 11:28 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 11:30 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 11:32 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 11:35 -!- javi404 [~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net] has quit [Ping timeout: 248 seconds] 11:38 < theStack> sipa: i would have expected that the node initiating the handshake is also the one sending the next part of the protocol first (likely, a version message?), and one could see 64 byte messages in both directions 11:42 < sipa> @theStack That'd be gratuitously adding a (half) roundtrip. The responder can do the next step instead (indeed, a version message) first, avoiding the need for waiting for the message to be received. 11:43 < sipa> In any case, there is definitely still identifying information in the sizes and pattern of traffic sent. But it's not nearly as detectable as looking for certain magic bytes anymore. 11:51 < theStack> combining the handshake reponse with the version message seems like a good idea, wasn't aware that this is planned to be implemented that way (maybe it isn't yet, i will in any case keep that in the back of my head for reviewing concrete PRs) 11:54 < sipa> @theStack Oh, this isn't the *bitcoin* version message, but the version of the transport protocol I'm talking about. 11:54 < sipa> I don't know to what extent all these things are reflected in the spec and the implementation. The spec might not even have this versioning messge at all yet. 11:54 < theStack> and yes, agree that with elligator square identifying is harder. i was wondering if it's worth it to add random sized data to the initial handshake to make it even harder (but probably not) 11:55 < theStack> sipa: oh! i guess it definitely makes sense to wait for the new spec then :) 12:00 < sipa> @theStack It's not a crazy idea, but the problem is that it can't actually be random. There is no shared secret established yet, so whatever size of stuffing is chosen, if it is to be skippable by the other party, it will also have to be known to third parties. 12:01 < sipa> So we could decide to change it from 64 to say 256 bytes, and send part before and part after the first message by the other side. 12:02 < sipa> But that would mean a fixed 192 bytes wasted, and leads to questions like how much waste is acceptable etc 12:02 < instagibbs> does core currently have issues with computing bip125 inherited signaling? Lost track of this 12:04 < theStack> i see. at least the waste argument shouldn't matter though, considering we are talking about messages that are only sent once at the beginning of a connection? 12:04 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 12:05 < sipa> right... but if you pick e.g. 256 bytes, you've only introduced a variability of the first message size between 64 and 256; if you can observe many messages, and the first message is always within that range, you arguably still learn something 12:05 < sipa> so how much is enough? 256 bytes? 4 kilobytes? 1 megabyte? 12:06 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:06 < sipa> maybe it's worth having some bikeshedding over after publishing 12:07 < theStack> yeah, good question, how to pick the range 12:08 < _aj_> instagibbs: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-31876 ; i don't think it's fixed? 12:09 < theStack> also sending messages with a random size just feels like a strange thing to do (not sure if there are any wide-known protocols doing this) 12:09 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 12:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has joined #bitcoin-core-dev 12:09 < instagibbs> _aj_, https://github.com/bitcoin/bitcoin/issues/22028 dun dun dunn 12:09 -!- Guest78 [~Guest78@84-112-57-216.cable.dynamic.surfer.at] has joined #bitcoin-core-dev 12:10 < instagibbs> oh, purple made it seem like "merge", this is the only place I can find the issue 12:12 < _aj_> you want a /pull/ url for merge to be an option? :) 12:18 < bitcoin-git> [bitcoin] fanquake opened pull request #25251: Consolidate Windows ASLR workarounds for upstream secp256k1 changes (master...libsecp256k1_no_more_static_export) https://github.com/bitcoin/bitcoin/pull/25251 12:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 12:20 -!- Guest78 [~Guest78@84-112-57-216.cable.dynamic.surfer.at] has quit [Quit: Client closed] 12:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 12:34 < bitcoin-git> [gui] hebasto merged pull request #609: wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` (master...220529-expired) https://github.com/bitcoin-core/gui/pull/609 12:34 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/269fa667f248...b9ef5a10e2fa 12:34 < bitcoin-git> bitcoin/master 151009c Hennadii Stepanov: qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` 12:34 < bitcoin-git> bitcoin/master b9ef5a1 Hennadii Stepanov: Merge bitcoin-core/gui#609: wallet, refactor: Drop unused `WalletModel::Pa... 13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 244 seconds] 13:11 -!- Saloframes [~Saloframe@user/Saloframes] has quit [Quit: Leaving] 13:35 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 13:39 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit] 13:53 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:55 < bitcoin-git> [bitcoin] brunoerg opened pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253 13:58 -!- bitcoinboi [~Jason@098-147-176-043.res.spectrum.com] has quit [Quit: WeeChat 3.2] 14:00 -!- Saloframes [~Saloframe@user/Saloframes] has joined #bitcoin-core-dev 14:40 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving] 14:40 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 14:48 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 15:00 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: a谢谢懈谢压褨邪!] 15:11 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 15:15 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 15:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 272 seconds] 15:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:56 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 16:13 -!- javi404 [~quassel@2001:470:1f07:298:bbc3:e231:c6b5:16f9] has joined #bitcoin-core-dev 16:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61] has quit [Remote host closed the connection] 16:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 16:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Remote host closed the connection] 16:30 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has quit [Remote host closed the connection] 16:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 16:32 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has joined #bitcoin-core-dev 16:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 16:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 16:46 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 16:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 246 seconds] 17:03 -!- johnzweng [~johnzweng@zweng.at] has quit [Read error: Connection reset by peer] 17:06 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev 17:07 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 17:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 17:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 17:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 17:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 260 seconds] 17:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 17:46 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 18:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 255 seconds] 18:33 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 246 seconds] 18:41 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 18:49 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds] 19:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 19:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 19:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 19:24 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 19:27 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 19:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 20:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 20:50 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 20:50 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 20:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 258 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 21:27 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 21:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 21:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 21:50 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 244 seconds] 21:51 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 22:03 -!- ubba [uid552050@user/ubba] has quit [Quit: Connection closed for inactivity] 22:04 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 22:05 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 258 seconds] 22:05 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 22:16 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Remote host closed the connection] 22:16 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 22:17 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev 22:19 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Quit: upekkha] 22:20 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev 22:27 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 22:39 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 22:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 255 seconds] 22:50 -!- gnaf [~gnaf@51-15-187-53.rev.poneytelecom.eu] has joined #bitcoin-core-dev 22:59 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 23:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 23:20 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 23:23 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has quit [Quit: Konversation terminated!] 23:25 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 23:30 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:32 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 23:33 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 23:36 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 23:39 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 23:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 246 seconds] 23:43 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 23:51 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev --- Log closed Tue May 31 00:00:38 2022