--- Log opened Tue May 31 00:00:38 2022 00:00 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:00 -!- gnaf [~gnaf@51-15-187-53.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 00:26 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 00:35 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 258 seconds] 00:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9ef5a10e2fa...bd6c5e410829 00:39 < bitcoin-git> bitcoin/master a7973bf fanquake: Revert "build: more robustly check for fcf-protection support" 00:39 < bitcoin-git> bitcoin/master bd6c5e4 MacroFake: Merge bitcoin/bitcoin#25246: Revert "build: more robustly check for fcf-pr... 00:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25246: Revert "build: more robustly check for fcf-protection support" (master...remove_clang_7_note) https://github.com/bitcoin/bitcoin/pull/25246 00:39 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev 00:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/34cb63e89597...d2e0c27e45ab 00:42 < bitcoin-git> bitcoin/22.x 5203691 Pieter Wuille: Add pure Python RIPEMD-160 00:42 < bitcoin-git> bitcoin/22.x ea3e028 Pieter Wuille: Swap out hashlib.ripemd160 for own implementation 00:42 < bitcoin-git> bitcoin/22.x d2e0c27 MacroFake: Merge bitcoin/bitcoin#25250: [22.x] test: replace hashlib.ripemd160 with a... 00:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-馃懃) https://github.com/bitcoin/bitcoin/pull/25250 00:45 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds] 00:48 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 00:56 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:58 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 01:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 01:24 -!- aleggg [~aleggg@179.177.109.104.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 258 seconds] 01:25 -!- aleggg [~aleggg@177.204.241.81.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev 01:36 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:40 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 01:53 -!- Aaronvan_ [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 01:57 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 02:01 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 02:04 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 240 seconds] 02:06 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev 02:11 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 02:11 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 02:11 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 02:14 -!- Aaronvan_ is now known as AaronvanW 02:16 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 02:18 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Quit: bye] 02:19 -!- Guest38 [~Guest38@103.156.75.43] has joined #bitcoin-core-dev 02:19 -!- Guest38 [~Guest38@103.156.75.43] has quit [Client Quit] 02:20 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 02:23 -!- Guest38 [~Guest38@103.156.75.43] has joined #bitcoin-core-dev 02:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 255 seconds] 02:42 -!- Guest38 [~Guest38@103.156.75.43] has quit [Quit: Client closed] 02:52 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 02:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 02:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 252 seconds] 03:05 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 03:05 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 03:06 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 03:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd6c5e410829...5f65afff9c4c 03:08 < bitcoin-git> bitcoin/master ef6dbe6 Suhas Daftuar: Respond to getheaders if we have sufficient chainwork 03:08 < bitcoin-git> bitcoin/master a35f963 Suhas Daftuar: Add test for getheaders behavior 03:08 < bitcoin-git> bitcoin/master 5f65aff MacroFake: Merge bitcoin/bitcoin#24178: p2p: Respond to getheaders if we have suffici... 03:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24178: p2p: Respond to getheaders if we have sufficient chainwork (master...2022-01-headers-response-requires-minchainwork) https://github.com/bitcoin/bitcoin/pull/24178 03:10 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 03:14 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 03:15 -!- ubba [uid552050@user/ubba] has joined #bitcoin-core-dev 03:22 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 03:24 -!- aleggg [~aleggg@177.204.241.81.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 258 seconds] 03:25 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 255 seconds] 03:25 -!- aleggg [~aleggg@179.178.112.20] has joined #bitcoin-core-dev 03:32 -!- Guyver2__ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 03:35 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 03:35 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 272 seconds] 03:38 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds] 03:56 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds] 03:57 -!- kanka [~kanka@2409:4042:4e07:d1ba:f18c:6850:a88e:e79b] has joined #bitcoin-core-dev 04:01 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 04:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 04:08 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 04:08 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 04:11 -!- kanka [~kanka@2409:4042:4e07:d1ba:f18c:6850:a88e:e79b] has quit [Read error: Connection reset by peer] 04:15 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 04:20 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 04:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 04:34 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 04:45 -!- noonien [~noonien@user/noonien] has quit [Ping timeout: 240 seconds] 05:01 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 05:05 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 05:06 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 05:15 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev 05:22 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 246 seconds] 05:36 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 05:36 -!- Guest30 [~Guest30@94.240.194.181] has joined #bitcoin-core-dev 05:37 -!- Guest30 [~Guest30@94.240.194.181] has quit [Client Quit] 05:37 -!- noonien [~noonien@user/noonien] has quit [Quit: Ping timeout (120 seconds)] 05:37 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev 05:40 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 240 seconds] 05:53 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 05:55 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Ping timeout: 258 seconds] 05:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 258 seconds] 06:00 < sdaftuar> _aj_: I'm not sure I think of that bip125 issue as a bug in the code -- I think the code does what is intended, and the BIP should just be clarified 06:00 < sdaftuar> (er, does what was intended -- i think a wholesale improvement to that policy would be good too) 06:03 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 06:04 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 06:08 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 06:08 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25254: Move minRelayTxFee to policy/settings (master...2205-fee-setting-馃暪) https://github.com/bitcoin/bitcoin/pull/25254 06:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 06:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5f65afff9c4c...1f932de67392 06:12 < bitcoin-git> bitcoin/master ebfc308 brunoerg: test: add coverage for non-hex value to -minimumchainwork 06:12 < bitcoin-git> bitcoin/master 1f932de MacroFake: Merge bitcoin/bitcoin#25253: test: add coverage for non-hex value to -mini... 06:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253 06:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f932de67392...d4d9daff7ab6 06:22 < bitcoin-git> bitcoin/master bf209ac Ben Woosley: doc: Fix spelling errors identified by codespell in coments 06:22 < bitcoin-git> bitcoin/master f565b28 Ben Woosley: Fixup option name in bench message 06:22 < bitcoin-git> bitcoin/master d4d9daf MacroFake: Merge bitcoin/bitcoin#25200: doc: Fix spelling errors identified by codesp... 06:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25200: doc: Fix spelling errors identified by codespell in comments (master...2022-05-codespell) https://github.com/bitcoin/bitcoin/pull/25200 06:36 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 06:38 -!- Guyver2_ [~Guyver@2a02-a45c-ba8d-1-cd9c-985e-2687-7976.fixed6.kpn.net] has joined #bitcoin-core-dev 06:40 -!- Guyver2__ [Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 255 seconds] 06:41 -!- Guyver2__ [~Guyver@2a02-a45c-ba8d-1-cd9c-985e-2687-7976.fixed6.kpn.net] has joined #bitcoin-core-dev 06:42 -!- Guyver2_ [~Guyver@2a02-a45c-ba8d-1-cd9c-985e-2687-7976.fixed6.kpn.net] has quit [Ping timeout: 244 seconds] 07:03 < bitcoin-git> [bitcoin] hebasto opened pull request #25255: ci: Improve "ARM64 Android APK" task (master...220531-android) https://github.com/bitcoin/bitcoin/pull/25255 07:11 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 07:21 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Ping timeout: 255 seconds] 07:31 < theStack> uname -a 07:31 < theStack> (oops, sorry, wrong windows) 07:31 < sipa> Linux epab 5.15.0-30-lowlatency #31-Ubuntu SMP PREEMPT Thu May 5 12:24:00 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux 07:31 <@gribble> https://github.com/bitcoin/bitcoin/issues/31 | -keypool option not advertised when using --help switch 路 Issue #31 路 bitcoin/bitcoin 路 GitHub 07:32 < theStack> :D 07:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 07:34 < fanquake> want to triple check your not running on aarch64 07:35 < sipa> triple checking my target triplet? 07:43 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 07:43 -!- kexkey [~kexkey@178.249.214.25] has joined #bitcoin-core-dev 07:46 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 255 seconds] 08:04 -!- Guyver2__ [~Guyver@2a02-a45c-ba8d-1-cd9c-985e-2687-7976.fixed6.kpn.net] has left #bitcoin-core-dev [] 08:08 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 08:11 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 255 seconds] 08:16 -!- furszy [~furszy@user/furszy] has quit [] 08:21 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev 08:39 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 08:46 -!- nanotube [~nanotube@user/nanotube] has quit [Quit: *poof*] 08:47 < bitcoin-git> [bitcoin] klementtan opened pull request #25256: logging: Add leveldb thread name and fix logging empty thread name (master...add_leveldb_threadname) https://github.com/bitcoin/bitcoin/pull/25256 08:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 08:56 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 08:57 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev 08:57 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has joined #bitcoin-core-dev 09:44 < _aj_> sdaftuar: sure; looks more to me like the spec stopped making sense when the implementation got serious, but same difference 09:44 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has quit [Quit: Konversation terminated!] 09:46 -!- ronoaldo [~ronoaldo@200-171-83-164.dsl.telesp.net.br] has joined #bitcoin-core-dev 10:04 < sdaftuar> the BIP was written after the code was, to try to explain to wallet developers how to think about it; i think that detail around "yes of course descendants of rbf-signalling transactions should be thought of as replaceable, but you need to conflict with the rbf-signalling parent to do so" was just difficult to put into words. 10:05 < instagibbs> hmm. 10:05 < _aj_> sdaftuar: well that's lame! 10:06 < _aj_> sdaftuar: (spec not matching already written code, i mean) 10:07 < _aj_> sdaftuar: are there fundamental problems with doing it the way described in the bip, or just "that's not what we were trying to do but it might work" or "it's slightly slower, uses slightly more memroy, slightly annoying to implement, etc" ? 10:08 < instagibbs> yeah the spec is clearly stating the other way 10:08 < instagibbs> imo 10:09 < sdaftuar> to be clear, when you say the way defined in the BIP, you mean: look at all in-mempool ancestors of a transaction and see if any are signaling for RBF, and if so, allow rbf of the transaction which is being conflicted? 10:09 < _aj_> yes 10:10 < sdaftuar> that seems like a bad thing to code up, imo. you might have to look at a lot of stuff, as a new transaction can conflict with up to 100 transactions as BIP 125 is written now, and each might have 24 parents 10:10 < sdaftuar> i'd rather we just move to full rbf and call it a day 10:10 < instagibbs> ACK! 10:11 < _aj_> yeah, you'd need to cache the"any-ancestor-signals-rbf" and update that cache when ancestors get confirmed 10:11 < _aj_> sounds like the "might work, might not" case to me 10:11 < sdaftuar> sure, and not really worth the effort imo 10:11 < _aj_> yeah 10:12 < sipa> is the implemented/intended behavior "a transaction with RBF signalling can be replaced, even if it has non-RBF-signalling descendants"? 10:12 < sdaftuar> isn't there also a discrepancy in the bip and iplementation around how signalling is defined? i can't remember for sure off the top of my head, but i believe we only look at the first input of a transaction to see if it's signalling, rather than all inputs 10:12 < sdaftuar> sipa: yes 10:13 < sipa> thanks, now i finally understand what the discussion is actually about :) 10:14 < sdaftuar> oh, maybe im wrong about that 10:14 < sdaftuar> (the signaling issue) 10:17 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 10:17 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:18 < sipa> if we'd want to change the RBF policy anyway, concept ACK full RBF... 10:24 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 10:26 < _aj_> hmm, last time i thought about full rbf, i think bitgo was actively using non-signalling of rbf as an essential input to the 'accept-zeroconf' logic 10:27 < _aj_> bah, bitrefill 10:27 < instagibbs> lots of services do 10:27 < instagibbs> but like... 10:32 < _aj_> i can't seem to find the twitter thread i'm thinking of 10:35 < _aj_> https://twitter.com/BitcoinErrorLog/status/1435888759510294529 10:39 -!- furszy [~furszy@user/furszy] has quit [Remote host closed the connection] 10:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 10:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:45 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 10:45 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 10:52 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:55 -!- Guest60 [~Guest60@lnsm3-montreal02-142-118-81-195.internet.virginmobile.ca] has joined #bitcoin-core-dev 10:59 -!- Guest60 [~Guest60@lnsm3-montreal02-142-118-81-195.internet.virginmobile.ca] has quit [Client Quit] 11:13 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-馃尫) https://github.com/bitcoin/bitcoin/pull/25257 11:32 -!- pkwsj [~pkwsj@66.44.113.38] has joined #bitcoin-core-dev 11:53 -!- ubba [uid552050@user/ubba] has quit [Quit: Connection closed for inactivity] 12:02 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 12:05 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 250 seconds] 12:06 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 12:09 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 12:10 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:13 -!- metallicc99 [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has joined #bitcoin-core-dev 12:13 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has joined #bitcoin-core-dev 12:14 -!- bytes1440000 [~bytes1440@garza.riseup.net] has joined #bitcoin-core-dev 12:14 -!- metallicc99 [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has quit [Remote host closed the connection] 12:14 -!- metallicc [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 12:14 -!- metallicc99 [~metallicc@c-73-217-34-231.hsd1.co.comcast.net] has joined #bitcoin-core-dev 12:14 < bytes1440000> I think knots has the option to use full rbf, opt in or no rbf. Also has options to disallow address reuse in mempool, set minimum fee rate for replacement tx and other things. 12:29 < bytes1440000> hebasto: I tried those commands and still getting same error: https://pastebin.com/raw/5Pd0YmJc 12:30 < bytes1440000> are you sure 'make clean' was required? 12:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net] has quit [Remote host closed the connection] 12:31 -!- gwillen1 is now known as gwillen 12:31 < hebasto> bytes1440000: error is not the same :) It seems you have no android cross-compile toolchain installed 12:31 < bytes1440000> hmmm 12:32 < bytes1440000> let me install that and try again 12:33 < bitcoin-git> [bitcoin] ryanofsky reopened pull request #22764: build: Include qt sources for parsing with extract_strings.py (master...210821-translation) https://github.com/bitcoin/bitcoin/pull/22764 12:33 < hebasto> bytes1440000: `/home/hebasto/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android28-clang` points to `/home/hebasto` :) 12:34 < hebasto> I think you have different toolchain location 12:35 < hebasto> just sanity check all variables provided to `make -C depends` 12:36 < bytes1440000> yeah I just copied same command and forgot to change the variables 12:37 < hebasto> also double check NDK version in paths 12:41 -!- pkwsj [~pkwsj@66.44.113.38] has quit [Ping timeout: 252 seconds] 13:07 -!- pkwsj [~pkwsj@66.44.113.38] has joined #bitcoin-core-dev 13:13 < bytes1440000> I tried this and manually checked all paths are correct: make -C depends HOST=aarch64-linux-android ANDROID_SDK=/home/test/Android/Sdk ANDROID_NDK=/home/test/Android/Sdk/ndk/24.0.8215888/ ANDROID_API_LEVEL=28 ANDROID_TOOLCHAIN_BIN=/home/test/Android/Sdk/ndk/24.0.8215888/toolchains/llvm/prebuilt/linux-x86_64/bin 13:13 < bytes1440000> Error: https://pastebin.com/raw/BvtHxQgd 13:17 < hebasto> bytes1440000: suggesting to switch to NDK 23; and submit an issue about bug with NDK 24 (but not sure if enough devs would care about support for non-LTS version of NDK) 13:21 < hebasto> fwiw, Qt 5.15 officially supports only NDK r21 :) -- https://doc.qt.io/qt-5/android-getting-started.html 13:21 < hebasto> but our code base tested with NDK r23 LTS 13:22 < hebasto> since #23677 13:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/23677 | build, qt: Use Android NDK r23 LTS by hebasto 路 Pull Request #23677 路 bitcoin/bitcoin 路 GitHub 13:31 < bytes1440000> hebasto: removing NDK 24 and installing NDK 23 in Android Studio: https://i.imgur.com/PuiKZoE.png 13:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:eced:5481:584a:7bf7] has joined #bitcoin-core-dev 13:39 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:eced:5481:584a:7bf7] has quit [Ping timeout: 272 seconds] 13:42 < bitcoin-git> [gui] hebasto closed pull request #199: Added updated bitcoin PNG / SVG icon (master...bitcoin_icon) https://github.com/bitcoin-core/gui/pull/199 13:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Remote host closed the connection] 13:43 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has joined #bitcoin-core-dev 13:48 -!- kexkey [~kexkey@178.249.214.25] has quit [Ping timeout: 276 seconds] 13:52 -!- furszy [~furszy@user/furszy] has quit [] 13:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 14:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 255 seconds] 14:08 -!- Guest4 [~Guest4@2a0d:6fc2:6010:3800:4cc8:aa2b:1f1a:ba74] has joined #bitcoin-core-dev 14:12 < bitcoin-git> [bitcoin] theStack opened pull request #25259: test: check pre-segwit peer error in `getblockfrompeer` RPC (master...202205-test-rpc-getblockfrompeer_check_presegwit_peer_error) https://github.com/bitcoin/bitcoin/pull/25259 14:14 -!- pkwsj [~pkwsj@66.44.113.38] has quit [Ping timeout: 252 seconds] 14:20 -!- div72_ [~div72@user/div72] has joined #bitcoin-core-dev 14:20 -!- div72 [~div72@user/div72] has quit [Ping timeout: 258 seconds] 14:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 14:40 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 14:46 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving] 14:47 < dongcarl> Seems somewhat unrelated to my change so asking: is this a known error? https://cirrus-ci.com/task/6153082282180608 14:49 < _aj_> dongcarl: yeah, seen that a few times. think there was a patch to tweak it not all that long ago too 14:50 < dongcarl> Okay, I might restart the CI run then, thanks _aj_ 14:50 < bytes1440000> hebasto: I am still getting error. Thanks for your help but I give up. Working on something else now so will try this later. I think this doc can be improved though: https://github.com/bitcoin/bitcoin/blob/master/doc/build-android.md 14:50 < bytes1440000> I have added some things in this gist that I could remember: https://gist.github.com/1440000bytes/a2335c64e5a82e40c55864a881f304e5 14:53 -!- bytes1440000 [~bytes1440@garza.riseup.net] has left #bitcoin-core-dev [] 15:14 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net] has quit [Remote host closed the connection] 15:15 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 15:16 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:eced:5481:584a:7bf7] has joined #bitcoin-core-dev 15:20 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:eced:5481:584a:7bf7] has quit [Ping timeout: 240 seconds] 15:28 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 15:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds] 15:34 < jonatack> dongcarl: yes, i think it has been ongoing for quite some time now https://github.com/bitcoin/bitcoin/issues/23165 15:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 15:41 < ariard> re-full-rbf: i had services complaining still relying on zero-conf when full-rbf as a policy was proposed last year... 15:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:eced:5481:584a:7bf7] has joined #bitcoin-core-dev 15:54 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@2600:8802:3806:c200:eced:5481:584a:7bf7] has quit [Remote host closed the connection] 15:55 -!- Guest4 [~Guest4@2a0d:6fc2:6010:3800:4cc8:aa2b:1f1a:ba74] has quit [Quit: Client closed] 16:04 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 16:07 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 16:07 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: a谢谢懈谢压褨邪!] 16:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 16:49 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 16:59 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 17:06 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 17:09 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 17:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 250 seconds] 17:12 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:15 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 17:22 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 17:31 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 17:41 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 17:47 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Ping timeout: 258 seconds] 18:13 -!- bytes1440000 [~bytes1440@garza.riseup.net] has joined #bitcoin-core-dev 18:16 < bytes1440000> ariard: if those services have bug bounty program, we could report vulnerability in which someone can exploit the services with double spend 18:17 -!- bytes1440000 [~bytes1440@garza.riseup.net] has left #bitcoin-core-dev [] 18:17 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 18:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:35 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:37 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: a谢谢懈谢压褨邪!] 18:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 18:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 19:05 -!- kexkey [~kexkey@178.249.214.25] has joined #bitcoin-core-dev 19:17 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 19:22 -!- div72_ is now known as div72 19:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 19:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 258 seconds] 20:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 20:23 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 20:27 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds] 20:39 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 20:39 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has joined #bitcoin-core-dev 21:00 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 21:00 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye] 21:00 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:04 -!- realies5 [~realies@user/realies] has joined #bitcoin-core-dev 21:04 -!- realies [~realies@user/realies] has quit [Read error: Connection reset by peer] 21:04 -!- realies5 is now known as realies 21:05 -!- realies [~realies@user/realies] has quit [Client Quit] 21:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 21:21 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 21:23 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 21:24 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 21:35 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 21:36 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 21:36 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 244 seconds] 21:37 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 21:37 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has joined #bitcoin-core-dev 21:37 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 21:42 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 21:58 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 22:21 -!- hashfunc17bc [~user@2601:5c0:c280:7090:8c1d:2984:8c2:18db] has joined #bitcoin-core-dev 22:33 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@172.58.19.191] has joined #bitcoin-core-dev 22:38 -!- hashfunc17bc [~user@2601:5c0:c280:7090:8c1d:2984:8c2:18db] has quit [Remote host closed the connection] 22:42 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@172.58.19.191] has quit [Remote host closed the connection] 22:58 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 22:59 -!- Guest6 [~Guest6@2a00:a040:194:6396:3101:9835:34fc:119c] has joined #bitcoin-core-dev 23:13 -!- Guest6 [~Guest6@2a00:a040:194:6396:3101:9835:34fc:119c] has quit [Quit: Client closed] 23:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d4d9daff7ab6...beb18d3fbc0d 23:14 < bitcoin-git> bitcoin/master 7d0f67a Sebastian Falbesoner: test: check pre-segwit peer error in `getblockfrompeer` RPC 23:14 < bitcoin-git> bitcoin/master beb18d3 MacroFake: Merge bitcoin/bitcoin#25259: test: check pre-segwit peer error in `getbloc... 23:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25259: test: check pre-segwit peer error in `getblockfrompeer` RPC (master...202205-test-rpc-getblockfrompeer_check_presegwit_peer_error) https://github.com/bitcoin/bitcoin/pull/25259 23:16 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 23:22 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@172.58.19.23] has joined #bitcoin-core-dev 23:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 23:30 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@172.58.19.23] has quit [Remote host closed the connection] 23:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has quit [Ping timeout: 260 seconds] 23:39 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/beb18d3fbc0d...e157b98640c7 23:39 < bitcoin-git> bitcoin/master fa2d226 MacroFake: doc: Explain squashing with merge commits 23:39 < bitcoin-git> bitcoin/master e157b98 laanwj: Merge bitcoin/bitcoin#25165: doc: Explain squashing with merge commits 23:39 < bitcoin-git> [bitcoin] laanwj merged pull request #25165: doc: Explain squashing with merge commits (master...2205-doc-squash-馃惥) https://github.com/bitcoin/bitcoin/pull/25165 23:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470] has joined #bitcoin-core-dev 23:54 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 23:55 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-馃尫) https://github.com/bitcoin/bitcoin/pull/25257 23:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds] --- Log closed Wed Jun 01 00:00:39 2022