--- Log opened Thu Jun 02 00:00:40 2022 00:12 -!- chinggg [~chinggg@49.52.96.106] has joined #bitcoin-core-dev 00:22 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 00:24 -!- chinggg [~chinggg@49.52.96.106] has quit [Ping timeout: 252 seconds] 00:24 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 00:25 -!- hashfunc1bb [~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05] has quit [Remote host closed the connection] 00:36 -!- chinggg [~chinggg@101.94.169.49] has joined #bitcoin-core-dev 00:39 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 00:44 -!- chinggg [~chinggg@101.94.169.49] has quit [Ping timeout: 252 seconds] 00:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 00:51 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:59 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:59 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 01:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 01:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 01:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 255 seconds] 01:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 01:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 260 seconds] 01:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 01:18 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 01:25 -!- chinggg [~chinggg@59.79.1.99] has joined #bitcoin-core-dev 01:33 -!- chinggg [~chinggg@59.79.1.99] has quit [Quit: Client closed] 01:37 -!- sheb [~sheb@31.223.228.71] has quit [Quit: Leaving] 01:43 < luke-jr> davidbakin: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#taproot-key-path-spending-signature-validation 02:03 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 246 seconds] 02:06 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 02:13 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 02:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:17 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 02:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 250 seconds] 02:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 02:57 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 02:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 03:29 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 03:33 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 255 seconds] 03:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 260 seconds] 03:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 03:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 255 seconds] 03:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 03:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Remote host closed the connection] 03:44 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 03:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 03:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 244 seconds] 03:56 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 03:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 04:00 -!- sturles [~sturles@sauron.uio.no] has quit [Remote host closed the connection] 04:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 04:04 -!- sturles [~sturles@sauron.uio.no] has joined #bitcoin-core-dev 04:05 < bitcoin-git> [bitcoin] theStack opened pull request #25267: test: check `replaceable` mismatch error in `createrawtransaction` RPC (master...202206-test-check_rbf_mismatch_in_createrawtransaction) https://github.com/bitcoin/bitcoin/pull/25267 04:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1c7ef0abd11f...39ddd522c37f 04:08 < bitcoin-git> bitcoin/master fa72e0b MarcoFalke: Use designated initializers 04:08 < bitcoin-git> bitcoin/master 39ddd52 MacroFake: Merge bitcoin/bitcoin#24531: Use designated initializers 04:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24531: Use designated initializers (master...2203-designated_init-🛍) https://github.com/bitcoin/bitcoin/pull/24531 05:04 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 05:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 258 seconds] 05:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 05:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has joined #bitcoin-core-dev 05:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 05:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 05:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b] has quit [Ping timeout: 260 seconds] 05:14 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 05:19 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 05:25 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 05:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 05:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:34 < bitcoin-git> [bitcoin] dergoegge opened pull request #25268: refactor: Introduce EvictionManager (master...2022-05-eviction-manager) https://github.com/bitcoin/bitcoin/pull/25268 06:06 -!- furszy_ [~furszy@186.141.201.103] has joined #bitcoin-core-dev 06:06 -!- furszy_ [~furszy@186.141.201.103] has quit [Client Quit] 06:08 -!- furszy [~furszy@user/furszy] has quit [Ping timeout: 240 seconds] 06:08 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 06:32 < reardencode> davidbakin: 2: The extension is to the `Common Signature Message` which is hashed with hash_TapSighash. 3: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#cite_ref-10-0 06:49 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Ping timeout: 240 seconds] 06:50 < sipa> @davidbakin The annex is completely different from the tapscript extension. Annex is defined in BIP341, and is a way to add extra fields to txins generically. The tapscript extension is what is added to the common sighash computation from BIP341 in BIP342 with the tapscript-specific fields. 06:51 < sipa> @davidbakin Yes, that low bit is used to communicate the sign of the tweaking equation (Q = P+H(...)G or Q = -(P+H(...)G). 06:55 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 07:02 -!- erik-etsuji-kato [~erik@gateway/tor-sasl/erik-etsuji-kato] has joined #bitcoin-core-dev 07:03 < jamesob> Can someone help me understand why this CI job is failing when all others are passing? The compiler error given seems to correspond to old (or otherwise changed) code: https://github.com/bitcoin/bitcoin/pull/24232/checks?check_run_id=6561221006 07:05 < jamesob> Oh, may be silent merge conflict... Is the prev-release CI job the only one that rebases branch on top of current master? 07:08 < laanwj> afaik all the CI jobs rebase on top of current master 07:08 < sipa> merge, not rebase, i assume 07:09 < laanwj> merge, yes 07:14 < jamesob> Well a rebase revealed the source of the error - but I find it odd that other jobs didn't fail similarly 07:17 < bitcoin-git> [bitcoin] furszy opened pull request #25269: wallet: re-activate the not triggered "AmountWithFeeExceedsBalance" (master...2022_wallet_fix_missing_AmountWithFeeExceedsBalance) https://github.com/bitcoin/bitcoin/pull/25269 07:18 < lightlike> jamesob: the other jobs ran 10 days ago, probably before the conflicting PR was merged. The failed one was apparently restarted only 2 days ago. 07:18 < jamesob> lightlike: ah, good point 07:26 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 07:27 < sipa> davidbakin: (1) luke-jr gave the link to the spec for key path spending in BIP341. For tapscript script path spending it's in BIP342, https://github.com/bitcoin/bips/blob/master/bip-0342.mediawiki#signature-validation 07:30 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 07:34 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds] 07:34 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 07:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds] 07:44 -!- belcher [~belcher@user/belcher] has quit [Quit: Leaving] 07:54 -!- bairen [~bairen@gateway/tor-sasl/bairen] has quit [Ping timeout: 240 seconds] 07:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 07:58 -!- furszy [~furszy@user/furszy] has quit [Quit: Ping timeout (120 seconds)] 07:58 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 07:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 240 seconds] 08:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 08:09 -!- furszy [~furszy@user/furszy] has quit [Quit: Client closed] 08:09 -!- Guest8765 [~Guest87@2603-7000-a701-2362-2f8e-764f-cfc5-4867.res6.spectrum.com] has joined #bitcoin-core-dev 08:14 -!- Guest8765 [~Guest87@2603-7000-a701-2362-2f8e-764f-cfc5-4867.res6.spectrum.com] has quit [Client Quit] 08:21 -!- klement [~textual@218.212.82.174] has joined #bitcoin-core-dev 08:31 < davidbakin> ok, so the extension is just something that's appended to the SigMsg before it is hashed - it doesn't actually exist as a field in a serialized transaction; but w.r.t. the 64vs65 byte signature - I have seen how you treat them differently in BIP-341 "taproot key path spending sig validation" but I don't see where there or in BIP-340 an explanation of what that 65th byte is when it 08:31 < davidbakin> exists - BIP-340 is totally about 64 byte signatures and doesn't know from hash types, so the only thing that I see describes it is the implication from that note 21 08:32 < sipa> BIP340 describes a digital signature scheme, it has no notion of sighash types or even anything related to Bitcoin at all. 08:32 < davidbakin> oh wait! I see it in the CODE of taproot_sign_key in BIP-341! Not in descriptive text! 08:33 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:33 < sipa> The rules for verifying signatures in the context of taproot key path spends are specified in BIP341. The rules for verifying signatures in the context of tapscript script path spends are in BIP342. 08:33 < sipa> davidbakin: It's literally here: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#taproot-key-path-spending-signature-validation 08:34 < sipa> To validate a signature sig with public key q: 08:34 < sipa> If the sig is 64 bytes long, return Verify(q, hashTapSighash(0x00 || SigMsg(0x00, 0)), sig)[20], where Verify is defined in BIP340. 08:34 < sipa> If the sig is 65 bytes long, return sig[64] ≠ 0x00[21] and Verify(q, hashTapSighash(0x00 || SigMsg(sig[64], 0)), sig[0:64]). 08:34 < sipa> Otherwise, fail[22]. 08:35 < sipa> BIP342 has very similar text: 08:35 < sipa> To validate a signature sig with public key p: 08:35 < sipa> Compute the tapscript message extension ext described above. 08:35 < sipa> If the sig is 64 bytes long, return Verify(p, hashTapSighash(0x00 || SigMsg(0x00, 1) || ext), sig), where Verify is defined in BIP340. 08:35 < sipa> If the sig is 65 bytes long, return sig[64] ≠ 0x00 and Verify(p, hashTapSighash(0x00 || SigMsg(sig[64], 1) || ext), sig[0:64]). 08:35 < sipa> Otherwise, fail. 08:35 < sipa> (under https://github.com/bitcoin/bips/blob/master/bip-0342.mediawiki#signature-validation) 08:36 < davidbakin> yes sipa I get that! tells you what to DO with a 65 byte one - doesn't tell you the circumstance when you CREATE one OR that the 65'th byte is the hash type (if non zero). I hope I'm not being really stupid. 08:37 < davidbakin> but I _did_ find it in the CODE of taproot_sign_key not in the descriptive text 08:37 < sipa> Oh, the BIPs don't really describe the creation. They're specifying the validation rules, not construction. 08:37 < sipa> There is some context that explains common usage, but that's not really the full description of everything one could do with these BIPs... that'd be unbounded. 08:39 < sipa> But fair enough, how to sign with specified sighash type might be worth including. 08:39 < davidbakin> i do get that but I nevertheless submit that somewhere there could be a little sentence that said in English "signatures are 65 bytes - the 64 bytes from BIP-340 plus the hash-type, unless the hash type is 0 in which case it is elided" - but that's ok it is in the code 08:40 < sipa> Agreed. 08:41 < davidbakin> however, something NOT in the code, or, AFAICT, in the text, is that the low order bit of the leaf version byte is the parity bit. Becuase in the code taproot_tweak_pubkey returns it as a multi-valued return (it's the first element of a pair) but in taproot_output_script where that function is _used_ (only place I can see it used) that first element of the pair is thrown away 08:42 < sipa> If q ≠ x(Q) or c[0] & 1 ≠ y(Q) mod 2, fail[10]. 08:42 < sipa> That's where it is used in the specification text. 08:43 < sipa> "c[0] & 1" is the parity bit. 08:44 < sipa> In the text about construction below it says. 08:44 < sipa> To spend this output using script D, the control block would contain the following data in this order: 08:44 < sipa> 08:45 < davidbakin> well yes I see that but it's the same issue with obscurity - you've got to really know what's going on before you know what's going on ... for example, right after the line "let v = c[0]&0xfe" and call it the _leaf version_" there could be a line "let pubpar = c[0]&0x1 and call it the _public key parity" - that would sort of help 08:45 < sipa> In any case, if you feel there is text that would have made this more clear to you, feel free to open a PR against the BIP. 08:46 < davidbakin> ah! didn't know you could do that with PRs that were already accepted - OH WAIT these Taproot PRs are still Draft. ok, i'll do that and see what the reviewers say (such as you I suppose, eh?) 08:46 < sipa> They probably should be moved off being Draft at this point. 08:46 -!- klement [~textual@218.212.82.174] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:46 < sipa> But even then, clarifications may be accepted if they don't change the specification. 08:47 < sipa> BIP changes are approved by the authors of the BIP (and the editor who decides if procedure is followed). 08:50 < davidbakin> eeh, I jumped right over that - ok, i'm clear now (at least on this stuff) thank you all! 08:50 < davidbakin> (i will do a PR though) 08:50 < sipa> Cool, thanks! 08:51 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 08:52 -!- klement [~textual@218.212.82.174] has joined #bitcoin-core-dev 08:55 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 08:58 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 244 seconds] 09:02 < sipa> davidbakin: The parity bit is mentioned in the signing code section too, actually: 09:02 < sipa> in taproot_sign_script 09:02 < sipa> output_pubkey_y_parity, _ = taproot_tweak_pubkey(internal_pubkey, h) 09:02 < sipa> pubkey_data = bytes([output_pubkey_y_parity + leaf_version]) + internal_pubkey 09:03 < sipa> it's not in taproot_output_script, because the signing bit isn't used at output creation time, only at signing time 09:03 < davidbakin> oh that's correct, ok, NVM about that then - it's all in the code - thanks for helping me read correctly! 09:08 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Connection closed] 09:14 -!- furszy [~furszy@user/furszy] has quit [Quit: Ping timeout (120 seconds)] 09:14 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 09:18 < bitcoin-git> [gui] laanwj opened pull request #613: qt: Remove unnecessary wallet includes from rpcconsole.cpp (master...2022-06-qtconsole-includes) https://github.com/bitcoin-core/gui/pull/613 09:26 -!- furszy [~furszy@user/furszy] has quit [Quit: Ping timeout (120 seconds)] 09:26 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 09:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 09:50 -!- furszy [~furszy@user/furszy] has quit [] 09:52 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:54 -!- realies [~realies@user/realies] has quit [Quit: ~] 10:05 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/39ddd522c37f...636991d0c0f9 10:05 < bitcoin-git> bitcoin/master a4741bd Cory Fields: kernel: pass params to BlockManager rather than using a global 10:05 < bitcoin-git> bitcoin/master 636991d laanwj: Merge bitcoin/bitcoin#25264: kernel: pass params to BlockManager rather th... 10:05 < bitcoin-git> [bitcoin] laanwj merged pull request #25264: kernel: pass params to BlockManager rather than using a global (master...no-kernel-global-params) https://github.com/bitcoin/bitcoin/pull/25264 10:09 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/636991d0c0f9...a100c42a136d 10:09 < bitcoin-git> bitcoin/master d7d9c7b glozow: [test util] add chain name to TestChain100Setup ctor 10:09 < bitcoin-git> bitcoin/master 5374dfc glozow: [test util] use -checkmempool for TestingSetup mempool check ratio 10:09 < bitcoin-git> bitcoin/master 2118750 glozow: [test util] to populate mempool with random transactions/packages 10:09 < bitcoin-git> [bitcoin] laanwj merged pull request #24927: Add test util to populate mempool with random transactions, fix #24634 bug (master...2022-04-test-util-populate-mempool) https://github.com/bitcoin/bitcoin/pull/24927 10:10 -!- z9z0b3t1c [~z9z0b3t1c@145.224.65.12] has joined #bitcoin-core-dev 10:10 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 10:11 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 10:12 -!- klement [~textual@218.212.82.174] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:12 -!- z9z0b3t1c [~z9z0b3t1c@145.224.65.12] has quit [Client Quit] 10:12 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 10:20 < bitcoin-git> [gui] hebasto merged pull request #613: Remove unnecessary wallet includes from rpcconsole.cpp (master...2022-06-qtconsole-includes) https://github.com/bitcoin-core/gui/pull/613 10:20 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a100c42a136d...da6792b2eb6a 10:20 < bitcoin-git> bitcoin/master 0994273 laanwj: qt: Remove unnecessary wallet includes from rpcconsole.cpp 10:20 < bitcoin-git> bitcoin/master da6792b Hennadii Stepanov: Merge bitcoin-core/gui#613: Remove unnecessary wallet includes from rpccon... 10:22 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 10:33 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 10:36 -!- realies [~realies@user/realies] has quit [Quit: ~] 10:37 < bitcoin-git> [gui] hebasto merged pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583 10:37 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da6792b2eb6a...b11ab25afb44 10:37 < bitcoin-git> bitcoin/master 8cfb562 w0xlt: qt, refactor: add translator comments in `TransactionDesc::FormatTxStatus(... 10:37 < bitcoin-git> bitcoin/master b11ab25 Hennadii Stepanov: Merge bitcoin-core/gui#583: Add translator comments to `TransactionDesc::F... 10:45 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 10:50 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:51 -!- z9z0b3t1_ [~z9z0b3t1c@145.224.65.12] has joined #bitcoin-core-dev 10:54 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 11:00 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev 11:08 -!- z9z0b3t1_ [~z9z0b3t1c@145.224.65.12] has quit [Remote host closed the connection] 11:09 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 11:18 -!- Guest36 [~Guest36@92.44.103.246] has joined #bitcoin-core-dev 11:22 -!- Guest36 [~Guest36@92.44.103.246] has quit [Client Quit] 11:29 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 11:43 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b11ab25afb44...1f63b460a850 11:43 < bitcoin-git> bitcoin/master 1bace0c Sebastian Falbesoner: test: check `replaceable` mismatch error in `createrawtransaction` RPC 11:43 < bitcoin-git> bitcoin/master 1f63b46 laanwj: Merge bitcoin/bitcoin#25267: test: check `replaceable` mismatch error in `... 11:43 < bitcoin-git> [bitcoin] laanwj merged pull request #25267: test: check `replaceable` mismatch error in `createrawtransaction` RPC (master...202206-test-check_rbf_mismatch_in_createrawtransaction) https://github.com/bitcoin/bitcoin/pull/25267 11:51 < sdaftuar> hi maintainers, #24171 may be ready for merge? (or if it needs re-acks since it was last rebased, i can ping the previous reviewers) 11:51 <@gribble> https://github.com/bitcoin/bitcoin/issues/24171 | p2p: Sync chain more readily from inbound peers during IBD by sdaftuar · Pull Request #24171 · bitcoin/bitcoin · GitHub 11:55 < _aj_> sdaftuar: front running the meeting, eh? 11:56 < sdaftuar> oh i forgot about the meeting! also going afk in a few minutes 11:58 < laanwj> sdaftuar: thanks, will take a look 12:00 < laanwj> #startmeeting 12:00 < jonatack> hi 12:00 < hebasto> hi 12:01 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo 12:01 < laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 12:01 -!- mrlemke [~mrlemke@208.74.105.200] has quit [Quit: Leaving] 12:01 < luke-jr> hi 12:01 < dongcarl> hi 12:01 < lightlike> hi 12:01 < laanwj> welcome to the weekly general bitcoin-core-dev meeting 12:02 < laanwj> there have been no topics proposed in advance (you can propose meeting topics with #proposedmeetingtopic during any time of the week) 12:02 < laanwj> any last minute topics? 12:02 < sipa> hi 12:02 < _aj_> hi 12:03 < sipa> #25096 may be close to ready too 12:03 < Murch> Hi 12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/25096 | [net] Minor improvements to addr caching by dergoegge · Pull Request #25096 · bitcoin/bitcoin · GitHub 12:04 < laanwj> sipa: good to know! 12:04 < jeremyrubin> hi 12:04 -!- Cory [~Cory@user/pasha] has quit [Ping timeout: 255 seconds] 12:05 < laanwj> #topic High priority for review 12:05 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 | currently we have 10 blocker PRs, 2 chasing concept ACK 12:06 < laanwj> does anyone want to add a PR, or remove it 12:06 < b10c> hi 12:07 < laanwj> or anything else that is almost ready for merge? 12:08 < dongcarl> I think #25065 is almost ready for merge, but that's on the high prio list already 12:08 < _aj_> #24931 is close i think 12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub 12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/24931 | Strengthen thread safety assertions by ajtowns · Pull Request #24931 · bitcoin/bitcoin · GitHub 12:08 < laanwj> dongcarl: _aj_ thanks 12:09 < laanwj> is there anything else that people would like to discuss? 12:10 < _aj_> would it be good to add a "what people are working on" section to the meeting every now and then? 12:10 < dongcarl> ACK 12:10 < laanwj> sure, if you'd like that 12:10 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 12:11 < laanwj> #topic What are people working on 12:11 < sipa> ACK topic :) 12:11 < _aj_> we had the lightnign summit the past few days; which will presumably have the notes published sometime. seems like there'll be progress getting funding txs moved to taproot / musig2; also a bunch of discussions about rbf and package relay ideas 12:12 < laanwj> oh, neat! 12:13 < _aj_> instagibbs in particular is working on actually implementing eltoo as his job(!) so working on getting an anyprevout testbed for him to build that on 12:13 < dongcarl> woah that's awesome if he can pull it off 12:14 < sipa> I've been working on writing a "production" codebase in Python for working with asmap on https://github.com/sipa/asmap/commits/nextgen. It currently has a module that can decode/encode/diff binary asmap files, tests, command-line tools for interfacing with that, plus gathering/collecting/processing BGP dump files into asmap. 12:14 < sipa> It still needs some polishing, but it's getting there, at which points I'll be pinging some people for review. 12:15 < laanwj> we've already been using the new Python asmap module in #24864, to replace the DNS based ASN lookup for the hardcoded seeds 12:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/24864 | contrib: Use asmap for ASN lookup in makeseeds by laanwj · Pull Request #24864 · bitcoin/bitcoin · GitHub 12:16 < jonatack> great stuff all, good to hear 12:16 < sipa> Also continued review of the PRs darosior has been working on to get Miniscript integrated into Bitcoin Core. 12:17 < sipa> Also, spec work on BIP324 (v2 p2p transport) with dhruv and real_or_random, hopefully public soon. 12:18 < sipa> Oh, and I did a writeup on optional, private, authentication protocols like Countersign: https://github.com/sipa/writeups/tree/main/private-authentication-protocols. Actually proposing something like that is a way off, as I think it needs more academic rigour first (but that's being worked on too). 12:18 < laanwj> speaking of that i've reviewed one of the BIP324 PRs today (#20962) 12:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/20962 | Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification by jonasschnelli · Pull Request #20962 · bitcoin/bitcoin · GitHub 12:20 < laanwj> interesting, good to hear the authentication side is also still being worked on 12:20 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:22 < laanwj> thanks for the updates _aj_ dongcarl and sipa 12:22 < laanwj> anyone else that'd like to discuss what they're working on? any other topics? 12:23 < dongcarl> I think we can probably have these "what are people working on" things as a convention for after the meeting? Don't want it to impose a burden on laanwj. 12:23 < jeremyrubin> i think it would be good to have regular updates from each maintainer on how they are prioritizing their time / what PRs they are focused on merging? 12:24 < laanwj> it doesn't burden me to discuss it during the meeting really, also we have very few topics lately 12:24 < dongcarl> laanwj: Okay cool! 12:25 < _aj_> i'd love to hear what fanquake/laanqj/marco are prioritising (assumign it's something specific not just highpri and things people say are rfm of course) 12:25 < _aj_> laanwj 12:25 < laanwj> i've been looking into BIP324, and catching up with the libbitcoin kernel stuff 12:26 < _aj_> (the qml gui stuff seems interesting and i hadn't been aware of it at all) 12:26 < hebasto> _aj_: thanks! 12:27 < dongcarl> hebasto: you think it's possible we'll use qt6 some day? 12:27 < laanwj> i've also tried to review #22702 but it scared me a bit 12:27 <@gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub 12:27 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 244 seconds] 12:28 < hebasto> dongcarl: maybe switching to cmake will help a lot 12:28 -!- realies [~realies@user/realies] has quit [Quit: ~] 12:29 < hebasto> as cmake is "native" for Qt 6, besides other benefits, of course 12:29 < jonatack> laanwj: read your feedback, i've been remiss in not re-reviewing that one yet but it seems like a valuable performance improvement. Do you think it's too dangerous, or it needs more testing and eyes? 12:29 < _aj_> is switching to cmake likely or pie-in-the-sky? if likely, is there a gentle introduction to cmake somewhere? :) 12:30 < laanwj> jonatack: the performance improvement is very nice but it's so tricky 12:30 < sipa> @laanwj I need to look at the latest code changes again, but I'm very concept ACK on that allocator. 12:30 < jonatack> laanwj: (have been running it without issues as well) 12:30 < hebasto> _aj_: https://github.com/hebasto/bitcoin/tree/cmake/test 12:31 < hebasto> https://gist.github.com/hebasto/aac97d2f6b18c4ec2ad951baeb1ac00c 12:31 < sipa> IIRC my biggest gripes with it were code organization related things. 12:33 < _aj_> hebasto: oh, if dlls "just work" that is a big side benefit 12:33 < hebasto> _aj_: indeed :) 12:33 < laanwj> i'm just afraid that we'll mess up somewhere with this kind of low level allocation handling, to be clear i'm not against it, but we need to be really sure it gets enough review, that we even have enough developers that can review code like that 12:34 < _aj_> laanwj: maybe we should do an advanced version of the pr review club on it? 12:34 < laanwj> _aj_: yeah maybe! 12:35 < jonatack> sipa: thanks, good to know. Last time I looked it appeared to have been reworked to an extent that a diff review wasn't too feasible, needed a full re-review for me 12:35 < laanwj> dlls don't 'just work' i dont believe u! 12:35 < sipa> haha 12:35 < hebasto> laanwj: feedback is always welcome :) 12:36 < laanwj> speaking of dlls, i wonder if we can stop exporting unnecessary symbols from libbitcoin_consensus, it exports all kinds of c++ library symbols at the moment 12:36 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 12:36 < laanwj> e.g. https://github.com/bitcoin/bitcoin/pull/25020#issuecomment-1142151675 12:37 < luke-jr> dlls just work with autotools too <.< 12:38 < hebasto> luke-jr: #19772 12:38 <@gribble> https://github.com/bitcoin/bitcoin/issues/19772 | build: Cross-compiling libbitcoinconsensus for Windows fails with DEBUG=1 · Issue #19772 · bitcoin/bitcoin · GitHub 12:39 < luke-jr> "fully static DLLs" is not a normal thing 12:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 12:39 < laanwj> ideally we'd only export bitcoinconsensus_*, _init and _fini, nothing more 12:43 < laanwj> i guess that concludes the meeting, thanks for attending everyone 12:43 < laanwj> #endmeeting 12:45 -!- Guest38 [~Guest38@80.208.68.183] has joined #bitcoin-core-dev 12:46 -!- Guest38 [~Guest38@80.208.68.183] has quit [Client Quit] 12:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 13:11 < jarolrod> seems like my bouncer wasn't working before 13:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 13:12 < jarolrod> _aj_: thanks! we took a little break in the middle, but we've picked up steam on the qml gui again, and hope to have something to showcase to the community fairly soon 13:35 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f63b460a850...00ce8543f16f 13:35 < bitcoin-git> bitcoin/master 0569b5c Suhas Daftuar: Sync chain more readily from inbound peers during IBD 13:35 < bitcoin-git> bitcoin/master 48262a0 Suhas Daftuar: Add functional test for block sync from inbound peers 13:35 < bitcoin-git> bitcoin/master 00ce854 laanwj: Merge bitcoin/bitcoin#24171: p2p: Sync chain more readily from inbound pee... 13:35 < bitcoin-git> [bitcoin] laanwj merged pull request #24171: p2p: Sync chain more readily from inbound peers during IBD (master...2022-01-download-from-inbound) https://github.com/bitcoin/bitcoin/pull/24171 13:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 14:11 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 260 seconds] 14:27 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 14:39 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 15:11 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 15:21 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection] 15:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 15:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 272 seconds] 15:29 -!- bairen [~bairen@gateway/tor-sasl/bairen] has joined #bitcoin-core-dev 15:32 -!- vasild_ [~vd@user/vasild] has joined #bitcoin-core-dev 15:33 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 15:36 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds] 15:36 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds] 15:46 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 15:51 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 15:59 -!- mudsip [~mudsip@user/mudsip] has quit [] 16:00 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 16:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 16:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 16:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 16:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 258 seconds] 16:21 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 16:22 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds] 16:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 16:41 -!- klement [~textual@218.212.82.174] has joined #bitcoin-core-dev 16:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 16:46 -!- Alina-malina [~Alina-mal@user/alina-malina] has quit [Ping timeout: 248 seconds] 16:48 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 16:50 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 16:52 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 258 seconds] 16:53 -!- klement [~textual@218.212.82.174] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 17:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 17:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds] 17:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 255 seconds] 17:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 17:54 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev 17:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 17:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 18:01 -!- Waly [~Waly@186.16.161.65] has joined #bitcoin-core-dev 18:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 18:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 240 seconds] 18:38 -!- Waly [~Waly@186.16.161.65] has quit [Quit: Client closed] 18:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 18:49 -!- klement [~textual@218.212.82.174] has joined #bitcoin-core-dev 18:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 272 seconds] 18:55 -!- erik-etsuji-kato [~erik@gateway/tor-sasl/erik-etsuji-kato] has quit [Ping timeout: 240 seconds] 19:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev 19:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 19:06 -!- Saloframes [~Saloframe@user/Saloframes] has quit [Ping timeout: 258 seconds] 19:10 -!- joshuajbouw [~jbouw@user/joshua] has joined #bitcoin-core-dev 19:11 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur] 19:16 -!- klement [~textual@218.212.82.174] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:25 -!- evbo [~bosats@2601:47:4285:c7f0:a7df:3981:7a04:d870] has quit [Ping timeout: 255 seconds] 19:26 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 19:30 -!- nullcon [~nullcon@garza.riseup.net] has joined #bitcoin-core-dev 19:30 < nullcon> Nullcon 2022 CFP closes on Jun 05, 2022. If anyone interested to submit a research related to bitcoin core security or cryptography: https://nullcon.net/goa-2022/cfp/ 19:30 -!- nullcon [~nullcon@garza.riseup.net] has left #bitcoin-core-dev [] 19:31 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 19:36 -!- evbo [~bosats@2601:47:4285:c7f0:26b7:8cdb:27c8:cd1c] has joined #bitcoin-core-dev 19:47 -!- mrlemke [~mrlemke@208.74.105.200] has joined #bitcoin-core-dev 19:51 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 19:54 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds] 19:56 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev 19:58 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 20:07 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 258 seconds] 20:17 -!- klement [~textual@218.212.82.174] has joined #bitcoin-core-dev 20:17 -!- klement [~textual@218.212.82.174] has quit [Client Quit] 20:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 20:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 260 seconds] 20:30 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 20:34 -!- evbo [~bosats@2601:47:4285:c7f0:26b7:8cdb:27c8:cd1c] has quit [Remote host closed the connection] 20:35 -!- evbo [~bosats@2601:47:4285:c7f0:970e:f31b:41d5:6cd9] has joined #bitcoin-core-dev 20:44 -!- evbo [~bosats@2601:47:4285:c7f0:970e:f31b:41d5:6cd9] has quit [Ping timeout: 255 seconds] 20:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 20:56 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 258 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:02 -!- evbo [~bosats@2601:47:4285:c7f0:be43:5240:909f:780d] has joined #bitcoin-core-dev 21:16 -!- cryptoquick [~cryptoqui@8.46.89.33] has quit [Quit: Ping timeout (120 seconds)] 21:19 -!- cryptoquick [~cryptoqui@8.46.89.33] has joined #bitcoin-core-dev 21:27 -!- evbo [~bosats@2601:47:4285:c7f0:be43:5240:909f:780d] has quit [Ping timeout: 244 seconds] 21:41 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 21:46 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 21:51 -!- hashfunc14e [~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05] has joined #bitcoin-core-dev 22:04 -!- hashfunc14e [~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05] has quit [Remote host closed the connection] 22:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has joined #bitcoin-core-dev 22:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b] has quit [Ping timeout: 260 seconds] 22:52 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 256 seconds] 23:05 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 23:07 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:11 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds] 23:36 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev 23:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00ce8543f16f...2cf8c2caea90 23:49 < bitcoin-git> bitcoin/master 3a171f7 klementtan: logging: fix logging empty threadname 23:49 < bitcoin-git> bitcoin/master 2cf8c2c MacroFake: Merge bitcoin/bitcoin#25256: logging: fix logging empty thread name 23:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25256: logging: fix logging empty thread name (master...add_leveldb_threadname) https://github.com/bitcoin/bitcoin/pull/25256 --- Log closed Fri Jun 03 00:00:37 2022