--- Log opened Tue Jun 14 00:00:52 2022 00:12 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds] 00:20 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev 00:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 00:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 00:34 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:47 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cccbc5fe3ea5...c5fbcf5f8d7b 00:47 < bitcoin-git> bitcoin/master 1cb42ae Oskar Mendel: util: modify Win32LockedPageAllocator to query windows for limit 00:47 < bitcoin-git> bitcoin/master c5fbcf5 laanwj: Merge bitcoin/bitcoin#25320: util: modify Win32LockedPageAllocator to quer... 00:47 < bitcoin-git> [bitcoin] laanwj merged pull request #25320: util: modify Win32LockedPageAllocator to query windows for limit. (master...win32-lockedpageallocator-limit) https://github.com/bitcoin/bitcoin/pull/25320 00:47 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 00:52 -!- o3 [uid554669@id-554669.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 01:04 -!- dougefish [~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239] has quit [Ping timeout: 258 seconds] 01:10 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 01:11 -!- dougefish [~dougefish@5.29.11.69] has joined #bitcoin-core-dev 01:17 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 01:21 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 01:31 < bitcoin-git> [bitcoin] fanquake closed pull request #23448: refactor, consensus: remove calls to global `Params()` in validation layer (master...remove_call_params) https://github.com/bitcoin/bitcoin/pull/23448 01:39 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5fbcf5f8d7b...1557014378cc 01:39 < bitcoin-git> bitcoin/master 491bb14 fanquake: build: test for timingsafe_bcmp 01:39 < bitcoin-git> bitcoin/master 1557014 laanwj: Merge bitcoin/bitcoin#25332: build: test for timingsafe_bcmp 01:39 < bitcoin-git> [bitcoin] laanwj merged pull request #25332: build: test for timingsafe_bcmp (master...test_for_timingsafe_bcmp) https://github.com/bitcoin/bitcoin/pull/25332 01:44 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 01:48 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds] 01:55 -!- Guest76 [~Guest76@101.96.71.210] has joined #bitcoin-core-dev 01:59 -!- Guest76 [~Guest76@101.96.71.210] has quit [Client Quit] 02:02 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 240 seconds] 02:04 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 02:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:17 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 02:17 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 256 seconds] 02:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 02:23 < laanwj> "laanwj closed this as completed 28 minutes ago" wait what, where does "completed" come from, does github allow choosing a close reason now? 02:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 02:25 < laanwj> oh i see "close as completed" "close as not planned" is a dropdown now ! 02:27 < laanwj> you can choose whether closed issues become grey or purple 02:29 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 02:29 < laanwj> that's kind of cool, well, at least more useful than being able to display "achievements" on your github profile *sigh* 02:46 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1557014378cc...9e4fbebcc8e4 02:46 < bitcoin-git> bitcoin/master eb8aab7 Jon Atack: logging: add LogPrintfCategory to log unconditionally with category 02:46 < bitcoin-git> bitcoin/master ecff20d Jon Atack: logging: use LogPrintfCategory rather than a manual category 02:46 < bitcoin-git> bitcoin/master 9e4fbeb laanwj: Merge bitcoin/bitcoin#25306: logging: add LogPrintfCategory to log uncondi... 02:46 < bitcoin-git> [bitcoin] laanwj merged pull request #25306: logging: add LogPrintfCategory to log unconditionally with category (master...2022-06-logprintfcategory) https://github.com/bitcoin/bitcoin/pull/25306 02:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 02:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 03:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 03:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 03:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 03:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 03:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 03:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 03:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 03:38 < bitcoin-git> [bitcoin] brokenprogrammer opened pull request #25368: doc: Update importaddress mention incompatibility with descriptor wallet (master...importaddress-descriptor-wallet-documentation) https://github.com/bitcoin/bitcoin/pull/25368 03:39 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 260 seconds] 03:41 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 03:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 03:46 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 03:48 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 03:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 03:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 244 seconds] 03:53 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 03:57 < bitcoin-git> [gui] hebasto opened pull request #618: refactor: Add `transactionoverviewwidget.cpp` source file (master...220614-tow) https://github.com/bitcoin-core/gui/pull/618 03:59 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev 03:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 04:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 258 seconds] 04:04 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 04:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 04:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 04:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 04:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 04:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 04:49 < bitcoin-git> [bitcoin] fanquake opened pull request #25369: Unsubtree Univalue (master...unsubtree_univalue) https://github.com/bitcoin/bitcoin/pull/25369 04:52 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 04:59 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 05:03 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 05:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 05:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:15 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has quit [Quit: ZNC 1.8.2 - https://znc.in] 05:18 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has joined #bitcoin-core-dev 05:37 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 06:05 -!- Guest16 [~Guest16@94.203.137.90] has joined #bitcoin-core-dev 06:08 -!- Guest16 [~Guest16@94.203.137.90] has quit [Client Quit] 06:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e4fbebcc8e4...a05876619a33 06:17 < bitcoin-git> bitcoin/master 42bbbba Sebastian Falbesoner: message-capture-parser: fix out of bounds error for empty vectors 06:17 < bitcoin-git> bitcoin/master a058766 MacroFake: Merge bitcoin/bitcoin#25367: [contrib] message-capture-parser: fix out of ... 06:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25367: [contrib] message-capture-parser: fix out of bounds error for empty vectors (master...202206-contrib-fix_message_capture_out_of_bounds) https://github.com/bitcoin/bitcoin/pull/25367 06:59 -!- furszy [~furszy@user/furszy] has quit [] 07:14 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 07:14 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 07:43 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 07:53 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 276 seconds] 07:57 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 08:02 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev 08:02 -!- Guest32 [~Guest32@49.207.222.68] has joined #bitcoin-core-dev 08:04 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 08:05 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 08:08 -!- Guest32 [~Guest32@49.207.222.68] has quit [Quit: Client closed] 08:09 -!- furszy [~furszy@user/furszy] has quit [] 08:21 < dongcarl> Hi all, I'm looking to get some review on #25215 and #25223. There's been quite some conceptual-level discussions and they are ready for code reviews. They're both pretty easy refactors to review too. Please let me know if there's anything I can do to help make review easier! Cheers! ☺️ 08:21 <@gribble> https://github.com/bitcoin/bitcoin/issues/25215 | [kernel 2d/n] Reduce CTxMemPool constructor call sites by dongcarl · Pull Request #25215 · bitcoin/bitcoin · GitHub 08:21 <@gribble> https://github.com/bitcoin/bitcoin/issues/25223 | [kernel 2e/n] miner: Make `mempool` optional, stop constructing temporary empty mempools by dongcarl · Pull Request #25223 · bitcoin/bitcoin · GitHub 08:23 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 09:16 < bitcoin-git> [bitcoin] theStack opened pull request #25370: test: check for `getblocktxn` request with out-of-bounds tx index (master...202206-test-check_getblocktxn_out_of_bounds_tx_index) https://github.com/bitcoin/bitcoin/pull/25370 09:22 -!- Guest37 [~Guest37@117.221.70.189] has joined #bitcoin-core-dev 09:23 < laanwj> dongcarl: will have a look, thanks 09:32 -!- Guest37 [~Guest37@117.221.70.189] has quit [Quit: Client closed] 09:43 < dongcarl> laanwj: Thanks! 09:47 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 09:47 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev 09:57 -!- kexkey_ [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 09:57 -!- kexkey_ [~kexkey@178.249.214.10] has quit [Client Quit] 09:59 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 246 seconds] 10:03 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 10:04 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:15 -!- larryruane [sid473749@2a03:5180:f:5::7:3a95] has quit [] 10:25 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 10:33 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 240 seconds] 10:38 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:52 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 10:53 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 10:54 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:55 -!- flooded is now known as _flood 11:05 -!- aleggg [~aleggg@179.178.114.111] has quit [] 11:06 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 11:09 -!- Eric3 [~exeric3@5.254.26.103] has joined #bitcoin-core-dev 11:10 -!- real_or_random_ [~real_or_r@user/real-or-random/x-4440763] has joined #bitcoin-core-dev 11:11 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev 11:12 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a05876619a33...df933596e7e9 11:12 < bitcoin-git> bitcoin/master 0947726 fanquake: build: support LTO in depends 11:12 < bitcoin-git> bitcoin/master df93359 laanwj: Merge bitcoin/bitcoin#23611: build: add `LTO` option to depends 11:12 < bitcoin-git> [bitcoin] laanwj merged pull request #23611: build: add `LTO` option to depends (master...lto_in_depends) https://github.com/bitcoin/bitcoin/pull/23611 11:13 -!- Earnest [~earnest@user/earnestly] has joined #bitcoin-core-dev 11:13 -!- S3RK_ [~S3RK@user/s3rk] has joined #bitcoin-core-dev 11:17 -!- meshcoll- [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-dev 11:18 -!- Netsplit *.net <-> *.split quits: dougefish, face, emcy_, gleb745438685, real_or_random, Earnestly, ExEric3, meshcollider, murrayn, Victorsueca, (+6 more, use /NETSPLIT to show all of them) 11:18 -!- Netsplit over, joins: face 11:21 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 11:21 -!- dougefish [~dougefish@5.29.11.69] has joined #bitcoin-core-dev 11:21 -!- ron-slc [~Ron@c-98-202-48-169.hsd1.ut.comcast.net] has joined #bitcoin-core-dev 11:21 -!- calvinalvin [~kcalvinal@ec2-3-38-183-204.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev 11:21 -!- gleb745438685 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 11:21 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 11:21 -!- dhruv [~dhruv@165.227.49.220] has joined #bitcoin-core-dev 11:21 -!- murrayn [~murray@static.38.4.181.135.clients.your-server.de] has joined #bitcoin-core-dev 11:22 -!- realies [~realies@user/realies] has quit [Max SendQ exceeded] 11:24 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 11:28 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 255 seconds] 11:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Read error: Connection reset by peer] 11:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 11:59 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev 12:10 -!- aleggg [~aleggg@179.178.114.111] has joined #bitcoin-core-dev 12:15 -!- greypw254600 [~greypw254@grey.pw] has joined #bitcoin-core-dev 12:17 -!- jnewbery_ [~john@user/jnewbery] has joined #bitcoin-core-dev 12:18 -!- gribble` [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 12:18 -!- mode/#bitcoin-core-dev [+o gribble`] by ChanServ 12:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:19 -!- _cold [~cold@user/cold] has joined #bitcoin-core-dev 12:20 -!- Henry151_ [~bishop@user/henry151] has joined #bitcoin-core-dev 12:20 -!- MacroFake_ [~none@72.5.34.65] has joined #bitcoin-core-dev 12:20 -!- jrawsthorne_ [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev 12:21 -!- kallewoof [~quassel@user/kallewoof] has joined #bitcoin-core-dev 12:24 -!- Netsplit *.net <-> *.split quits: da2ce7_, greypw25460, Henry151, jnewbery, @gribble, aleggg, kalle, cold, jrawsthorne, MacroFake 12:24 -!- Netsplit over, joins: aleggg 12:28 -!- da2ce7 [~da2ce7@user/da2ce7] has joined #bitcoin-core-dev 12:37 -!- Victorsueca [~Victorsue@user/victorsueca] has joined #bitcoin-core-dev 12:44 -!- TheRec [~toto@user/therec] has quit [Ping timeout: 240 seconds] 12:52 < bitcoin-git> [bitcoin] luke-jr opened pull request #25373: Support ignoring "opt-in" flag for RBF (aka full RBF) (master...fullrbf) https://github.com/bitcoin/bitcoin/pull/25373 12:57 -!- jamesob [~jamesob@pool-108-31-94-118.washdc.fios.verizon.net] has quit [Quit: The Lounge - https://thelounge.chat] 13:05 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection] 13:06 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 13:10 -!- jamesob [~jamesob@pool-108-31-94-118.washdc.fios.verizon.net] has joined #bitcoin-core-dev 13:19 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:28 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev 14:10 -!- furszy [~furszy@user/furszy] has quit [Remote host closed the connection] 14:16 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 14:30 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 14:39 -!- kexkey [~kexkey@178.249.214.10] has quit [Quit: kexkey] 14:44 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 14:47 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 14:47 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 14:47 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev 14:48 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 14:51 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Quit: Konversation terminated!] 15:12 -!- cryptapus [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev 15:40 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 15:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Remote host closed the connection] 15:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 15:50 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 15:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 258 seconds] 15:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 16:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 250 seconds] 16:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 16:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 16:16 < bitcoin-git> [bitcoin] theStack opened pull request #25374: test: remove unused `create_confirmed_utxos` helper (master...202206-test-remove_unused_create_confirmed_utxos_helper) https://github.com/bitcoin/bitcoin/pull/25374 16:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 16:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 16:32 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 250 seconds] 16:54 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 16:59 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 17:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 17:03 -!- theStack [~theStack@95.179.145.232] has quit [Remote host closed the connection] 17:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 17:08 < bitcoin-git> [bitcoin] ishaanam opened pull request #25375: rpc: add minconf option to sendall and fund transaction calls (master...fundrawtransaction_minconf) https://github.com/bitcoin/bitcoin/pull/25375 17:11 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-dev 17:12 -!- jdmark [~quassel@user/jdmark] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 17:14 -!- jdmark [~quassel@user/jdmark] has joined #bitcoin-core-dev 17:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 17:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 17:37 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity] 17:43 < _aj_> is p2p_blockfilters.py currently flaky? 17:44 -!- Alina-malina [~Alina-mal@user/alina-malina] has quit [Quit: !be back soon] 17:47 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev 17:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 17:56 -!- Ben75 [~Ben@2407:7000:85dd:dd00:a145:b99e:f59c:6818] has joined #bitcoin-core-dev 17:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 18:03 -!- Ben75 [~Ben@2407:7000:85dd:dd00:a145:b99e:f59c:6818] has quit [Quit: Ping timeout (120 seconds)] 18:05 -!- jdmark [~quassel@user/jdmark] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 18:05 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 18:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 18:06 -!- jdmark [~quassel@user/jdmark] has joined #bitcoin-core-dev 18:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 18:12 < jeremyrubin> achow101: i noticed a small bug in the PSBT spec I believe. 174 says "The internal key does not have leaf hashes, so can be indicated with a hashes len of 0.", however, it is not true that the internal key may not show up in some tap leaf as well. However, it should be clear which key is the internal key by the taproot intenral key field, so it 18:12 < jeremyrubin> shouldn't be ambigious even if it does have more than one branch. 18:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 18:15 -!- Alina-malina [~Alina-mal@user/alina-malina] has quit [Ping timeout: 260 seconds] 18:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 18:21 < jeremyrubin> it also says "4 byte master key fingerprint " and i think this should just be the fingerprint, not nesc master? 18:23 < jeremyrubin> it's also not clear (IMO) if the derivation path is required if the ExtendedPrivKey itself corresponds to the internal key 18:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 18:37 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 18:38 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 18:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 18:44 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Ping timeout: 256 seconds] 18:45 -!- Ben25 [~Ben@2407:7000:85dd:dd00:a145:b99e:f59c:6818] has joined #bitcoin-core-dev 18:53 -!- Ben25 [~Ben@2407:7000:85dd:dd00:a145:b99e:f59c:6818] has quit [Quit: Ping timeout (120 seconds)] 19:06 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 19:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 19:13 < _aj_> hmm, seems my PC doesn't handle generate(999) too well - node 1 receives blocks relatively slowly, then hits the "Large reorg, won't direct fetch" path, which makes things slower still, then it eventually times out. 9x generate(111) works fine. 19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 258 seconds] 19:23 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev 19:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 19:37 < achow101> jeremyrubin: yes, I think the intent of that sentence was to answer the question of where to put the key origin info for the internal key. The fingerprint is almost always the master key fingerprint. It's the identifier for the key to derive from. 19:37 < achow101> I'm not sure where you see an extended private key anywhere? 20:02 -!- weylin_ [~weylin@2600:8800:4005:6d00:19b7:4366:a169:a3d] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:05 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has quit [Quit: The Lounge - https://thelounge.chat] 21:06 -!- dongcarl [~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:10 -!- ronoaldo [~ronoaldo@2804:431:cfe0:1d3b:cae2:65ff:fe9b:69e6] has quit [Quit: Konversation terminated!] 21:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Remote host closed the connection] 21:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 21:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 21:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 21:20 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 21:21 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds] 21:22 -!- lukedashjr is now known as luke-jr 21:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 21:26 -!- weylin_ [~weylin@2600:8800:4005:6d00:19b7:4366:a169:a3d] has quit [Quit: Leaving...] 21:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 21:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 21:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 21:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 21:59 -!- martinus [~martinus@2001:4bc9:824:1751:ce4:a0d6:761e:4] has quit [Remote host closed the connection] 22:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 22:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 22:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 22:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 22:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 22:16 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has joined #bitcoin-core-dev 22:21 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev 22:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 22:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 22:27 < laanwj> _aj_: interesting, i do remember previous problems with large generate() being slow in the test suite on some hardware 22:27 < laanwj> _aj_: though i don't think anyone narrowed it down to tha path specifically 22:37 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev 22:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 22:42 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds] 22:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 22:45 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 22:49 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 22:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 23:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 23:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 23:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 23:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df933596e7e9...38c63e368374 23:12 < bitcoin-git> bitcoin/master 018d70b Hennadii Stepanov: scripted-diff: Avoid incompatibility with CMake AUTOUIC feature 23:12 < bitcoin-git> bitcoin/master 38c63e3 MacroFake: Merge bitcoin/bitcoin#25338: scripted-diff: Avoid incompatibility with CMa... 23:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25338: scripted-diff: Avoid incompatibility with CMake AUTOUIC feature (master...220611-autouic) https://github.com/bitcoin/bitcoin/pull/25338 23:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 23:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38c63e368374...ede908909691 23:15 < bitcoin-git> bitcoin/master fafddaf MacroFake: refactor: Introduce PeerManagerImpl::RejectIncomingTxs 23:15 < bitcoin-git> bitcoin/master ede9089 MacroFake: Merge bitcoin/bitcoin#25156: refactor: Introduce PeerManagerImpl::RejectIn... 23:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25156: refactor: Introduce PeerManagerImpl::RejectIncomingTxs (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156 23:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 248 seconds] 23:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ede908909691...a57492f65df7 23:21 < bitcoin-git> bitcoin/master 5a8c321 Sebastian Falbesoner: test: check for `getblocktxn` request with out-of-bounds tx index 23:21 < bitcoin-git> bitcoin/master a57492f MacroFake: Merge bitcoin/bitcoin#25370: test: check for `getblocktxn` request with ou... 23:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25370: test: check for `getblocktxn` request with out-of-bounds tx index (master...202206-test-check_getblocktxn_out_of_bounds_tx_index) https://github.com/bitcoin/bitcoin/pull/25370 23:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 23:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 255 seconds] 23:39 < bitcoin-git> bitcoin/master 42b2fdf Sebastian Falbesoner: test: remove unused `create_confirmed_utxos` helper 23:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a57492f65df7...4c0d1fec16fd 23:39 < bitcoin-git> bitcoin/master 4c0d1fe MacroFake: Merge bitcoin/bitcoin#25374: test: remove unused `create_confirmed_utxos` ... 23:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25374: test: remove unused `create_confirmed_utxos` helper (master...202206-test-remove_unused_create_confirmed_utxos_helper) https://github.com/bitcoin/bitcoin/pull/25374 23:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev 23:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has quit [Ping timeout: 260 seconds] 23:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:56 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 23:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:58ae:6da2:f116:61a8] has joined #bitcoin-core-dev --- Log closed Wed Jun 15 00:00:26 2022