--- Log opened Wed Jul 20 00:00:26 2022 00:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 276 seconds] 00:04 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 00:05 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 00:06 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 00:08 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 00:55 < bitcoin-git> [bitcoin] S3RK opened pull request #25647: wallet: return change from SelectionResult (master...coin_selection_get_change) https://github.com/bitcoin/bitcoin/pull/25647 00:55 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 01:05 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds] 01:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 01:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 240 seconds] 01:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 01:32 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0897b189e424...895937edb2cc 01:32 < bitcoin-git> bitcoin/master 6666803 MacroFake: streams: Add AutoFile without ser-type and ser-version 01:32 < bitcoin-git> bitcoin/master facc2fa MacroFake: Use AutoFile where possible 01:32 < bitcoin-git> bitcoin/master 895937e fanquake: Merge bitcoin/bitcoin#25285: Add AutoFile without ser-type and ser-version... 01:32 < bitcoin-git> [bitcoin] fanquake merged pull request #25285: Add AutoFile without ser-type and ser-version and use it where possible (master...2206-autofile-🌟) https://github.com/bitcoin/bitcoin/pull/25285 01:36 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 01:37 < fanquake> Google signaling it's abandonment of leveldb: https://github.com/google/leveldb/commit/7b650f85de0b785596cc145a3dd28a54cb73bb50 01:38 < fanquake> I think the likelyhood of us getting PRs merged upstream is approaching zero 01:41 < _aj_> yay google 01:44 < laanwj> assuming we don't want to look for a replacement, may be another thing to fuse and dissolve over time like univalue 01:46 < laanwj> at some point we experimented using sqlite for the utxo db and it was noticably slower (especially updates), also it may be risky from a consensus point of view to switch it 01:51 -!- emcy_ [~emcy@user/emcy] has joined #bitcoin-core-dev 01:52 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Read error: Connection reset by peer] 01:52 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 01:52 -!- Eric3 [~exeric3@dbox.miners-zone.net] has joined #bitcoin-core-dev 01:52 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 01:53 -!- darosior6 [~darosior@194.36.189.246] has joined #bitcoin-core-dev 01:53 -!- lowhope [~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e] has quit [Ping timeout: 240 seconds] 01:54 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 256 seconds] 01:54 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 256 seconds] 01:54 -!- darosior6 is now known as darosior 01:54 -!- emcy [~emcy@user/emcy] has quit [Ping timeout: 256 seconds] 01:54 -!- ExEric3 [~exeric3@dbox.miners-zone.net] has quit [Ping timeout: 256 seconds] 01:54 -!- infernix [nix@spirit.infernix.net] has quit [Ping timeout: 256 seconds] 01:56 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-core-dev 01:56 -!- lowhope [~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e] has joined #bitcoin-core-dev 01:57 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 01:57 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 02:02 -!- kexkey [~kexkey@178.249.214.23] has quit [Ping timeout: 255 seconds] 02:04 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 02:05 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has joined #bitcoin-core-dev 02:17 -!- infernix [nix@spirit.infernix.net] has joined #bitcoin-core-dev 02:18 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 02:19 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 02:19 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 02:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 268 seconds] 02:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 02:28 -!- Guest92 [~Guest92@103.82.4.244] has joined #bitcoin-core-dev 02:29 -!- Guest92 [~Guest92@103.82.4.244] has quit [Client Quit] 02:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 03:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 03:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 240 seconds] 03:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 04:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 255 seconds] 04:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 04:55 < jonatack> noticed that CI tasks that time out are now signaled as "neutral" rather than failing, nice 05:12 < vasild> I guess a custom in-house replacement of leveldb can be created that is both faster and smaller (src/leveldb is 30k lines) 05:12 < sipa> I very much doubt that. 05:12 < fanquake> yea very unlikely 05:13 < vasild> That is a provocation! 05:13 < vasild> but anyway, maintenance cost will be much higher than present which is close to zero 05:13 < sipa> Creating something functional is one thing, but having it work reliably on many platforms is one challenge, and just gaining enough confidence that it works would be one hell of a job. 05:14 < sipa> RocksDB is still being maintained. 05:14 < vasild> true 05:14 < sipa> Which started as a fork of LevelDB. 05:15 < vasild> IMO maintenace cost trumps speed, unless the in-house one is times faster, but I guess that is not likely 05:17 < fanquake> Maybe first figure out if leveldb is "slow", before worrying about writing something in house that is "faster" 05:18 < TheCharlatan> laanwj didn't you do benchmarks with lmdb as well? IIRC leveldb was faster in those. 05:19 < sipa> IIRC we benchmarked sqlite at some point, which is enormously slower. 05:19 < sipa> lmdb we discarded as an option as it only realistically worked on 64-bit systems IIRC 05:20 < _aj_> on disk format is platform dependent, apparently? 05:20 < sipa> Right; that too. 05:21 < TheCharlatan> it was discussed here for the wallet db format: https://github.com/bitcoin/bitcoin/issues/18916#issuecomment-670132247 05:25 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 05:25 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:31 < sipa> The benchmarking with other database layers for the chainstate was much earlier... maybe 2015-2016 somewhere. 05:31 < _aj_> rocksdb doesn't sound terrible? 05:31 < josie[m]> fwiw, i have noticed rocksDB popping up in a lot of other open source projects. seems to be gaining adoption 05:32 < _aj_> https://pastebin.com/raw/evx62gak was jonasschnelli's reindex test for lmdb with laanwj's patches i think? 05:32 < sipa> I'd need to look into it, but it being a fork of LevelDB, with a number of improvements over it, and actively maintained it seems, may make most sense. 05:35 < vasild> +1 and probably easiest to transition to, I guess, if it has same or similar api 05:37 < TheCharlatan> _aj_ yes, that was the one I was looking for. 05:37 -!- Guest60 [~Guest60@60.241.9.31] has joined #bitcoin-core-dev 05:39 < vasild> what is the downside of having the db library as an external dependency instead of in src/? We cannot patch it (do we need to)? Users have to install it separately? Is that really a problem if it is something like "apt install rocksdb"? they already have to install other stuff too, e.g. sqlite 05:41 -!- Guest60 [~Guest60@60.241.9.31] has quit [Client Quit] 05:41 < sipa> It depends on the use case, but for LevelDB I think there are two main ones: (a) we have our own fork of LevelDB already with a few patches (for a while this was needed to get windows support, though that later changed), and (b) the UTXO database is so consensus critical that if a bug were to be found in it, we may be forced to perpetuate the bug (until it can be changed through a coordinated consensus rule change) 05:46 < vasild> (b) 05:48 < josie[m]> iinm, doesn't electrs use rocksdb? might be worth asking if they have any complaints with it. im sure the use cases for the db are very different, but there could be some overlap and some insights from them 05:53 -!- Guest56 [~Guest56@124-182-146-85.ftth.glasoperator.nl] has joined #bitcoin-core-dev 05:53 -!- Guest56 [~Guest56@124-182-146-85.ftth.glasoperator.nl] has quit [Client Quit] 05:57 < sipa> Also... it doesn't look like LevelDB is dead. 05:57 < sipa> Just a "critical maintenance only" state, which probably doesn't predict much good for its long-term future, but on the other hand... it does just work. 05:59 < fanquake> Yea, and we've patched a few things we need in our subtree already, like c++20 support 05:59 < fanquake> I cannot imagine we're ever going to end up in a state were users apt install leveldb/rocks/db/whatever 05:59 < fanquake> That sounds terrible. 06:00 < sipa> fanquake vasild There is also a big difference between subtree vs compile-time dependency on the one hand, and compiled-in vs runtime dependency on the other hand. 06:00 < sipa> I have the impression we're conflating them. 06:01 < sipa> sqlite is a compile-time dependency but not a runtime dependency 06:01 < fanquake> sqlite is also not required to use bitcoind 06:01 < _aj_> sipa: ? my bitcoind is dynamically linked to libsqlite3.so.0? 06:02 < Earnestly> (If users were able to install leveldb/rock/db/whatever it would imply that bitcoin-core has matured enough to decouple the db from consensus 06:02 < fanquake> if anything i hope we continue to reduce the runtime dependencies in our release binaries 06:02 < sipa> _aj_: Oh, only in release build then I guess. 06:02 < _aj_> sipa: ah, sure 06:09 -!- OneLzx [~OneLzx@141.164.59.188] has joined #bitcoin-core-dev 06:10 -!- OneLzx [~OneLzx@141.164.59.188] has quit [Client Quit] 06:11 < vasild> sipa: I was talking about subtree vs compile-time dependency. That is - not include it in our source code, but ask users to have it installed separtely (like sqlite) then it can be dynamically linked, meaning it is needed at runtime too or statically linked, meaning no need to have an external libfoodb.so all the time. But I think (b) just means it is best to have it in a subtree 06:12 < vasild> well, actually subtree library can also be statically or dynamically linked 06:19 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25648: refactor: Remove ::fRequireStandard global (master...2207-burn-globals-🛶) https://github.com/bitcoin/bitcoin/pull/25648 06:29 < bitcoin-git> [bitcoin] Chres-SC opened pull request #25649: Src crypto (master...src_crypto) https://github.com/bitcoin/bitcoin/pull/25649 06:29 < bitcoin-git> [bitcoin] fanquake closed pull request #25649: Src crypto (master...src_crypto) https://github.com/bitcoin/bitcoin/pull/25649 06:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/895937edb2cc...1eedde157f2e 06:30 < bitcoin-git> bitcoin/master fa32b1b MacroFake: refactor: Use chainman() helper consistently in ChainImpl 06:30 < bitcoin-git> bitcoin/master 1eedde1 MacroFake: Merge bitcoin/bitcoin#25638: refactor: Use chainman() helper consistently ... 06:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25638: refactor: Use chainman() helper consistently in ChainImpl (master...2207-chainman-🕉) https://github.com/bitcoin/bitcoin/pull/25638 06:32 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 06:47 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404] 06:47 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:48 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Client Quit] 06:48 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:50 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev 06:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/1eedde157f2e...5c82ca3365f6 06:52 < bitcoin-git> bitcoin/master cc7b2fd fanquake: refactor: move compat.h into compat/ 06:52 < bitcoin-git> bitcoin/master 7c3df5e fanquake: compat: document FD_SETSIZE redefinition for WIN32 06:52 < bitcoin-git> bitcoin/master b63ddb7 fanquake: compat: remove unused WSA* definitions 06:52 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25493: compat: document code in compat.h (master...document_compat_code) https://github.com/bitcoin/bitcoin/pull/25493 07:00 < bitcoin-git> [bitcoin] josibake opened pull request #25650: script: default to necessary tags in `test/get_previous_releases.py` (master...josibake-update-get-previous-releases-script) https://github.com/bitcoin/bitcoin/pull/25650 07:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 08:02 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 08:29 -!- jespada [~jespada@200.123.140.126] has quit [Ping timeout: 240 seconds] 08:33 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 08:33 -!- jespada [~jespada@45.162.228.190] has joined #bitcoin-core-dev 08:47 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 08:58 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev 09:01 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Remote host closed the connection] 09:04 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 09:09 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Remote host closed the connection] 09:15 < josie[m]> is there any special steps that need to be taken when making a ci change in a PR, mixed with other changes? or is it better to have them as separate PRs ? 09:21 < josie[m]> s/is there/are there/ 09:31 < bitcoin-git> [bitcoin] jonatack opened pull request #25651: refactor: make ChainImpl::m_node data member private (master...make-ChainImpl-m_node-data-member-private) https://github.com/bitcoin/bitcoin/pull/25651 09:32 < sipa> josie ⚡️: I'd say separate commits (which ideally all pass CI individually), but within the same PR. 09:32 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 09:33 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 09:34 < sipa> (assuming it's related at all, of course) 09:38 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@70.49.167.252] has joined #bitcoin-core-dev 09:42 < josie[m]> Pieter: cool, thx! 10:01 -!- Lov3r_Of_Bitcoin [~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:02 -!- michaelfolkson2 is now known as michaelfolkson 10:18 < kanzure> openssl has removed ripemd160? https://github.com/petertodd/python-bitcoinlib/pull/276 10:18 < kanzure> s/removed/moved to a non-default configuration 10:18 < sipa> yes 10:19 < sipa> lol, that PR copies the "embit" pure python implementation, which is apparently copied from the one I wrote for Bitcoin Corr. 10:19 < sipa> full circle 10:21 < kanzure> sounds like an ACK to me! 10:24 < sipa> They seem to have remove the warning not to use it for anything but testing..m 10:25 < sipa> https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/ripemd160.py 10:28 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@70.49.167.252] has quit [Remote host closed the connection] 11:02 -!- Lov3r_Of_Bitcoin [~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has quit [Quit: Connection closed] 12:15 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 12:17 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 12:20 -!- hirish [~hirish@ip251.ip-178-33-19.eu] has quit [Read error: Connection reset by peer] 12:22 -!- hirish [~hirish@ip251.ip-178-33-19.eu] has joined #bitcoin-core-dev 13:25 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 13:39 -!- ronoaldo [~ronoaldo@179.100.0.45] has quit [Quit: Konversation terminated!] 13:40 -!- ronoaldo [~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6] has joined #bitcoin-core-dev 13:47 < bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/5c82ca3365f6...d67f89bd9577 13:47 < bitcoin-git> bitcoin/master 597a4b3 Sebastian Falbesoner: scripted-diff: rename `FromBinary` helper to `from_binary` (signet miner) 13:47 < bitcoin-git> bitcoin/master 7c0dfec Sebastian Falbesoner: refactor: move `from_binary` helper from signet miner to test framework 13:47 < bitcoin-git> bitcoin/master 1b035c0 Sebastian Falbesoner: refactor: move PSBT(Map) helpers from signet miner to test framework 13:47 < bitcoin-git> [bitcoin] achow101 merged pull request #25625: test: add test for decoding PSBT with per-input preimage types (master...202207-test-add_more_decodepsbt_tests) https://github.com/bitcoin/bitcoin/pull/25625 13:47 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 13:50 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has quit [Ping timeout: 264 seconds] 13:52 -!- kexkey [~kexkey@178.249.214.23] has joined #bitcoin-core-dev 13:55 -!- ronoaldo [~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6] has quit [Quit: Konversation terminated!] 13:57 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Remote host closed the connection] 13:58 -!- ronoaldo [~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6] has joined #bitcoin-core-dev 13:59 < bitcoin-git> [bitcoin] achow101 pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/d67f89bd9577...d1e42659bbdd 13:59 < bitcoin-git> bitcoin/master da8f62d furszy: wallet: remove always true 'fUseCache' from CachedTxGetImmatureCredit 14:00 < bitcoin-git> bitcoin/master 47b1012 furszy: wallet: remove always true 'fUseCache' from CachedTxGetImmatureWatchOnlyCr... 14:00 < bitcoin-git> bitcoin/master 4f0ca9b furszy: wallet: remove always false 'recalculate' arg from GetCachableAmount 14:00 < bitcoin-git> [bitcoin] achow101 merged pull request #25543: wallet: cleanup cached amount and input mine check code (master...2022_wallet_cleanup_1) https://github.com/bitcoin/bitcoin/pull/25543 14:04 -!- hotbeat [~hotbeat@64.145.93.205] has joined #bitcoin-core-dev 14:09 -!- afmencken [~afmencken@static-198-54-131-158.cust.tzulo.com] has joined #bitcoin-core-dev 14:17 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 14:20 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 260 seconds] 14:21 -!- ronoaldo [~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6] has quit [Quit: Konversation terminated!] 14:21 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 14:51 < bitcoin-git> [bitcoin] real-or-random opened pull request #25655: build: remove left-over pkgconfig vars in config.site.in (master...202207-pkgconfig-leftovers) https://github.com/bitcoin/bitcoin/pull/25655 14:52 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:53 -!- Guest2517 [~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net] has joined #bitcoin-core-dev 14:54 -!- Guest2517 [~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net] has quit [Client Quit] 14:55 -!- Guest25 [~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net] has joined #bitcoin-core-dev 15:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 15:00 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 15:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 15:05 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 15:11 -!- deadslug [~enno@2600:1010:b044:c772:dd00:61da:c511:49bb] has joined #bitcoin-core-dev 15:16 < bitcoin-git> [bitcoin] theStack opened pull request #25656: refactor: wallet: return BResult from `GetReservedDestination` methods (master...202207-refactor-wallet_use_bresult_for_getreserveddestination) https://github.com/bitcoin/bitcoin/pull/25656 15:19 -!- Guest45 [~Guest45@2a01:4b00:82a3:df00:42d:b064:5c7a:3bc2] has joined #bitcoin-core-dev 15:20 < bitcoin-git> [bitcoin] real-or-random closed pull request #25655: build: remove left-over pkgconfig vars in config.site.in (master...202207-pkgconfig-leftovers) https://github.com/bitcoin/bitcoin/pull/25655 15:21 -!- Guest45 [~Guest45@2a01:4b00:82a3:df00:42d:b064:5c7a:3bc2] has quit [Client Quit] 15:25 -!- Guest25 [~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net] has quit [Quit: Client closed] 15:39 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 15:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 15:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:04 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 16:25 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 16:26 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Remote host closed the connection] 16:42 -!- hotbeat [~hotbeat@64.145.93.205] has quit [Ping timeout: 240 seconds] 16:47 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 17:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 17:05 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 17:09 -!- deadslug [~enno@2600:1010:b044:c772:dd00:61da:c511:49bb] has quit [Ping timeout: 244 seconds] 17:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Remote host closed the connection] 17:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 17:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 240 seconds] 17:30 -!- deadslug [~enno@157.sub-174-194-148.myvzw.com] has joined #bitcoin-core-dev 17:31 -!- deadslug [~enno@157.sub-174-194-148.myvzw.com] has quit [Client Quit] 17:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 17:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 272 seconds] 17:56 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 17:56 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 18:05 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 268 seconds] 18:06 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Remote host closed the connection] 18:07 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 18:07 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 18:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has joined #bitcoin-core-dev 18:29 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 18:29 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 18:43 -!- cfields_ [~cfields@user/cfields] has quit [Ping timeout: 256 seconds] 18:57 -!- Sav10 [~Sav@2601:245:4580:48b0:f8c7:8722:5f9d:1d89] has joined #bitcoin-core-dev 18:58 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Remote host closed the connection] 18:58 -!- Sav10 [~Sav@2601:245:4580:48b0:f8c7:8722:5f9d:1d89] has quit [Client Quit] 18:58 -!- cfields [~cfields@user/cfields] has joined #bitcoin-core-dev 18:59 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 19:03 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Ping timeout: 272 seconds] 19:06 < bitcoin-git> [bitcoin] furszy opened pull request #25659: wallet: simplify ListCoins implementation (master...2022_wallet_clean_listCoins) https://github.com/bitcoin/bitcoin/pull/25659 19:17 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has joined #bitcoin-core-dev 19:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e] has quit [Ping timeout: 240 seconds] 19:25 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 19:28 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 268 seconds] 19:32 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 19:44 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 260 seconds] 19:48 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 19:51 -!- Kaizen_K_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-18.dsl.bell.ca] has joined #bitcoin-core-dev 19:52 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca] has quit [Ping timeout: 268 seconds] 19:56 -!- Kaizen_K_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-18.dsl.bell.ca] has quit [Ping timeout: 272 seconds] 20:11 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-18.dsl.bell.ca] has joined #bitcoin-core-dev 20:11 -!- greypw254600 [~greypw254@grey.pw] has joined #bitcoin-core-dev 20:34 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 268 seconds] 20:35 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-18.dsl.bell.ca] has quit [Ping timeout: 272 seconds] 20:43 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 20:54 -!- Guest32 [~Guest32@068-188-232-066.res.spectrum.com] has joined #bitcoin-core-dev 20:54 -!- Guest32 [~Guest32@068-188-232-066.res.spectrum.com] has quit [Client Quit] 20:57 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:05 -!- david-bakin [~david-bak@c-174-61-163-5.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 21:46 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds] 21:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d16a:e8a7:2a08:2cd3] has joined #bitcoin-core-dev 22:14 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 240 seconds] 22:24 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 22:36 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 22:36 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 22:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d16a:e8a7:2a08:2cd3] has quit [Ping timeout: 272 seconds] 22:58 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:03 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 268 seconds] 23:04 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev 23:30 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 23:59 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] --- Log closed Thu Jul 21 00:00:27 2022