--- Log opened Tue Sep 13 00:00:04 2022 --- Day changed Tue Sep 13 2022 00:00 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 00:05 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 258 seconds] 00:19 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:21 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:53 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev 00:57 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 250 seconds] 01:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds] 01:26 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:42 -!- Murch [~murch@user/murch] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- bitcoin-git [~bitcoin-g@2001:470:69fc:105::2:690] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- provoostenator [~provooste@user/provoostenator] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- sipa [~sipa@user/sipa] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- kvaciral [~kvaciral@2001:470:69fc:105::17b] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- denise[m] [~denisewui@2001:470:69fc:105::1:4ab8] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- josie[m] [~josiem]@2001:470:69fc:105::2:47a6] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has quit [Quit: Bridge terminating on SIGTERM] 01:42 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has quit [Quit: Bridge terminating on SIGTERM] 01:45 -!- Murch [~murch@user/murch] has joined #bitcoin-core-dev 01:50 -!- kvaciral [~kvaciral@2001:470:69fc:105::17b] has joined #bitcoin-core-dev 01:50 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-core-dev 01:50 -!- bitcoin-git [~bitcoin-g@2001:470:69fc:105::2:690] has joined #bitcoin-core-dev 01:50 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev 01:50 -!- denise[m] [~denisewui@2001:470:69fc:105::1:4ab8] has joined #bitcoin-core-dev 01:50 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-dev 01:50 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined #bitcoin-core-dev 01:50 -!- provoostenator [~provooste@user/provoostenator] has joined #bitcoin-core-dev 01:50 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has joined #bitcoin-core-dev 01:50 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has joined #bitcoin-core-dev 01:50 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has joined #bitcoin-core-dev 01:50 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has joined #bitcoin-core-dev 01:50 -!- josie[m] [~josiem]@2001:470:69fc:105::2:47a6] has joined #bitcoin-core-dev 01:50 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has joined #bitcoin-core-dev 02:03 -!- kexkey [~kexkey@178.249.214.19] has quit [Ping timeout: 265 seconds] 02:05 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 02:07 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5558d2f5496d...995fdef14af2 02:07 < bitcoin-git> bitcoin/master beb9426 Hennadii Stepanov: Revert "guix: Build depends/qt with our platform definition" 02:07 < bitcoin-git> bitcoin/master 995fdef fanquake: Merge bitcoin/bitcoin#26059: Revert "guix: Build depends/qt with our platf... 02:07 < bitcoin-git> [bitcoin] fanquake merged pull request #26059: Revert "guix: Build depends/qt with our platform definition" (master...220910-guix) https://github.com/bitcoin/bitcoin/pull/26059 02:17 -!- af_mencken [~afmencken@69.4.234.104] has joined #bitcoin-core-dev 02:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/995fdef14af2...e9e943cfb7c4 02:17 < bitcoin-git> bitcoin/master 2870a97 furszy: RPC: unify arg type error message 02:17 < bitcoin-git> bitcoin/master e9e943c fanquake: Merge bitcoin/bitcoin#26069: rpc: unify arg type error message 02:17 < bitcoin-git> [bitcoin] fanquake merged pull request #26069: rpc: unify arg type error message (master...2022_rpc_unify_error_type) https://github.com/bitcoin/bitcoin/pull/26069 02:19 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9e943cfb7c4...a361c6cae766 02:19 < bitcoin-git> bitcoin/master 0cd7928 fanquake: guix: use git-minimal over git 02:19 < bitcoin-git> bitcoin/master a361c6c fanquake: Merge bitcoin/bitcoin#26047: guix: use git-minimal over git 02:19 < bitcoin-git> [bitcoin] fanquake merged pull request #26047: guix: use git-minimal over git (master...guix_use_git_minimal) https://github.com/bitcoin/bitcoin/pull/26047 02:20 -!- __afmencken [~afmencken@69.4.234.83] has quit [Ping timeout: 265 seconds] 02:34 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye] 02:36 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 03:23 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev 03:27 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds] 03:45 -!- gleb1068924 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 04:05 < bitcoin-git> [bitcoin] fanquake closed pull request #25948: doc: added note about brew and Qt 6 on macOS (master...docs-macos-qt6) https://github.com/bitcoin/bitcoin/pull/25948 04:10 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 04:17 < bitcoin-git> [bitcoin] fanquake opened pull request #26073: build: fix depends bdb compilation for BSDs (master..._BSD_bdb_compilation) https://github.com/bitcoin/bitcoin/pull/26073 04:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #26074: refactor: Set RPCArg options with designated initializers (master...2209-rpc-refactor-🐿) https://github.com/bitcoin/bitcoin/pull/26074 04:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a361c6cae766...94d17845d04e 04:36 < bitcoin-git> bitcoin/master 2d0b4e4 Vasil Dimov: init: allow startup with -onlynet=onion -listenonion=1 04:36 < bitcoin-git> bitcoin/master 94d1784 fanquake: Merge bitcoin/bitcoin#24991: init: allow startup with -onlynet=onion -list... 04:36 < bitcoin-git> [bitcoin] fanquake merged pull request #24991: init: allow startup with -onlynet=onion -listenonion=1 (master...onlynet_onion_with_listenonion_is_ok) https://github.com/bitcoin/bitcoin/pull/24991 04:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:09 -!- gleb1068924 [~gleb@178.150.137.228] has quit [Ping timeout: 264 seconds] 05:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94d17845d04e...141540a71f51 05:19 < bitcoin-git> bitcoin/master faa3d38 MacroFake: refactor: Pass reference to LookUpStats 05:19 < bitcoin-git> bitcoin/master 141540a MacroFake: Merge bitcoin/bitcoin#25222: refactor: Pass reference to LookUpStats 05:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25222: refactor: Pass reference to LookUpStats (master...2205-ref-stat-😶) https://github.com/bitcoin/bitcoin/pull/25222 05:23 -!- gleb1068924 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 05:36 < bitcoin-git> [bitcoin] fanquake opened pull request #26075: contrib: remove 32bit linux code from release scripts (master...remove_32bit_linux_scripts) https://github.com/bitcoin/bitcoin/pull/26075 06:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d116:387a:e9f6:d613] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] Sjors opened pull request #26076: Switch hardened derivation marker to h in descriptors (master...2022/09/descriptors_h) https://github.com/bitcoin/bitcoin/pull/26076 06:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #24737: Remove taproot chain param (master...2204-rem-code-🥊) https://github.com/bitcoin/bitcoin/pull/24737 06:34 -!- fjMSX [~hypni2p@128-68-149-52.broadband.corbina.ru] has joined #bitcoin-core-dev 06:42 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 06:45 -!- __afmencken [~afmencken@69.4.234.76] has joined #bitcoin-core-dev 06:48 -!- af_mencken [~afmencken@69.4.234.104] has quit [Ping timeout: 250 seconds] 06:50 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 06:54 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 268 seconds] 07:03 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 07:04 -!- mikehu44_ [~quassel@159.65.11.175] has joined #bitcoin-core-dev 07:04 -!- mikehu44 [~quassel@159.65.11.175] has quit [Ping timeout: 268 seconds] 07:06 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:42 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev 07:43 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/141540a71f51...3a7e0a210c86 07:43 < bitcoin-git> bitcoin/master 00eeb31 James O'Beirne: scripted-diff: rename CChainState -> Chainstate 07:43 < bitcoin-git> bitcoin/master 3a7e0a2 glozow: Merge bitcoin/bitcoin#24513: CChainState -> Chainstate 07:43 < bitcoin-git> [bitcoin] glozow merged pull request #24513: CChainState - Chainstate (master...2022-03-chainstate-rename) https://github.com/bitcoin/bitcoin/pull/24513 07:47 < bitcoin-git> [bitcoin] fanquake opened pull request #26077: guix: switch from `guix environment` to `guix shell` (master...guix_shell_over_environment) https://github.com/bitcoin/bitcoin/pull/26077 08:04 -!- mikehu44_ [~quassel@159.65.11.175] has quit [Ping timeout: 265 seconds] 08:14 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:14 < jamesob> wow, it actually happened. CChainState is now Chainstate. Feel free to direct all rebase ire at me 08:17 < bitcoin-git> [bitcoin] jamesob reopened pull request #24364: refactor: remove duplicate code from BlockAssembler (master...2022-02-ba-dup-code) https://github.com/bitcoin/bitcoin/pull/24364 08:18 < halosghost> lol 08:18 < halosghost> am I understanding the history correctly that the prefix-C was a hungarian-notation holdover? 08:18 < halosghost> (namely, for “class”) 08:19 < jamesob> halosghost: yeah, Satoshi had a penchant for it 08:21 < halosghost> to be fair, a lot of people at the time did ☺ 08:23 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:24 -!- Guyver2__ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 08:24 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:26 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 268 seconds] 08:29 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:29 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:35 -!- jamesob [~jamesob@pool-108-51-103-2.washdc.fios.verizon.net] has quit [Ping timeout: 265 seconds] 08:52 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3a7e0a210c86...c85688347eac 08:52 < bitcoin-git> bitcoin/master d26c3cc furszy: wallet: bugfix, load wallet with an unknown descriptor cause fatal error 08:52 < bitcoin-git> bitcoin/master e066763 furszy: wallet: coverage for loading an unknown descriptor 08:52 < bitcoin-git> bitcoin/master c856883 Andrew Chow: Merge bitcoin/bitcoin#26021: wallet: bugfix, load a wallet with an unknown... 08:53 < bitcoin-git> [bitcoin] achow101 merged pull request #26021: wallet: bugfix, load a wallet with an unknown/corrupt descriptor causes a fatal error (master...2022_wallet_fix_descriptor_unserialization) https://github.com/bitcoin/bitcoin/pull/26021 08:53 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:54 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye] 09:01 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 09:03 -!- jamesob [~jamesob@151.200.19.227] has joined #bitcoin-core-dev 09:15 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c85688347eac...29d540b7ada8 09:15 < bitcoin-git> bitcoin/master b50a4b7 Cory Fields: build: quiet warnings in system headers installed from homebrew 09:15 < bitcoin-git> bitcoin/master 29d540b fanquake: Merge bitcoin/bitcoin#26070: build: Quiet warnings in symlinked headers in... 09:15 < bitcoin-git> [bitcoin] fanquake merged pull request #26070: build: Quiet warnings in symlinked headers installed from homebrew (master...fix-brew-usrlocal) https://github.com/bitcoin/bitcoin/pull/26070 09:21 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 09:22 -!- fjMSX [~hypni2p@128-68-149-52.broadband.corbina.ru] has quit [Remote host closed the connection] 09:24 < fanquake> wallet / psbt concerned folks, we need some opinons in regards to #25856 vs #25858 09:24 <@gribble> https://github.com/bitcoin/bitcoin/issues/25856 | [BugFix] Make PSBT serializations 174 compliant by excluding empty taptree from serialization by JeremyRubin · Pull Request #25856 · bitcoin/bitcoin · GitHub 09:24 <@gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub 09:30 -!- fjMSX [~hypni2p@128-68-149-52.broadband.corbina.ru] has joined #bitcoin-core-dev 09:41 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:03 -!- DeanGuss [~dean@user/deanguss] has quit [Quit: buhbye] 10:11 -!- Copinmalin [~Copinmali@51.91.208.235] has joined #bitcoin-core-dev 10:13 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #bitcoin-core-dev 10:13 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host] 10:13 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-core-dev 10:36 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:38 -!- gleb1068924 [~gleb@178.150.137.228] has quit [Ping timeout: 268 seconds] 10:42 -!- gleb1068924 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 10:48 -!- Guest94 [~Guest94@103.216.143.114] has joined #bitcoin-core-dev 10:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 10:53 -!- Guest94 [~Guest94@103.216.143.114] has quit [Client Quit] 11:07 -!- Copinmalin [~Copinmali@51.91.208.235] has quit [Ping timeout: 252 seconds] 11:15 -!- Copinmalin [~Copinmali@51.91.208.235] has joined #bitcoin-core-dev 11:21 -!- dougefish [~dougefish@77.137.68.0] has quit [Remote host closed the connection] 11:25 -!- Copinmalin [~Copinmali@51.91.208.235] has quit [Quit: Client closed] 11:48 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 12:16 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:27 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 13:29 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 258 seconds] 13:35 -!- dougefish [~dougefish@2a00:a040:199:52c1:1ac0:4dff:fe34:3985] has joined #bitcoin-core-dev 14:23 -!- Guyver2__ [Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:25 < bitcoin-git> [bitcoin] brunoerg opened pull request #26078: p2p: return `CSubNet` in `LookupSubNet` (master...2022-09-csubnet-lookup) https://github.com/bitcoin/bitcoin/pull/26078 14:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d116:387a:e9f6:d613] has quit [] 14:44 -!- realies [~realies@user/realies] has quit [Quit: ~] 15:04 < bitcoin-git> [bitcoin] hebasto opened pull request #26079: Revert "doc: note that brew installed qt is not supported" (master...220913-brew) https://github.com/bitcoin/bitcoin/pull/26079 15:05 -!- halosghost [~halosghos@user/halosghost] has quit [Ping timeout: 260 seconds] 15:09 < bitcoin-git> [bitcoin] ishaanam opened pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081 15:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 15:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 15:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:46 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:51 < bitcoin-git> [bitcoin] luke-jr opened pull request #26082: RPC/Wallet: Access wallets via interfaces::Wallet (master...rpc_wallet_interfaces) https://github.com/bitcoin/bitcoin/pull/26082 15:51 < bitcoin-git> [bitcoin] glozow merged pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081 15:52 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29d540b7ada8...57a17de05ea2 15:52 < bitcoin-git> bitcoin/master 6f8e381 ishaanam: sendall: check if the maxtxfee has been exceeded 15:52 < bitcoin-git> bitcoin/master 57a17de Gloria Zhao: Merge pull request #26081 from ishaanam/sendall_maxtxfee 15:52 < glozow> OMG that was a total accident, fat finger on mobile 15:57 < luke-jr> people have GitHub accounts logged into on mobile? <.< 15:57 < achow101> huh. didn't know that button still worked 15:58 < luke-jr> huh, the merge is GPG-signed 15:58 < luke-jr> how is that possible? :x 15:59 < achow101> I think the github webui has a gpg key 15:59 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 16:00 < sipa> ... the correct one? 16:00 < achow101> no, I expect CI will fail verify-commits now 16:00 < luke-jr> ah, it's not her normal one 16:00 < glozow> no way, it should be on my yubikey 16:01 < luke-jr> 8 minutes now. probably should just revert and deal with verify-commits consequences :x 16:02 < luke-jr> (or branch off 24.x from the older commit and deal with the PR as-is) 16:02 -!- jespada [~jespada@cpc121060-nmal24-2-0-cust249.19-2.cable.virginm.net] has quit [Ping timeout: 252 seconds] 16:03 < sipa> can't you force push the previous state? 16:03 < achow101> should I try? 16:04 < achow101> going to try force pushing 29d540b7ada890dd588c4825d40c27c5e6f20061 16:04 < achow101> goign to need an owner to do that: remote: error: Cannot force-push to this protected branch 16:04 < luke-jr> sipa: it will break anyone who pulled in the last 10 mins 16:06 < luke-jr> otoh, maybe we should take advantage of this to treat it as a malicious push to the git repo 16:06 < luke-jr> and see who notices / can adapt 16:06 < luke-jr> I assume in that scenario, we'd force push 16:07 < luke-jr> is laanwj the only one with needed access? 16:07 < achow101> I believe fanquake can force too 16:10 < sipa> i may still be able to, should i try? 16:11 < luke-jr> IMO yes, but I'm treating it as malicious (no offense to glozow intended) 16:11 < achow101> sipa: I think so 16:11 < glozow> I will open a revert. If somebody is able to push, please do. 16:12 < luke-jr> glozow: no point in a revert if sipa force pushes 16:12 < luke-jr> though the PR itself will need to be reopened 16:12 < sipa> give me a minute 16:12 < luke-jr> re-created* 16:13 < bitcoin-git> [bitcoin] sipa force pushed 0 commit to master: https://github.com/bitcoin/bitcoin/compare/57a17de05ea2...29d540b7ada8 16:13 < bitcoin-git> [bitcoin] glozow opened pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083 16:13 < luke-jr> glozow: might I suggest a second unprivileged github account for your mobile? 16:13 < achow101> that appears to have worked 16:14 < luke-jr> also confirming the force push worked as results in the expected head commit 16:16 < glozow> luke-jr: yes indeed, I will need to stop having my account on mobile, lessons learned. Sincerest apologies! 16:16 < bitcoin-git> [bitcoin] glozow closed pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083 16:20 < glozow> Thank you sipa! I’m very, very sorry, it was an accident 16:21 < sipa> There is a setting to require signed commits, though I don't know how it works. 16:21 < sipa> Or whether it applies to all commits or just the merge commits, or which keys it would accept. 16:22 < achow101> sipa: I believe that would apply to all commits 16:22 < achow101> https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-signed-commits 16:24 < achow101> we could probably turn on "Require pull request reviews before merging"? 16:25 < luke-jr> too bad there's no "don't allow merging via GitHub" XD 16:25 < achow101> although that would require at least one person to use the "review approval" thing as it probably won't understand ACKs. At least we could set it to 1 and before merging a pr, the maintainer needs to click that button before they can merge it 16:26 < luke-jr> hmm 16:26 < luke-jr> does it enforce these policies on git pushes at all? 16:27 < luke-jr> maybe we can enable an unsatisfiable one to just block the button 16:28 < achow101> it does block on git pushes too 16:29 < luke-jr> oh well :/ 16:30 < achow101> it would have to be some policy which can be disabled per pr right before merging 16:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds] 16:41 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev 16:55 < _aj_> achow101: drahtbot could translate ACKs into a review approval by drahtbot, i suppose 17:10 < bitcoin-git> [bitcoin] ishaanam opened pull request #26084: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26084 17:14 < luke-jr> are there really that many merged PRs that didn't get at least one "review approval"? XD 17:21 -!- Guest15 [~Guest15@109-92-40-91.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev 17:22 < achow101> i haven't really noticed people using the approve button, other than spammers 17:41 < luke-jr> … 17:51 -!- kexkey [~kexkey@178.249.214.10] has quit [Quit: kexkey] 18:41 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev 18:42 -!- Guest15 [~Guest15@109-92-40-91.dynamic.isp.telekom.rs] has quit [Quit: Client closed] 18:58 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds] 19:14 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [] 19:16 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev 19:21 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 265 seconds] 19:40 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 19:47 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev 19:52 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 244 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:09 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 21:15 -!- fjMSX [~hypni2p@128-68-149-52.broadband.corbina.ru] has quit [Remote host closed the connection] 22:28 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 23:00 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev 23:03 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 23:05 -!- _apex_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 264 seconds] 23:15 < fanquake> I'll delete the revert-26081-sendall_maxtxfee branch that is hanging around 23:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] --- Log closed Wed Sep 14 00:00:18 2022