--- Log opened Thu Sep 22 00:00:26 2022
00:12 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
00:22 -!- dongcarl4 [~dongcarl@cpe-66-65-184-36.nyc.res.rr.com] has quit [Quit: Ping timeout (120 seconds)]
00:23 -!- dongcarl [~dongcarl@cpe-66-65-184-36.nyc.res.rr.com] has joined #bitcoin-core-dev
00:49 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 258 seconds]
00:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
00:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
00:53 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
01:09 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
01:14 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 264 seconds]
01:24 < bitcoin-git> [bitcoin] yancyribbens opened pull request #26154: refactor: move coin_control variable to test setup section (master...move-coin-control-setup) https://github.com/bitcoin/bitcoin/pull/26154
01:29 -!- Earnestly [~earnest@user/earnestly] has quit [Quit: WeeChat 3.6]
01:31 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:49 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
01:54 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 265 seconds]
02:00 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
02:02 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
02:03 -!- kexkey [~kexkey@static-198-54-132-156.cust.tzulo.com] has quit [Ping timeout: 264 seconds]
02:05 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev
02:21 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev
02:21 -!- Guest842 [~Guest84@183.91.7.244] has joined #bitcoin-core-dev
02:22 -!- Guest842 [~Guest84@183.91.7.244] has quit [Client Quit]
02:22 -!- quannn [~quannn@222.254.34.75] has joined #bitcoin-core-dev
02:36 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
02:37 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
02:41 -!- quannn [~quannn@222.254.34.75] has quit [Quit: Client closed]
02:42 -!- Bejita [~Bejita@120.159.133.140] has joined #bitcoin-core-dev
02:48 -!- Bejita [~Bejita@120.159.133.140] has quit [Quit: Client closed]
02:56 -!- NorrinRadd [~me@188.215.95.37] has quit [Ping timeout: 250 seconds]
02:56 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
03:01 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
03:16 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
03:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
03:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
03:48 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
03:53 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 268 seconds]
04:39 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
04:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:05 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 258 seconds]
05:06 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
05:12 -!- youranonnima [~youranonn@2a02-a453-293-1-d0f3-eeeb-9065-3762.fixed6.kpn.net] has joined #bitcoin-core-dev
05:16 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
05:17 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
05:21 < youranonnima> https://twitter.com/_n1rna/status/1572915224319234052
05:22 < youranonnima> We are asking all communities to spread the word and help us - Iranians, to be heard by the world! There is an all out war happening on the streets of Iran.
05:22 < youranonnima> Stand with Iranians. We need you to help us get our Country back from Mullahs!
05:22 < youranonnima> #OpIran
05:22 < youranonnima> #MahsaAmini
05:26 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
05:30 -!- NorrinRadd [~me@188.215.95.184] has joined #bitcoin-core-dev
05:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:48:2dd4:18bc:454c] has joined #bitcoin-core-dev
05:49 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
05:53 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 264 seconds]
06:13 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev
06:14 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:32 -!- youranonnima [~youranonn@2a02-a453-293-1-d0f3-eeeb-9065-3762.fixed6.kpn.net] has quit [Ping timeout: 252 seconds]
06:42 -!- Guest8336 [~Guest83@207.38.129.117] has joined #bitcoin-core-dev
06:45 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2b2c970627f7...590d20644458
06:45 < bitcoin-git> bitcoin/master 55aad5f fanquake: build: remove stdio.h from header checks
06:45 < bitcoin-git> bitcoin/master 590d206 fanquake: Merge bitcoin/bitcoin#26150: build: remove stdio.h from header checks
06:45 < bitcoin-git> [bitcoin] fanquake merged pull request #26150: build: remove stdio.h from header checks (master...remove_stdio_h) https://github.com/bitcoin/bitcoin/pull/26150
06:47 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
06:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:53 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:53 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:56 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/590d20644458...100949af0e25
06:56 < bitcoin-git> bitcoin/master fa64228 MacroFake: fuzz: Avoid timeout in bitdeque fuzz target
06:56 < bitcoin-git> bitcoin/master fa4ba04 MacroFake: fuzz: Remove no-op call to get()
06:56 < bitcoin-git> bitcoin/master 100949a fanquake: Merge bitcoin/bitcoin#26012: fuzz: Avoid timeout in bitdeque fuzz target
06:56 < bitcoin-git> [bitcoin] fanquake merged pull request #26012: fuzz: Avoid timeout in bitdeque fuzz target (master...2209-fuzz-timeout-🏺) https://github.com/bitcoin/bitcoin/pull/26012
06:56 -!- Guest8336 [~Guest83@207.38.129.117] has quit [Ping timeout: 252 seconds]
07:04 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
07:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
07:17 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
07:37 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
07:49 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
07:54 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds]
08:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
08:07 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
08:18 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
08:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
08:36 -!- gleb10689249 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
08:47 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
09:24 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
09:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
09:36 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 268 seconds]
09:37 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev
09:40 -!- amovfx_ [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
09:40 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-dev
09:45 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has left #bitcoin-core-dev []
09:46 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-dev
09:55 -!- gleb [sid306870@id-306870.lymington.irccloud.com] has quit []
09:56 -!- gleb10689249 [~gleb@178.150.137.228] has left #bitcoin-core-dev []
09:56 -!- gleb10689249 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
09:56 -!- gleb10689249 [~gleb@178.150.137.228] has left #bitcoin-core-dev []
09:58 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
09:59 < gleb> testing
10:05 < laanwj> dongcarl: i don't think so; though i'm not 100% sure how the permissions for the new kind of project board are handled, for the old kind of project board the only way is write access to the entire repo
10:05 < achow101> #proposedmeetingtopic: acceptable runtimes of new benchmarks
10:06 < laanwj> contrats on the 24.0 splitoff/tag btw
10:09 < laanwj> i've added the 24.x branch to the bot so it will show merges there too
10:12 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:12 < _aj_> laanwj, dongcarl: you're meant to be able to give individuals access to classic project boards https://docs.github.com/en/organizations/managing-access-to-your-organizations-project-boards/managing-an-individuals-access-to-an-organization-project-board
10:20 < instagibbs> gleb, testong
10:22 < laanwj> _aj_: thanks, will try
10:25 < laanwj> so it seems to work for project boards at organization level
10:26 < laanwj> going to the settings of a project board at repository level just gets me the repository permissions
10:26 < laanwj> can migrate it ofcourse
10:30 < laanwj> dongcdd
10:30 < _aj_> laanwj: but the projects are at organiztion level?
10:31 < laanwj> dongcarl: migrated the project to https://github.com/orgs/bitcoin/projects/3 and added TheCharlatan explicitly with write access
10:31 < _aj_> laanwj: migrating seems fine too though!
10:31 < laanwj> _aj_: only two of the, now https://github.com/orgs/bitcoin/projects
10:31 < laanwj> the others are at repository level
10:32 < laanwj> i'm happy to migrate them too if someone asks
10:33 < _aj_> laanwj: oh :( github tricked me
10:34 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:35 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
10:40 < amovfx> test
10:40 < instagibbs> amovfx, you got it
10:41 < amovfx> ah sweet! thanks _aj_ that worked
10:41 < _aj_> amovfx: cool; it's an anti-spam thing on some bitcoin channels
10:41 < amovfx> yea makes sense
10:41 < amovfx> meeting is in an hour 20 right?
10:41 < amovfx> just want to make sure I'm timezoning correctly
10:42 < instagibbs> believe so
10:44 < amovfx> osom,
10:46 < bitcoin-git> [bitcoin] theStack opened pull request #26156: test: check that `listdescriptors` descriptor strings are sorted (master...202209-test-rpc-check_sorted_listdescriptors_strings) https://github.com/bitcoin/bitcoin/pull/26156
10:46 < laanwj> yes
10:47 < amovfx> I don't suppose I could grab some guidance on what to focus on to be a core dev. I'm noob, right now I'm doing the blockchain commons learn bitcoin by the commandline, reviewing prs, and doing the pr review club
10:48 < amovfx> I guess I'm looking for a goal, or a pre defined task, of "the project needs this"
10:48 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
10:48 < sipa> https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
10:49 < sipa> There are issues label "good first issue".
10:49 < bitcoin-git> [bitcoin] dhruv closed pull request #25354: [crypto] Reduce wasted pseudorandom bytes in ChaCha20 (master...chacha20-partial-blocks) https://github.com/bitcoin/bitcoin/pull/25354
10:49 < amovfx> ah yes, those are hard to swipe, Ill keep my eye on those closer, ty
10:49 < instagibbs> especially test-enhacement issues, those are always very appreciated
10:51 < _aj_> https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Up+for+grabs%22  -- maybe too
11:07 -!- aleggg [~aleggg@179.178.112.239] has quit [Ping timeout: 252 seconds]
11:11 < bitcoin-git> [bitcoin] benthecarman opened pull request #26157: rpc: Fix ordering of arguments in listtransactions help message (master...fix-list-txs-help) https://github.com/bitcoin/bitcoin/pull/26157
11:11 < bitcoin-git> [bitcoin] benthecarman closed pull request #26157: rpc: Fix ordering of arguments in listtransactions help message (master...fix-list-txs-help) https://github.com/bitcoin/bitcoin/pull/26157
11:12 < amovfx> Is there a conflict when configureing with sanitizers
11:13 < amovfx> ?
11:13 < amovfx> I'm running ../configure --without-bdb --without-gui --enable-c++17 --enable-fuzz --with-sanitizers=address,fuzzer,undefined CC=clang CXX=clang++
11:13 < amovfx> and it works
11:13 < amovfx> but if I add thread, it doesnt
11:13 < amovfx> ../configure --without-bdb --without-gui --enable-c++17 --enable-fuzz --with-sanitizers=address,fuzzer,undefined,thread CC=clang CXX=clang++
11:14 < amovfx> checking whether C++ compiler accepts -fsanitize=address,fuzzer,undefined,thread... no
11:14 < amovfx> configure: error: compiler did not accept requested flags
11:14 < sipa> yes, you cannot combine the thread sanitizer with most other sanitizers
11:14 < amovfx> ahhh okay
11:14 < amovfx> so I have to alternate the config for what I want
11:14 < amovfx> okay thats cool, cause thread by itself worked
11:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:48:2dd4:18bc:454c] has quit [Ping timeout: 268 seconds]
11:23 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
11:23 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
11:25 -!- amovfx_ [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
11:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:28 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Ping timeout: 265 seconds]
11:36 < fanquake> laanwj: thanks for updating the bot
11:38 -!- Guest48 [~Guest48@38.96.179.198] has joined #bitcoin-core-dev
11:40 -!- Guest48 [~Guest48@38.96.179.198] has quit [Client Quit]
11:43 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
11:44 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 258 seconds]
11:47 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 246 seconds]
11:54 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
11:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ade2:76d3:1280:3ac0] has joined #bitcoin-core-dev
11:56 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
12:00 < laanwj> #startmeeting
12:00 <@core-meetingbot> Meeting started Thu Sep 22 19:00:08 2022 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:00 <@core-meetingbot> Available commands: action commands idea info link nick
12:00 < Murch> Hi
12:00 < hebasto> hi
12:00 < fanquake> hi
12:00 < luke-jr> hi
12:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
12:00 < furszy> hi
12:00 < laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:00 < laanwj> hi
12:00 < achow101> hi
12:01 < lightlike> hi
12:01 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
12:01 < glozow> hi
12:01 < amovfx_> hi
12:01 < laanwj> welcome to the weekly general bitcoin-core-dev meeting
12:02 < laanwj> on topic has been proposed: acceptable runtimes of new benchmarks (achow101)
12:02 < sipa> hi
12:02 < laanwj> any lastminute ones?
12:02 < sipsorcery> hi
12:03 < fanquake> rc1 bins!
12:03 < warren> hi
12:03 < laanwj> 24.0 was split off a few days ago, and v24.0rc1, so if you haven't yet please start your guix builder
12:03 < jonatack> hi
12:03 < amovfx_> is guix builder, just building with gui?
12:03 < fanquake> ~10 builders submitted sigs so far, and detached sigs are up for codesigning
12:03 < emzy> hi
12:04 < sipa> amovfx: guix is the build environment we use for deterministic/reproducible release binaries
12:04 < sipa> it is entirely unrelated to the gui
12:04 < laanwj> i think we'll want to go back to discussing high priority for review now that the branch was split off
12:04 < amovfx_> ty
12:04 < luke-jr> well, it does build the gui, but what sipa said otherwise ;p
12:04 -!- Zenton [~user@user/zenton] has quit [Read error: Connection reset by peer]
12:05 < sipa> it also builds the non-gui!
12:05 < luke-jr> right
12:05 < sipa> https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/README.md for more information
12:05 < jonatack> amovfx_: see contrib/guix/README.md
12:05 < laanwj> #topic High priority for review
12:05 <@core-meetingbot> topic: High priority for review
12:06 < amovfx_> looking at that now, ty
12:06 < laanwj> https://github.com/orgs/bitcoin/projects/1 has 5 blockers, 3 chasing concept ACK 
12:06 < laanwj> probably needs update
12:07 < laanwj> anything to add/remove?
12:07 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev
12:07 < jonatack> #23433 may be getting close
12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/23433 | Addrman unit test failures · Issue #23433 · bitcoin/bitcoin · GitHub
12:08 < jonatack> #23443 sorry
12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
12:08 < laanwj> great!!!
12:09 < fanquake> I'll probably throw #25391 back in now that we're branched off
12:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25391 | guix: Use LTO to build releases by fanquake · Pull Request #25391 · bitcoin/bitcoin · GitHub
12:09 < fanquake> Most toolchain stuff is sorted now. The windows build is still a bit hairy, but otherwise this works, and is ready for more thoughts (in regards to release use) / benchmarking / review.
12:10 < laanwj> makes sense
12:10 < glozow> #25038 for me please!
12:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/25038 | policy: nVersion=3 and Package RBF by glozow · Pull Request #25038 · bitcoin/bitcoin · GitHub
12:10 < achow101> #23417 for me
12:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/23417 | wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101 · Pull Request #23417 · bitcoin/bitcoin · GitHub
12:11 < laanwj> glozow: added-should it be for blockers or chasing concept ACK?
12:11 < glozow> laanwj: chasing concept ACK i think
12:12 -!- Zenton [~user@user/zenton] has quit [Read error: Connection reset by peer]
12:12 < glozow> thanks :)
12:12 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev
12:12 < laanwj> achow101: looks like it was already on the list?
12:13 < fanquake> laanwj: i may have just added it
12:13 < laanwj> okay!
12:14 < laanwj> anything else for high prio?
12:14 < laanwj> if not we'll go to next topic
12:15 < warren> (do I ask questions at the end?)
12:15 < laanwj> #topic acceptable runtimes of new benchmarks (achow101)
12:15 <@core-meetingbot> topic: acceptable runtimes of new benchmarks (achow101)
12:16 < laanwj> warren: depends on the kind of question? 
12:16 < laanwj> i mean if it's a big one then it'd make sense to make it a separate topic
12:16 < achow101> We've been adding some benchmarks for the wallet which run some pretty slow behavior. Since we run all of the benchmarks in make check, there's been some questions on how slow an entire benchmark can be, including setup and teardown
12:17 < sipa> we could run the make-check benchmarks with a lower -min-time ?
12:17 < sipa> Because we don't really care about the benchmarking aspect, just that the code gets exercised.
12:17 < lightlike> we only run one iteration already within "make check", right?
12:17 < laanwj> sipa: we already run them for one iteration
12:17 < sipa> I vaguely recall a PR that added an option for this actually.
12:18 < laanwj> sipa: the problem is that some tests take significant time per iteration
12:18 < sipa> oh
12:18 < sipa> i see
12:18 < achow101> there's the time per iteration, and also time for setting up the wallet
12:18 < achow101> e.g. a benchmark for a wallet with many txs also requires spending time before the benchmark making those txs
12:18 < laanwj> the original idea of the benchmarks was that iterations would take neglible time by themselves
12:19 -!- amovfx_ [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Read error: Connection reset by peer]
12:19 < laanwj> but yes, that's different for the wallet ones
12:19 < sipa> right, the one-time setup cost per benchmark
12:19 < furszy> I think that achow101 refers to benchmarks that require time consuming setups, and not the process that gets timed.
12:20 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
12:20 < furszy> message got out late :p..
12:20 < fanquake> If benches are going to be considerably more expensive than the others, and not necessarily valuable for everyone to run every make check, we should gate them behind some flag / option
12:21 < lightlike> maybe have a set of "extended" benchmarks that are not part of "make check", similar to  the existing solution for long-running functional tests?
12:21 < fanquake> I don't think we want to add more weight to make check itself
12:21 < fanquake> There are already expensive things run there that ideally could be split out. i.e running libsecp test suite every time on never-changing code
12:21 < achow101> what's the purpose of running benchmarks in make check?
12:21 < sipa> making sure the benchmarks actually run
12:22 < sipa> i guess the policy (intentional or not) we have is that "make check" runs all compiled code we have?
12:22 < sipa> it doesn't run functional tests, but does run unit tests
12:22 < laanwj> right, there have been crashes in the benchmarks in the past, running them for one iteration makes sure thre are no obvious crashes at least
12:22 < _aj_> doesn't run the fuzz tests?
12:22 < sipa> and bitcoin-tx tests
12:23 < sipa> hmm, it doesn't run the fuzz tests, good point
12:23 < achow101> that could also be achieved with another ci job
12:23 < laanwj> the fuzz tests would reqiire external data (e.g. corpuses) so it's not very practical
12:23 < _aj_> would be nice to have 'make check' run the cheap benchmarks, at any rate?
12:23 < sipa> yeah the most important thing is that CI at least occasionally runs all benchmark code
12:24 < furszy> isn't the CI running in debug mode? (which makes benchmarks run much slower)
12:26 < achow101> yes, but slow CI is nothing new
12:28 < achow101> anyways, seems like the consensus is to have make check just not run all of the benchmarks
12:28 < laanwj> i think that's the only proposed solution, too
12:29 < sipa> i think that's reasonable
12:29 < warren> sounds like there should be different levels of "check"?
12:29 < jonatack> yes, as long as a CI task does run them
12:30 < warren> Somewhat related, when Fedora packaged bitcoin core they insisted on running "make check" during every package build. I tried to argue even Bitcoin Core's own binary distribution process doesn't do that because it's way too slow?
12:30 < furszy> if we have to run some of the benchmarks, couldn't we just run them in a different CI job without debug mode?
12:30 < warren> I didn't check for a year but at some point I had "make check" succeed on only faster machines but fail on slow machines due to a timeout of some sort, which would cause the Fedora package build to fail.
12:31 < achow101> furszy: I think we would still want debug enabled as debug will also execute code that we may care about
12:31 < achow101> (since the purpose is to look for crashes/programming errors rather than actually benchmarking)
12:31 < warren> I suppose "make check" failing on a slow machine with a timeout should be considered a bug?
12:31 < jonatack> at least benchmarks ran last, so on my slow laptop, i would halt the make check run at the benchmark step
12:31 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:31 < furszy> achow101: hmm k
12:32 < laanwj> warren: yes, imo
12:32 < laanwj> warren: but it would be fixed by the same solution proposed now
12:32 < warren> nice
12:32 < achow101> I don't think guix runs any of the tests or benchmarks?
12:32 < achow101> other than symbol and security checks
12:33 < laanwj> no, guix doesn't
12:33 < sipa> really?
12:33 < laanwj> it woudn't make much sense with cross compiling
12:33 < warren> yeah, can we have an official recommendation for distros "we don't recommend using make check since we don't use it in our own binary distro procedure"?
12:33 < sipa> we don't run the tests in guix builds?
12:33 < sipa> ah, yeah, cross compilation is an issue
12:34 < sipa> @warren as far as i'm concerned, that's up to them
12:34 < laanwj> wait, we absolutely recommend runing make check
12:34 < laanwj> if you can
12:34 < warren> i argue it isn't worth adding hours (?) of build time for distributors. it could be separately tested in their case.
12:34 < laanwj> we do ship test_bitcoin fwiw
12:34 < sipa> if they don't mind the time it takes on their builders to run all the tests (even ones beyond make check), so much the better
12:34 < laanwj> so people can run it *on their own machine* before running bitcoind
12:34 < laanwj> if they want
12:34 < fanquake> guix build targets: https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/libexec/build.sh#L261-L285
12:34 < laanwj> that's the unit tests and most important part; they could also run the benchmarks, ofc
12:35 < warren> with this proposed benchmarks change "make check" would become a lot faster?
12:35 < sipa> wouldn't it make sense to run unit tests in guix on platforms where host=target ?
12:35 < laanwj> sipa: i'm not sure
12:35 < achow101> warren: yes
12:35 < warren> excellent
12:36 < _aj_> warren: (are you sure that was make check / unit tests, and not the functional tests? make check should be minutes, not hours)
12:36 < laanwj> you could always run the generated test_bitcoin if you want to check the result
12:36 < laanwj> i'm not sure running the code it generates is within the scope of deterministic building
12:36 < warren> that's what I argued
12:37 < warren> _aj_: I haven't looked in over a year
12:37 < sipa> @laanwj True
12:38 < warren> at the moment I'm part of a rebel group trying to encourage the entire distro to take build reproducibility seriously. we need to demonstrate such a bootstrap outside their infra. will take a while.
12:38 < laanwj> sipa: i mean i'm not strongly against it either, but making behavior depend on the host platform, for example, is a potential source of non-determinism
12:39 < sipa> fair enough
12:40 < laanwj> we've drifted from the topic a bit :) any other topics?
12:41 < warren> I was curious if anyone knows what's going on with BIP324?
12:41 < sipa> yes
12:41 < sipa> we've been working on updating the draft in private (dhruv, real-or-random, me)
12:41 -!- gossie [~gossie@2001:1c02:11e:3500:df25:6321:8260:d9be] has quit [Ping timeout: 264 seconds]
12:41 < sipa> should have something to show very soon
12:42 < warren> Will it end up using the same p2p port as current day clearnet connections?
12:42 < warren> Will it have a different connection limit bucket?
12:42 < warren> anyhow excited to see the next draft!
12:43 < sipa> well, port 8333 is no longer preferred for outbound connections, though it's still the default for listening
12:43 < laanwj> dhruv was asking about testing #24545 a few days ago
12:43 <@gribble> https://github.com/bitcoin/bitcoin/issues/24545 | BIP324: Enable v2 P2P encrypted transport by dhruv · Pull Request #24545 · bitcoin/bitcoin · GitHub
12:43 < sipa> the interaction with bip324 i'd say is an implementation detail; the spec doesn't care about what port it runs on, and bip324 capable listeners can accept both on the same port
12:44 -!- dougefish_ [~dougefish@2a00:a041:3c18:b400:1ac0:4dff:fe34:3985] has quit [Remote host closed the connection]
12:44 < sipa> dhruv's implementation seems to work, i'm running it on bitcoin.sipa.be and there are a few other nodes running it
12:44 < sipa> i've personally focused more on the spec than the implementation though
12:44 < sipa> so far
12:46 < warren> thank you
12:46 < laanwj> yes i think that's the important point, they can share the same port
12:47 < laanwj> the connection limit bucket is not affected at all by the kind of connection, whether it should is something for discussion but probably not for the initial implementation
12:47 < sipa> yeah
12:47 < warren> right
12:48 < laanwj> any other topics for today?
12:49 < fanquake> Just making the rc1 bins available shortly, given we've had a good number of builds. Will be good to get some people testing rc1
12:49 < sipa> are the only rc2 backported fixes test things so far?
12:49 < laanwj> i'll get building
12:50 < fanquake> a couple bug fixes, 1 in the wallet, 1 config option related
12:50 < sipa> ok
12:51 < laanwj> #endmeeting
12:51 <@core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:51 <@core-meetingbot> Meeting ended Thu Sep 22 19:51:09 2022 UTC.  
12:51 <@core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-09-22-19.00.moin.txt
12:51 -!- dougefish [~dougefish@2a00:a041:3c18:b400:1ac0:4dff:fe34:3985] has joined #bitcoin-core-dev
12:51 < fanquake> the miniscript fix needs backporting, maybe the fuzz fix for the bitdeque
12:51 < fanquake> we'll keep collecting for rc2
12:51 < achow101> fyi I will be unavailable for the wallet meeting tomorrow, if someone else would like to run it, that'd be great.
12:52 < amovfx> Thanks everyone, are there any other meetings I should be aware of, i do this, and pr review club
12:52 < glozow> it would also be good to get #25858 if people are willing to review?
12:52 <@gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
12:52 < amovfx> and just learned of the wallet
12:52 < amovfx> is that here?
12:52 < achow101> amovfx: yes, we have a wallet meeting here every other friday
12:52 < amovfx> cool
12:56 < amovfx> Is there a good resource where I can learn about taproot? I'm reading over #25858 and I have some stuff to learn
12:56 <@gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
12:57 < sipa> amovfx: Have you read the BIPs (341 and 342 mostly)? There are more high-level explainers on various online media too. I've done one or two talks about it too.
12:58 < amovfx> I've seen a few videos, Ill read over the BIPS today thanks
12:58 < jonatack> amovfx: another suggestion would be to git clone the bitcoin optech and the bitcoin core pr reviews repositories locally and then search them for the terms you are interested in
12:59 < amovfx> ah thats a good idea, ty
12:59 < jonatack> also just https://bitcoinops.org/en/topics/
13:00 < jonatack> (idem for git cloning the bips repository locally)
13:00 < amovfx> yea makes them a bit more searchable
13:09 -!- jamesob [~jamesob@151.200.19.227] has quit [Quit: The Lounge - https://thelounge.chat]
13:11 -!- jamesob [~jamesob@151.200.19.227] has joined #bitcoin-core-dev
13:26 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
13:26 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
13:26 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
13:27 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
13:30 < kouloumos> amovfx: regarding optech resources, this might be useful https://bitcoinops.org/en/preparing-for-taproot/
13:40 -!- PasiveIncomeGirl [~PasiveInc@183.83.137.201] has joined #bitcoin-core-dev
13:44 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
13:46 -!- PasiveIncomeGirl [~PasiveInc@183.83.137.201] has left #bitcoin-core-dev []
13:48 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds]
14:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:ade2:76d3:1280:3ac0] has quit []
14:38 < Murch> We also have the Optech Workshop for Taproot with the Jupiter notebooks which should help people get their hands a bit dirty trying to understand how Taproot fits together under the hood
14:39 < Murch> https://bitcoinops.org/en/schorr-taproot-workshop/
14:39 < Murch> It may be slightly outdated on some minor details, but still useful
14:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds]
15:00 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
15:09 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
15:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
15:12 -!- aleggg [~aleggg@189.114.69.95] has joined #bitcoin-core-dev
15:13 < luke-jr> fanquake: can you un-rebase #25964 so it cleanly merges into 24.x too?
15:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/25964 | build: fix mingw miniupnpc cflags by fanquake · Pull Request #25964 · bitcoin/bitcoin · GitHub
15:33 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:40 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
15:45 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
15:49 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds]
15:54 < bitcoin-git> [bitcoin] furszy opened pull request #26158: bench: add "priority level" to the benchmark framework (master...2022_bench_priority_level) https://github.com/bitcoin/bitcoin/pull/26158
16:16 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Ping timeout: 246 seconds]
16:17 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
16:18 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 246 seconds]
17:03 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
17:06 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 265 seconds]
17:16 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
17:30 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
18:16 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.6]
18:17 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
18:17 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:27 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
18:27 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:33 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 265 seconds]
18:36 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
18:36 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
19:02 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev
19:09 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
19:13 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 244 seconds]
19:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
19:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
19:32 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
19:36 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds]
19:39 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
19:40 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
19:47 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Ping timeout: 265 seconds]
19:52 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-dev
20:31 -!- Guest41 [~Guest41@184.97.149.53] has joined #bitcoin-core-dev
20:53 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
20:53 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
21:08 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.6]
21:29 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 258 seconds]
21:40 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
21:41 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
21:42 -!- yanmaani2 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
23:33 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has joined #bitcoin-core-dev
23:38 -!- _apex2_ [~apex@dynamic-acs-24-144-190-15.zoominternet.net] has quit [Ping timeout: 252 seconds]
23:41 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
23:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
23:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
23:47 -!- Guest41 [~Guest41@184.97.149.53] has quit [Quit: Client closed]
--- Log closed Fri Sep 23 00:00:27 2022