--- Log opened Thu Nov 10 00:00:12 2022 00:05 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-core-dev 00:05 -!- Topic for #bitcoin-core-dev: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 00:05 -!- Topic set by laanwj [] [Sat May 22 03:05:22 2021] 00:05 [Users #bitcoin-core-dev] 00:05 [@gribble ] [ dergoegge ] [ instagibbs ] [ MatrixBot123 ] [ sanket_cell ] 00:05 [ [D] ] [ dermoth ] [ ishaanam[m] ] [ mekster669493 ] [ schmidty_ ] 00:05 [ ___nick___ ] [ dhruv ] [ Jackielove4u ] [ meshcollider ] [ sdaftuar ] 00:05 [ _aj_ ] [ dlb76 ] [ jamesob ] [ metta ] [ sebx2a ] 00:05 [ _andrewtoth_ ] [ dodo ] [ jarolrod ] [ michaelfolkson] [ sgiath ] 00:05 [ _Sam-- ] [ dongcarl ] [ jarthur ] [ midnight ] [ shiza ] 00:05 [ achow101 ] [ doppo ] [ jb55 ] [ mikehu44 ] [ sipa ] 00:05 [ adiabat ] [ dougefish ] [ jdmark ] [ mimmy ] [ sloorush ] 00:05 [ ajonas ] [ Earnestly ] [ jespada ] [ mjdietzx__ ] [ SpellChecker_ ] 00:05 [ amiti_ ] [ elichai2 ] [ jesseposner ] [ moneyball__ ] [ stacie ] 00:05 [ andytoshi ] [ emzy ] [ jetpack_ ] [ Murch ] [ stevenroose ] 00:05 [ Ara ] [ EPiSKiNG- ] [ jkczyz ] [ murrayn ] [ stick ] 00:05 [ ariard ] [ erwanor_ ] [ jnewbery ] [ nanotube ] [ stickies-v ] 00:05 [ arik ] [ euclid[m] ] [ johnzweng ] [ Nebraskka ] [ stratospher[m] ] 00:05 [ arturomf94[m] ] [ Evel-Knievel ] [ jon_atack ] [ neha ] [ sturles ] 00:05 [ aureleoules ] [ Evolver ] [ jonasschnelli] [ nickler ] [ sugarpuff ] 00:05 [ b10c ] [ ExEric3 ] [ josibake____ ] [ NorrinRadd ] [ szkl ] 00:05 [ baakeydo1 ] [ fanquake ] [ josie[m] ] [ notmandatory_ ] [ takinbo ] 00:05 [ bcdarc ] [ FelixWeis ] [ jrawsthorne ] [ noxim ] [ TallTim ] 00:05 [ berndj ] [ fjahr ] [ justache ] [ otoburb ] [ TheCharlatan ] 00:05 [ bitcoin-git ] [ flooded ] [ kakolainen[m]] [ outfox ] [ TheRec ] 00:05 [ bitdex ] [ Flow ] [ kallewoof ] [ PaperSword ] [ theStack ] 00:05 [ BlueMatt[m] ] [ furszy ] [ kanzure ] [ Pasha ] [ tinova4 ] 00:05 [ bohruz[m] ] [ ghost43 ] [ katsu_ ] [ phantomcircuit] [ tripleslash ] 00:05 [ bomb-on ] [ ghostarchist[m]] [ kcalvinalvin ] [ pinheadmz ] [ uasf ] 00:05 [ BUSY ] [ gleb071225 ] [ kexkey ] [ provoostenator] [ vasild ] 00:05 [ bw ] [ glozow ] [ kinlo ] [ qubenix ] [ Victorsueca ] 00:05 [ cfields ] [ gnusha ] [ kouloumos ] [ raj_ ] [ vincenzopalazzo] 00:05 [ cm ] [ GoldmanSats_ ] [ laanwj ] [ real_or_random] [ w0xlt_ ] 00:05 [ cmirror ] [ greypw2546002 ] [ landabaso ] [ realies ] [ warren ] 00:05 [ cncr04s ] [ gwillen ] [ landryl ] [ reardencode ] [ willcl_ark ] 00:05 [ cold ] [ harding ] [ LarryRuane ] [ roasbeef ] [ windsok ] 00:05 [ core-meetingbot] [ hebasto ] [ lightlike ] [ rockhouse ] [ x88x88x ] 00:05 [ cornfeedhobo ] [ helo ] [ lightningbot ] [ rodarmor ] [ yakshaver ] 00:05 [ cryptapus ] [ hendi ] [ Lightsword ] [ RubenSomsen ] [ yanmaani3 ] 00:05 [ da2ce7 ] [ hirish_ ] [ livestradamus] [ ryanofsky ] [ Zenton ] 00:05 [ darosior ] [ hsmiths ] [ lowhope ] [ S3RK ] 00:05 [ DeanGuss ] [ hugohn__ ] [ luke-jr ] [ sandipndev ] 00:05 [ denise[m] ] [ infernix ] [ MacroFake ] [ sanket1729 ] 00:05 -!- Irssi: #bitcoin-core-dev: Total of 192 nicks [1 ops, 0 halfops, 0 voices, 191 normal] 00:05 -!- Channel #bitcoin-core-dev created Wed May 19 06:52:47 2021 00:05 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-core-dev 00:06 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 00:07 -!- Irssi: Join to #bitcoin-core-dev was synced in 135 secs 00:10 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 248 seconds] 00:13 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev 00:24 -!- pablomartin [~pablomart@82.180.147.187] has joined #bitcoin-core-dev 00:32 -!- pablomartin [~pablomart@82.180.147.187] has quit [Ping timeout: 260 seconds] 00:35 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:36 -!- noxim [~AdminUser@user/noxim] has quit [Remote host closed the connection] 00:39 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 00:39 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 00:40 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 00:43 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 01:00 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has quit [Quit: You have been kicked for being idle] 01:18 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 01:18 < fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git 01:18 < fanquake> * [new tag] v24.0rc4 -> v24.0rc4 01:22 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 01:24 -!- Flow [~none@gentoo/developer/flow] has quit [Ping timeout: 252 seconds] 01:29 < fanquake> * [new tag] v23.1rc1 -> v23.1rc1 01:37 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev 01:55 -!- landabaso [~landabaso@62.174.245.185.static.user.ono.com] has quit [Quit: Client closed] 02:00 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 02:03 -!- kexkey [~kexkey@static-198-54-132-116.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 02:04 -!- kexkey [~kexkey@static-198-54-132-116.cust.tzulo.com] has joined #bitcoin-core-dev 02:05 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 02:35 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 02:38 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 02:39 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 02:39 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 246 seconds] 02:54 < hebasto> UPD. CMake-based build system integrated with 6 of 16 CI task for now -- https://cirrus-ci.com/build/5620151671324672. It's nice to see how CMake provides compile database building out-of-the box :) 03:00 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 03:02 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 03:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 03:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 03:11 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 03:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:15 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 03:18 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 03:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 03:28 -!- pablomartin [~pablomart@185.199.100.4] has joined #bitcoin-core-dev 03:34 -!- pablomartin [~pablomart@185.199.100.4] has quit [Ping timeout: 252 seconds] 03:35 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev 03:45 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 03:49 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 03:59 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 03:59 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 04:17 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 04:22 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 04:47 -!- jrayhawk [~jrayhawk@user/jrayhawk] has joined #bitcoin-core-dev 04:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a431:6990:e12d:ffa4] has joined #bitcoin-core-dev 04:50 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 04:55 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 04:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 05:06 -!- jrayhawk [~jrayhawk@user/jrayhawk] has quit [Ping timeout: 260 seconds] 05:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:13 -!- jrayhawk [~jrayhawk@user/jrayhawk] has joined #bitcoin-core-dev 05:16 < sipa> @hebasto Nice! 05:16 < hebasto> sipa: ty 05:23 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 05:27 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 255 seconds] 05:28 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 05:34 -!- _Sam-- [~sam@65.52.38.131] has quit [Ping timeout: 252 seconds] 05:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 05:45 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 05:49 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 05:50 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 05:57 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 06:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds] 06:02 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 06:09 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 06:30 -!- pablomartin [~pablomart@185.199.100.51] has joined #bitcoin-core-dev 06:33 < sipa> @harding Nice writeup. 06:33 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 06:36 -!- pablomartin [~pablomart@185.199.100.51] has quit [Ping timeout: 260 seconds] 06:37 < harding> sipa: thanks! 06:37 < instagibbs> harding, I'd try and not bury the lede that default is status quo 06:37 < instagibbs> text looks good otherwise 06:43 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:46 -!- amovfx [~amovfx@d50-99-173-89.abhsia.telus.net] has joined #bitcoin-core-dev 06:51 -!- amovfx [~amovfx@d50-99-173-89.abhsia.telus.net] has quit [Ping timeout: 268 seconds] 07:02 -!- _Sam-- [~sam@65.52.38.131] has joined #bitcoin-core-dev 07:04 -!- mikehu44 [~quassel@159.65.11.175] has quit [Ping timeout: 252 seconds] 07:11 -!- Guest89 [~Guest89@145.62.64.98] has joined #bitcoin-core-dev 07:12 -!- Guest89 [~Guest89@145.62.64.98] has quit [Client Quit] 07:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:20 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:27 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 07:38 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #26480: test: Remove wallet option from non-wallet tests (master...2211-test-wallet-options-💣) https://github.com/bitcoin/bitcoin/pull/26480 07:40 < darosior> Text looks good to me too 07:59 < stevenroose> Does anyone maintain a guix channel with packages for all different versions of bitcoind? Or even just the latest which tagged commits to place make inferiors for specific versions? 08:00 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 08:02 -!- Guest89 [~Guest89@145.62.64.98] has joined #bitcoin-core-dev 08:02 -!- Guest89 [~Guest89@145.62.64.98] has quit [Client Quit] 08:05 < lightlike> harding: Agree with the text, I find the wording "Notice of policy change" too strong - I would have expected a change in the default policy just from reading the heading, not an option that is off per default. 08:06 < harding> instagibbs, lightlike: good feedback, thanks, working on an edit. 08:06 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:07 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:14 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev 08:20 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 255 seconds] 08:22 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 08:22 -!- vasild_ [~vd@user/vasild] has joined #bitcoin-core-dev 08:24 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 08:28 < bitcoin-git> [bitcoin] hebasto opened pull request #26481: bench: Suppress output when running with `-sanity-check` option (master...221110-bench) https://github.com/bitcoin/bitcoin/pull/26481 08:31 < harding> instagibbs, lightlike: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft/_compare/1c1f17b778174724b4132288b815b11ae36c8d37...6985a7730310c364b075ccfb9c71b2242556779a (I have a meeting, I'll be back in a few hours if there are any other suggestions) 08:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 08:34 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has joined #bitcoin-core-dev 08:34 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 08:35 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:35 -!- kexkey [~kexkey@static-198-54-132-116.cust.tzulo.com] has quit [Ping timeout: 252 seconds] 08:37 -!- kexkey [~kexkey@static-198-54-132-122.cust.tzulo.com] has joined #bitcoin-core-dev 08:39 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 08:41 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [] 08:42 < bitcoin-git> [bitcoin] hebasto opened pull request #26482: ci: Drop redundant configuration options (master...221110-ci) https://github.com/bitcoin/bitcoin/pull/26482 08:50 < fanquake> jamesob instagibbs: in no ways thin, but there you go https://github.com/fanquake/core-review/blob/master/docker/lint.dockerfile 08:51 < bitcoin-git> [bitcoin] ryanofsky opened pull request #26483: test: Don't pass add_to_wallet option to walletcreatefundedpsbt (master...pr/realopt) https://github.com/bitcoin/bitcoin/pull/26483 08:51 < fanquake> Build the image. Run with your WIP bitcoin dir mounted. run linter with same script / deps as CI 08:51 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 08:51 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 08:51 < fanquake> all hardcoded and horrible atm, but it also just works, and ideally wouldn't change often 08:52 < instagibbs> I meant thin as in "doesn't do much but mitigate this developer headache" :) 08:54 -!- vasild_ [~vd@user/vasild] has quit [Remote host closed the connection] 08:54 < fanquake> in that case this is thin yes 08:54 < halosghost> if the CI supports the linter step, would a tool like act function to allow local running easily? (https://github.com/nektos/act) 08:54 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 08:55 < fanquake> you can already run the ci locally easily 08:55 < fanquake> https://github.com/bitcoin/bitcoin/tree/master/ci 08:55 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:56 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:56 -!- jon_atack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1] 08:57 < fanquake> although the CI lint job is somewhat the exception, and doesn't have a direct ci/test/setup_env script 08:57 < halosghost> I guess I'm misunderstanding what the headache is then ☺ 08:57 < halosghost> ahh 08:57 < halosghost> gotcha 08:58 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:58 < fanquake> having a dedicated image like this, that can be trivially spun up / down, with less overhead than the regular ci scripts is also likely useful 08:59 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 252 seconds] 08:59 < instagibbs> subtle version differences mean locally reproducing what CI will complain about is harder 08:59 < instagibbs> can mean* 09:00 < fanquake> Yea, and having an env that mimics the CI, means we can avoid changes that basically just refactor for the sake of squelling warnings coming from some updated dep that arbitrarily changed something 09:01 < halosghost> that's what I use act for ☺ 09:01 < fanquake> we don't use github actions 09:01 < halosghost> then it's kind of an immaterial suggestion with no value 09:01 < halosghost> nevermind ☺ 09:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 09:10 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 09:12 < bitcoin-git> [bitcoin] achow101 closed pull request #19181: Add ASM optimizations for MuHash3072 (master...csi-4-muhash-asm) https://github.com/bitcoin/bitcoin/pull/19181 09:12 < bitcoin-git> [bitcoin] achow101 closed pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078 09:12 < bitcoin-git> [bitcoin] achow101 closed pull request #19420: http: Track active requests and wait for last to finish (master...2020-06-track-requests) https://github.com/bitcoin/bitcoin/pull/19420 09:12 < bitcoin-git> [bitcoin] achow101 closed pull request #23352: test: Extend stale_tip_peer_management test (master...2110-testDos) https://github.com/bitcoin/bitcoin/pull/23352 09:13 < bitcoin-git> [bitcoin] achow101 closed pull request #24122: refactor: replace RecursiveMutex `cs_vProcessMsg` with Mutex (and rename) (master...202201-refactor_replace_RecursiveMutex_cs_vProcess) https://github.com/bitcoin/bitcoin/pull/24122 09:13 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 09:13 < bitcoin-git> [bitcoin] achow101 closed pull request #24150: refactor: move index class members from protected to private (master...move-index-class-members-from-protected-to-private) https://github.com/bitcoin/bitcoin/pull/24150 09:13 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 09:13 < bitcoin-git> [bitcoin] achow101 closed pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199 09:14 < bitcoin-git> [bitcoin] achow101 closed pull request #24827: net: Fix undefined behavior in socket address handling (master...fix_sock_ub) https://github.com/bitcoin/bitcoin/pull/24827 09:14 < bitcoin-git> [bitcoin] achow101 closed pull request #25039: lint: convert git-subtree-check.sh to Python (master...convert_git_subtree_check) https://github.com/bitcoin/bitcoin/pull/25039 09:14 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 09:15 < bitcoin-git> [bitcoin] achow101 closed pull request #24952: rpc: Add sqlite format option for dumptxoutset (master...2022-04-sqlite-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/24952 09:15 < bitcoin-git> [bitcoin] achow101 closed pull request #25659: wallet: simplify ListCoins implementation (master...2022_wallet_clean_listCoins) https://github.com/bitcoin/bitcoin/pull/25659 09:16 < bitcoin-git> [bitcoin] achow101 closed pull request #25097: test: Unit tests for taproot/tapscript coverage in `interpreter.cpp` (master...23279-taproot-unit-tests) https://github.com/bitcoin/bitcoin/pull/25097 09:19 < bitcoin-git> [bitcoin] achow101 reopened pull request #24150: refactor: move index class members from protected to private (master...move-index-class-members-from-protected-to-private) https://github.com/bitcoin/bitcoin/pull/24150 09:20 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199 09:25 -!- salvatoshi [~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr] has joined #bitcoin-core-dev 09:27 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 09:28 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 09:32 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 09:33 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 09:33 -!- pablomartin [~pablomart@185.199.100.54] has joined #bitcoin-core-dev 09:34 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:35 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:39 -!- pablomartin [~pablomart@185.199.100.54] has quit [Ping timeout: 260 seconds] 09:40 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 09:41 < instagibbs> harding, LGTM 09:42 < lightlike> same, thanks! 09:44 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev 09:50 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 09:51 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 09:52 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 09:52 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 09:53 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:54 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 09:54 -!- salvatoshi [~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr] has quit [Quit: Leaving] 10:02 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 10:07 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 10:07 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!] 10:08 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 10:13 < glozow> harding: thank you for the writeup, lgtm 10:13 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 10:14 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 10:14 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 10:15 -!- Aaronvan_ [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 10:19 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 10:20 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 10:27 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 10:31 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 10:31 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:32 < luke-jr> "zero conf" is a dishonest propaganda term. NACK using it. 10:32 < luke-jr> and why is the wiki non-editable⁇ 10:36 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 10:36 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev 10:41 < bitcoin-git> [bitcoin] ryanofsky opened pull request #26485: RPC: Add support for name-only parameters (master...pr/nonly) https://github.com/bitcoin/bitcoin/pull/26485 10:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 10:45 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:45 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 10:46 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:46 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 10:50 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 10:51 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 10:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 10:53 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 10:58 < achow101> luke-jr: to prevent spam/vandalism, but frequent contributors should be able to edit it 10:59 < laanwj> it should be editable by org members 11:00 < luke-jr> apparently not 11:00 < lightlike> maybe the issue is that you have to go the actual wiki page (https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft) - the difflinks given above don't have an edit button 11:00 < laanwj> #startmeeting 11:01 -!- mode/#bitcoin-core-dev [+o core-meetingbot] by ChanServ 11:01 < luke-jr> lightlike: right, I tried that - no edit button there either 11:02 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo 11:02 < laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 11:02 < kanzure> hi 11:02 < laanwj> welcome to the weekly bitcoin-core-dev meeting 11:02 < brunoerg> hi 11:02 < sipsorcery> hi 11:02 < achow101> hi 11:02 < laanwj> i don't see any topics proposed in advance -- any last minute ones? 11:02 < glozow> hi 11:03 < laanwj> hi 11:03 < sipa> hi 11:03 < jarolrod> Hi 11:03 < luke-jr> achow101: looks like I'm not part of the "frequent contributors" team 11:04 < laanwj> let's start with high priority for review as usual 11:04 < laanwj> #topic High priority for review 11:04 <@core-meetingbot> topic: High priority for review 11:05 < laanwj> luke-jr: ok, weird, you definitely belong in there 11:05 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 11:05 < jonatack> hi 11:05 < luke-jr> laanwj: perhaps an oversight between the two repos 11:05 < luke-jr> I remember being in it, but it might have been on 'bitcoin' rather than 'bitcoin-core' 11:05 < laanwj> https://github.com/orgs/bitcoin/projects/1/views/1 8 blockers, 3 chasing concept ACK at the moment 11:05 -!- PaperSword [~PaperSwor@50.126.96.22] has quit [Read error: Connection reset by peer] 11:05 < laanwj> luke-jr: likely! 11:05 < achow101> luke-jr: looks like you are in bitcoin but not in bitcoin-core. I'm suruprised it took us this long to notice 11:06 -!- PaperSword [~PaperSwor@50.126.96.22] has joined #bitcoin-core-dev 11:06 < achow101> someone with owner permissions will need to add you 11:06 < laanwj> anything to add / remove from the list? 11:07 < lightlike> #25600 was closed and can be removed from "chasing concept ack" 11:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/25600 | p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set by ariard · Pull Request #25600 · bitcoin/bitcoin · GitHub 11:07 < luke-jr> laanwj: I just rebased/addressed #22693 which seems like there's interest in sooner rather than later 11:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/22693 | RPC/Wallet: Add "use_txids" to output of getaddressinfo by luke-jr · Pull Request #22693 · bitcoin/bitcoin · GitHub 11:07 < laanwj> lightlike: removed 11:07 < luke-jr> I don't recall which PR I had in there before, but might as well put this in for now 11:08 < laanwj> luke-jr: added 11:10 < laanwj> anything else? any other topics for today? 11:11 < laanwj> if not, let's close the meeting early 11:12 < laanwj> #endmeeting 11:12 <@core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:12 <@core-meetingbot> Meeting ended Thu Nov 10 19:12:21 2022 UTC. 11:12 <@core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-11-10-19.00.moin.txt 11:13 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 11:13 -!- _Sam-- [~sam@65.52.38.131] has quit [Remote host closed the connection] 11:17 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 11:19 -!- champo [~champo@190.194.221.154] has joined #bitcoin-core-dev 11:21 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1] 11:24 -!- champo [~champo@190.194.221.154] has quit [Client Quit] 11:24 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 11:24 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 11:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:30 -!- Aaronvan_ is now known as AaronvanW 11:31 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 11:32 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 11:44 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Read error: Connection reset by peer] 11:44 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Read error: Connection reset by peer] 11:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Read error: Connection reset by peer] 11:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:44 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 11:48 < luke-jr> made various corrections ot the RBF release notes, including removing the "zero conf" propaganda term 11:50 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 11:50 < luke-jr> noteworthy the recommendation at the end is also changed such that it first suggests simply not accepting unconfirmed transactions at all 11:51 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 11:52 < luke-jr> though on further thought, that may be too absolute and need some language changes, since merchants typically do accept unconfirmed (eg) credit card transactions and such 11:52 < sipa> I don't understand what the issue is with zeroconf, and I don't think first-seen is the same thing (I'd associate zeroconf with the business practice of considering a transaction accepted at zero confirmations, while I'd associate first-seen with the node relay policy of not replacing anything) 11:53 < instagibbs> if you don't like the term, the polite thing to do is add "so-called" so readers who use the term understand what you're talking about 11:54 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 246 seconds] 11:54 < NorrinRadd> yeah i don't think there's anything "propaganda" about it 11:55 < sipa> Right, to me it has a pretty negative connotation even 11:55 < sipa> Calling it "instant payments" or so would be propaganda. 11:59 < luke-jr> it's not confirmed, "zero conf" implies it is 11:59 < sipa> I don't understand. 12:00 < sipa> zero confirmation literally means no confirmations. 12:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 12:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 12:01 < luke-jr> no, it means confirmation with zero blocks 12:01 < sipa> Huh, I'd never even consider interpreting it that way. 12:01 < sipa> Nor have I ever seen anyone doing so. 12:02 < luke-jr> just like "1 conf" is confirmation with 1 block 12:02 < NorrinRadd> agree with sipa. the apple dns protocol, zero conf, equally means zero configuration. because it'd work with no dns server & not require manually setting IP settings; names could resolve also 12:02 < sipa> I don't mind saying "so-called zeroconf" or so, but I think your changes to the writeup made it substantially less clear. 12:02 < brunoerg> seems weird for me luke's interpretation, never heard about it before 12:03 < luke-jr> also, discussing merchants' bad practices really doesn't belong in this doc at all IMO 12:04 < luke-jr> they're bad and unsafe regardless of full RBF 12:10 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 12:11 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:14 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dce30194bc0...7ef730ca84bd 12:14 < bitcoin-git> bitcoin/master 737c285 Ryan Ofsky: test: Don't pass add_to_wallet option to walletcreatefundedpsbt 12:14 < bitcoin-git> bitcoin/master 7ef730c Andrew Chow: Merge bitcoin/bitcoin#26483: test: Don't pass add_to_wallet option to wall... 12:14 < bitcoin-git> [bitcoin] achow101 merged pull request #26483: test: Don't pass add_to_wallet option to walletcreatefundedpsbt (master...pr/realopt) https://github.com/bitcoin/bitcoin/pull/26483 12:17 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 12:18 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:21 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 12:29 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 12:30 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 12:31 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:31 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 12:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 12:35 -!- pablomartin [~pablomart@185.199.100.56] has joined #bitcoin-core-dev 12:44 -!- pablomartin [~pablomart@185.199.100.56] has quit [Ping timeout: 260 seconds] 12:49 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 12:57 < harding> FWIW, I updated my personal gist for the draft release note about mempoolfullrbf to use the text from before luke-jr's edits plus the addition of "so-called" before "zero conf". https://gist.github.com/harding/f3cd8affb10cea96d352347fed7f4a3a 13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 252 seconds] 13:08 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 13:09 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 255 seconds] 13:11 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 13:11 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 13:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a431:6990:e12d:ffa4] has quit [] 13:26 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 13:26 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 13:30 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 13:31 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 13:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 13:40 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 13:45 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 13:50 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 13:51 -!- w0xlt_ [sid555702@id-555702.ilkley.irccloud.com] has quit [Excess Flood] 13:51 -!- w0xlt_ [sid555702@id-555702.ilkley.irccloud.com] has joined #bitcoin-core-dev 13:55 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 14:10 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 14:12 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 14:21 < luke-jr> harding: so you expressly prefer to include falsehoods? 14:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 14:24 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 14:28 < bitcoin-git> [bitcoin] sipa opened pull request #26486: Batch send NOTFOUND messages (master...202211_batchnotfound) https://github.com/bitcoin/bitcoin/pull/26486 14:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 14:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 14:38 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 14:38 < bitcoin-git> [bitcoin] sdulfari opened pull request #26487: log: improve some validation log messages to include hashPrevBlock (master...hash-prev-blk-error-msg) https://github.com/bitcoin/bitcoin/pull/26487 14:55 < harding> luke-jr: I have no clue what you're talking about. 14:57 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 14:58 < luke-jr> harding: that's what you seem to imply by going back to a version before corrections were made 15:00 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:01 -!- berndj [~berndj@197.189.254.139] has quit [Read error: Software caused connection abort] 15:01 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:04 -!- berndj [~berndj@197.189.254.139] has joined #bitcoin-core-dev 15:07 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 15:11 < harding> luke-jr: I didn't see a correction, just an opinionated edit. I have an opinion too, and it favored the previous text. However, since your only specific complaint here was about "zero conf" being a propaganda term, I implemented the suggestion from two other people here to precede it by "so-called". If you have other constructive feedback, I'd be happy to try to address it on my gist. 15:12 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 15:12 < luke-jr> if my edit involved opinion, it was the removal of it 15:12 < luke-jr> release notes aren't a place to push your (incorrect) "opinions" about the effects of policies 15:12 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 15:20 < harding> luke-jr: I didn't say that my draft contained my opinions about the effects of policies. I said that, in my opinion, I favored the previous text. 15:21 < luke-jr> the previous text contained factual errors which I corrected 15:22 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds] 15:26 < luke-jr> the way wikis typically work is that if you think it can be further improved, you edit it further. not fork an older version with errors 15:26 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 15:31 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 15:32 -!- Ara [~Ara@user/ara] has quit [Read error: Software caused connection abort] 15:33 -!- Ara [~Ara@user/ara] has joined #bitcoin-core-dev 15:36 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:37 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 15:37 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:37 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:37 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 15:40 -!- pablomartin [~pablomart@82.180.147.184] has joined #bitcoin-core-dev 15:40 < sipa> @[luke-jr] I find your version worse than @harding's, for two reasons (1) avoiding the term zeroconf - imo the accepted term for a certain practice - in favor of a term whose understood meaning is very different, and (2) calling a certain subset of users incompetent. 15:40 < harding> luke-jr: again, I don't see any errors in the older version nor any corrections in your version. One of the other typical ways wikis work is that, when two editors cannot agree on a way to intergate their differing edits, they allow other editors to take over and help resolve the disagreement. That's what I've attempted to do by externally providing my alternative version. If other members of this project decide to use it or to find a 15:40 < harding> compromise, great! If not, at least I know I tried my best to notify users about the potential consequences of the current change and potential future changes in this direction. 15:40 < sipa> In addition, I don't understand what specifically you object to, apart from finding the term zeroconf misleading (that's fine, we can address that by calling it so-called zeroconf). 15:41 < sipa> It would be more constructive to discuss alternatives than to flat-out say that someone else's version is wrong. 15:48 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:48 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:49 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:49 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:53 < PaperSword> Is the max value the RPC can accept for a block height a int32_t? as per 928 src/rest.cpp? 15:54 < PaperSword> Sorry if that was a double, got an error from irssi 16:09 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 16:12 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 16:13 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 16:14 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 246 seconds] 16:14 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1] 16:17 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 16:27 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 16:28 -!- pablomartin [~pablomart@82.180.147.184] has quit [Ping timeout: 268 seconds] 16:28 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 16:41 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 255 seconds] 16:41 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 16:44 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 16:49 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 17:13 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 17:14 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 17:15 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 17:15 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 17:15 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 17:15 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 17:19 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 17:20 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 255 seconds] 17:21 < luke-jr> sipa: if they were competent, they would be successful double spending … 17:21 < luke-jr> but again, if you have a better way to say it, feel free 17:21 < luke-jr> and no, "zeroconf" is a term used mainly for propaganda, not an accepted term 17:22 < luke-jr> PaperSword: the software cannot handle a height outside of int32 range right now at all IIRC 17:23 < luke-jr> PaperSword: which is fine, it won't matter until like AD 40800 or so 17:32 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 17:32 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 17:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 17:33 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 17:42 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Software caused connection abort] 17:45 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev 17:46 < PaperSword> Thanks @luke-jr, Yeah that's just fine as it could be updated as a softfork pretty sure! Just wanted to double check on that my getblock(height) implementation fully utilized the max range of possible inputs. 17:58 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 17:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 18:10 < luke-jr> PaperSword: it can't be 18:11 < sipa> luke-jr: I'm not disagreeing about the incompetent part; I just don't think it's the kind of language we ought to use in release notes 18:12 < sipa> re timestamp range; it's in theory fixable with a softfork a la forward blocks - but that brings huge downsides too 18:18 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Read error: Software caused connection abort] 18:18 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev 18:24 < ariard> ack harding's release notes about the possible effects of the `mempoolfullrbf`; left few improvement comment on the gist 18:25 < ariard> luke-jr: it's one thing to question users level of knowledge -- another to warn about the potential harmful effects of their application practices in light of transaction-relay changes 19:40 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 19:41 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 19:44 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Remote host closed the connection] 19:45 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 19:49 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 19:59 < luke-jr> ariard: there are no potential harmful effects though 20:00 < luke-jr> the "zeroconf" nonsense is FUD 20:17 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev 20:20 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 20:24 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 20:26 < luke-jr> https://bugs.xdavidhu.me/google/2022/11/10/accidental-70k-google-pixel-lock-screen-bypass/ 20:30 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 20:33 < PaperSword> @luke-jr sorry, I see what would happen. 20:36 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 255 seconds] 20:38 -!- jrayhawk [~jrayhawk@user/jrayhawk] has quit [Quit: debugging performance issues in 1.4.3] 20:38 -!- jrayhawk [~jrayhawk@user/jrayhawk] has joined #bitcoin-core-dev 20:42 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 20:46 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 255 seconds] 20:48 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 20:54 -!- qubenix [~qubenix@user/qubenix] has quit [Read error: Software caused connection abort] 20:54 -!- qubenix [~qubenix@user/qubenix] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:16 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 21:18 -!- katsu_ [~0x0ff@user/0x0ff/x-0302470] has quit [Read error: Software caused connection abort] 21:21 -!- katsu_ [~0x0ff@2001:bc8:47b0:123::1] has joined #bitcoin-core-dev 21:21 -!- katsu_ [~0x0ff@2001:bc8:47b0:123::1] has quit [Changing host] 21:21 -!- katsu_ [~0x0ff@user/0x0ff/x-0302470] has joined #bitcoin-core-dev 21:21 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 252 seconds] 21:52 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 21:57 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 246 seconds] 22:26 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 22:31 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 260 seconds] 22:31 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 255 seconds] 22:47 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 22:51 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 246 seconds] 22:53 -!- newlife08 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has joined #bitcoin-core-dev 22:55 -!- newlife08 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has quit [Client Quit] 22:56 -!- newlife08 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has joined #bitcoin-core-dev 22:57 -!- newlife085 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has joined #bitcoin-core-dev 22:57 -!- newlife085 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has quit [Client Quit] 22:57 -!- newlife08 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has quit [Client Quit] 22:57 -!- newlife08 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has joined #bitcoin-core-dev 22:58 -!- newlife08 [~newlife08@d72-38-201-170.commercial1.cgocable.net] has quit [Client Quit] 23:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 23:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 23:22 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev 23:26 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has quit [Ping timeout: 255 seconds] 23:56 -!- amovfx [~amovfx@node-1w7jr9yaiypxx1x2b9f6f63gj.ipv6.telus.net] has joined #bitcoin-core-dev --- Log closed Fri Nov 11 00:00:13 2022