--- Log opened Tue Nov 15 00:00:17 2022 00:12 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 00:13 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 00:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 00:16 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 00:17 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 255 seconds] 00:18 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 00:19 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev 00:23 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds] 00:43 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 00:45 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 00:48 -!- Guyver2 [~Guyver@77.174.98.73] has joined #bitcoin-core-dev 00:52 -!- Guyver2 [~Guyver@77.174.98.73] has left #bitcoin-core-dev [] 01:01 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 01:09 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 01:10 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 01:27 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 01:44 -!- gnaf [~gnaf@212-83-165-160.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 02:03 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 02:03 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has joined #bitcoin-core-dev 02:04 < MacroFake> I've made some last edits to the release notes draft 02:04 < MacroFake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft 02:04 < MacroFake> Unless there are objections, I think it can be merged back for 24.0-final 02:07 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 02:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 02:13 < vasild> LarryRuane: "Can `CChain::Next()` be called without holding `cs_main`?" -- In general, one has to check every variable that is read or written by CChain::Next() (directly or through other functions) -- how that variable is accessed in all other places. 02:15 < vasild> The number of things to check could explode quite quickly. Proper thread annotations would help with that. Next() is quite small :) 02:18 < vasild> It does access CChain::vChain in such a way that it expects it will not change between the reads. If it can be modified concurrently by other threads then that would be a problem. 02:44 < bitcoin-git> [bitcoin] fanquake opened pull request #26503: [24.x] bump version to v24.0 (24.x...24_0_final) https://github.com/bitcoin/bitcoin/pull/26503 02:55 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 252 seconds] 02:55 -!- cold [~cold@user/cold] has quit [Ping timeout: 248 seconds] 02:56 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev 02:57 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev 03:05 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 03:06 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 03:16 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD] 03:16 -!- NorrinRadd [~me@185.238.231.8] has quit [Ping timeout: 260 seconds] 03:18 -!- NorrinRadd [~me@185.238.231.63] has joined #bitcoin-core-dev 03:19 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev 03:26 -!- NorrinRadd [~me@185.238.231.63] has quit [Ping timeout: 260 seconds] 03:27 -!- NorrinRadd [~me@185.238.231.12] has joined #bitcoin-core-dev 04:05 -!- NorrinRadd [~me@185.238.231.12] has quit [Ping timeout: 260 seconds] 04:06 -!- NorrinRadd [~me@185.238.231.12] has joined #bitcoin-core-dev 04:07 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 04:22 -!- test__ is now known as _flood 04:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4820:4336:135:32d2] has joined #bitcoin-core-dev 04:34 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:35 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds] 04:37 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 04:47 < bitcoin-git> [bitcoin] hebasto opened pull request #26504: Add `UNREACHABLE` macro and drop `-Wreturn-type`/`C4715` warnings suppressions (master...221115-enum) https://github.com/bitcoin/bitcoin/pull/26504 05:15 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 05:16 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 05:17 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 05:21 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 05:27 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:44 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 05:45 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 05:48 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 246 seconds] 05:51 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 05:53 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 05:54 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:54 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:04 -!- ziggie [uid521459@user/ziggie] has quit [Quit: Connection closed for inactivity] 06:07 -!- gleb0712250 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 06:07 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:08 -!- gleb071225 [~gleb@178.150.137.228] has quit [Ping timeout: 260 seconds] 06:12 -!- gleb0712250 [~gleb@178.150.137.228] has quit [Ping timeout: 260 seconds] 06:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:26 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:26 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:28 < fanquake> Can everyone check / comment in regards to their attribution in the release notes: #26503 06:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/26503 | [24.x] bump version to v24.0 by fanquake · Pull Request #26503 · bitcoin/bitcoin · GitHub 06:28 < fanquake> I know in past releases contributors have preferred real-names over GH handles, or no attribution etc 06:31 < luke-jr> what's the status of jonatack's backport PR? slipping 24.0? 06:33 < instagibbs> github unicorn, havent seen that in a while 06:34 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 06:35 < luke-jr> #26457 06:35 <@gribble> https://github.com/bitcoin/bitcoin/issues/26457 | [24.x] backports for tx relay changes in getpeerinfo/netinfo/gui by jonatack · Pull Request #26457 · bitcoin/bitcoin · GitHub 06:44 < fanquake> luke-jr: That pr contains changes that haven't even been merged into master, and would also be a last-minute change to translation strings, which as far as I'm aware, we avoid. So at this stage, no, it's not going to make it in. 06:44 < bitcoin-git> [bitcoin] RandyMcMillan opened pull request #26505: src/bitcoin-cli.cpp: -getinfo help - grammar correction (master...1668522832/59e00c7e03/48174c0f28-getinfo) https://github.com/bitcoin/bitcoin/pull/26505 06:46 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:47 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:50 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:51 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:52 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:53 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:17 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 07:43 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev 07:53 -!- halosghost [~halosghos@user/halosghost] has quit [Read error: Connection reset by peer] 08:04 < jon_atack> fanquake: The PR those backports depend on seems mergeable, along with the backports (thank you luke-jr for mentioning it). 08:06 < stevenroose> Does Core store old blocks by height (i.e. sequentially)? 08:09 -!- jon_atack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1] 08:10 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:12 < stickies-v> stevenroose: no, see e.g. https://github.com/bitcoin/bitcoin/pull/16981 for context 08:13 < jonatack> Those backports may appear minor, but without them v24 will break user space. For example, the CashApp crypto team informed me that v24 will break their production systems if they upgrade without those patches. 08:16 < stickies-v> jonatack: perhaps it would be useful if they could comment/create issue with a bit more detail on how this would break their stuff? 08:17 < stevenroose> stickies-v: aha, thanks 08:17 < jonatack> I've been proposing to fix these since August before v24 branch-off. If we go forward as-is, it seems to me the v24 release notes ought to warn about the changes (last I looked a few days ago, there was no mention of it). 08:17 < stevenroose> stickies-v: and that holds for the entire chain, not just for the latest section of unprocessed blocks? 08:19 < stickies-v> yeah, blocks just get serialized to disk when they're received and basically not touched afterwards, and receiving blocks is never guaranteed to be sequential 08:23 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:23 < stickies-v> jonatack: i know you've raised it a while ago but i think there is some unclarity on how these changes break user space? Hence having direct and specific user input could be helpful? 08:23 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:24 < jonatack> stickies-v: they use the endpoint for sanity checks in their CI and deployment. It's also common sense that a field always present since a number of years in the API shouldn't become sometimes present, sometimes absent, without a deeply compelling reason to do so -- in which case user space ought to be warned in that case. 08:26 < jonatack> I've stated that case a number of times over months and need to sign off to present at a conf. Up to you all. 08:27 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 08:27 < willcl_ark> stevenroose: there is a script in contrib/linearize which can construct a linear block chain locally, if you require :) 08:27 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1] 08:29 < stevenroose> Things like Riccardo Casatta's block_iterator that iterates through the blockchain on disk would be significantly faster I presume if they would be sequential. As would a hypothetical streamblockchain RPC of some kind 08:46 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 260 seconds] 08:51 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev 08:55 < bitcoin-git> [bitcoin] brunoerg opened pull request #26507: test: remove unused vars in `feature_block` (master...2022-11-unused-feature-block-test) https://github.com/bitcoin/bitcoin/pull/26507 09:07 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 09:09 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:18 -!- generatecoll [~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565] has quit [Quit: Client closed] 09:19 -!- NorrinRadd [~me@185.238.231.12] has quit [Ping timeout: 260 seconds] 09:22 -!- NorrinRadd [~me@185.238.231.8] has joined #bitcoin-core-dev 09:24 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 09:25 -!- salvatoshi [~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr] has joined #bitcoin-core-dev 09:26 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:26 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit] 09:28 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:39 < bitcoin-git> [gui] john-moffett opened pull request #680: Fixes MacOS 13 segfault by preventing certain notifications after main window is destroyed (master...202211MacSegfaultOnQuit) https://github.com/bitcoin-core/gui/pull/680 09:41 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 10:00 -!- salvatoshi [~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr] has quit [Remote host closed the connection] 10:00 -!- salvatoshi [~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr] has joined #bitcoin-core-dev 10:37 -!- Zenton [~user@user/zenton] has quit [Read error: Connection reset by peer] 10:53 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev 11:02 -!- bytes1440000 [~bytes1440@212-83-165-160.rev.poneytelecom.eu] has joined #bitcoin-core-dev 11:04 < bytes1440000> michaelfolkson: dont try to police what people write in any repo on github, time you spend on twitter or stackexchange, if spent on github and some testing maybe you could review some PR without bias 11:04 < bytes1440000> or write some code at some point 11:08 -!- salvatoshi [~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr] has quit [Ping timeout: 268 seconds] 11:12 -!- bytes1440000 [~bytes1440@212-83-165-160.rev.poneytelecom.eu] has left #bitcoin-core-dev [] 11:54 < lightlike> jonatack: it's not clear to me what exactly breaks user space and should be mentioned in release notes. Do you mean the order change in getpeerinfo JSON output? Or that some fields can be reported differently very rarely during a specific moment during connection initialisation? Or something else? 12:00 < harding> lightlike: did you see: " [...] a field always present since a number of years in the API shouldn't become sometimes present, sometimes absent, without a deeply compelling reason to do so -- in which case user space ought to be warned in that case." and https://github.com/bitcoin/bitcoin/pull/26457/commits/5c03df1fce744fbc357e32f66f9a50b8e609c386 ? 12:10 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:10 < lightlike> harding: yes, i saw that. I was asking about the "sometimes", to better understand how this affects user experience. Can this happen in a split second during connection initialization, and you'd need an extremely well-timed getpeerinfo call to evoke it? Can this happen in other circumstances? 12:16 < lightlike> I just tried to add a sleep during various points in initialization with v24.0rc3 and tried to get a getpeerinfo reponse without minfeefilter present, but didn't succeed (but maybe I missed the right spot for the sleep). 12:28 -!- gleb0712250 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 12:29 < harding> lightlike: I see. However, if we expect statestats to be available but we include an extra if statement just in case it isn't available, shouldn't we also expect downstream users to want to include their own if statements in their code case the minfeefilter RPC result isn't available? 12:35 -!- NorrinRadd [~me@185.238.231.8] has quit [Ping timeout: 260 seconds] 12:39 < lightlike> harding: Not sure if it makes sense to accomodate this particular situation if it's really just for an extremely short period during connection setup - maybe we could just not answer getpeerinfo until statestats is available? But to answer this (and to get an opinion whether this needs to be backported / mentioned in the release notes) the missing info for me is how exactly can it occur that statestats is not available. 12:41 < lightlike> (I meant not include the particular peer in getpeerinfo, of course we should answer it) 12:47 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 12:47 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 12:47 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 12:48 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 12:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48174c0f287b...547a96362888 12:50 < bitcoin-git> bitcoin/master fa4ec1b MacroFake: test: Split overly large util_tests.cpp file 12:50 < bitcoin-git> bitcoin/master 547a963 MacroFake: Merge bitcoin/bitcoin#26489: test: Split overly large util_tests.cpp file 12:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26489: test: Split overly large util_tests.cpp file (master...2211-test-split-🌐) https://github.com/bitcoin/bitcoin/pull/26489 12:52 -!- NorrinRadd [~me@185.238.231.65] has joined #bitcoin-core-dev 13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 260 seconds] 13:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4820:4336:135:32d2] has quit [] 13:10 -!- hg [~halosghos@user/halosghost] has joined #bitcoin-core-dev 13:11 -!- halosghost [~halosghos@user/halosghost] has quit [Ping timeout: 240 seconds] 13:45 -!- generatecoll [~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565] has joined #bitcoin-core-dev 13:46 -!- shiza [~admin@ec2-52-208-131-13.eu-west-1.compute.amazonaws.com] has quit [Remote host closed the connection] 14:13 -!- generatecoll [~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565] has quit [Quit: Client closed] 14:38 < lightlike> harding, jonatack: I looked a bit more into this and wrote up my conclusions in #26457 - tldr is that I think the fields can only be missing if there is a race between a peer disconnecting and the getpeerinfo RPC. 14:38 <@gribble> https://github.com/bitcoin/bitcoin/issues/26457 | [24.x] backports for tx relay changes in getpeerinfo/netinfo/gui by jonatack · Pull Request #26457 · bitcoin/bitcoin · GitHub 14:38 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 14:41 < harding> lightlike: whatever the outcome, thanks for the careful research! 14:52 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1] 15:16 < luke-jr> ++lightlike 15:17 < luke-jr> I think that means the fixes done are actually wrong, since it was assuming the opposite? (that it only occurs during connection setup) 15:34 -!- NorrinRadd [~me@185.238.231.65] has quit [Ping timeout: 256 seconds] 15:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:57 < lightlike> luke-jr: I think they'd still fix the part where clients that would expect a field like "minfeefilter" to be always there won't crash - they'd just get incorrect data for these fields now. But the actual root cause that we'd sometimes report a mix of correct (but outdated) and wrong (default-initialized) data for an Peer that should be atomic is not fixed by this. 16:02 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 16:03 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 255 seconds] 16:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:13 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 16:24 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/547a96362888...5602cc7ccf4a 16:24 < bitcoin-git> bitcoin/master 48a6890 Larry Ruane: Add LoadExternalBlockFile() benchmark 16:24 < bitcoin-git> bitcoin/master c72de99 Larry Ruane: util: add CBufferedFile::SkipTo() to move ahead in the stream 16:24 < bitcoin-git> bitcoin/master db92989 Larry Ruane: Faster -reindex by initially deserializing only headers 16:24 < bitcoin-git> [bitcoin] achow101 merged pull request #16981: Improve runtime performance of --reindex (master...reindex-speedup) https://github.com/bitcoin/bitcoin/pull/16981 16:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds] 16:27 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 16:46 < bitcoin-git> [bitcoin] luke-jr opened pull request #26508: RPC/Blockchain: Minor improvements for scanblocks & scantxoutset docs/errors (master...rpc_scanblocks_scantxoutset_doc_improvements) https://github.com/bitcoin/bitcoin/pull/26508 16:53 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5602cc7ccf4a...f0c646f026e6 16:53 < bitcoin-git> bitcoin/master f0f6a35 furszy: RPC: listunspent, add "include immature coinbase" flag 16:53 < bitcoin-git> bitcoin/master 61c2265 furszy: wallet: group AvailableCoins filtering parameters in a single struct 16:53 < bitcoin-git> bitcoin/master fa84df1 furszy: scripted-diff: wallet: rename AvailableCoinsParams members to snake_case 16:53 < bitcoin-git> [bitcoin] achow101 merged pull request #25730: RPC: listunspent, add "include immature coinbase" flag (master...2022_RPC_listunspent_include_immature_coinbase) https://github.com/bitcoin/bitcoin/pull/25730 16:56 < luke-jr> lightlike: incorrect data is worse than crashing 17:05 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 17:39 < bitcoin-git> [bitcoin] Kuplynx opened pull request #26509: fix the network (master...master) https://github.com/bitcoin/bitcoin/pull/26509 17:44 < luke-jr> ^ spammer fanquake sipa laanwj 18:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 18:04 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 18:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 18:12 -!- NorrinRadd [~me@185.238.231.45] has joined #bitcoin-core-dev 18:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:25 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 255 seconds] 18:26 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 19:07 -!- jespada [~jespada@82.36.38.229] has quit [Ping timeout: 248 seconds] 19:09 -!- jespada [~jespada@nmal-24-b2-v4wan-166357-cust1764.vm24.cable.virginm.net] has joined #bitcoin-core-dev 19:53 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev 19:58 -!- mikehu44 [~quassel@159.65.11.175] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 20:13 < bitcoin-git> [bitcoin] glozow closed pull request #26509: fix the network (master...master) https://github.com/bitcoin/bitcoin/pull/26509 20:59 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 20:59 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:46 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404] 22:21 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 22:27 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 22:55 -!- Guest34 [~Guest34@2607:fb90:3f25:2c68:f40a:4bc6:8e33:2d13] has joined #bitcoin-core-dev 23:01 -!- Guest34 [~Guest34@2607:fb90:3f25:2c68:f40a:4bc6:8e33:2d13] has quit [Quit: Client closed] 23:24 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev 23:34 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 255 seconds] 23:38 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 23:47 -!- NorrinRadd [~me@185.238.231.45] has quit [Ping timeout: 268 seconds] --- Log closed Wed Nov 16 00:00:18 2022