--- Log opened Wed Nov 16 00:00:18 2022 00:01 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev 00:34 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur] 00:40 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 00:41 -!- TheRec [~toto@user/therec] has quit [Ping timeout: 246 seconds] 00:47 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has quit [Read error: Software caused connection abort] 00:48 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has joined #bitcoin-core-dev 00:57 -!- takinbo [~takinbo@user/takinbo] has quit [Read error: Software caused connection abort] 00:57 -!- takinbo [~takinbo@user/takinbo] has joined #bitcoin-core-dev 01:05 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 01:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 01:15 -!- ziggie [uid521459@user/ziggie] has joined #bitcoin-core-dev 01:21 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:23 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 01:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 01:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 01:30 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:30 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 01:54 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:02 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has joined #bitcoin-core-dev 02:07 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 02:09 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 02:10 -!- steve__ [steve@2600:3c01::f03c:93ff:feaa:dd16] has joined #bitcoin-core-dev 02:13 < fanquake> lightlike: thanks for investigating further. So it seems the changes in #26328 are probably overcomplicated, given it's basically impossible to hit the third state (and not something we should have to worry about in -netinfo)? 02:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/26328 | netinfo: fix relaytxes doc, display 3 relaytxes states by jonatack 路 Pull Request #26328 路 bitcoin/bitcoin 路 GitHub 02:13 < fanquake> and the rpc/release notes doc, "not available while peer connection is still being set up" are also incorrect? 02:21 < MacroFake> PSA: DrahtBot will now collect review comments and link to all of them in a summary comment. Example: https://github.com/bitcoin/bitcoin/pull/26508#issuecomment-1316749699 02:21 < MacroFake> Let me know if there are any issues 02:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 02:22 < MacroFake> Code was contributed by aureleoules :) 02:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 02:34 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 02:36 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 02:36 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [] 02:37 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 02:41 < fanquake> I guess this means we should also partially revert https://github.com/bitcoin-core/gui/pull/676, which contained the same "(not available while the peer connection is being set up)" 02:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 02:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 03:07 < fanquake> > and need to sign off to present at a conf. Up to you all. 03:07 < fanquake> jonatack: When you're done presenting, please clarify exactly what is going to "break user space and production systems", and which specific change(s) need backporting. 03:07 < fanquake> I'm assuming it's only minfeefilter (setting aside whether this should be handled downstream), in which case, only 5c03df1fce744fbc357e32f66f9a50b8e609c386 from 26457 would be a last-minute blocker? 03:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:36 -!- steve__ [steve@2600:3c01::f03c:93ff:feaa:dd16] has quit [Quit: Leaving] 03:36 -!- steve__ [steve@2600:3c01::f03c:93ff:feaa:dd16] has joined #bitcoin-core-dev 03:42 -!- NorrinRadd [~me@185.238.231.65] has joined #bitcoin-core-dev 03:45 < aureleoules> thanks MacroFake for reviewing the code! 03:46 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 03:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 03:47 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 03:47 -!- NorrinRadd [~me@185.238.231.65] has quit [Ping timeout: 260 seconds] 03:47 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 03:48 -!- NorrinRadd [~me@185.238.231.54] has joined #bitcoin-core-dev 03:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:49 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 03:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 03:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 04:09 -!- NorrinRadd [~me@185.238.231.54] has quit [Ping timeout: 268 seconds] 04:29 -!- NorrinRadd [~me@185.238.231.54] has joined #bitcoin-core-dev 04:33 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 04:33 -!- Guest95 [~Guest95@185.173.181.70.mixvoip.solutions] has joined #bitcoin-core-dev 04:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 04:33 -!- Guest5 [~Guest5@185.173.181.70.mixvoip.solutions] has joined #bitcoin-core-dev 04:33 -!- Guest95 [~Guest95@185.173.181.70.mixvoip.solutions] has quit [Client Quit] 04:33 -!- Guest5 [~Guest5@185.173.181.70.mixvoip.solutions] has quit [Client Quit] 04:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:98f8:37c3:cbdf:e0a0] has joined #bitcoin-core-dev 04:43 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 04:45 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 04:54 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 05:12 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 05:12 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 05:24 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 05:25 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 05:30 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 05:33 -!- MeA_BzZz [~MeA_BzZz@adsl-84-227-13-96.adslplus.ch] has joined #bitcoin-core-dev 05:34 < harding> Is it expected that there are no 24.0 RC4 binaries at https://bitcoincore.org/bin/bitcoin-core-24.0/ ? 05:51 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev 05:54 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 05:54 -!- MeA_BzZz [~MeA_BzZz@adsl-84-227-13-96.adslplus.ch] has quit [Quit: Client closed] 05:55 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 06:01 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:02 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0c646f026e6...6863ad79a658 06:06 < bitcoin-git> bitcoin/master 2222ec7 MacroFake: util: Move error message formatting of NonFatalCheckError to cpp 06:06 < bitcoin-git> bitcoin/master 6863ad7 MacroFake: Merge bitcoin/bitcoin#25112: util: Move error message formatting of NonFat... 06:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25112: util: Move error message formatting of NonFatalCheckError to cpp (master...2205-err-impl-馃棥) https://github.com/bitcoin/bitcoin/pull/25112 06:06 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 06:07 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 06:08 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:08 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:09 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:09 < bitcoin-git> [bitcoin] willcl-ark opened pull request #26512: init: Evaluate sysperms before config file (master...2022_13371_sysperms) https://github.com/bitcoin/bitcoin/pull/26512 06:10 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:12 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:13 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:18 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:22 -!- stevenroose [~steven@2001:19f0:6801:83a:5e1a:89e5:c5fb:d631] has quit [Remote host closed the connection] 06:22 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-core-dev 06:28 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:29 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:31 -!- gnaf [~gnaf@212-83-144-108.rev.poneytelecom.eu] has joined #bitcoin-core-dev 06:53 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 06:53 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 07:04 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev 07:06 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:07 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:15 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 07:18 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 07:20 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:21 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:24 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [] 07:30 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:32 -!- ziggie [uid521459@user/ziggie] has quit [Quit: Connection closed for inactivity] 07:33 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 07:37 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 268 seconds] 07:49 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 07:51 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 07:56 -!- test_ is now known as _flood 08:05 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 08:08 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 08:15 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Quit: Leaving] 08:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:34 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 08:35 -!- Guest10 [~Guest10@2600:4040:b487:6e00:9953:4ee1:2a4a:58c2] has joined #bitcoin-core-dev 08:35 -!- Guest10 [~Guest10@2600:4040:b487:6e00:9953:4ee1:2a4a:58c2] has quit [Client Quit] 08:37 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev 08:50 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 08:50 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:56 < bitcoin-git> [bitcoin] aureleoules opened pull request #26513: Make static nLastFlush and nLastWrite Chainstate members (master...2022-11-remove-static-chainstate) https://github.com/bitcoin/bitcoin/pull/26513 08:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection] 08:59 -!- pablomartin [~pablomart@192.145.124.100] has joined #bitcoin-core-dev 09:00 -!- Lov3r_Of_Bitcoin [~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:01 < jonatack> lightlike: cf yesterday's discussion on the breaking getpeerinfo API, the v24 changes also broke our own code, see #25176 09:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack 路 Pull Request #25176 路 bitcoin/bitcoin 路 GitHub 09:04 < jonatack> lightlike: this was also trivially visible by observing the GUI peers details during new connections, or by testing #26328 09:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/26328 | netinfo: fix relaytxes doc, display 3 relaytxes states by jonatack 路 Pull Request #26328 路 bitcoin/bitcoin 路 GitHub 09:05 < jonatack> after my last talk today, i'll reverify with 24rc4 09:08 < jonatack> these weren't rare occurences, at least in my testing, they were frequent. note that i use a vpn, have tor/i2p/cjdns peers, and some addnode manual peers with colleagues on the other side of the world. 09:08 < fanquake> > please clarify exactly what is going to "break user space and production systems", and which specific change(s) need backporting. 09:09 < lightlike> jonatack: are you sure that the errors in #25176 happened during connection setup for a new peer - and not during disconnection of a peer? Because I can't see how this would be possible from looking at the code. 09:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack 路 Pull Request #25176 路 bitcoin/bitcoin 路 GitHub 09:11 < jonatack> lightlike: yes, i read your comments (thanks for looking!), and will reverify, but the manual testing methods above showed it happening on connection. i will recheck to be sure. 09:15 < jonatack> fanquake: messages forwarded to me by the CashApp PM from two of their developers: "we have layers of bitcoin core nodes and use that endpoint [getpeerinfo] .. if we upgraded our production systems without Jon's patch, it would break our production systems and we'd get paged" 09:15 < jonatack> another dev: "and related, we need to update our core nodes" 09:16 < jonatack> first dev: "if you want to link the github issue/PR, I can comment directly and ack the proposed changes" 09:16 < fanquake> Ok. So what is "johns patch" in this scenerio? I'm sure it doesn't include doc changes, rpc help changes, netinfo changes, qt changes etc 09:17 < fanquake> What is the specific commit or change they are talking about 09:18 < fanquake> From the investigation here, it's not clear what is broken, or how it's broken, or, aslo, why cashapp couldn't work around this on their side, even temporarily. 09:18 < jonatack> i had similar feedback from a dev at Block a month or so ago regarding their deployment pipeline. the cashapp messages were a week ago 09:19 < dergoegge> jonatack: why can't they upgrade their handling of the getpeerinfo call to support missing fields? 09:19 < dergoegge> This would have all been much simpler if they (CashApp devs) would have just opened an issue explaining their exact problem tbh 09:19 < jonatack> fanquake: the fields that became optional 09:20 -!- emzy [~quassel@user/emzy] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 09:20 < jonatack> dergoegge: the Block dev contacted me after reading the discussion in my first proposal and found some of the reactions too intimidating to comment 09:20 < jonatack> dergoegge: sure, everyone can patch it on their own, but that doesn't seem ideal 09:22 < fanquake> jonatack: which fields are you talking about? 09:22 < fanquake> My understanding is that only minfeefilter has changed in terms of being optional 09:23 < fanquake> The presence of relaytxes is unchanged in 26457 09:23 < jonatack> fanquake: and relaytxes, which i proposed to also patch but their was resistance. If we leave the change to make it optional in v24 (after 8 years of being always present, it would introduced in 2015), it would be good to mention that change in the release notes 09:24 < fanquake> sorry, I'm misunderstanding, 26457 does nothing in regards to changing wether relaytxes is present on not. It's just moved to a different fStateStats conditional 09:25 < fanquake> and martins comment here: https://github.com/bitcoin/bitcoin/pull/26457/files#r1024158792, suggests that it's always available in any case 09:26 < jonatack> fanquake: https://github.com/bitcoin/bitcoin/pull/26109#discussion_r973091972 09:27 < jonatack> it's not always available, and that is trivially testing by reverting #25176 or the two other methods i mentioned above in this convo 09:27 <@gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack 路 Pull Request #25176 路 bitcoin/bitcoin 路 GitHub 09:28 < jonatack> *testable 09:28 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 09:30 * jonatack back in a few hours 09:34 -!- john-moffett [~john-moff@pool-108-24-170-15.cmdnnj.fios.verizon.net] has joined #bitcoin-core-dev 09:35 < fanquake> so, to clarify, the current PR, which just shifts relaytxes from one fStateStats conditional, to another, doesn't actually fix the cashapp issue in any case? 09:37 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 09:38 < fanquake> but does make minfeefilter non-optional, by giving it a value of 0 if there is no fstatestats 09:39 < fanquake> however the current question / understanding is that it's only possible for there to be no fstatestats if you're racing a getpeerinfo call, and a peer disconnection 09:40 < fanquake> and this can't happen during connection setup 09:44 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 09:47 < jonatack> i doubt that, but if it were true then we could make relaytxes always present as before with no downside 09:48 < jonatack> will check in a few hours, thanks 09:48 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 09:57 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 09:58 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 10:00 -!- steve__ [steve@2600:3c01::f03c:93ff:feaa:dd16] has quit [Quit: Leaving] 10:01 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 10:03 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 10:05 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:05 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 256 seconds] 10:06 -!- Lov3r_Of_Bitcoin [~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has quit [Quit: Connection closed] 10:14 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 10:15 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:30 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 10:34 < bitcoin-git> [bitcoin] aureleoules opened pull request #26514: Improve address decoding errors (master...2022-11-improve-address-decode-errors) https://github.com/bitcoin/bitcoin/pull/26514 11:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:05 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 11:06 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit] 11:08 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 11:35 -!- stickies-v [sid544753@id-544753.uxbridge.irccloud.com] has quit [Ping timeout: 252 seconds] 11:38 -!- stickies-v [sid544753@id-544753.uxbridge.irccloud.com] has joined #bitcoin-core-dev 11:40 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 260 seconds] 11:43 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has joined #bitcoin-core-dev 11:49 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 256 seconds] 11:55 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has joined #bitcoin-core-dev 12:01 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 12:27 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 12:28 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [] 12:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 12:36 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev 12:36 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 248 seconds] 13:16 -!- Guest7 [~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60] has joined #bitcoin-core-dev 13:28 < BlueMatt[m]> jonatack - you seem to indicate its not a regression anyway at https://github.com/bitcoin/bitcoin/pull/26457/#discussion_r1014670159 ? if that's true I don't see why this is a candidate for backport this late in an rc cycle at all. 13:36 -!- chipxxx [~chip@2001:8a0:f61c:9200:9c3d:d55a:c1aa:516e] has quit [Ping timeout: 256 seconds] 13:37 -!- PaperSword [~PaperSwor@50.126.96.22] has quit [Read error: Connection reset by peer] 13:38 -!- NorrinRadd [~me@185.238.231.54] has quit [Ping timeout: 240 seconds] 13:39 -!- Guest7 [~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60] has quit [Ping timeout: 260 seconds] 13:40 -!- NorrinRadd [~me@185.238.231.42] has joined #bitcoin-core-dev 13:44 -!- Guest7 [~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60] has joined #bitcoin-core-dev 13:45 < luke-jr> jonatack: during peer disconnection, we can't know what the correct value was, so how could it be present? 13:46 < luke-jr> returning incorrect data is IMO worse than omitting it 13:53 -!- Guest7 [~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60] has quit [Quit: Client closed] 14:10 -!- Zenton [~user@user/zenton] has quit [Read error: Connection reset by peer] 14:10 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev 14:14 < bitcoin-git> [bitcoin] mzumsande opened pull request #26515: rpc: skip getpeerinfo for a peer without CNodeStateStats, make its fields non-optional (master...202211_getpeerinfo_allornothing) https://github.com/bitcoin/bitcoin/pull/26515 14:27 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:29 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 14:36 < lightlike> I opened 26515 as a more general proposal to deal with this long-term. 15:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds] 15:04 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 15:04 -!- theStack [~theStack@95.179.145.232] has quit [Ping timeout: 248 seconds] 15:09 < jonatack> BlueMatt[m]: the comment you linked to refers to a doc update proposed two months ago and is not the regression in question. at the time, it was within the window, as was the backports pull. 15:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 15:10 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 256 seconds] 15:10 < BlueMatt[m]> jonatack: so, iiuc, the issue here is that one field (minfeefilter) was always present in 23 and prior releases, and now there's some (absurdly, apparently?) rare race condition where it may not be while a peer is disconnecting? 15:11 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 15:12 < BlueMatt[m]> is that correct? 15:12 < jonatack> BlueMatt[m]: two fields in getpeerinfo, relaytxes and minfeefilter. no, it's not rare. we had to patch our own code for the former in #25176 15:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack 路 Pull Request #25176 路 bitcoin/bitcoin 路 GitHub 15:12 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection] 15:12 < BlueMatt[m]> (fwiw its not at all clear from the current pr, the previous pr, or any commit message - none of them describe the concrete issue here, just trying to make sure I get what's going on) 15:13 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev 15:13 < BlueMatt[m]> okay, so 26457 does not re-add relaytxes, its still missing in the same set of cases as before? 15:13 < BlueMatt[m]> is there some second pr to make it always present? 15:13 -!- NorrinRadd [~me@185.238.231.42] has quit [Ping timeout: 260 seconds] 15:14 < jonatack> BlueMatt[m]: i wanted to make it always present as before, see https://github.com/bitcoin/bitcoin/pull/26109#discussion_r973091972 15:14 < BlueMatt[m]> btw who is "we" here? You're saying in some deployment of yours you had an issue because of this? I assume it's because something was deserializing the response into a struct that expects the field to be present? 15:15 -!- NorrinRadd [~me@185.238.231.34] has joined #bitcoin-core-dev 15:15 < jonatack> and the original discussion at the start of #25923 15:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/25923 | p2p: always provide CNodeStateStats and getpeerinfo/netinfo/gui updates by jonatack 路 Pull Request #25923 路 bitcoin/bitcoin 路 GitHub 15:16 < BlueMatt[m]> jonatack: right, I'm not really trying to understand what did or didnt happen, just trying to make sure I understand where we sit today. 15:17 < jonatack> BlueMatt[m]: some out-of-date docs that don't cause a regression and two longstanding getpeerinfo fields (relaytxes since 2015 and mifeefilter since 2018 or 2019 iirc) that in v24 are no longer always present 15:17 < BlueMatt[m]> (am I still correct that rpc changes are supposed to go through the announced-in-one-release-changed/removed-in-the-next two-step process thing?) 15:20 < BlueMatt[m]> jonatack: right, okay, so then I'm a bit confused why a release is being held up for a non-fix? Irrespective of whether Marco was right to argue against it or not, I don't see why fixing the removal of one field, and not another, makes sense this late in rc? 15:20 < BlueMatt[m]> like, if removal of a field is an issue (again, not taking a stance here), then fix both, if its not, then ship? 15:21 < BlueMatt[m]> again irrespective of if it should have landed before now, it is where it is 15:23 < jonatack> BlueMatt[m]: we had to patch -netinfo that doesn't null check fields that are always present. given the number of fields returned by getpeerinfo, and given feedback from some companies in the space, this needlessly breaks their software as well while being trivial on our end to fix once, rather than each of them patching it. in any case, this has been proposed for months now. it's not 15:23 < jonatack> holding up the release. it could have been merged but was not. that is not in my control. however, we should also warn user space in the release notes if we leave it as is. 15:24 < BlueMatt[m]> (fwiw I asked the cash app folks - they have no idea what the patch does or what the specific issue is, and dont know if it would actually cause them pain, they were only told that "if you use getpeerinfo this may break your stuff" and they said "yea, we use that") 15:24 < BlueMatt[m]> hence why I'm here asking trying to understand exactly where things sit 15:24 < BlueMatt[m]> what is "-netinfo" that you had to patch? You saw the missing fields in prod? 15:25 < jonatack> BlueMatt[m]: see my irc comments earlier today for what was forwaded to me 15:26 < jonatack> i don't have direct access to them 15:26 < BlueMatt[m]> again, I'm not taking a position on if it should be merged or not, but trying to understand (a) if its a regression (sounds like yes), (b) how likely it is that you can even observe the fields being missing (you seem to say they can be and are in prod, others have said they basically cant be), and (c) if its an issue that merits last-minute fixes. 15:26 < jonatack> BlueMatt[m]: re -netinfo, see the patch PR i linked to above 15:26 < BlueMatt[m]> yes, I know, that was a game of telephone, that's why I went and asked ryan directly :) 15:26 < BlueMatt[m]> he said he's happy to get on a call, if you'd like, but he's busy dealing with mempool growth today :) 15:27 < jonatack> i'm free any time for a call 15:28 < jonatack> i've just finished a bunch of stuff and will re-verify but the issues have been trivial to reproduce in at least three ways 15:28 < jonatack> - observing our GUI peers details 15:28 < BlueMatt[m]> okay, by "frequently" there in your comment about netinfo I'm a bit confused - fanquake seemed to indicate that in tests others had noted they weren't able to reproduce this at all unless they added some sleeps in the code, implying its an incredibly rare race? 15:29 < jonatack> - reverting the -netinfo patch 15:29 < jonatack> - and by testing #26328 15:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/26328 | netinfo: fix relaytxes doc, display 3 relaytxes states by jonatack 路 Pull Request #26328 路 bitcoin/bitcoin 路 GitHub 15:30 < BlueMatt[m]> oh, and, finally, it seems pretty obvious that if we think this is a major breaking issue worth backporting, we should make sure both fields are always present, even in a 24-only PR. 15:30 -!- pablomartin_ [~pablomart@181.228.255.13] has joined #bitcoin-core-dev 15:30 < jonatack> BlueMatt[m]: I prefer making both present for v24 as it's more prudent and then figuring out the best path for the next releases 15:30 < BlueMatt[m]> because obviously just fixing it for one field wont help. 15:31 < BlueMatt[m]> is there a pr for that? 15:31 < jonatack> agree 15:31 -!- pablomartin [~pablomart@192.145.124.100] has quit [Ping timeout: 260 seconds] 15:31 < jonatack> #26109 did that before dropping the relaytxes change. i'll open one to re-propose and re-verify the recent feedback 15:31 <@gribble> https://github.com/bitcoin/bitcoin/issues/26109 | rpc, doc: getpeerinfo updates by jonatack 路 Pull Request #26109 路 bitcoin/bitcoin 路 GitHub 15:34 < jonatack> BlueMatt[m]: I think you are referring to https://github.com/bitcoin/bitcoin/pull/26457#pullrequestreview-1181641835 which doesn't appear to be end-to-end user-facing testing but will re-check now to be sure 15:34 < BlueMatt[m]> may be worth re-testing, to make sure it still makes sense holding up a release on it. 15:35 -!- pablomartin_ [~pablomart@181.228.255.13] has quit [Ping timeout: 268 seconds] 15:35 < jonatack> BlueMatt[m]: it's sure that it happens frequently though. Looking at the GUI peers details makes that clear. But going to re-check indeed. 15:36 < jonatack> -netinfo would break several times a minute without the patch 15:36 < jonatack> with a watch interval of 1 second or 2 15:36 < BlueMatt[m]> thanks 15:47 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 15:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds] 15:51 -!- yanmaani3 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 15:52 -!- justache is now known as justGrit 15:53 < lightlike> jonatack: for the gui peer details , fetching the statestats can fail for completely unrelated reasons (locking issues, see https://github.com/bitcoin/bitcoin/blob/6863ad79a65842504ab6f5584fac3d1de7ecf87e/src/qt/rpcconsole.cpp#L1200-L1201 ) that don't apply to the RPC. 16:22 -!- NorrinRadd [~me@185.238.231.34] has quit [Ping timeout: 256 seconds] 16:22 -!- zeropoint [~alex@c-67-169-157-130.hsd1.ca.comcast.net] has quit [Quit: leaving] 16:24 -!- NorrinRadd [~me@185.238.231.8] has joined #bitcoin-core-dev 16:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:98f8:37c3:cbdf:e0a0] has quit [] 16:29 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1] 16:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 16:53 -!- NorrinRadd [~me@185.238.231.8] has quit [Ping timeout: 260 seconds] 16:58 -!- NorrinRadd [~me@185.238.231.34] has joined #bitcoin-core-dev 16:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 17:12 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-dev 17:13 -!- gnaf [~gnaf@212-83-144-108.rev.poneytelecom.eu] has quit [Ping timeout: 260 seconds] 17:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:29 -!- infernix [nix@spirit.infernix.net] has quit [Ping timeout: 268 seconds] 17:48 -!- gnaf [~gnaf@212-83-144-108.rev.poneytelecom.eu] has joined #bitcoin-core-dev 17:53 -!- infernix [nix@spirit.infernix.net] has joined #bitcoin-core-dev 18:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 18:03 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 18:22 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 18:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 18:35 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1] 18:46 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 19:01 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 19:03 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 19:05 -!- jonatack1 [~jonatack@user/jonatack] has joined #bitcoin-core-dev 19:07 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 19:07 -!- jonatack2 [~jonatack@user/jonatack] has joined #bitcoin-core-dev 19:08 -!- jonatack2 [~jonatack@user/jonatack] has quit [Client Quit] 19:09 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 19:40 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 19:42 < lightlike> Maybe it's in fact only happening in case of a disconnect race, but if you allow incoming peers and there are constantly spy nodes connecting/disconnecting you as seems to be the case on mainnet recently ( https://b10c.me/observations/05-inbound-connection-flooder-down/) these races are more common than one would think. 20:14 < bitcoin-git> [bitcoin] jonatack opened pull request #26516: Always return getpeerinfo "relaytxes" field (master...2022-11-getpeerinfo-relayxes) https://github.com/bitcoin/bitcoin/pull/26516 20:15 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404] 20:15 < bitcoin-git> [bitcoin] jonatack closed pull request #26328: netinfo: fix relaytxes doc, display 3 relaytxes states (master...update-netinfo-relaytxes-help) https://github.com/bitcoin/bitcoin/pull/26328 20:25 < bitcoin-git> [bitcoin] jonatack reopened pull request #26328: netinfo: fix relaytxes doc, display 3 relaytxes states (master...update-netinfo-relaytxes-help) https://github.com/bitcoin/bitcoin/pull/26328 20:29 < lightlike> For example, my node has received ~3 new incoming connections per second recently on average - summing up to over 7 Million connections over a month. So if you poll getpeerinfo once per second in this situation, the chance of a race with a disconnect is probably significant. 20:48 < jonatack> lightlike: how many peers do you have? 20:51 < jonatack> I think you may be right about the disconnection only. 20:51 * jonatack sleep 20:53 < lightlike> didn't change the default, so ~125. The growth in NodeId can be inferred from the debug log, where new outbound connections are logged with the respective Node Id. 20:57 < bitcoin-git> [gui] jonatack opened pull request #681: Fix Transaction Relay tooltip text in Peers details window (master...relaytxes-tooltip-fix) https://github.com/bitcoin-core/gui/pull/681 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:01 < jonatack> lightlike: oh, i don't doubt you, i have also seen high peer id numbers at times relative to node uptime 21:11 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 21:13 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 21:15 -!- jon_atack [~jonatack@user/jonatack] has quit [Client Quit] 21:24 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 21:30 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 21:37 -!- generatecoll [~generatec@2600:1700:1c35:2bb0:dc56:3352:4b1b:e34d] has joined #bitcoin-core-dev 21:43 -!- generatecoll [~generatec@2600:1700:1c35:2bb0:dc56:3352:4b1b:e34d] has quit [Quit: Client closed] 21:44 < bitcoin-git> [bitcoin] Randy808 opened pull request #26517: test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. (master...use-vsize-for-fee-tests) https://github.com/bitcoin/bitcoin/pull/26517 22:00 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 22:35 -!- jamesob3 [~jamesob@151.200.19.227] has joined #bitcoin-core-dev 22:37 -!- instagibbs_ [~instagibb@pool-100-15-129-252.washdc.fios.verizon.net] has joined #bitcoin-core-dev 22:37 -!- instagibbs [~instagibb@pool-100-15-129-252.washdc.fios.verizon.net] has quit [Ping timeout: 248 seconds] 22:37 -!- jamesob [~jamesob@151.200.19.227] has quit [Ping timeout: 252 seconds] 22:37 -!- jamesob3 is now known as jamesob 22:38 -!- roasbeef [~roasbeef@104.131.26.124] has quit [Ping timeout: 260 seconds] 22:38 -!- roasbeef [~roasbeef@104.131.26.124] has joined #bitcoin-core-dev 22:38 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 22:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 22:39 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 22:40 -!- gossie [~gossie@2001:1c02:11e:3500:df25:6321:8260:d9be] has quit [Quit: = "bye bye"] 22:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:00 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 23:15 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 23:18 -!- NorrinRadd [~me@185.238.231.34] has quit [Ping timeout: 256 seconds] 23:40 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] --- Log closed Thu Nov 17 00:00:19 2022