--- Log opened Tue Dec 13 00:00:44 2022
01:05 -!- Aaronvan_ [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
01:14 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
01:19 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
01:36 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
02:08 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6061eb656410...968f03e65c98
02:08 < bitcoin-git> bitcoin/master a451e83 James O'Beirne: fix: validation: cast now() to seconds for maxtipage comparison
02:08 < bitcoin-git> bitcoin/master e4be0e9 James O'Beirne: test: add -maxtipage test for the maximum allowable value
02:08 < bitcoin-git> bitcoin/master 968f03e fanquake: Merge bitcoin/bitcoin#26477: validation: fix broken maxtipage comparison
02:08 < bitcoin-git> [bitcoin] fanquake closed pull request #26477: validation: fix broken maxtipage comparison (master...2022-11-fix-maxtipage) https://github.com/bitcoin/bitcoin/pull/26477
02:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds]
02:39 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds]
02:43 < bitcoin-git> [bitcoin] fanquake closed pull request #26692: doc: Fix typo in comment (master...fix-typo-implemenation) https://github.com/bitcoin/bitcoin/pull/26692
02:51 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev
02:52 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
02:57 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
03:07 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 264 seconds]
03:14 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds]
03:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a8f0:96ec:9928:64a3] has joined #bitcoin-core-dev
03:21 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
03:42 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 255 seconds]
03:45 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
03:51 -!- Guest54 [~Guest54@197.210.71.18] has joined #bitcoin-core-dev
03:52 -!- Guest54 [~Guest54@197.210.71.18] has quit [Client Quit]
03:53 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
03:53 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
04:16 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
05:04 < stickies-v> in https://github.com/bitcoin/bitcoin/blob/968f03e65c98a9a36aea6c57a29306839b0ada57/src/util/result.h#L65-L69, it seems that we want to return an rvalue ref (`T&&`) but since the return type is just `T` - my intuition is that we will be passing by value instead? I think I must be wrong, but I don't understand why - any insights (or links/pointers) appreciated (cc author ryanofsky)
05:05 -!- Guest170 [~Guest1@212-186-118-210.static.upcbusiness.at] has joined #bitcoin-core-dev
05:06 -!- Guest170 [~Guest1@212-186-118-210.static.upcbusiness.at] has quit [Client Quit]
05:25 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 256 seconds]
05:39 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
05:39 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
05:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:45 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
05:46 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:02 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
06:03 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:30 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
06:40 -!- Guest27 [~Guest27@195.97.112.38] has joined #bitcoin-core-dev
06:40 < stickies-v> ^ hebasto answered me offline, I'll try and summarize here (any misinterprations my own): to avoid dangling references, we don't want to return an rvalue reference `T&&` but return by value instead. However, if `T` properly implements a move constructor, we can construct `T` without doing any copy operations
06:45 -!- Guest27 [~Guest27@195.97.112.38] has quit [Client Quit]
07:12 < bitcoin-git> [bitcoin] willcl-ark opened pull request #26693: build: special instruction check script (master...18603_si_check) https://github.com/bitcoin/bitcoin/pull/26693
07:15 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:20 < jonatack> stickies-v: https://en.cppreference.com/w/cpp/language/copy_elision or searching on RVO (return value optimization) might be relevant (ignore me if not :)
07:23 < stickies-v> yeah thanks jonatack I'm aware of both concepts and they are relevant practically, my question was a bit more theoretical
07:34 < bitcoin-git> [bitcoin] kdmukai opened pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run the unsigned v23.0 arm64 binary; fall back to x86_64 binary (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
08:38 < bitcoin-git> [bitcoin] glozow opened pull request #26695: bench: BlockAssembler on a mempool with packages (master...2022-12-bench-miner) https://github.com/bitcoin/bitcoin/pull/26695
08:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/968f03e65c98...a4baf3f17748
08:59 < bitcoin-git> bitcoin/master e2c3b18 Ryan Ofsky: test: Add RPC tests for same named parameter specified more than once
08:59 < bitcoin-git> bitcoin/master 6bd1d20 Ryan Ofsky: rpc: Make it an error server-side to specify same named parameter multiple...
08:59 < bitcoin-git> bitcoin/master d1ca563 Ryan Ofsky: bitcoin-cli: Make it an error to specify the "args" parameter two differen...
08:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26628: RPC: Reject RPC requests with same named parameter specified multiple times (master...pr/nmult) https://github.com/bitcoin/bitcoin/pull/26628
09:06 -!- javi404 [~quassel@c-73-1-238-68.hsd1.fl.comcast.net] has quit [Quit: No Ping reply in 180 seconds.]
09:08 -!- javi404 [~quassel@c-73-1-238-68.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
09:08 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 260 seconds]
09:09 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
09:41 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has joined #bitcoin-core-dev
09:49 -!- jespada_ [~jespada@nmal-24-b2-v4wan-166357-cust1764.vm24.cable.virginm.net] has joined #bitcoin-core-dev
09:49 -!- otoburb_ [~otoburb@user/otoburb] has joined #bitcoin-core-dev
09:49 -!- jonasschnelli_ [~jonasschn@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev
09:50 -!- jkczyz_ [sid419941@id-419941.lymington.irccloud.com] has joined #bitcoin-core-dev
09:50 -!- kakolainen[m]1 [~kakolaine@2001:470:69fc:105::34f9] has joined #bitcoin-core-dev
09:51 -!- bcdarc_ [~bcdarc@4.53.92.114] has joined #bitcoin-core-dev
09:54 -!- _0x0ff [~0x0ff@2001:bc8:47b0:123::1] has joined #bitcoin-core-dev
09:54 -!- _0x0ff [~0x0ff@2001:bc8:47b0:123::1] has quit [Changing host]
09:54 -!- _0x0ff [~0x0ff@user/0x0ff/x-0302470] has joined #bitcoin-core-dev
09:54 -!- Murch1 [~murch@user/murch] has joined #bitcoin-core-dev
09:54 -!- otoburb [~otoburb@user/otoburb] has quit [Ping timeout: 252 seconds]
09:54 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has quit [Ping timeout: 252 seconds]
09:55 -!- asoltys_ [~adam@s207-81-214-251.bc.hsia.telus.net] has joined #bitcoin-core-dev
09:55 -!- kinlo [~peter@user/kinlo] has quit [Ping timeout: 252 seconds]
09:55 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has quit [Ping timeout: 252 seconds]
09:55 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 252 seconds]
09:55 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has quit [Ping timeout: 252 seconds]
09:55 -!- sugarpuff [sid92283@id-92283.lymington.irccloud.com] has quit [Ping timeout: 252 seconds]
09:55 -!- bcdarc [~bcdarc@4.53.92.114] has quit [Ping timeout: 252 seconds]
09:55 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Ping timeout: 252 seconds]
09:55 -!- katsu_ [~0x0ff@user/0x0ff/x-0302470] has quit [Ping timeout: 252 seconds]
09:55 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Ping timeout: 252 seconds]
09:55 -!- jespada [~jespada@nmal-24-b2-v4wan-166357-cust1764.vm24.cable.virginm.net] has quit [Ping timeout: 252 seconds]
09:55 -!- Murch [~murch@user/murch] has quit [Ping timeout: 252 seconds]
09:55 -!- asoltys [~adam@s207-81-214-251.bc.hsia.telus.net] has quit [Ping timeout: 252 seconds]
09:55 -!- jkczyz_ is now known as jkczyz
09:55 -!- _0x0ff is now known as katsu_
09:56 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
09:56 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev
09:57 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
10:01 < stickies-v> anything wrong with our cirrus instances? suddenly all my CI jobs failing: https://github.com/bitcoin/bitcoin/pull/26506/checks?check_run_id=10070556876 - can't see anything in recent commits that would trigger it
10:02 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:02 < stickies-v> getting error message `Failed to checkout 135e8326adee7f86da83e8aa409905a1de4a5b2e: object not found!` when that commit is definitely on origin: https://github.com/bitcoin/bitcoin/commit/135e8326adee7f86da83e8aa409905a1de4a5b2e
10:02 -!- kinlo [~peter@user/kinlo] has joined #bitcoin-core-dev
10:03 < stickies-v> oh, it seems github is having some issues: https://www.githubstatus.com/ : `Git Operations` and `Pull Requests` is showing as `Degraded`
10:04 -!- sugarpuff [sid92283@id-92283.lymington.irccloud.com] has joined #bitcoin-core-dev
10:28 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:29 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
10:55 -!- rozehnal_paul [~rozehnal_@142.157.230.169] has joined #bitcoin-core-dev
11:10 < bitcoin-git> [gui] meshcollider closed pull request #536: Add address error location to GUI (master...202201_bech32_error_gui) https://github.com/bitcoin-core/gui/pull/536
11:14 -!- rozehnal_paul [~rozehnal_@142.157.230.169] has quit [Quit: Client closed]
11:19 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a4baf3f17748...8f3021155e8c
11:19 < bitcoin-git> bitcoin/master e5daf97 Andrew Chow: wallet: Rename nFeeRet in CreateTransactionInternal to current_fee
11:19 < bitcoin-git> bitcoin/master c1a84f1 Andrew Chow: wallet: Move fee underpayment check to after fee setting
11:19 < bitcoin-git> bitcoin/master 798430d Andrew Chow: wallet: Sanity check fee paid cannot be negative
11:19 < bitcoin-git> [bitcoin] achow101 merged pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
12:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a8f0:96ec:9928:64a3] has quit []
12:35 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:54 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
12:57 -!- javi404 [~quassel@c-73-1-238-68.hsd1.fl.comcast.net] has quit [Ping timeout: 260 seconds]
12:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
13:00 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
13:02 -!- javi404 [~quassel@c-73-1-238-68.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
13:31 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 256 seconds]
13:41 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
13:51 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f3021155e8c...ffa32ab108a4
13:51 < bitcoin-git> bitcoin/master e75d227 John Moffett: Minor fix: Don't directly delete abandoned txes
13:51 < bitcoin-git> bitcoin/master ffa32ab Hennadii Stepanov: Merge bitcoin-core/gui#682: Don't directly delete abandoned txes from GUI
13:51 < bitcoin-git> [gui] hebasto merged pull request #682: Don't directly delete abandoned txes from GUI (master...2022_11_FixAbandonTxGUI) https://github.com/bitcoin-core/gui/pull/682
14:00 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
14:02 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
14:03 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit]
14:05 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
14:06 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1]
14:17 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
14:21 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
15:00 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
15:02 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
15:04 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev
15:09 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ffa32ab108a4...daf881de9db1
15:09 < bitcoin-git> bitcoin/master daf881d Andrew Chow: Merge bitcoin/bitcoin#23319: rpc: Return fee and prevout (utxos) to getraw...
15:09 < bitcoin-git> bitcoin/master f866971 Douglas Chimento: rpc: Return fee and prevout(s) to getrawtransaction
15:09 < bitcoin-git> [bitcoin] achow101 merged pull request #23319: rpc: Return fee and prevout (utxos) to getrawtransaction (master...23264-fee-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/23319
15:26 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
15:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:37 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
15:38 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
15:40 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
15:40 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
15:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds]
15:55 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
15:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
15:57 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:58 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
16:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
16:27 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
16:30 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
16:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
16:57 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
17:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:17 -!- ShohamChakrabort [~shohamc1m@2001:470:69fc:105::2:d8cb] has joined #bitcoin-core-dev
18:00 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
18:02 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
18:02 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit]
18:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
18:42 -!- orville [~orville@c-71-202-253-228.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:45 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404]
19:08 -!- orville [~orville@c-71-202-253-228.hsd1.ca.comcast.net] has quit [Quit: <exit all I/O streams / EOF>]
19:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
19:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
19:16 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
19:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:50 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:40 < bitcoin-git> [bitcoin] LarryRuane opened pull request #26697: logging: use std::bitset for categories (master...2022-12-log-categories-stdbitset) https://github.com/bitcoin/bitcoin/pull/26697
21:45 < bitcoin-git> [bitcoin] LarryRuane closed pull request #26619: log: expand BCLog::LogFlags (categories) to 64 bits (master...2022-11-log-categories-64) https://github.com/bitcoin/bitcoin/pull/26619
22:03 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has quit [Quit: as2333]
22:13 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
22:14 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
22:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
22:14 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
22:15 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
22:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
22:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
22:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
23:24 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:25 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
23:30 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 255 seconds]
23:32 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
--- Log closed Wed Dec 14 00:00:45 2022