--- Log opened Mon Dec 19 00:00:49 2022 00:19 -!- mpkcj93 [~mpkcj93@225.red-79-152-174.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 00:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cb32328d1b80...8b05f13ddb1e 00:24 < bitcoin-git> bitcoin/master 2b77a33 Hennadii Stepanov: test: Improve `check-doc.py` pattern 00:24 < bitcoin-git> bitcoin/master 8b05f13 MarcoFalke: Merge bitcoin/bitcoin#26717: test: Improve `check-doc.py` pattern 00:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26717: test: Improve `check-doc.py` pattern (master...221217-doc) https://github.com/bitcoin/bitcoin/pull/26717 00:25 -!- mpkcj93 [~mpkcj93@225.red-79-152-174.dynamicip.rima-tde.net] has quit [Quit: Client closed] 00:41 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:52 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 00:52 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 00:55 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 00:56 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 01:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/8b05f13ddb1e...bd13d6b36921 01:16 < bitcoin-git> bitcoin/master 4ad7272 Andrew Chow: tests: reduce number of generated blocks for wallet_import_rescan 01:16 < bitcoin-git> bitcoin/master 544cbf7 Andrew Chow: tests: Use batched RPC in feature_fee_estimation 01:16 < bitcoin-git> bitcoin/master 6c872d5 Andrew Chow: tests: Initialize sigops draining script with bytes in feature_taproot 01:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26656: tests: Improve runtime of some tests when `--enable-debug` (master...faster-test-runner-when-debug) https://github.com/bitcoin/bitcoin/pull/26656 01:19 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:19 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 01:34 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd13d6b36921...65f5cfda656c 01:34 < bitcoin-git> bitcoin/master 36c201f James O'Beirne: remove CBlockIndex copy construction 01:34 < bitcoin-git> bitcoin/master 65f5cfd fanquake: Merge bitcoin/bitcoin#25311: refactor: remove CBlockIndex copy construction 01:34 < bitcoin-git> [bitcoin] fanquake merged pull request #25311: refactor: remove CBlockIndex copy construction (master...2022-06-cblockindex-delete-copy) https://github.com/bitcoin/bitcoin/pull/25311 01:40 -!- UncleBen [~UncleBens@user/UncleBen] has joined #bitcoin-core-dev 01:45 < fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git 01:45 < fanquake> * [new tag] v23.1 -> v23.1 02:14 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 02:24 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:26 -!- UncleBen [~UncleBens@user/UncleBen] has quit [Quit: ____________________________________________________________________________________________________________________________________________] 02:28 -!- UncleBen [~UncleBens@user/UncleBen] has joined #bitcoin-core-dev 02:38 -!- UncleBen [~UncleBens@user/UncleBen] has quit [Quit: ____________________________________________________________________________________________________________________________________________] 02:54 < bitcoin-git> [bitcoin] willcl-ark opened pull request #26725: lint: fix lint-tests.py failing on correct names (master...lint-name-test) https://github.com/bitcoin/bitcoin/pull/26725 03:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 03:55 -!- UncleBen [~UncleBens@user/UncleBen] has joined #bitcoin-core-dev 04:10 < bitcoin-git> [bitcoin] willcl-ark closed pull request #26725: lint: fix lint-tests.py failing on correct names (master...lint-name-test) https://github.com/bitcoin/bitcoin/pull/26725 04:17 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 04:34 -!- bytes1440000 [~bytes1440@212-83-143-67.rev.poneytelecom.eu] has joined #bitcoin-core-dev 04:45 -!- UncleBen [~UncleBens@user/UncleBen] has quit [Quit: celebrate free speech \o/] 04:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 04:47 < bytes1440000> achow101: I read last meeting logs and wondering what are the next steps for #25871 ? Considering PR is open since last 4 months, jeremyrubin has withdrawn all ACK/NACK, dergoegge fanquake have not responded for weeks and there are 16 ACKs from different contributors in the pull request or related discussion on IRC. 04:47 <@gribble> https://github.com/bitcoin/bitcoin/issues/25871 | contrib: add vasild to trusted keys by vasild · Pull Request #25871 · bitcoin/bitcoin · GitHub 04:52 -!- UncleBen [~UncleBens@user/UncleBen] has joined #bitcoin-core-dev 05:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65f5cfda656c...3d974960d38b 05:01 < bitcoin-git> bitcoin/master 6fefd49 Martin Zumsande: rpc: Require NodeStateStats object in getpeerinfo 05:01 < bitcoin-git> bitcoin/master 3d97496 MarcoFalke: Merge bitcoin/bitcoin#26515: rpc: skip getpeerinfo for a peer without CNod... 05:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 05:11 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 05:14 -!- bytes1440000 [~bytes1440@212-83-143-67.rev.poneytelecom.eu] has quit [Ping timeout: 260 seconds] 05:31 < bitcoin-git> [bitcoin] fanquake closed pull request #26515: rpc: skip getpeerinfo for a peer without CNodeStateStats (master...202211_getpeerinfo_allornothing) https://github.com/bitcoin/bitcoin/pull/26515 05:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 05:45 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 05:47 -!- Guest43 [~Guest43@114.41.150.83.ftth.as8758.net] has joined #bitcoin-core-dev 05:48 -!- Guest43 [~Guest43@114.41.150.83.ftth.as8758.net] has quit [Client Quit] 06:00 -!- MrFrancis [~MrFrancis@bl15-115-2.dsl.telepac.pt] has joined #bitcoin-core-dev 06:14 -!- willcla_rk [~willcla_r@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3d974960d38b...8ab19237e11e 06:19 < bitcoin-git> bitcoin/master ec63a48 brunoerg: test: call `keypoolrefill` with private keys disabled should throw an error 06:19 < bitcoin-git> bitcoin/master 8ab1923 MarcoFalke: Merge bitcoin/bitcoin#26723: test: call `keypoolrefill` with priv key disa... 06:20 -!- UncleBen [~UncleBens@user/UncleBen] has quit [Quit: UncleBen] 06:21 -!- jamesob [~jamesob@151.200.19.227] has joined #bitcoin-core-dev 06:24 -!- Guest41 [~Guest41@23-47-59-81.ftth.glasoperator.nl] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] fanquake closed pull request #26723: test: call `keypoolrefill` with priv key disabled should throw an error (master...2022-12-keypool-error-privatekey) https://github.com/bitcoin/bitcoin/pull/26723 06:39 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Remote host closed the connection] 06:45 -!- josie[m] is now known as josibake 06:45 -!- willcla_rk [~willcla_r@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has quit [Quit: Client closed] 06:50 -!- josibake is now known as josie 06:51 -!- MrFrancis [~MrFrancis@bl15-115-2.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 06:56 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev 06:58 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev 07:01 -!- realies [~realies@user/realies] has quit [Ping timeout: 265 seconds] 07:04 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev 07:04 -!- jonatack2 [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 07:07 -!- josie [~josiem]@2001:470:69fc:105::2:47a6] has quit [Quit: Reconnecting] 07:07 -!- josie [~josibake@2001:470:69fc:105::2:47a6] has joined #bitcoin-core-dev 07:40 < bitcoin-git> [bitcoin] fanquake opened pull request #26727: rpc: remove optional from fStateStats fields (master...remove_fstatestats_post_26515) https://github.com/bitcoin/bitcoin/pull/26727 07:44 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Read error: Connection reset by peer] 07:49 -!- halosghost [~halosghos@user/halosghost] has joined #bitcoin-core-dev 07:51 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:57 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:7889:c073:b49b:b2a3] has joined #bitcoin-core-dev 08:38 -!- jonatack2 [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:51 -!- jonatack2 [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 08:51 -!- jonatack3 [~jonatack@user/jonatack] has joined #bitcoin-core-dev 09:00 -!- Guest24 [~Guest24@23-47-59-81.ftth.glasoperator.nl] has joined #bitcoin-core-dev 09:02 -!- Guest24 [~Guest24@23-47-59-81.ftth.glasoperator.nl] has quit [Client Quit] 09:33 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:34 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:7889:c073:b49b:b2a3] has quit [Ping timeout: 256 seconds] 09:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev 10:02 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 10:03 -!- jonatack3 [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 10:32 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:42 < midnight> fanquake: hello, I spotted you pinging me re: the recent keys commit and thought I'd just ping you in here to see if you needed me to do anything more? My key will, eventually, be the same key I'll use if I can ever get gitian working fully from-source in my build environment. :) 10:43 -!- Guest41 [~Guest41@23-47-59-81.ftth.glasoperator.nl] has quit [Ping timeout: 260 seconds] 10:43 < fanquake> midnight: only needed if you ever do a Guix build, in which case, you can add it along with your first set of assertations you contribute 10:45 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 10:46 < fanquake> (both to the guix.sigs repo) 10:46 < midnight> aye aye. Just also wanted to reaffirm my appreciation for all of the devs' efforts and care. Much obliged, thank you. 10:47 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 10:49 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 10:56 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 11:39 -!- Guest6661 [~Guest66@117.208.112.193] has joined #bitcoin-core-dev 11:40 -!- Guest6661 [~Guest66@117.208.112.193] has quit [Client Quit] 11:58 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:7889:c073:b49b:b2a3] has joined #bitcoin-core-dev 12:12 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 265 seconds] 12:25 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev 12:44 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:52 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:7889:c073:b49b:b2a3] has quit [Remote host closed the connection] 12:52 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:7889:c073:b49b:b2a3] has joined #bitcoin-core-dev 12:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 252 seconds] 13:41 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has joined #bitcoin-core-dev 14:31 < bitcoin-git> [bitcoin] achow101 opened pull request #26728: wallet: Have the wallet store the key for automatically generated descriptors (master...wallet-knows-master-key) https://github.com/bitcoin/bitcoin/pull/26728 14:35 < bitcoin-git> [bitcoin] achow101 closed pull request #23417: wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager (master...wallet-keyman) https://github.com/bitcoin/bitcoin/pull/23417 15:03 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 15:04 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev 15:06 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 15:12 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 15:12 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 15:18 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Read error: Connection reset by peer] 15:22 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev 15:26 -!- halosghost [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1] 15:46 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:7889:c073:b49b:b2a3] has quit [Ping timeout: 252 seconds] 15:50 -!- PaperSword [~PaperSwor@securemail.qrsnap.io] has joined #bitcoin-core-dev 16:02 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 252 seconds] 17:05 < PaperSword> I am trying to use bech32::Encode and the result string when passed into cout << seems to be completely garbled other than the hrp? 17:16 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 17:18 < sipa> @PaperSword Not sure what you're expecting to see, or what you're seeing. 17:25 -!- b_101_ [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev 17:27 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:28 < PaperSword> @sipa thanks so much for the response, my example would be that I am passing in an array of 32 uint8_t (serialized schnorr pubkey) for the values vector and the hrp is 'bc' with a type is bech32::Encoding::BECH32. 17:28 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 272 seconds] 17:29 < PaperSword> an input such as "45a63115693ff284cc001add4647ea90b89bbc356334a3bac6be96e6644d40cd" will product something like bc1���fn���s��z{c3uu��r7nqj9 17:29 < PaperSword> 32602975f0190b582298dddef79a676bcd6e4f7e7e8a4cd3f2bb9366ebd77d1e 17:29 < PaperSword> produce* 17:30 < sipa> The input needs to be a vector of 5-bit values. 17:30 < PaperSword> Ahh thank you very much 17:30 < sipa> So uint8_t's in range 0 to 31 inclusive. 17:30 < PaperSword> Ahhhh!!! Thanks so much! 17:30 < PaperSword> BTW I am using your library from github :D 17:31 < PaperSword> Thank you so everything you have built 17:31 < sipa> In the Bitcoin Core source code, see key_io.cpp for higher-level conversions between witness programs and addresses. 17:33 < PaperSword> Thanks and yep already been looking at that as part of my search for uses of bech32::Encode 17:33 < PaperSword> Again thanks so much 17:40 < PaperSword> Sorry last question about this but to create the 5bit unit8_t's I just have to take the 256 bits and chunk it in to 52 total unit8_t's 17:40 < sipa> Yes, there is a function ConvertBits for that. 18:36 -!- MrFrancis [~MrFrancis@bl15-115-2.dsl.telepac.pt] has joined #bitcoin-core-dev 18:37 -!- FrancisMr [~MrFrancis@bl15-115-2.dsl.telepac.pt] has joined #bitcoin-core-dev 18:38 -!- FranMr [~MrFrancis@2001:8a0:fa4c:901:70cd:7ac8:9a76:cb5f] has joined #bitcoin-core-dev 18:41 -!- MrFrancis [~MrFrancis@bl15-115-2.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 18:42 -!- FrancisMr [~MrFrancis@bl15-115-2.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 19:13 -!- FranMr [~MrFrancis@2001:8a0:fa4c:901:70cd:7ac8:9a76:cb5f] has quit [Ping timeout: 260 seconds] 19:20 -!- Guest5 [~Guest5@223.178.208.61] has joined #bitcoin-core-dev 19:21 -!- Guest5 [~Guest5@223.178.208.61] has quit [Client Quit] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 22:15 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has quit [Quit: as2333] 22:48 -!- p2plife [~p2plife@vps-46773dd2.vps.ovh.net] has joined #bitcoin-core-dev 23:21 -!- FranMr [~MrFrancis@2001:8a0:fa4c:901:70cd:7ac8:9a76:cb5f] has joined #bitcoin-core-dev 23:52 -!- nanotube [~nanotube@user/nanotube] has quit [Remote host closed the connection] --- Log closed Tue Dec 20 00:00:50 2022