--- Log opened Wed Jan 04 00:00:05 2023 00:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 00:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 256 seconds] 00:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 00:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 248 seconds] 00:14 -!- gwillen [gwillen@user/gwillen] has quit [Ping timeout: 255 seconds] 00:14 -!- gwillen [gwillen@user/gwillen] has joined #bitcoin-core-dev 00:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 00:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 264 seconds] 00:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 00:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 246 seconds] 00:43 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:45 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f8591d46b46...03254c22296a 00:45 < bitcoin-git> bitcoin/master fa818e1 MarcoFalke: txmempool: Remove unused clear() member function 00:45 < bitcoin-git> bitcoin/master 03254c2 glozow: Merge bitcoin/bitcoin#19909: refactor: Remove unused CTxMemPool::clear() h... 00:45 < bitcoin-git> [bitcoin] glozow merged pull request #19909: refactor: Remove unused CTxMemPool::clear() helper (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909 00:47 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 00:48 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 00:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 00:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 252 seconds] 01:02 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev 01:15 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 272 seconds] 01:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 01:27 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 01:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 260 seconds] 01:32 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 01:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 01:56 -!- Guest26 [~Guest26@36.71.141.221] has joined #bitcoin-core-dev 01:56 -!- Guest26 [~Guest26@36.71.141.221] has quit [Client Quit] 01:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 260 seconds] 02:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 02:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 248 seconds] 02:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 02:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03254c22296a...53653060c147 02:12 < bitcoin-git> bitcoin/master 927b8d4 jdjkelly@gmail.com: rpc: Correct RPCHelpMan for fundrawtransaction's input_weights field 02:12 < bitcoin-git> bitcoin/master 5365306 MarcoFalke: Merge bitcoin/bitcoin#26795: rpc: Correct RPCHelpMan for fundrawtransactio... 02:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 248 seconds] 02:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 02:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 264 seconds] 02:22 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev 02:24 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/53653060c147...4717a5aa31bc 02:24 < bitcoin-git> bitcoin/master 22e9afe Murray Nesbitt: use sha256 command instead of sha256sum on FreeBSD 02:24 < bitcoin-git> bitcoin/master 4717a5a fanquake: Merge bitcoin/bitcoin#26772: contrib: fix sha256 check in install_db4.sh f... 02:24 < bitcoin-git> [bitcoin] fanquake merged pull request #26795: rpc: Correct RPCHelpMan for fundrawtransaction's input_weights field (master...rpc/fundrawtransaction-input-weights) https://github.com/bitcoin/bitcoin/pull/26795 02:24 < bitcoin-git> [bitcoin] fanquake merged pull request #26772: contrib: fix sha256 check in install_db4.sh for FreeBSD (master...freebsd_db4_fix) https://github.com/bitcoin/bitcoin/pull/26772 02:27 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 260 seconds] 02:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 02:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 256 seconds] 02:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 02:43 < laanwj> at least ghi is working again 02:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 260 seconds] 02:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 02:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 252 seconds] 02:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 03:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 246 seconds] 03:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 03:05 -!- gnaf [~gnaf@51-15-0-88.rev.poneytelecom.eu] has joined #bitcoin-core-dev 03:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 252 seconds] 03:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 03:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 246 seconds] 03:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 03:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 248 seconds] 03:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 03:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 246 seconds] 03:41 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4717a5aa31bc...2ec97825e708 03:41 < bitcoin-git> bitcoin/master f84e445 Suriyaa Sundararuban: doc: Correct linked Microsoft URLs 03:41 < bitcoin-git> bitcoin/master 2ec9782 fanquake: Merge bitcoin/bitcoin#26771: doc: Correct linked Microsoft URLs 03:41 < bitcoin-git> [bitcoin] fanquake merged pull request #26771: doc: Correct linked Microsoft URLs (master...build-windows) https://github.com/bitcoin/bitcoin/pull/26771 03:58 < bitcoin-git> [bitcoin] fanquake closed pull request #26787: Update build-osx.md (master...master) https://github.com/bitcoin/bitcoin/pull/26787 03:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 04:11 < bitcoin-git> [bitcoin] fanquake opened pull request #26809: compat: use STDIN_FILENO over 0 (master...compat_STDIN_FILENO) https://github.com/bitcoin/bitcoin/pull/26809 04:18 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 04:32 -!- Guest97 [~Guest97@93.175.201.232] has joined #bitcoin-core-dev 04:36 < bitcoin-git> [bitcoin] fanquake opened pull request #26810: debian: remove nonexistent files from copyright (master...remove_redundant_copyright) https://github.com/bitcoin/bitcoin/pull/26810 04:36 -!- Guest97 [~Guest97@93.175.201.232] has quit [Client Quit] 04:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2ec97825e708...4bb840a45311 04:55 < bitcoin-git> bitcoin/master f6eadaa Kristaps Kaupe: Use same Python executable for subprocesses as for all-lint.py 04:55 < bitcoin-git> bitcoin/master 4bb840a MarcoFalke: Merge bitcoin/bitcoin#26802: test: Use same Python executable for subproce... 04:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26802: test: Use same Python executable for subprocesses as for `all-lint.py` (master...all-lint-python-executable) https://github.com/bitcoin/bitcoin/pull/26802 04:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bb840a45311...bf3b58941356 04:59 < bitcoin-git> bitcoin/master fa5cbf2 MarcoFalke: ci: Properly set COMMIT_RANGE in lint task 04:59 < bitcoin-git> bitcoin/master bf3b589 MarcoFalke: Merge bitcoin/bitcoin#26791: ci: Properly set COMMIT_RANGE in lint task 04:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26791: ci: Properly set COMMIT_RANGE in lint task (master...2301-ci-lint-🥗) https://github.com/bitcoin/bitcoin/pull/26791 05:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #26811: test: Add debug log for 25644 (master...2301-test-debug-🕰) https://github.com/bitcoin/bitcoin/pull/26811 05:50 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 06:12 -!- gnaf [~gnaf@51-15-0-88.rev.poneytelecom.eu] has quit [Read error: Connection reset by peer] 06:14 -!- gnaf [~gnaf@51-15-0-88.rev.poneytelecom.eu] has joined #bitcoin-core-dev 06:18 -!- gnaf [~gnaf@51-15-0-88.rev.poneytelecom.eu] has quit [Read error: Connection reset by peer] 06:27 -!- gnaf [~gnaf@51-15-0-88.rev.poneytelecom.eu] has joined #bitcoin-core-dev 06:39 < bitcoin-git> [bitcoin] vasild opened pull request #26812: test: add end-to-end tests for CConnman and PeerManager (master...e2e_tests) https://github.com/bitcoin/bitcoin/pull/26812 06:56 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #26811: test: Add debug log for 25644 (master...2301-test-debug-🕰) https://github.com/bitcoin/bitcoin/pull/26811 06:59 -!- hg [~halosghos@user/halosghost] has joined #bitcoin-core-dev 07:12 -!- gnaf [~gnaf@51-15-0-88.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 07:16 -!- gnaf [~gnaf@212-129-37-129.rev.poneytelecom.eu] has joined #bitcoin-core-dev 07:22 -!- lopo [~lopo@173.205.85.52] has quit [Quit: Leaving] 07:34 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 07:36 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 07:36 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit] 07:38 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev 07:47 -!- lisper29 [~vibs29``@83-87-73-107.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 07:51 < lisper29> bitcoind's (24.0.1) listreceivedbyaddress always returns an empty array for a watch-only wallet when it's of type descriptor (not legacy). Anyone know if that's expected behaviour, or a potential bug? (This problem doesn't occur with a legacy watch-only wallet, only a descriptor watch-only wallet.) Helpful people in #bitcoin suggested I ask in here. Thanks in advance. 07:52 < fanquake> achow101 might be able to help 07:55 < Earnestly> Related, but not exactly: https://github.com/bitcoin/bitcoin/issues/10468 07:56 < achow101> lisper29: sounds like a bug, but I can't replicate it 07:56 < achow101> what parameters are you giving it? 07:58 < lisper29> Awesome, thanks achow101. In that case, I'd better re-run my experiment more carefully. (I did observe that listsince block did work so I could use that as a workaround, or just use a legacy wallet.) 08:02 -!- Guest969 [~Guest96@66.46.59.18] has joined #bitcoin-core-dev 08:04 -!- gnaf [~gnaf@212-129-37-129.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 08:15 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 08:16 < lisper29> achow101: http://www.wispym.com/download/bitcoin_rpc_bug.txt shows a recreation of the problem. 08:18 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 08:20 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 08:23 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 268 seconds] 08:24 < lisper29> achow101: Sorry, I should have listed this query/response. I've updated the bottom of my note. $ bcli.sh -rpcwallet=w2 listreceivedbyaddress 1 true true "" true => [] 08:28 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 260 seconds] 08:28 < achow101> lisper29: thanks, I do replicate the issue now 08:28 < achow101> will investigate 08:29 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 08:30 < lisper29> achow101: That's super to hear. Thanks for trying all this out with me. And thanks fanquake. 08:31 < achow101> lisper29: if you do getaddressinfo for the address in the watchonly wallet, do you see "ischange": true 08:33 < lisper29> achow101: yes, it's set to true. 08:37 < achow101> so the problem is that the wallet thinks the address(es) is change because there is no address book entry. There's no address book entry because you haven't done anything that would give it an address book entry, like use getnewaddress (which adds an entry for the returned address) or use setlabel 08:37 < achow101> and listreceived doesn't show txs for change 08:37 < lisper29> Right, I see 08:38 < achow101> I think you could work around this by setting a label to all of the addresses. 08:38 < achow101> This generally falls under the umbrella of "our change detection sucks" 08:38 < lisper29> ha 08:40 < lisper29> I notice that importdescriptors' help says label is disabled for ranged descriptor. I did try setting the next_index value to something high (900), to see if that would make bitcoind notice, but it didn't. I'll now try your getnewaddress trick on the watch-only wallet. 08:40 < achow101> I think this is the kind of issue that you won't see fixed for a while. can you open an issue on github so we can track it over the long term? 08:41 -!- jon_atack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1] 08:42 < achow101> we might be able to have a workaround with having next_index add address book entries for everything in the range below that index, but that's not implemented yet 08:45 < lisper29> Here's something that works. If I import descriptors with the active=true flag, then ischange is shown as false and listreceivedbyaddress works. (No need for getnewaddress, or more specifically getnewaddress requires active=true, which is what actually solves the problem.) 08:46 -!- Guest969 [~Guest96@66.46.59.18] has quit [Ping timeout: 260 seconds] 08:54 < achow101> hmm, I didn't expect just importing as active to make a difference 08:56 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:59 < achow101> oh, I guess it does when rescanning. if it's active, we can infer whether the address is change when we rescan. 09:01 < lisper29> Ah, I see. Cool. 09:12 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bf3b58941356...139ba2bf121c 09:12 < bitcoin-git> bitcoin/master 3a4f8bc furszy: bench: add benchmark for wallet 'AvailableCoins' function. 09:12 < bitcoin-git> bitcoin/master 139ba2b Andrew Chow: Merge bitcoin/bitcoin#25234: bench: add benchmark for wallet 'AvailableCoi... 09:12 < bitcoin-git> [bitcoin] achow101 merged pull request #25234: bench: add benchmark for wallet 'AvailableCoins' function. (master...2022_bench_wallet_available_coins) https://github.com/bitcoin/bitcoin/pull/25234 09:17 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [] 09:19 < lisper29> achow101: I've created this as you suggested: https://github.com/bitcoin/bitcoin/issues/26813 09:19 < achow101> thanks 09:24 -!- gnaf [~gnaf@212-83-182-127.rev.poneytelecom.eu] has joined #bitcoin-core-dev 09:29 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:31 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 09:31 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.7.1] 09:32 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 09:39 -!- as2333 [~as2333@host170.181-12-230.telecom.net.ar] has joined #bitcoin-core-dev 09:42 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/139ba2bf121c...a27324148089 09:42 < bitcoin-git> bitcoin/master b942c94 yancy: test: Change coinselection parameter location to make tests independent 09:42 < bitcoin-git> bitcoin/master a273241 Andrew Chow: Merge bitcoin/bitcoin#26020: test: Change coinselection parameter location... 09:42 < bitcoin-git> [bitcoin] achow101 merged pull request #26020: test: Change coinselection parameter location to make tests independent (master...fix-bnb-search-test-param) https://github.com/bitcoin/bitcoin/pull/26020 09:43 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev 09:49 -!- franbopple [~franboppl@20.1.142.20] has joined #bitcoin-core-dev 09:54 < bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a27324148089...65ecf24b5c42 09:54 < bitcoin-git> bitcoin/master bf19069 w0xlt: wallet: remove `mempool_sequence` from `transactionAddedToMempool` 09:54 < bitcoin-git> bitcoin/master 55696a0 w0xlt: wallet: remove `mempool_sequence` from `transactionRemovedFromMempool` 09:54 < bitcoin-git> bitcoin/master 65ecf24 glozow: Merge bitcoin/bitcoin#26752: wallet: Remove `mempool_sequence` from interf... 09:54 < bitcoin-git> [bitcoin] glozow merged pull request #26752: wallet: Remove `mempool_sequence` from interface methods (master...remove_mempool_sequence) https://github.com/bitcoin/bitcoin/pull/26752 10:02 < bitcoin-git> [bitcoin] fanquake opened pull request #26814: random: remove windows-only compat.h usage (master...prune_compat_random) https://github.com/bitcoin/bitcoin/pull/26814 10:08 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 256 seconds] 10:08 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65ecf24b5c42...196a43eddb96 10:08 < bitcoin-git> bitcoin/master f537127 stickies-v: doc: fix: prevHeights entries are set to 0, not removed 10:08 < bitcoin-git> bitcoin/master 196a43e glozow: Merge bitcoin/bitcoin#26603: doc: CalculateSequenceLocks: prevHeights entr... 10:08 < bitcoin-git> [bitcoin] glozow merged pull request #26603: doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed (master...docs-fix-CalculateSequenceLocks) https://github.com/bitcoin/bitcoin/pull/26603 10:10 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds] 10:12 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 10:17 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 260 seconds] 10:19 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev 10:28 -!- b_101_ [~robert@189.236.6.68] has joined #bitcoin-core-dev 10:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev 10:31 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 260 seconds] 10:33 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev 10:36 -!- b_101_ [~robert@189.236.6.68] has quit [Ping timeout: 264 seconds] 11:06 -!- gnaf [~gnaf@212-83-182-127.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 12:07 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 12:09 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 12:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Remote host closed the connection] 12:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 12:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 265 seconds] 12:56 < bitcoin-git> [bitcoin] zpv opened pull request #26815: builder-keys: remove luke-jr (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26815 13:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 252 seconds] 13:04 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Ping timeout: 264 seconds] 13:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has joined #bitcoin-core-dev 13:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8154:1e21:9600:cb7a] has quit [Client Quit] 13:36 < jamesob> If I'm consuming a PUSHDATA value in EvalScript, let's say a hash, it's encoded in little-endian, right? So that means if I want to cast it to uint256, I'd have to reverse the bytearray? 13:36 < sipa> Script elements are byte arrays. It has no concept of numbers. 13:37 < sipa> The opcode takes the bytes from the script, and creates a stack element with those bytes, in the order they were specified. 13:37 < jamesob> Ah okay, of course. Thanks 13:38 < sipa> If you want to show those bytes in a human readable-way, because you happen to know they represent a hash (something script doesn't know or care about), then you'll indeed want to reverse them 13:38 < sipa> But that's just a human representation issue 14:18 -!- halo [~halosghos@user/halosghost] has joined #bitcoin-core-dev 14:19 -!- hg [~halosghos@user/halosghost] has quit [Ping timeout: 265 seconds] 14:31 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/196a43eddb96...cabeae43ea6e 14:31 < bitcoin-git> bitcoin/master 585c672 fanquake: compat: use STDIN_FILENO over 0 14:31 < bitcoin-git> bitcoin/master cabeae4 Andrew Chow: Merge bitcoin/bitcoin#26809: compat: use STDIN_FILENO over 0 14:37 -!- halo [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1] 14:40 < bitcoin-git> [bitcoin] achow101 closed pull request #26809: compat: use STDIN_FILENO over 0 (master...compat_STDIN_FILENO) https://github.com/bitcoin/bitcoin/pull/26809 14:46 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cabeae43ea6e...360e047a7102 14:46 < bitcoin-git> bitcoin/master 8c7222b Sebastian Falbesoner: wallet: fix GUI crash on cross-chain legacy wallet restore 14:46 < bitcoin-git> bitcoin/master 21ad4e2 Sebastian Falbesoner: test: add coverage for cross-chain wallet restore 14:46 < bitcoin-git> bitcoin/master 360e047 Andrew Chow: Merge bitcoin/bitcoin#26747: wallet: fix confusing error / GUI crash on cr... 14:47 < bitcoin-git> [bitcoin] achow101 merged pull request #26747: wallet: fix confusing error / GUI crash on cross-chain legacy wallet restore (master...202212-wallet-fix_restorewallet_bdb_crosschain) https://github.com/bitcoin/bitcoin/pull/26747 15:06 -!- franbopple [~franboppl@20.1.142.20] has left #bitcoin-core-dev [] 15:07 -!- franbopzle [~franboppl@20.1.142.20] has joined #bitcoin-core-dev 16:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 16:05 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-core-dev 16:36 -!- drue [~drue@ec2-18-216-100-168.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 16:53 -!- javi404 [~quassel@c-73-1-238-68.hsd1.fl.comcast.net] has quit [Ping timeout: 260 seconds] 17:13 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 17:19 -!- mudsip [~mudsip@user/mudsip] has quit [] 17:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 264 seconds] 17:53 -!- b_101_ [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev 17:56 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 260 seconds] 17:57 -!- franbopzle [~franboppl@20.1.142.20] has quit [Ping timeout: 246 seconds] 18:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 18:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:05 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 260 seconds] 18:24 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev 20:01 -!- lisper29 [~vibs29``@83-87-73-107.cable.dynamic.v4.ziggo.nl] has quit [Quit: Leaving] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:35 -!- Guest67 [~Guest67@89.187.164.137] has joined #bitcoin-core-dev 21:36 -!- Guest67 [~Guest67@89.187.164.137] has quit [Client Quit] 21:48 -!- Guest91 [~Guest91@173-255-172-85.msp.as54203.net] has joined #bitcoin-core-dev 21:55 -!- Guest91 [~Guest91@173-255-172-85.msp.as54203.net] has quit [Quit: Client closed] 22:00 -!- as2333 [~as2333@host170.181-12-230.telecom.net.ar] has quit [Quit: as2333] 22:18 -!- javi404 [~quassel@c-73-1-238-68.hsd1.fl.comcast.net] has joined #bitcoin-core-dev --- Log closed Thu Jan 05 00:00:05 2023