--- Log opened Sun Jan 15 00:00:15 2023
00:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
00:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 256 seconds]
00:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
00:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
00:40 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
00:44 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 272 seconds]
01:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
01:15 -!- salvatoshi [~salvatosh@lfbn-idf3-1-333-227.w83-199.abo.wanadoo.fr] has joined #bitcoin-core-dev
01:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
01:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
01:23 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Ping timeout: 255 seconds]
01:25 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
01:44 -!- b_101 [~robert@216.144.236.70] has quit [Ping timeout: 268 seconds]
02:02 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
02:03 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has joined #bitcoin-core-dev
02:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
02:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
02:17 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has joined #bitcoin-core-dev
02:28 -!- b_101 [~robert@216.144.236.70] has joined #bitcoin-core-dev
02:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
02:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
03:15 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
03:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
03:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 256 seconds]
03:33 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
03:35 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has quit [Remote host closed the connection]
03:35 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has joined #bitcoin-core-dev
03:43 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has joined #bitcoin-core-dev
03:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
03:59 -!- b_101 [~robert@216.144.236.70] has quit [Ping timeout: 252 seconds]
04:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
04:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
04:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:dc58:a617:91dc:f3b2] has joined #bitcoin-core-dev
04:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
04:22 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Remote host closed the connection]
04:24 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
05:02 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has quit [Remote host closed the connection]
05:11 < bitcoin-git> [bitcoin] mruddy closed pull request #26535: reindex: allow finalized blk files to use read-only permissions (master...issue_2039_readonly_finalized_blk_files) https://github.com/bitcoin/bitcoin/pull/26535
05:53 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
05:58 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
06:13 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has joined #bitcoin-core-dev
06:19 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has quit [Ping timeout: 255 seconds]
06:25 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has joined #bitcoin-core-dev
06:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
06:49 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
07:03 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
07:03 < theStack> phantomcircuit: right. to quote bip 158: "The parameter k MUST be set to the first 16 bytes of the hash (in standard little-endian representation) of the block for which the filter is constructed. This ensures the key is deterministic while still varying from block to block."
07:05 < bitcoin-git> [bitcoin] SmashedFrenzy16 opened pull request #26893: Update CONTRIBUTING.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/26893
07:07 < bitcoin-git> [bitcoin] fanquake closed pull request #26893: Update CONTRIBUTING.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/26893
07:10 < sipa> theStack: phantomcircuit is suggesting not using bip158 filters for rescanning, but another filter type, where instead of the deterministic bip158 per-block-salted one, a static per-host one is used.
07:11 < sipa> bip158's point is being able to provide bip157 filters over the network, which must be deterministic... and once you have those, you might as well use them for rescanning
07:11 < sipa> but if your goal is just rescanning, a much more efficient approach is possible
07:14 < theStack> sipa: oh, that would then be block filters that would _only_ be useful locally and never served to peers?
07:14 < sipa> yes
07:14 < sipa> (which also means there is much less need for standardization etc on them)
07:15 < theStack> okay, interesting
07:32 -!- jirigrill [~jirigrill@212.187.202.158] has joined #bitcoin-core-dev
07:36 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 272 seconds]
07:45 -!- jirigrill [~jirigrill@212.187.202.158] has quit [Quit: Ping timeout (120 seconds)]
07:45 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has quit [Ping timeout: 252 seconds]
07:49 -!- jirigrill [~jirigrill@212.187.202.158] has joined #bitcoin-core-dev
07:57 < theStack> phantomcircuit: "it's weird to benchmark because it only shows up when you have a lot of elements in the set" <- by default a freshly created descriptor wallet starts with a filter set of 8000 scriptPubKeys, increasing with every top-up... is that already in the ball-park of "a lot of elements" w.r.t. your benchmark results? :p
08:00 -!- jirigrill [~jirigrill@212.187.202.158] has quit [Ping timeout: 260 seconds]
08:22 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
08:23 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Remote host closed the connection]
08:23 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has joined #bitcoin-core-dev
08:23 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
08:27 -!- jirigrill [~jirigrill@ip-86-49-229-17.bb.vodafone.cz] has joined #bitcoin-core-dev
08:32 -!- jirigrill [~jirigrill@ip-86-49-229-17.bb.vodafone.cz] has quit [Ping timeout: 260 seconds]
09:04 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Remote host closed the connection]
09:05 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
09:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
09:20 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has quit [Ping timeout: 248 seconds]
09:45 < Murch1> From what I understand, the problem is that all 8k keys need to be resalted for every block that you look at. If you generated a second set of filters that were salted all the same way, you would skip the 8000×block count key resaltings
09:45 < sipa> Exactly.
09:47 < sipa> But you do need some salting, or attackers could construct a multitude of transactions designed to cause collisions in the filter's hash function.
09:48 < sipa> So the one alternative is having a per-node salt, using a locally generated secret key, stored in the filter itself.
09:51 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev
09:53 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Client Quit]
09:54 -!- as2333 [~as2333@host214.181-12-220.telecom.net.ar] has joined #bitcoin-core-dev
10:00 -!- b_101 [~robert@187.202.220.88] has joined #bitcoin-core-dev
10:04 -!- b_101 [~robert@187.202.220.88] has quit [Ping timeout: 252 seconds]
10:05 < theStack> sipa: to cause collisions, wouldn't an attacker need to know the exact set of scriptPubKeys that an user is scanning for? 
10:09 < sipa> theStack: Well, yes, but if everyone is using the same salt, it's predictable, and anything in the block may be interesting to someone.
10:09 < sipa> Either because there are clients interested in everything, or because the attacker is involved in transactions with the victim.
10:17 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has joined #bitcoin-core-dev
10:42 < ariard> achow101: sure -- i'll add a note on the pr before next meeting
10:56 < bitcoin-git> [gui] hebasto merged pull request #690: Catch invalid networks combination crash (master...2022_gui_catch_netparam_crash) https://github.com/bitcoin-core/gui/pull/690
10:56 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c2a1288a210...3dd2762cf839
10:56 < bitcoin-git> bitcoin/master f4a11d7 furszy: gui: bugfix, catch invalid networks combination crash
10:56 < bitcoin-git> bitcoin/master 3dd2762 Hennadii Stepanov: Merge bitcoin-core/gui#690: Catch invalid networks combination crash
11:16 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:25 -!- szarka [~szarka@24-124-20-18-static.midco.net] has quit [Ping timeout: 265 seconds]
11:42 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:44 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:46 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit]
11:48 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:48 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
11:49 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:52 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:03 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
12:04 -!- Norrin [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Remote host closed the connection]
12:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:dc58:a617:91dc:f3b2] has quit [Remote host closed the connection]
12:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
12:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Remote host closed the connection]
12:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
12:43 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 260 seconds]
12:47 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 268 seconds]
13:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
13:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:10 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.7.1]
13:13 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
13:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
13:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:dc58:a617:91dc:f3b2] has joined #bitcoin-core-dev
13:24 -!- as2333 [~as2333@host214.181-12-220.telecom.net.ar] has quit [Ping timeout: 264 seconds]
13:25 -!- as2333 [~as2333@host214.181-12-220.telecom.net.ar] has joined #bitcoin-core-dev
13:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:dc58:a617:91dc:f3b2] has quit [Ping timeout: 246 seconds]
13:29 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:39 -!- as2333 [~as2333@host214.181-12-220.telecom.net.ar] has quit [Remote host closed the connection]
13:40 -!- as2333 [~as2333@host214.181-12-220.telecom.net.ar] has joined #bitcoin-core-dev
13:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
13:44 -!- salvatoshi [~salvatosh@lfbn-idf3-1-333-227.w83-199.abo.wanadoo.fr] has quit [Ping timeout: 264 seconds]
13:45 -!- as2333 [~as2333@host214.181-12-220.telecom.net.ar] has quit [Ping timeout: 264 seconds]
13:45 -!- blbl2 [~as2333@host50.181-12-221.telecom.net.ar] has joined #bitcoin-core-dev
13:46 -!- blbl2 [~as2333@host50.181-12-221.telecom.net.ar] has left #bitcoin-core-dev []
13:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 256 seconds]
14:02 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.8]
14:04 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
14:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
14:06 -!- as2333 [~as2333@host168.190-138-75.telecom.net.ar] has joined #bitcoin-core-dev
14:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
14:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
14:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
14:21 -!- as2333 [~as2333@host168.190-138-75.telecom.net.ar] has quit [Remote host closed the connection]
14:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
14:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
14:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
14:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
14:38 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has quit [Ping timeout: 252 seconds]
15:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
15:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 246 seconds]
15:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
15:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
15:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
15:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
15:29 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
15:32 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev
15:34 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 268 seconds]
15:38 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Remote host closed the connection]
16:06 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
16:12 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 268 seconds]
16:13 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
16:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
16:17 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 260 seconds]
16:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
16:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
16:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
16:32 -!- as2333 [~as2333@host168.190-138-75.telecom.net.ar] has joined #bitcoin-core-dev
16:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 255 seconds]
16:35 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 252 seconds]
16:46 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
16:58 < bitcoin-git> [bitcoin] KolbyML opened pull request #26894: test: Remove redundant function call (master...test-redundant-assignment) https://github.com/bitcoin/bitcoin/pull/26894
17:01 -!- Guest36 [~Guest36@2600:6c5d:67f:5c2b:8c24:8829:9b3d:ec8c] has joined #bitcoin-core-dev
17:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
17:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
17:11 -!- Guest36 [~Guest36@2600:6c5d:67f:5c2b:8c24:8829:9b3d:ec8c] has quit [Ping timeout: 260 seconds]
17:13 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
17:15 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
17:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
17:18 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 272 seconds]
17:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
17:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
17:27 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has joined #bitcoin-core-dev
17:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
17:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
17:39 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has quit [Remote host closed the connection]
17:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
17:40 < phantomcircuit> theStack: no 8k elements is quite small, older non descriptor wallets often had on the order of 100k keys
17:42 < phantomcircuit> sipa: it was suggested that the filters could use the same key as the block obfuscation, but that isn't currently guaranteed to be a real key, it's been there for a long time though, maybe logic to guarantee the block obfuscation key is non-zero would be accepted now?
17:42 < phantomcircuit> (either just asserting that the key is non-zero or migrating zero key blocks to non-zero)
17:44 < sipa> It's also only a 64-bit key, the obfuscation one.
17:44 < sipa> I think it'd be a lot easier to have an independent key; the filters are already very separate code organization wise too.
17:44 < phantomcircuit> sipa: the filters are siphash , so a 64 bit key is probably fine anyways?
17:44 < sipa> If we'd want to do something like that.
17:46 < phantomcircuit> sipa: or are these some 128 bit siphash variant?
17:47 < phantomcircuit> oh it's a 64 bit result from a 128 bit key
17:47 < sipa> siphash has a 128 bit key
17:47 < phantomcircuit> nvm
17:47 -!- weylin_ [~weylin@2600:8800:4005:6d00:61c3:a6da:f46f:a942] has joined #bitcoin-core-dev
17:50 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
17:54 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
17:55 < phantomcircuit> sipa: any opinion on where that key should go
17:55 < sipa> in the filter itself?
17:56 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 265 seconds]
17:56 < phantomcircuit> sipa: i maybe can do that, iirc it's kind of annoying because of the existing format not having any version
17:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
17:57 < phantomcircuit> sipa: i guess there's GCS_SER_VERSION actually
17:58 < sipa> this would be a totally separate index, i'd imagine
17:59 < phantomcircuit> sipa: yes, there's a BlockFilterType that i could use but i think just doing it as a completely separate thing would be easier
18:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
18:08 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
18:10 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:8c24:4d07:ca49:2d65] has quit [Ping timeout: 248 seconds]
18:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds]
18:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
18:27 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
18:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
18:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
18:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
18:43 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
18:48 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 268 seconds]
18:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
18:58 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 252 seconds]
18:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
19:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
19:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
19:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
19:10 < bitcoin-git> [bitcoin] ThatGuy000001 opened pull request #26895: Update BitcoinCore.md (master...master) https://github.com/bitcoin/bitcoin/pull/26895
19:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
19:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
19:22 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404]
19:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
19:28 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has joined #bitcoin-core-dev
19:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
19:35 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
19:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
19:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 255 seconds]
19:46 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Ping timeout: 255 seconds]
19:47 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
19:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
19:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
19:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
20:00 < bitcoin-git> [bitcoin] achow101 closed pull request #26895: Update BitcoinCore.md (master...master) https://github.com/bitcoin/bitcoin/pull/26895
20:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
20:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
20:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 255 seconds]
20:08 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
20:12 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 255 seconds]
20:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
20:16 -!- Guest13 [~Guest13@202.9.41.11] has joined #bitcoin-core-dev
20:16 -!- Guest13 [~Guest13@202.9.41.11] has quit [Client Quit]
20:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:18 -!- Guest13 [~Guest13@202.9.41.11] has joined #bitcoin-core-dev
20:18 -!- Guest13 [~Guest13@202.9.41.11] has quit [Client Quit]
20:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
20:37 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
20:40 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
20:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
20:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
20:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
20:56 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
20:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
20:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 264 seconds]
21:24 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
21:29 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
21:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
21:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
21:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
21:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
22:17 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev
22:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
22:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 255 seconds]
22:27 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving]
22:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
22:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 252 seconds]
22:37 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
22:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
22:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 260 seconds]
23:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
23:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
23:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
23:08 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
23:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 256 seconds]
23:16 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Ping timeout: 255 seconds]
23:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
23:18 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
23:19 -!- as2333 [~as2333@host168.190-138-75.telecom.net.ar] has quit [Remote host closed the connection]
23:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 265 seconds]
23:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
23:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has quit [Ping timeout: 248 seconds]
23:29 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-dev
23:34 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds]
23:38 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has quit [Ping timeout: 255 seconds]
23:41 -!- AmunRa [~NorrinRad@gateway/tor-sasl/norrinradd] has joined #bitcoin-core-dev
23:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
23:45 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
23:48 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 246 seconds]
23:49 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
23:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8af:6398:55d:8e67] has joined #bitcoin-core-dev
--- Log closed Mon Jan 16 00:00:16 2023