--- Log opened Thu Mar 23 00:00:18 2023
00:08 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
00:10 -!- dongcarl [~dongcarl@cpe-66-65-169-19.nyc.res.rr.com] has quit [Read error: Connection reset by peer]
00:12 -!- dongcarl [~dongcarl@cpe-66-65-169-19.nyc.res.rr.com] has joined #bitcoin-core-dev
00:13 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 276 seconds]
00:14 -!- chipxxx [~chip@2001:8a0:f620:6500:8f6d:c640:c292:171c] has quit [Quit: Leaving]
00:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
00:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 246 seconds]
00:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
00:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 265 seconds]
00:35 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
00:39 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
00:52 -!- greypw25460021 [~greypw254@grey.pw] has quit [Quit: Ping timeout (120 seconds)]
00:53 -!- greypw25460021 [~greypw254@grey.pw] has joined #bitcoin-core-dev
00:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
01:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 256 seconds]
01:06 -!- Thoams [~Thoams@88.97.45.247] has joined #bitcoin-core-dev
01:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
01:19 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
01:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
01:20 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 265 seconds]
01:29 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:50 -!- Thoams [~Thoams@88.97.45.247] has quit [Ping timeout: 246 seconds]
01:58 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
01:59 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
02:00 -!- Jiri[m] [~jirijirij@2001:470:69fc:105::2:c0a7] has quit [Quit: You have been kicked for being idle]
02:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 265 seconds]
02:08 < bitcoin-git> [bitcoin] hebasto opened pull request #27311: ci: Use clang-15 in "tidy" task (master...230322-clang15) https://github.com/bitcoin/bitcoin/pull/27311
02:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
02:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 240 seconds]
02:24 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
02:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
02:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 246 seconds]
02:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has joined #bitcoin-core-dev
02:46 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
02:48 -!- chipxxx [~chip@2001:8a0:f620:6500:8f6d:c640:c292:171c] has joined #bitcoin-core-dev
02:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:9806:274d:a015:60ce] has quit [Ping timeout: 256 seconds]
02:56 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
03:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
03:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4c6b7d330a4e...2fadb261b6b6
03:17 < bitcoin-git> bitcoin/master faf3f12 MarcoFalke: refactor: Replace GetTimeMicros by SystemClock
03:17 < bitcoin-git> bitcoin/master 2fadb26 fanquake: Merge bitcoin/bitcoin#27233: refactor: Replace GetTimeMicros by SystemClock
03:17 < bitcoin-git> [bitcoin] fanquake merged pull request #27233: refactor: Replace GetTimeMicros by SystemClock (master...2303-time-🎁) https://github.com/bitcoin/bitcoin/pull/27233
03:35 < bitcoin-git> [bitcoin] fanquake opened pull request #27312: depends: qrencode 4.1.1 (master...qrencode_4_1_1) https://github.com/bitcoin/bitcoin/pull/27312
04:01 -!- cold [~cold@user/cold] has quit [Ping timeout: 250 seconds]
04:02 -!- midnight_ [~midnight@user/midnight] has joined #bitcoin-core-dev
04:02 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 255 seconds]
04:03 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
04:41 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
04:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:48 -!- chipxxx [~chip@2001:8a0:f620:6500:8f6d:c640:c292:171c] has quit [Ping timeout: 248 seconds]
05:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
05:13 -!- b_101_ [~robert@185.242.5.35] has joined #bitcoin-core-dev
05:14 -!- b_101 [~robert@185.242.5.35] has quit [Ping timeout: 268 seconds]
06:07 -!- Guest71 [~Guest71@92.223.93.158] has joined #bitcoin-core-dev
06:17 -!- Guest7171 [~Guest71@92.223.93.158] has joined #bitcoin-core-dev
06:18 -!- Guest71 [~Guest71@92.223.93.158] has quit [Ping timeout: 260 seconds]
06:20 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
06:25 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 256 seconds]
06:28 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2fadb261b6b6...f380bb93e854
06:28 < bitcoin-git> bitcoin/master 8fe27fb Hennadii Stepanov: ci: Use clang-15 in "tidy" task
06:28 < bitcoin-git> bitcoin/master f380bb9 fanquake: Merge bitcoin/bitcoin#27311: ci: Use clang-15 in "tidy" task
06:28 < bitcoin-git> [bitcoin] fanquake merged pull request #27311: ci: Use clang-15 in "tidy" task (master...230322-clang15) https://github.com/bitcoin/bitcoin/pull/27311
06:36 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:2d0c:f22:9b50:e15] has joined #bitcoin-core-dev
06:39 -!- pablomartin [~pablomart@89.38.69.249] has joined #bitcoin-core-dev
06:40 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f380bb93e854...8acfb1f8e045
06:40 < bitcoin-git> bitcoin/master fab9a08 MarcoFalke: refactor: Replace block_hash with block_out
06:40 < bitcoin-git> bitcoin/master fa18504 MarcoFalke: rpc: Add submit option to generateblock
06:40 < bitcoin-git> bitcoin/master 8acfb1f fanquake: Merge bitcoin/bitcoin#18933: rpc: Add submit option to generateblock
06:41 < bitcoin-git> [bitcoin] fanquake merged pull request #18933: rpc: Add submit option to generateblock (master...2004-rpcBlock) https://github.com/bitcoin/bitcoin/pull/18933
06:46 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 250 seconds]
06:48 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
06:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
06:55 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:09 < bitcoin-git> [bitcoin] hebasto closed pull request #27301: depends: fontconfig 2.14.2 (master...fontconfig_2_14_2) https://github.com/bitcoin/bitcoin/pull/27301
07:09 < bitcoin-git> [bitcoin] hebasto reopened pull request #27301: depends: fontconfig 2.14.2 (master...fontconfig_2_14_2) https://github.com/bitcoin/bitcoin/pull/27301
07:22 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
07:28 -!- jamesob [~jamesob@141.156.173.67] has quit [Read error: Connection reset by peer]
07:28 -!- jamesob9 [~jamesob@141.156.173.67] has quit [Read error: Connection reset by peer]
07:28 -!- jamesob [~jamesob@141.156.173.67] has joined #bitcoin-core-dev
07:28 -!- jamesob9 [~jamesob@141.156.173.67] has joined #bitcoin-core-dev
07:29 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
07:32 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 252 seconds]
07:35 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] hebasto opened pull request #27314: build, qt: Fix handling of `CXX=clang++` when building `qt` package (master...230323-qt-clang) https://github.com/bitcoin/bitcoin/pull/27314
07:43 < bitcoin-git> [bitcoin] fanquake closed pull request #26296: [DEMO] Integrate `bitcoin-tidy` clang-tidy plugin - warn on uninitialized members of aggregate types (master...integrate_cory_tidy) https://github.com/bitcoin/bitcoin/pull/26296
07:52 -!- Thoams [~Thoams@88.97.45.247] has joined #bitcoin-core-dev
07:55 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 250 seconds]
08:00 < bitcoin-git> [bitcoin] fanquake closed pull request #27301: depends: fontconfig 2.14.2 (master...fontconfig_2_14_2) https://github.com/bitcoin/bitcoin/pull/27301
08:10 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8acfb1f8e045...483fb8d2165b
08:10 < bitcoin-git> bitcoin/master fa0696e MarcoFalke: test: Replace threading with concurrent.futures
08:10 < bitcoin-git> bitcoin/master 483fb8d fanquake: Merge bitcoin/bitcoin#27287: test: Replace threading with concurrent.futur...
08:10 < bitcoin-git> [bitcoin] fanquake merged pull request #27287: test: Replace threading with concurrent.futures (master...2303-test-check-return-value-😝) https://github.com/bitcoin/bitcoin/pull/27287
08:17 -!- Guest7171 [~Guest71@92.223.93.158] has quit [Quit: Client closed]
08:36 -!- pablomartin [~pablomart@89.38.69.249] has quit [Ping timeout: 252 seconds]
08:36 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Remote host closed the connection]
08:37 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
08:41 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 248 seconds]
08:50 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
08:54 < bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/483fb8d2165b...381593c906fb
08:54 < bitcoin-git> bitcoin/master acf0119 furszy: wallet: return error msg for too-long-mempool-chain failure
08:54 < bitcoin-git> bitcoin/master f3221d3 furszy: test: add wallet too-long-mempool-chain error coverage
08:54 < bitcoin-git> bitcoin/master 381593c glozow: Merge bitcoin/bitcoin#24845: wallet: return error msg for  "too-long-mempo...
08:54 < bitcoin-git> [bitcoin] glozow merged pull request #24845: wallet: return error msg for  "too-long-mempool-chain" (master...2022_wallet_operationresult) https://github.com/bitcoin/bitcoin/pull/24845
09:11 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
09:53 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
09:54 -!- Thoams [~Thoams@88.97.45.247] has quit [Ping timeout: 260 seconds]
10:06 < bitcoin-git> [gui] rebroad closed pull request #720: Correct poor grammar in wallet synchronization warning. (master...UpdateSyncWarningText) https://github.com/bitcoin-core/gui/pull/720
10:32 < bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/381593c906fb...23056436461a
10:32 < bitcoin-git> bitcoin/master ad44aa5 dergoegge: [net] Add connection type getter to CNode
10:32 < bitcoin-git> bitcoin/master cc5cdf8 dergoegge: [net] Deduplicate marking received message for processing
10:32 < bitcoin-git> bitcoin/master 897e342 dergoegge: [net] Encapsulate CNode message polling
10:32 < bitcoin-git> [bitcoin] fanquake merged pull request #27257: refactor, net: End friendship of CNode, CConnman and ConnmanTestMsg (master...2023-03-cnode-friends) https://github.com/bitcoin/bitcoin/pull/27257
10:35 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
10:57 -!- pablomartin [~pablomart@109.70.150.158] has joined #bitcoin-core-dev
11:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
11:06 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 276 seconds]
11:46 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
11:46 -!- preimage [~halosghos@user/halosghost] has quit [Client Quit]
11:49 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
11:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:00 < achow101> #startmeeting
12:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack vasild
12:00 < brunoerg> hi
12:00 < pinheadmz> hi
12:00 < hebasto> hi
12:00 < LarryRuane> Hi
12:01 < achow101> There are no pre-proposed meeting topics this week. Does anyone have any last minute topics to discuss?
12:01 < achow101> #topic High Priority for review
12:02 < achow101> https://github.com/orgs/bitcoin/projects/1 anything to add, remove, or merge?
12:02 < luke-jr> hi
12:02 < kouloumos> hi
12:02 < jon_atack> hi
12:03 < achow101> also, a reminder that the 25.0 feature freeze is coming up soon on April 1
12:03 < pinheadmz> #27039 is pretty close, ACK from lightlike, pretty much just a one line change with unit and func tests
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/27039 | blockstorage: do not flush block to disk if it is already there by pinheadmz · Pull Request #27039 · bitcoin/bitcoin · GitHub
12:05 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Remote host closed the connection]
12:05 < achow101> seems there's nothing to discuss this week
12:05 < achow101> #endmeeting
12:05 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
12:05 < jon_atack> https://github.com/bitcoin/bitcoin/pull/26957 might be rfm, would help ensure no perf regressions while moving forward on severity-based logging
12:06 < luke-jr> seems like the bot is broken
12:06 < achow101> fyi, I'm going to be out for the next 2 weeks, which means I'll miss the wallet meeting tomorrow and the one 2 weeks from now. would be nice if someone else could pick those up, otherwise we can skip them
12:07 < achow101> luke-jr: which bot?
12:07 < luke-jr> meeting bot?
12:07 -!- core-meetingbot` [~meetingbo@2a01:4f9:2a:2510::2] has quit [Quit: 2019.02.23]
12:07 < achow101> oh yeah, didn't even notice lol
12:07 -!- core-meetingbot [~meetingbo@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev
12:07 < luke-jr> XD
12:07 < achow101> it's at least reading the channel since it sends me a pm when I start the meeting
12:08 < achow101> maybe it just can't post?
12:08 < jonasschnelli> just restarted the meetingbot
12:08 < luke-jr> it had a nonstandard nick
12:08 < luke-jr> so maybe wasn't identified
12:08 < jonasschnelli> meetings where logged IMO: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2023/
12:09 < achow101> looks like they were logged correctly
12:10 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 265 seconds]
12:10 < jonasschnelli> bot unregisters from nickserv after a while and I need to manually re-identify in order for the bot to have voice rights
12:11 < achow101> ah, could be the +R that was set a few months ago
12:11 < jonasschnelli> logging works,... the bot messages are redirected to the nirvana though
12:11 < jonasschnelli> (I guess it was always the case)
12:12 < achow101> could maybe remove that restriction now?
12:12 < jonasschnelli> core-meetingbot ping
12:12 < core-meetingbot> pong
12:13 < jonasschnelli> is +R making only nickserv registered having voice?
12:13 < achow101> yes
12:13 < jonasschnelli> I guess its fine... my script probably should periodical identify itself again
12:15 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Read error: Connection reset by peer]
12:15 < achow101> that would be preferable
12:16 -!- preimage [~halosghos@user/halosghost] has quit [Ping timeout: 252 seconds]
12:16 -!- angusp [9e8eed9774@2604:bf00:561:2000::1048] has quit [Read error: Connection reset by peer]
12:16 < stickies-v> could https://github.com/bitcoin/bitcoin/pull/27253 be added to the 25.0 milestone? I think it's quite important this makes it in.
12:17 < achow101> stickies-v: added
12:17 < stickies-v> ty
12:20 < bitcoin-git> [bitcoin] john-moffett opened pull request #27317: log: Check that the timestamp string is non-empty to avoid undefined behavior (master...2023_04_FixTimestampPotentialUB) https://github.com/bitcoin/bitcoin/pull/27317
12:21 -!- angusp [9e8eed9774@2604:bf00:561:2000::1048] has joined #bitcoin-core-dev
12:21 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
12:22 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #27237: test: getblock on header throws (master...2303-test-block-header-throw-📞) https://github.com/bitcoin/bitcoin/pull/27237
12:31 -!- licensed [~licensed@189-25-135-248.user3p.veloxzone.com.br] has joined #bitcoin-core-dev
12:32 -!- Thoams [~Thoams@88.97.45.247] has joined #bitcoin-core-dev
12:39 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
12:39 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
12:42 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
12:47 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 240 seconds]
12:48 < bitcoin-git> [bitcoin] furszy opened pull request #27318: test: wallet_create_tx.py fix race (master...2022_walletcreatetx_fix_race) https://github.com/bitcoin/bitcoin/pull/27318
12:48 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:2d0c:f22:9b50:e15] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:51 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:2d0c:f22:9b50:e15] has joined #bitcoin-core-dev
12:54 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:2d0c:f22:9b50:e15] has quit [Client Quit]
12:57 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:2d0c:f22:9b50:e15] has joined #bitcoin-core-dev
13:05 -!- licensed [~licensed@189-25-135-248.user3p.veloxzone.com.br] has quit [Quit: licensed]
13:16 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
13:21 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 255 seconds]
13:23 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
13:25 < bitcoin-git> [bitcoin] brunoerg opened pull request #27319: addrman, refactor: improve stochastic test in `AddSingle` (master...2023-03-addrman-improv) https://github.com/bitcoin/bitcoin/pull/27319
13:27 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:27 < bitcoin-git> [bitcoin] brunoerg closed pull request #23475: wallet: add config to prioritize a solution that doesn't create change in coin selection  (master...2021-11-coinselection-option) https://github.com/bitcoin/bitcoin/pull/23475
13:51 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
14:01 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 268 seconds]
14:04 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:2d0c:f22:9b50:e15] has quit [Quit: No Ping reply in 180 seconds.]
14:04 < bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/23056436461a...630756cac073
14:04 < bitcoin-git> bitcoin/master 4684aa8 Larry Ruane: bench: allow logging benchmarks to be order-independent
14:04 < bitcoin-git> bitcoin/master 4b3fdbf Jon Atack: bench: update logging benchmark naming for clarity
14:04 < bitcoin-git> bitcoin/master 102b203 Jon Atack: bench: order the logging benchmark code by output
14:04 < bitcoin-git> [bitcoin] achow101 merged pull request #26957: bench: update logging benchmarks (master...2023-01-update-logging-benchmarks) https://github.com/bitcoin/bitcoin/pull/26957
14:05 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:c95d:6dbe:e335:2c6c] has joined #bitcoin-core-dev
14:22 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
14:26 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection]
14:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
14:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
14:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
14:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
14:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
14:43 -!- pablomartin [~pablomart@109.70.150.158] has quit [Ping timeout: 240 seconds]
14:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 256 seconds]
14:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
14:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
15:03 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
15:05 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
15:07 -!- Thoams [~Thoams@88.97.45.247] has quit [Ping timeout: 276 seconds]
15:07 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
15:08 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8]
15:09 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
15:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
15:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
15:23 -!- pablomartin [~pablomart@109.70.150.157] has joined #bitcoin-core-dev
15:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
15:24 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 276 seconds]
15:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
15:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
15:37 -!- ___nick___ [~quassel@2a00:23c6:8d9f:f501:c95d:6dbe:e335:2c6c] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
15:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
15:44 -!- jonatack1 [~jonatack@user/jonatack] has joined #bitcoin-core-dev
15:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
15:46 -!- jonatack1 [~jonatack@user/jonatack] has quit [Client Quit]
15:47 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
15:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
15:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
15:52 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
15:58 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
16:02 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Remote host closed the connection]
16:02 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 255 seconds]
16:03 < andytoshi> has anyone ever seen unknown location(0): fatal error: in "walletload_tests/wallet_load_verif_crypted_key_checksum": std::filesystem::__cxx11::filesystem_error: filesystem error: cannot create directories: Invalid argument []
16:04 < andytoshi> from the unit tests?
16:04 < andytoshi> it's coming from the CWalllet::EncryptWallet call to GetDatabase().ReloadDbEnv();
16:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
16:05 < andytoshi> which eventually winds up at BerkeleyEnvironment::ReloadDbEnv() which tries to call BerkeleyEnvironment::Open() which tries to create a directory with the name strPath ... but strPath is not initialized anywhere, so it tries to make the directory ""
16:05 < andytoshi> this is failing for me in a nix environment since 23.x at least .. and i can't see how it ever worked
16:08 < furszy> yes, fixes are inside #26644 or #26715
16:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/26644 | wallet: bugfix, wallet_load_ckey unit test fails with bdb by furszy · Pull Request #26644 · bitcoin/bitcoin · GitHub
16:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/26715 | Introduce `MockableDatabase` for wallet unit tests by achow101 · Pull Request #26715 · bitcoin/bitcoin · GitHub
16:08 < andytoshi> oh, thank you!
16:08 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
16:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
16:09 < achow101> iirc it works if you don't use bdb
16:09 < achow101> and the default configure doesn't use bdb for tests at all
16:09 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
16:10 < achow101> well, not just configure. the mock db we use for tests is sqlite if sqlite is available
16:11 < andytoshi> ok, cool, i'll make sqlite available
16:14 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
16:14 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev
16:17 < furszy> you could read 26644 description to understand why it crashes (it mixes few things). And go for 26715 if you want to help the reviewing/fixing process.
16:19 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 265 seconds]
16:19 < furszy> I will likely port part of 26644 to another PR and close it in favor of 26715.
16:20 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
16:22 < andytoshi> thanks! i might take a look tomorrow or over the weekend
16:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
16:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
16:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
16:26 -!- pablomartin [~pablomart@109.70.150.157] has quit [Ping timeout: 265 seconds]
16:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
16:28 -!- vitst[m] [~vitstmatr@2001:470:69fc:105::3:3128] has left #bitcoin-core-dev []
16:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
16:34 -!- theStack [~theStack@95.179.145.232] has quit [Read error: Connection reset by peer]
16:51 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-dev
17:19 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 268 seconds]
17:19 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-dev
17:19 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
17:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
17:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
17:58 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
17:59 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
17:59 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
18:00 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
18:00 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
18:01 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
18:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
18:22 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
18:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
18:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
18:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:34 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
18:42 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 255 seconds]
19:02 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404]
19:04 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Read error: Connection reset by peer]
19:05 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
19:05 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
19:05 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
19:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
19:25 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has joined #bitcoin-core-dev
19:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
19:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
19:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
19:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
19:55 -!- Guest13 [~Guest13@103.86.49.187] has joined #bitcoin-core-dev
19:55 -!- Guest13 [~Guest13@103.86.49.187] has quit [Client Quit]
19:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
20:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
20:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 246 seconds]
20:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
20:17 -!- b_101_ [~robert@185.242.5.35] has quit [Quit: Lost terminal]
20:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
20:19 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
20:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
20:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
20:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
20:40 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
20:45 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 276 seconds]
20:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
20:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
20:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
21:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
21:13 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
21:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:14 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
21:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
21:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
21:28 -!- b_101 [~robert@189.236.12.192] has joined #bitcoin-core-dev
21:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
21:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
21:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:41 -!- mxz [~mxz@user/mxz] has quit [Quit: cya]
21:43 -!- mxz [~mxz@user/mxz] has joined #bitcoin-core-dev
21:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
21:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
21:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
21:58 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
22:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 246 seconds]
22:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
22:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
22:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
22:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
22:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
22:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 246 seconds]
22:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
22:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
23:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
23:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 248 seconds]
23:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
23:34 -!- Guest48 [~Guest48@27.109.16.251] has joined #bitcoin-core-dev
23:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 265 seconds]
23:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
23:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 240 seconds]
23:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
23:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has quit [Ping timeout: 246 seconds]
23:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:5153:1177:6ea9:a155] has joined #bitcoin-core-dev
--- Log closed Fri Mar 24 00:00:12 2023