--- Log opened Sun Mar 26 00:00:21 2023 00:38 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Remote host closed the connection] 01:30 -!- salvatoshi [~salvatosh@lfbn-idf3-1-1331-187.w92-170.abo.wanadoo.fr] has joined #bitcoin-core-dev --- Log opened Sun Mar 26 01:39:18 2023 01:39 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-core-dev 01:39 -!- Topic for #bitcoin-core-dev: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 01:39 -!- Topic set by laanwj [] [Sat May 22 03:05:22 2021] 01:39 [Users #bitcoin-core-dev] 01:39 [@gribble ] [ dhruv_ ] [ jkczyz ] [ realies ] 01:39 [ _aj_ ] [ dlb76 ] [ jnewbery ] [ roasbeef ] 01:39 [ _flood ] [ dodo ] [ johnzwen- ] [ robobub ] 01:39 [ _fractal[m] ] [ dongcarl ] [ jonasschnelli ] [ rodarmor ] 01:39 [ achow101 ] [ dougefish ] [ jonatack2 ] [ RubenSomsen ] 01:39 [ adiabat ] [ dviola ] [ josibake____ ] [ ryanofsky ] 01:39 [ ajonas ] [ Earnestly ] [ josie ] [ S3RK ] 01:39 [ amiti_ ] [ elichai2 ] [ jrayhawk ] [ salvatoshi ] 01:39 [ andrewtoth ] [ emzy ] [ justache ] [ sandipndev ] 01:39 [ andytoshi ] [ EPiSKiNG- ] [ kakolainen[m] ] [ sanket1729 ] 01:39 [ angusp ] [ Evel-Knievel ] [ kalle ] [ sanket_cell ] 01:39 [ Anth0mk ] [ ExEric3 ] [ katsu_ ] [ schmidty ] 01:39 [ Ara ] [ fanquake ] [ kayabanerve[m]] [ sdaftuar ] 01:39 [ ariard ] [ FelixWeis_ ] [ kcalvinalvin ] [ sebx2a_ ] 01:39 [ arik ] [ fjahr ] [ kinlo ] [ sequences[m] ] 01:39 [ ARNABNANDI[m] ] [ Flow ] [ kouloumos ] [ sgiath ] 01:39 [ asoltys ] [ freesprung ] [ laanwj ] [ sipa ] 01:39 [ aureleoules ] [ furszy ] [ LarryRuane ] [ SpellChecker ] 01:39 [ b10c ] [ ghost43_ ] [ lightlike ] [ stacie ] 01:39 [ b10c[m] ] [ gleb ] [ lightningbot ] [ stevenroose ] 01:39 [ b_101 ] [ glozow ] [ Lightsword ] [ stick ] 01:39 [ baakeydow ] [ gnusha ] [ lowhope ] [ stickies-v ] 01:39 [ bcdarc ] [ GoldmanSats_ ] [ luke-jr ] [ stratospher[m] ] 01:39 [ berndj ] [ gossie ] [ MacroFake ] [ sturles ] 01:39 [ bitcoin-git ] [ greypw25460021] [ martinus ] [ sugarpuff ] 01:39 [ bitdex ] [ gwillen ] [ mekster669493 ] [ takinbo ] 01:39 [ BlueMatt[m] ] [ harding ] [ meshcollider ] [ taldrain ] 01:39 [ bomb-on ] [ hardtotell ] [ metta ] [ TallTim ] 01:39 [ brunoerg ] [ hebasto ] [ michaelfolkson] [ TheCharlatan ] 01:39 [ BUSY ] [ helo ] [ midnight ] [ theHeap ] 01:39 [ bw ] [ hendi ] [ moneyball___ ] [ TheRec ] 01:39 [ cfields ] [ Henry151 ] [ Murch ] [ theStack ] 01:39 [ chip_x ] [ hirish_ ] [ murrayn ] [ tinova4 ] 01:39 [ cm ] [ hsmiths ] [ mxz ] [ tripleslash ] 01:39 [ cmirror ] [ hugohn__ ] [ Nebraskka ] [ uasf ] 01:39 [ cncr04s ] [ infernix ] [ neha ] [ unspent__ ] 01:39 [ codo ] [ instagibbs ] [ neromm[m] ] [ Urko[m] ] 01:39 [ cold ] [ ishaanam[m] ] [ nickler ] [ vasild ] 01:39 [ core-meetingbot] [ Jackielove4u ] [ notmandatory_ ] [ Victorsueca ] 01:39 [ coreyphillips ] [ jamesob ] [ onetwo38 ] [ vincenzopalazzo] 01:39 [ cornfeedhobo ] [ jamesob9 ] [ otoburb ] [ vyHamii ] 01:39 [ Cory ] [ jarolrod ] [ outfox ] [ w0xlt ] 01:39 [ cryptapus ] [ jarthur ] [ p2plife ] [ warren ] 01:39 [ da2ce7_ ] [ javi404 ] [ phantomcircuit] [ willcl_ark ] 01:39 [ dariusp ] [ jeremyrubin ] [ pinheadmz ] [ windsok ] 01:39 [ darosior ] [ jespada ] [ provoostenator] [ yakshaver ] 01:39 [ denise[m] ] [ jesseposner ] [ qubenix ] [ yancy ] 01:39 [ dergoegge ] [ jhns ] [ qxs ] [ Zenton ] 01:39 [ dermoth ] [ jinxd ] [ real_or_random] 01:39 -!- Irssi: #bitcoin-core-dev: Total of 195 nicks [1 ops, 0 halfops, 0 voices, 194 normal] 01:39 -!- Channel #bitcoin-core-dev created Wed May 19 06:52:47 2021 01:41 -!- Irssi: Join to #bitcoin-core-dev was synced in 143 secs 02:02 -!- jonatack3 [~jonatack@user/jonatack] has joined #bitcoin-core-dev 02:03 -!- jonatack2 [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 02:03 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 02:07 -!- chip_x [~chip@2001:8a0:f620:6500:8f6d:c640:c292:171c] has quit [Ping timeout: 256 seconds] 02:10 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev 02:42 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev 02:52 < darosior> andytoshi: don't know if you seen it, but slightly related: https://github.com/bitcoin/bitcoin/issues/19151 03:57 -!- kanzure [~kanzure@user/kanzure] has joined #bitcoin-core-dev 04:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...] 04:19 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has joined #bitcoin-core-dev 04:43 -!- gnaf [~gnaf@212-83-165-160.rev.poneytelecom.eu] has joined #bitcoin-core-dev 04:48 -!- gnaf [~gnaf@212-83-165-160.rev.poneytelecom.eu] has quit [Client Quit] 05:03 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 05:04 -!- jonatack3 [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 05:32 -!- vstoyanov [~vstoyanov@94.26.22.151] has joined #bitcoin-core-dev 05:33 -!- vstoyanov [~vstoyanov@94.26.22.151] has quit [Client Quit] 05:33 -!- vstoyanov [~vstoyanov@94.26.22.151] has joined #bitcoin-core-dev 05:38 < bitcoin-git> [bitcoin] vstoyanov opened pull request #27333: ci: cleanup of CI_EXEC & CI_EXEC_ROOT (refs #27321) (master...bitcoin#27321) https://github.com/bitcoin/bitcoin/pull/27333 05:49 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 06:08 < vstoyanov> Hey. What would be a good first issue which is not taken. I went through all of them labeled that way and they are all at some stage of discussion/implementation. I sort of lack the intuition/context-awareness to read between the lines and pick something up. Bot C++ and shell/infra are Ok for me 06:08 < vstoyanov> Both* 06:15 < andytoshi> darosior: thanks! it is slightly related, in that we're both trying to add more-or-less the same capability 06:18 -!- Hercules1 [~Hercules@2001:4641:613f:0:1c2a:fe4f:87b6:eb74] has joined #bitcoin-core-dev 06:22 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 06:26 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds] 06:32 -!- TallTim [~talltim@184-83-250-114-static.midco.net] has quit [Quit: Leaving] 06:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 07:00 -!- vstoyanov [~vstoyanov@94.26.22.151] has quit [Ping timeout: 255 seconds] 07:05 -!- vstoyanov [~vstoyanov@94.26.22.151] has joined #bitcoin-core-dev 07:06 -!- Hercules1 [~Hercules@2001:4641:613f:0:1c2a:fe4f:87b6:eb74] has quit [Quit: Leaving] 07:39 < martinus> In prevector.h, the destructor calls "_union.indirect_contents.indirect = nullptr;". Any particular reason why this is done? It's done that ever since https://github.com/bitcoin/bitcoin/pull/6914/ was merged in 2015 07:55 < bitcoin-git> [bitcoin] martinus opened pull request #27334: util: implement `noexcept` move assignment & move ctor for `prevector` (master...2023-03-prevector-move) https://github.com/bitcoin/bitcoin/pull/27334 07:59 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 08:02 -!- aielima [~aielima@user/aielima] has joined #bitcoin-core-dev 08:27 -!- vstoyanov [~vstoyanov@94.26.22.151] has quit [Ping timeout: 240 seconds] 08:28 -!- vstoyanov [~vstoyanov@151.251.248.62] has joined #bitcoin-core-dev 09:31 -!- beshology [~beshology@197.54.211.210] has joined #bitcoin-core-dev 09:41 -!- salvatoshi [~salvatosh@lfbn-idf3-1-1331-187.w92-170.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds] 09:43 < vasild> vstoyanov: I can't name a particular issue, but in general you can also look at ones not labeled "good first issue". Or you can start by reviewing some opened PR - or at least try to compile the code and run the tests, that helps to gather some knowledge and is useful to the project too. 09:45 -!- beshology [~beshology@197.54.211.210] has quit [Quit: Leaving] 09:47 < vstoyanov> Hi Vasil, I'm well past compiling the code and running tests :) I already opened a PR on the only free 'good first issue' I saw and asked if another one is stale indeed - unfortunately they all seem to be in some stage of completion. 09:47 < vstoyanov> Jonatack told me that the real shortage is in reviewers, so I read his guides and will probably go this way for now. 09:47 < vstoyanov> Apologies, it's been a long time since I last used IRC 09:50 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Remote host closed the connection] 09:50 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 09:52 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Read error: Connection reset by peer] 09:52 -!- ddisqq_ [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 09:55 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 10:00 -!- ddisqq_ [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 264 seconds] 10:02 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:07 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 276 seconds] 10:25 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 10:33 -!- gnaf [~gnaf@212-83-144-108.rev.poneytelecom.eu] has joined #bitcoin-core-dev 10:35 -!- ddisqq [~ddisqq@c-73-236-190-119.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 10:40 -!- ddisqq [~ddisqq@c-73-236-190-119.hsd1.pa.comcast.net] has quit [Ping timeout: 248 seconds] 10:40 -!- ddisqq_ [~ddisqq@c-73-117-17-115.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 10:46 -!- ddisqq_ [~ddisqq@c-73-117-17-115.hsd1.pa.comcast.net] has quit [Ping timeout: 248 seconds] 10:46 -!- gnaf [~gnaf@212-83-144-108.rev.poneytelecom.eu] has quit [Quit: Konversation terminated!] 10:59 -!- vstoyanov [~vstoyanov@151.251.248.62] has quit [Read error: Connection reset by peer] 10:59 -!- vstoyanov [~vstoyanov@94.26.22.151] has joined #bitcoin-core-dev 11:06 -!- vstoyanov [~vstoyanov@94.26.22.151] has quit [Ping timeout: 240 seconds] 11:06 -!- vstoyanov [~vstoyanov@151.251.248.62] has joined #bitcoin-core-dev 11:10 -!- vstoyanov [~vstoyanov@151.251.248.62] has quit [Read error: Connection reset by peer] 11:11 -!- vstoyanov [~vstoyanov@94.26.22.151] has joined #bitcoin-core-dev 11:12 -!- vstoyanov [~vstoyanov@94.26.22.151] has quit [Client Quit] 11:25 < bitcoin-git> [bitcoin] martinus closed pull request #23169: fix initialization in FastRandomContext: removes undefined behavior & uninitialized read (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169 11:30 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 11:59 -!- aielima [~aielima@user/aielima] has quit [Quit: Ciao] 12:16 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev 12:23 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 12:34 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 12:36 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 12:40 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 255 seconds] 12:48 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 12:51 -!- TallTim [~talltim@184-83-250-114-static.midco.net] has joined #bitcoin-core-dev 13:05 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Remote host closed the connection] 13:05 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 13:23 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 13:26 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 13:33 < ariard> Been asked what was going with Chaincode with the Jackson Lewis letter - After one more what-the-fuck communication from the other side (thanks Alex), here my version of the story: https://gist.github.com/ariard/a4e81e6c0f17d71803352774cac8c77c 13:33 < ariard> And I don't give a fuck anymore :) 14:13 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving] 14:31 < bitcoin-git> [bitcoin] EthanHeilman opened pull request #27335: Fixes compile errors in MSVC build #27332 (master...fixmsvc) https://github.com/bitcoin/bitcoin/pull/27335 14:43 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 15:23 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 15:30 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 15:51 -!- Guest7098 [~Guest70@45.134.22.177] has joined #bitcoin-core-dev 15:56 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving] 15:57 -!- Guest7098 [~Guest70@45.134.22.177] has quit [Quit: Client closed] 15:58 -!- Ev0x1 [~Ev0x1@45.134.22.226] has joined #bitcoin-core-dev 16:03 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:10 -!- pakaro [~quassel@2605:8d80:5a1:140c:6ef6:ccc1:10d7:5db1] has joined #bitcoin-core-dev 16:10 < Ev0x1> d 16:11 < Ev0x1> Hello ! Tell me what to do, I do not quite understand how multisignature works ! 16:11 < Ev0x1> I created an address with two public keys with the command createmultisig 2 ... 16:11 < Ev0x1> How do I get the money that came to this address and then sign it? 16:24 < andytoshi> achow101: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3599-L3602 i think this code should check whether a spookyman already exists with this ID 16:25 < andytoshi> currently this function is only called in two places -- in one we generate a uniformly random seed so the spkman will have a unique ID, so that's fine. in the other the key might come from wallet migration data but (i think) the original DB will have a unique seed, so it's also fine 16:26 < andytoshi> but if we provide any way for a user to import new seeds, you can get dupes, and then bad things happen (we overwrite an old scriptpubkeyman, which i think will lose data, at least in-memory, and then when we try to record the seed for the new spkman in the db, we get an error because (thankfully) we set fOverwrite=false somewhere) 16:26 < andytoshi> i say "thankfully" because otherwise this would've been pretty hard to notice :P 16:32 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 16:44 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:05 -!- pakaro [~quassel@2605:8d80:5a1:140c:6ef6:ccc1:10d7:5db1] has quit [Read error: Connection reset by peer] 17:06 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 255 seconds] 17:11 -!- Ev0x1 [~Ev0x1@45.134.22.226] has quit [Ping timeout: 260 seconds] 17:25 < bitcoin-git> [bitcoin] apoelstra opened pull request #27337: wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet (master...2023-03--wallet-error) https://github.com/bitcoin/bitcoin/pull/27337 17:26 -!- pakaro [~quassel@24.114.90.221] has joined #bitcoin-core-dev 17:41 -!- pakaro [~quassel@24.114.90.221] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 19:17 -!- Ev0x1 [~Ev0x1@45.134.22.88] has joined #bitcoin-core-dev 19:17 -!- Ev0x1 [~Ev0x1@45.134.22.88] has quit [Client Quit] 19:19 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 19:21 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit] 20:12 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds] 20:14 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 20:31 -!- rolf [rolf@2a01:7e01::f03c:93ff:fe36:d1af] has joined #bitcoin-core-dev 20:35 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 20:40 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 240 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:51 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 22:19 -!- vyHamii [~vyHamii@118.70.74.159] has quit [Remote host closed the connection] 22:19 -!- vyHamii [~vyHamii@27.72.98.102] has joined #bitcoin-core-dev 22:48 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 22:48 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Remote host closed the connection] 22:53 -!- ddisqq [~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net] has quit [Ping timeout: 276 seconds] 23:00 -!- Netsplit *.net <-> *.split quits: katsu_, TheCharlatan, qubenix, kakolainen[m], cold, Jackielove4u 23:00 -!- Netsplit over, joins: Jackielove4u, TheCharlatan, kakolainen[m] 23:01 -!- Netsplit over, joins: cold 23:02 -!- katsu_ [~0x0ff@2001:bc8:47b0:123::1] has joined #bitcoin-core-dev 23:02 -!- katsu_ [~0x0ff@2001:bc8:47b0:123::1] has quit [Changing host] 23:02 -!- katsu_ [~0x0ff@user/0x0ff/x-0302470] has joined #bitcoin-core-dev 23:04 -!- qubenix [~qubenix@user/qubenix] has joined #bitcoin-core-dev 23:38 -!- martinus [~martinus@212095005131.public.telering.at] has quit [Remote host closed the connection] 23:42 -!- martinus [~martinus@212095005131.public.telering.at] has joined #bitcoin-core-dev 23:43 -!- martinus_ [~martinus@212095005131.public.telering.at] has joined #bitcoin-core-dev 23:43 -!- martinus [~martinus@212095005131.public.telering.at] has quit [Read error: Connection reset by peer] --- Log closed Mon Mar 27 00:00:09 2023