--- Log opened Mon May 20 00:00:00 2024
00:10 -!- mailman [~mailman@103.166.150.118] has joined #bitcoin-core-dev
00:17 -!- mailman [~mailman@103.166.150.118] has quit [Quit: Client closed]
00:17 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev
00:40 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 260 seconds]
00:40 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
00:46 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:17 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 240 seconds]
01:25 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Ping timeout: 264 seconds]
01:25 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
01:36 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 260 seconds]
01:38 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
03:44 -!- Zenton [~user@user/zenton] has quit [Remote host closed the connection]
05:03 -!- nicky [~nicky@191.165.202.115] has quit [Ping timeout: 250 seconds]
05:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:29 < laanwj> <saffi> "I was going through this PR..." <- i don't know, tbh i don't see much difference in readability
05:30 -!- pablomartin [~pablomart@193.160.247.151] has joined #bitcoin-core-dev
05:31 < laanwj> everyone who's able to meaningfully contribute to the test cases won't have difficulty reading != as "not equal" but maybe i'm missing something
05:33 < laanwj> for non-native English speakers, the symbol may be quicker to parse than the word
05:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:8ca:964c:6151:16b1] has quit [Remote host closed the connection]
05:38 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
05:42 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds]
05:43 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
05:44 -!- cygnet3 [~cygnet3@185.65.134.188] has joined #bitcoin-core-dev
05:51 -!- Guest2 [~Guest35@213-182-238-138.static.kufnet.at] has joined #bitcoin-core-dev
05:52 -!- Guest2 [~Guest35@213-182-238-138.static.kufnet.at] has quit [Client Quit]
06:26 < dodo> is that pytest?
06:28 < dodo> fwiw, in unittest there is assertEqual and assertNotEqual, maybe that motivated it to follow python idioms
06:29 < dodo> dunno about pytest, but i find it surprising that such helper functions even have to exist..
06:29 < dodo> though unittest syntax is derived from java afaik.oO
06:33 < dodo> oh ok.. some homegrown test system..
06:53 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:01 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
07:06 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
07:09 -!- sohrab [~sohrab@user/sohrab] has quit [Ping timeout: 260 seconds]
07:14 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
07:15 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
07:37 -!- brunoerg [~brunoerg@gwsc.sc.usp.br] has joined #bitcoin-core-dev
07:39 -!- brunoerg_ [~brunoerg@www.labes.icmc.usp.br] has joined #bitcoin-core-dev
07:41 -!- brunoerg [~brunoerg@gwsc.sc.usp.br] has quit [Ping timeout: 264 seconds]
07:44 -!- puchka [~puchka@185.203.122.35] has quit [Ping timeout: 260 seconds]
07:44 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has joined #bitcoin-core-dev
07:47 -!- brunoerg_ [~brunoerg@www.labes.icmc.usp.br] has quit [Ping timeout: 264 seconds]
07:48 -!- Guest45 [~Guest45@31.217.161.229] has joined #bitcoin-core-dev
07:49 -!- Guest45 [~Guest45@31.217.161.229] has quit [Client Quit]
07:59 -!- puchka [~puchka@185.203.122.34] has joined #bitcoin-core-dev
08:04 -!- sohrab [~sohrab@user/sohrab] has joined #bitcoin-core-dev
08:05 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
08:10 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has quit [Remote host closed the connection]
08:16 -!- brunoerg [~brunoerg@www.labes.icmc.usp.br] has joined #bitcoin-core-dev
08:20 -!- brunoerg [~brunoerg@www.labes.icmc.usp.br] has quit [Ping timeout: 255 seconds]
08:21 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
08:26 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has joined #bitcoin-core-dev
08:30 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has quit [Ping timeout: 240 seconds]
08:38 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has joined #bitcoin-core-dev
08:43 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 240 seconds]
08:54 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:91b7:c0e7:2983:c9e7] has joined #bitcoin-core-dev
08:58 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:91b7:c0e7:2983:c9e7] has quit [Ping timeout: 255 seconds]
09:00 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
09:18 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has quit [Remote host closed the connection]
09:18 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:91b7:c0e7:2983:c9e7] has joined #bitcoin-core-dev
09:22 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:52 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:59 -!- Torr [~Torr@user/torr] has joined #bitcoin-core-dev
10:32 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
10:34 -!- brunoerg [~brunoerg@gwsc.sc.usp.br] has joined #bitcoin-core-dev
10:37 -!- twistedline_ [~bitcoin@c-73-172-209-62.hsd1.md.comcast.net] has quit []
10:37 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:37 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
10:37 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
10:37 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
10:38 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
10:40 -!- brunoerg [~brunoerg@gwsc.sc.usp.br] has quit [Ping timeout: 264 seconds]
10:41 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
10:42 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
10:42 -!- puchka [~puchka@185.203.122.34] has quit [Ping timeout: 240 seconds]
10:43 -!- pablomartin [~pablomart@193.160.247.151] has quit [Ping timeout: 240 seconds]
10:52 -!- ryanofsky_ [russ@jumpy.yanofsky.org] has left #bitcoin-core-dev []
10:52 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
10:53 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
10:58 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has joined #bitcoin-core-dev
11:31 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffb:8d3b] has quit [Remote host closed the connection]
11:40 -!- mcey [~emcy@85.255.234.238] has quit [Ping timeout: 260 seconds]
11:41 -!- mcey [~emcy@148.252.147.131] has joined #bitcoin-core-dev
12:12 -!- puchka [~puchka@185.203.122.249] has joined #bitcoin-core-dev
12:23 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:47 -!- VonNaturAustreVe [~ne0h_@user/vonnaturaustreve] has joined #bitcoin-core-dev
12:53 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
13:05 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:b12f:b00b:480a:66b7] has joined #bitcoin-core-dev
13:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:b12f:b00b:480a:66b7] has quit [Ping timeout: 256 seconds]
13:23 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
13:32 -!- saffi [~saffi@user/saffi] has joined #bitcoin-core-dev
13:43 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.2.2]
13:57 < saffi> laanwj   but assertion gives better error messages
13:57 < saffi> and if the above pr gets approved for the consistency of code it would be better to use assertions for other symbols as well
13:57 < saffi> this thing provide better diagnostics when tests fail. This small change can significantly enhance the clarity and robustness of your test suite.
14:09 -!- saffi [~saffi@user/saffi] has quit [Quit: Connection closed]
14:17 < laanwj> if you're looking to contribute to the tests, i think something like fixing one of the flakey CI tests, or improving test coverage, would be much more welcome than these kind of search/replace jobs
14:18 -!- saffi [~saffi@user/saffi] has joined #bitcoin-core-dev
14:19 < saffi> but feels like you are right its better for non english people and in many other ways
14:22 < saffi> sure I would take a look into those thank you for pointing in the direction and the guidance   laanwj
14:22 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 260 seconds]
14:25 -!- pablomartin [~pablomart@193.160.247.154] has joined #bitcoin-core-dev
14:29 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
14:34 -!- pablomartin [~pablomart@193.160.247.154] has quit [Ping timeout: 240 seconds]
14:35 -!- Flow [~none@gentoo/developer/flow] has quit [Ping timeout: 255 seconds]
14:42 -!- pablomartin [~pablomart@193.160.247.153] has joined #bitcoin-core-dev
14:43 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev
14:56 -!- pablomartin [~pablomart@193.160.247.153] has quit [Quit: Leaving]
15:21 -!- cygnet3 [~cygnet3@185.65.134.188] has quit [Quit: Leaving]
15:49 -!- saffi [~saffi@user/saffi] has quit [Quit: Connection closed]
15:59 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
16:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:35 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
18:30 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!]
18:34 -!- tarotfied [~tarotfied@static.38.4.181.135.clients.your-server.de] has joined #bitcoin-core-dev
18:45 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
19:13 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
19:18 -!- vyHamii [~vyHamii@118.70.74.159] has joined #bitcoin-core-dev
19:23 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
19:25 -!- vyHamii [~vyHamii@118.70.74.159] has quit [Quit: Leaving]
19:25 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
20:38 -!- VonNaturAustreVe [~ne0h_@user/vonnaturaustreve] has quit [Ping timeout: 255 seconds]
20:40 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:43 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
20:53 -!- Torr [~Torr@user/torr] has quit [Quit: Torr]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:20 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 264 seconds]
21:32 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
23:41 -!- Guest14 [~Guest14@147.160.220.145] has joined #bitcoin-core-dev
23:42 -!- Guest14 [~Guest14@147.160.220.145] has quit [Client Quit]
--- Log closed Tue May 21 00:00:01 2024