--- Log opened Thu Jun 20 00:00:30 2024
00:35 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:37 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
00:39 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
00:42 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:03 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
01:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has joined #bitcoin-core-dev
01:25 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has quit [Ping timeout: 260 seconds]
01:37 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
01:43 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 268 seconds]
01:45 -!- pablomartin [~pablomart@185.216.146.91] has joined #bitcoin-core-dev
01:46 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d21060af831...c6de072a215e
01:46 < bitcoin-git> bitcoin/master fa9cb10 MarcoFalke: refactor: Add explicit cast to expected_last_page to silence fuzz ISan
01:46 < bitcoin-git> bitcoin/master c6de072 merge-script: Merge bitcoin/bitcoin#30248: refactor: Add explicit cast to expected_last_...
01:47 < bitcoin-git> [bitcoin] fanquake merged pull request #30248: refactor: Add explicit cast to expected_last_page to silence fuzz ISan (master...2406-bdb-fuzz-isan) https://github.com/bitcoin/bitcoin/pull/30248
01:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c6de072a215e...aa2ce2d64696
01:53 < bitcoin-git> bitcoin/master fa7bc9b MarcoFalke: fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error
01:53 < bitcoin-git> bitcoin/master aa2ce2d merge-script: Merge bitcoin/bitcoin#30307: fuzz: Fix wallet_bdb_parser 32-bit unhandled ...
01:53 < bitcoin-git> [bitcoin] fanquake merged pull request #30307: fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error (master...2406-fuzz-wallet-bdb-32) https://github.com/bitcoin/bitcoin/pull/30307
01:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
02:01 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 246 seconds]
02:07 -!- katsu_ is now known as katsu
02:15 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
02:21 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 264 seconds]
02:23 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
02:23 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
02:24 -!- puchka [~puchka@185.203.122.219] has quit [Ping timeout: 268 seconds]
02:28 -!- puchka [~puchka@185.203.122.224] has joined #bitcoin-core-dev
02:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
02:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 268 seconds]
02:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has joined #bitcoin-core-dev
02:54 -!- vyHamii [~vyHamii@116.104.87.246] has quit [Ping timeout: 272 seconds]
02:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has quit [Ping timeout: 268 seconds]
03:09 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev
03:15 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 256 seconds]
03:28 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
03:33 -!- Guest9 [~Guest1@2409:4055:2db9:9978:507d:d359:4cb1:b8ed] has joined #bitcoin-core-dev
03:33 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 272 seconds]
03:34 -!- Guest9 [~Guest1@2409:4055:2db9:9978:507d:d359:4cb1:b8ed] has quit [Client Quit]
03:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
03:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 255 seconds]
04:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
04:24 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 268 seconds]
04:34 -!- Guest41 [~Guest80@64.238.203.29] has joined #bitcoin-core-dev
04:34 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
04:35 -!- Guest41 [~Guest80@64.238.203.29] has quit [Client Quit]
04:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
04:43 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 260 seconds]
04:46 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
05:11 -!- puchka [~puchka@185.203.122.224] has quit [Ping timeout: 268 seconds]
05:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
05:13 -!- puchka [~puchka@185.203.122.222] has joined #bitcoin-core-dev
05:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Ping timeout: 264 seconds]
05:20 -!- mcey_ [~emcy@148.252.147.219] has joined #bitcoin-core-dev
05:23 -!- emcy__ [~emcy@148.252.147.10] has joined #bitcoin-core-dev
05:23 -!- mcey [~emcy@148.252.147.10] has quit [Ping timeout: 246 seconds]
05:26 -!- mcey_ [~emcy@148.252.147.219] has quit [Ping timeout: 268 seconds]
05:27 -!- mcey_ [~emcy@148.252.129.131] has joined #bitcoin-core-dev
05:30 -!- pablomartin [~pablomart@185.216.146.91] has quit [Ping timeout: 256 seconds]
05:31 -!- emcy__ [~emcy@148.252.147.10] has quit [Ping timeout: 268 seconds]
05:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
05:34 < bitcoin-git> [bitcoin] fanquake opened pull request #30312: contrib: add R(UN)PATH check to ELF symbol-check (master...add_runpath_check) https://github.com/bitcoin/bitcoin/pull/30312
05:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:48 -!- mcey_ [~emcy@148.252.129.131] has quit [Ping timeout: 264 seconds]
05:50 -!- mcey [~emcy@85.255.232.39] has joined #bitcoin-core-dev
05:54 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
05:55 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Remote host closed the connection]
05:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
05:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Remote host closed the connection]
05:57 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
05:57 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has joined #bitcoin-core-dev
06:05 -!- jon_atack [~jonatack@user/jonatack] has quit [Quit: WeeChat 4.3.2]
06:09 -!- mcey [~emcy@85.255.232.39] has quit [Read error: Connection reset by peer]
06:10 -!- mcey [~emcy@85.255.232.39] has joined #bitcoin-core-dev
06:22 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:25 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:26 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
06:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [qa-assets] dergoegge pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/107ecdb97f75...d1016904bb2b
06:50 < bitcoin-git> qa-assets/main af7edb8 marcofleon: add initial vecdeque inputs
06:50 < bitcoin-git> qa-assets/main d101690 Niklas Gögge: Merge pull request #190 from marcofleon/2024/06/add-vecdeque-inputs
06:50 < bitcoin-git> [qa-assets] dergoegge merged pull request #190: Initial vecdeque inputs (main...2024/06/add-vecdeque-inputs) https://github.com/bitcoin-core/qa-assets/pull/190
06:56 -!- Emc99 [~Emc99@212.129.84.38] has joined #bitcoin-core-dev
06:57 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
07:00 < achow101> #startmeeting
07:00 < core-meetingbot> Meeting started Thu Jun 20 14:00:16 2024 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
07:00 < core-meetingbot> Available commands: action commands idea info link nick
07:00 < bitcoin-git> [bitcoin] guilhermelinosp opened pull request #30313: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/30313
07:00 < kevkevin> hi
07:00 < dergoegge> hi
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < Murch[m]> Hi
07:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
07:00 < furszy> hi
07:00 < vasild> hi
07:01 < sipa> hi
07:01 < achow101> #topic package relay updates (glozow)
07:01 < core-meetingbot> topic: package relay updates (glozow)
07:01 < dergoegge> I'm doing gloria's update today
07:01 < b10c> hi
07:01 < dergoegge> "I'm on holiday June 20-30. #28984 was merged. We have a couple followups (#30272 and #30295). The new priority PR is #30111."
07:01 < bitcoin-git> [bitcoin] achow101 closed pull request #30313: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/30313
07:01 < hebasto> Hi
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30272 | doc: use TRUC instead of v3 and add release note by glozow · Pull Request #30272 · bitcoin/bitcoin · GitHub
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30295 | #28984 package rbf followups by instagibbs · Pull Request #30295 · bitcoin/bitcoin · GitHub
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub
07:01 < fjahr> hi
07:01 < dergoegge> that's all
07:02 < instagibbs> \o/
07:02 < maxedw> hi
07:02 < achow101> #topic cluster mempool updates (sdaftuar)
07:02 < core-meetingbot> topic: cluster mempool updates (sdaftuar)
07:02 < vasild> wrt #30111 I wonder if there are better than manual ways to review such threading changes
07:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub
07:03 < abubakarsadiq> hi
07:03 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
07:03 < jonatack> hi
07:03 < vasild> https://github.com/bitcoin/bitcoin/pull/30111#pullrequestreview-2122762881 specifically
07:04 < achow101> vasild: the thread safety annotations should help as clang will error
07:04 < tdb3_> hi
07:04 < vasild> no, they will not help with mutex order
07:05 < dergoegge> we have runtime lock order checks iirc
07:05 < dergoegge> TSan would also complain (i think)
07:05 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
07:05 < vasild> there is some partial order support in those annotations but we don't use that at all, it is like Mutex m WILL_LOCK_AFTER(another_mutex);
07:05 < achow101> there's debug_lockorder for runtime checks
07:05 < josie_> hi
07:05 < sipa> I don't see sdaftuar. Since last meeting I've split up #30126 (adding #30286 and #30285), and opened a tracking issue #30283.
07:05 < bitcoin-git> [bitcoin] Sjors opened pull request #30314: ci: clarify Cirrus self-hosted workers setup (master...2024/06/cirrus-docs) https://github.com/bitcoin/bitcoin/pull/30314
07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/30283 | upnp: fix build with miniupnpc 2.2.8 by theuni · Pull Request #30283 · bitcoin/bitcoin · GitHub
07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/30285 | cluster mempool: merging & postprocessing of linearizations by sipa · Pull Request #30285 · bitcoin/bitcoin · GitHub
07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/30286 | cluster mempool: optimized candidate search by sipa · Pull Request #30286 · bitcoin/bitcoin · GitHub
07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub
07:06 < sipa> I'm also working on another writeup with a gentler introduction to the linearization algorithms why and how
07:06 < vasild> yes, if the lock misorder happens during execution of testing, then yes, it will crash in a good way
07:06 < achow101> sipa: which one of those should we review first?
07:07 < instagibbs> 30126
07:07 < sipa> achow101: see the tracking issue! 30126
07:07 -!- marcofleon [~marcofleo@143.244.44.175] has joined #bitcoin-core-dev
07:07 < instagibbs> sipa could you also do a tiny writeup on teh serialization/deser strategy in the fuzz test?
07:07 < instagibbs> mental model of what is happening 
07:08 < sipa> instagibbs: on the serializer format itself, or on the "why use serialization.h instead of FuzzedDataProvider"?
07:09 < instagibbs> former mostly (I think I handled the latter)
07:09 < sipa> instagibbs: sure; i'll try to write a big comment explaining it in the code
07:09 < instagibbs> 👍 
07:10 < achow101> #topic legacy wallet removal updates (achow101)
07:10 < core-meetingbot> topic: legacy wallet removal updates (achow101)
07:10 < achow101> #26596 has been getting some review
07:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 · Pull Request #26596 · bitcoin/bitcoin · GitHub
07:11 < achow101> gui#824 and #30265 are also open and easier to review
07:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/824 | Use of read_some in bitcoinrpc.cpp · Issue #824 · bitcoin/bitcoin · GitHub
07:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/30265 | wallet: Fix listwalletdir listing of migrated default wallets and generated backup files by achow101 · Pull Request #30265 · bitcoin/bitcoin · GitHub
07:12 < achow101> #topic Ad-hoc high priority for review
07:12 < core-meetingbot> topic: Ad-hoc high priority for review
07:12 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:13 < sipa> i'd like to get some attention to #29625 (it's already on the list)
07:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa · Pull Request #29625 · bitcoin/bitcoin · GitHub
07:13 < achow101> I started reviewing that and then got lost
07:14 < sipa> can I do something to help the lostness?
07:16 < achow101> looks like there's more smaller commits now, so I think that will help
07:16 < sipa> yeah, several things have been split up
07:17 < achow101> Any other topics to discuss?
07:19 < maxedw> Just a quick one to say that there is an open issue to discuss moving some more CI jobs from Cirrus to Github Actions. If anyone has thoughts on that please come to https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2180535361
07:20 < achow101> #endmeeting
07:20 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
07:20 < core-meetingbot> Meeting ended Thu Jun 20 14:20:23 2024 UTC.  
07:20 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2024/bitcoin-core-dev.2024-06-20-14.00.moin.txt
07:22 -!- jamesob443688173 [~jamesob@108.44.248.162] has joined #bitcoin-core-dev
07:22 -!- jamesob1 [~jamesob@108.44.248.162] has joined #bitcoin-core-dev
07:24 -!- Emc99 [~Emc99@212.129.84.38] has quit [Quit: Client closed]
07:25 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:25 -!- jetpack [~jetpack@2605:2700:1:100e:dc::f01d] has quit [Ping timeout: 246 seconds]
07:25 -!- Guest0 [~Guest0@2a03:ef44:5:a003:2:2:7b09:5c0d] has joined #bitcoin-core-dev
07:27 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
07:29 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
07:33 -!- Emc99 [~Emc99@212.129.84.38] has joined #bitcoin-core-dev
07:34 -!- Emc99 [~Emc99@212.129.84.38] has quit [Client Quit]
07:34 -!- marcofleon [~marcofleo@143.244.44.175] has quit [Quit: Connection closed]
07:35 -!- pablomartin [~pablomart@188.241.144.172] has joined #bitcoin-core-dev
07:35 -!- Guest0 [~Guest0@2a03:ef44:5:a003:2:2:7b09:5c0d] has quit [Ping timeout: 250 seconds]
07:53 -!- Guest8 [~Guest44@102.220.199.245] has joined #bitcoin-core-dev
07:54 -!- Guest8 [~Guest44@102.220.199.245] has quit [Client Quit]
08:11 -!- puchka [~puchka@185.203.122.222] has quit [Ping timeout: 268 seconds]
08:13 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:14 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
08:17 -!- puchka [~puchka@185.203.122.217] has joined #bitcoin-core-dev
08:20 -!- pablomartin [~pablomart@188.241.144.172] has quit [Ping timeout: 264 seconds]
08:23 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
08:25 < vasild> dergoegge: our lock order checks don't catch this problem: lock m1 m2, unlock all, lock m2 m3, unlock all, lock m3 m1 <-- this is a bug
08:26 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:29 < vasild> lets say that now you are introducing mutex m3. the code before is lock m1 m2 and you add m3 plus lock m2 m3 and lock m3 m1. You have to manually find that lock m1 m2 all over the code base :/
08:31 < vasild> I mean, since lock m2 m3 and lock m3 m1 implies lock order m2 before m1 then the developer has to check all the code base that nowhere m1 is locked before m2.
08:32  * vasild bbl
08:32 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
08:50 -!- Torr [~Torr@user/torr] has joined #bitcoin-core-dev
08:59 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:59 < bitcoin-git> [bitcoin] Sjors opened pull request #30315: Stratum v2 Transport (master...2024/06/sv2_transport) https://github.com/bitcoin/bitcoin/pull/30315
09:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
09:11 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
09:13 < bitcoin-git> [gui] theStack opened pull request #825: Show maximum mempool size in information window (master...gui_show_maxmempoolsize) https://github.com/bitcoin-core/gui/pull/825
09:25 -!- puchka [~puchka@185.203.122.217] has quit [Ping timeout: 256 seconds]
09:34 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:35 -!- puchka [~puchka@185.203.122.188] has joined #bitcoin-core-dev
09:40 -!- cedhouse [~cedhouse@93-42-115-154.ip86.fastwebnet.it] has joined #bitcoin-core-dev
09:48 < vasild> hebasto: fanquake: I confirm this: on master when configured with --enable-fuzz but without --with-sanitizers, then the fuzz binary just hangs without printing anything: `FUZZ=addrman src/test/fuzz/fuzz` or `FUZZ=addrman src/test/fuzz/fuzz .../bitcoin-core/qa-assets/fuzz_seed_corpus/addrman`. Adding --with-sanitizers=fuzzer creates a working one.
09:49 -!- cedhouse [~cedhouse@93-42-115-154.ip86.fastwebnet.it] has quit [Quit: Client closed]
09:50 < sipa> vasild: huh, that's surprising; without --with-sanitizer=fuzzer there shouldn't be a main() function even (as it's provided by the sanitizer)
09:51 < dergoegge> i'm pretty sure it's waiting for input from stdin
09:51 < dergoegge> if you pass it a file or folder it won't hang
09:51 < dergoegge> s/won't/shouldn't/
09:53 < sipa> oh, so it's just doing the same as if you didn't pass --enable-fuzz in that case? (using our own dummy-fuzz main routine)
09:58 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:01 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
10:04 < dergoegge> i thought so, can double check tomorrow
10:08 < vasild> well, if I press ctrl+D then it quits
10:10 < vasild> I said that it hangs with `FUZZ=addrman src/test/fuzz/fuzz .../bitcoin-core/qa-assets/fuzz_seed_corpus/addrman`, but it actually does something because it loads the CPU
10:10 < vasild> and eventually it prints "addrman: succeeded against 2064 files in 85s."
10:11 < vasild> nothing else, just this one line and quits
10:13 < dergoegge> That's the expected behaviour without the fuzzer sanitizer
10:13 < vasild> I am confused. Is this a fully functional fuzz binary (compiled with --enable-fuzz but without --with-sanitizers)?
10:17 < sipa> vasild: so if you build completely normally (no --enable-fuzz, and no --with-sanitizers=fuzzer), you still get a src/test/fuzz/fuzz binary
10:17 < sipa> vasild: that binary cannot do any actual fuzzing, but it can read a fuzz seed corpus, and feed it through the fuzzing harness
10:19 < vasild> ok
10:19 < sipa> and i suspect that if you build with --enable-fuzz but without --with-sanitizers=fuzzer, you get the same thing
10:20 < vasild> I will further investigate tomorrow, so far "only --enable-fuzz-binary" and "only --enable-fuzz" (without --with-sanitizers) seem to create the same binary
10:21 < sipa> it's pretty cool i think that we have this; it means we get to run our fuzz corpus tests on platforms/architectures that aren't actually supported by libfuzzer (including gcc, mingw32, msvc, ...)
10:22 < vasild> right
10:23 < sipa> i think when we introduced this there was some talk of calling the binary phuzz (phony fuzz) rather than fuzz to not confuse the two
10:23 < sipa> maybe we should still do that
10:23 < vasild> yes!
10:24 < vasild> so, all 3 produce the same phuzz binary: 1. without any option, 2. --enable-fuzz 3. --enable-fuzz-binary --> its all the same result
10:26 < sipa> it may be that these options only matter for other fuzzing systems
10:26 < vasild> and --with-sanitizers=fuzzer creates a true fuzz binary. Why do we disable building other executables when --enable-fuzz is used?
10:27 < vasild> thanks!
10:27  * vasild afk...
10:27 < sipa> i don't have experience with these, but it is/was possible to use afl or honggfuzz too
10:28 < sipa> vasild: when we're building for real fuzzing (which perhaps is what --enable-fuzz is trying to do, to the extent possible), we cannot build any other binaries (because the main() function is provided by the fuzzing framework)
10:28 -!- sohrab [~sohrab@user/sohrab] has joined #bitcoin-core-dev
10:29 < bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/aa2ce2d64696...a52837b9e969
10:29 < bitcoin-git> bitcoin/master 9f66ac7 Pieter Wuille: net_processing: do not treat non-connecting headers as response
10:29 < bitcoin-git> bitcoin/master 944c542 Pieter Wuille: net_processing: drop Misbehavior for unconnecting headers
10:29 < bitcoin-git> bitcoin/master 5120ab1 Pieter Wuille: net_processing: drop 8 headers threshold for incoming BIP130
10:29 < bitcoin-git> [bitcoin] achow101 merged pull request #29575: net_processing: make any misbehavior trigger immediate discouragement (master...202403_nomisbehave) https://github.com/bitcoin/bitcoin/pull/29575
10:29 < sipa> \o/ no more DoS scores!
10:37 < bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a52837b9e969...21656e99b5f4
10:37 < bitcoin-git> bitcoin/master c3a8843 Lőrinc: Use SCRIPT_VERIFY_NONE instead of hard-coded 0 in transaction_tests
10:37 < bitcoin-git> bitcoin/master 1984187 Lőrinc: Validate transaction without inputs
10:37 < bitcoin-git> bitcoin/master 327a31d Lőrinc: Validate oversized transaction
10:37 < bitcoin-git> [bitcoin] achow101 merged pull request #29862: test: Validate oversized transactions or without inputs (master...paplorinc/consensus_test_coverage) https://github.com/bitcoin/bitcoin/pull/29862
10:45 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21656e99b5f4...a961ad1bebc5
10:45 < bitcoin-git> bitcoin/master 1245d13 Vasil Dimov: netbase: extend CreateSock() to support creating arbitrary sockets
10:45 < bitcoin-git> bitcoin/master a961ad1 Ava Chow: Merge bitcoin/bitcoin#30202: netbase: extend CreateSock() to support creat...
10:45 < bitcoin-git> [bitcoin] achow101 merged pull request #30202: netbase: extend CreateSock() to support creating arbitrary sockets (master...extend_CreateSock) https://github.com/bitcoin/bitcoin/pull/30202
11:12 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:14 < fanquake> sipa 🚀
11:15 < bitcoin-git> [qa-assets] murchandamus opened pull request #191: Add new fuzz inputs after package_rbf changed (main...2024-06-update-package_rbf) https://github.com/bitcoin-core/qa-assets/pull/191
11:48 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
11:50 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:50 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:51 < bitcoin-git> [bitcoin] theuni opened pull request #30316: refactor: remove extraneous lock annotations from function definitions (master...clang-annotations-definitions) https://github.com/bitcoin/bitcoin/pull/30316
12:09 -!- mudsip [~mudsip@user/mudsip] has quit []
12:10 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
12:12 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:18 -!- pablomartin [~pablomart@188.241.144.173] has joined #bitcoin-core-dev
12:36 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
12:38 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
12:48 -!- jon_atack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
12:50 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
12:51 -!- cm [~chaz@user/cm] has quit [Quit: Bye.]
12:52 -!- cm [~chaz@user/cm] has joined #bitcoin-core-dev
12:59 -!- pablomartin [~pablomart@188.241.144.173] has quit [Remote host closed the connection]
12:59 -!- pablomartin [~pablomart@188.241.144.173] has joined #bitcoin-core-dev
13:39 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.3.2]
14:09 -!- pablomartin [~pablomart@188.241.144.173] has quit [Ping timeout: 268 seconds]
14:20 -!- jtraub91 [~jason@71-146-184-246.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev
14:23 -!- pablomartin [~pablomart@188.241.144.173] has joined #bitcoin-core-dev
14:44 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:58 < bitcoin-git> [bitcoin] paplorinc opened pull request #30317: WIP Optimize SipHash (master...paplorinc/siphash) https://github.com/bitcoin/bitcoin/pull/30317
15:04 -!- mudsip [~mudsip@user/mudsip] has quit []
15:04 -!- jtraub91 [~jason@71-146-184-246.lightspeed.irvnca.sbcglobal.net] has quit [Quit: WeeChat 3.8]
15:09 -!- pablomartin [~pablomart@188.241.144.173] has quit [Ping timeout: 252 seconds]
15:09 -!- pablomartin4btc [~pablomart@188.241.144.179] has joined #bitcoin-core-dev
15:13 -!- pablomartin4btc [~pablomart@188.241.144.179] has quit [Client Quit]
15:27 -!- kevkevin [~kevkevin@2601:241:8703:7b30:3df8:9f1d:b4ab:b62c] has quit [Remote host closed the connection]
15:30 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev
15:35 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 264 seconds]
15:45 -!- midnight [~midnight@user/midnight] has quit [Remote host closed the connection]
15:46 -!- cold [~cold@user/cold] has quit [Remote host closed the connection]
15:56 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
15:56 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev
16:00 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev
16:05 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 256 seconds]
16:17 -!- midnight [~midnight@user/midnight] has quit [Remote host closed the connection]
16:17 -!- cold [~cold@user/cold] has quit [Remote host closed the connection]
16:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
16:28 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
16:28 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev
16:49 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Read error: Connection reset by peer]
16:50 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
16:50 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
16:52 -!- Torr [~Torr@user/torr] has quit [Quit: Torr]
17:09 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
17:11 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
17:19 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 268 seconds]
17:43 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 260 seconds]
17:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has joined #bitcoin-core-dev
17:57 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has quit [Ping timeout: 260 seconds]
18:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
18:13 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 255 seconds]
18:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 264 seconds]
18:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
18:48 -!- mcey [~emcy@85.255.232.39] has quit [Ping timeout: 246 seconds]
18:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 268 seconds]
18:54 -!- mcey [~emcy@85.255.236.136] has joined #bitcoin-core-dev
18:55 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
18:58 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
19:06 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
19:14 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 260 seconds]
19:26 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
19:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has joined #bitcoin-core-dev
20:05 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has quit [Remote host closed the connection]
20:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has joined #bitcoin-core-dev
20:20 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
20:39 < vasild> sipa: "because the main() function is provided by the fuzzing framework)" -- seems that the fuzzing framework is engaged by --with-sanitizers=fuzzer, not by --enable-fuzz
20:40 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9] has quit [Remote host closed the connection]
21:00 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:25 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Remote host closed the connection]
21:43 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
21:44 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
21:49 < vasild> I opened https://github.com/bitcoin/bitcoin/issues/30318 "Fuzzing related configuration/build options can be improved" following the discussion from yesterday
21:54 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
21:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
21:55 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
21:56 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
21:58 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
22:00 -!- mcey [~emcy@85.255.236.136] has quit [Read error: Connection reset by peer]
22:01 -!- mcey [~emcy@85.255.236.136] has joined #bitcoin-core-dev
22:04 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 255 seconds]
22:11 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
22:12 -!- dermoth [~dermoth@user/dermoth] has quit [Remote host closed the connection]
22:14 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 260 seconds]
22:16 -!- dermoth_ is now known as dermoth
22:17 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:17 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
22:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
22:20 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
22:24 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 272 seconds]
22:28 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:29 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
22:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
22:40 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 268 seconds]
22:42 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
22:53 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
22:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:55 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:58 -!- jonatack1 [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:58 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
23:00 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
23:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
23:17 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 264 seconds]
23:18 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
23:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:30 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
23:31 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:35 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:36 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
23:39 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:40 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
23:48 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has joined #bitcoin-core-dev
23:52 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
23:53 -!- kevkevin [~kevkevin@2601:241:8703:7b30:54db:302f:88a9:cd95] has quit [Ping timeout: 272 seconds]
23:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
--- Log closed Fri Jun 21 00:00:31 2024