--- Log opened Tue Jul 16 00:00:54 2024 00:01 -!- tppellegrino [~tppellegr@185.255.128.139] has joined #bitcoin-core-dev 00:02 -!- tppellegrino [~tppellegr@185.255.128.139] has quit [Client Quit] 00:04 -!- tppellegrino [~tppellegr@185.255.128.139] has joined #bitcoin-core-dev 00:04 -!- tppellegrino [~tppellegr@user/tppellegrino44] has changed host 00:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 00:13 -!- tppellegrino [~tppellegr@user/tppellegrino44] has quit [Quit: Client closed] 00:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 272 seconds] 00:19 -!- shesek [~shesek@user/shesek] has quit [Server closed connection] 00:19 -!- shesek [~shesek@user/shesek] has joined #bitcoin-core-dev 00:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 00:38 -!- puchka [~puchka@185.203.122.222] has quit [Ping timeout: 244 seconds] 00:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 00:43 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:48 -!- puchka [~puchka@185.203.122.181] has joined #bitcoin-core-dev 00:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 00:52 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 00:59 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8426e018bf22...d41f4a69e7be 00:59 < bitcoin-git> bitcoin/master c6d4336 stratospher: test: Fix intermittent failure in p2p_v2_misbehaving.py 00:59 < bitcoin-git> bitcoin/master d41f4a6 merge-script: Merge bitcoin/bitcoin#30420: test: Fix intermittent failure in p2p_v2_misb... 00:59 < bitcoin-git> [bitcoin] fanquake merged pull request #30420: test: Fix intermittent failure in p2p_v2_misbehaving.py (master...fix-race-earlykey) https://github.com/bitcoin/bitcoin/pull/30420 00:59 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 252 seconds] 01:01 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 01:01 -!- TracaChang [~TracaChan@gateway/tor-sasl/tracachang] has joined #bitcoin-core-dev 01:04 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 252 seconds] 01:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 01:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 01:38 -!- puchka [~puchka@185.203.122.181] has quit [Ping timeout: 248 seconds] 01:38 -!- harding [quassel@newmail.dtrt.org] has quit [Server closed connection] 01:39 -!- harding [quassel@newmail.dtrt.org] has joined #bitcoin-core-dev 01:42 < bitcoin-git> [bitcoin] glozow pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d41f4a69e7be...35dddbccf1fb 01:42 < bitcoin-git> bitcoin/master 66673f1 Sebastian Falbesoner: net: fix race condition in self-connect detection 01:42 < bitcoin-git> bitcoin/master 0dbcd4c Sebastian Falbesoner: net: prevent sending messages in `NetEventsInterface::InitializeNode` 01:42 < bitcoin-git> bitcoin/master 16bd283 Sebastian Falbesoner: Reapply "test: p2p: check that connecting to ourself leads to disconnect" 01:42 < bitcoin-git> [bitcoin] glozow merged pull request #30394: net: fix race condition in self-connect detection (master...202407-p2p-fix_selfdetection_racecond) https://github.com/bitcoin/bitcoin/pull/30394 01:48 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/35dddbccf1fb...5f538f2a7caf 01:48 < bitcoin-git> bitcoin/master a38c960 Cory Fields: contrib: use c++ rather than c for binary tests 01:48 < bitcoin-git> bitcoin/master 261f770 Cory Fields: contrib: rename cc to cxx in binary checking scripts 01:48 < bitcoin-git> bitcoin/master 9010b13 Cory Fields: contrib: c++ify test stubs after switching to c++ compilers 01:48 < bitcoin-git> [bitcoin] fanquake merged pull request #30387: contrib: use c++ compiler rather than c compiler for binary checks (master...cxx-security-check) https://github.com/bitcoin/bitcoin/pull/30387 01:55 < _aj_> glozow: LOCK(m_mutex) doesn't check, it (generally) just deadlocks if it's already held, afaik. (unless you've got DEBUG_LOCKORDER enabled) 01:59 -!- puchka [~puchka@185.203.122.187] has joined #bitcoin-core-dev 02:03 < glozow> _aj_: ah thanks! I should add an explicit `AssertLockNotHeld` then 02:08 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 02:14 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 02:23 -!- face [~face@mail.hmel.org] has quit [Server closed connection] 02:24 -!- face [~face@mail.hmel.org] has joined #bitcoin-core-dev 02:28 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 02:29 < _aj_> glozow: yeah. i think for mutexes that are private to a class, the MaybeCheckNotHeld stuff will give you compile-time errors if you do a double-lock or don't have sufficient EXCLUSIVE_LOCKS_REQUIRED(!m_mutex) annotations to guarantee no double locks, but better to be extra safe 02:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 272 seconds] 02:44 -!- stratospher[m] [~stratosph@2620:6e:a000:ce11::1e] has quit [Server closed connection] 02:44 -!- stratospher[m] [~stratosph@2620:6e:a000:ce11::1e] has joined #bitcoin-core-dev 02:49 < vasild> I am working on a unit test that is failing in a weird way: just prints *** 1 failure is detected in the test module "Bitcoin Core Test Suite" and exists without printing any failures prior that. I lost some significant amount of time only to figure out that a BOOST_REQUIRE(n > 0) fails without printing anything (!), changing that to assert(n > 0) prints the expected Assertion failed: (n > 0), 02:49 < vasild> ... 02:54 < vasild> printouts with std::cout << ... present just before BOOST_REQUIRE(n > 0) were also swallowed/missing. BOOST_TEST_MESSAGE("...") is also executed but missing, in spite std::cout.setf(std::ios::unitbuf); setbuffer(stdout, NULL, 0); 02:55 < vasild> but std::cerr << ... is printed / works 03:00 < vasild> oh, this is my fault, I have accidentally closed stdout 03:04 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 03:09 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye] 03:09 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 03:10 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 248 seconds] 03:44 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 03:55 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 272 seconds] 04:03 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 04:04 < bitcoin-git> [bitcoin] fanquake opened pull request #30452: guix: bump time-machine to 3c58b759a51072aabd7eaaca680674a0c2b36c23 (master...guix_mingw64_12_0_1) https://github.com/bitcoin/bitcoin/pull/30452 04:13 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5f538f2a7caf...1db0be83535f 04:13 < bitcoin-git> bitcoin/master c807f33 stratospher: Add fuzz test for AEADChacha20Poly1305 04:13 < bitcoin-git> bitcoin/master 8607773 stratospher: Add fuzz test for FSChaCha20Poly1305 04:13 < bitcoin-git> bitcoin/master 1db0be8 merge-script: Merge bitcoin/bitcoin#28263: Add fuzz test for FSChaCha20Poly1305, AEADCha... 04:13 < bitcoin-git> [bitcoin] fanquake merged pull request #28263: Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305 (master...fuzz_chacha20poly1305) https://github.com/bitcoin/bitcoin/pull/28263 04:14 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 04:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 04:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 272 seconds] 04:41 < bitcoin-git> [bitcoin] maflcko opened pull request #30453: test: Non-Shy version sender (master...2407-test-ver) https://github.com/bitcoin/bitcoin/pull/30453 04:42 -!- cfields [~cfields@user/cfields] has quit [Server closed connection] 04:42 -!- cfields [~cfields@user/cfields] has joined #bitcoin-core-dev 04:48 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 04:50 -!- otoburb [~otoburb@user/otoburb] has quit [Server closed connection] 04:50 -!- otoburb [~otoburb@user/otoburb] has joined #bitcoin-core-dev 04:52 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 244 seconds] 05:06 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 05:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 272 seconds] 05:17 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 05:26 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 05:31 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 252 seconds] 05:45 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 05:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 272 seconds] 06:03 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 06:04 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:04 -!- BrandonOdiwuor [~BrandonOd@105.163.1.56] has joined #bitcoin-core-dev 06:08 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 06:08 < andrewtoth_> hi - I see #17487 is locked and I wanted to comment on it. Can it be unlocked? 06:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/17487 | coins: allow write to disk without cache drop by jamesob · Pull Request #17487 · bitcoin/bitcoin · GitHub 06:19 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 06:19 < ryanofsky> andrewtoth_, unlocked it now 06:19 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 06:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 06:22 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 248 seconds] 06:26 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 252 seconds] 06:33 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:33 < andrewtoth_> ryanofsky: thanks! 06:33 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 06:40 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 06:44 -!- gmaxwell [~gmaxwell@user/gmaxwell] has quit [Server closed connection] 06:44 -!- gmaxwell [~gmaxwell@user/gmaxwell] has joined #bitcoin-core-dev 06:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 272 seconds] 06:48 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 06:48 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 06:49 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 07:04 -!- Guest69 [~Guest75@2a02:ab88:c0c:e00:c483:45ba:4001:c515] has joined #bitcoin-core-dev 07:05 -!- Guest69 [~Guest75@2a02:ab88:c0c:e00:c483:45ba:4001:c515] has quit [Client Quit] 07:14 < bitcoin-git> [bitcoin] ryanofsky pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1db0be83535f...46878326808f 07:14 < bitcoin-git> bitcoin/master 3443943 TheCharlatan: refactor: De-globalize validation benchmark timekeeping 07:14 < bitcoin-git> bitcoin/master 39f9b80 TheCharlatan: refactor: De-globalize last notified header index 07:14 < bitcoin-git> bitcoin/master 51fa262 TheCharlatan: refactor: Mark some static global vars as const 07:14 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30425: kernel: De-globalize static validation variables (master...kernelRmGlobals) https://github.com/bitcoin/bitcoin/pull/30425 07:32 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection] 07:32 -!- vasild [~vd@user/vasild] has quit [Read error: Connection reset by peer] 07:32 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 07:33 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev 07:37 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 07:38 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 07:49 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/46878326808f...24dffdde7b40 07:49 < bitcoin-git> bitcoin/master 81d4dc8 fanquake: build: use -no_exported_symbols on macOS 07:49 < bitcoin-git> bitcoin/master 24dffdd merge-script: Merge bitcoin/bitcoin#29072: build: use `-no_exported_symbols` on macOS 07:49 < bitcoin-git> [bitcoin] fanquake merged pull request #29072: build: use `-no_exported_symbols` on macOS (master...use_no_exported_symbols_macos) https://github.com/bitcoin/bitcoin/pull/29072 07:55 < bitcoin-git> [bitcoin] hebasto opened pull request #30454: build: Introduce CMake-based buid system (master...240716-cmake) https://github.com/bitcoin/bitcoin/pull/30454 07:56 < bitcoin-git> [bitcoin] hebasto closed pull request #29790: [DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP (master...240402-cmake-DA) https://github.com/bitcoin/bitcoin/pull/29790 07:59 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev 08:24 < bitcoin-git> [bitcoin] brunoerg closed pull request #29129: wallet, rpc: add BIP44 `account` in `createwallet` (master...2023-12-externalsigner-account-parameter) https://github.com/bitcoin/bitcoin/pull/29129 08:33 < cfields> \o/ 08:46 -!- windsok [~windsok@rarepepe.cash] has quit [Server closed connection] 08:46 -!- windsok [~windsok@rarepepe.cash] has joined #bitcoin-core-dev 08:47 -!- test_ is now known as _flood 09:11 < bitcoin-git> [bitcoin] alfonsoromanz opened pull request #30455: test: assumeutxo: add missing tests in wallet_assumeutxo.py (master...wallet_assumeutxo_tests) https://github.com/bitcoin/bitcoin/pull/30455 09:18 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:23 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev 09:32 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24dffdde7b40...1d24d383b45e 09:32 < bitcoin-git> bitcoin/master 5fd4836 Martin Zumsande: init: change shutdown order of load block thread and scheduler 09:32 < bitcoin-git> bitcoin/master 1d24d38 merge-script: Merge bitcoin/bitcoin#30435: init: change shutdown order of load block thr... 09:32 < bitcoin-git> [bitcoin] fanquake merged pull request #30435: init: change shutdown order of load block thread and scheduler (master...202407_shutdown_order) https://github.com/bitcoin/bitcoin/pull/30435 09:39 -!- BrandonOdiwuor [~BrandonOd@105.163.1.56] has quit [Quit: Client closed] 09:45 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 09:52 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:10 < bitcoin-git> [bitcoin] maflcko opened pull request #30457: doc: getaddressinfo[isscript] is optional (master...2407-doc) https://github.com/bitcoin/bitcoin/pull/30457 10:42 < bitcoin-git> [bitcoin] gabrielsellan-paylivre opened pull request #30459: Alterando readme (master...alterando-readme) https://github.com/bitcoin/bitcoin/pull/30459 10:43 < bitcoin-git> [bitcoin] fanquake closed pull request #30459: Alterando readme (master...alterando-readme) https://github.com/bitcoin/bitcoin/pull/30459 10:51 -!- puchka [~puchka@185.203.122.187] has quit [Ping timeout: 272 seconds] 11:02 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Remote host closed the connection] 11:02 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 11:05 -!- infernix [nix@spirit.infernix.net] has quit [Server closed connection] 11:06 -!- infernix [nix@spirit.infernix.net] has joined #bitcoin-core-dev 11:40 < bitcoin-git> [bitcoin] brunoerg opened pull request #30461: fuzz: add target for `CoinsResult` (master...2024-07-fuzz-coinsresult) https://github.com/bitcoin/bitcoin/pull/30461 11:41 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has quit [Server closed connection] 11:44 -!- Guest79 [~Guest79@2401:4900:1c8f:c4aa:71c8:1e41:2af7:10a] has joined #bitcoin-core-dev 11:45 -!- Earnestly [~earnest@user/earnestly] has quit [Server closed connection] 11:45 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 11:46 -!- cncr04s_ [~cncr04s@afxr.net] has quit [Server closed connection] 11:46 -!- cncr04s [~cncr04s@afxr.net] has joined #bitcoin-core-dev 11:46 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has joined #bitcoin-core-dev 11:53 -!- Guest62 [~Guest79@2401:4900:1c8f:c4aa:71c8:1e41:2af7:10a] has joined #bitcoin-core-dev 11:58 -!- Guest79 [~Guest79@2401:4900:1c8f:c4aa:71c8:1e41:2af7:10a] has quit [Quit: Client closed] 11:58 -!- Guest62 [~Guest79@2401:4900:1c8f:c4aa:71c8:1e41:2af7:10a] has quit [Quit: Client closed] 12:04 < bitcoin-git> [bitcoin] theuni opened pull request #30462: utils: replace boost::date_time usage with c++20 std::chrono (master...nuke-date-time) https://github.com/bitcoin/bitcoin/pull/30462 12:24 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection] 12:27 -!- aleggg [~aleggg@177.204.247.69.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev 12:31 < bitcoin-git> [bitcoin] maflcko closed pull request #28236: fuzz: wallet, add target for Spend (master...fuzz-coverage-spend) https://github.com/bitcoin/bitcoin/pull/28236 13:00 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1d24d383b45e...ad5579e056ac 13:00 < bitcoin-git> bitcoin/master fa62707 MarcoFalke: rpc: Use CHECK_NONFATAL over Assert 13:00 < bitcoin-git> bitcoin/master ad5579e Ava Chow: Merge bitcoin/bitcoin#30429: rpc: Use CHECK_NONFATAL over Assert 13:00 < bitcoin-git> [bitcoin] achow101 merged pull request #30429: rpc: Use CHECK_NONFATAL over Assert (master...2407-rpc-no-assert) https://github.com/bitcoin/bitcoin/pull/30429 13:14 < bitcoin-git> [bitcoin] hebasto opened pull request #30463: qa: Functional test improvements (master...240716-ftest) https://github.com/bitcoin/bitcoin/pull/30463 13:19 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ad5579e056ac...16b4f75d04c8 13:19 < bitcoin-git> bitcoin/master 0800895 Sebastian Falbesoner: bench: add benchmark for `SignTransaction` 13:19 < bitcoin-git> bitcoin/master fe92c15 Sebastian Falbesoner: script/sign: avoid duplicated signature verification after signing 13:19 < bitcoin-git> bitcoin/master 16b4f75 Ava Chow: Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verif... 13:19 < bitcoin-git> [bitcoin] achow101 merged pull request #28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks) (master...202311-add_SignTransaction_benchmark) https://github.com/bitcoin/bitcoin/pull/28923 13:27 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/16b4f75d04c8...45750f61d65d 13:27 < bitcoin-git> bitcoin/master 9a7e5f4 Vasil Dimov: net: don't extra bind for Tor if binds are restricted 13:27 < bitcoin-git> bitcoin/master af55253 Vasil Dimov: net: report an error if unable to bind on the Tor listening addr:port 13:27 < bitcoin-git> bitcoin/master bca346a Vasil Dimov: net: require P2P binds to succeed 13:27 < bitcoin-git> [bitcoin] achow101 merged pull request #22729: Make it possible to disable Tor binds and abort startup on bind failure (master...torbind) https://github.com/bitcoin/bitcoin/pull/22729 13:40 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Server closed connection] 13:40 -!- reardencode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev 14:10 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/45750f61d65d...6f9db1ebcab4 14:10 < bitcoin-git> bitcoin/master 39cea21 willcl-ark: wallet: fix FillPSBT errantly showing as complete 14:10 < bitcoin-git> bitcoin/master 7e36dca willcl-ark: test: add test for modififed walletprocesspsbt calls 14:10 < bitcoin-git> bitcoin/master 6f9db1e Ava Chow: Merge bitcoin/bitcoin#30357: Fix cases of calls to `FillPSBT` errantly ret... 14:10 < bitcoin-git> [bitcoin] achow101 merged pull request #30357: Fix cases of calls to `FillPSBT` errantly returning `complete=true` (master...walletprocesspsbt-no-finalize) https://github.com/bitcoin/bitcoin/pull/30357 14:12 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving] 14:14 -!- nanotube [~nanotube@user/nanotube] has quit [Quit: *poof*] 14:22 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.3.4] 14:31 -!- TracaChang [~TracaChan@gateway/tor-sasl/tracachang] has quit [Quit: Leaving] 14:33 -!- TracaChang [~TracaChan@gateway/tor-sasl/tracachang] has joined #bitcoin-core-dev 14:48 < bitcoin-git> [bitcoin] hebasto opened pull request #30464: test, refactor: Fix MSVC warning C4101 "unreferenced local variable" (master...240716-univalue) https://github.com/bitcoin/bitcoin/pull/30464 15:09 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev 15:15 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Remote host closed the connection] 15:20 < bitcoin-git> [bitcoin] hebasto opened pull request #30465: depends: Set `CMAKE_SYSTEM_VERSION` for CMake builds (master...240716-deps-cmake) https://github.com/bitcoin/bitcoin/pull/30465 15:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 16:00 -!- b10c [~quassel@user/b10c] has quit [Server closed connection] 16:00 -!- b10c [~quassel@user/b10c] has joined #bitcoin-core-dev 16:01 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Remote host closed the connection] 16:15 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 16:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 252 seconds] 16:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 16:55 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 16:58 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 17:06 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving] 17:09 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 17:13 -!- Guest15 [~Guest25@cable-24-135-91-64.dynamic.sbb.rs] has joined #bitcoin-core-dev 17:19 -!- TracaChang [~TracaChan@gateway/tor-sasl/tracachang] has quit [Remote host closed the connection] 17:19 -!- TracaChang [~TracaChan@gateway/tor-sasl/tracachang] has joined #bitcoin-core-dev 17:31 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Ping timeout: 264 seconds] 17:36 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #bitcoin-core-dev 17:37 -!- Guest15 [~Guest25@cable-24-135-91-64.dynamic.sbb.rs] has quit [Quit: Client closed] 17:57 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 18:00 -!- sample [~sample@82-64-162-213.subs.proxad.net] has quit [Server closed connection] 18:00 -!- sample [~sample@82-64-162-213.subs.proxad.net] has joined #bitcoin-core-dev 18:10 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Remote host closed the connection] 18:20 -!- Lockesmith [~user@gateway/tor-sasl/lockesmith] has quit [Ping timeout: 260 seconds] 18:21 -!- Lockesmith [~user@gateway/tor-sasl/lockesmith] has joined #bitcoin-core-dev 18:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 18:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 18:33 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 19:31 -!- dodo [~dodo@user/dodo] has quit [Server closed connection] 19:31 -!- dodo [~dodo@user/dodo] has joined #bitcoin-core-dev 20:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:03 -!- mcey_ [~emcy@148.252.128.42] has quit [Remote host closed the connection] 21:04 -!- mcey_ [~emcy@148.252.128.42] has joined #bitcoin-core-dev 21:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:30 -!- mudsip [~mudsip@user/mudsip] has quit [] 22:00 -!- mcey_ [~emcy@148.252.128.42] has quit [Read error: Connection reset by peer] 22:01 -!- mcey [~emcy@148.252.128.42] has joined #bitcoin-core-dev 22:20 -!- pyth [~pyth@116.110.42.94] has joined #bitcoin-core-dev 22:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Remote host closed the connection] 22:57 -!- puchka [~puchka@185.203.122.224] has joined #bitcoin-core-dev 23:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 23:13 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!] 23:16 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 23:47 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 23:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 246 seconds] --- Log closed Wed Jul 17 00:00:51 2024