--- Log opened Thu Jul 18 00:00:13 2024 --- Day changed Thu Jul 18 2024 00:00 -!- rodarmor [sid210835@id-210835.helmsley.irccloud.com] has quit [Server closed connection] 00:00 -!- rodarmor [sid210835@id-210835.helmsley.irccloud.com] has joined #bitcoin-core-dev 00:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 00:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 260 seconds] 00:20 -!- gleb [sid306870@id-306870.lymington.irccloud.com] has quit [Server closed connection] 00:20 -!- gleb [sid306870@id-306870.lymington.irccloud.com] has joined #bitcoin-core-dev 00:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 00:37 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 272 seconds] 00:41 -!- kermit4 [sid393220@user/kermit4] has quit [Server closed connection] 00:41 -!- kermit4 [sid393220@user/kermit4] has joined #bitcoin-core-dev 00:42 -!- Novo__ [sid605808@id-605808.lymington.irccloud.com] has quit [Server closed connection] 00:42 -!- Novo__ [sid605808@id-605808.lymington.irccloud.com] has joined #bitcoin-core-dev 00:43 -!- hebasto [sid449604@id-449604.uxbridge.irccloud.com] has quit [Server closed connection] 00:43 -!- hebasto [sid449604@id-449604.uxbridge.irccloud.com] has joined #bitcoin-core-dev 00:44 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:46 -!- yonson [~yonson@2600:8801:e800:28::1962] has quit [Server closed connection] 00:46 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [] 00:46 -!- yonson [~yonson@2600:8801:e800:28::1962] has joined #bitcoin-core-dev 00:49 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 00:54 -!- bw_______ [sid2730@id-2730.ilkley.irccloud.com] has quit [Server closed connection] 00:54 -!- bw_______ [sid2730@id-2730.ilkley.irccloud.com] has joined #bitcoin-core-dev 00:55 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 264 seconds] 00:58 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has quit [Server closed connection] 00:58 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has joined #bitcoin-core-dev 01:06 -!- cornfeedhobo [~cornfeedh@user/cornfeedhobo] has quit [Server closed connection] 01:08 -!- jqq_ [sid628190@id-628190.uxbridge.irccloud.com] has quit [Server closed connection] 01:09 -!- jqq_ [sid628190@id-628190.uxbridge.irccloud.com] has joined #bitcoin-core-dev 01:11 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 260 seconds] 01:12 -!- cornfeedhobo [~cornfeedh@user/cornfeedhobo] has joined #bitcoin-core-dev 01:13 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 01:13 -!- FelixWeis__ [sid154231@id-154231.hampstead.irccloud.com] has quit [Server closed connection] 01:14 -!- FelixWeis__ [sid154231@id-154231.hampstead.irccloud.com] has joined #bitcoin-core-dev 01:18 -!- larryruane_ [sid473749@id-473749.uxbridge.irccloud.com] has quit [Server closed connection] 01:18 -!- larryruane_ [sid473749@id-473749.uxbridge.irccloud.com] has joined #bitcoin-core-dev 01:26 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 01:30 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 01:30 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 01:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 260 seconds] 01:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 02:00 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 272 seconds] 02:26 -!- Jackielove4u [sid43977@user/jackielove4u] has quit [Server closed connection] 02:26 -!- Jackielove4u [sid43977@user/jackielove4u] has joined #bitcoin-core-dev 02:28 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 02:34 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 255 seconds] 02:44 -!- takinbo [~takinbo@user/takinbo] has quit [Server closed connection] 02:44 -!- takinbo [~takinbo@user/takinbo] has joined #bitcoin-core-dev 02:49 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 02:52 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 02:53 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Ping timeout: 252 seconds] 02:53 -!- hirish [~hirish@ip251.ip-178-33-19.eu] has quit [Quit: ZNC - https://znc.in] 02:53 -!- hirish [~hirish@ip251.ip-178-33-19.eu] has joined #bitcoin-core-dev 02:54 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 264 seconds] 02:54 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 252 seconds] 02:56 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev 03:26 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 03:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 260 seconds] 03:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 03:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 265 seconds] 03:51 -!- jonasschnelli [~jonasschn@bitcoinsrv3.jonasschnelli.ch] has quit [Server closed connection] 03:52 -!- jonasschnelli [~jonasschn@bitcoinsrv3.jonasschnelli.ch] has joined #bitcoin-core-dev 04:02 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 04:07 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev 04:07 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 264 seconds] 04:15 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Server closed connection] 04:15 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev 04:16 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Server closed connection] 04:16 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined #bitcoin-core-dev 04:21 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 04:25 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 246 seconds] 04:31 -!- achow101 [~achow101@user/achow101] has quit [Server closed connection] 04:31 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev 04:39 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 04:44 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 260 seconds] 04:49 -!- bitcoin-git [~bitcoin-g@2620:6e:a000:ce11::21] has quit [Server closed connection] 04:49 -!- bitcoin-git [~bitcoin-g@2620:6e:a000:ce11::21] has joined #bitcoin-core-dev 04:58 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 05:03 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 246 seconds] 05:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 05:24 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 272 seconds] 05:29 -!- Murch[m] [~murch@2620:6e:a000:ce11::1b] has quit [Server closed connection] 05:29 -!- Murch[m] [~murch@2620:6e:a000:ce11::1b] has joined #bitcoin-core-dev 05:37 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 05:37 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 05:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 05:38 -!- jon_atack [~jonatack@user/jonatack] has quit [Excess Flood] 05:39 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 05:43 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 248 seconds] 05:55 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 05:55 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:01 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 260 seconds] 06:10 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 06:16 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 06:17 -!- gnusha [~gnusha@user/gnusha] has quit [Server closed connection] 06:17 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-core-dev 06:17 -!- Topic for #bitcoin-core-dev: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 06:17 -!- Topic set by achow101 [] [Thu May 25 07:25:40 2023] 06:17 -!- Irssi: #bitcoin-core-dev: Total of 173 nicks [2 ops, 0 halfops, 0 voices, 171 normal] 06:17 -!- Channel #bitcoin-core-dev created Wed May 19 06:52:47 2021 06:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 06:19 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 06:19 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 06:19 -!- Irssi: Join to #bitcoin-core-dev was synced in 144 secs 06:24 -!- freesprung51269 [~freesprun@user/freesprung] has quit [Server closed connection] 06:24 -!- freesprung51269 [~freesprun@user/freesprung] has joined #bitcoin-core-dev 06:25 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 246 seconds] 06:33 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 06:48 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Quit: leaving] 06:55 -!- Emc99 [~Emc99@212.129.86.218] has joined #bitcoin-core-dev 07:00 < achow101> #startmeeting 07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild 07:00 < dergoegge> hi 07:00 < stickies-v> hi 07:00 < glozow> hi 07:00 < instagibbs> hi 07:00 < sdaftuar> hi (only sort of here) 07:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add 07:00 < cfields> hi 07:01 < furszy> hi 07:01 < fjahr> hi 07:01 < tdb3> hi 07:01 < lightlike> Hi 07:01 < achow101> #topic package relay updates (glozow) 07:01 < pinheadmz> hi 07:01 < glozow> Not much new. #30111 is still the PR to review. #30295 was merged. 07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters once per tip change by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub 07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30295 | #28984 package rbf followups by instagibbs · Pull Request #30295 · bitcoin/bitcoin · GitHub 07:01 < brunoerg> hi 07:01 < maxedw> hi 07:01 < sipa> hi 07:02 < hebasto> hi 07:02 < achow101> #topic cluster mempool updates (sdaftuar) 07:02 -!- flag [~flag@81.56.89.175] has joined #bitcoin-core-dev 07:02 < sdaftuar> i don't have much -- sipa's PR 31026 is still the one to review, and i suspect it's getting close 07:02 < sdaftuar> er #30126 07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub 07:03 < sipa> getting some review, making progress 07:03 < instagibbs> thanks for carving off some of those optimizations, will be easier to ack 07:03 < glozow> reviewing! 07:03 < sipa> not much to report otherwise 07:04 < sipa> thanks for the reviews! 07:04 < achow101> #topic legacy wallet removal updates (achow101) 07:05 < achow101> Not much activity. #30328 is the current pr to review. 07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub 07:05 < achow101> #topic Ad-hoc high priority for review 07:05 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 07:06 < instagibbs> achow101 would like to bring up a couple PRs to attention, since there's been some concept drift, and I think at least one can make it into 28.0 along with 1P1C relay. 07:06 < instagibbs> (not sure if this is the right slot) 07:06 < achow101> instagibbs: go ahead 07:06 < instagibbs> #30352 this is a new output type called Pay To Anchor 07:06 < instagibbs> made standard to spend, to be used in an anchor pattern. 07:06 < instagibbs> This does not include the ability to make dust, which 07:06 < instagibbs> is now a separate feature I'm calling Ephemeral Dust. 07:06 < instagibbs> P2A + Ephemeral Dust = Ephemeral Anchor. 07:06 < instagibbs> This PR is under 40 lines of logic. 07:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/30352 | policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending by instagibbs · Pull Request #30352 · bitcoin/bitcoin · GitHub 07:06 < instagibbs> #30239 is Ephemeral Dust, which leverages TRUC to allow dust that is spent in the same transaction package. With 1P1C relay in place, this should allow simpler smart contracts to be created. 07:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/30239 | Ephemeral Dust by instagibbs · Pull Request #30239 · bitcoin/bitcoin · GitHub 07:07 < instagibbs> This PR is slightly more involved, but is mostly tests. 07:07 < instagibbs> Focus on P2A first would be nice. Fin. 07:07 -!- Sjors[m]1 [~provooste@2620:6e:a000:ce11::1f] has quit [Quit: Reconnecting] 07:08 -!- Sjors[m]1 [~provooste@2620:6e:a000:ce11::1f] has joined #bitcoin-core-dev 07:08 < glozow> I'll also shill #30275 for 28.0 07:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/30275 | Fee Estimation: change `estimatesmartfee` default mode to `economical` by ismaelsadeeq · Pull Request #30275 · bitcoin/bitcoin · GitHub 07:08 < achow101> prehaps #30352 to chasing comcept ack then? 07:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/30352 | policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending by instagibbs · Pull Request #30352 · bitcoin/bitcoin · GitHub 07:09 < instagibbs> It's got some concept ACKs(and rocket emojis), it's not a new idea, but if you like yeah 07:10 < Sjors[m]1> hi 07:11 < achow101> glozow: i'll add it to the milestone 07:11 < achow101> also, 28.0 feature freeze is 4 weeks 07:11 < achow101> Any other topics to discuss? 07:11 < sipa> i'd like to see #28280 make it in, and it's getting close i think 07:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/28280 | Dont empty dbcache on prune flushes: >30% faster IBD by andrewtoth · Pull Request #28280 · bitcoin/bitcoin · GitHub 07:11 < jonatack> hi 07:11 < kanzure> hi 07:12 < achow101> sipa: yeah, i've been looking at that too 07:14 < lightlike> Was also planning to review that again 07:15 < fjahr> Review begs #29519 and #30320 so we can get mainnet assumeutxo 07:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/29519 | p2p: For assumeutxo, download snapshot chain before background chain by mzumsande · Pull Request #29519 · bitcoin/bitcoin · GitHub 07:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/30320 | assumeutxo: Dont load a snapshot if its not in the best header chain by mzumsande · Pull Request #30320 · bitcoin/bitcoin · GitHub 07:17 < achow101> #endmeeting 07:17 -!- Emc99 [~Emc99@212.129.86.218] has quit [Quit: Client closed] 07:18 < pinheadmz> Sjors[m]1 wanna chat about abstract connman for stratum and http servers? 07:19 < cfields> instagibbs: re 30352 I followed a maze back to a dead link for an ephemeral anchors bip. Is there a current one? 07:19 < Sjors[m]1> pinheadmz: sure, that would be useful. 07:20 < instagibbs> cfields I killed off the BIP because it just became very implementation-specific. Would a slightly longer description of how the two PRs link together help on a gist/PR? 07:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:23 < cfields> instagibbs: more like a very high-level description for someone who's not familiar with your policy goals but is interested in reviewing the code for sanity :) 07:24 < instagibbs> I'll take that as a hint to rewrite the OP. Will do. 07:35 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Server closed connection] 07:35 -!- cryptapus [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev 07:38 -!- JTL [~jtl@user/jtl] has quit [Server closed connection] 07:40 < bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/3679fa167f7d...efbf4e71ce8e 07:40 < bitcoin-git> bitcoin/master 7f61d31 ismaelsadeeq: [refactor]: update coin selection algorithms input parameter `max_weight` ... 07:40 < bitcoin-git> bitcoin/master baab0d2 ismaelsadeeq: [doc]: update reason for deducting change output weight 07:40 < bitcoin-git> bitcoin/master b6fc504 ismaelsadeeq: [wallet]: update the data type of `change_output_size`, `change_spend_size... 07:40 < bitcoin-git> [bitcoin] achow101 merged pull request #29523: Wallet: Add `max_tx_weight` to transaction funding options (take 2) (master...02-2024-add-max-weight-to-tx-funding) https://github.com/bitcoin/bitcoin/pull/29523 07:40 < bitcoin-git> [bitcoin] brunoerg closed pull request #30461: fuzz: add target for `CoinsResult` (master...2024-07-fuzz-coinsresult) https://github.com/bitcoin/bitcoin/pull/30461 07:40 < bitcoin-git> [bitcoin] hebasto opened pull request #30477: depends: Amend handling flags environment variables (master...240718-deps-env) https://github.com/bitcoin/bitcoin/pull/30477 07:41 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/efbf4e71ce8e...9c8b36eba658 07:41 < bitcoin-git> bitcoin/master 5d25a82 Hennadii Stepanov: univalue, refactor: Convert indentation tabs to spaces 07:41 < bitcoin-git> bitcoin/master 44f0878 Hennadii Stepanov: test: Fix MSVC warning C4101 "unreferenced local variable" 07:41 < bitcoin-git> bitcoin/master 9c8b36e merge-script: Merge bitcoin/bitcoin#30464: test, refactor: Fix MSVC warning C4101 "unref... 07:41 < bitcoin-git> [bitcoin] fanquake merged pull request #30464: test, refactor: Fix MSVC warning C4101 "unreferenced local variable" (master...240716-univalue) https://github.com/bitcoin/bitcoin/pull/30464 07:42 -!- JTL [~jtl@user/jtl] has joined #bitcoin-core-dev 07:45 < bitcoin-git> [bitcoin] ryanofsky pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9c8b36eba658...ef19a193fc66 07:45 < bitcoin-git> bitcoin/master 323cfed Sjors Provoost: refactor: use CHECK_NONFATAL to avoid single-use symbol 07:45 < bitcoin-git> bitcoin/master 6b4c817 Sjors Provoost: refactor: pass BlockCreateOptions to createNewBlock 07:45 < bitcoin-git> bitcoin/master c504b69 Sjors Provoost: refactor: add coinbase constraints to BlockCreateOptions 07:45 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30356: refactor: add coinbase constraints to BlockAssembler::Options (master...2024/06/coinbase-constraints) https://github.com/bitcoin/bitcoin/pull/30356 07:56 < pinheadmz> Sjors[m]1 sorry, distracted. ok. so, seems like a big refactor of conman, and like, itd need an abstract client that can tell us if that client needs to read or write so we can compare with WaitMany 07:58 < Sjors[m]1> pinheadmz: what seems a big refactor? Your WIP? 07:59 -!- puchka [~puchka@185.203.122.224] has quit [Ping timeout: 272 seconds] 07:59 < Sjors[m]1> For #30332 I need something much simpler than all of connman, so I can avoid copy-pasting the socket handling stuff. 07:59 <@gribble> https://github.com/bitcoin/bitcoin/issues/30332 | Stratum v2 connman by Sjors · Pull Request #30332 · bitcoin/bitcoin · GitHub 08:01 -!- lbia [~lbia@user/lbia] has quit [Server closed connection] 08:02 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev 08:02 < pinheadmz> yeah just running a server without libevent. theres a loop that accepts connections, checks sockets for readiness, and sends or receives messages depending on whats ready. 08:02 < pinheadmz> connman does that and i copy pasted much of that into a http server as well 08:02 < Sjors[m]1> Indeed 08:02 < Sjors[m]1> Right, so we both have a shared interest in less copy-paste. 08:02 < Sjors[m]1> Are you just doing this for REST or also RPC? 08:03 < pinheadmz> both yeah 08:06 < pinheadmz> so yeah what i meant by refactor is pulling out of connman something generic and reusable 08:20 < cfields> Mmm, I probably should've asked during the meeting... 08:21 < cfields> I've just written up a plan for the next few weeks for cmake. (review beg starts next week, which is why I didn't bring it up this week). But I do think it makes sense to start sketching out a plan/roadmap to begin setting expectations... 08:22 < cfields> achow101: Would it make sense to go ahead and setup a CMake project on github? 08:27 -!- puchka [~puchka@185.203.122.203] has joined #bitcoin-core-dev 08:40 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Remote host closed the connection] 08:40 -!- mcey [~emcy@148.252.128.42] has quit [Ping timeout: 255 seconds] 08:45 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 08:46 -!- RaphaelH [~RaphaelH@2a01cb0100406de9bc5d4aea7056ba11.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 08:46 -!- mcey [~emcy@148.252.128.42] has joined #bitcoin-core-dev 08:50 -!- mcey_ [~emcy@148.252.128.42] has joined #bitcoin-core-dev 08:51 -!- mcey [~emcy@148.252.128.42] has quit [Ping timeout: 252 seconds] 08:55 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev 08:57 -!- RaphaelH [~RaphaelH@user/RaphaelH] has changed host 08:58 -!- Guest82 [~Guest82@2a01cb0100406de9bc5d4aea7056ba11.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 08:58 -!- Guest82 [~Guest82@2a01cb0100406de9bc5d4aea7056ba11.ipv6.abo.wanadoo.fr] has quit [Client Quit] 08:59 < RaphaelH> Hello, I am currently studying bitcoin core network protocol and I was wondering how the 1000 addresses in ADDR message (responding to a GETADDR) were chosen among the new/tried tables. I have looked at the codebase but I don't really understand where this is done nor have I found documentation/a wiki. Does anyone have helping ressources please? 09:01 < lightlike> RaphaelH: They are chosen randomly, we don't care about maintaining some specific new/tried ratio at all. 09:01 -!- dlb76 [~dlb76@user/dlb76] has quit [Server closed connection] 09:04 < sipa> RaphaelH: the code is in https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L806 09:05 -!- dlb76 [~dlb76@user/dlb76] has joined #bitcoin-core-dev 09:05 -!- emcy__ [~emcy@148.252.128.42] has joined #bitcoin-core-dev 09:06 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:08 < lightlike> since nodes often have more new entries than tried ones (especially when they haven't been running for months), this can result in pretty low-quality getaddr responses, so there have been ideas to change that. On the other hand, we wouldn't want to reveal our tried table to other peers due to eclipse attacks, so it's not completely trivial. 09:08 -!- mcey_ [~emcy@148.252.128.42] has quit [Ping timeout: 252 seconds] 09:08 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef19a193fc66...20ccb30b7af1 09:08 < bitcoin-git> bitcoin/master faed5d3 MarcoFalke: test: Non-Shy version sender 09:08 < bitcoin-git> bitcoin/master 20ccb30 glozow: Merge bitcoin/bitcoin#30453: test: Non-Shy version sender 09:08 < bitcoin-git> [bitcoin] glozow merged pull request #30453: test: Non-Shy version sender (master...2407-test-ver) https://github.com/bitcoin/bitcoin/pull/30453 09:08 < RaphaelH> lightlike sipa Thanks a lot for your answers. Do you also know what happen when two different clients both send a GETADDR to a client (in a short period of time), do they both get the same answer or do the "random choice" change at some point? 09:10 < lightlike> RaphaelH: all nodes (from a given network such as IPv4) get the same cached answer within 24h. This caching was introduced a couple years ago to prevent probing. 09:10 < lightlike> (in https://github.com/bitcoin/bitcoin/pull/18991 ) 09:11 -!- helo [~helo@user/helo] has quit [Server closed connection] 09:11 -!- helo [~helo@user/helo] has joined #bitcoin-core-dev 09:17 < RaphaelH> lightlike Ok thanks a lot, I'm starting to understand. Also, I'm not sure I understand the "from a given network" part, is it possible to get two differents results depending if the nodes are in the IPv4/IPv6 network? I thought the address were always sent in IPv6 format 09:22 -!- emcy__ [~emcy@148.252.128.42] has quit [Ping timeout: 265 seconds] 09:22 -!- mcey [~emcy@148.252.128.42] has joined #bitcoin-core-dev 09:25 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has quit [Server closed connection] 09:25 -!- mcey_ [~emcy@148.252.144.183] has joined #bitcoin-core-dev 09:26 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has joined #bitcoin-core-dev 09:28 -!- mcey [~emcy@148.252.128.42] has quit [Ping timeout: 255 seconds] 09:32 -!- kvaciral[m]1 [~kvaciralx@2620:6e:a000:ce11::27] has quit [Server closed connection] 09:32 -!- kvaciral[m]1 [~kvaciralx@2620:6e:a000:ce11::27] has joined #bitcoin-core-dev 09:35 -!- mcey_ [~emcy@148.252.144.183] has quit [Ping timeout: 255 seconds] 09:39 -!- dermoth [~dermoth@user/dermoth] has quit [Server closed connection] 09:39 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev 09:40 -!- RaphaelH [~RaphaelH@user/RaphaelH] has quit [Quit: Client closed] 09:44 < lightlike> RaphaelH: it means that you send a peer connected to you via tor a different cached addr message than another peer connected to you via IPv4. That makes it harder for others to fingerprint you (connecting your tor with your ipv4 identity). 09:48 < achow101> cfields: sure 09:50 < achow101> https://github.com/orgs/bitcoin/projects/13 10:01 -!- mcey [~emcy@148.252.144.183] has joined #bitcoin-core-dev 10:21 -!- puchka [~puchka@185.203.122.203] has quit [Quit: leaving] 10:44 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:46 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 10:55 < bitcoin-git> [bitcoin] mzumsande opened pull request #30479: validation: Add eligible ancestors of reconsidered block to setBlockIndexCandidates (master...202407_fix_resetfailure) https://github.com/bitcoin/bitcoin/pull/30479 11:09 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 11:21 -!- Guest97 [~Guest97@2405:201:8013:685c:44d:1df8:68b4:155] has joined #bitcoin-core-dev 11:22 -!- IbanaeSanve [~IbanaeSan@2804:431:c7c4:5055:d1c2:f56:cd4e:27bb] has joined #bitcoin-core-dev 11:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 11:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:28 -!- SeeSharpRocks [~SeeSharpR@2a02:58:145:8800:559d:51e5:7b6:c0b8] has joined #bitcoin-core-dev 11:30 -!- IbanaeSanve45 [~IbanaeSan@2804:431:c7c4:5055:d1c2:f56:cd4e:27bb] has joined #bitcoin-core-dev 11:30 -!- IbanaeSanve45 [~IbanaeSan@2804:431:c7c4:5055:d1c2:f56:cd4e:27bb] has quit [Client Quit] 11:30 -!- IbanaeSanve [~IbanaeSan@2804:431:c7c4:5055:d1c2:f56:cd4e:27bb] has quit [Quit: Client closed] 11:37 -!- SeeSharpRocks [~SeeSharpR@2a02:58:145:8800:559d:51e5:7b6:c0b8] has quit [Quit: Client closed] 11:38 -!- Guest97 [~Guest97@2405:201:8013:685c:44d:1df8:68b4:155] has quit [Quit: Client closed] 12:08 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has joined #bitcoin-core-dev 12:08 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has quit [Client Quit] 12:10 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has joined #bitcoin-core-dev 12:14 < bitcoin-git> [bitcoin] Psc544 opened pull request #30480: 6fe04302f75958ca1ad398e637e9e44c680d3a2eCreate devcontainer.json (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30480 12:14 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 12:16 < bitcoin-git> [bitcoin] fanquake closed pull request #30480: 6fe04302f75958ca1ad398e637e9e44c680d3a2eCreate devcontainer.json (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30480 12:30 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection] 12:41 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:42 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Remote host closed the connection] 13:04 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has quit [Ping timeout: 276 seconds] 13:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 13:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Ping timeout: 260 seconds] 13:24 < harding> Is there an appropriate resource within the project (e.g. issue to bitcoin/bitcoin, a bitcoin-core/ repo, the bitcoin-dev mailing list) to discuss non-security-sensitive matters relating to the security@bitcoincore mailing list? 13:33 < achow101> harding: possibly bitcoin-core/meta? we're currently only using that for moderation related things, but in theory, it could be a general "meta topics" repo 13:34 < harding> achow101: that works, thanks! 13:38 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 13:51 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/20ccb30b7af1...6144aa21d060 13:51 < bitcoin-git> bitcoin/master fab54db MarcoFalke: rest: Reject negative outpoint index in getutxos parsing 13:51 < bitcoin-git> bitcoin/master fac932b MarcoFalke: refactor: Use util::Split to avoid a harmless unsigned-integer-overflow 13:51 < bitcoin-git> bitcoin/master 6144aa2 Ava Chow: Merge bitcoin/bitcoin#30444: rest: Reject negative outpoint index early in... 14:13 -!- johnny9dev584508 [~johnny9de@136.54.93.132] has quit [Ping timeout: 245 seconds] 14:15 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Remote host closed the connection] 14:19 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 14:22 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit] 14:26 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 14:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 14:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Read error: Connection reset by peer] 14:39 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.3.4] 14:45 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 14:45 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Remote host closed the connection] 14:47 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving] 15:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 16:59 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Remote host closed the connection] 17:05 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has joined #bitcoin-core-dev 18:19 -!- mcey [~emcy@148.252.144.183] has quit [Ping timeout: 246 seconds] 18:29 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving] 18:31 -!- mcey [~emcy@148.252.144.183] has joined #bitcoin-core-dev 19:54 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcf1:273d:47de:6aec] has quit [Remote host closed the connection] 20:12 -!- johnny9dev584508 [~johnny9de@136.54.93.132] has joined #bitcoin-core-dev 20:25 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev 20:30 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 252 seconds] 20:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:02 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 21:08 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 276 seconds] 21:16 -!- mcey_ [~emcy@148.252.129.215] has joined #bitcoin-core-dev 21:19 -!- mcey [~emcy@148.252.144.183] has quit [Ping timeout: 248 seconds] 21:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 21:25 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 248 seconds] 21:37 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 21:43 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 276 seconds] 22:00 -!- mcey_ [~emcy@148.252.129.215] has quit [Read error: Connection reset by peer] 22:06 -!- mcey [~emcy@148.252.129.215] has joined #bitcoin-core-dev 22:15 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 22:21 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 276 seconds] 22:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 22:39 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 252 seconds] 22:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 22:42 -!- aleggg [~aleggg@177.204.247.69.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 272 seconds] 22:42 -!- aleggg [~aleggg@179.182.74.87] has joined #bitcoin-core-dev 22:47 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 276 seconds] 22:58 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has joined #bitcoin-core-dev 23:03 -!- kevkevin [~kevkevin@2601:241:8703:7b30:2179:904f:dbd7:e6c8] has quit [Ping timeout: 252 seconds] 23:17 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 23:23 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 276 seconds] 23:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 23:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has joined #bitcoin-core-dev 23:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:bda6:c83b:81c4:1082] has quit [Ping timeout: 252 seconds] 23:46 -!- hel [hel@libera/staff/el] has quit [Read error: Connection reset by peer] 23:47 -!- hel [hel@libera/staff/el] has joined #bitcoin-core-dev 23:47 -!- jaxon-dozier [~jaxon-doz@2600:1700:bd34:4b00:49b0:53c7:4d02:1a55] has joined #bitcoin-core-dev --- Log closed Fri Jul 19 00:00:57 2024