--- Log opened Thu Aug 01 00:00:09 2024
00:03 -!- kevkevin [~kevkevin@2601:243:197e:8f10:e5ad:b1c1:8c19:38be] has joined #bitcoin-core-dev
00:08 -!- kevkevin [~kevkevin@2601:243:197e:8f10:e5ad:b1c1:8c19:38be] has quit [Ping timeout: 248 seconds]
00:21 -!- kevkevin [~kevkevin@c-73-111-168-5.hsd1.il.comcast.net] has joined #bitcoin-core-dev
00:26 -!- kevkevin [~kevkevin@c-73-111-168-5.hsd1.il.comcast.net] has quit [Ping timeout: 245 seconds]
00:58 -!- kevkevin [~kevkevin@c-73-111-168-5.hsd1.il.comcast.net] has joined #bitcoin-core-dev
01:01 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:04 -!- kevkevin [~kevkevin@c-73-111-168-5.hsd1.il.comcast.net] has quit [Ping timeout: 260 seconds]
01:17 -!- kevkevin [~kevkevin@2601:243:197e:8f10:e5ad:b1c1:8c19:38be] has joined #bitcoin-core-dev
01:23 -!- kevkevin [~kevkevin@2601:243:197e:8f10:e5ad:b1c1:8c19:38be] has quit [Ping timeout: 276 seconds]
01:26 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
01:28 -!- SpellChecker_ is now known as SpellChecker
01:31 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 260 seconds]
01:49 < bitcoin-git> [bitcoin] glozow pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/66e82dc90c59...b8755164cf9c
01:49 < bitcoin-git> bitcoin/master 662e8db dergoegge: [net processing] Lazily initialize m_recent_rejects
01:49 < bitcoin-git> bitcoin/master fa0c87f dergoegge: [net processing] Lazily initialize m_recent_rejects_reconsiderable
01:49 < bitcoin-git> bitcoin/master 82de1bc dergoegge: [net processing] Lazily initialize m_recent_confirmed_transactions
01:49 < bitcoin-git> [bitcoin] glozow merged pull request #30413: p2p: Lazy init some bloom filters; fuzz version handshake (master...2024-07-fuzz-handshake) https://github.com/bitcoin/bitcoin/pull/30413
01:50 < bitcoin-git> [bitcoin] wrathmdx opened pull request #30566: Name Change (27.x...27.x) https://github.com/bitcoin/bitcoin/pull/30566
01:50 < bitcoin-git> [bitcoin] wrathmdx closed pull request #30566: Name Change (27.x...27.x) https://github.com/bitcoin/bitcoin/pull/30566
02:00 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
02:04 -!- mcey_ [~emcy@185.69.145.117] has joined #bitcoin-core-dev
02:06 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 252 seconds]
02:07 -!- mcey [~emcy@148.252.129.171] has quit [Ping timeout: 252 seconds]
02:08 < bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/3285399763d7...e6c7ee31b2c9
02:08 < bitcoin-git> bitcoincore.org/master 5e79a88 azuchi: Apply #1044 changes to japanese translations
02:08 < bitcoin-git> bitcoincore.org/master e6c7ee3 merge-script: Merge bitcoin-core/bitcoincore.org#1051: Apply #1044 changes to japanese t...
02:08 < bitcoin-git> [bitcoincore.org] fanquake merged pull request #1051: Apply #1044 changes to japanese translations (master...apply-#1044-to-ja) https://github.com/bitcoin-core/bitcoincore.org/pull/1051
02:11 -!- emcy__ [~emcy@148.252.144.208] has joined #bitcoin-core-dev
02:14 -!- mcey_ [~emcy@185.69.145.117] has quit [Ping timeout: 252 seconds]
02:28 < bitcoin-git> [bitcoincore.org] fanquake opened pull request #1052: Use consistent date format for advisories (master...same_dates) https://github.com/bitcoin-core/bitcoincore.org/pull/1052
02:33 < bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/e6c7ee31b2c9...14c0eda9efcc
02:33 < bitcoin-git> bitcoincore.org/master 533ee9b azuchi: Add japanese translations for security advisories in Bitcoin Core v22.0
02:33 < bitcoin-git> bitcoincore.org/master 14c0eda merge-script: Merge bitcoin-core/bitcoincore.org#1050: Add japanese translations for sec...
02:33 < bitcoin-git> [bitcoincore.org] fanquake merged pull request #1050: Add japanese translations for security advisories in Bitcoin Core v22.0 (master...translate-security-advisories-22.0) https://github.com/bitcoin-core/bitcoincore.org/pull/1050
02:34 < bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/14c0eda9efcc...fc58fdf730d9
02:35 < bitcoin-git> bitcoincore.org/master 96930ea fanquake: use consistent date format for advisories
02:35 < bitcoin-git> bitcoincore.org/master fc58fdf merge-script: Merge bitcoin-core/bitcoincore.org#1052: Use consistent date format for ad...
02:35 < bitcoin-git> [bitcoincore.org] fanquake merged pull request #1052: Use consistent date format for advisories (master...same_dates) https://github.com/bitcoin-core/bitcoincore.org/pull/1052
02:56 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
03:01 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 248 seconds]
03:07 -!- flag [~flag@81.56.89.175] has quit [Ping timeout: 244 seconds]
03:09 -!- flag [~flag@81.56.89.175] has joined #bitcoin-core-dev
03:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8755164cf9c...dc605cf6e601
03:27 < bitcoin-git> bitcoin/master 89b1d5c Hennadii Stepanov: depends: Fix `zeromq` build on OpenBSD
03:27 < bitcoin-git> bitcoin/master dc605cf merge-script: Merge bitcoin/bitcoin#30565: depends: Fix `zeromq` build on OpenBSD
03:27 < bitcoin-git> [bitcoin] fanquake merged pull request #30565: depends: Fix `zeromq` build on OpenBSD (master...240731-openbsd-zmq) https://github.com/bitcoin/bitcoin/pull/30565
03:31 -!- rishkwal [~rishkwal@2405:201:8013:685c:e0d2:70f4:5445:5fc7] has joined #bitcoin-core-dev
03:32 -!- pablomartin4btc [~pablomart@188.241.144.176] has joined #bitcoin-core-dev
03:33 -!- pablomartin4btc [~pablomart@188.241.144.176] has quit [Client Quit]
03:34 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
03:39 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 252 seconds]
03:53 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
03:58 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 272 seconds]
04:06 < bitcoin-git> [bitcoin] glozow pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/dc605cf6e601...ebd82fa9fae1
04:06 < bitcoin-git> bitcoin/master 526a87b stickies-v: test: add uint256::FromHex unittest coverage
04:06 < bitcoin-git> bitcoin/master 9a0b2a6 stickies-v: fuzz: increase FromHex() coverage
04:06 < bitcoin-git> bitcoin/master 285ab50 stickies-v: test: replace WtxidFromString with Wtxid::FromHex
04:06 < bitcoin-git> [bitcoin] glozow merged pull request #30532: refactor: remove deprecated TxidFromString() in favour of transaction_identifier::FromHex() (master...2024-07/rm-txidfromstring) https://github.com/bitcoin/bitcoin/pull/30532
04:30 -!- rishkwal [~rishkwal@2405:201:8013:685c:e0d2:70f4:5445:5fc7] has quit [Quit: Client closed]
04:31 -!- pablomartin [~pablomart@188.241.144.181] has joined #bitcoin-core-dev
04:39 -!- rishkwal [~rishkwal@2405:201:8013:685c:e0d2:70f4:5445:5fc7] has joined #bitcoin-core-dev
04:40 -!- rishkwal [~rishkwal@2405:201:8013:685c:e0d2:70f4:5445:5fc7] has quit [Client Quit]
04:59 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
05:01 -!- angusp [9e8eed9774@2a03:6000:1812:100::1048] has quit [Remote host closed the connection]
05:02 -!- angusp [9e8eed9774@2a03:6000:1812:100::1048] has joined #bitcoin-core-dev
05:13 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 252 seconds]
05:58 -!- virtu [~virtu@user/virtu] has changed host
06:02 -!- Olsen [~Olsen@195.35.42.133] has joined #bitcoin-core-dev
06:08 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
06:08 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
06:08 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
06:08 -!- flooded is now known as _flood
06:09 < bitcoin-git> [bitcoin] hebasto opened pull request #30567: qt, build: Drop `QT_STATICPLUGIN` macro (master...240801-qtstatic) https://github.com/bitcoin/bitcoin/pull/30567
06:24 -!- flag [~flag@81.56.89.175] has quit [Ping timeout: 252 seconds]
06:26 -!- flag [~flag@81.56.89.175] has joined #bitcoin-core-dev
06:30 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:33 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
06:34 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:39 -!- Guest77 [~Guest77@2607:fb90:8f03:83b5:82dc:b5d6:7fd0:6d77] has joined #bitcoin-core-dev
06:41 -!- Guest77 [~Guest77@2607:fb90:8f03:83b5:82dc:b5d6:7fd0:6d77] has quit [Client Quit]
06:47 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Remote host closed the connection]
06:49 -!- cryptapus [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev
06:49 -!- Olsen [~Olsen@195.35.42.133] has quit [Ping timeout: 256 seconds]
06:50 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
06:59 < glozow> hi
07:00 -!- dzxzg [~bezel@2600:380:4969:e676:c4e7:ee73:73cc:d726] has joined #bitcoin-core-dev
07:00 < pinheadmz> hi g!
07:00 < stickies-v> hi
07:00 < glozow> #startmeeting
07:00 < b10c> hi
07:00 < glozow> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < fjahr> hi
07:00 < instagibbs> hi
07:00 < brunoerg> hi
07:00 < dzxzg> hi
07:00 < hebasto> hi
07:00 < furszy> hi
07:00 < lightlike> Hi
07:00 < ajonas> hi
07:00 < jonatack> hi
07:00 < cfields> hi
07:01 < glozow> I see 2 topics proposed by fjahr, any last-minute ones to add?
07:01 < dergoegge> hi
07:01 < josie> hi
07:01 < sdaftuar> hi
07:01 < tdb3> hi
07:01 < glozow> #topic package relay updates (glozow)
07:01 < darosior> hi
07:01 < glozow> #30110 is the priority PR - it's a lot of commits, but mostly just moving things out of net_processing, and then around 800 lines test code at the end. I've also rebased #20831 on top of it.
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30110 | refactor: TxDownloadManager by glozow · Pull Request #30110 · bitcoin/bitcoin · GitHub
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/20831 | Cannot generate change address on descriptor wallets. · Issue #20831 · bitcoin/bitcoin · GitHub
07:02 < glozow> #topic cluster mempool updates (sdaftuar, sipa)
07:02 -!- marcofleon [~marcofleo@181.214.131.162] has joined #bitcoin-core-dev
07:02 < sdaftuar> cluster mempool is moving along.  #30126: merged.  next up: #30285!
07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub
07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/30285 | cluster mempool: merging & postprocessing of linearizations by sipa · Pull Request #30285 · bitcoin/bitcoin · GitHub
07:02 < sdaftuar> please review :)
07:03 < glozow> yay! and then #30286?
07:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/30286 | cluster mempool: optimized candidate search by sipa · Pull Request #30286 · bitcoin/bitcoin · GitHub
07:03 < sdaftuar> yep
07:03 < glozow> 👍
07:03 < glozow> #topic legacy wallet removal updates (achow101)
07:03 < sipa> hi
07:03 < instagibbs> do you expect the mainline cluster mempool PR ready after the postlin/merge PR?
07:03 < sipa> (nothing to add, carry on)
07:03 < Murch[m]> hi
07:04 < sdaftuar> instagibbs: not quite; we still need a reimplementation if the txgraph module before i take that out of draft
07:04 < instagibbs> k
07:04 < fanquake> "legacy wallet update since I won't be at the meeting tomorrow: Main PRs to review are #30328 and https://github.com/bitcoin-core/gui/pull/824. I will address the current review comments next week." from the scrollback
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub
07:05 < glozow> Ah, should I replace #27677 with #30289 in the project board? https://github.com/orgs/bitcoin/projects/1/views/2
07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/27677 | Proposal for a new mempool design · Issue #27677 · bitcoin/bitcoin · GitHub
07:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/30289 | Cluster mempool tracking issue · Issue #30289 · bitcoin/bitcoin · GitHub
07:05 < sr_gi[m]1> Hi
07:06 < glozow> fanquake: thanks
07:06 < sdaftuar> glozow:yes i think so?
07:06 < glozow> done
07:06 < sipa> i'll add new references to design etc in #30289
07:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/30289 | Cluster mempool tracking issue · Issue #30289 · bitcoin/bitcoin · GitHub
07:07 < glozow> #topic Testnet 4 in v28 (fjahr)
07:08 < fjahr> Hi, so the Testnet 4 BIP and PR (#29775) seem pretty much final except for two remaining questions, I will post both because they are somewhat connected:
07:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/29775 | Testnet4 including PoW difficulty adjustment fix by fjahr · Pull Request #29775 · bitcoin/bitcoin · GitHub
07:08 < abubakarsadiq> hi
07:08 < fjahr> 1. Can we embed interesting scripts in the chains initial blocks and add a checkpoint? We can and I have been working on it but I think I won’t be able to finish it before the feature freeze due to travelling etc. I am still developing the tooling for this and will use it to put scripts into the chain, just not at the start of Testnet 4. But it will make it possible and ease the launch for an eventual Testnet 5. Do people 
07:08 < fjahr> think this is absolutely necessary and should delay merging Testnet 4? My opinion is clearly no and I have heard similar feedback but I wanted to make sure this has been brought up.
07:08 < pablomartin> hey
07:08 < fjahr> And 2. Do we need another reset before merging? I would say here the feedback is split. Had we gotten 1. done this would have made the reset necessary but some might still want it nonetheless. Personally I don’t see an issue with the “pre-mine” of 40k blocks. Many of these coins seem to be available through free faucets which makes it easier for anyone to get some right from the start. There is some distribution among 
07:08 < fjahr> several miners and it’s not clear to me if a more public re-launch gives us a fairer result. Maybe someone invests a bit more hashrate in order to get all of those first 40k blocks. And not resetting allows us to also set a min chain work as sjors mentioned on the PR. So I see more upside on not resetting personally but happy to discuss it.
07:08 < bitcoin-git> [qa-assets] murchandamus opened pull request #194: Add ten initial corpora and new seeds (main...2024-08-add-seeds) https://github.com/bitcoin-core/qa-assets/pull/194
07:09 < vasild> hi
07:09 < sipa> I don't see the issue with "pre-mine". If testnet4 coins have no value, this is irrelevant. If they do, it has failed and we shouldn't continue with it anyway.
07:10 < fjahr> sipa: yepp
07:10 < glozow> fwiw I don't think reproducing interesting scripts should be necessary for starting a new testnet
07:10 < darosior> i have not been following the work on testnet4 but regarding the first question, it doesn't seem crucial to me for weird scripts to be specifically at the very beginning of the chain
07:10 < sipa> also agreed on not treating the interesting scripts thing as a blocker
07:10 < instagibbs> darosior +1
07:10 -!- Olsen [~Olsen@2804:431:c7ca:1df4:8404:7eef:79a7:7712] has joined #bitcoin-core-dev
07:10 < stickies-v> 1. no I don't think this should hold up testnet4, this shouldn't be an inherent quality of a testnet, even though it'd be nice if they get added at some point
07:10 < sipa> because once testnet4 is "active" it'll be much easier for people to contribute "interesting scripts" themselves
07:11 < darosior> Yes good point
07:11 < jonatack> fjahr: I agree with your suggestion on each point.
07:12 < tdb3> same
07:12 < b10c> where are you working on the "interesting script" part? I ran into a few recently that I might want to contribute/have in there
07:13 < fjahr> the repo is here: https://github.com/fjahr/test_chain_init but I have done more that I haven't pushed yet, so please give me a bit of time, I can announce when it's ready for contributions
07:13 < b10c> sure, will open an issue
07:13 < fjahr> b10c: cool, thanks!
07:14 < glozow> fjahr: should we move on to your next topic?
07:14 -!- kashifs [~kashifs@2603:7000:4600:500:d0e2:4306:4b03:4d2e] has joined #bitcoin-core-dev
07:14 < fjahr> sure
07:14 < glozow> #topic AssumeUTXO mainnet in v28 (fjahr)
07:15 < fjahr> Here, I would like to ask for conceptual feedback on #30516 if others agree with maflcko that the metadata needs to be changed once more.
07:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/30516 | Assumeutxo: Sanitize block height in metadata by fjahr · Pull Request #30516 · bitcoin/bitcoin · GitHub
07:15 < fjahr> And also I would like to ask for review of #29519 again
07:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/29519 | p2p: For assumeutxo, download snapshot chain before background chain by mzumsande · Pull Request #29519 · bitcoin/bitcoin · GitHub
07:15 < fjahr> Unless there are questions I think there isn’t much to discuss. A lot has been done on AssumeUTXO (see #29616) and I think we can add the mainnet params next week with a little more help. Thanks!
07:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/29616 | AssumeUTXO Mainnet Readiness Tracking · Issue #29616 · bitcoin/bitcoin · GitHub
07:17 < maflcko> fjahr: I'd say it doesn't need to be changed, but once the bug is fixed, the unused field seems clearer to remove, no?
07:17 < furszy> fjahr: q: guess the time in which the interesting scripts are included is important due to feature activations? e.g. pre/post taproot activation.
07:18 < luke-jr_> fjahr:  #28598 shouldn't be considered optional
07:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/28598 | assumeutxo: Ensure transactions are not presented as confirmed until background sync is complete · Issue #28598 · bitcoin/bitcoin · GitHub
07:18 < maflcko> furszy: Everything is active since block 1, see https://github.com/bitcoin/bips/pull/1601/files#diff-b1dfc6b3d29248b595d00c195cf1432deac01b23f04b1cacbb22def5a264223fR87 
07:18 < fjahr> furszy: taproot is activated from the start in testnet 4, so I don't think this is relevant
07:19 < fjahr> luke-jr_: I addressed this here: https://github.com/bitcoin/bitcoin/issues/29616#issuecomment-1997399080
07:20 < darosior> luke-jr_: the feature is opt-in, if you are opting into using an "assumed and trusted utxo set" in the first place it doesn't seem critical
07:20 < fjahr> maflcko: We added it without critical use initially and it got conceptual acks and review just a few months ago. The idea was that we could use it for something interesting later. I don't want to remove it unless more people agree with you that we don't want these future/uncritical uses anymore
07:22 < glozow> Should we move on?
07:23 < fjahr> yepp, thanks all!
07:23 < Murch[m]> Oh, on the Testnet topic: the BIP is also close to getting merged, if you want to take a look
07:23 < fjahr> https://github.com/bitcoin/bips/pull/1601
07:23 < glozow> #topic 28.0 release priorities
07:23 < glozow> Feature freeze is scheduled for August 12. https://github.com/bitcoin/bitcoin/issues/29891
07:24 < glozow> Does anyone have anything to add to the milestone? https://github.com/bitcoin/bitcoin/milestone/66
07:25 < darosior> Can i get achow101's #22838? I think it's very close.
07:25 <@gribble> https://github.com/bitcoin/bitcoin/issues/22838 | descriptors: Be able to specify change and receiving in a single descriptor string by achow101 · Pull Request #22838 · bitcoin/bitcoin · GitHub
07:26 < glozow> Sure. Wow, seems very popular.
07:27 < glozow> Ok. Anything else to discuss?
07:27 < sipa> #28280 is already on the list, and seems pretty close too (there are some open review comments, but none seem blockers)
07:27 <@gribble> https://github.com/bitcoin/bitcoin/issues/28280 | Dont empty dbcache on prune flushes: >30% faster IBD by andrewtoth · Pull Request #28280 · bitcoin/bitcoin · GitHub
07:27 < pinheadmz> quick moderation reminder, https://github.com/bitcoin-core/meta has issues and PRs if anyone is interested in contributing to policy
07:28 < pinheadmz> also chatGPT bot reviewing every comment: https://t.me/s/bitcoincoregithubmoderation
07:28 < pinheadmz> some amusing false positives in there but you can also see how im getting my notifications if someone misbehaves
07:28 < pinheadmz> be nice! <3 youre being watched ;-)
07:29 < glozow> pinheadmz: thanks for moderating! :)
07:29 < glozow> sipa: will take a look
07:29 < vasild> chatgpt :-O I think the last 3 comments here, marked as off-topic: https://github.com/bitcoin/bitcoin/issues/29759 are not off-topic
07:29 < pinheadmz> yeah like i said, lots of false positives
07:30 < pinheadmz> the bot just helps out, its not the moderator
07:30 < pinheadmz> but if someone is rude and bot doesnt pick it up thats something i need to adjust
07:30 < pinheadmz> it usually thinks "crack <hash>" is some kind of threat :-P
07:30 < sipa> vasild: i think the comments are marked off-topic on github due to the author having received a temporary ban, not because the ai bot thought they were offtopic
07:30 < pinheadmz> s/ crACK
07:31 < glozow> #endmeeting
07:32 < vasild> so if somebody gets a temp ban all his comments on all issues and prs are marked off-topic? That seems a bit too aggressive?
07:32 < pinheadmz> sipa vasild hm actually that does look like a partial misake
07:32 < pinheadmz> there is an option in the ban dialog to hide all the authors comments (if its a massive spammer) but i didnt check that box for this guy
07:32 < sipa> ah
07:32 < pinheadmz> although a lot of comments on that thread are off topic ...
07:33 < kanzure> can you give a summary of when a 24 hour ban in this project has actually been helpful?
07:33 < kanzure> why not just actual bans
07:33 < pinheadmz> so this might actually be a bug with github because this is not expected
07:33 < pinheadmz> kanzure the policy dictates temporary bans to "cool off"
07:34 < kanzure> also, i don't think that arguing is productive in /meta - i think it is more important to say what you are going to do, then do it.
07:34 < pinheadmz> with increasing duration. 1 day then 2, then 4 etc
07:34 < pinheadmz> i dont think we want permananet bans, someone might be a jerk today but have a real issue next week
07:34 < kanzure> i have already registered my criticism of having a policy-- just ban who you need to ban.
07:34 < pinheadmz> re: arguing in meta... could you elaborate?
07:35 < kanzure> sorry but that's not how anonymous contributions work! identity is costless.
07:35 < kanzure> if they have a real issue next week then they can report it anyway regardless of their ban
07:35 < pinheadmz> with a diferent account you mean ?
07:37 < vasild> I just read all comments on https://github.com/bitcoin/bitcoin/issues/29759 from kosuodhmwa. All of them are on-topic. Can they be fixed? (remove marked as off-topic)
07:37 < pinheadmz> vasild fuck well. actually i need a maintainer to un-hide fanquake sorry
07:40 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
07:44 < pinheadmz> vasild https://gist.github.com/pinheadmz/f80244acfc23d1792efa11fb835a0cc5
07:44 < pinheadmz> this is the checkbox in question
07:59 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
08:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
08:07 -!- marcofleon [~marcofleo@181.214.131.162] has quit [Quit: Connection closed]
08:08 -!- dzxzg [~bezel@2600:380:4969:e676:c4e7:ee73:73cc:d726] has quit [Ping timeout: 245 seconds]
08:14 < jonatack> pinheadmz: kudos for doing a tough job very well afaict
08:26 < bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ebd82fa9fae1...9774a958b501
08:26 < bitcoin-git> bitcoin/master 31b3301 Hennadii Stepanov: qt: Pull recent translations from Transifex
08:26 < bitcoin-git> bitcoin/master e49d858 Hennadii Stepanov: qt: Bump Transifex slug for 28.x
08:26 < bitcoin-git> bitcoin/master be41967 Hennadii Stepanov: qt: Update translation source file
08:26 < bitcoin-git> [bitcoin] hebasto merged pull request #30548: release: Update translations for v28.0 soft translation string freeze (master...240730-translations) https://github.com/bitcoin/bitcoin/pull/30548
08:27 < instagibbs> b10c something I've noticed for a while is my non-listening node seems to have much higher % round-trips for compact blocks vs my listening node. I havent thought deeply about this but wondering how expected this is
08:28 < instagibbs> 65% 0.5RTT completion(non-listening) vs 92% on my listening node
08:29 -!- Olsen [~Olsen@2804:431:c7ca:1df4:8404:7eef:79a7:7712] has quit [Quit: Client closed]
08:40 -!- pablomartin [~pablomart@188.241.144.181] has quit [Ping timeout: 248 seconds]
09:03 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
09:06 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
09:06 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:14 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
09:15 -!- zzzzz [~dooby1@gateway/tor-sasl/zzzzz] has quit [Ping timeout: 260 seconds]
09:15 -!- cman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
09:16 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Ping timeout: 252 seconds]
09:19 -!- pablomartin [~pablomart@188.241.144.173] has joined #bitcoin-core-dev
09:19 -!- cman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Remote host closed the connection]
09:20 -!- cman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
09:29 < bitcoin-git> [gui-qml] hebasto pushed 5 commits to main: https://github.com/bitcoin-core/gui-qml/compare/c065a17375e6...a73577b7b79d
09:29 < bitcoin-git> gui-qml/main 4f11e01 johnny9: qml: Add color properties to ContinueButton
09:29 < bitcoin-git> gui-qml/main 931d442 johnny9: qml: Add DISABLED state to ContinueButton
09:29 < bitcoin-git> gui-qml/main 0266742 johnny9: qml: Introduce AddWallet page after onboarding
09:29 < bitcoin-git> [gui-qml] hebasto merged pull request #403: Introduce Create Single-Sig wallet flow (main...create-wallet-pr) https://github.com/bitcoin-core/gui-qml/pull/403
09:31 -!- zzzzz_ [~dooby1@gateway/tor-sasl/zzzzz] has joined #bitcoin-core-dev
09:48 -!- pablomartin4btc [~pablomart@2a02:6b67:d691:a900:3dd:d8b:1958:74f1] has joined #bitcoin-core-dev
09:51 -!- pablomartin [~pablomart@188.241.144.173] has quit [Ping timeout: 252 seconds]
10:01 < bitcoin-git> [bitcoin] mzumsande opened pull request #30568: addrman: change counter to uint64_t (master...202408_addrman_int) https://github.com/bitcoin/bitcoin/pull/30568
10:06 -!- pablomartin4btc_ [~pablomart@185.158.242.149] has joined #bitcoin-core-dev
10:09 -!- pablomartin4btc [~pablomart@2a02:6b67:d691:a900:3dd:d8b:1958:74f1] has quit [Ping timeout: 260 seconds]
10:13 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
10:17 -!- kashifs [~kashifs@2603:7000:4600:500:d0e2:4306:4b03:4d2e] has quit [Quit: Client closed]
10:33 < gmaxwell> instagibbs: I'm 85% sure it's because your listening node gets mass connected by someone who is forwarding transactions that a stock core node wouldn't.
10:34 < gmaxwell> instagibbs: either just running fullrbf on, or doing some kind agressive forwarding.
10:36 < sipa> rejected transactions make it into the reconstruction cache, right? so even being fed transactions you reject may suffice with improving reconstruction
10:36 < gmaxwell> sipa: it does, but there are so many now that the default extrapool is way too small.
10:37 < sipa> right, it'd need to be done aggressively to avoid being cycled out before the block is found
10:37 < gmaxwell> In tests I got people to perform I had them enable fullrbf OR massively increase the extrapool size.  Both improved reconstruction rates (though fullrbf appears to do a little better) but only on listening nodes,  outbound only continued to have miserable reconstruction rates-- which is I presume because no one ever forwarded them the required txn.
10:43 < gmaxwell> also the number of missed txn is pretty extreme, for blocks that have any misses on an outbound only node the average number missed is currently 97 txn over the last 288 blocks.
10:44 < gmaxwell> which I think would be somewhat difficult to fix via improved block relay protocols.
11:02 < instagibbs> interesting
11:02 -!- Talkless [~Talkless@78.56.155.237] has joined #bitcoin-core-dev
11:02 -!- pablomartin4btc_ [~pablomart@185.158.242.149] has quit [Ping timeout: 245 seconds]
11:02 < instagibbs> and yes distribution of misses for me is like 0, 1, or MANY
11:22 -!- Talkless [~Talkless@78.56.155.237] has quit [Ping timeout: 260 seconds]
11:41 -!- pablomartin4btc_ [~pablomart@185.158.242.146] has joined #bitcoin-core-dev
11:41 < gmaxwell> I suspect that if you took an inbound node and made an effort to block all mass connectors the reconstruction rate would drop again.
11:58 -!- pablomartin4btc_ [~pablomart@185.158.242.146] has quit [Ping timeout: 252 seconds]
11:59 < bitcoin-git> [bitcoin] stickies-v opened pull request #30569: node: reduce unsafe uint256S usage (master...2024-08/hex-arg-parse) https://github.com/bitcoin/bitcoin/pull/30569
12:40 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
13:15 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:47 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:48 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
13:59 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
14:09 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
14:09 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
14:27 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.3.5]
14:30 -!- cman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!]
14:31 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
14:51 -!- Guest84 [~Guest84@ppp-223-24-157-126.revip6.asianet.co.th] has joined #bitcoin-core-dev
14:52 -!- Guest96 [~Guest96@c-73-148-103-201.hsd1.va.comcast.net] has joined #bitcoin-core-dev
14:53 -!- Guest96 [~Guest96@c-73-148-103-201.hsd1.va.comcast.net] has quit [Client Quit]
14:56 -!- Guest84 [~Guest84@ppp-223-24-157-126.revip6.asianet.co.th] has quit [Quit: Client closed]
15:13 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
16:01 < bitcoin-git> [bitcoincore.org] joetor5 closed pull request #1038: Fix default twitter/og meta tag image (fixes #1037) (master...fix-1037) https://github.com/bitcoin-core/bitcoincore.org/pull/1038
16:16 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Ping timeout: 244 seconds]
16:16 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Remote host closed the connection]
16:21 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 252 seconds]
16:34 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
16:42 < bitcoin-git> [bitcoin] kevkevinpal opened pull request #30570: [tests] New fuzz target wallet_rpc (master...fuzzwalletrpc) https://github.com/bitcoin/bitcoin/pull/30570
17:06 -!- pablomartin4btc_ [~pablomart@185.158.242.144] has joined #bitcoin-core-dev
17:12 -!- pablomartin4btc_ is now known as pablomartin4btc
17:13 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
17:13 -!- aleggg [~aleggg@179.176.71.100.dynamic.adsl.gvt.net.br] has quit [Remote host closed the connection]
17:28 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev
17:41 -!- flag [~flag@81.56.89.175] has quit [Ping timeout: 245 seconds]
17:43 -!- flag [~flag@81.56.89.175] has joined #bitcoin-core-dev
18:01 -!- pablomartin4btc [~pablomart@185.158.242.144] has quit [Ping timeout: 245 seconds]
18:09 -!- aleggg [~aleggg@179.176.71.100.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
18:24 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev
18:27 -!- S3RK_ [~S3RK@user/s3rk] has quit [Ping timeout: 248 seconds]
19:05 < _aj_> instagibbs: tx relay to non-listening nodes takes a few seconds longer than tx relay to listening nodes, so blocks that happen to include very recently broadcast txs would automatically do that, i think? the handful of recent blocks with 1000s of txns requested on my node look like they were mostly very-recently broadcast txs according to mempool.space too...
19:08 < bitcoin-git> [bitcoincore.org] dependabot[bot] opened pull request #1053: build(deps-dev): bump rexml from 3.3.1 to 3.3.3 (master...dependabot/bundler/rexml-3.3.3) https://github.com/bitcoin-core/bitcoincore.org/pull/1053
19:10 < gmaxwell> 1000s of tx being broadcast in a few seconds doesn't sound right!
19:11 < gmaxwell> I would bet that thats an artifact of the site learning about the txn from the block.
19:12 < gmaxwell> and those thousand txn are some stupid thing where the miner is not broadcasting txn first intentionally.
19:14 < _aj_> https://mempool.space/block/00000000000000000001f634db90c9a511cde302db8f77374071187d4731f426 is one example; lots of the txs seem to be ~1m or ~2m prior to the block per mempool.space 
19:14 < gmaxwell> (because of some scamcoin seigniorage thing where the transting party doesn't want anyone frontrunning their transaction)
19:14 < gmaxwell> 1m or 2m isn't consistent with your theory though either.
19:14 < gmaxwell> Possible one of those timestamps is the block timestamp and the other is just when th block arrived?
19:15 < gmaxwell> anyways, gimme a txid an I can see if a node with oddles of connections got the txn before the block?
19:16 < _aj_> for a non-listening node, onyl having 8 connections might limit how many txs get relayed in 120s?
19:17 < _aj_> 1c1cad15e3891aa83c7f3de85bf163994558480d6fe1afff6738636cdb61571f maybe ? mempool.space claims that as after-1-minute
19:17 < gmaxwell> that's why I suggest looking to see if anyone got it ahead of the block.
19:18 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
19:19 < gmaxwell> _aj_: so I had two people check, one on a node with ~40 inbounds, and one on a node with ~250 inbounds and net logging enabled,  neither ever saw that txid as a loose transaction.
19:19 < gmaxwell> (or had it INVed to them)
19:20 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
19:20 -!- jarthur_ [~jarthur@user/jarthur] has quit [Client Quit]
19:21 < _aj_> (the 40 inbound had mempool logging? or something else?)
19:21 < gmaxwell> net logging
19:22 < gmaxwell> (both have net logging)
19:22 < _aj_> oh!
19:22 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 276 seconds]
19:22 < gmaxwell> I'm trying to get a third check too.
19:25 -!- mcey_ [~emcy@148.252.147.230] has joined #bitcoin-core-dev
19:26 < _aj_> hmm, my non-listening node saw ~2500 new invs in the 2mins around that block; so ~21/s or ~2.6/peer/s
19:26 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
19:29 -!- emcy__ [~emcy@148.252.144.208] has quit [Ping timeout: 260 seconds]
19:29 < _aj_> (oh, 2.3/peer/s, i have 9 tx peers duh)
19:30 < gmaxwell> Seems high. it's a little hard to reason about though because the relay logic is quasi-feerate sorted, so the higher fee txn which would immediately get included tend to be relayed faster.  But if the txn aren't showing up at all then, well, that's a moot consideration.
19:38 < _aj_> ah, quasi-feerate, good point. that 1c1cad tx had a decent ancestor chain within that block
19:39 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Remote host closed the connection]
19:40 < _aj_> (it was 15th if i counted right)
19:42 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
19:44 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
19:44 < gmaxwell> ah that would slow its relay for sure.
19:55 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
20:00 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 276 seconds]
21:00 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:02 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
21:03 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
21:30 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has joined #bitcoin-core-dev
21:34 -!- kevkevin [~kevkevin@2601:243:197e:8f10:d108:7c7d:1004:b0f4] has quit [Ping timeout: 245 seconds]
21:50 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
22:01 -!- emcy__ [~emcy@148.252.147.230] has joined #bitcoin-core-dev
22:03 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
22:04 -!- mcey_ [~emcy@148.252.147.230] has quit [Ping timeout: 260 seconds]
22:05 -!- Netsplit *.net <-> *.split quits: dermoth, real_or_random, jonasschnelli, hugohn____, kinlo, mullick, jqq_, kanzure, sr_gi[m]1, RubenSomsen,  (+8 more, use /NETSPLIT to show all of them)
22:06 -!- Netsplit over, joins: RubenSomsen, kanzure, hugohn____, BlueMatt[m], jonasschnelli, real_or_random, mullick, tdb3, dermoth, PatBoy (+8 more)
22:06 -!- Netsplit *.net <-> *.split quits: dongcarl, FelixWeis__, face, otoburb, larryruane_, cncr04s, katsu, hernanmarino, stratospher[m], stevenroose,  (+5 more, use /NETSPLIT to show all of them)
22:06 -!- emcy__ [~emcy@148.252.147.230] has quit [Remote host closed the connection]
22:07 -!- Netsplit over, joins: stickies-v, b10c, jarolrod___, FelixWeis__, katsu, stevenroose, otoburb, dongcarl, hernanmarino, bitcoin-git (+5 more)
22:07 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has quit [Max SendQ exceeded]
22:07 -!- emcy__ [~emcy@148.252.147.230] has joined #bitcoin-core-dev
22:07 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:07 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
22:09 -!- mekster66949398 [~mekster@user/mekster] has quit [Quit: Ping timeout (120 seconds)]
22:09 -!- mekster66949398 [~mekster@user/mekster] has joined #bitcoin-core-dev
22:27 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
22:31 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:36 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
--- Log closed Fri Aug 02 00:00:10 2024