--- Log opened Tue Aug 06 00:00:14 2024 00:41 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:41 -!- pigeons [~pigeons@user/pigeons] has quit [Ping timeout: 260 seconds] 01:30 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev 01:35 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 01:36 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 01:49 -!- Guest23 [~Guest23@vc-cpt-41-4-16-111.umts.vodacom.co.za] has joined #bitcoin-core-dev 01:50 -!- Guest23 [~Guest23@vc-cpt-41-4-16-111.umts.vodacom.co.za] has quit [Client Quit] 01:58 < bitcoin-git> [bitcoin] glozow opened pull request #30594: docs: update documentation for new mempoolfullrbf default (master...2024-07-fullrbf-docs) https://github.com/bitcoin/bitcoin/pull/30594 02:01 < glozow> instagibbs: re "Leaving as draft since there is plenty of other things people should be working on for 28.0 freeze." in #30592, are you suggesting not doing this in 28.0? 02:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/30592 | Remove mempoolfullrbf by instagibbs · Pull Request #30592 · bitcoin/bitcoin · GitHub 02:09 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 02:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 260 seconds] 02:14 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/949b67347255...d928f4c47ff9 02:14 < bitcoin-git> bitcoin/master 41797f8 fanquake: Squashed 'src/secp256k1/' changes from 4af241b320..642c885b61 02:14 < bitcoin-git> bitcoin/master 183e2fd fanquake: Update secp256k1 subtree to latest master 02:14 < bitcoin-git> bitcoin/master 9ec776a fanquake: Revert "build: pass --with-ecmult-gen-kb=86 to secp256k1" 02:14 < bitcoin-git> [bitcoin] fanquake merged pull request #30573: Update libsecp256k1 subtree to latest master (master...secp_0_5_1) https://github.com/bitcoin/bitcoin/pull/30573 02:18 < bitcoin-git> [bitcoin] TheCharlatan opened pull request #30595: kernel: Introduce initial C header API (master...kernelApi) https://github.com/bitcoin/bitcoin/pull/30595 02:18 -!- mickin [~quassel@212.129.83.119] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 02:20 < bitcoin-git> [bitcoin] josibake opened pull request #30596: fuzz: replace hardcoded numbers for bech32 limits (master...fix-leftover-hardcoded-bech32-limits) https://github.com/bitcoin/bitcoin/pull/30596 02:30 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d928f4c47ff9...43740f4971f4 02:30 < bitcoin-git> bitcoin/master a0a9a11 fanquake: depends: fix ZMQ CMake getcachesize check 02:30 < bitcoin-git> bitcoin/master 43740f4 merge-script: Merge bitcoin/bitcoin#30588: depends: fix ZMQ CMake getcachesize check 02:30 < bitcoin-git> [bitcoin] fanquake merged pull request #30588: depends: fix ZMQ CMake getcachesize check (master...zmq_s390x_missing_fixes) https://github.com/bitcoin/bitcoin/pull/30588 02:42 -!- akrmn [~pi@akusa.linkmark.xyz] has joined #bitcoin-core-dev 02:44 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:45 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 04:32 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Remote host closed the connection] 05:08 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 05:10 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 05:23 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 05:24 -!- BrandonOdiwuor [~BrandonOd@105.163.156.120] has quit [Quit: Client closed] 05:25 < instagibbs> glozow I don't think it's an important change to make for 28.0, personally? Maybe mark the option as deprecated for a cycle? 05:27 -!- flooded is now known as _flood 05:34 < glozow> instagibbs: I'm thinking that, if we came to the conclusion that mempoolfullrbf=0 is bad enough to change the default, then logically it's also bad enough to at least warn users that try to set it? 05:35 -!- pablomartin [~pablomart@91.196.223.150] has joined #bitcoin-core-dev 05:36 < glozow> If we think it'd be a footgun then we shouldn't provide it as an option imo? Or do we not think it's not that bad? 05:36 < instagibbs> yeah hence the deprecation warning? that make sense? 05:39 < glozow> warning sounds good 05:39 < sipa> glozow: ignoring whether or not the option makes sense, i think logistically it's wrong to remove an option without deprecation cycle... there may be software/packaging relying on even just the option existing 05:41 < instagibbs> not everything can be supported like this, but this has essentially 0 cost 05:50 < glozow> I think I'm just trying to say that the deprecation should start in 28.0 05:52 -!- Olsen [~Olsen@2804:431:c7ca:1df4:f9d2:8c75:dc4e:301] has joined #bitcoin-core-dev 06:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:15 < BlueMatt[m]> has anyone in bitcoin core land ever gotten driller or fuzzolic or some other concolic execution tool working? 06:17 < instagibbs> glozow yes, I agree. I don't know the process for deprecating a startup arg :) 06:18 < Murch[m]> gmaxwell: The coordinated switch in signaling sounds interesting, but I’m not sure a rolling update is that harmful. Especially for those that continue signaling after the update, everyone else switching at the same time might leave them sticking out even more 06:19 < Murch[m]> glozow, instagibbs: I think removing the option completely may dissuade some users from upgrading, it might be better to only update the default and deprecate this release 06:21 < Murch[m]> gmaxwell: If we are worried about full-rbf transactions propagating well by the time the opt-in signaling is turned off by default, maybe we should try to connect to at least one peer whose version is at least v28? 06:23 < instagibbs> I don't see the payoff in trying to solve wallet behavior switching now, and by the time it's decided I suspect propagation will be pretty trivial? 06:23 < instagibbs> I guess I'm saying, this is all post-28.0 talk in my mind 06:25 -!- Olsen [~Olsen@2804:431:c7ca:1df4:f9d2:8c75:dc4e:301] has quit [Quit: Client closed] 06:31 < sipa> Murch[m], gmaxwell: it looks (https://txstats.com/d/000000020/replace-by-fee) like close to or over a majority of transactions signal opt-in RBF; it seems like defaulting to on is a better shelling point than trying to default to off? 06:39 -!- emcy__ [~emcy@148.252.147.71] has joined #bitcoin-core-dev 06:42 -!- mcey_ [~emcy@148.252.128.239] has quit [Ping timeout: 252 seconds] 07:00 < dergoegge> BlueMatt: I've played around with symcc 07:00 < dergoegge> i think i also tried fuzzolic but don't remember if I actually got it working 07:01 < dergoegge> https://github.com/SoftSec-KAIST/Eclipser has also been used on core before 07:02 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/43740f4971f4...31a3ff55154b 07:02 < bitcoin-git> bitcoin/master 59c0ece josibake: fuzz: replace hardcoded numbers for bech32 limits 07:02 < bitcoin-git> bitcoin/master 31a3ff5 glozow: Merge bitcoin/bitcoin#30596: fuzz: replace hardcoded numbers for bech32 li... 07:02 < bitcoin-git> [bitcoin] glozow merged pull request #30596: fuzz: replace hardcoded numbers for bech32 limits (master...fix-leftover-hardcoded-bech32-limits) https://github.com/bitcoin/bitcoin/pull/30596 07:02 < dergoegge> Afaik we've never had big success with any of them in terms of new coverage or bugs found 07:03 < BlueMatt[m]> ah cool, hadn't come across symcc yet 07:03 < BlueMatt[m]> thanks 07:12 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 07:28 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 248 seconds] 07:47 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:47 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:48 -!- pigeons [~pigeons@user/pigeons] has joined #bitcoin-core-dev 07:49 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 07:51 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 07:51 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 07:52 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 07:53 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 08:15 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 08:17 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 08:24 < bitcoin-git> [bitcoin] hebasto opened pull request #30597: doc: Drop no longer needed workaround for WSL (master...240806-wsl-note) https://github.com/bitcoin/bitcoin/pull/30597 08:28 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev 08:31 < bitcoin-git> [bitcoin] ryanofsky pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31a3ff55154b...870447fd585e 08:31 < bitcoin-git> bitcoin/master 87b1880 willcl-ark: rpc: clarify ALREADY_IN_CHAIN rpc errors 08:31 < bitcoin-git> bitcoin/master e9de0a7 willcl-ark: doc: release note for 30212 08:31 < bitcoin-git> bitcoin/master 870447f Ryan Ofsky: Merge bitcoin/bitcoin#30212: rename TransactionError:ALREADY_IN_CHAIN 08:31 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30212: rename TransactionError:ALREADY_IN_CHAIN (master...clarify-missing-inputs-err) https://github.com/bitcoin/bitcoin/pull/30212 08:59 -!- pablomartin [~pablomart@91.196.223.150] has quit [Ping timeout: 248 seconds] 09:01 -!- pablomartin [~pablomart@91.196.223.148] has joined #bitcoin-core-dev 09:18 -!- pablomartin [~pablomart@91.196.223.148] has quit [Ping timeout: 264 seconds] 09:36 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:36 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:44 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/870447fd585e...d7333ece15b8 09:44 < bitcoin-git> bitcoin/master 37c9abd fanquake: build: remove check for __attribute__((visibility.. 09:44 < bitcoin-git> bitcoin/master bbcba09 fanquake: build: remove check for __declspec(dllexport) 09:44 < bitcoin-git> bitcoin/master d7333ec merge-script: Merge bitcoin/bitcoin#30590: build: Remove unused visibility checks 09:44 < bitcoin-git> [bitcoin] fanquake merged pull request #30590: build: Remove unused visibility checks (master...remove_unused_visibility) https://github.com/bitcoin/bitcoin/pull/30590 09:48 -!- pablomartin [~pablomart@91.196.223.148] has joined #bitcoin-core-dev 09:58 < gmaxwell> sipa: yeah I mentioned above that I thought it was a majority. The answer I have to that is that it's probably easier to get the ones who've turned it on to turn it off than it is to get the ones that still don't have it on to turn it on? 10:09 < sipa> gmaxwell: hmm, good question 10:11 -!- pablomartin [~pablomart@91.196.223.148] has quit [Ping timeout: 264 seconds] 10:13 -!- qxs_ [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev 10:15 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 260 seconds] 10:29 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 10:29 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:33 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 10:35 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:50 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 276 seconds] 11:55 -!- noonien808310429 [~noonien@86.125.147.232] has joined #bitcoin-core-dev 11:56 -!- halff [~stormhalf@189.28.196.187] has joined #bitcoin-core-dev 12:02 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 12:06 -!- halff [~stormhalf@user/halff] has changed host 12:07 < halff> chat p2p? 12:18 -!- Guest61 [~Guest61@24.232.97.69] has joined #bitcoin-core-dev 12:22 -!- Guest61 [~Guest61@24.232.97.69] has quit [Client Quit] 12:41 < bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7333ece15b8...bb25e0691f65 12:41 < bitcoin-git> bitcoin/master fa18fc7 MarcoFalke: log: Remove NOLINT(bitcoin-unterminated-logprintf) 12:41 < bitcoin-git> bitcoin/master bb25e06 Ryan Ofsky: Merge bitcoin/bitcoin#30485: log: Remove NOLINT(bitcoin-unterminated-logpr... 12:41 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30485: log: Remove NOLINT(bitcoin-unterminated-logprintf) (master...2407-log-lint) https://github.com/bitcoin/bitcoin/pull/30485 13:00 < Murch[m]> sipa: Everyone settling on not signaling for a previously enforced optional feature seems a bit cleaner than everyone settling on signaling for a no-longer enforced feature. 13:06 -!- halff [~stormhalf@user/halff] has quit [Quit: Leaving] 13:07 < sipa> Murch[m]: agreed there 13:08 < gmaxwell> +1 13:26 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 265 seconds] 13:29 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev 13:35 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds] 13:42 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 14:08 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev 14:10 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit] 14:15 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 14:34 -!- Wh4xk69_1 [~Wh4xk69@2804:d55:4382:3e00:618d:cfc9:3547:e06d] has joined #bitcoin-core-dev 14:38 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.3.5] 14:55 -!- Wh4xk69_1 [~Wh4xk69@2804:d55:4382:3e00:618d:cfc9:3547:e06d] has quit [Quit: Leaving] 15:06 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 15:08 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 15:25 -!- jon_atack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 15:27 < bitcoin-git> [bitcoin] fjahr opened pull request #30598: assumeutxo: Drop block height from metadata (master...2024-08-au-drop-height) https://github.com/bitcoin/bitcoin/pull/30598 15:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 15:28 -!- RaphaelH [~RaphaelH@user/RaphaelH] has joined #bitcoin-core-dev 16:53 -!- noonien808310429 [~noonien@86.125.147.232] has quit [Quit: Ping timeout (120 seconds)] 16:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:54 -!- noonien808310429 [~noonien@86.125.147.232] has joined #bitcoin-core-dev 16:55 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 16:58 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 17:03 -!- infernix [nix@spirit.infernix.net] has quit [Ping timeout: 252 seconds] 17:11 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb25e0691f65...ce1c881ccc8f 17:11 < bitcoin-git> bitcoin/master 6714276 brunoerg: miniscript: Use `ToIntegral` instead of `ParseInt64` 17:11 < bitcoin-git> bitcoin/master ce1c881 Ava Chow: Merge bitcoin/bitcoin#30577: miniscript: Use `ToIntegral` instead of `Pars... 17:11 < bitcoin-git> [bitcoin] achow101 merged pull request #30577: miniscript: Use `ToIntegral` instead of `ParseInt64` (master...2024-07-miniscript-tointegral) https://github.com/bitcoin/bitcoin/pull/30577 17:39 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 17:39 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 18:02 -!- infernix [nix@spirit.infernix.net] has joined #bitcoin-core-dev 18:08 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 18:09 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 18:22 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 18:41 -!- pablomartin [~pablomart@91.196.223.150] has joined #bitcoin-core-dev 18:42 -!- pablomartin [~pablomart@91.196.223.150] has quit [Client Quit] 18:43 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 252 seconds] 19:10 < bitcoin-git> [bitcoin] ryanofsky pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/ce1c881ccc8f...b38fb19b7eed 19:10 < bitcoin-git> bitcoin/master f14900b josibake: bench: add benchmark for signing with a taptweak 19:10 < bitcoin-git> bitcoin/master 5d507a0 josibake: tests: add key tweak smoke test 19:10 < bitcoin-git> bitcoin/master c39fd39 josibake: crypto: add KeyPair wrapper class 19:10 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30051: crypto, refactor: add new KeyPair class (master...add-apply-taptweak-method) https://github.com/bitcoin/bitcoin/pull/30051 19:35 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 19:56 -!- RaphaelH [~RaphaelH@user/RaphaelH] has quit [Quit: Client closed] 20:40 -!- mcey_ [~emcy@148.252.128.134] has joined #bitcoin-core-dev 20:43 -!- emcy__ [~emcy@148.252.147.71] has quit [Ping timeout: 260 seconds] 20:48 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 20:52 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 20:52 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 22:01 -!- mcey_ [~emcy@148.252.128.134] has quit [Remote host closed the connection] 22:01 -!- mcey_ [~emcy@148.252.128.134] has joined #bitcoin-core-dev 22:27 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b38fb19b7eed...2987ba663758 22:27 < bitcoin-git> bitcoin/master 6e7e620 ismaelsadeeq: [doc]: add `30275` release notes 22:27 < bitcoin-git> bitcoin/master fa2f269 ismaelsadeeq: [rpc, fees]: add more detail on the fee estimation modes 22:27 < bitcoin-git> bitcoin/master 2987ba6 Ava Chow: Merge bitcoin/bitcoin#30525: doc, rpc : `#30275` followups 22:27 < bitcoin-git> [bitcoin] achow101 merged pull request #30525: doc, rpc : `#30275` followups (master...07-2024-estimatesmartfee-doc-update) https://github.com/bitcoin/bitcoin/pull/30525 22:55 -!- BrandonOdiwuor [~BrandonOd@105.163.156.120] has joined #bitcoin-core-dev 23:08 -!- PatBoy [xyz@cryption.cn] has joined #bitcoin-core-dev 23:08 -!- P8tBoy [xyz@cryption.cn] has quit [Ping timeout: 248 seconds] --- Log closed Wed Aug 07 00:00:15 2024