--- Log opened Wed Aug 28 00:00:26 2024
--- Day changed Wed Aug 28 2024
00:00 -!- noonien808310429 [~noonien@86.125.147.232] has quit [Ping timeout: 255 seconds]
00:05 -!- noonien808310429 [~noonien@86.125.147.232] has joined #bitcoin-core-dev
00:15 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
00:18 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
00:19 -!- instagibbs4 [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has joined #bitcoin-core-dev
00:20 -!- emcy__ [~emcy@148.252.128.43] has joined #bitcoin-core-dev
00:21 -!- cncr04s_ [~cncr04s@ns1.afxr.net] has joined #bitcoin-core-dev
00:21 -!- TheRec [~toto@user/therec] has quit [Ping timeout: 246 seconds]
00:21 -!- cncr04s [cnc@afxr.net] has quit [Ping timeout: 246 seconds]
00:21 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
00:21 -!- harding [quassel@newmail.dtrt.org] has quit [Quit: No Ping reply in 180 seconds.]
00:21 -!- mcey_ [~emcy@148.252.128.43] has quit [Ping timeout: 246 seconds]
00:21 -!- pigeons [~pigeons@user/pigeons] has quit [Ping timeout: 246 seconds]
00:21 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 246 seconds]
00:21 -!- instagibbs4 is now known as instagibbs
00:21 -!- pigeons_ [~pigeons@d23-16-131-51.bchsia.telus.net] has joined #bitcoin-core-dev
00:21 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:22 -!- harding [quassel@newmail.dtrt.org] has joined #bitcoin-core-dev
01:10 -!- Guest37 [~Guest37@201.red-79-151-83.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
01:11 -!- Guest37 [~Guest37@201.red-79-151-83.dynamicip.rima-tde.net] has quit [Write error: Broken pipe]
01:11 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c7a4231db35...f4a10911c70e
01:42 < bitcoin-git> bitcoin/master 49f9b64 Hodlinator: refactor: Testnet4 - Replace uint256S("str") -> uint256{"str"}
01:42 < bitcoin-git> bitcoin/master f4a1091 merge-script: Merge bitcoin/bitcoin#30721: refactor: Testnet4 - Replace uint256S("str") ...
01:42 < bitcoin-git> [bitcoin] fanquake merged pull request #30721: refactor: Testnet4 - Replace uint256S("str") - uint256{"str"} (master...2024-08/uint256_testnet4_scripted_diff) https://github.com/bitcoin/bitcoin/pull/30721
01:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4a10911c70e...128ade02e445
01:42 < bitcoin-git> bitcoin/master 8dec4e1 brunoerg: fuzz: fix timeout in `crypto_fschacha20poly1305`
01:42 < bitcoin-git> bitcoin/master 128ade0 merge-script: Merge bitcoin/bitcoin#30725: fuzz: fix timeout in `crypto_fschacha20poly13...
01:42 < bitcoin-git> [bitcoin] fanquake merged pull request #30725: fuzz: fix timeout in `crypto_fschacha20poly1305` (master...2024-08-fix-timeout-cryptochacha) https://github.com/bitcoin/bitcoin/pull/30725
02:27 < bitcoin-git> [bitcoin-detached-sigs] fanquake pushed 1 commit to 28.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/commit/c717a70a90ba
02:27 < bitcoin-git> bitcoin-detached-sigs/28.x c717a70 fanquake: 28.x: macOS sig for rc1
02:34 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/128ade02e445...80f00cafdeef
02:34 < bitcoin-git> bitcoin/master fadf0a7 MarcoFalke: refactor: Remove Span operator==, Use std::ranges::equal
02:34 < bitcoin-git> bitcoin/master fad0cf6 MarcoFalke: refactor: Use std::ranges::equal in GetNetworkForMagic
02:34 < bitcoin-git> bitcoin/master 80f00ca merge-script: Merge bitcoin/bitcoin#29071: refactor: Remove Span operator==, Use std::ra...
02:34 < bitcoin-git> [bitcoin] fanquake merged pull request #29071: refactor: Remove Span operator==, Use std::ranges::equal (master...2312-less-span-) https://github.com/bitcoin/bitcoin/pull/29071
02:35 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to 26.x: https://github.com/bitcoin/bitcoin/compare/7b7041019ba5...0a2a5c4ba62e
02:35 < bitcoin-git> bitcoin/26.x 7d5764f fanquake: doc: update release notes for 26.x
02:35 < bitcoin-git> bitcoin/26.x 0a2a5c4 merge-script: Merge bitcoin/bitcoin#30722: [26.x] Fix compilation with GCC 15
02:35 < bitcoin-git> [bitcoin] fanquake merged pull request #30722: [26.x] Fix compilation with GCC 15 (26.x...26_fix_gcc15) https://github.com/bitcoin/bitcoin/pull/30722
02:51 < bitcoin-git> [bitcoin] fanquake pushed 69 commits to master: https://github.com/bitcoin/bitcoin/compare/80f00cafdeef...338bc2cd261b
02:51 < bitcoin-git> bitcoin/master a2317e2 Hennadii Stepanov: cmake: Add root `CMakeLists.txt` file
02:51 < bitcoin-git> bitcoin/master 7068388 Hennadii Stepanov: cmake: Introduce interface libraries to encapsulate common flags
02:51 < bitcoin-git> bitcoin/master fe5cdac Hennadii Stepanov: cmake: Print compiler and linker flags in summary
02:51 < bitcoin-git> [bitcoin] fanquake merged pull request #30454: build: Introduce CMake-based build system (master...240716-cmake) https://github.com/bitcoin/bitcoin/pull/30454
02:59 -!- Guest2 [~Guest2@36.89.217.148] has joined #bitcoin-core-dev
02:59 -!- Guest2 [~Guest2@36.89.217.148] has quit [Client Quit]
03:00 < vasild> CMake \o/ -- T H A N K  Y O U -- everybody and hebasto!
03:08 < glozow> 🎉
03:09 < bitcoin-git> [bitcoin] fanquake opened pull request #30729: build: fix version number post CMake (master...fix_version_number) https://github.com/bitcoin/bitcoin/pull/30729
03:14 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/338bc2cd261b...e45913ea8b06
03:14 < bitcoin-git> bitcoin/master fa0e1e4 MarcoFalke: fuzz: Add missing fuzz targets to cmake build
03:14 < bitcoin-git> bitcoin/master e45913e merge-script: Merge bitcoin/bitcoin#30712: fuzz: Add missing fuzz targets to cmake build
03:14 < bitcoin-git> [bitcoin] fanquake merged pull request #30712: fuzz: Add missing fuzz targets to cmake build (master...2408-fuzz-cmake) https://github.com/bitcoin/bitcoin/pull/30712
03:14 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45913ea8b06...92c787f33de1
03:14 < bitcoin-git> bitcoin/master 680f05e fanquake: build: fix version number post CMake
03:14 < bitcoin-git> bitcoin/master 92c787f merge-script: Merge bitcoin/bitcoin#30729: build: fix version number post CMake
03:14 < bitcoin-git> [bitcoin] fanquake merged pull request #30729: build: fix version number post CMake (master...fix_version_number) https://github.com/bitcoin/bitcoin/pull/30729
03:25 < laanwj> nice !!!
03:27 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
03:29 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
03:41 < hebasto> Thanks to all reviewers!
03:49 < bitcoin-git> [bitcoin] hebasto closed pull request #30465: depends: Set `CMAKE_SYSTEM_VERSION` for CMake builds (master...240716-deps-cmake) https://github.com/bitcoin/bitcoin/pull/30465
03:50 < bitcoin-git> [bitcoin] hebasto closed pull request #30477: depends: Amend handling flags environment variables (master...240718-deps-env) https://github.com/bitcoin/bitcoin/pull/30477
03:50 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
03:55 < bitcoin-git> [bitcoin] fanquake opened pull request #30730: guix: Bump time machine to 53396a22afc04536ddf75d8f82ad2eafa5082725 (master...bump_time_machine_gcc_12_4_0) https://github.com/bitcoin/bitcoin/pull/30730
04:04 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has quit [Ping timeout: 264 seconds]
04:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
04:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
04:12 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has joined #bitcoin-core-dev
04:16 < bitcoin-git> [bitcoin] fanquake opened pull request #30731: build: remove old MSVC build system (master...drop_msvc_old) https://github.com/bitcoin/bitcoin/pull/30731
04:18 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/92c787f33de1...2eb358b25f62
04:18 < bitcoin-git> bitcoin/master 371910a Hennadii Stepanov: depends: Fix CMake-generated `libzmq.pc` file
04:18 < bitcoin-git> bitcoin/master 2eb358b merge-script: Merge bitcoin/bitcoin#30508: depends: Fix CMake-generated `libzmq.pc` file
04:18 < bitcoin-git> [bitcoin] fanquake merged pull request #30508: depends: Fix CMake-generated `libzmq.pc` file (master...240723-zmq-pc) https://github.com/bitcoin/bitcoin/pull/30508
04:40 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
04:59 -!- emcy__ [~emcy@148.252.128.43] has quit [Remote host closed the connection]
05:01 -!- mcey [~emcy@148.252.128.43] has joined #bitcoin-core-dev
05:30 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2eb358b25f62...0c90fc644395
05:30 < bitcoin-git> bitcoin/master 04fb085 fanquake: build: remove old MSVC build system
05:30 < bitcoin-git> bitcoin/master 0c90fc6 merge-script: Merge bitcoin/bitcoin#30731: build: remove old MSVC build system
05:30 < bitcoin-git> [bitcoin] fanquake merged pull request #30731: build: remove old MSVC build system (master...drop_msvc_old) https://github.com/bitcoin/bitcoin/pull/30731
05:32 < glozow> Everything tagged with "Needs CMake port" should be rebased now, right?
05:39 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
05:41 < TheCharlatan> rebasing might be a good idea anyway so reviewers don't have to switch tooling.
05:43 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
05:45 -!- bw_______ [sid2730@id-2730.ilkley.irccloud.com] has left #bitcoin-core-dev []
06:00 -!- angusp [9e8eed9774@2a03:6000:1812:100::1048] has quit [Remote host closed the connection]
06:01 -!- angusp [9e8eed9774@2a03:6000:1812:100::1048] has joined #bitcoin-core-dev
06:01 < vasild> this ^
06:06 < bitcoin-git> [bitcoin] l0rinc opened pull request #30732: cmake: Improve cxx and linker flag caching (master...l0rinc/hash-collisions) https://github.com/bitcoin/bitcoin/pull/30732
06:06 < instagibbs> what's the cmake equiv of --enable-debug :)
06:06 < hebasto> -DCMAKE_BUILD_TYPE=Debug
06:06 < glozow> Should I leave my Makefile.am changes in my PRs until autotools is removed, or take them out now?
06:08 < hebasto> while rebasing, switching to new tools is reasonable
06:08 < instagibbs> hebasto I think that's missing from dev docs, figured out everything else so far...
06:09 < hebasto> docs are subjects for amending
06:09 < hebasto> PRs will be opened shortly
06:10 < vasild> instagibbs: https://gist.github.com/hebasto/2ef97d3a726bfce08ded9df07f7dab5e (the party table)
06:11 < instagibbs> oh nice party
06:11 < vasild> ;-)
06:11 < bitcoin-git> [bitcoin] l0rinc opened pull request #30733: Remove unused src_dir param from run_tests (master...l0rinc/test-runner-param-cleanup) https://github.com/bitcoin/bitcoin/pull/30733
06:11 < hebasto> thanks vasild 
06:14 < bitcoin-git> [bitcoin] l0rinc opened pull request #30734: Fix a few likely documentation typos (master...l0rinc/log-typo) https://github.com/bitcoin/bitcoin/pull/30734
06:19 < bitcoin-git> [bitcoin] maflcko closed pull request #30732: cmake: improve cxx and linker flag caching (master...l0rinc/hash-collisions) https://github.com/bitcoin/bitcoin/pull/30732
06:19 < bitcoin-git> [bitcoin] maflcko reopened pull request #30732: cmake: improve cxx and linker flag caching (master...l0rinc/hash-collisions) https://github.com/bitcoin/bitcoin/pull/30732
06:23 < bitcoin-git> [bitcoin] maflcko opened pull request #30735:  cmake: Add option to use C++23 for testing  (master...2408-23) https://github.com/bitcoin/bitcoin/pull/30735
06:40 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:44 < bitcoin-git> [bitcoin] hodlinator opened pull request #30737: test: Fix RANDOM_CTX_SEED use with parallel tests (master...2024-08/RANDOM_CTX_SEED_jobs_fix_alt) https://github.com/bitcoin/bitcoin/pull/30737
06:50 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] fanquake opened pull request #30738: doc: fixup macOS build docs for CMake (master...macos_cmake_docs) https://github.com/bitcoin/bitcoin/pull/30738
07:01 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:12 -!- Guest22 [~Guest22@102.91.93.229] has joined #bitcoin-core-dev
07:13 -!- Guest22 [~Guest22@102.91.93.229] has quit [Client Quit]
07:17 < bitcoin-git> [bitcoin] fanquake opened pull request #30739: doc: update dev note examples for CMake (master...dev_notes_cmake) https://github.com/bitcoin/bitcoin/pull/30739
07:22 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c90fc644395...f175a737c9e1
07:22 < bitcoin-git> bitcoin/master 3c53e59 fanquake: doc: fixup macOS build docs for CMake
07:22 < bitcoin-git> bitcoin/master f175a73 glozow: Merge bitcoin/bitcoin#30738: doc: fixup macOS build docs for CMake
07:22 < bitcoin-git> [bitcoin] glozow merged pull request #30738: doc: fixup macOS build docs for CMake (master...macos_cmake_docs) https://github.com/bitcoin/bitcoin/pull/30738
07:42 < achow101> darhtbot is busy today
07:47 < bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 28.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/c717a70a90ba...58e8aa11919d
07:47 < bitcoin-git> bitcoin-detached-sigs/28.x 58e8aa1 Ava Chow: 28.0: win sig for rc1
07:49 < bitcoin-git> [bitcoin-detached-sigs] achow101 pushed tag v28.0rc1: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/v28.0rc1
07:52 < bitcoin-git> [crc32c-subtree] fanquake opened pull request #8: Sync to upstream (bitcoin-fork...sync_to_upstream) https://github.com/bitcoin-core/crc32c-subtree/pull/8
07:52 < bitcoin-git> [bitcoin] maflcko opened pull request #30740: ci: Re-add configs removed in cmake migration (master...2408-ci-cmake) https://github.com/bitcoin/bitcoin/pull/30740
07:54 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
07:57 < bitcoin-git> [bitcoin] glozow pushed 15 commits to master: https://github.com/bitcoin/bitcoin/compare/f175a737c9e1...f93d5553d1e8
07:57 < bitcoin-git> bitcoin/master 7e86541 Ava Chow: descriptors: Add PubkeyProvider::Clone
07:57 < bitcoin-git> bitcoin/master 0d55dea Ava Chow: descriptors: Add DescriptorImpl::Clone
07:57 < bitcoin-git> bitcoin/master a5f39b1 Ava Chow: descriptors: Change ParseScript to return vector of descriptors
07:57 < bitcoin-git> [bitcoin] glozow merged pull request #22838: descriptors: Be able to specify change and receiving in a single descriptor string (master...multipath-descs) https://github.com/bitcoin/bitcoin/pull/22838
08:05 < bitcoin-git> [bitcoin] l0rinc opened pull request #30741: Update documentation generation example in developer-notes.md (master...lorinc/build-documentation) https://github.com/bitcoin/bitcoin/pull/30741
08:10 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:19 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 260 seconds]
08:25 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
08:37 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
08:39 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
08:39 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
08:51 < sipa> i go offline for a few days, and we switch build systems?!
08:51 < sipa> i should do this more oftrn
08:56 < bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/f93d5553d1e8...d184fc3ba411
08:56 < bitcoin-git> bitcoin/master fae7e37 MarcoFalke: test: Correct the random seed log on a prevector test failure
08:56 < bitcoin-git> bitcoin/master fa2cb65 MarcoFalke: test: Add m_rng alias for the global random context
08:56 < bitcoin-git> bitcoin/master fab023e MarcoFalke: test: refactor: Make unsigned promotion explicit
08:56 < bitcoin-git> [bitcoin] fanquake merged pull request #30571: test: [refactor] Use m_rng directly (master...2408-test-rng) https://github.com/bitcoin/bitcoin/pull/30571
09:08 < laanwj> we'd quickly run out of build systems to switch to
09:08 < fanquake> i also reckon 2 will be enough to maintain for the next couple year heh
09:09 < laanwj> are we going to keep both of them?
09:09 < hebasto> not in the master branch
09:09 < laanwj> phew 
09:09 < fanquake> nah, but we've gotta keep all the release branches working
09:09 < fanquake> so 28.x release date from 18 months or so
09:10 < fanquake> until we actually don't have autotools
09:10 < laanwj> yes, that makes sense
09:10 < fanquake> 28.x release date *plus 18 months or so
09:10 < laanwj> would be kind of silly to backport the build system switch
09:11 < fanquake> hopefully we wont have to backport too much across the build system boundaries
09:11 < fanquake> no more clean cherry-picking
09:11 < laanwj> at least nothing that changes the set of compiled files too much
09:12 < laanwj> i guess usually bugfixes won't
09:12 < laanwj> maybe softforks ... 😅
09:13 < bitcoin-git> [bitcoin] TheCharlatan opened pull request #30742: kernel: Use spans instead of vectors for passing block headers to validation functions (master...headersSpan) https://github.com/bitcoin/bitcoin/pull/30742
09:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d184fc3ba411...4ee1940e849e
09:33 < bitcoin-git> bitcoin/master 7ee5c3c Lőrinc: Fix a few likely documentation typos
09:33 < bitcoin-git> bitcoin/master 4ee1940 merge-script: Merge bitcoin/bitcoin#30734: doc: fix a few likely documentation typos rel...
09:33 < bitcoin-git> [bitcoin] fanquake merged pull request #30734: doc: fix a few likely documentation typos related to CMake migration (master...l0rinc/log-typo) https://github.com/bitcoin/bitcoin/pull/30734
09:43 < bitcoin-git> [bitcoin] fanquake opened pull request #30743: depends: build libevent with `-D_GNU_SOURCE` (master...libevent_non_gnu_c) https://github.com/bitcoin/bitcoin/pull/30743
10:22 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:33 < _aj_> laanwj: if we just have a long delay between lock-in and activation like with taproot, no need for sf backports
10:37 < laanwj> aj: true, good point
11:10 -!- mcey_ [~emcy@85.255.234.171] has joined #bitcoin-core-dev
11:13 -!- mcey [~emcy@148.252.128.43] has quit [Ping timeout: 255 seconds]
11:40 -!- anrichp [~anrichp@2a02:8012:2090:0:ea5e:375c:954f:2979] has joined #bitcoin-core-dev
11:41 -!- anrichp [~anrichp@2a02:8012:2090:0:ea5e:375c:954f:2979] has quit [Remote host closed the connection]
11:41 < achow101> 28.0rc1 bins are up
11:41 -!- cncr04s [~cncr04s@ns1.afxr.net] has joined #bitcoin-core-dev
11:42 -!- cncr04s_ [~cncr04s@ns1.afxr.net] has quit [Read error: Connection reset by peer]
11:50 -!- cncr04s [~cncr04s@ns1.afxr.net] has quit [Quit: See you real soon!]
12:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:30 -!- cncr04s [cnc@afxr.net] has joined #bitcoin-core-dev
12:57 < bitcoin-git> [bitcoin] l0rinc closed pull request #30619: doc: Change `nproc` in docs to `getconf _NPROCESSORS_ONLN` (master...paplorinc/nproc) https://github.com/bitcoin/bitcoin/pull/30619
13:05 < bitcoin-git> [bitcoin] hebasto opened pull request #30744: doc: Fix typo in `build-unix.md` (master...240828-typo) https://github.com/bitcoin/bitcoin/pull/30744
13:08 < sdaftuar> cmake looks awesome so far -- nice work everyone.  just experienced the joys of having separate build directories for fuzzing versus running other tests! :)
13:10 < hebasto> sdaftuar: thanks
13:18 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
13:18 -!- dermoth [~dermoth@user/dermoth] has quit [Remote host closed the connection]
13:23 -!- dermoth_ is now known as dermoth
13:25 < achow101> Is there an easy way to turn on every WITH_ option that doesn't require writing them all out?
13:37 < TheCharlatan> you could contribute a preset?
13:43 -!- Guest36 [~Guest36@2607:fb90:3fda:4b42:3825:62ff:fe5e:a38e] has joined #bitcoin-core-dev
13:53 -!- Guest36 [~Guest36@2607:fb90:3fda:4b42:3825:62ff:fe5e:a38e] has quit [Ping timeout: 256 seconds]
14:26 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has quit [Quit: Ping timeout (120 seconds)]
14:27 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
14:29 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev
14:33 -!- S3RK_ [~S3RK@user/s3rk] has quit [Ping timeout: 272 seconds]
14:37 < instagibbs> sdaftuar similarly, having debug builds right alongside release, and no need to disable asm for fuzz debug anymore, so good 👍
15:13 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:24 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.1]
15:26 < achow101> eh? we've had out of tree builds for a while
15:33 < sdaftuar> achow101: I don't believe it worked to run the tests (maybe the functional tests specifically?) in out of tree builds -- or at least if it did, i could never figure out how
15:34 < achow101> sdaftuar: you could with test_runner.py and specifying the test as an argument
15:36 < sdaftuar> 🤷
15:41 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
15:43 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
16:21 -!- toys [~toys@user/toys] has joined #bitcoin-core-dev
16:53 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:06 -!- jlest [~jlest@2804:7f1:eb00:cf36:2af3:4066:f002:b65a] has joined #bitcoin-core-dev
17:06 -!- jlest [~jlest@user/jlest] has changed host
17:22 -!- jlest [~jlest@user/jlest] has quit [Ping timeout: 246 seconds]
17:54 -!- twistedline [~bitcoin@c-73-172-209-62.hsd1.md.comcast.net] has quit []
18:14 -!- lbia [~lbia@user/lbia] has quit [Quit: lbia]
18:52 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
19:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:dde1:46d2:9082:9f54] has quit [Ping timeout: 260 seconds]
19:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:18bc:7a7e:4a16:a7ea] has joined #bitcoin-core-dev
19:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:18bc:7a7e:4a16:a7ea] has quit [Ping timeout: 260 seconds]
19:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:18bc:7a7e:4a16:a7ea] has joined #bitcoin-core-dev
19:49 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
19:58 -!- flag [~flag@81.56.89.175] has quit [Ping timeout: 255 seconds]
20:00 -!- flag [~flag@81.56.89.175] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
22:01 -!- mcey_ [~emcy@85.255.234.171] has quit [Remote host closed the connection]
22:01 -!- mcey_ [~emcy@85.255.234.171] has joined #bitcoin-core-dev
22:05 < maflcko> Looks like a rebase on top of cmake *has* to be done before every push to a pull request, otherwise the GHA CI will be failing.
22:06 < maflcko> The reason is that the "test each commit" task is using the cmake invocation, but it is running on the non-rebased commits, which may be lacking CMakeLists.txt
22:07 < maflcko> but doing a rebase should be harmless and may otherwise be useful anyway
22:25 < maflcko> I've removed the "Needs CMake port" label from pull requests that fail CI or otherwise need a rebase. The CI failure should be self-explanatory.
22:27 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
22:35 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
23:22 -!- dermoth [~dermoth@user/dermoth] has quit [Read error: Connection reset by peer]
23:26 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
23:37 < bitcoin-git> [bitcoin] l0rinc closed pull request #29847: test: add a few more base32/64 calculation corner cases (master...paplorinc/base-32-64-padding-simplification) https://github.com/bitcoin/bitcoin/pull/29847
23:58 < bitcoin-git> [bitcoin] l0rinc opened pull request #30746: Add base32 and base64 roundtrip random padding tests (master...l0rinc/roundtrip-tests-base32-base64) https://github.com/bitcoin/bitcoin/pull/30746
--- Log closed Thu Aug 29 00:00:36 2024