--- Log opened Thu Aug 29 00:00:36 2024
00:16 < maflcko> Looks like "make --keep-going" now aborts early in cmake, whereas previously it really did try to compile everything 
00:18 < maflcko> This makes code search and static analysis using a compiler harder
00:47 < TheCharlatan> maflcko I think the recommendation is to use cmake instead of make and passing any arguments you would normally give make after `--` to cmake.
00:47 < fanquake> instagibbs: why did you need to disable asm? Sounds like something that should be fixed (not sure how CMake would have fixed your compiler)
00:48 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:48 < maflcko> TheCharlatan: I know. I was trying to say the the "-k" behavior changed. I used "cmake --build ./bld-cmake --parallel $( nproc ) --  --keep-going"
00:50 < maflcko> For example, if libtest_util can not be compiled, cmake aborts early, whereas autotools compiled everything else as well.
01:01 < TheCharlatan> ah, I see, looks like any dependents on the library won't be built. I was previously checking a broken bitcoind.cpp, which would still allow the tests to compile with `--keep-going`
01:01 < bitcoin-git> [bitcoin] maflcko opened pull request #30748:  test: Pin and document TEST_DIR_PATH_ELEMENT, SeedRand::FIXED_SEED (master...2408-test) https://github.com/bitcoin/bitcoin/pull/30748
01:34 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4ee1940e849e...4ae3be772d06
01:34 < bitcoin-git> bitcoin/master e78551b Hennadii Stepanov: doc: Fix typo in `build-unix.md`
01:34 < bitcoin-git> bitcoin/master 4ae3be7 merge-script: Merge bitcoin/bitcoin#30744: doc: Fix typo in `build-unix.md`
01:34 < bitcoin-git> [bitcoin] fanquake merged pull request #30744: doc: Fix typo in `build-unix.md` (master...240828-typo) https://github.com/bitcoin/bitcoin/pull/30744
01:36 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4ae3be772d06...0e0de9484600
01:36 < bitcoin-git> bitcoin/master f9a08f3 Lőrinc: doc: fix a few simple codespell warnings
01:36 < bitcoin-git> bitcoin/master 837fbca Lőrinc: Update spelling.ignore-words
01:36 < bitcoin-git> bitcoin/master 0e0de94 merge-script: Merge bitcoin/bitcoin#30700: doc: fix CI codespell warnings
01:36 < bitcoin-git> [bitcoin] fanquake merged pull request #30700: doc: fix CI codespell warnings (master...l0rinc/lint-typos) https://github.com/bitcoin/bitcoin/pull/30700
01:53 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
01:59 -!- dermoth [~dermoth@user/dermoth] has quit [Read error: Connection reset by peer]
02:03 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
02:07 -!- dermoth [~dermoth@user/dermoth] has quit [Read error: Connection reset by peer]
02:11 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
02:23 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e0de9484600...00ad716c2b6a
02:23 < bitcoin-git> bitcoin/master fa80d39 MarcoFalke: ci: Re-add configs removed in cmake migration
02:23 < bitcoin-git> bitcoin/master 00ad716 merge-script: Merge bitcoin/bitcoin#30740: ci: Re-add configs removed in cmake migration
02:23 < bitcoin-git> [bitcoin] fanquake merged pull request #30740: ci: Re-add configs removed in cmake migration (master...2408-ci-cmake) https://github.com/bitcoin/bitcoin/pull/30740
02:24 < bitcoin-git> [bitcoin] fanquake opened pull request #30749: Remove bsdmainutils from doc/ci (master...no_bsd_main_utils) https://github.com/bitcoin/bitcoin/pull/30749
02:34 < bitcoin-git> [bitcoin] maflcko opened pull request #30750:  scripted-diff: LogPrint - LogDebug  (master...2408-log) https://github.com/bitcoin/bitcoin/pull/30750
02:40 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
02:45 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
02:45 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
02:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00ad716c2b6a...8f761ea742e6
02:53 < bitcoin-git> bitcoin/master 7de0c99 fanquake: doc: update dev note examples for CMake
02:53 < bitcoin-git> bitcoin/master 8f761ea merge-script: Merge bitcoin/bitcoin#30739: doc: update dev note examples for CMake
02:53 < bitcoin-git> [bitcoin] fanquake merged pull request #30739: doc: update dev note examples for CMake (master...dev_notes_cmake) https://github.com/bitcoin/bitcoin/pull/30739
02:54 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8f761ea742e6...d08bedd81f18
02:54 < bitcoin-git> bitcoin/master fa053ab MarcoFalke: build: Add Centos Stream 9 EOL URL
02:54 < bitcoin-git> bitcoin/master fac587e MarcoFalke: ci: Use C++23 once for testing
02:54 < bitcoin-git> bitcoin/master d08bedd merge-script: Merge bitcoin/bitcoin#30735: ci: Use C++23 in one task
02:54 < bitcoin-git> [bitcoin] fanquake merged pull request #30735: ci: Use C++23 in one task (master...2408-23) https://github.com/bitcoin/bitcoin/pull/30735
03:31 -!- deborah59 [~deborah@2600:387:f:7431::6] has joined #bitcoin-core-dev
03:33 -!- deborah59 [~deborah@2600:387:f:7431::6] has quit [Client Quit]
03:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d08bedd81f18...7a226eb4d97b
03:40 < bitcoin-git> bitcoin/master c7fb80a Hennadii Stepanov: guix: Drop unused module from manifest
03:40 < bitcoin-git> bitcoin/master 7a226eb merge-script: Merge bitcoin/bitcoin#30653: guix: Drop unused module from manifest
03:40 < bitcoin-git> [bitcoin] fanquake merged pull request #30653: guix: Drop unused module from manifest (master...240814-guix-gnu) https://github.com/bitcoin/bitcoin/pull/30653
03:52 < bitcoin-git> [bitcoin] hebasto opened pull request #30752: guix: Drop unused autotools packages (master...240829-guix-clean) https://github.com/bitcoin/bitcoin/pull/30752
04:02 -!- toys [~toys@user/toys] has left #bitcoin-core-dev [WeeChat 4.4.1]
04:30 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7a226eb4d97b...5c7d4b9dec79
04:30 < bitcoin-git> bitcoin/master 36ff336 fanquake: ci: remove bsdmainutils
04:30 < bitcoin-git> bitcoin/master a2b1d2c fanquake: doc: remove bsdmainutils
04:30 < bitcoin-git> bitcoin/master 78358ce fanquake: ci: add libzmq3-dev to test-each-commit job
04:30 < bitcoin-git> [bitcoin] fanquake merged pull request #30749: Remove bsdmainutils from doc/ci (master...no_bsd_main_utils) https://github.com/bitcoin/bitcoin/pull/30749
04:37 -!- jlest [~jlest@user/jlest] has joined #bitcoin-core-dev
04:52 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:53 -!- jlest [~jlest@user/jlest] has quit [Ping timeout: 248 seconds]
05:12 < instagibbs> fanquake autotool's based builds seemed to require it (asked here a long time ago on how to avoid issues), cmake based doesn't need it 🤷
05:13 < instagibbs> one less problem, I am not complaining
05:35 < fanquake> instagibbs: if that's true then there's a bug in the cmake build
05:36 < fanquake> i.e you're no-longer actually getting asm, when you should be, thus no-longer need to disable it to work around the compilation issue
05:38 < fanquake> if you care enough you could retry 28.x, without --disable-asm, and see if it still fails
05:39 < fanquake> possible you were hitting #29801, which got fixed
05:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/29801 | Compilation failure with `-O0` + `-fsanitize=address` due to inline asm · Issue #29801 · bitcoin/bitcoin · GitHub
05:49 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
05:54 < fanquake> If anyone happened to "guix pull" yesterday, and your guix is now segfaulting, "guix pull --roll-back" and then a "guix pull" should fix your guix
06:16 < bitcoin-git> [bitcoin] hebasto opened pull request #30753: build: Drop no longer needed workaround (master...240829-zmg-mingw) https://github.com/bitcoin/bitcoin/pull/30753
06:16 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:16 < instagibbs> fanquake ok looks like an old issue that must have been fixed since April 
06:17 < fanquake> huge
06:18 < instagibbs> looks like my complaining paid off 🚀
06:43 -!- midnight [~midnight@user/midnight] has quit [Quit: quit]
06:43 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev
07:00 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
07:00 < Murch[m]> hi
07:00 < achow101> #startmeeting
07:00 < TheCharlatan> hi
07:00 < theStack> hi
07:00 < fjahr> hi
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < brunoerg> hi
07:00 < furszy> hi
07:01 < virtu> hi
07:01 < willcl-ark> hi
07:01 < lightlike> Hi
07:01 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
07:01 < hebasto> hi
07:01 < instagibbs> hi
07:02 < achow101> #topic 28.0 release priorities
07:02 < achow101> 28.0rc1 was posted yesterday. please test
07:02 < achow101> any prs that should be backported yet?
07:02 < fanquake> #30743
07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/30743 | depends: build libevent with `-D_GNU_SOURCE` by fanquake · Pull Request #30743 · bitcoin/bitcoin · GitHub
07:03 < fanquake> building depends on alpine and similar is broken, so this'll need to go in
07:03 < theStack> #30714, if anyone out there uses TestShell
07:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/30714 | test: fix `TestShell` initialization (late follow-up for #30463) by theStack · Pull Request #30714 · bitcoin/bitcoin · GitHub
07:04 < fanquake> also need to fix #30751 in some way, otherwise builds with new clang and old boost are broken
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30751 | build: Boost 1.74.0 incompatible with Clang 18 · Issue #30751 · bitcoin/bitcoin · GitHub
07:04 < achow101> theStack: added to the milestone
07:04 < fanquake> looks like clang 18 with boost < 1.81.0, which is annoying, because debian stable and similar ships with 1.76 etc
07:04 < furszy> probably #30684. To v28 and previous releases. 
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30684 | init: fix init fatal error on invalid negated option value by furszy · Pull Request #30684 · bitcoin/bitcoin · GitHub
07:05 < fanquake> not sure about that, given it's a real edgecase, and nobody has ever reported it
07:05 < achow101> fanquake: boost issues aren't really our problem? unless we're requiring clang 18?
07:06 < fanquake> achow101: they are if we claim to support 1.73+
07:06 < fanquake> and if the boost libs shipped on the distro don't work with the default compiler
07:06 < fanquake> unless we are telling everyone to use depends
07:07 < achow101> hmm ok
07:07 < Sjors[m]11> hi
07:08 < achow101> furszy: since that is
07:08 < fanquake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft - please contribute anything missing to the release note
07:08 < hebasto> debian stable default clang is 14 
07:08 < achow101> since that issue has existed for a while, I think it's fine to skip for this release
07:08 < achow101> (based entirely on looking at the title)
07:09 -!- Guest40 [~Guest40@2401:4900:51f7:7237:568:1443:c04d:536e] has joined #bitcoin-core-dev
07:09 < furszy> sure, np there.
07:10 < achow101> #topic Ad-hoc high priority for review
07:10 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:10 < achow101> i guess everything needs rebase now because of cmake
07:10 < jonatack> hi
07:10 < fjahr> #28792 for me, rebased already
07:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/28792 | Embed default ASMap as binary dump header file by fjahr · Pull Request #28792 · bitcoin/bitcoin · GitHub
07:11 < fanquake> my suggestion during rebasing would be to drop any autotools changes, unless you just want to rebase again
07:11 < fanquake> or force everyone to review two sets of the same change
07:11 < fjahr> editing some stuff on the build system too so interested in feedback from competent reviewers ;)
07:12 < Sjors[m]11> What's the ETA for kill autotools?
07:12 < achow101> also, i guess if people don't rebase their stuff soon, those prs are gonna be closed
07:12 < Sjors[m]11> Or does it not matter if you merge something that doesn't work with it?
07:12 < cfields> hi
07:12 < fanquake> what do you mean not work with? Nothing like that will be merged
07:12 < fanquake> autotools is going to be entirely removed very soon
07:12 < fanquake> CI is only using cmake, guix is only using cmake etc
07:13 < fanquake> so anything doing stuff in autotools wont even be tested properly at this point
07:13 < fjahr> I kept the autotools stuff in so far, I felt like for me it would be easier to review both side by side but I am happy to remove it if that is the policy we want to follow generally
07:13 < Sjors[m]11> E.g. #30409 adds a header, so it touches Makefile.am. 
07:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/30409 | Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block by Sjors · Pull Request #30409 · bitcoin/bitcoin · GitHub
07:13 < Sjors[m]11> I can drop that, but then if it's merged before autotools goes away, it won't compile.
07:13 < fjahr> (easier to review as a cmake noob)
07:14 < Sjors[m]11> My other PRs are probably not getting merged before that time anyway, so I made them cmake-only.
07:14 < fanquake> Sjors I don't understand. Just make the change in cmake, and drop the autotools parts
07:14 < fanquake> everything will compile fine, regardless of if autotools exists or not
07:14 < fanquake> and then you don't have to worry about when it's removed
07:14 < fanquake> and your changes will be tested in the CI
07:15 -!- Guest40 [~Guest40@2401:4900:51f7:7237:568:1443:c04d:536e] has quit [Quit: Client closed]
07:15 < cfields> Any reason not to nuke autotools today? To moot this conversation entirely?
07:15 < fanquake> cfields: that would be my preference, so we don't waste time with all this, but cmake is still lacking working features, like coverage, so it's a little bit of a blocker
07:16 < cfields> We discussed exactly this issue for exactly this reason and came to the conclusion that (at the very least) configure.ac+Makefile.* should be removed asap.
07:16 < cfields> Seems we can live without coverage for a few days?
07:17 < maflcko> Can I plz haz 24 more hours?
07:17 < fanquake> I would have preferred to at least have a change ready for review / testing, but it's not clear who is working on it
07:17 < maflcko> fanquake: I think the change is there, but no current acks
07:17 < fanquake> is there a pr in bitcoin/bitcoin?
07:17 < maflcko> I'll try to review it later today or tomorrow
07:18 < cfields> maflcko: for coverage? or something else?
07:18 < maflcko> fanquake: it is #30664 
07:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/30664 | build: Remove Autotools-based build system by hebasto · Pull Request #30664 · bitcoin/bitcoin · GitHub
07:18 < fanquake> How does that fix coverage?
07:19 < maflcko> fanquake: I don't want to block something, based on missing coverage reports
07:19 < fanquake> Ok. I'm very happy to merge that by EOD tomorrow, if no other blockers come up
07:19 < maflcko> cfields: Just so that I can run some legacy scripts without having to modify them to pull an old commit
07:19 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
07:21 < jonatack> end of day tomorrow sgtm
07:21 < cfields> ok
07:22 < achow101> any other topics to discuss?
07:24 < achow101> #endmeeting
07:36 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:38 -!- marcofleon [~marcofleo@82.163.218.33] has joined #bitcoin-core-dev
07:46 < bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5c7d4b9dec79...7349d572c34e
07:46 < bitcoin-git> bitcoin/master 1f4cdb3 Martin Saposnic: Replace custom funding tx creation with MiniWallet.
07:46 < bitcoin-git> bitcoin/master a563f41 Martin Saposnic: Remove second node since only 1 is needed for the test
07:46 < bitcoin-git> bitcoin/master 7349d57 glozow: Merge bitcoin/bitcoin#30701: Use MiniWallet in functional test rpc_signraw...
07:46 < bitcoin-git> [bitcoin] glozow merged pull request #30701: Use MiniWallet in functional test rpc_signrawtransactionwithkey. (master...test-miniwallet-on-rpc-signrawtransactionwithkey) https://github.com/bitcoin/bitcoin/pull/30701
07:48 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7349d572c34e...1e4823870054
07:48 < bitcoin-git> bitcoin/master bd7ce05 Sebastian Falbesoner: test: fix `TestShell` initialization (late follow-up for #30463)
07:48 < bitcoin-git> bitcoin/master 1e48238 glozow: Merge bitcoin/bitcoin#30714: test: fix `TestShell` initialization (late fo...
07:48 < bitcoin-git> [bitcoin] glozow merged pull request #30714: test: fix `TestShell` initialization (late follow-up for #30463) (master...202408-test-fix_testshell_instantiation) https://github.com/bitcoin/bitcoin/pull/30714
07:51 < bitcoin-git> [bitcoin] fanquake opened pull request #30754: misc: Autotools - CMake changes (master...deps_now_cmake) https://github.com/bitcoin/bitcoin/pull/30754
07:55 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Ping timeout: 276 seconds]
07:55 -!- BlueMatt_ [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
07:55 -!- preimage [~halosghos@user/halosghost] has quit [Ping timeout: 276 seconds]
07:56 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
08:02 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
08:07 < bitcoin-git> [bitcoin] fanquake closed pull request #30462: utils: replace boost::date_time usage with c++20 std::chrono (master...nuke-date-time) https://github.com/bitcoin/bitcoin/pull/30462
08:11 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
08:13 < bitcoin-git> [bitcoin] hebasto opened pull request #30755: ci: Add missed configuration options to "Win64 native" job (master...240829-ci-win) https://github.com/bitcoin/bitcoin/pull/30755
08:35 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:17 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
09:25 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
09:33 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
09:34 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1e4823870054...ffdc3d6060f6
09:34 < bitcoin-git> bitcoin/master b02f29e fanquake: doc: replace Autotools with CMake
09:34 < bitcoin-git> bitcoin/master a865494 fanquake: lint: remove autotools packages
09:34 < bitcoin-git> bitcoin/master ffdc3d6 merge-script: Merge bitcoin/bitcoin#30754: misc: Autotools -> CMake changes
09:34 < bitcoin-git> [bitcoin] fanquake merged pull request #30754: misc: Autotools - CMake changes (master...deps_now_cmake) https://github.com/bitcoin/bitcoin/pull/30754
09:38 < sdaftuar> is there anything special we need to do -- such as rerunning cmake -B -- if we add a new functional test?
09:38 < sdaftuar> i ran into an issue with a functional test not appearing in my build directory that I think I eventually fixed by doing that, but i'm not sure if i understand correctly
09:39 < sdaftuar> (this was while i was just rebasing #28676)
09:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
09:40 < instagibbs> worked normally for my PR that adds a functional test
09:42 < sdaftuar> i'll do some experiments maybe...
09:46 < sdaftuar> ok if i copy an existing test to a new file (and add it to test_runner.py for good measure), and then run cmake --build build, it does not appear in the build/ directory. but if i run cmake -B and then cmake --build, it shows up...
09:46 < sdaftuar> so maybe the right thing to do is always run cmake -B first when kicking off a build?
09:46 < instagibbs> oh maybe, I'm running a small script that does that 
09:47 < hebasto> `cmake -B` creates symlinks for test files in source dir to a build tree
09:48 < hebasto> and tests run from the build directory
09:50 < sdaftuar> hebasto: i see, so that means that if a test is changed, we don't need to rerun cmake -B, but if a test is added then we should?
09:50 < hebasto> correct
09:50 < hebasto> I'd say that something like `rm -rf build && cmake -B build` is the safest way 
09:51 < sdaftuar> sounds good, thanks!
09:51 < hebasto> yw
10:12 -!- flag [~flag@81.56.89.175] has quit [Ping timeout: 252 seconds]
10:12 < sdaftuar> am i right in thinking that a commit like https://github.com/bitcoin/bitcoin/pull/28676/commits/ec1b0d53d9eeda8610e2cca2a1cff265891a54af is no longer going to work now that we are using cmake?
10:13 -!- flag [~flag@81.56.89.175] has joined #bitcoin-core-dev
10:46 < maflcko> yes, autotools isn't used for anything anymore in the CI or otherwise, so modifying it will serve no purpose
10:47 < maflcko> The recommendation is to move the autotools modifications to cmake in the pull request
10:47 < maflcko> Not sure where the boost build issue is coming from in your pull request :eyes:
10:48 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:07 -!- marcofleon [~marcofleo@82.163.218.33] has quit [Quit: Connection closed]
11:14 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
11:19 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:24 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
11:32 < bitcoin-git> [qa-assets] maflcko opened pull request #204: Delete nonreduced inputs (main...main) https://github.com/bitcoin-core/qa-assets/pull/204
11:32 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev
11:57 < sdaftuar> maflcko: any idea what the equivalent thing to do would be in the cmake build system? (i also don't understand why the build change was needed but it seemed to work)
11:58 < hebasto> sdaftuar: what is the failure?
11:58 < sdaftuar> hebasto: see eg https://github.com/bitcoin/bitcoin/actions/runs/10618840214/job/29435022797
11:59 < sdaftuar> the commit i linked before seemed to fix the issue for autotools, but now that i'm rebasing i'm trying to figure out how to fix it with cmake
11:59 < hebasto> I'll comment in the PR shortly
11:59 < sdaftuar> however i don't really understand the issue or why the fix works, so if you have a better wya of doing things i'd appreciate it! thanks
12:02 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
12:26 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:32 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving]
12:43 < achow101> what is the equivalent for `make check`?
12:43 < hebasto> `ctest --test-dir build`
12:43 < achow101> that will also build if not built?
12:44 < hebasto> no, it won't
12:44 < achow101> 'make check' was build and test, i'd like to do the same with minimal verbosity
12:45 < hebasto> sdaftuar: your change is correct (I just was waiting finishing my own builds)
12:45 < sdaftuar> ok great, i just decided to guess :) watching the ci now to see if it works (for whatever reason, i can't reproduce the build error i was seeing locally)
12:51 < achow101> how do i make compiler errors and warnings be colorized as they were previously?
12:54 < hebasto> achow101: you could try https://cmake.org/cmake/help/latest/manual/ctest.1.html#build-and-test-mode
12:59 < achow101> seems to be more verbose than chaining cmake --build and ctest
13:00 < achow101> and that's more verbose than 'make check'
13:01 < hebasto> achow101: on Ubuntu 24.04, with systems GCC and CMake, error messages are colorized
13:02 < hebasto> what is your system/compiler ?
13:02 < achow101> arch and gcc
13:03 < hebasto> and cmake version?
13:03 < achow101> 3.30.2
13:05 < hebasto> what if you set `CMAKE_COLOR_DIAGNOSTICS` environment variable to `TRUE`?
13:06 < achow101> no difference
13:11 < bitcoin-git> [bitcoin] luke-jr opened pull request #30756: run_command: Close non-std fds when execing slave processes (master...subproc_closefds) https://github.com/bitcoin/bitcoin/pull/30756
13:16 -!- aleggg [~aleggg@187.112.95.77] has quit [Remote host closed the connection]
13:17 < instagibbs> that option may be pretty new, I don't think my cmake is new enough
13:28 -!- Guest93 [~Guest93@host-78-129-36-41.dynamic.voo.be] has joined #bitcoin-core-dev
13:30 -!- Guest93 [~Guest93@host-78-129-36-41.dynamic.voo.be] has quit [Client Quit]
13:35 < achow101> it looks like building with clang is colorized
13:45 -!- aleggg [~aleggg@187.112.95.77] has joined #bitcoin-core-dev
13:51 -!- Yuvraj [~Yuvraj@117.250.64.129] has joined #bitcoin-core-dev
13:51 -!- Yuvraj [~Yuvraj@117.250.64.129] has quit [Client Quit]
15:05 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
15:48 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
15:49 -!- jarthur [~jarthur@user/jarthur] has quit [Client Quit]
16:24 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.1]
17:23 -!- danielabrozzoni [sid661616@ilkley.irccloud.com] has quit [Read error: Connection reset by peer]
17:23 -!- maxedw_ [sid625334@uxbridge.irccloud.com] has quit [Read error: Connection reset by peer]
17:23 -!- maxedw_ [sid625334@id-625334.uxbridge.irccloud.com] has joined #bitcoin-core-dev
17:23 -!- danielabrozzoni [sid661616@id-661616.ilkley.irccloud.com] has joined #bitcoin-core-dev
17:24 -!- real_or_random [sid554204@user/real-or-random/x-4440763] has quit [Ping timeout: 252 seconds]
17:24 -!- fjahr [sid374480@uxbridge.irccloud.com] has quit [Ping timeout: 252 seconds]
17:27 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #bitcoin-core-dev
17:27 -!- real_or_random [sid554204@user/real-or-random/x-4440763] has joined #bitcoin-core-dev
17:36 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
18:16 -!- jlest [~jlest@user/jlest] has joined #bitcoin-core-dev
18:21 -!- jlest [~jlest@user/jlest] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
22:01 -!- mcey [~emcy@85.255.234.171] has joined #bitcoin-core-dev
22:01 -!- mcey_ [~emcy@85.255.234.171] has quit [Remote host closed the connection]
22:17 -!- Guest92 [~Guest96@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:23 -!- Guest92 [~Guest96@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Quit: Client closed]
22:23 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:37 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Quit: Client closed]
22:38 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:39 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
22:39 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:44 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
22:44 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:47 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
22:49 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:51 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
22:52 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:52 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
22:52 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:53 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
22:53 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
22:58 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Quit: Client closed]
22:59 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:01 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
23:01 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:11 -!- noonien808310429 [~noonien@86.125.147.232] has quit [Ping timeout: 260 seconds]
23:16 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Quit: Client closed]
23:16 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:17 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has left #bitcoin-core-dev []
23:19 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:34 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Quit: Client closed]
23:34 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:39 -!- satoshinakamoto5 [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:40 -!- satoshinakamoto5 [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
23:40 -!- satoshinakamoto1 [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:41 -!- satoshinakamoto1 [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Client Quit]
23:48 < bitcoin-git> [bitcoin] ItsaFugazi opened pull request #30758: Create lost and found (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30758
23:49 < bitcoin-git> [bitcoin] fanquake closed pull request #30758: Create lost and found (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30758
23:49 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has quit [Quit: Client closed]
23:50 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has joined #bitcoin-core-dev
23:56 -!- satoshinakamoto [~satoshina@2a02-8440-d12b-136b-0000-004b-4b04-e701.rev.sfr.net] has left #bitcoin-core-dev []
--- Log closed Fri Aug 30 00:00:37 2024